[00:00:23] Well the combination of "strip out all templates" and "notify people when they are {{ping}}ed" isn't great [00:00:35] See https://phabricator.wikimedia.org/T129531 [00:01:18] (03CR) 10Catrope: [C: 032] thank-you-edit: Only call User::getEditCount() once [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/276556 (owner: 10Catrope) [00:04:54] 3Collaboration-Team-Current, 10MediaWiki-extensions-GuidedTour, 7Technical-Debt: GuidedTour: Remove use of sync XHR - use mw.Api and async for parsing - https://phabricator.wikimedia.org/T46925#2110227 (10Mattflaschen) [00:09:16] So I was thinking perhaps parsing templates but making sure they are rendered as plain text would be better [00:13:07] 3Collaboration-Team-Current, 10Notifications: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2110260 (10jmatazzoni) Responding to Benoit's question: > Knowing some users, I anticipate the question " why don't you use infinite scroll?". My feeling about that is this: Infinit... [00:17:11] (03CR) 10Mooeypoo: Add MobileNotificationsWrapper for Mobile display (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [00:17:41] (03PS11) 10Mooeypoo: Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) [00:18:41] (03Merged) 10jenkins-bot: thank-you-edit: Only call User::getEditCount() once [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/276556 (owner: 10Catrope) [00:19:36] jdlrobson, RoanKattouw I unboomed the commits. [00:19:47] Thanks [00:19:52] I'll look when I'm done deploying [00:20:03] RoanKattouw: if we parse and then strip_tags(), that should render as plain text [00:20:18] Yeah, that's what I thought [00:20:29] That might look weird if you put an infobox template at the start of a comment :D [00:20:37] But it'd probably have good results for {{ping}} [00:20:55] The snippets we use for Flow comments basically do that, although there we have the HTML in storage already so we just grab that and strip tags [00:21:02] Need to look at what stripping it does exaclty [00:23:15] RoanKattouw, htmlToPlaintext in Flow just strips the tags and decodes the entities. Fun fact, strip_tags also removes PHP tags, which is sort of scary, and also probably strips completely valid wikitext unnecessarily. [00:23:31] The "decodes the entities" part is also more complicated than it should be on HHVM (I need to update that patch). [00:23:34] (03CR) 10jenkins-bot: [V: 04-1] Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [00:23:40] Oh right that bug [00:23:46] Although it should basically work now on HHVM since we changed the parameters, so no worries. [00:23:51] Yeah I'll just look at what Flow does and basically make DiscussionParser do that [00:27:14] matt_flaschen: Ahm... help? https://www.mediawiki.org/wiki/Talk:Wikimedia_Engineering/Goals_Proposal [00:27:18] "" [00:27:24] Oh, shit [00:27:26] Content model script, right? [00:28:06] * RoanKattouw reverts [00:28:42] Ah, darn it. I should have dug into the last time we did this more. [00:29:32] RoanKattouw, populateContentModel.php [00:29:40] In core. [00:30:19] Yes, thanks for finding the name [00:30:21] Gonna run that now [00:34:43] I'm going to fix that error message. [00:35:37] Thanks [00:44:21] The last time this happened legoktm proposed an RFC (https://phabricator.wikimedia.org/T105652), which is still necessary since DBAs are not okay with storing the string in all rows (for perf reasons). [00:45:20] I still have that sitting locally uncommitted in my git repo :/ [00:45:25] It's like 50% done [00:46:00] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Roll out cross-wiki notifications beta feature - https://phabricator.wikimedia.org/T124234#2110430 (10Catrope) Deployed: 00:24 logmsgbot: catrope@tin Synchronized wmf-config/InitialiseSettings.php: Enable cross-wiki notificatio... [00:46:25] Yeah I'm only populating mw.org's revision table for odd-numbered namespaces [00:46:29] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10ArchCom-RfC, 10MediaWiki-ContentHandler: RfC: Content model storage - https://phabricator.wikimedia.org/T105652#2110431 (10Mattflaschen) [00:48:19] (03PS5) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [00:49:16] (03PS6) 10Mooeypoo: Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) [00:51:04] Ugh there is a LOT of history for ns3 on mw.org [00:51:08] (User talk namespace) [00:52:48] (03CR) 10Catrope: [C: 04-1] "npm failure is real:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [00:53:54] (03CR) 10Catrope: Add MobileNotificationsWrapper for Mobile display (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [00:57:34] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Use more compact timestamps for notifications - https://phabricator.wikimedia.org/T125970#2110522 (10jmatazzoni) @Etonkovidova points out that the new abbreviations have: > no plural forms - no mos >... [00:57:43] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2110538 (10jmatazzoni) [00:57:45] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Use more compact timestamps for notifications - https://phabricator.wikimedia.org/T125970#2110537 (10jmatazzoni) 5Open>3Resolved [01:04:14] (03CR) 10Catrope: [C: 04-1] Make plural support for large values (100 or more) explicit in l10n (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [01:04:29] (03PS1) 10Mattflaschen: Split flow-action-unsupported into two errors, and add real messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276676 [01:04:32] (03CR) 10Catrope: "Looks good other than the number conversion issue; haven't tested." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [01:08:51] (03CR) 10Catrope: [C: 032] Split flow-action-unsupported into two errors, and add real messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276676 (owner: 10Mattflaschen) [01:14:56] 6Collaboration-Team-Backlog, 10Notifications: Switch from relative to absolute timestamps after a relevant period - https://phabricator.wikimedia.org/T129610#2110674 (10jmatazzoni) [01:15:22] 6Collaboration-Team-Backlog, 10Notifications: Switch from relative to absolute timestamps after a relevant period - https://phabricator.wikimedia.org/T129610#2110690 (10jmatazzoni) [01:19:13] (03Merged) 10jenkins-bot: Split flow-action-unsupported into two errors, and add real messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276676 (owner: 10Mattflaschen) [01:48:53] (03PS1) 10Catrope: Always show a cross-wiki notifications preference, even if the beta feature is disabled [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276683 (https://phabricator.wikimedia.org/T129077) [01:53:14] (03CR) 10jenkins-bot: [V: 04-1] Always show a cross-wiki notifications preference, even if the beta feature is disabled [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276683 (https://phabricator.wikimedia.org/T129077) (owner: 10Catrope) [01:53:16] 6Collaboration-Team-Backlog, 10Notifications, 13Patch-For-Review: Give a way for users to opt-out Cross-wiki Notifications - https://phabricator.wikimedia.org/T129077#2110768 (10Catrope) >>! In T129077#2110756, @gerritbot wrote: > Change 276683 had a related patch set uploaded (by Catrope): > Always show a c... [01:58:08] (03PS1) 10Mooeypoo: [WIP] OOUI'fy the Special Page notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276684 [02:00:55] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Give a way for users to opt-out Cross-wiki Notifications - https://phabricator.wikimedia.org/T129077#2110789 (10Catrope) [02:02:04] (03CR) 10Catrope: [C: 032] Bidi isolate content items in notification header text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276388 (https://phabricator.wikimedia.org/T127407) (owner: 10Mooeypoo) [02:03:11] (03CR) 10jenkins-bot: [V: 04-1] [WIP] OOUI'fy the Special Page notification items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276684 (owner: 10Mooeypoo) [02:07:37] (03CR) 10Catrope: [C: 031] Corresponding changes for Echo 99+ refactoring (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [02:09:03] (03CR) 10jenkins-bot: [V: 04-1] Bidi isolate content items in notification header text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276388 (https://phabricator.wikimedia.org/T127407) (owner: 10Mooeypoo) [02:10:16] (03CR) 10Catrope: [C: 032] "Most ridiculous bogus Jenkins failure so far: /usr/local/bin/npm: No such file or directory" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276388 (https://phabricator.wikimedia.org/T127407) (owner: 10Mooeypoo) [02:21:06] (03Merged) 10jenkins-bot: Bidi isolate content items in notification header text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276388 (https://phabricator.wikimedia.org/T127407) (owner: 10Mooeypoo) [02:48:30] (03PS1) 10Catrope: Unconvolute DiscussionParser::getTextSnippet() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276687 (https://phabricator.wikimedia.org/T129531) [03:02:07] Have a good night, all. [03:30:14] (03PS1) 10Catrope: Remove useless getTextSnippet() call in getContentSnippet() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276692 [03:34:39] (03CR) 10Catrope: [C: 04-1] Corresponding changes for Echo 99+ refactoring (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [03:38:17] (03PS1) 10Catrope: Bidi-embed topic titles in notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276693 (https://phabricator.wikimedia.org/T127407) [03:52:07] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, and 2 others: User names and other content language-y things in notifications should be bidi-isolated - https://phabricator.wikimedia.org/T127407#2110998 (10Catrope) a:5Mooeypoo>3Catrope I went through notifications in extensions... [03:53:49] (03PS1) 10Catrope: Follow-up 9a1defa: fix function name typo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276696 [04:03:57] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), and 3 others: Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2111024 (10Catrope) After deploying this change, all thank-you-edit events still get f... [04:07:29] (03CR) 10Catrope: [C: 032] Only phplint PHP files that actually changed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276497 (owner: 10Mattflaschen) [04:17:16] (03Merged) 10jenkins-bot: Only phplint PHP files that actually changed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276497 (owner: 10Mattflaschen) [04:56:18] (03CR) 10Legoktm: [C: 032] Follow-up 9a1defa: fix function name typo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276696 (owner: 10Catrope) [05:10:27] (03Merged) 10jenkins-bot: Follow-up 9a1defa: fix function name typo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276696 (owner: 10Catrope) [07:18:56] 6Collaboration-Team-Backlog, 10Notifications: Ping users in edit summary - https://phabricator.wikimedia.org/T129572#2111155 (10matej_suchanek) [07:18:59] 6Collaboration-Team-Backlog, 10MediaWiki-Page-editing, 10Notifications: Notify user when username used in an edit summary - https://phabricator.wikimedia.org/T32750#2111156 (10matej_suchanek) [09:25:00] 6Collaboration-Team-Backlog, 10Notifications: Switch from relative to absolute timestamps after a relevant period - https://phabricator.wikimedia.org/T129610#2111230 (10Pginer-WMF) Some considerations (some I mentioned when discussing it for Flow in T111596#1804185 ): - I totally agree with relative timestamps... [09:26:39] 6Collaboration-Team-Backlog, 10Notifications: Switch from relative to absolute timestamps after a relevant period - https://phabricator.wikimedia.org/T129610#2111235 (10Pginer-WMF) [09:26:41] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2111234 (10Pginer-WMF) [09:29:04] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2111236 (10Pginer-WMF) [09:30:12] 6Collaboration-Team-Backlog, 10Notifications: Switch from relative to absolute timestamps after a relevant period - https://phabricator.wikimedia.org/T129610#2110674 (10Pginer-WMF) [09:30:14] 6Collaboration-Team-Backlog, 10Notifications, 7Epic, 7WorkType-NewFunctionality: Better organisation for the Notification System - https://phabricator.wikimedia.org/T114351#2111253 (10Pginer-WMF) [09:30:26] 6Collaboration-Team-Backlog, 10Notifications, 7Epic, 7WorkType-NewFunctionality: Better organisation for the Notification System - https://phabricator.wikimedia.org/T114351#1692643 (10Pginer-WMF) [10:00:16] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 3Liaisons-March-2016: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2088612 (10Qgil) * [[ https://ca.wikipedia.org/wiki/Tema:Szuh7op33vmx5ihu |... [10:26:51] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Allow to mark as read items and groups in the Notification Page - https://phabricator.wikimedia.org/T129460#2111352 (10Trizek-WMF) [10:29:06] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review: Remove double emphasis in UI strings - https://phabricator.wikimedia.org/T128711#2111354 (10Trizek-WMF) I haven't read any feedback concerning bold or quotations. [10:29:26] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Copy-paste a template in wikitext on Flow does not work on visual mode when a space is present before the first brace - https://phabricator.wikimedia.org/T129454#2111357 (10Elitre) I'm in Safari/Mac today and it works even if I copy/paste it from Phab dire... [10:34:50] 6Collaboration-Team-Backlog, 10Notifications, 10Wikidata, 7Need-volunteer, and 2 others: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#2111359 (10Edgars2007) Yes, I would agree with Lydia. We could enable this by default for all... [10:42:31] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review: Remove double emphasis in UI strings - https://phabricator.wikimedia.org/T128711#2111371 (10Pginer-WMF) > At least that way you'd preserve a distinction between the two types of information. As I mentioned above I think quotes may h... [10:44:42] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Copy-paste a template in wikitext on Flow does not work on visual mode when a space is present before the first brace - https://phabricator.wikimedia.org/T129454#2111374 (10Trizek-WMF) I retried it on xubuntu 14.04, Firefox 44 and Chromium 48: * no proble... [11:20:59] 6Collaboration-Team-Backlog, 10Notifications: Partially displayed notification - https://phabricator.wikimedia.org/T129638#2111439 (10Sunpriat) [11:23:50] 6Collaboration-Team-Backlog, 10Notifications: Partially displayed notification - https://phabricator.wikimedia.org/T129638#2111452 (10Sunpriat) [11:27:18] 6Collaboration-Team-Backlog, 10Notifications: Partially displayed notification - https://phabricator.wikimedia.org/T129638#2111470 (10Sunpriat) [11:28:35] 6Collaboration-Team-Backlog, 10Notifications: Partially displayed notification - https://phabricator.wikimedia.org/T129638#2111439 (10Sunpriat) [11:29:32] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review: Remove double emphasis in UI strings - https://phabricator.wikimedia.org/T128711#2111474 (10Pginer-WMF) > I'd want to look at what it would be like to bold the page names only and then use quotation marks for the topic names. I creat... [11:29:35] 6Collaboration-Team-Backlog, 10Notifications: Partially displayed notification - https://phabricator.wikimedia.org/T129638#2111475 (10Sunpriat) [11:57:11] 6Collaboration-Team-Backlog, 10Notifications: BadMethodCallException - https://phabricator.wikimedia.org/T129641#2111502 (10Sunpriat) [11:58:03] 6Collaboration-Team-Backlog, 10MediaWiki-Change-tagging, 10Notifications, 7Easy: Notify user when a tag is added to/removed from their edit - https://phabricator.wikimedia.org/T112119#2111516 (10matej_suchanek) [11:58:05] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2111515 (10matej_suchanek) [12:17:23] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 10Notifications: Notify users about deletion tags being added to pages they created - https://phabricator.wikimedia.org/T123866#2111526 (10matej_suchanek) [12:17:25] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-ContentTranslation, 10Notifications, 5ContentTranslation-Release8, and 2 others: Notify inactive translators that new suggestions are available - https://phabricator.wikimedia.org/T113586#2111527 (10matej_suchanek) [12:17:29] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-ContentTranslation, 10Notifications, 6WMF-Design, 7WorkType-NewFunctionality: Notify that your article has been translated by another user - https://phabricator.wikimedia.org/T88581#2111528 (10matej_suchanek) [12:17:32] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2111525 (10matej_suchanek) [12:22:33] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 10Notifications, 7Documentation: Document whitelist and blacklist options on Flow help page - https://phabricator.wikimedia.org/T129642#2111531 (10Trizek-WMF) [12:22:46] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 10Notifications, 7Documentation: Document whitelist and blacklist options on Flow help page - https://phabricator.wikimedia.org/T129642#2111545 (10Trizek-WMF) p:5Triage>3Low [12:26:58] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 3Liaisons-March-2016: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2111546 (10Trizek-WMF) 5Open>3Resolved [12:27:00] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Roll out cross-wiki notifications beta feature - https://phabricator.wikimedia.org/T124234#2111548 (10Trizek-WMF) [12:31:03] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 10Notifications, 7user-notice: Prepare and review announcements concerning Cross-wiki Notifications as a by-default feature on all wikis - https://phabricator.wikimedia.org/T129643#2111549 (10Trizek-WMF) [12:39:27] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Give a way for users to opt-out Cross-wiki Notifications - https://phabricator.wikimedia.org/T129077#2111569 (10Pginer-WMF) > Thoughts? I think that is a minimal and reasonable way to expose the setting. It can be useful initial step for lear... [13:49:52] 6Collaboration-Team-Backlog, 10Notifications: Echo API: display filtered notification lists based on type - https://phabricator.wikimedia.org/T67361#2111729 (10matej_suchanek) [13:52:04] 6Collaboration-Team-Backlog, 10Metrolook, 10Notifications: Echo doesn't look good in metrolook - https://phabricator.wikimedia.org/T119134#2111743 (10matej_suchanek) [13:55:05] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 10Notifications: Setup cross-wiki notifications in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T119999#2111763 (10matej_suchanek) [13:55:45] 6Collaboration-Team-Backlog, 10Flow: Unhelpful error message on mediawiki.org - https://phabricator.wikimedia.org/T129635#2111764 (10Elitre) It happened in Flow actually, I just assumed it's a message that would occur in any environment. Thanks for your note. [13:56:15] 3Collaboration-Team-Current, 10Notifications: Instrument opening of cross-wiki notification GroupItems - https://phabricator.wikimedia.org/T121945#2111768 (10matej_suchanek) [13:58:35] 6Collaboration-Team-Backlog, 10Notifications: Notifications page HTML markup - https://phabricator.wikimedia.org/T51269#2111772 (10matej_suchanek) [14:03:05] 6Collaboration-Team-Backlog, 10Flow: Unhelpful error message on mediawiki.org - https://phabricator.wikimedia.org/T129635#2111774 (10Aklapper) Seems to come from #Flow: ``` $:canis\> grep -r "you still get this error" . ./mediawiki-extensions-Flow/i18n/en.json: "flow-error-parsoid-failure" ``` [14:24:10] 6Collaboration-Team-Backlog, 10Flow: flow-error-parsoid-failure message is unhelpful, does not explain where/how to file a bug - https://phabricator.wikimedia.org/T129635#2111815 (10Krenair) [15:00:19] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on current no-JS version of Special:Notifications - https://phabricator.wikimedia.org/T115528#2111871 (10Pginer-WMF) > I hope that makes more sense? Yes. Thanks @Mooeypoo for all the detai... [16:17:29] 6Collaboration-Team-Backlog, 10Notifications: Not all notifications displayed - https://phabricator.wikimedia.org/T129638#2111989 (10Mattflaschen) [16:23:41] 6Collaboration-Team-Backlog, 10Notifications: Not all notifications displayed - https://phabricator.wikimedia.org/T129638#2111439 (10Mattflaschen) There is a cap on the number of notifications (2000). However, date should not matter. Also, I don't know why the oldest notification would go backwards from 2016... [16:24:04] 6Collaboration-Team-Backlog, 10Notifications: Not all notifications displayed; oldest notification fluctuates - https://phabricator.wikimedia.org/T129638#2112015 (10Mattflaschen) [16:34:20] 6Collaboration-Team-Backlog, 10Notifications: BadMethodCallException in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129641#2112017 (10Mattflaschen) [16:34:29] 3Collaboration-Team-Current, 10Notifications: BadMethodCallException in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129641#2111502 (10Mattflaschen) [16:50:05] 3Collaboration-Team-Current, 10Notifications: BadMethodCallException in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129641#2112037 (10Mattflaschen) a:3Mattflaschen [17:20:13] (03CR) 10Sbisson: [C: 032] Clean up some code in EchoEmailBatch [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276044 (owner: 10Legoktm) [17:31:57] (03Merged) 10jenkins-bot: Clean up some code in EchoEmailBatch [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276044 (owner: 10Legoktm) [17:49:49] 6Collaboration-Team-Backlog, 10Notifications: Missing first letter in article name in notification - https://phabricator.wikimedia.org/T129663#2112183 (10Ijon) [18:38:47] RoanKattouw, looking at the edit count thing, could it be slave lag? The new edit should be fully saved and count incremented by the time it runs, but getEditCount always populates from slave. [18:39:17] RoanKattouw, maybe add a parameter to getEditCount to allow populating from master (it will only happen in response to a POST if we think they might have triggered a threshold, so not too many master queries). [18:39:36] Yes, it's slave lag most likely [18:39:38] However [18:39:44] Read getEditCount and look at how it has an in-process cache [18:40:05] That should convince you that calling it twice and getting different results should be impossible [18:40:11] And yet that's what we observed [18:43:55] RoanKattouw, yeah, I can't explain the previous "if they're different, log the problem, but the log says they're the same" issue (unless it was a type issue but I think you said you checked that?). [18:44:23] Yeah well and also the logs changed after we changed the code [18:44:30] is called firrst in the request and second in a deferred update? is it possible that a commit happens between the two? [18:44:31] From "10 should be 10" to "10 should be 9" [18:44:47] I don't think that's what's happening [18:44:51] Lemme find a diff to link to [18:45:24] https://gerrit.wikimedia.org/r/#/c/276080/1/Hooks.php [18:45:27] stephanebisson, yeah, a commit is supposed to happen before the deferred runs. The code is supposed to take that into account. [18:45:34] That diff changed the behavior from "10 should be 10" to "10 should be 9" [18:45:44] And that seems impossible/mysterious/haunted, but maybe I'm missing something [18:46:04] One thing I think it suspect is that there are two $user variables, one shadowing the other, but that'd still mean we'd be dealing with a PHP bug [18:46:33] RoanKattouw, wait, what changed? I just see renames, plus not calling a method twice? [18:46:39] In the old code, lines 468 and 477 call $user->getEditCount() and evidently the first one got 9 and the second one got 10 [18:47:05] Which seems impossible because 1) there's no async-ness between those two and 2) that method caches its return value [18:47:08] matt_flaschen: Exactly [18:48:51] RoanKattouw, oh, were you replying to stephanebisson with "I don't thikn that's what's happening", or what I said about the prior logging? [18:49:10] To Stephane [18:49:14] RoanKattouw, oh, okay. [18:49:23] Specifically his "commit happens between the two" theory [18:49:37] RoanKattouw, isn't that right, though? There is a commit at the end of the request, before the deferred runs. [18:49:43] Well yes [18:49:46] But it's meant to take that into account. [18:49:48] can getEditCount() already include the edit that is about to be commited? [18:49:56] But the two calls with different values both occur inside the deferred callback [18:50:08] (or occurred, I should say, because we changed that code) [18:50:25] It does seem like the new edit count is not yet queryable from a slave at the time the deferred update runs [18:50:30] stephanebisson, I don't think it's supposed to since incEditCount runs onTransactionPreCommitOrIdle , but don't know exactly when that runs. [18:50:38] And very consistently so because every single log entry is a race condition entry, there are no success entries in the log [18:51:04] And yes, not sure what the ordering is between onTransactionPreCommitOrIdle vs DeferredUpdate although intuitively you'd expect the latter to run later [18:51:11] However, with slave lag it might not be later enough [18:51:44] One thing I'm wondering is if there is a facility for "run this after my writes are queryable from a slave" and/or if that'd be a good facility to add [18:52:10] Otherwise, perhaps we should just query the edit count from the master in our deferred update; we're possibly going to write anyway [18:52:38] If PreCommitOrIdle runs earlier than expected, it might already include the edit count like stephanebisson said. [18:52:41] However, none of that explains the different return value stuff, and that part still makes me feel like I saw a ghost [18:53:05] RoanKattouw, plus, the user is not waiting in the DeferredUpdate, and it can only trigger in response to a user POST, so shouldn't be a big deal to query master. [18:53:25] Yeah [18:53:46] RoanKattouw, also, the fix introduced a message bug, which I saw locally. Fix coming. [18:53:59] Huh? [18:54:02] * RoanKattouw awaits patch [18:54:44] RoanKattouw, 497 of the patch. Over-zealous find-replace. [18:55:03] I'll also add back-compat. [18:55:06] Oh! Well shit [18:55:20] matt_flaschen: No need for b/c because we can easily prove there are no such events [18:55:37] Like, there are no "Thanking user for their Nth edit" log entries in that timespan [18:55:39] Okay, if you checked in prod, then no need. [19:00:05] (03PS1) 10Mattflaschen: thank-you-edit: canRender for deleted page and extra fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276788 (https://phabricator.wikimedia.org/T129641) [19:01:58] (03CR) 10Catrope: [C: 032] thank-you-edit: canRender for deleted page and extra fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276788 (https://phabricator.wikimedia.org/T129641) (owner: 10Mattflaschen) [19:04:42] (03CR) 10jenkins-bot: [V: 04-1] thank-you-edit: canRender for deleted page and extra fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276788 (https://phabricator.wikimedia.org/T129641) (owner: 10Mattflaschen) [19:08:02] Verified that the most recent thank-you-edit event in the DB is just after midnight UTC on March 8 [19:12:01] (03Merged) 10jenkins-bot: thank-you-edit: canRender for deleted page and extra fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276788 (https://phabricator.wikimedia.org/T129641) (owner: 10Mattflaschen) [19:15:07] RoanKattouw: everything is consistently off by one? [19:15:20] Yes [19:15:34] Lemme confirm that again with the current logs, but last I looked yes [19:16:21] is that something we can depend upon? [19:16:54] like, stick another +1 in there and call it done? or does that put us back in the same hole? [19:23:46] Hmm not all of them! [19:24:01] There are still some "should have had 1 but has 1" rows [19:24:06] Lemme get some counts going [19:26:05] catrope@fluorine:/a/mw-log$ cat Echo.log | cut -d '{' -f 2 | cut -d ',' -f 3-4 | sort | uniq -c | sort -n [19:26:07] 1 "expectedCount":100,"actualCount":100} [19:26:08] 2 "expectedCount":10000,"actualCount":9999} [19:26:10] 2 "expectedCount":1000,"actualCount":999} [19:26:11] 6 "expectedCount":10,"actualCount":10} [19:26:13] 12 "expectedCount":100,"actualCount":99} [19:26:15] 25 "expectedCount":1,"actualCount":1} [19:26:16] 136 "expectedCount":10,"actualCount":9} [19:26:18] 808 "expectedCount":1,"actualCount":0} [19:26:28] 3Collaboration-Team-Current: Notification titles should differentiate subpages of the talk page - https://phabricator.wikimedia.org/T129686#2112745 (10Mooeypoo) [19:26:59] So it's not reliably off by one AND we now have the even more impossible-seeming case of 10 !== 10 [19:27:31] We could change !== to != I guess [19:27:35] But...WTF [19:28:35] Also, how hard would it be to change thank-you-edit -> 'milestone' or 'edit-threshold'? [19:28:40] Yes, let's [19:28:51] After we fix it :) [19:29:01] Or maybe now, actually, since we aren't recording new ones anyway [19:29:11] I mean, right now everything in the db can safely be deleted so... [19:29:46] Exactly [19:29:48] Or renamed [19:30:55] (03PS1) 10Legoktm: thank-you-edit: Cast counts as integers before comparing [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276793 [19:30:55] \o/ [19:31:31] (03CR) 10Catrope: [C: 032] thank-you-edit: Cast counts as integers before comparing [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276793 (owner: 10Legoktm) [19:31:39] Not that I have much faith after all the weirdness we're seeing, but +2 [19:33:11] jmatazzoni__: can I put what you said in standup ("Aren't we doing this because James said it would be easy?") on https://tools.wmflabs.org/bash/ [19:33:16] ? [19:37:35] RoanKattouw, quiddity: 'milestone' or 'edit-threshold'? [19:38:26] the php class is currently called 'EchoEditThresholdPresentationModel' [19:39:07] (03CR) 10jenkins-bot: [V: 04-1] thank-you-edit: Cast counts as integers before comparing [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276793 (owner: 10Legoktm) [19:39:42] wtf [19:40:30] 6Collaboration-Team-Backlog, 10Notifications: Missing first letter in article name in notification - https://phabricator.wikimedia.org/T129663#2112836 (10Ijon) Caused by inappropriate use of GRAMMAR in the translated message. The message here: https://he.wikipedia.org/w/index.php?title=%D7%9E%D7%93%D7%99%D7%9... [19:41:22] (03CR) 10Legoktm: [C: 032] thank-you-edit: Cast counts as integers before comparing [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276793 (owner: 10Legoktm) [19:47:42] 6Collaboration-Team-Backlog, 10Notifications: Missing first letter in article name in notification - https://phabricator.wikimedia.org/T129663#2112183 (10Catrope) Caused by an [[https://translatewiki.net/w/i.php?title=MediaWiki:Notification-header-page-linked/he&diff=prev&oldid=6624194|edit on TranslateWiki]]... [19:48:01] 6Collaboration-Team-Backlog, 10WikiLove: [edit] link in WikiLove preview screen causes data loss - https://phabricator.wikimedia.org/T129692#2112870 (10Peteforsyth) [19:50:04] 6Collaboration-Team-Backlog, 10Notifications: Missing first letter in article name in notification - https://phabricator.wikimedia.org/T129663#2112883 (10Ijon) Fixed the string on Translatewiki. [19:52:13] 6Collaboration-Team-Backlog, 10WikiLove: [edit] link in WikiLove preview screen causes data loss - https://phabricator.wikimedia.org/T129692#2112870 (10Legoktm) It would be trivial for us to suppress the edit section links so people don't accidentally click on it, but what you really want is a way to get the w... [19:56:36] etonkovidova, any luck with Vagrant? [19:57:51] 6Collaboration-Team-Backlog, 10WikiLove: [edit] link in WikiLove preview screen causes data loss - https://phabricator.wikimedia.org/T129692#2112920 (10Peteforsyth) I see three possible outcomes, any of which would be good. The first, I think, is ideal: (1) Make the [edit] button take you to a manual entry mo... [19:59:56] (03PS2) 10Catrope: Always show a cross-wiki notifications preference, even if the beta feature is disabled [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276683 (https://phabricator.wikimedia.org/T129077) [20:00:02] (03Merged) 10jenkins-bot: thank-you-edit: Cast counts as integers before comparing [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276793 (owner: 10Legoktm) [20:00:56] 6Collaboration-Team-Backlog, 10Notifications, 7Design, 7WorkType-NewFunctionality: Define Cross-wiki Notifications settings - https://phabricator.wikimedia.org/T117670#2112926 (10Nizil) [[File:Screenshot crosswiki idea1.png|thumb|screenshot crosswiki idea1|500px]] This is my rough idea of "control panel".... [20:01:42] (03PS12) 10Mooeypoo: Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) [20:02:47] mooeypoo: https://gerrit.wikimedia.org/r/274342 [20:06:41] (03CR) 10jenkins-bot: [V: 04-1] Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [20:11:23] matt_flaschen: was not looking at vagrant :( busy with iOS mobile app. Will look later in the day [20:29:53] legoktm, either fine by me. [20:30:40] bd808, is HHVM working for you? [20:30:42] I get: [20:30:44] [Fri Mar 11 20:30:23 2016] [hphp] [9645:7fb74bf20100:0:000001] [] Uncaught exception: Could not open extension /usr/lib/x86_64-linux-gnu/hhvm/extensions/current/fss.so: /usr/lib/x86_64-linux-gnu/hhvm/extensions/current/fss.so: cannot open shared object file: No such file or directory [20:30:58] May have been because I provisioned on an old non-rebased patch. Not sure though. [20:31:44] What do you get for: [20:31:45] dpkg -l|grep hhvm [20:32:07] https://phabricator.wikimedia.org/P2748 [20:32:19] fss was removed/deleted [20:32:28] and you need to update mw-v to fix it [20:32:34] quiddity: pick one plz :| [20:32:46] milestone, seems least ambiguous [20:33:42] matt_flaschen: Should be fixed with a git pull on mw-v itself -- https://phabricator.wikimedia.org/T129343 [20:35:58] Okay, thanks, bd808. Re-provsioning now. [20:41:30] 3Collaboration-Team-Current, 10Notifications: Remove unused Echo code - https://phabricator.wikimedia.org/T125861#2113029 (10jmatazzoni) 5Open>3Resolved [20:45:17] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Action and timestamp position needs adjustment - https://phabricator.wikimedia.org/T125969#2001797 (10jmatazzoni) @Mooeypoo, moving this back to Development. Are you able to address Pau's requests? [20:52:41] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review, and 2 others: Should get notified for topic summary change on your own user talk - https://phabricator.wikimedia.org/T125119#2113052 (10jmatazzoni) 5Open>3Resolved Closing this ticket (with pleasure!). Thanks all. [20:52:42] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2113054 (10jmatazzoni) [20:54:23] 3Collaboration-Team-Current, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Fix namespace movable hook - https://phabricator.wikimedia.org/T128694#2113059 (10jmatazzoni) 5Open>3Resolved [21:07:23] My PHP debugger is giving me a hard time. [21:14:34] Sigh, I keep forgetting that when you get "missing revision" it goes into parser cache, so even after you fix it you have to do action=purge. [21:14:51] The last time was probably 3 months ago, but still. [21:50:37] (03CR) 10Mooeypoo: Allow mark-as-unread in notifications (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) (owner: 10Mooeypoo) [21:50:45] (03PS13) 10Mooeypoo: Allow mark-as-unread in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) [21:55:19] (03CR) 10Mooeypoo: [C: 032] "LGTM" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274342 (owner: 10Catrope) [21:58:53] (03PS14) 10Catrope: Allow mark-as-unread in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) (owner: 10Mooeypoo) [22:01:51] (03Merged) 10jenkins-bot: Fix duplicate impression logging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274342 (owner: 10Catrope) [22:12:36] (03PS15) 10Catrope: Allow mark-as-unread in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) (owner: 10Mooeypoo) [22:30:59] (03CR) 10Catrope: [C: 032] Allow mark-as-unread in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) (owner: 10Mooeypoo) [22:38:54] (03PS1) 10Catrope: Follow-up 9a1defa5: unbreak mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276902 [22:39:00] mooeypoo: https://gerrit.wikimedia.org/r/276902 [22:42:19] (03PS1) 10Mooeypoo: Wrap section name in tags in 'new topic' notification text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276903 [22:42:22] RoanKattouw, ^^ [22:42:31] actually matt_flaschen might find it amusing as well [22:44:00] (03Merged) 10jenkins-bot: Allow mark-as-unread in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) (owner: 10Mooeypoo) [22:45:20] (03PS2) 10Catrope: Follow-up 9a1defa5: unbreak mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276902 [22:46:52] mooeypoo, RoanKattouw, I know Siebrand said in one of these bugs he preferred not to put this in i18n. Was their a resolution on that? [22:47:11] I.E. he wanted to do it in PHP if possible. [22:47:15] matt_flaschen, there's not much choice [22:47:31] The only option is to include the "" in the php which is a nono [22:48:07] mooeypoo, okay, I see what you mean. [22:48:11] (03CR) 10Legoktm: "Er...why not construct the User object from the name then?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276902 (owner: 10Catrope) [22:48:22] mooeypoo, so I can test it with just a board and topic both in Hebrew, right? [22:48:40] matt_flaschen, yep [22:49:03] (03CR) 10Catrope: "I guess we could? getTruncatedUsername() would just call getName() on it again, which feels a bit silly, but we would avoid code duplicati" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276902 (owner: 10Catrope) [22:49:05] I called my board something with 1 in there (לוח 1 בעברית) and my topic something with 2 (בדיקה 2 בעברית) [22:49:25] Then it makes it clearer that you need to have xxxx_1_xxxx: "xxxx_2_xxxx" [22:50:18] matt_flaschen, I love this bug, though. It's like a demo of (a) the difference between isolation and embed, and (b) strong and weak bidi characters [22:50:19] \o/ [22:50:30] (03PS3) 10Catrope: Follow-up 9a1defa5: unbreak mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276902 [22:51:52] mooeypoo, "both of these elements (topic and board names) are internally wrapped in bidi embed" is something that was already implemented? [22:52:40] matt_flaschen: Yes although my patch for the topic part of that was only recently +2ed [22:53:03] Actually, no it wasn't ever +2ed [22:53:04] https://gerrit.wikimedia.org/r/#/c/276693/ [22:53:14] mooeypoo's patch should probably be based on mine [22:53:50] RoanKattouw, will review that one first then. [22:53:55] matt_flaschen, yes - I added the second internal-embed by +2ing RoanKattouw's commit, but yeah those were already in there, but since they're "embed" they don't affect the general directionality [22:54:45] uhm, oops [22:54:55] the +2 window is open, but I didn't press "publish comments". Ha [22:55:05] (03CR) 10Mooeypoo: [C: 032] "lgtm" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276693 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [22:55:09] **now** it's +2ed [22:55:20] (03CR) 10Legoktm: [C: 04-1] Follow-up 9a1defa5: unbreak mention notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276902 (owner: 10Catrope) [22:56:26] (03PS4) 10Catrope: Follow-up 9a1defa5: unbreak mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276902 [22:56:36] legoktm: Good catch, I did look at the $validate param but then forgot to actually pass it [22:57:22] (03PS5) 10Legoktm: Follow-up 9a1defa5: unbreak mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276902 (owner: 10Catrope) [22:57:27] (03CR) 10Legoktm: [C: 032] Follow-up 9a1defa5: unbreak mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276902 (owner: 10Catrope) [23:03:03] (03CR) 10Catrope: [C: 04-1] "Works well. Found one bug: all unread notifications get the "unseen" (blue animation) effect every time. This is because NotificationsMode" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [23:07:35] (03Merged) 10jenkins-bot: Bidi-embed topic titles in notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276693 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [23:07:39] (03Merged) 10jenkins-bot: Follow-up 9a1defa5: unbreak mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276902 (owner: 10Catrope) [23:08:47] (03PS2) 10Mattflaschen: Wrap section name in tags in 'new topic' notification text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276903 (owner: 10Mooeypoo) [23:10:38] mooeypoo, yeah, it is an interesting bug. At first I want to say it's correct (1 is to the right of 2, and it's right to left). But it's actually a LTR context nonetheless since the UI is English. So it makes me think a little. [23:11:28] Yeah, this has made me finally understand the difference between embedding and isolation [23:11:58] You have Blah blah [Hebrew text]: "[Hebrew text]" [23:12:01] (03CR) 10Mattflaschen: [C: 032] Wrap section name in tags in 'new topic' notification text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276903 (owner: 10Mooeypoo) [23:12:29] There's nothing strongly LTR in between the two bits of Hebrew text, so they get strung together as one block of RTL-ness, but we don't want that [23:13:00] Embedding prevents LTR-ness from leaking into the Hebrew text and affecting punctuation at its edges, but it does nothing to address this problem. Isolation does. [23:14:24] Yeah, I'm gradually understanding it better. In this case, basically makes the whole Hebrew phrase behave as a single LTR character in terms of the overall context. [23:14:37] Yeah that's a good metaphor [23:16:27] (03CR) 10jenkins-bot: [V: 04-1] Wrap section name in tags in 'new topic' notification text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276903 (owner: 10Mooeypoo) [23:19:25] (03CR) 10Catrope: [C: 04-1] Add mark-as-read button to notifications in Special:Notifications (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [23:19:29] 6Collaboration-Team-Backlog, 10MediaWiki-Watchlist, 10Notifications: Allow e-mail notifocations about changes of watched without having to log in and load the entire pages again. - https://phabricator.wikimedia.org/T129710#2113566 (10Purodha) [23:22:21] (03CR) 10Catrope: [C: 032] Wrap section name in tags in 'new topic' notification text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276903 (owner: 10Mooeypoo) [23:22:26] (03Merged) 10jenkins-bot: Wrap section name in tags in 'new topic' notification text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276903 (owner: 10Mooeypoo) [23:25:22] Jinx [23:25:49] I +2ed it because of the Jenkins failure, but it turns out that was a test failure not a gate-and-submit failure [23:36:16] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#2113650 (10GWicke) @ssastry: Thanks for updating the task description. I'm broadly in agreement with your outline. Since our discussion ye... [23:42:18] 6Collaboration-Team-Backlog, 10Notifications, 7Wikimedia-log-errors: Echo: Call to a member function getLocalURL() on a non-object (null) in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129715#2113681 (10demon) [23:48:31] 6Collaboration-Team-Backlog, 10Notifications, 7Wikimedia-log-errors: Echo: Call to a member function getLocalURL() on a non-object (null) in EditThresholdPresentationModel.php - https://phabricator.wikimedia.org/T129715#2113681 (10Catrope) We already noticed this separately and fixed it in https://gerrit.wik... [23:48:36] 6Collaboration-Team-Backlog, 10MediaWiki-Watchlist, 10Notifications: Allow e-mail notifocations about changes of watched without having to log in and load the entire pages again. - https://phabricator.wikimedia.org/T129710#2113734 (10Quiddity) [23:48:49] (03PS1) 10Catrope: thank-you-edit: canRender for deleted page and extra fix [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/276916 (https://phabricator.wikimedia.org/T129641) [23:49:01] (03PS2) 10Catrope: thank-you-edit: canRender for deleted page and extra fix [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/276916 (https://phabricator.wikimedia.org/T129641) [23:50:05] 6Collaboration-Team-Backlog, 10MediaWiki-Watchlist, 10Notifications: Allow e-mail notifocations about changes of watched without having to log in and load the entire pages again. - https://phabricator.wikimedia.org/T129710#2113566 (10Quiddity) (The e-mail notifications about changes to our watchlist, are usi...