[00:08:50] (03CR) 10jenkins-bot: [V: 04-1] Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [00:23:32] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, and 2 others: User names and other content language-y things in notifications should be bidi-isolated - https://phabricator.wikimedia.org/T127407#2105377 (10Catrope) [00:23:33] (03PS1) 10Mooeypoo: Bidi isolate content items in notification header text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276388 (https://phabricator.wikimedia.org/T127407) [00:23:42] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, and 2 others: User names and other content language-y things in notifications should be bidi-isolated - https://phabricator.wikimedia.org/T127407#2105379 (10Catrope) a:5Catrope>3Mooeypoo [00:51:59] quiddity: This also reminded me to hand off https://www.google.com/url?q=https%3A%2F%2Fgerrit.wikimedia.org%2Fr%2F273569&sa=D&sntz=1&usg=AFQjCNF0bZBg9t7R0qNKye_IN5a8z8AHQg [00:51:59] Ugh [00:52:04] https://gerrit.wikimedia.org/r/#/c/273569/ [00:52:18] Damn you Google [00:52:21] Trying to pawn that one off on Moriel now [00:52:59] :) [00:55:53] (03CR) 10Catrope: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274342 (owner: 10Catrope) [01:26:12] (03CR) 10Catrope: Allow mark-as-unread in notifications (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) (owner: 10Mooeypoo) [01:28:45] (03PS8) 10Mattflaschen: WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) [01:29:24] (03CR) 10jenkins-bot: [V: 04-1] WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [01:29:27] (03PS9) 10Mattflaschen: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) [01:31:08] (03CR) 10jenkins-bot: [V: 04-1] Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [01:37:10] (03PS10) 10Mattflaschen: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) [01:37:34] (03CR) 10Mattflaschen: "Rebased, made some fixes (addresses issues raised by Paladox) and some minor changes." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [01:38:25] (03PS3) 10Mattflaschen: Corresponding changes for Echo 99+ refactoring [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) [01:39:43] (03CR) 10Mattflaschen: "Also, I did more testing." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [01:42:42] (03CR) 10jenkins-bot: [V: 04-1] Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [01:43:23] (03PS11) 10Mattflaschen: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) [01:44:02] (03CR) 10jenkins-bot: [V: 04-1] Corresponding changes for Echo 99+ refactoring [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [01:49:37] (03CR) 10jenkins-bot: [V: 04-1] Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [01:52:29] (03PS12) 10Mattflaschen: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) [01:57:13] 6Collaboration-Team-Backlog, 10Notifications: Give a way for users to opt-out Cross-wiki Notifications - https://phabricator.wikimedia.org/T129077#2094340 (10Catrope) One thing we could do is add a line to this: {F3586799} with the "email" one greyed out as it is for "Email from other user". Alternatively, w... [02:02:37] mooeypoo, re mark as read, I think legoktm was saying he didn't want to change the presentation model, but I'm not sure what a better alternative would be. [02:17:46] (03CR) 10Mattflaschen: [C: 04-1] "Don't know if the IE 8 is worth bothering with." (037 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [02:45:31] (03CR) 10Mattflaschen: "filter-callback will help remove some minor code duplication. Other than that, small stuff." (037 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [02:45:37] (03CR) 10Mattflaschen: [C: 04-1] Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [03:21:39] 3Collaboration-Team-Current, 10Flow: topic-title-plaintext content format to treat topic-title-wikitext as plain text - https://phabricator.wikimedia.org/T129439#2105666 (10Mattflaschen) [03:25:54] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7JavaScript: PageTriage uses synchronous XMLHttpRequests - https://phabricator.wikimedia.org/T90328#2105690 (10Ricordisamoa) [03:28:56] (03CR) 10Mattflaschen: "Forgot to say, I mentioned some rawElement that are unrelated to your change. I can do them separately if you prefer." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [04:06:36] (03PS1) 10Mattflaschen: Add topic-title-plaintext content format to reduce boilerplate code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276401 (https://phabricator.wikimedia.org/T129439) [04:09:44] Have a good night, everyone. [04:12:36] (03CR) 10jenkins-bot: [V: 04-1] Add topic-title-plaintext content format to reduce boilerplate code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276401 (https://phabricator.wikimedia.org/T129439) (owner: 10Mattflaschen) [06:42:14] 6Collaboration-Team-Backlog, 10Notifications, 10Wikidata, 7Need-volunteer, and 2 others: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#2105911 (10Edgars2007) Sorry for not commenting this earlier, but better late then never as th... [07:30:50] 6Collaboration-Team-Backlog, 10Notifications, 10Wikidata, 7Need-volunteer, and 2 others: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#2105948 (10matej_suchanek) No problem, the review has started yesterday. This is one of the p... [09:56:33] 6Collaboration-Team-Backlog, 6Increasing-content-coverage, 10MediaWiki-extensions-ContentTranslation, 10Notifications, and 5 others: Notify translators about new personalised suggestions being available based on their recently published translation - https://phabricator.wikimedia.org/T119939#2106097 (10Pgin... [09:56:35] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2106096 (10Pginer-WMF) [10:16:06] 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 13Patch-For-Review, 7WorkType-Maintenance: Migrate Flow content to new separate logical External Store - https://phabricator.wikimedia.org/T106363#2106177 (10jcrespo) Thanks to @Volans, new codfw external storage se... [10:25:32] 6Collaboration-Team-Backlog, 10Flow: Copy-paste a template in wikitext on Flow does not work on visual mode when a space is present before the first brace - https://phabricator.wikimedia.org/T129454#2106184 (10Trizek-WMF) [10:49:43] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Roll out cross-wiki notifications beta feature - https://phabricator.wikimedia.org/T124234#2106244 (10Trizek-WMF) [10:51:04] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 3Liaisons-March-2016: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2106245 (10Trizek-WMF) Updated the email to tech ambassadors: release on the... [11:15:25] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Allow to mark as read items int he Notification Page - https://phabricator.wikimedia.org/T129460#2106308 (10Pginer-WMF) [11:21:47] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#2106328 (10Pginer-WMF) > @Pginer-WMF, should we add some more emphasis on the difference in the current no-javascript v... [11:25:25] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Allow to mark as read items and groups in the Notification Page - https://phabricator.wikimedia.org/T129460#2106333 (10Pginer-WMF) [11:25:54] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2106334 (10Pginer-WMF) [11:45:13] 3Collaboration-Team-Current, 10Notifications: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2106364 (10Pginer-WMF) >>! In T129363#2104460, @Mattflaschen wrote: > Since this is for the old notification page I'm not sure what do you mean. This was proposed as an one of the fir... [11:47:14] (03CR) 10Sbisson: [C: 032] Minor qqq tweak for notification-links-flow-description-edited-view-page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276344 (https://phabricator.wikimedia.org/T129351) (owner: 10Mattflaschen) [11:51:10] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Copy-paste a template in wikitext on Flow does not work on visual mode when a space is present before the first brace - https://phabricator.wikimedia.org/T129454#2106382 (10SBisson) [11:57:27] (03Merged) 10jenkins-bot: Minor qqq tweak for notification-links-flow-description-edited-view-page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276344 (https://phabricator.wikimedia.org/T129351) (owner: 10Mattflaschen) [12:02:53] 3Collaboration-Team-Current, 10Notifications: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2106492 (10Pginer-WMF) >>! In T129363#2103747, @Trizek-WMF wrote: > Knowing some users, I anticipate the question " why don't you use infinite scroll?". > > (I know: "Infinite scroll... [12:09:10] 6Collaboration-Team-Backlog, 10Notifications: Notifications inside a cross-wiki bundle have different space in each side - https://phabricator.wikimedia.org/T129469#2106503 (10Pginer-WMF) [12:13:14] 3Collaboration-Team-Current, 10Notifications: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2103478 (10SBisson) >>! In T129363#2106364, @Pginer-WMF wrote: >>>! In T129363#2104460, @Mattflaschen wrote: >> Since this is for the old notification page > > I'm not sure what do yo... [12:17:22] 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10Notifications, 7user-notice: Revise Sorting of Notifications on the Fly-Out Menu - https://phabricator.wikimedia.org/T123018#1919410 (10TheDJ) i had a discussion about this with someone at the summit, and for me another important division... [12:22:16] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2106557 (10Pginer-WMF) >>! In T128069#2104218, @Etonkovi... [12:28:43] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#2106564 (10TheDJ) > Visually distinguish read and unread notifications at the notification page. Please don't forget s... [12:31:43] 3Collaboration-Team-Current, 10Notifications: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2106568 (10Pginer-WMF) > From this point on, I propose we refer to those pages as "Special:Notifications (JS)" and "Special:Notifications (NO-JS)" or something like that to avoid more... [12:42:10] 3Collaboration-Team-Current, 10Flow, 10Datasets-Archiving, 10Dumps-Generation, 7Blocked-on-Operations: Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#2106578 (10ArielGlenn) I'm trying to run the flow maintenance script from the command line on an a... [12:47:00] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#2106590 (10Pginer-WMF) >>! In T115528#2106564, @TheDJ wrote: >> Visually distinguish read and unread notifications at t... [12:49:11] 6Collaboration-Team-Backlog, 10Notifications, 7WorkType-NewFunctionality: Clarify read/unread status for notifications - https://phabricator.wikimedia.org/T126214#2106596 (10TheDJ) [12:58:37] (03PS7) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [12:58:50] (03PS5) 10Sbisson: [WIP] [POC] Moderate notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275052 (https://phabricator.wikimedia.org/T93673) [13:03:45] (03CR) 10jenkins-bot: [V: 04-1] [WIP] [POC] Moderate notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275052 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [13:05:41] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [13:25:06] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 3Liaisons-March-2016: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2106668 (10Trizek-WMF) Announced on: * English Wikipedia - technical VP * Po... [14:11:43] 6Collaboration-Team-Backlog, 10Flow, 7Browser-Tests, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Fix Flow scenarios that fail at en.wikipedia.beta.wmflabs.org or do not run them daily - https://phabricator.wikimedia.org/T94153#2106785 (10zeljkofilipin) a:5zeljkofilipin>3None [15:30:10] (03CR) 10Siebrand: [C: 04-1] [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [15:39:55] (03PS8) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [15:41:33] (03PS1) 10Matthias Mullie: Notify when a topic is marked as resolved or reopened [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276480 (https://phabricator.wikimedia.org/T125654) [15:45:33] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264070 (https://phabricator.wikimedia.org/T100974) (owner: 10Haritha28) [15:47:18] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [15:47:21] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2107217 (10matthiasmullie) Patch is up. I may have missed it, but I couldn't find any decision on who should get these notifications.... [15:47:27] (03PS2) 10Matthias Mullie: Notify when a topic is marked as resolved or reopened [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276480 (https://phabricator.wikimedia.org/T125654) [15:48:10] (03CR) 10Sbisson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [15:49:30] (03CR) 10jenkins-bot: [V: 04-1] Notification when account is blocked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264070 (https://phabricator.wikimedia.org/T100974) (owner: 10Haritha28) [15:51:16] (03PS6) 10Sbisson: [WIP] Moderate notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275052 (https://phabricator.wikimedia.org/T93673) [15:57:58] (03PS2) 10Mattflaschen: Add topic-title-plaintext content format to reduce boilerplate code [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276401 (https://phabricator.wikimedia.org/T129439) [16:02:32] (03CR) 10Paladox: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276299 (owner: 10L10n-bot) [16:08:44] (03CR) 10Paladox: "recheck" [extensions/Echo] (REL1_23) - 10https://gerrit.wikimedia.org/r/246995 (https://phabricator.wikimedia.org/T110553) (owner: 10Chad) [16:08:55] (03CR) 10Paladox: "check experimental" [extensions/Echo] (REL1_23) - 10https://gerrit.wikimedia.org/r/246995 (https://phabricator.wikimedia.org/T110553) (owner: 10Chad) [16:13:40] (03CR) 10Jforrester: [C: 032] build: Enable jscs jsDoc rule 'requireNewlineAfterDescription' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275450 (owner: 10Ricordisamoa) [16:19:15] (03CR) 10Sbisson: [C: 04-1] "Looks good. Haven't tested yet." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276401 (https://phabricator.wikimedia.org/T129439) (owner: 10Mattflaschen) [16:26:37] (03Merged) 10jenkins-bot: build: Enable jscs jsDoc rule 'requireNewlineAfterDescription' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275450 (owner: 10Ricordisamoa) [16:46:16] (03PS1) 10Mattflaschen: Only phplint PHP files that actually changed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276497 [16:48:05] (03PS2) 10Mattflaschen: Only phplint PHP files that actually changed [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276497 [16:49:40] Finally fixed the spammy phplint that checks every single PHP file every time. [16:51:48] 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 13Patch-For-Review, 7WorkType-Maintenance: Migrate Flow content to new separate logical External Store - https://phabricator.wikimedia.org/T106363#2107612 (10Mattflaschen) Yes, they could potentially be used for the... [16:54:47] James_F, we should probably discuss the MediaWiki.org change. $wgFlowOccupyNamespaces does not work anymore (sorry, that shouldn't even be in there, we must have forgot to remove it, I will fix that). [16:55:01] It is possible to set the namespace for a content model, but there is no easy way to create wikitext pages in that namespace afterwards (however, they can be moved in). [16:56:27] matt_flaschen: Oh. How is it working on officewiki then? [16:56:59] matt_flaschen: Also you should tell RoanKattouw. :-) [16:57:33] (03PS1) 10Paladox: TEST: DO NOT MERGE [extensions/Echo] (REL1_24) - 10https://gerrit.wikimedia.org/r/276505 [16:57:43] 6Collaboration-Team-Backlog, 10Notifications, 10Wikidata, 7Need-volunteer, and 2 others: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#2107633 (10Lydia_Pintscher) I would suggest bundling them.For the people who write many many a... [16:57:59] (03CR) 10jenkins-bot: [V: 04-1] TEST: DO NOT MERGE [extensions/Echo] (REL1_24) - 10https://gerrit.wikimedia.org/r/276505 (owner: 10Paladox) [16:58:01] James_F, all officewiki talk namespace pages (subpages or not) are Flow (including non-existent). However, you can move non-Flow into those namespaces. [16:58:14] matt_flaschen: Yeah; can't we do the same for MW.org? [16:58:17] (03PS1) 10Paladox: TEST: DO NOT MERGE [extensions/Echo] (REL1_23) - 10https://gerrit.wikimedia.org/r/276506 [16:58:32] James_F, yes, but https://www.mediawiki.org/wiki/Topic:Szxf9xmuoz13ihvf is not explained right. I will clarify. [16:59:25] matt_flaschen: I'm lost. We're not able to replicate the state of officewiki for MW.org? Or we are, but it won't work any more? [16:59:50] (03CR) 10jenkins-bot: [V: 04-1] TEST: DO NOT MERGE [extensions/Echo] (REL1_23) - 10https://gerrit.wikimedia.org/r/276506 (owner: 10Paladox) [17:00:15] James_F, yes, we can do the exact same thing on MW.org as we did on officewiki. On both, you can not/will not be able to *create* a non-Flow page in a talk namespace. However, you can *move* a non-Flow page into a talk namespace. [17:00:32] James_F, I've replied to https://www.mediawiki.org/wiki/Topic:Szxf9xmuoz13ihvf to clarify this (you said "It'll still be possible to create new unstructured wikitext pages"). [17:02:48] matt_flaschen: Yeah, but that's just a bug, not a statement of how it will always work. I intentionally didn't mention that to avoid wasting time arguing about it. :-) [17:07:52] matt_flaschen: Thanks, though. :-) [17:08:04] (And yeah, we should fix the naming.) [17:08:35] James_F, about to post the followup. [17:08:45] Awesome, thank you. [17:17:46] 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 13Patch-For-Review, 7WorkType-Maintenance: Migrate Flow content to new separate logical External Store - https://phabricator.wikimedia.org/T106363#2107702 (10jcrespo) @matthiasmullie No, those can be around for test... [17:18:20] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on current version of Special:Notifications - https://phabricator.wikimedia.org/T115528#2107703 (10Mattflaschen) [17:19:39] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on current no-JS version of Special:Notifications - https://phabricator.wikimedia.org/T115528#1726587 (10Mattflaschen) [17:20:16] 3Collaboration-Team-Current, 10Notifications: Change current no-JS Special:Notifications to use core Pager - https://phabricator.wikimedia.org/T129169#2107724 (10Mattflaschen) [17:20:35] (03CR) 10Paladox: "check experimental" [extensions/Echo] (REL1_23) - 10https://gerrit.wikimedia.org/r/276506 (owner: 10Paladox) [17:26:46] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7JavaScript, 7Technical-Debt: PageTriage uses synchronous XMLHttpRequests - https://phabricator.wikimedia.org/T90328#2107758 (10Krinkle) [17:33:45] (03Abandoned) 10Paladox: TEST: DO NOT MERGE [extensions/Echo] (REL1_23) - 10https://gerrit.wikimedia.org/r/276506 (owner: 10Paladox) [17:34:21] (03CR) 10Paladox: "recheck" [extensions/Echo] (REL1_22) - 10https://gerrit.wikimedia.org/r/100120 (owner: 10Legoktm) [17:34:31] (03CR) 10Paladox: "check experimental" [extensions/Echo] (REL1_22) - 10https://gerrit.wikimedia.org/r/100120 (owner: 10Legoktm) [17:37:28] (03CR) 10Paladox: "check experimental" [extensions/Flow] (REL1_23) - 10https://gerrit.wikimedia.org/r/128613 (owner: 10L10n-bot) [17:46:15] (03CR) 10Paladox: "check experimental" [extensions/Flow] (REL1_23) - 10https://gerrit.wikimedia.org/r/128613 (owner: 10L10n-bot) [17:47:05] 3Collaboration-Team-Current, 10Flow, 10Datasets-Archiving, 10Dumps-Generation, 7Blocked-on-Operations: Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#2107911 (10Mattflaschen) >>! In T119511#2106578, @ArielGlenn wrote: > I'm trying to run the flow m... [17:50:21] 3Collaboration-Team-Current, 10Flow, 10Datasets-Archiving, 10Dumps-Generation, 7Blocked-on-Operations: Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#2107968 (10ArielGlenn) sure will. [17:54:01] 6Collaboration-Team-Backlog, 10Notifications: Give a way for users to opt-out Cross-wiki Notifications - https://phabricator.wikimedia.org/T129077#2108025 (10Trizek-WMF) "Show talk page message indicator in my toolbar" is, I think more easier to find and understand. The point is to enable-disable a functionali... [17:55:58] (03CR) 10ArielGlenn: "Very excited to see this happen. I was wishing for it earlier today but not feeling like I had the spare cycles." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275519 (owner: 10Matthias Mullie) [17:57:52] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-General-or-Unknown, 7I18n, 13Patch-For-Review: [[MediaWiki:Notification-links-flow-description-edited-view-page/qqq]] i18n issue - https://phabricator.wikimedia.org/T129351#2103042 (10Etonkovidova) Checked in betalabs - the **//"notification-links-flow-des... [17:58:37] (03PS1) 10Paladox: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] (REL1_22) - 10https://gerrit.wikimedia.org/r/276520 [17:58:48] (03CR) 10Paladox: "check experimental" [extensions/Flow] (REL1_22) - 10https://gerrit.wikimedia.org/r/276520 (owner: 10Paladox) [17:59:55] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] (REL1_22) - 10https://gerrit.wikimedia.org/r/276520 (owner: 10Paladox) [17:59:59] (03PS2) 10Paladox: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] (REL1_22) - 10https://gerrit.wikimedia.org/r/276520 [18:00:11] (03CR) 10Paladox: "check experimental" [extensions/Flow] (REL1_22) - 10https://gerrit.wikimedia.org/r/276520 (owner: 10Paladox) [18:00:48] (03PS3) 10Paladox: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] (REL1_22) - 10https://gerrit.wikimedia.org/r/276520 [18:01:15] (03CR) 10Paladox: "check experimental" [extensions/Flow] (REL1_22) - 10https://gerrit.wikimedia.org/r/276520 (owner: 10Paladox) [18:02:24] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] (REL1_22) - 10https://gerrit.wikimedia.org/r/276520 (owner: 10Paladox) [18:03:27] (03Abandoned) 10Paladox: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] (REL1_22) - 10https://gerrit.wikimedia.org/r/276520 (owner: 10Paladox) [18:03:56] (03PS1) 10Paladox: Jenkins job validation (DO NOT SUBMIT) [extensions/Thanks] (REL1_22) - 10https://gerrit.wikimedia.org/r/276521 [18:04:08] (03CR) 10Paladox: "check experimental" [extensions/Thanks] (REL1_22) - 10https://gerrit.wikimedia.org/r/276521 (owner: 10Paladox) [18:05:09] (03Abandoned) 10Paladox: Jenkins job validation (DO NOT SUBMIT) [extensions/Thanks] (REL1_22) - 10https://gerrit.wikimedia.org/r/276521 (owner: 10Paladox) [18:05:17] (03PS1) 10Paladox: Jenkins job validation (DO NOT SUBMIT) [extensions/Thanks] (REL1_23) - 10https://gerrit.wikimedia.org/r/276522 [18:05:30] (03CR) 10Paladox: "check experimental" [extensions/Thanks] (REL1_23) - 10https://gerrit.wikimedia.org/r/276522 (owner: 10Paladox) [18:07:45] (03CR) 10Paladox: "recheck" [extensions/Thanks] (REL1_24) - 10https://gerrit.wikimedia.org/r/185149 (owner: 10Hashar) [18:07:53] (03CR) 10Paladox: "check experimental" [extensions/Thanks] (REL1_24) - 10https://gerrit.wikimedia.org/r/185149 (owner: 10Hashar) [18:12:02] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Thanks] (REL1_23) - 10https://gerrit.wikimedia.org/r/276522 (owner: 10Paladox) [18:15:25] (03Abandoned) 10Paladox: Jenkins job validation (DO NOT SUBMIT) [extensions/Thanks] (REL1_23) - 10https://gerrit.wikimedia.org/r/276522 (owner: 10Paladox) [18:17:32] (03Abandoned) 10Paladox: TEST: DO NOT MERGE [extensions/Echo] (REL1_24) - 10https://gerrit.wikimedia.org/r/276505 (owner: 10Paladox) [18:28:53] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): 'Mark as read' dots menu is misaligned - https://phabricator.wikimedia.org/T126686#2108207 (10jmatazzoni) if it's fixed, does it need to go to code review or straight to QA? [18:35:09] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): 'Mark as read' dots menu is misaligned - https://phabricator.wikimedia.org/T126686#2020813 (10SBisson) There doesn't seem to be unmerged code to review here so I would sent to QA for @Etonkovidova to c... [18:42:57] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#2108310 (10ssastry) [18:43:21] 6Collaboration-Team-Backlog, 10Notifications: Usernames invisible in Echo notification text - https://phabricator.wikimedia.org/T129531#2108314 (10Ijon) [18:44:44] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#850853 (10ssastry) [18:47:22] 6Collaboration-Team-Backlog, 10Notifications: Usernames invisible in Echo notification text - https://phabricator.wikimedia.org/T129531#2108361 (10Ijon) Correction: the edit text used the Hebrew equivalent of the {{Ping}} template: This is the diff: https://he.wikipedia.org/w/index.php?title=%D7%A9%D7%99%D7%9... [18:57:10] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review: Remove double emphasis in UI strings - https://phabricator.wikimedia.org/T128711#2108413 (10jmatazzoni) As some may remember, I was initially concerned that all the boldfacing and quotation marks were too much. That it would make the... [19:01:12] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review: Remove double emphasis in UI strings - https://phabricator.wikimedia.org/T128711#2108416 (10jmatazzoni) ... Continuing. If we were going to change anything -- and I'm not convinced yet that a change is necessary -- I'd want to look... [19:19:38] 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 13Patch-For-Review, 7WorkType-Maintenance: Migrate Flow content to new separate logical External Store - https://phabricator.wikimedia.org/T106363#2108519 (10Mattflaschen) >>! In T106363#2107702, @jcrespo wrote: > @... [19:33:35] 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 13Patch-For-Review, 7WorkType-Maintenance: Migrate Flow content to new separate logical External Store - https://phabricator.wikimedia.org/T106363#2108573 (10jcrespo) Sorry about that, I just preset tab. > are we d... [19:39:54] 6Collaboration-Team-Backlog, 10Notifications, 10Wikidata, 7Need-volunteer, and 2 others: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#2108611 (10Ainali) Yes, bundling is good. And perhaps exclude articles created by a bot-flagge... [19:43:20] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Copy-paste a template in wikitext on Flow does not work on visual mode when a space is present before the first brace - https://phabricator.wikimedia.org/T129454#2108667 (10Catrope) I can't reproduce this. Are you sure this isn't the difference between an... [19:44:52] 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10Notifications, 7user-notice: Revise Sorting of Notifications on the Fly-Out Menu - https://phabricator.wikimedia.org/T123018#2108684 (10jmatazzoni) > for me another important division is: someone contacting me (ping, talk page, direct rep... [19:58:03] matt_flaschen, .... uhh.... re your code review, "newFromUser" --- how the hell did that even *work* the way it's written right now in the code!? O.o [20:01:38] mooeypoo, yeah, I was considering putting a snarky remark about how proper capitalization for method names is optional but encouraged in PHP, but I thought you might already know. [20:09:27] Apparently PHP doesn't care about capitalization and case sensitivity in methods?! eek. [20:09:39] Isn't PHP great [20:11:01] There are lots of other fun things, too [20:11:10] Like, what is array_unique(NULL) ? [20:11:14] It's WoNdErFuL [20:11:25] I am afraid to check [20:11:33] (Context: array_unique([1,2,3,1]) returns [1,2,3]) [20:11:51] ... what does that return [20:12:23] (03PS9) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [20:12:46] So, it doesn't throw an exception or an error. It logs a warning, and then returns NULL [20:12:57] That's right, array_unique() can potentially return something that's not an array [20:13:01] RoanKattouw, come on. There are way weirder things than that in PHP. :) [20:13:12] In fact, array_unique(3) is also NULL [20:13:19] matt_flaschen: Oh yes, that was just the most recent thing I ran into :) [20:13:29] array_unique 3 counts. :) [20:14:29] mooeypoo, yes, there are many more Yellowstone supervolcanoes in PHP to discover, in both the https://xkcd.com/1053/ sense and the normal supervolcano "ruin everything" sense. [20:15:41] mooeypoo: More on-topic, have you seen https://phabricator.wikimedia.org/T125969#2098313? [20:15:58] For example (granted, there are a lot better but this is easy to remember) implode accepts arguments in either order. explode does not... [20:16:23] Right, because it can't [20:16:26] ... did PHP implode on itself ? [20:16:40] Ah yeah, good point. [20:17:02] Favorite part of that one, "it may be less confusing to use the documented order of arguments." [20:17:13] May be, you know if that's okay with you. No pressure [20:17:46] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [20:17:46] explode takes two args of the same type, implode takes args of different types [20:18:08] Consistency[TM] [20:18:18] PHP: Go Where Your Heart Takes You [20:18:38] (03CR) 10Sbisson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [20:20:58] 6Collaboration-Team-Backlog, 10Notifications, 7Mobile: Mobile splitted notifications do not show numbers properly - https://phabricator.wikimedia.org/T125321#1984388 (10Catrope) Is this an RTL-only bug? [20:21:48] 6Collaboration-Team-Backlog, 10Flow: Flow should be able to enumerate all flow enabled pages on a wiki - https://phabricator.wikimedia.org/T63747#2108995 (10Catrope) For the purposes of the survey I recommend using Quarry or having me run a query on stat1003. [20:24:41] matt_flaschen, James_F, re: earlier discussion about contentmodel - for empty pages, we'll be able to use https://www.mediawiki.org/wiki/Help:ChangeContentModel (Just tested and confirmed on officewiki. And it doesn't convert flow boards with existing content, so that's good, too.) [20:25:52] quiddity, thanks for checking (I tried to check on officewiki, but I'm not an admin). However, that is restricted. [20:26:03] quiddity, what does it do if you try it on an existing Flow board. [20:26:20] matt_flaschen, see the last sentence ;) [20:26:36] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Copy-paste a template in wikitext on Flow does not work on visual mode when a space is present before the first brace - https://phabricator.wikimedia.org/T129454#2109012 (10Elitre) For me it's never converted, in both Chrome and Opera, regardless of the sp... [20:26:39] quiddity, you said it doesn't do a terrible thing. You didn't say what it did do... :) [20:27:22] Silently nothing? [20:28:14] matt_flaschen, re: restricted, it's apparently going to be given to all users, once bugs are fixed. https://phabricator.wikimedia.org/T85847 [20:28:25] oh, it gave a good warning message, I'll screenshot [20:28:31] Oh good. [20:28:37] Got to go to a meeting. [20:29:11] matt_flaschen, http://i.imgur.com/VVjn2To.png [20:32:29] milimetric: https://gerrit.wikimedia.org/r/#/c/276356/ FYI. You said I could self-merge that kind of stuff, but it's not clear to me if it's deployed automatically or not [20:32:42] RoanKattouw: It is. [20:32:51] Awesome [20:32:52] RoanKattouw: However it V-1'ed. [20:33:13] 20:32:28 OSError: [Errno 13] Permission denied [20:33:14] 20:32:28 ERROR: InvocationError: '/mnt/jenkins-workspace/workspace/tox-flake8/.tox/flake8/bin/flake8' [20:33:15] CI issue. [20:33:24] * RoanKattouw re-+2s [20:33:46] (03PS1) 10Catrope: thank-you-edit: Only call User::getEditCount() once [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/276556 [20:39:15] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), and 3 others: Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2109061 (10Catrope) (Update from March 8th) The plot thickens. Echo.log is full of lin... [20:39:55] quiddity: Update in the thank-you-edit saga, which has gotten more mysterious ---^^ [20:40:19] 6Collaboration-Team-Backlog, 10WikiLove, 13Patch-For-Review, 5WMF-deploy-2016-03-15_(1.27.0-wmf.17): WikiLove: Stylesheet should not embed both png and svg version of image - https://phabricator.wikimedia.org/T64000#2109067 (10Catrope) 5Open>3Resolved [20:40:21] 6Collaboration-Team-Backlog, 10WikiLove, 7Performance: Investigate WikiLove's performance - https://phabricator.wikimedia.org/T60192#2109068 (10Catrope) [20:40:35] fun! [20:41:41] (side-grumble: I keep getting confused by that name, and panicking that "Thanks" are having problems! >.< Wish we'd gone with "milestone" as the notification-type name) [20:42:02] RoanKattouw: Or an issue with type equivalence? [20:42:40] 6Collaboration-Team-Backlog, 10Notifications, 7Mobile: Mobile splitted notifications do not show numbers properly - https://phabricator.wikimedia.org/T125321#2109075 (10IKhitron) Checked now in foreign wiki. Indeed, it's a dir problem, @Catrope. [20:44:16] James_F: We checked, but that seems unlikely [20:44:27] eval.php testing shows that getEditCount() returns an int [20:44:37] And we also checked that the JSON log data preserves types [20:44:53] If this doesn't work, the next thing I'll try is changing !== to != [20:45:03] But more as a shot in the dark than anything else [20:45:28] quiddity: Yeah you're not the first one who's confused, Elena asked if it was related to the double-click-on-thank-link bug [20:45:54] mw:Naming_things ! [20:49:30] * James_F nods. [20:49:37] 6Collaboration-Team-Backlog, 10Thanks, 13Patch-For-Review: Notifications: Getting multiple "Thank"s from one user for the same edit is possible (double/duplicate) - https://phabricator.wikimedia.org/T53303#2109091 (10Catrope) T129401 points out that a trivial way to trigger this is by double-clicking a JS-po... [20:56:13] 3Collaboration-Team-Current, 10Notifications: Notifications inside a cross-wiki bundle have different space in each side - https://phabricator.wikimedia.org/T129469#2109115 (10Catrope) [21:16:34] 3Collaboration-Team-Current, 10Notifications: Usernames invisible in Echo notification text - https://phabricator.wikimedia.org/T129531#2109269 (10Catrope) [21:18:28] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Copy-paste a template in wikitext on Flow does not work on visual mode when a space is present before the first brace - https://phabricator.wikimedia.org/T129454#2109319 (10Catrope) >>! In T129454#2109012, @Elitre wrote: > For me it's never converted, in b... [21:20:57] I'm out for lunch, and then a local reading by an author. Back in 2-3 hours. [21:27:16] matt_flaschen: in my vagrant I cannot see Alerts getting Call to undefined method EchoFlowThanksPresentationModel::getTopicTitle() [21:27:47] matt_flaschen: cannot get anything new with git pull [21:29:21] Hmm, it sounds like Flow might be out of date [21:29:28] I see getTopicTitle() in FlowPresentationModle [21:32:39] (03CR) 10Catrope: [C: 032] Turn dumpBackup into proper Maintenance script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275519 (owner: 10Matthias Mullie) [21:34:22] (03PS1) 10Catrope: Replace create_function() with a closure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276611 [21:34:35] (03CR) 10Catrope: "Follow-up: https://gerrit.wikimedia.org/r/276611" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275519 (owner: 10Matthias Mullie) [21:36:18] etonkovidova, did that fix it? [21:37:05] matt_flaschen: hold on... [21:42:46] (03CR) 10Krinkle: [C: 032] Replace create_function() with a closure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276611 (owner: 10Catrope) [21:43:48] Ugh.... [21:43:56] Why does EchoDiscussionParser::getTextSnippet() strip templates ... [21:44:13] Flow's approach is to plain-text-ify the HTML, which makes sense [21:44:20] Echo seems to just take the wikitext and strip stuff from it [21:48:07] 3Collaboration-Team-Current, 10Notifications: Usernames invisible in Echo notification text - https://phabricator.wikimedia.org/T129531#2108314 (10Catrope) So it looks like `EchoDiscussionParser::getTextSnippet()` just strips all templates. I don't really understand why it works the way it does. For snippets o... [21:48:54] 6Collaboration-Team-Backlog, 10Notifications: Ping users in edit summary - https://phabricator.wikimedia.org/T129572#2109485 (10Dispenser) [21:51:10] matt_flaschen, legoktm: Do you guys know anything about the insanity that is EchoDiscussionParser::getTextSnippet()? [21:54:36] RoanKattouw, to answer your question, maybe because it's done at view-time and they didn't want to call the parser? [21:54:40] haha yesss [21:54:47] If it was done at send-time, that wouldn't be an issue. [21:55:08] But they DO call the parser [21:55:11] Well, the message parser [21:55:27] Also good point about view-time, but we could do it at send-time easily [21:55:43] matt_flaschen: sorry, after vagrant git-update -- Could not update dependencies of citoid ! Could not update dependencies of restbase ! [21:56:08] RoanKattouw, I'm pretty sure that's just a hack to call the parser (not sure why), but it's the same parser. [21:56:35] And whoops, I have no idea then. [21:56:59] (Sorry, I'm a little distracted filling out DMV paperwork right now, I have to go there in a few minutes and will be back later, hopefully soon >.>) [21:57:19] Unless they really did want to strip templates (not the same as converting to HTML and then plaintext-ify). [21:57:32] Stripping templates is easy to do cleanly with Parsoid (we do in Flow), not so with PHP parser. [21:57:43] etonkovidova, well, you can workaround it by just doing git pull in Flow as RoanKattouw suggested (rather than full git-update). [21:57:52] Regarding those errors, can you post a paste of the error message? [21:58:43] ************* Errors *********** [21:58:43] * Could not update dependencies of citoid ! [21:58:43] * Could not update dependencies of restbase ! [21:58:49] matt_flaschen: they are just like that [21:59:17] etonkovidova [21:59:25] cd srv/citoid; git submodule update --init --recursive [21:59:33] cd ../restbase; git submodule update --init --recursive [21:59:36] Post the log from that. [22:00:54] matt_flaschen: I have nothing on the screen after running those commands [22:01:30] Yeah, I thought it was submodules, but apparently not looking at gitupdate.conf.erb [22:01:30] (03Merged) 10jenkins-bot: Turn dumpBackup into proper Maintenance script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275519 (owner: 10Matthias Mullie) [22:01:35] (03Merged) 10jenkins-bot: Replace create_function() with a closure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276611 (owner: 10Catrope) [22:01:42] And run-git-update.erb [22:01:48] legoktm: OK, I'll get lunch soonish. When you're back from the DMV, could you tell me what you know about getTextSnippet()? [22:08:56] etonkovidova, try: [22:09:03] vagrant ssh; cd /srv/citoid; sudo rm -rf node_modules && npm install --no-bin-links [22:10:20] etonkovidova, also, while the summary at the end only says that, there should be an earlier detailed error about citoid earlier in the git-update run. [22:10:38] matt_flaschen: ok -trying [22:11:27] RoanKattouw: that's automatically deployed, and your change is fine. We just cleaned up some stuff with those jobs recently, and some seem mis-configured [22:11:34] I'll figure it out and let you know [22:11:37] Thanks [22:12:41] matt_flaschen: looks so sophisticated :) [22:14:08] etonkovidova, is it just outputting a lot about how it's downloading a whole bunch of stuff? [22:14:43] matt_flaschen: bunch of errors - argh [22:15:08] 45443 error Darwin 14.5.0 [22:15:08] 45444 error argv "/usr/local/Cellar/node/5.4.0/bin/node" "/usr/local/bin/npm" "install" "--no-bin-links" [22:15:08] 45445 error node v5.4.0 [22:15:10] 45446 error npm v3.3.12 [22:15:12] 45447 error Maximum call stack size exceeded [22:15:45] etonkovidova, sorry, you have to run it inside the VM. Note the vagrant ssh. [22:16:02] matt_flaschen: shoot [22:16:05] etonkovidova, that's from running it manually, not from git-update, right? [22:16:43] matt_flaschen: right [22:22:04] matt_flaschen: vagrant@mediawiki-vagrant:~$ cd /srv/citoid -bash: cd: /srv/citoid: No such file or directory [22:24:20] RoanKattouw: oh, never mind, I confused dates, your changes were deployed, but the job runs daily so it'll run in about 1.5 hours. The output will rsync shortly after that [22:24:44] Oh OK that's fine [22:24:57] I deliberately did this before the beta feature would actually be available there [22:25:15] It'll become available also about 1.5 hours from now, so the first run should still be pretty clean [22:26:19] etonkovidova, whoops, change /srv/citoid to /vagrant/srv/citoid . [22:27:39] matt_flaschen: ok... [22:28:34] matt_flaschen: no errors anymore [22:28:57] etonkovidova, npm install is outputting a bunch of stuff? [22:29:57] (03PS4) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [22:30:13] matt_flaschen: yes [22:37:05] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on current no-JS version of Special:Notifications - https://phabricator.wikimedia.org/T115528#2109785 (10Mooeypoo) >>! In T115528#2106328, @Pginer-WMF wrote: >> @Pginer-WMF, should we add... [22:42:52] (03PS3) 10Mooeypoo: Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) [22:43:02] (03CR) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications (037 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [22:46:55] (03CR) 10jenkins-bot: [V: 04-1] Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [22:59:29] (03CR) 10Mooeypoo: Add 'mark section as read' to Special:Notifications (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [23:05:30] (03PS4) 10Mooeypoo: Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) [23:12:19] (03PS1) 10Siebrand: Call static Language::fetchLanguageName() statically [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276642 [23:14:50] (03CR) 10MaxSem: [C: 032] Call static Language::fetchLanguageName() statically [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276642 (owner: 10Siebrand) [23:22:33] (03PS1) 10Mooeypoo: Fix bundled notification width [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276648 (https://phabricator.wikimedia.org/T129469) [23:22:42] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Notifications inside a cross-wiki bundle have different space in each side - https://phabricator.wikimedia.org/T129469#2110063 (10Mooeypoo) a:3Mooeypoo [23:23:52] (03PS5) 10Mooeypoo: Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) [23:24:36] RoanKattouw_away mooeypoo: any chance of those Echo patches getting merged today or tomorrow - happy to pair if it speeds things up. [23:24:44] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Allow to mark as read items and groups in the Notification Page - https://phabricator.wikimedia.org/T129460#2110076 (10Mooeypoo) a:3Mooeypoo The submitted patch adds the option to mark read by date/section **only** to the no-js version. A Ja... [23:25:57] jdlrobson, they're being reviewed. Hoping they'll be merged as soon as possible, I'll poke RoanKattouw_away about it when he gets back. I think matt_flaschen also started reviewing too [23:26:27] RoanKattouw_away: i will get you stroopwafels for Monday if you do ;-) [23:30:22] (03CR) 10Catrope: [C: 032] Fix bundled notification width [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276648 (https://phabricator.wikimedia.org/T129469) (owner: 10Mooeypoo) [23:31:19] (03CR) 10Catrope: [C: 032] Call static Language::fetchLanguageName() statically [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276642 (owner: 10Siebrand) [23:31:50] (03Merged) 10jenkins-bot: Call static Language::fetchLanguageName() statically [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276642 (owner: 10Siebrand) [23:35:38] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#2110119 (10jmatazzoni) Stephane suggests: > I think the primary action for 'flow-new-topic' and 'flowusertalk-new-topic' should be consist... [23:37:03] mooeypoo, oh, i should review that right away since it's Thursday. [23:38:35] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2110128 (10jmatazzoni) @Mooeypoo, moving this back to De... [23:39:50] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#2110140 (10ssastry) [23:40:38] mooeypoo, it's more that 'mobile.notifications.overlay' is stated to run on desktop, not that it depends on desktop. It might just be that all mobile modules are both desktop and mobile. jdlrobson would know better. [23:40:45] https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/53310/consoleFull [23:40:52] (03CR) 10Catrope: [C: 04-1] Add MobileNotificationsWrapper for Mobile display (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [23:43:59] matt_flaschen: all mobile modules are both desktop+mobile as Minerva is a desktop skin (hidden in preferences currently given the state of Special:Preferences but I'd love to rectify that) [23:44:26] The hope is eventually the targets system will die, but right now it's main purpose is to avoid putting libraries such as jquery.ui on mobile. [23:45:15] basically don't rely on the targets system to decide where your code ends up - explicitly choose with either BeforePageDisplay or BeforePageDisplayMobile [23:50:28] (03Merged) 10jenkins-bot: Fix bundled notification width [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276648 (https://phabricator.wikimedia.org/T129469) (owner: 10Mooeypoo) [23:52:17] (03CR) 10Catrope: Add MobileNotificationsWrapper for Mobile display (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [23:52:49] (03CR) 10Mattflaschen: Add MobileNotificationsWrapper for Mobile display (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) (owner: 10Mooeypoo) [23:54:53] mooeypoo, jdlrobson: OK I've shot some holes in both patches :) [23:56:27] the goal of EchoDiscussionParser::getTextSnippet() is to be able to take unparsed wikitext and get plaintext [23:56:42] RoanKattouw: boom! [23:57:42] https://static-bugzilla.wikimedia.org/41139 is the history behind it [23:59:55] Hmm, OK ...