[00:00:14] (03PS3) 10Catrope: Revert "Defer onPersonalUrls() DB writes to post-send" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276053 (https://phabricator.wikimedia.org/T129299) [00:00:27] (03CR) 10Catrope: [C: 032] Revert "Defer onPersonalUrls() DB writes to post-send" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276053 (https://phabricator.wikimedia.org/T129299) (owner: 10Catrope) [00:00:37] Reading the patch. Maybe you missed a use. [00:01:20] Doesn't look like it. [00:01:33] matt_flaschen: No, the fatal isn't inside the deferred function, it's at getEventType() [00:02:02] Oooh [00:02:02] $targetPage is an array?! [00:02:19] ohhh [00:02:20] Aha, yeah [00:02:20] $targetPages[$row->etp_event][] = EchoTargetPage::newFromRow( $row ); [00:02:22] I see it [00:02:28] It returns EchoTargetPage[][] not EchoTargetPage[] [00:02:53] (03CR) 10MaxSem: [C: 032] Add debug logging for when the thank-you-edit code detects a race condition [extensions/Echo] (wmf/1.27.0-wmf.15) - 10https://gerrit.wikimedia.org/r/275909 (https://phabricator.wikimedia.org/T128249) (owner: 10Catrope) [00:03:13] (03CR) 10MaxSem: [C: 032] Add debug logging for when the thank-you-edit code detects a race condition [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/275910 (https://phabricator.wikimedia.org/T128249) (owner: 10Catrope) [00:03:47] RoanKattouw: should we swat out the revert and then let the proper fix (I'll work on it) sit on beta for a while? [00:03:52] Yes [00:04:04] I'm thinking we just have your fix ride the wmf17 train [00:04:07] If you think that's OK [00:04:19] This makes sense. There can be more than one target page for a given event. [00:04:45] RoanKattouw: it was sitting for months, another week is fine [00:05:36] OK [00:07:27] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review, and 2 others: Should get notified for topic summary change on your own user talk - https://phabricator.wikimedia.org/T125119#2101561 (10Etonkovidova) > The topic "How the moi moved?" was summarized. > The topic "How the moi moved?" w... [00:11:53] (03Merged) 10jenkins-bot: Revert "Defer onPersonalUrls() DB writes to post-send" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276053 (https://phabricator.wikimedia.org/T129299) (owner: 10Catrope) [00:12:05] (03PS1) 10Catrope: Revert "Defer onPersonalUrls() DB writes to post-send" [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/276062 (https://phabricator.wikimedia.org/T129299) [00:14:02] (03CR) 10MaxSem: [C: 032] Revert "Defer onPersonalUrls() DB writes to post-send" [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/276062 (https://phabricator.wikimedia.org/T129299) (owner: 10Catrope) [00:14:30] (03CR) 10Catrope: [C: 032] Clean up hook usage [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275918 (owner: 10Krinkle) [00:18:22] (03CR) 10jenkins-bot: [V: 04-1] Revert "Defer onPersonalUrls() DB writes to post-send" [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/276062 (https://phabricator.wikimedia.org/T129299) (owner: 10Catrope) [00:19:12] (03CR) 10Catrope: [C: 04-1] Clean up hook usage (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275918 (owner: 10Krinkle) [00:19:40] (03CR) 10Catrope: [C: 032] Revert "Defer onPersonalUrls() DB writes to post-send" [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/276062 (https://phabricator.wikimedia.org/T129299) (owner: 10Catrope) [00:20:08] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-LiquidThreads: Blank talk pages on Portuguese Wikibooks: Fatal exception of type MWUnknownContentModelException - https://phabricator.wikimedia.org/T128293#2069760 (10Etonkovidova) All pages mentioned in the ticket are properly displayed. [00:20:12] RoanKattouw, I'm adding in the 'x' button for mark as read in special notifications, but I am getting a bit stuck as to where to link it for nojs support. [00:20:29] What's the usual thing to do in this case? Or should I not do this for nojs at all, but only for js with ajax like usual? [00:21:38] So normally my answer would be, link it to Special:Notifications?markasread=12345 or something [00:22:04] However, modifying state in a GET request is not cool and is also not going to be allowed any more because of the multi-DC project [00:22:05] Right that's what I was thinking, but (a) not sure that's a good thing to expose like that [00:22:12] but also (b) I am not sure how to expose that [00:22:24] right... hm. Okay. Soooo... alternative? :\ [00:22:25] So instead, you'd have to make the X (or whatever it is) a button in a
that sends a POST request [00:22:31] oh [00:22:33] hm [00:22:38] meh. [00:22:43] (03Merged) 10jenkins-bot: Add debug logging for when the thank-you-edit code detects a race condition [extensions/Echo] (wmf/1.27.0-wmf.15) - 10https://gerrit.wikimedia.org/r/275909 (https://phabricator.wikimedia.org/T128249) (owner: 10Catrope) [00:22:46] (03Merged) 10jenkins-bot: Add debug logging for when the thank-you-edit code detects a race condition [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/275910 (https://phabricator.wikimedia.org/T128249) (owner: 10Catrope) [00:23:17] And that POST request can then respond with a redirect to Special:Notifications [00:23:46] This pattern is called PRG: https://en.wikipedia.org/wiki/Post/Redirect/Get [00:26:27] (03Merged) 10jenkins-bot: Revert "Defer onPersonalUrls() DB writes to post-send" [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/276062 (https://phabricator.wikimedia.org/T129299) (owner: 10Catrope) [00:33:40] (03PS2) 10Catrope: Clean up hook usage [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275918 (owner: 10Krinkle) [00:33:42] (03PS4) 10Catrope: Various WikiLove performance clean up [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275919 (https://phabricator.wikimedia.org/T64000) (owner: 10Krinkle) [00:37:39] mooeypoo, maybe form (for each X) with a hidden field, plus an input type="image" to submit. Then the submit path can be Special:Notifications/something , or a separate special page. [00:38:02] Not sure if you can use HtmlForm only for a subpage like that, but it could be done with direct form access rather than HTMLForm. [00:43:45] Yeah I'm just not sure how to do the form processing [00:44:37] brb [00:44:39] if ( $request->wasPosted() ) { checkToken(); markRead(); $out->redirect( ... ) } [00:45:40] Also, yes, you need to include a CSRF token with all that, I forgot to mention that [00:45:59] legoktm: Ahmmm.... [00:46:00] 2016-03-09 00:42:40 mw1226 eswiki 1.27.0-wmf.15 Echo DEBUG: thank-you-edit race condition detected: Luciano Chavez (id: 4141293) should have had 1 edits but has 1 {"user":"Luciano Chavez","id":4141293,"expectedCount":1,"actualCount":1} [00:46:09] "should have had 1 edits but has 1" [00:46:20] Is this like a strict equality bug? [00:46:45] Maybe one of the vars is a string? [00:46:50] Although they're both numbers in the JSON blob... [00:48:38] mooeypoo, cleanest option is probably a separate unlisted special page (Special:NotificationsMarkRead). [00:48:54] Oh, yeah, that could work too [00:48:56] That can extend FormSpecialPage for clean form-handling of the POST. [00:49:05] And I didn't know about FormSpecialPage [00:49:12] Because I haven't messed with special pages much since 2010-2011 [00:49:16] If you really want to put it in Special:Notifications I have some ideas on that, but I don't think it's as clean. [00:49:29] RoanKattouw: .... [00:49:30] The POST-handling I mean. The hidden form would go in S:Notifications output. [00:49:51] > var_dump($user->getEditCount()); [00:49:53] * legoktm looks closely [00:49:53] int(334) [00:49:56] So it shouldn't be a type problem... [00:50:19] > $c = $user->getEditCount() + 1 - 1; [00:50:20] > var_dump($user->getEditCount() === $c ); [00:50:22] bool(true) [00:50:47] https://3v4l.org/dEU2L and JSON preserves types to [00:50:51] too* [00:51:34] Yeah [00:51:45] And both values come from getEditCount(), there's just a +1 in between [00:51:53] And in eval.php getEditCount returns an int [00:51:55] RoanKattouw: does it only happen for 1? [00:52:02] and +1-1 results in strict equality [00:52:08] I even passed it through a use callback [00:52:47] And the FormSpecialPage would also work as a normal special page. The hidden form might have to be constructed manually, but that could maybe be avoided by having a custom getForm that constructed a HTMLForm subclass, then reusing that form class's getHTML to render the hidden form [00:52:57] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7WorkType-NewFunctionality: Implement expandable notification groups - https://phabricator.wikimedia.org/T115423#1723912 (10Etonkovidova) Cross-wiki bundled notifications have been checked in betalabs. Note: {T114356} shows expandable bundl... [00:53:15] legoktm: Nope, I see one for 100 too [00:53:40] ok, so it's not anything weird with initializing the count on the first edit [00:54:10] No [00:54:24] I wonder if we should try weak equality? Though that feels like giving up [00:54:32] And I'm completely baffled [00:55:11] I guess we could store the second value of $user->getEditCount() in a variable to be sure that its return value didn't change between calls? [00:55:20] That would also be very weird but who knows [00:55:33] It would be less weird than int(100) !== int(100) [00:55:36] hm, okay, for the moment I'm dealing with trying to fiure out how to output a form with Html class. [00:55:41] The docs are **atrocious** [00:55:56] mooeypoo, did you look at FormSpecialPage? [00:56:03] You don't necessarily have to use it, but it's an option. [00:56:16] I just found this https://www.mediawiki.org/wiki/HTMLForm [00:56:18] Also, even if you don't want to bother with FormSpecialPage, you can still use HTMLForm. [00:56:23] jinx. [00:56:26] mooeypoo, yes, see my comments above. [00:56:29] :D [00:56:35] * mooeypoo nods [00:56:36] mooeypoo: the answer is "don't build forms with Html class" ;) [00:56:43] ... legoktm how else? [00:57:00] *echoes* HTMLForm! [00:57:06] oh [00:57:09] yes. that [00:57:22] Also using htmlform gives you OOUI for free too [00:57:39] RoanKattouw_away: bd.808 said types are preserved, so they're definitely both ints [00:58:25] mooeypoo: Alternatively, don't bother to implement it for non-JS users. ;-) [00:58:33] ha [00:59:18] legoktm, so far I'm not sure wtf to do with it by the examples given, though. There seems to be $htmlForm->show(); to display the form, but I need to output its html so to add it to the formatter output [00:59:35] mooeypoo: another option is to *link* to Special:MarkRead/<####>, and have that contain the form to mark it as read [00:59:37] * mooeypoo mutters about ooui-php-ifying Special:Notifications [00:59:49] legoktm: Yeah. [00:59:54] legoktm, that's what I started with but GET-- oh, no, wait, ah [00:59:55] hm [01:00:07] eh, that's lame for the user :\ [01:00:42] Probably, but I'm not sure it's worth building a super nice no-JS interface [01:01:07] mooeypoo: What legoktm said. [01:01:23] I don't care about 'super nice', I just want it to work [01:01:32] I agree that no-JS users should be able to explicitly mark notifs as read [01:01:42] And stuffing more stuff into Special:Notifs isn't a great idea [01:01:52] if we use a separate special page we can take advantage of FormSpecialPage and stuff [01:01:57] but having it as a button that sends you to another page with a form (that basically has a single "mark as read" button) and back to special:notifications sounds lame [01:02:25] OTOH it means we don't need 25 forms on Special:Notifications [01:02:48] I guess... [01:02:58] I can also just start by adding "mark all as read" :\ [01:03:02] Thanks currently has the same pattern for no-js users [01:03:25] at least then we can take off the auto-mark-everything-as-read behavior [01:03:27] Click "thank" -> Special:Thanks/<###> asks "Do you want to thank blah" -> "Blah has been thanked" [01:04:22] I guess we can do that [01:04:27] it will b ethe most straight forward. [01:05:46] (03PS1) 10Legoktm: thank-you-edit: Only call User::getEditCount() once [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276080 [01:07:05] mooeypoo, see my suggestion of using FormSpecialPage for MarkRead, and hacking up a hidden form that posts to it (optionally using the same HTMLForm to generate that form, making it less hacky). [01:07:10] RoanKattouw_away: ^^ [01:07:26] That could be added later as well, not essential. [01:07:36] Got to go for a while. [01:08:50] hm this is not my usual hunting grounds, so I'm going at "as best as I can" and we can make it "proper" later [01:20:33] hm, the problem of FormSpecialPage is that it's not UnlistedSpecialPage [01:20:37] that's probably not what we want, right? [01:30:40] legoktm, how can I get the notification ID from EchoEventPresentationModel ? It doesn't seem to have a getId() method. I think it's from the $this->event though, so that doesnt seem to be exposed? Am I missing something? [01:31:04] [17:20:33] hm, the problem of FormSpecialPage is that it's not UnlistedSpecialPage <-- you can set isListed() to false in FormSpecialPage too... [01:31:16] ooh, ok [01:31:22] mooeypoo: uhh, you can't. PresentationModels don't know about EchoNotifications, they just know about EchoEvents [01:31:34] Okay, that... makes thinks difficult [01:31:45] I'm in SpecialNotificationsFormatter [01:31:53] Adding the 'x' link for the 'mark as read' [01:32:12] I need the notification ID there otherwise I can't link to Special:NotificationMarkRead/xxxx ... ? [01:32:20] right... /me thinks [01:32:43] It would be best if all of that would be in the special page itself (structured data) but that would be changing the entire output [01:32:48] so... meh. [01:33:28] I have an extremely convoluted way of doing it, but I hope not to have to use it [01:34:15] legoktm, ^^ re that -- I could, theoretically, add the 'x' button in the Special Page code (I have the ID there), and inject it into the ready-made HTML I'm getting from the formatter... but that's crappy [01:34:27] Hrmmm [01:34:35] I don't have an idea off the top of my head [01:35:03] We can pass more state into the formatter itself, but it shouldn't reach the presentation models [01:35:16] * mooeypoo mutters [01:39:45] Hm. I'm not sure what to do here. [01:40:07] I'm checking into some hacks. [02:37:17] Am [02:37:25] There is no such thing as a notification ID, is there? [02:37:36] Notifications are identified by eventID + userID pairs [02:37:47] So I think you should only need the event ID to mark something as read [02:38:13] ( mooeypoo legoktm ) [02:38:37] (03CR) 10Catrope: [C: 032] thank-you-edit: Only call User::getEditCount() once [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276080 (owner: 10Legoktm) [02:47:26] (03CR) 10Catrope: Various WikiLove performance clean up (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275919 (https://phabricator.wikimedia.org/T64000) (owner: 10Krinkle) [02:48:57] (03PS5) 10Catrope: Various WikiLove performance clean up [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275919 (https://phabricator.wikimedia.org/T64000) (owner: 10Krinkle) [02:51:42] (03Merged) 10jenkins-bot: Clean up hook usage [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275918 (owner: 10Krinkle) [02:59:40] (03CR) 10jenkins-bot: [V: 04-1] thank-you-edit: Only call User::getEditCount() once [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276080 (owner: 10Legoktm) [02:59:47] (03CR) 10Catrope: [C: 032] Various WikiLove performance clean up [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275919 (https://phabricator.wikimedia.org/T64000) (owner: 10Krinkle) [03:00:22] (03CR) 10Catrope: [C: 032] "Bogus failure: 02:51:01 git.exc.GitCommandError: 'git branch -d -r origin/wmf/1.20wmf21 origin/wmf/1.24wmf10 origin/wmf/1.24wmf11 origin/w" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276080 (owner: 10Legoktm) [03:00:55] RoanKattouw, I forget, are we allowed to do find/replaces in the translations, or does that mess up translatewiki's workflow? [03:01:10] (03Merged) 10jenkins-bot: Various WikiLove performance clean up [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275919 (https://phabricator.wikimedia.org/T64000) (owner: 10Krinkle) [03:01:20] It would just be to remove a superfluous parameter (e.g. $5 -> $6) [03:01:26] Or rather vice-vera [03:03:57] matt_flaschen: I don't know. Last time I tried that and asked if it was OK, I was (correctly) told to do what I wanted to do differently without touching the i18n file [03:05:31] RoanKattouw, okay, i can do that. It just requires repeating a parameter. Until the translations are updated, it will also show 100 instead of 99+ for 100 or more, which IMHO is acceptable temporarily. [03:07:46] Yeah that's fine [03:09:44] (03Merged) 10jenkins-bot: thank-you-edit: Only call User::getEditCount() once [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276080 (owner: 10Legoktm) [05:02:00] (03PS1) 10Mattflaschen: WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 [05:02:26] (03CR) 10Mattflaschen: "This is almost done, but I want to test a few more scenarios." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (owner: 10Mattflaschen) [05:04:28] (03CR) 10jenkins-bot: [V: 04-1] WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (owner: 10Mattflaschen) [05:04:31] (03PS1) 10Mattflaschen: Corresponding changes for Echo 99+ refactoring [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 [05:05:02] 3Collaboration-Team-Current, 10Notifications: Bundle messages with imprecise amount of "other" not properly localizable - https://phabricator.wikimedia.org/T127288#2102036 (10Mattflaschen) >>! In T127288#2041518, @Mattflaschen wrote: > It's kind of weird to have two possible renderings, "User and 99 others" (i... [05:05:18] (03PS2) 10Mattflaschen: WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) [05:05:36] (03CR) 10jenkins-bot: [V: 04-1] Corresponding changes for Echo 99+ refactoring [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (owner: 10Mattflaschen) [05:06:49] (03PS2) 10Mattflaschen: Corresponding changes for Echo 99+ refactoring [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) [05:08:05] (03PS3) 10Mattflaschen: WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) [05:08:23] (03CR) 10jenkins-bot: [V: 04-1] WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [05:08:26] (03CR) 10jenkins-bot: [V: 04-1] Corresponding changes for Echo 99+ refactoring [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [05:09:24] (03PS4) 10Mattflaschen: WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) [05:12:10] Have a good night, all. [05:13:08] (03CR) 10jenkins-bot: [V: 04-1] WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [09:13:43] 6Collaboration-Team-Backlog, 10Flow: Have post content on Flow email notification - https://phabricator.wikimedia.org/T129321#2102254 (10Trizek-WMF) [09:37:47] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 3Liaisons-March-2016: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2102307 (10Trizek-WMF) [09:37:49] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2102308 (10Trizek-WMF) [09:53:36] 6Collaboration-Team-Backlog, 10Notifications, 7Design, 7WorkType-NewFunctionality: Define Cross-wiki Notifications settings - https://phabricator.wikimedia.org/T117670#2102321 (10Trizek-WMF) [[ https://www.mediawiki.org/w/index.php?title=Topic:Szp3jinluf819p4x&topic_showPostId=szp3jinnejnolvup#flow-post-sz... [13:55:27] 6Collaboration-Team-Backlog, 6Performance-Team, 10Reading-Community-Engagement, 10VisualEditor, 10VisualEditor-EditingTools: How to invoke the performance inspector? - https://phabricator.wikimedia.org/T129322#2102960 (10Moushira) [14:16:57] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-General-or-Unknown, 7I18n: [[MediaWiki:Notification-links-flow-description-edited-view-page/qqq]] i18n issue - https://phabricator.wikimedia.org/T129351#2103042 (10Purodha) [14:20:31] (03CR) 10Paladox: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275955 (owner: 10L10n-bot) [14:20:46] (03CR) 10Paladox: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/275983 (owner: 10L10n-bot) [14:20:53] (03CR) 10Paladox: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275955 (owner: 10L10n-bot) [14:23:52] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/275983 (owner: 10L10n-bot) [14:28:00] (03PS5) 10Paladox: WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [14:28:26] (03CR) 10Paladox: "Fixed a syntax error." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [14:29:55] 3Collaboration-Team-Current, 10Flow, 10Notifications: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2103088 (10matthiasmullie) a:3matthiasmullie [14:30:17] (03CR) 10Paladox: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [14:32:31] (03CR) 10jenkins-bot: [V: 04-1] WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [14:33:48] (03PS6) 10Paladox: WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [14:34:21] (03CR) 10Paladox: "Replace formatNotificationCount with getCappedNotificationCount since this patch renamed that function but never updated it in some files." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [14:36:39] (03PS7) 10Paladox: WIP: Make plural support for large values (100 or more) explicit in l10n [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [14:40:00] (03CR) 10Paladox: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [14:41:32] (03CR) 10Paladox: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276099 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [14:52:13] (03PS1) 10Paladox: Test [extensions/Thanks] (REL1_26) - 10https://gerrit.wikimedia.org/r/276171 [14:52:26] (03CR) 10Paladox: "check experimental" [extensions/Thanks] (REL1_26) - 10https://gerrit.wikimedia.org/r/276171 (owner: 10Paladox) [14:55:22] (03Abandoned) 10Paladox: Test [extensions/Thanks] (REL1_26) - 10https://gerrit.wikimedia.org/r/276171 (owner: 10Paladox) [14:56:02] (03PS1) 10Paladox: Test [extensions/Thanks] (REL1_25) - 10https://gerrit.wikimedia.org/r/276174 [14:56:10] (03CR) 10Paladox: "check experimental" [extensions/Thanks] (REL1_25) - 10https://gerrit.wikimedia.org/r/276174 (owner: 10Paladox) [15:02:53] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/Thanks] (REL1_25) - 10https://gerrit.wikimedia.org/r/276174 (owner: 10Paladox) [15:03:03] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 10Notifications: Echo failure with Flow or Thanks 'check experimental' - https://phabricator.wikimedia.org/T128627#2103177 (10Paladox) I think its a bigger problem since I can reproduce on REL1_26 and REL1_25. [15:06:33] 3Collaboration-Team-Current, 10Flow, 10Thanks: Flow failure with Thanks 'check experimental' - https://phabricator.wikimedia.org/T128628#2103192 (10Paladox) I think its a bigger problem since I can reproduce on REL1_26 and REL1_25. On REL1_25 I'm getting this error 14:59:02 There was 1 error: 14:59:02 14:5... [15:07:46] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 10Notifications: Echo and Flow fail on Thanks 'check experimental' ('generic') tests - https://phabricator.wikimedia.org/T128613#2103193 (10Paladox) I think its a bigger problem since I can reproduce on REL1_26 and REL1_25. On REL1_25 I'm getting this error 1... [15:16:28] (03PS2) 10Matthias Mullie: Turn dumpBackup into proper Maintenance script [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275519 [15:16:33] (03CR) 10Matthias Mullie: Turn dumpBackup into proper Maintenance script (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275519 (owner: 10Matthias Mullie) [15:32:28] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2103259 (10Pginer-WMF) [15:34:15] (03Abandoned) 10Paladox: Test [extensions/Thanks] (REL1_25) - 10https://gerrit.wikimedia.org/r/276174 (owner: 10Paladox) [15:40:38] (03PS1) 10Paladox: Test [extensions/Thanks] (REL1_24) - 10https://gerrit.wikimedia.org/r/276185 [15:40:51] (03CR) 10Paladox: "check experimental" [extensions/Thanks] (REL1_24) - 10https://gerrit.wikimedia.org/r/276185 (owner: 10Paladox) [15:43:31] (03Abandoned) 10Paladox: Test [extensions/Thanks] (REL1_24) - 10https://gerrit.wikimedia.org/r/276185 (owner: 10Paladox) [16:11:25] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 10Notifications: Echo failure with Flow or Thanks 'check experimental' - https://phabricator.wikimedia.org/T128627#2103357 (10Paladox) But Gather https://integration.wikimedia.org/ci/job/mwext-testextension-hhvm-composer/2129/console doesent fail and it uses e... [16:19:08] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2103379 (10Pginer-WMF) [16:49:22] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#2103470 (10Pginer-WMF) [16:55:43] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2103478 (10Pginer-WMF) [16:55:55] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Use more compact timestamps for notifications - https://phabricator.wikimedia.org/T125970#2103492 (10Amire80) In some languages it's not as easy to make one- or two- letter abbreviations. In English i... [17:00:17] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Filter by read status on the Notification Page - https://phabricator.wikimedia.org/T129364#2103509 (10Pginer-WMF) [17:11:27] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Overview of cross-wiki activity per page on the Notification Page - https://phabricator.wikimedia.org/T129366#2103549 (10Pginer-WMF) [17:15:15] 6Collaboration-Team-Backlog, 10Notifications: Notification archive filters - https://phabricator.wikimedia.org/T49093#507088 (10Pginer-WMF) As part of the designs for the Notification Page improvements, I think we are covering these requirements across several tickets: - {T129364} - {T129366} - and probably mo... [17:17:52] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2103608 (10Pginer-WMF) [17:18:37] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 3Liaisons-March-2016, 7Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2103633 (10Trizek-WMF) [17:19:38] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 10Notifications, 7Documentation: Create a page about Special:Notifications page - https://phabricator.wikimedia.org/T119873#2103640 (10Trizek-WMF) [17:20:47] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Use more compact timestamps for notifications - https://phabricator.wikimedia.org/T125970#2103644 (10Pginer-WMF) >>! In T125970#2103492, @Amire80 wrote: > In some languages it's not as easy to make one... [17:45:10] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2103747 (10Trizek-WMF) Knowing some users, I anticipate the question " why don't you use infinite scroll?". (I know: "Infinite scroll, infinite troll" :รพ) [18:12:07] (03CR) 10Nemo bis: Flow dumps XSD schema (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275843 (https://phabricator.wikimedia.org/T112799) (owner: 10Matthias Mullie) [18:19:40] stephanebisson, https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change . [18:19:52] https://wikitech.wikimedia.org/wiki/How_to_do_a_schema_change is out of date, but it does have one piece of important advice. [18:20:03] "RoanKattouw_away: And if anyone runs update.php I'll be on the first flight to SFO to slap them in the face " [18:21:16] (03PS3) 10Catrope: Fix duplicate impression logging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274342 [18:21:34] (03CR) 10Catrope: Fix duplicate impression logging (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274342 (owner: 10Catrope) [18:21:58] 6Collaboration-Team-Backlog, 6Performance-Team, 10Reading-Community-Engagement, 10VisualEditor, 10VisualEditor-EditingTools: How to invoke the performance inspector? - https://phabricator.wikimedia.org/T129322#2102270 (10Mattflaschen) Is this intentionally tagged Collaboration-Team-Backlog (because of VE... [18:23:24] stephanebisson, but in serious, tha's the basic workflow. Generally, we talk things through as needed on Gerrit or Phabricator with Jaime Crespo (jynus on IRC). [18:24:57] thanks matt_flaschen [18:26:44] (03CR) 10jenkins-bot: [V: 04-1] Fix duplicate impression logging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274342 (owner: 10Catrope) [18:28:40] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-General-or-Unknown, 7I18n: [[MediaWiki:Notification-links-flow-description-edited-view-page/qqq]] i18n issue - https://phabricator.wikimedia.org/T129351#2104016 (10Mattflaschen) [18:29:35] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-General-or-Unknown, 7I18n: [[MediaWiki:Notification-links-flow-description-edited-view-page/qqq]] i18n issue - https://phabricator.wikimedia.org/T129351#2103042 (10Mattflaschen) It could be: "Text for the link to the board where the description was edited"... [18:29:48] You can tell documentation is old when it contains references to me living in Europe [18:30:04] At one point [[How to deploy code]] justified the timing of deployment windows based on my timezone and dinner habits [18:44:08] 3Collaboration-Team-Current, 10Flow: [betalabs] Blocked user creating a new topic gets malformed error message - https://phabricator.wikimedia.org/T121137#2104041 (10Quiddity) [18:58:47] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Implement compressed rendering of notifications - https://phabricator.wikimedia.org/T115422#1723904 (10Etonkovidova) Checked in betalabs as part of several other (detailed) tickets. In the screenshot below, the expanded message from Chinese wi... [19:03:32] 3Collaboration-Team-Current: Delete old instances that are no longer used - https://phabricator.wikimedia.org/T129389#2104124 (10Mattflaschen) [19:03:37] Take aways from Scrum of Scrums: [19:03:48] Remove old Labs instances that are no longer needed: https://phabricator.wikimedia.org/T129389 [19:03:57] Code freeze week of March 21st, due to Dallas switchover. [19:08:30] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Roll out cross-wiki notifications beta feature - https://phabricator.wikimedia.org/T124234#2104156 (10Catrope) >>! In T124234#2100711, @Catrope wrote: > [[https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revisi... [19:08:53] quiddity: Per ---^^ I did what I alluded to this morning and moved the beta feature deployment from 8am to 4pm [19:09:06] 6Collaboration-Team-Backlog, 10Notifications, 13Patch-For-Review: BadMethodCall in PersonalUrls - https://phabricator.wikimedia.org/T129299#2104160 (10Legoktm) 5Open>3Resolved [19:09:27] (03PS1) 10Legoktm: Defer onPersonalUrls() DB writes to post-send (try #2) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276240 (https://phabricator.wikimedia.org/T117531) [19:09:35] Because the workaround for the grammar issues (moving the wiki names down into the subtitle) is in wmf16 and that doesn't hit Wikipedias until 11am [19:09:35] nod. :) [19:10:08] 6Collaboration-Team-Backlog, 10Notifications, 13Patch-For-Review, 7Performance, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Echo DB writes on page views - https://phabricator.wikimedia.org/T117531#2104177 (10Legoktm) 5Resolved>3Open Patch was reverted due to {T129299} [19:13:16] (03CR) 10Mattflaschen: "Please do not amend my patches without coordinating with me first." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [19:14:03] matt_flaschen, when can we pair today? [19:14:46] matt_flaschen, I have the "X" appearing, I just need to work on the FormSpecialPage bit... I also keep getting "No such special page" even though I registered it and ran the script to add it to the autoload.php [19:15:21] mooeypoo, I can do now, whenever you want except that I want to go to the Echo RFC meeting. [19:16:03] oh, wait, I solved that (stupid error on my part) -- but yeah I could use a bit of help on the form bit [19:16:07] and me too -- isn't it later? [19:16:13] mooeypoo, yeah. [19:16:14] Yeah ~3h from now [19:16:33] matt_flaschen, ok, we can start now and then stop for lunch and the rfc ? [19:17:03] mooeypoo, sure. You said you were trying out some software with Stephane before, or do you just want to do IRC? [19:17:39] yeah we were using the Chrome extension for sharing the desktop [19:17:57] mooeypoo, which extension? [19:17:57] matt_flaschen, https://chrome.google.com/webstore/detail/chrome-remote-desktop/gbchcmhmhahfdphkhkmpfmihenigjmpp?hl=en [19:18:14] We were using that + hangout [19:18:52] (03CR) 10Paladox: "Sorry." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276096 (https://phabricator.wikimedia.org/T127288) (owner: 10Mattflaschen) [19:23:45] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2104218 (10Etonkovidova) @Pginer-WMF - if anything else... [19:43:52] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Cross-wiki notifications: Links for reverts notifications point to the local wiki - https://phabricator.wikimedia.org/T127697#2050858 (10Etonkovidova) Checked... [19:48:46] stephanebisson: can you take a look at my comment about flowusertalk-new-topic specs on https://phabricator.wikimedia.org/T121737? [19:48:55] sure [19:49:46] stephanebisson: I moved it to PM sign off cause I think it looks good enough - but may be that spec is critical :) [19:51:27] etonkovi_: I think it's ok. 'flow-new-topic' and 'flowusertalk-new-topic' should be the same: bundled: board sorted by newest, single: new topic page [19:51:37] is it not what the spec is saying? [19:51:50] stephanebisson: I agree with you. [19:52:15] stephanebisson: the spec says - direct to the Flow board [19:52:20] I think it was just overlooked in the spreadsheet [19:52:43] stephanebisson: exactly [19:52:56] I'll reply to the ticket [19:53:06] stephanebisson: thx! [19:56:27] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#2104335 (10SBisson) >>! In T121737#2085707, @Etonkovidova wrote: > {icon exclamation-triangle color=red} @SBisson **flowusertalk-new-topic... [20:00:04] 3Collaboration-Team-Current, 10Notifications: Make pagination on Special:Notifications clearer - https://phabricator.wikimedia.org/T129169#2104354 (10Catrope) [20:00:08] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2104355 (10Catrope) [20:01:20] 3Collaboration-Team-Current, 10Notifications, 7Epic: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2103478 (10Catrope) [20:01:29] (03PS3) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [20:01:35] (03PS3) 10Sbisson: [WIP] [POC] Moderate notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275052 (https://phabricator.wikimedia.org/T93673) [20:01:46] 3Collaboration-Team-Current, 10Notifications: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2103478 (10Catrope) [20:02:02] 3Collaboration-Team-Current, 10Notifications: Filter by read status on the Notification Page - https://phabricator.wikimedia.org/T129364#2104361 (10Catrope) [20:02:32] 3Collaboration-Team-Current, 10Notifications: Overview of cross-wiki activity per page on the Notification Page - https://phabricator.wikimedia.org/T129366#2104362 (10Catrope) [20:12:20] 6Collaboration-Team-Backlog, 10Flow: FlowHooks::onMessageCacheGet() may be called during load.php and depends on the session user language - https://phabricator.wikimedia.org/T129397#2104401 (10Anomie) [20:12:43] 3Collaboration-Team-Current, 10Flow, 10Notifications: Double escaping in Flow notifications - https://phabricator.wikimedia.org/T125130#1979107 (10Etonkovidova) @Mattflaschen - the quotes from topic titles are doubled. Also I tried to use curly quotes - no additional problems: just doubling them as straight... [20:15:07] (03PS4) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [20:21:44] 3Collaboration-Team-Current, 10Notifications: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2103478 (10Mattflaschen) Since this is for the old notification page, maybe it should use ReverseChronologicalPager.php or one of the other pagers in core. Then we can do this paginat... [20:22:12] RoanKattouw, T129363 is an incremental improvement to the old/current S:N page, right? [20:22:12] T129363: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363 [20:23:06] I think there are two parts to it: improve the old / no-JS version, and build it into the new / JS-ful version [20:25:50] RoanKattouw, yeah, but those should be different tasks, right? [20:26:14] etonkovidova, re T125130, is that because we're quoting all topic titles? [20:26:14] T125130: Double escaping in Flow notifications - https://phabricator.wikimedia.org/T125130 [20:26:24] matt_flaschen: yup [20:26:32] (03PS1) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [20:26:34] etonkovidova, okay, so I don't think we need a special case for that. [20:26:50] matt_flaschen: agree :) [20:26:53] 3Collaboration-Team-Current, 10Notifications: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2104496 (10Mattflaschen) a:3Mattflaschen [20:27:01] 6Collaboration-Team-Backlog, 10Notifications: Double Thank notifications for double-click on Thanks - https://phabricator.wikimedia.org/T129401#2104498 (10Etonkovidova) [20:27:10] OK yeah that's fine [20:27:18] Also, there's a separate task asking for those quotes to be removed anyway [20:27:20] The "double emphasis" one [20:28:42] RoanKattouw, what do you think of my suggestion to use a core pager for the incremental part of Special:Notifications pagination? [20:29:29] 6Collaboration-Team-Backlog, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, and 2 others: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2104522 (10Sumit) [20:30:43] matt_flaschen: Well I suggested it in the duplicate task :) [20:30:44] 3Collaboration-Team-Current, 10Notifications: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2104526 (10Mattflaschen) There's another issue to consider here. With the current augmented JS functionality, it just appends to the current page when you click the button. Do we wan... [20:30:47] (03CR) 10jenkins-bot: [V: 04-1] Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [20:31:26] I think it's a good idea in general; not sure if IndexPager and friends are compatible with things that aren't directly SQL-driven like our Echo backend, but if they are, go for it [20:34:22] RoanKattouw, yeah, we just might need to override doQuery. We're doing that in Flow. [20:34:28] I'd like the pagination controls to look as much like the others in MW as possible; and if people think that's ugly they should propose prettifying the core pagination controls ;) [20:34:33] Oh, OK, yeah that makes sense [20:35:16] RoanKattouw, okay, and that includes dropping the "just append more when I click the button" JS augmentation right (different from both core and pginer's mockup), right? [20:37:40] Oh is that what it currently does in JS mode? [20:37:47] RoanKattouw, yeah. [20:37:56] Eww [20:38:14] OK yeah drop it then [20:38:15] I also think we should re-separate the incremental part and the "mockup for the eventual full rewritten Special:Notifications page" part. [20:38:22] I thought the no-JS pagination was bad because you click More and it gives you no indication that you're no longer at the beginning [20:38:34] That confused me for a while before I saw that the timestamps were from last week [20:38:45] +1 re separation [20:40:58] 3Collaboration-Team-Current, 10Notifications: Change current Special:Notifications to use core Pager - https://phabricator.wikimedia.org/T129169#2104557 (10Mattflaschen) a:3Mattflaschen [20:41:06] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#2104563 (10Mattflaschen) [20:41:08] 3Collaboration-Team-Current, 10Notifications: Change current Special:Notifications to use core Pager - https://phabricator.wikimedia.org/T129169#2097078 (10Mattflaschen) 5duplicate>3Open [20:42:20] (03PS2) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [20:42:26] 3Collaboration-Team-Current, 10Notifications: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2103478 (10Mattflaschen) This is now just about the future pagination for the new JS version of the special page. The first round (which will apply to both JS and no-JS users) is {T1... [20:42:41] 3Collaboration-Team-Current, 10Notifications: Pagination for the Notification Page - https://phabricator.wikimedia.org/T129363#2104567 (10Mattflaschen) a:5Mattflaschen>3None [20:43:03] (03PS3) 10Mooeypoo: Add mark-as-read button to notifications in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276256 (https://phabricator.wikimedia.org/T115528) [20:43:24] RoanKattouw_away, and sorry for forgetting that you were the one who brought up the core pager idea originally. [20:46:22] 3Collaboration-Team-Current, 10Flow: FlowHooks::onMessageCacheGet() may be called during load.php and depends on the session user language - https://phabricator.wikimedia.org/T129397#2104592 (10Mattflaschen) [20:48:48] 6Collaboration-Team-Backlog, 10Notifications: Double Thank notifications for double-click on Thanks - https://phabricator.wikimedia.org/T129401#2104597 (10Mattflaschen) [20:48:50] 6Collaboration-Team-Backlog, 10Thanks, 13Patch-For-Review: Notifications: Getting multiple "Thank"s from one user for the same edit is possible (double/duplicate) - https://phabricator.wikimedia.org/T53303#2104598 (10Mattflaschen) [21:05:29] matt_flaschen: No worries, I wasn't trying to take credit, just trying to be humorous :) [21:22:02] (03PS4) 10Sbisson: [WIP] [POC] Moderate notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275052 (https://phabricator.wikimedia.org/T93673) [21:22:05] (03PS5) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [21:24:49] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Librarization, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2104701 (10Krinkle) TL;DR: * **Provide base classes and interfaces** in MediaWiki core: PHP interfaces for event creation, notification backend and notificati... [21:26:06] (03CR) 10jenkins-bot: [V: 04-1] [WIP] [POC] Moderate notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275052 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [21:27:44] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [21:30:11] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#2104705 (10Mooeypoo) With this added to the Special:Notifications page, we are removing the auto-mark-read action from... [21:40:00] (03CR) 10Catrope: [C: 032] "Made sure to test it locally this time :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276240 (https://phabricator.wikimedia.org/T117531) (owner: 10Legoktm) [21:47:10] quiddity: So, for the graphs of how many people have the beta feature enabled, I have to list which wikis to track ("all" is not an option apparently, although ContentTranslation gets away with a quite long list) [21:47:27] I looked at the biggest wikis and at the data I pulled from the tracking table two months ago, and came up with this: [21:47:39] metawiki, enwiki, eswiki, dewiki, zhwiki, ruwiki, itwiki, ptwiki, jawiki, plwiki, svwiki, viwiki, arwiki, cawiki, fawiki, idwiki, kowiki, trwiki, ukwiki, hiwiki, enwikibooks, enwiktionary, enwikiquote, enwikisource, enwikinews, enwikiversity, enwikivoyage, specieswiki, incubatorwiki [21:47:39] fun! [21:47:44] In addition to the early-stage ones (testwiki, test2wiki, mediawikiwiki, testwikidatawiki, wikidatawiki, commonswiki, hewiki, hewikibooks, hewikinews, hewikiquote, hewikisource, hewikivoyage, hewiktionary, frwiki, frwikibooks, frwikinews, frwikiquote, frwikiversity, frwikivoyage, frwiktionary) [21:48:02] Anything I'm missing? More ideas for things to add, or criteria to use to find things to add? [21:49:07] (To see the long CX list in all its glory, see https://raw.githubusercontent.com/wikimedia/analytics-limn-language-data/master/language/config.yaml ) [21:52:32] Analytics is not within my areas of expertise... From an amateur pespective, it looks like you've already got what I would suggest: Multiple representative's from each type of sister project, and each of the multilingual wikis.... I'll take a look at SiteMatrix and see if anything obvious leaps out.. [21:52:43] I didn't include any non-English non-Wikipedias [21:52:59] Because I don't know that landscape and don't know which ones are big/significant [21:53:07] we had those from the early-stage though [21:53:19] I know some of the English sister projects are bigger than most non-English Wikipedias [21:53:19] Oh, yes, you're right [21:53:19] We have all French and Hebrew sister projects [21:53:21] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Librarization, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2104841 (10Mattflaschen) >>! In T128351#2104701, @Krinkle wrote: > TL;DR: > * **Provide base classes and interfaces** in MediaWiki core: PHP interfaces for ev... [21:53:39] Also, we can in fact add to this list later, we just don't get retroactive data [21:53:48] Which is why I'm adding this today before the beta feature goes out so that the lack of retroactivity doesn't matter [21:55:04] RoanKattouw, oh, let's add (if possible): wikimania2016, outreach, [21:55:06] (03PS6) 10Sbisson: [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [21:55:09] ooh good idea [21:55:13] Is outreachwiki still in use? [21:55:22] Or was it revived with the recent strategy stuff or something? [21:55:23] yupyup [21:55:29] still in use [21:55:51] (tentative long-term plans to merge it back into metawiki) [21:56:51] (slowly. because there is a lot of work still ongoing there. and oodles of external links pointing towards it (from the interwebs in general)) [21:57:23] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Librarization, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2104858 (10Legoktm) >>! In T128351#2104701, @Krinkle wrote: > TL;DR: > * **Provide base classes and interfaces** in MediaWiki core: PHP interfaces for event c... [21:57:38] (03PS1) 10Mattflaschen: Minor qqq tweak for notification-links-flow-description-edited-view-page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276344 (https://phabricator.wikimedia.org/T129351) [21:57:47] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-General-or-Unknown, 7I18n, 13Patch-For-Review: [[MediaWiki:Notification-links-flow-description-edited-view-page/qqq]] i18n issue - https://phabricator.wikimedia.org/T129351#2104863 (10Mattflaschen) a:3Mattflaschen [21:58:54] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-General-or-Unknown, 7I18n, 13Patch-For-Review: [[MediaWiki:Notification-links-flow-description-edited-view-page/qqq]] i18n issue - https://phabricator.wikimedia.org/T129351#2103042 (10Mattflaschen) [22:01:52] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [22:26:18] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Librarization, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2104974 (10Ricordisamoa) >>! In T128351#2091658, @brion wrote: >>>! In T128351#2091630, @Ricordisamoa wrote: >> Let me express some concerns here. >> As a use... [22:35:58] matt_flaschen, can you remind me of the local url to check zend errors? I'm stumped with a REALLY unhelpful exception text [22:36:11] (not urgent, I know you're in the meeting) [22:36:43] http://php5.local.wmftest.net:8080 [22:41:29] matt_flaschen, thanks! [22:43:33] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Librarization, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2105008 (10Mattflaschen) >>! In T128351#2104974, @Ricordisamoa wrote: > On the other hand, the watchlist only works by page (not by user, etc.) and interestin... [22:43:41] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Librarization, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2105009 (10brion) Quick note on my position after IRC discussion: Having the interfaces available in core is I think very important for establishing server->... [22:51:08] (03CR) 10Purodha: [C: 031] Minor qqq tweak for notification-links-flow-description-edited-view-page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/276344 (https://phabricator.wikimedia.org/T129351) (owner: 10Mattflaschen) [22:52:57] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Librarization, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2105051 (10Mattflaschen) I think the simplest option is to: * Bundle Echo for a release (it's a popular extension already, but it doesn't hurt to do this to... [23:39:51] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Librarization, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2105216 (10Tgr) It would be nice if MediaWiki was built as a set of loosely-coupled components (such as, say, Symfony2 where messages, resource loading, pages... [23:42:48] (03PS1) 10Mooeypoo: Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) [23:42:57] matt_flaschen, ^^ I extended on top of the commit to allow for multiple IDs [23:43:05] (plus a 'mark section as read' button) [23:45:35] mooeypoo, cool. [23:45:53] mooeypoo, will review at least the first one after I'm done the Echo i18n one. [23:46:51] matt_flaschen, I've separated the two commits mainly because the product decision isn't completely agreed on in terms of the section button [23:48:15] RoanKattouw: https://docs.google.com/spreadsheets/d/1XjPO8RlrFMqNhboWBUZwONJv93TRmLbReAuQ_ZktnD0/edit#gid=0 [23:48:24] (03CR) 10jenkins-bot: [V: 04-1] Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528) (owner: 10Mooeypoo) [23:58:48] (03PS2) 10Mooeypoo: Add 'mark section as read' to Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276376 (https://phabricator.wikimedia.org/T115528)