[00:00:32] 6Collaboration-Team-Backlog, 10Notifications, 7Easy, 13Patch-For-Review: Echo congratulations thresholds shouldn't be hard-coded - https://phabricator.wikimedia.org/T127311#2097551 (10MZMcBride) Part of my confusion here was that when I looked at and saw that it got... [00:03:03] (03CR) 10EBernhardson: [C: 032] Try and avoid race conditions with thank-you-edit notifications [extensions/Echo] (wmf/1.27.0-wmf.15) - 10https://gerrit.wikimedia.org/r/274908 (https://phabricator.wikimedia.org/T128249) (owner: 10Catrope) [00:03:24] 3Collaboration-Team-Current, 10Flow, 10Notifications: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2097579 (10jmatazzoni) Moving this to Ready for Pickup. Please find the spec for the language, icons and links under **flow-topic-resolved** on the spreadsh... [00:10:20] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review, and 2 others: Should get notified for topic summary change on your own user talk - https://phabricator.wikimedia.org/T125119#2097625 (10jmatazzoni) No one has objected to the newly created spec for this newly minted notification typ... [00:10:25] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-General-or-Unknown, 7JavaScript, 13Patch-For-Review: Support single set of index.php parameters for pre-filling new topics for both old-style talk pages and Flow - https://phabricator.wikimedia.org/T107637#2097626 (10matmarex) [00:18:44] (03Merged) 10jenkins-bot: Try and avoid race conditions with thank-you-edit notifications [extensions/Echo] (wmf/1.27.0-wmf.15) - 10https://gerrit.wikimedia.org/r/274908 (https://phabricator.wikimedia.org/T128249) (owner: 10Catrope) [00:21:37] 6Collaboration-Team-Backlog, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2097700 (10jayvdb) [00:48:31] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2097883 (10Etonkovidova) Please re-check the layout acco... [00:50:35] 3Collaboration-Team-Current, 10Flow: Problem while converting from LiquidThreads to Flow - https://phabricator.wikimedia.org/T128949#2091056 (10Mattflaschen) Thanks for providing this info. It was good talking to Riccardo about this at FOSDEM, and glad to hear your team is working on it. It looks from http:/... [00:50:42] 3Collaboration-Team-Current, 10Flow: Problem while converting from LiquidThreads to Flow - https://phabricator.wikimedia.org/T128949#2097891 (10Mattflaschen) a:3Mattflaschen [00:55:54] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): 'Mark as read' dots menu is misaligned - https://phabricator.wikimedia.org/T126686#2097910 (10Mooeypoo) This is fixed now. [00:59:40] Comment of the day: "2005-01-03, by dubious request on Ts's talk page" [01:02:25] matt_flaschen, ha where was that? [01:02:35] mooeypoo, InitialiseSettings.php [01:03:08] mooeypoo, I'm trying to find if there are any languages where formatNum does anything for 0-99. [01:03:21] The comma-dot thing shouldn't be in play, so it's really just if you use totally different digits.] [01:03:28] Punjabi is given as an example, but it doesn't work for me locally. [01:04:02] RoanKattouw, should know more (he mentioned something) but I think there are certain languages where that might be true? [01:04:04] ping RoanKattouw [01:07:43] Bengali [01:07:46] matt_flaschen: mooeypoo: arabic? (ar) [01:07:54] And any other language with a digitTransformTable [01:07:54] oh, actually, they disable it. ckb then [01:08:12] Yeah ar has one in CLDR but arwiki disables it (which results in a fun bug when momentjs is used) [01:08:31] has one is MessagesAr.php too. but wgTranslateNumerals is false [01:08:39] But only on arwiki, right? [01:09:01] that bug being https://phabricator.wikimedia.org/T123845 [01:09:02] yes [01:09:07] And the Western Arabic Wikipedia or something; the moment.js bug was reported on a Wikipedia whose language name contains "Arabic" but isn't ar [01:09:19] Or, no, it was arwiki [01:09:21] Thanks MatmaRex [01:09:29] RoanKattouw, cool, thanks. [01:09:54] bn for those playing along at home. [01:11:23] MatmaRex, I don't know arabic well enough to say... [01:12:25] It's cool how the Bengali 2 sort of looks like a 2, but not exactly. [01:12:39] What's better is some of the digits that look like other ones [01:14:20] btw, RoanKattouw, remember how on friday we were talking about collapsing margins, and then "fixed" the problem to fit Pau's request on the ticket? [01:14:36] .... yeah, about that. It turns out that the yellow line in that ticket is what to *REMOVE* ... not... what... to add.... [01:18:37] RoanKattouw, if there are actually 99 notifications, should it show as 99, or 99+? [01:19:26] Hopefully we have the ability to distinguish 99 vs. 100+. [01:19:28] Let me check. [01:21:45] 99+ cross-wiki notifications in your popup, 99 cross-wiki notifications... you mark one as read, it vanishes and instead--- 99 cross-wiki notifications in your popup [01:21:51] ~~~ sing it ~~~~ [01:22:15] Take one down, pass it around, 99 cross-wiki notifications in your popup. [01:22:22] Or 98, depending how RoanKattouw answers my question! [01:22:25] ~o/ [01:22:29] Exactly [01:22:31] mooeypoo: See I know that's what he *said* but I'm skeptical [01:22:42] ... that's what who said? [01:22:52] He said he wanted the heading "Spanish Wikipedia" to be closer to the list of notifications from Spanish Wikipedia [01:22:54] Pau [01:23:09] RoanKattouw, I re-read the ticket now. He wants 15px above the title, 10px below the title [01:23:13] I'm making sure now [01:23:13] Reducing the amount of space above the heading accomplishes the opposite of that [01:23:17] Yes, 15px above and 10px below [01:23:26] We distinguish 99 from 100 or more. [01:23:37] I thought that's what we verified friday, but Elena looked and we went over it and got confused again [01:23:38] The margin-bottom of the notif list *above* the heading is 5px, and the heading has 10px above and below [01:23:46] yeah [01:23:48] meh [01:23:53] Since the limit is 99 + 1 in the gateway query. [01:24:06] matt_flaschen: AFAIK it's 98, 99, 99+ but don't quote me on that [01:24:10] matt_flaschen, I would imagine that 99 means actual 99 notifications, and 99+ means 100 and up? [01:24:53] RoanKattouw, okay, I just verified, it's 15px above, 10px below [01:24:59] I'm going to toss it back to Elena [01:25:03] Well, 99+ could legitimately mean >=99 right? [01:25:22] RoanKattouw, yes, that was my case in the task. [01:25:36] But currently it is ">99 is 99+" [01:25:44] But I would prefer 99+ means >=99 [01:25:55] This is for https://phabricator.wikimedia.org/T127288 BTW. [01:26:12] Re bn digits, ৪ is ... 4 :) [01:26:45] :) [01:27:49] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2097958 (10Mooeypoo) @Etonkovidova and I looked at this,... [01:28:08] RoanKattouw, why would 99+ be >= and not > ? [01:28:12] the + means more [01:28:46] ... I guess it's a matter of perspective, and you two seem to agree against me, so I'll concede the plus. [01:30:28] The current code doesn't agree with me, though. [01:31:35] Code you can fix [01:31:54] A confused RoanKattouw is harder to fix [01:32:20] Seriously, though -- how many users do we actually think this happens to? [01:32:21] I can see both arguments too [01:32:32] I mean... it might be not worth the fixing in the code at all? [01:32:50] This is only if you have tons of x-wiki unread notifications, right? [01:32:59] mooeypoo, that's not the main reason I'm doing this commit. The main reason is T127288 which is to satisfy various languages. It's not just for the 99 use case. [01:33:16] oh, I know the commit in general, I'm saying specifically about this issue [01:33:16] See https://gerrit.wikimedia.org/r/#/c/268164/8/i18n/qqq.json [01:33:43] mooeypoo, well, I have to change a bunch of stuff anyway, but I can leave this part the same if that's the consensus. [01:34:02] It just feels weird to say 99+ if we know it's not 99. [01:34:45] Yeah [01:34:53] wow, I didn't think about siebrand's point actually [01:34:55] interesting [01:36:07] ok I'm heading out. I'll see you all tomorrow! [01:36:15] Have a good night. [01:41:54] (03PS6) 10Catrope: Defer onPersonalUrls() DB writes to post-send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250761 (https://phabricator.wikimedia.org/T117531) (owner: 10Aaron Schulz) [01:42:13] (03CR) 10Catrope: [C: 032] Defer onPersonalUrls() DB writes to post-send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250761 (https://phabricator.wikimedia.org/T117531) (owner: 10Aaron Schulz) [01:42:52] (03PS3) 10Catrope: Fix EchoAttributeManager::getNotificationSection() php doc [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275603 (owner: 10Legoktm) [01:43:11] (03PS2) 10Catrope: EchoTargetPage: Don't call Title::newFromId() repeatedly [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275721 (owner: 10Legoktm) [01:43:34] (03CR) 10Catrope: [C: 032] EchoTargetPage: Don't call Title::newFromId() repeatedly [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275721 (owner: 10Legoktm) [01:44:13] (03CR) 10Catrope: [C: 032] Fix EchoAttributeManager::getNotificationSection() php doc [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275603 (owner: 10Legoktm) [01:47:29] Dean from my coworking place also interprets it as more than 99. So I'll probably just leave it. [01:56:55] (03Merged) 10jenkins-bot: Defer onPersonalUrls() DB writes to post-send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250761 (https://phabricator.wikimedia.org/T117531) (owner: 10Aaron Schulz) [01:56:58] (03Merged) 10jenkins-bot: EchoTargetPage: Don't call Title::newFromId() repeatedly [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275721 (owner: 10Legoktm) [01:57:01] (03Merged) 10jenkins-bot: Fix EchoAttributeManager::getNotificationSection() php doc [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275603 (owner: 10Legoktm) [03:21:29] Is it just me, or is it weird to say e.g. "Smith and 1 other responded on your talk page"? [03:21:41] 2 others would sound fine, but shouldn't it be 1 other user? [03:57:06] See you all tomorrow [09:02:24] (03CR) 10Siebrand: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274657 (https://phabricator.wikimedia.org/T128711) (owner: 10Siebrand) [09:25:30] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Adjust contrast and hover behaviour for the secondary actions displayed directly on notifications - https://phabricator.wikimedia.org/T128444#2098281 (10Pginer-WMF) > For Pginer-WMF to take a look: Th... [09:43:55] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Action and timestamp position needs adjustment - https://phabricator.wikimedia.org/T125969#2098313 (10Pginer-WMF) It has improved with respect to the original situation, but @Etonkovidova points to two aspects that can benefit from a bit of ad... [10:54:46] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#2098441 (10Trizek-WMF) That's rea... [11:39:56] 3Collaboration-Team-Current, 6Design-Research-Backlog, 10Notifications: Invite Users to Take Notifications Survey (Using Notifications Panel) - https://phabricator.wikimedia.org/T128937#2098539 (10Pginer-WMF) >>! In T128937#2096840, @jmatazzoni wrote: > @Pginer-WMF, the mockup shown above is what people look... [11:43:16] 3Collaboration-Team-Current, 6Design-Research-Backlog, 10Notifications: Invite Users to Take Notifications Survey (Using Notifications Panel) - https://phabricator.wikimedia.org/T128937#2098560 (10Pginer-WMF) >>! In T128937#2096260, @Capt_Swing wrote: > @Pginer-WMF I agree we want to avoid showing this acros... [12:30:56] (03CR) 10Hashar: [C: 032] Remove use of "successful" in strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275410 (owner: 10Siebrand) [12:43:31] (03Merged) 10jenkins-bot: Remove use of "successful" in strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275410 (owner: 10Siebrand) [13:12:21] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review: Remove double emphasis in UI strings - https://phabricator.wikimedia.org/T128711#2098654 (10Pginer-WMF) For additional context, some of the considerations were discussed in T121724. With the bolding and the quotes I think we are try... [13:25:27] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2098664 (10Trizek-WMF) I've tried to move "User talk:Nbfreeh/Flow 存档 1" to "User talk:Nbfreeh". I get that message: > You do not have permission to move... [14:08:19] 6Collaboration-Team-Backlog, 10Notifications, 7Mobile: Mobile splitted notifications do not show numbers properly - https://phabricator.wikimedia.org/T125321#2098749 (10IKhitron) [14:08:23] (03PS17) 10Haritha28: Notification when account is blocked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264070 (https://phabricator.wikimedia.org/T100974) [14:24:42] (03CR) 10Aklapper: "Thanks! Please adjust the commit message by dropping unnecessary boilerplate text like "Changes have been made accordingly in the respecti" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264070 (https://phabricator.wikimedia.org/T100974) (owner: 10Haritha28) [14:49:25] (03PS18) 10Haritha28: Notification when account is blocked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264070 (https://phabricator.wikimedia.org/T100974) [15:01:56] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 10Notifications: Echo and Flow fail on Thanks 'check experimental' ('generic') tests - https://phabricator.wikimedia.org/T128613#2098923 (10hashar) [15:02:01] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 10Notifications: Echo failure with Flow or Thanks 'check experimental' - https://phabricator.wikimedia.org/T128627#2098924 (10hashar) [15:02:08] 3Collaboration-Team-Current, 10Flow, 10Thanks: Flow failure with Thanks 'check experimental' - https://phabricator.wikimedia.org/T128628#2098925 (10hashar) [15:06:42] 6Collaboration-Team-Backlog, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2098951 (10darthbhyrava) @Legoktm would you be able to co-mentor this project for this round of GSoC? [15:49:04] 6Collaboration-Team-Backlog, 10Flow: Flow should be able to enumerate all flow enabled pages on a wiki - https://phabricator.wikimedia.org/T63747#2099131 (10Trizek-WMF) Concerning Flow satisfaction survey, I'll need to send a message to all Flow users. For this, I need to have an (hidden) category on each wiki... [16:01:40] (03CR) 10Aklapper: "@Haritha28: Please see again the link I provided in my previous comment and improve the commit message by not using passive constructions." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264070 (https://phabricator.wikimedia.org/T100974) (owner: 10Haritha28) [16:03:44] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 3Liaisons-March-2016, 7Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2099202 (10Trizek-WMF) [16:04:24] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 3Liaisons-March-2016, 7Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#1993170 (10Trizek-WMF) I've contacted three users and integrated feedback from the Collaboration team. [16:49:49] 6Collaboration-Team-Backlog, 10MediaWiki-Email, 5MW-1.27-release-notes, 13Patch-For-Review, and 2 others: Correct parameter docs in UserMailer::sendWithPear() - https://phabricator.wikimedia.org/T68673#2099349 (1001tonythomas) [16:50:34] (03PS1) 10Matthias Mullie: Flow dumps XSD schema [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275843 (https://phabricator.wikimedia.org/T112799) [16:51:49] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 13Patch-For-Review, 7WorkType-Maintenance: Create XML Schema for Flow dump format(s) - https://phabricator.wikimedia.org/T112799#2099357 (10matthiasmullie) Patch in gerrit. Writings XSDs is not something I do every day, please review car... [16:53:21] 6Collaboration-Team-Backlog, 10MediaWiki-Email, 5MW-1.27-release-notes, 13Patch-For-Review, and 2 others: Correct parameter docs in UserMailer::sendWithPear() - https://phabricator.wikimedia.org/T68673#2099379 (1001tonythomas) This one is resolved, fixed after https://gerrit.wikimedia.org/r/#/c/273228/. Ti... [17:43:17] (03CR) 10Glaisher: [C: 04-1] "This doesn't do what the commit says at all currently. You might want to read the documentation for adding new events before working on th" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264070 (https://phabricator.wikimedia.org/T100974) (owner: 10Haritha28) [17:44:39] (03CR) 10Brion VIBBER: "Couple quick notes:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275843 (https://phabricator.wikimedia.org/T112799) (owner: 10Matthias Mullie) [17:50:07] 6Collaboration-Team-Backlog, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2099637 (10Legoktm) I'd be willing to mentor this, but I'm not sure it's large enough for a full GSoC project? [17:52:17] (03CR) 10Brion VIBBER: Flow dumps XSD schema (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275843 (https://phabricator.wikimedia.org/T112799) (owner: 10Matthias Mullie) [17:58:14] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2099676 (10Mattflaschen) >>! In T127693#2098664, @Trizek-WMF wrote: > I've tried to move "User talk:Nbfreeh/Flow 存档 1" to "User talk:Nbfreeh". I get that... [18:05:48] 6Collaboration-Team-Backlog, 10Notifications, 13Patch-For-Review, 7Performance, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Echo DB writes on page views - https://phabricator.wikimedia.org/T117531#2099702 (10Legoktm) 5Open>3Resolved a:3Legoktm [18:12:38] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2099736 (10Trizek-WMF) >>! In T127693#2099676, @Mattflaschen wrote: > I don't think flow-create-board itself should grant deletion, but it might be reaso... [19:24:47] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, and 2 others: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2100141 (10Etonkovidova) Checked in betalabs - the screenshots are for uselang=uk (Ukranian) , zh ( Simplified Ch... [19:26:27] RoanKattouw, stephanebisson, it seems we are actually using the old API formatting in Special:Notifications like I remembered. The structure that comes pre-built from the API that includes "
" plus the entire structure :\ [19:27:22] I can change that structure from where we build it, but that would ruin backwards compatibility. How much do we care about that? Or should I just rewrite this to be in a better (ooui-php maybe?) structure, so we can actually add "mark as read" button to each of them [19:28:15] mooeypoo: what do you mean by "old API" in this case? [19:28:15] We're currently using $row['*'] for the content of the
  • in each notification :\ [19:28:32] So, we are using the new presentation models [19:28:34] we're using the presentation models, with the special page formatter [19:28:37] However, we are using the back compat HTML formatter [19:28:43] Instead of usng the structured data and building the widget like we do now in JS, we are using the old html formatter [19:28:47] AFAIK [19:28:54] Or.... no I think stephanebisson might be right that it's a special formatter [19:29:00] Hm. Is it? [19:29:02] might be [19:29:11] You're right [19:29:14] okay, so I can just change that [19:29:16] Well obviously for no-JS we'll have to keep an HTML formatter [19:29:25] SpecialNotificationsFormatter.php [19:29:38] Although I did file a task about how its HTML output and associated CSS should probably be better [19:29:54] I just want to say that I dislike this in general. I think we need to do this properly with structured data. HOWEVER... that'll take longer, so since we agreed we should leave things as-is more or less and not waste oto much time on no-js, it's probably easier to just fix up the special formatter for now [19:29:55] The mindset with which SpecialNotificationsFormatter.php was written was "let's not make anything break" [19:30:41] Yeah, meh, okay. The classes are also different. [19:31:14] Yeah, exactly, that's what I meant by "HTML output and associated CSS" [19:31:50] RoanKattouw, I could do this by hand, but if we really want the styles to be the same, we should ooui'fy. Probably not a priority right now, though. [19:32:07] I'll start with the simple stuff, we can figure out later how deep into this we want to go [19:32:24] we said yesterday we do't really care about the style being the same [19:32:27] But we need to know that this means we are basically maintaining two distinct styles [19:32:30] *don't [19:33:01] stephanebisson, between the nojs and js, but I don't know if we should keep this as distinct as not looking the same in the notification itself, no? [19:33:17] "maintain" for the js and no-js versions mean 2 different things [19:34:33] I mean that we should probably not want to make the no-js look like the "inbox" style (minus the filters and interactive stuff) -- but it will make our maintenance lives easier (and the system will look better, imho) if the notification pieces use the same styling... especially since we take so much time styling the js version anyways [19:34:41] but it's not that crucial, either. [19:34:58] I just think it could be a good thing for a tech-debt TODO [19:35:30] if the no-js in still and the js is changing rapidly, keeping them consistent is more work I think [19:35:59] The styles will change together, though, in that case. [19:36:17] but the markup (and features) are different [19:36:25] Colors, sizing, the padding of the buttons (which we are spending a lot of time on back and forth :p ) all that will be consistent [19:37:31] the markup doesn't have to be all different. The base could be the same, minus the interactive stuff. Hover effects could be the same, "seen unseen" effect is CSS, could be the same, the styling of the actual notification internally could be the same -- except that in no-js the notification markup doesn't include the ... menu [19:38:26] But also, it's not that crucial. We said that the number of users that actually see this is fairly low. I just think we can get relative easy "wins" with the design if we go that route - not complete sameness, but more-same-than-not to gain some of the css styles. [19:43:22] 6Collaboration-Team-Backlog, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2100264 (10jayvdb) [19:43:59] (03PS2) 10Catrope: Fix duplicate impression logging [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274342 [19:44:27] (03CR) 10Catrope: [C: 04-1] "Now no longer duplicated because the Echo API change removed some of the other impressions code." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274342 (owner: 10Catrope) [19:49:38] 6Collaboration-Team-Backlog, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2100281 (10jayvdb) [19:53:11] 6Collaboration-Team-Backlog, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2100287 (10darthbhyrava) >>! In T129049#2099637, @Legoktm wrote: > I'd be willing to mentor this, but I'm not sure it's large enoug... [19:53:25] 6Collaboration-Team-Backlog, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2100290 (10jayvdb) [19:56:19] (03CR) 10Catrope: "Never mind, the code the Echo API change removed was yet another duplicate, but at least it was calling the function that filters duplicat" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274342 (owner: 10Catrope) [20:00:34] Shit [20:02:11] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), and 2 others: Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2100370 (10Catrope) >>! In T128249#2097659, @gerritbot wrote: > Change 274908 merged b... [20:05:26] (03PS1) 10Catrope: Add debug logging for when the thank-you-edit code detects a race condition [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275898 (https://phabricator.wikimedia.org/T128249) [20:05:45] legoktm: ---^^ :( [20:05:56] 6Collaboration-Team-Backlog, 10Thanks: False "thanked" confirmation for users with thanks disabled - https://phabricator.wikimedia.org/T57401#591351 (10jayvdb) This could be the source of problems during editing disputes, where one participant has thanked an 'opponent' for a good edit, which should be a quick... [20:08:44] 6Collaboration-Team-Backlog, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2100397 (10jayvdb) [20:09:53] (03CR) 10Catrope: [C: 032] "Come on Jenkins" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) (owner: 10Bmansurov) [20:10:10] (03CR) 10Catrope: "Oh, never mind, the dependency in MobileFrontend is not merged yet." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) (owner: 10Bmansurov) [20:11:19] (03CR) 10Legoktm: [C: 032] Add debug logging for when the thank-you-edit code detects a race condition [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275898 (https://phabricator.wikimedia.org/T128249) (owner: 10Catrope) [20:11:23] Thanks legoktm [20:11:25] RoanKattouw: uh, whoops :/ [20:11:30] Yeah... not sure why yet [20:11:45] Although I imagine incEditCount is itself deferred, so maybe we're missequencing deferred updatse? [20:12:08] Hmm it uses onTransactionPreCommitOrIdle [20:12:19] Which I don't know much about but you'd think that'd run before DeferredUpdates do [20:13:00] 6Collaboration-Team-Backlog, 10Thanks: False "thanked" confirmation for users with thanks disabled - https://phabricator.wikimedia.org/T57401#2100409 (10jayvdb) [20:13:10] 6Collaboration-Team-Backlog, 10Thanks: Thanks should hide the thanks link in diff and history views when contributor disabled notifications - https://phabricator.wikimedia.org/T72765#2100412 (10jayvdb) [20:13:13] 6Collaboration-Team-Backlog, 10Thanks: False "thanked" confirmation for users with thanks disabled - https://phabricator.wikimedia.org/T57401#591351 (10jayvdb) [20:13:31] 6Collaboration-Team-Backlog, 10Thanks: False "thanked" confirmation for users with thanks disabled - https://phabricator.wikimedia.org/T57401#591351 (10jayvdb) [20:16:41] 6Collaboration-Team-Backlog, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2100427 (10jayvdb) [20:28:53] 6Collaboration-Team-Backlog, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2100484 (10jayvdb) [20:33:17] 6Collaboration-Team-Backlog, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2100503 (10jayvdb) >>! In T129049#2099637, @Legoktm wrote: > I'd be willing to mentor this, but I'm not sure it's large enough for... [20:35:28] (03Merged) 10jenkins-bot: Add debug logging for when the thank-you-edit code detects a race condition [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275898 (https://phabricator.wikimedia.org/T128249) (owner: 10Catrope) [20:47:14] (03PS1) 10Catrope: Add debug logging for when the thank-you-edit code detects a race condition [extensions/Echo] (wmf/1.27.0-wmf.15) - 10https://gerrit.wikimedia.org/r/275909 (https://phabricator.wikimedia.org/T128249) [20:47:40] (03PS1) 10Catrope: Add debug logging for when the thank-you-edit code detects a race condition [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/275910 (https://phabricator.wikimedia.org/T128249) [20:51:12] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Use more compact timestamps for notifications - https://phabricator.wikimedia.org/T125970#2001832 (10Etonkovidova) The short abbreviations have been added - see the examples in the screenshots for sec... [20:55:24] (03CR) 10jenkins-bot: [V: 04-1] Add debug logging for when the thank-you-edit code detects a race condition [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/275910 (https://phabricator.wikimedia.org/T128249) (owner: 10Catrope) [20:57:26] ... [20:58:07] (03CR) 10Catrope: "recheck" [extensions/Echo] (wmf/1.27.0-wmf.16) - 10https://gerrit.wikimedia.org/r/275910 (https://phabricator.wikimedia.org/T128249) (owner: 10Catrope) [20:58:15] 6Collaboration-Team-Backlog, 10Thanks: False "thanked" confirmation for users with thanks disabled - https://phabricator.wikimedia.org/T57401#2100617 (10Quiddity) >>! In T57401#591364, @Legoktm wrote: > If we don't show the thanks link, that would technically expose the users preference to not receive thanks.... [21:08:51] 6Collaboration-Team-Backlog, 10Pywikibot-Flow, 10Thanks, 10Possible-Tech-Projects, 10pywikibot-core: Pywikibot support for Thanks - https://phabricator.wikimedia.org/T129049#2100660 (10darthbhyrava) @jayvdb thanks a lot for expanding the project details. :D I would like to take this project up for this... [21:10:36] 6Collaboration-Team-Backlog, 10WikiLove: WikiLove: Stylesheet should not embed both png and svg version of image - https://phabricator.wikimedia.org/T64000#2100664 (10Krinkle) a:3Krinkle [21:11:54] (03PS1) 10Krinkle: Clean up hook usage [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275918 [21:11:56] (03PS1) 10Krinkle: Various WikiLove JavaScript clean up [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275919 (https://phabricator.wikimedia.org/T64000) [21:16:46] (03PS2) 10Krinkle: Various WikiLove JavaScript clean up [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275919 (https://phabricator.wikimedia.org/T64000) [21:17:15] (03PS3) 10Krinkle: Various WikiLove performance clean up [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/275919 (https://phabricator.wikimedia.org/T64000) [21:21:14] 6Collaboration-Team-Backlog, 10WikiLove, 13Patch-For-Review: WikiLove: Stylesheet should not embed both png and svg version of image - https://phabricator.wikimedia.org/T64000#2100708 (10Krinkle) [21:21:16] 6Collaboration-Team-Backlog, 10WikiLove, 7Performance: Investigate WikiLove's performance - https://phabricator.wikimedia.org/T60192#2100707 (10Krinkle) [21:23:01] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Roll out cross-wiki notifications beta feature - https://phabricator.wikimedia.org/T124234#2100711 (10Catrope) >>! In T124234#2100689, @gerritbot wrote: > Change 275930 had a related patch set uploaded (by Catrope): > Enable cr... [21:25:41] (03CR) 10Catrope: [C: 04-1] "Unit tests fail because there is no apihelp-echomarkread-param-unreadlist message documenting the new unreadlist parameter" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) (owner: 10Mooeypoo) [21:31:21] (03Abandoned) 10Krinkle: Compress PNGs with zopflipng [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/272282 (https://phabricator.wikimedia.org/T127608) (owner: 10Ori.livneh) [21:32:33] (03CR) 10Krinkle: [C: 032] Set license-name property [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/273838 (owner: 10Legoktm) [21:36:18] (03Merged) 10jenkins-bot: Set license-name property [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/273838 (owner: 10Legoktm) [21:45:38] mooeypoo: https://gerrit.wikimedia.org/r/#/c/274342/ [21:48:44] 3Collaboration-Team-Current, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Fix namespace movable hook - https://phabricator.wikimedia.org/T128694#2083026 (10Etonkovidova) Checked in betalabs: regression testing for Move Flow boards - all seem to be normal. Note: 1) There is no notifications... [21:50:40] (03CR) 10Mooeypoo: [C: 04-1] "Looks good in general, minor comment about variable order." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274342 (owner: 10Catrope) [21:54:21] stephanebisson: is Special:ContentTranslation working in betalabs? Cannot make it work... [21:56:43] 3Collaboration-Team-Current, 10Notifications: Remove unused Echo code - https://phabricator.wikimedia.org/T125861#1999234 (10Etonkovidova) General regression testing was done in betalabs - all look fine. [21:59:16] 6Collaboration-Team-Backlog, 10Notifications, 7Technical-Debt: Get rid of old phantomjs/qunit Echo code and helper scripts - https://phabricator.wikimedia.org/T129282#2100866 (10Legoktm) [22:01:48] etonkovidova: sort of [22:02:31] etonkovidova: the page is up but it cannot find the page I chose to translate... [22:02:41] stephanebisson: exactly [22:03:01] stephanebisson: it's also does not see pages created by me... hmm [22:07:14] stephanebisson: and I need to check those translation notifications [22:07:58] RoanKattouw_away, we're still good for tomorrow's Beta Feature global enable? [22:08:38] nvm, I see confirmation in https://phabricator.wikimedia.org/T124234#2100711 [22:08:43] etonkovidova: cx relies on a servie that is separate from mediawiki, it might be down or something [22:08:52] etonkovidova: I'm not sure who to ping about this [22:09:18] stephanebisson: asking amir... [22:11:43] quiddity: Thursday, not tomorrow [22:11:53] quiddity: At 8am PDT, so I'm gonna have to get up early [22:12:01] err, that's what i mean. >.> [22:12:09] (I didn't want to do it at 4pm because then we don't have all day to deal with things if needed) [22:12:15] yikes, condolences! [22:12:19] nod [22:12:20] ty! [22:12:30] Well I can do it from home in my PJs etc [22:12:38] Alarm at 7:45 :) [22:14:41] ah, so full-consciousness-not-required... ;P [22:27:00] stephanebisson: amir communicated the issue to the proper channels :) and we checked the translations notifications in production [22:27:09] stephanebisson: all is good [22:40:34] 3Collaboration-Team-Current, 10MediaWiki-extensions-ContentTranslation, 10Notifications, 5ContentTranslation-Release8, and 3 others: Update ContentTranslation notifications to new language and format - https://phabricator.wikimedia.org/T125680#1994589 (10Etonkovidova) Thanks to @Amire80 - checked in produc... [23:05:41] (03PS1) 10Krinkle: Remove broken and obsolete WikiLoveLocal::getMessages() method [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/276034 [23:12:07] RoanKattouw, et al, anything I should bring up at tomorrow's SoS besides cross-wiki notifications beta feature going to all wikis? [23:12:26] Our struggles with thank-you-edit perhaps [23:12:56] And anything blocking you and/or Matthias with Flow dumps or external store? [23:12:57] * RoanKattouw doesn't actually know the status of those things [23:15:08] RoanKattouw, don't think so. Matthias has a patch up for XSD (which has a review), I need to update my make-all-blobs patch. [23:15:18] RoanKattouw, should I ask anyone for help for thank-you, perf team, maybe? [23:16:59] (03CR) 10Krinkle: "Caused "PHP Warning: in_array() expects parameter 2 to be array, string given" in ResourceLoader->getModulesByMessage" [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/276034 (owner: 10Krinkle) [23:17:41] (03CR) 10Jforrester: [C: 032] Remove broken and obsolete WikiLoveLocal::getMessages() method [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/276034 (owner: 10Krinkle) [23:18:07] No, Lego and I are making progress on thank-you, it's just that the back-and-forths take time [23:18:33] Deploy logging patch, wait for logs to come in, deploy fix, discover it actually breaks it, deploy more logging, etc [23:19:53] And there's a business day in between each step :/ [23:20:10] I'm not sure it's worth bringing up in SoS other than that people have asked when it'll be turned back on [23:21:16] // @Todo - replace them with the CONSTANT in 33810 once it is merged [23:21:27] * legoktm notes that that patch was merged in Dec 2012. [23:26:38] (03Merged) 10jenkins-bot: Remove broken and obsolete WikiLoveLocal::getMessages() method [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/276034 (owner: 10Krinkle) [23:34:00] (03PS8) 10Legoktm: [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) [23:34:03] (03PS1) 10Legoktm: Clean up some code in EchoEmailBatch [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276044 [23:34:37] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [23:34:48] (03CR) 10jenkins-bot: [V: 04-1] Clean up some code in EchoEmailBatch [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276044 (owner: 10Legoktm) [23:37:51] (03PS9) 10Legoktm: [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) [23:37:54] (03PS2) 10Legoktm: Clean up some code in EchoEmailBatch [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276044 [23:46:33] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [23:52:21] Umm. [23:52:23] "Exception encountered, of type "BadMethodCallException"" [23:52:36] On MW.org. [23:53:21] https://www.mediawiki.org/wiki/Topic:Sztl7fb1akhaoido [23:53:36] Thanks, James_F. Looking. [23:53:55] James_F, I don't see it. Are you logged in or out? [23:54:04] James_F, did you try to post or just get it on view? [23:55:30] James_F, I'm digging up the exception. [23:57:23] It's an Echo bug. The plot thickens. [23:58:35] I know what's going on [23:58:38] Well, kind of [23:58:53] I am almost certain that https://gerrit.wikimedia.org/r/#/c/250761/ caused it and I need to revert it [23:58:57] Which I will do right now [23:59:01] I don't understand *why* it breaks though [23:59:06] ( matt_flaschen ) [23:59:10] (03PS1) 10Catrope: Revert "Defer onPersonalUrls() DB writes to post-send" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276053 [23:59:31] (03PS2) 10Catrope: Revert "Defer onPersonalUrls() DB writes to post-send" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276053 [23:59:36] whaat [23:59:36] (03CR) 10Catrope: [C: 032] Revert "Defer onPersonalUrls() DB writes to post-send" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/276053 (owner: 10Catrope) [23:59:44] :S [23:59:48] 6Collaboration-Team-Backlog, 10Notifications: BadMethodCall in PersonalUrls - https://phabricator.wikimedia.org/T129299#2101530 (10Mattflaschen) [23:59:59] 6Collaboration-Team-Backlog, 10Notifications: BadMethodCall in PersonalUrls - https://phabricator.wikimedia.org/T129299#2101544 (10Mattflaschen) @Catrope is already reverting.