[00:00:58] (03Merged) 10jenkins-bot: Change "Expand N alerts/messages" to "View N alerts/messages" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274162 (https://phabricator.wikimedia.org/T121936) (owner: 10Catrope) [00:02:35] matt_flaschen, there's another patch waiting for that [00:02:53] (03PS3) 10Mooeypoo: Mark all as read should not apply to cross-wiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274480 (https://phabricator.wikimedia.org/T128621) [00:03:33] matt_flaschen, okay, there were 2 fixes: one to make "mark all as read" ignore x-wiki bundles (that's not merged: https://gerrit.wikimedia.org/r/#/c/274480/) and another, merged, to make the "mark bundle as read" work, and that one only marks the *existing* items inside the bundle. [00:04:01] mooeypoo, this is not related to cross-wiki. [00:04:05] They're all local. [00:06:52] matt_flaschen, oh, yes, that marks *all* as read. [00:06:56] we have a comment that we should fix that [00:07:25] Okay, I just wanted to make sure it was a known issue. [00:07:32] as a "TODO" comment.. but I didn't touch it because that's the way things worked up to now. I am almost sure I fixed it in the echo api (or subsequent) commits,though [00:07:57] the Echo API introduces a method that is markItemsAsRead( itemId ) [00:08:17] mooeypoo, not in the Echo API one, since it marked read all notifications I carefully hoarded to test Matthias's 'only mark read notifications' patch. ;) [00:08:19] This was used for the bundles... and *can* (and *should*) be used for all the popup. [00:08:35] Possibly in a follow up in the chain, though. [00:08:41] no I think it's in a subsequent one, let me find it [00:08:44] i remember working on that [00:09:02] matt_flaschen, https://gerrit.wikimedia.org/r/#/c/274480/3/modules/viewmodel/mw.echo.dm.NotificationsModel.js [00:09:08] there it is. [00:09:56] matt_flaschen, this commit will basically mean we're stopping the use of "markallread" in the API in general [00:10:10] (except for the special page which no one touched) [00:10:23] actually, the special page does that in the back end anyways [00:10:50] Got it, thanks. [00:19:37] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2063036 (10Catrope) >>! In T128069#2083578, @Pginer-WMF wrote: > Yes, the spacing does not seem to... [00:20:28] (03PS1) 10Catrope: Use padding instead of margin to separate cross-wiki sections from each other [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274853 (https://phabricator.wikimedia.org/T128069) [00:21:05] (03CR) 10Mooeypoo: [C: 032] "Boo to margin collapse." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274853 (https://phabricator.wikimedia.org/T128069) (owner: 10Catrope) [00:23:09] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273560 (https://phabricator.wikimedia.org/T125970) (owner: 10Mooeypoo) [00:23:34] matt_flaschen: Re careful hoarding, you should use Stephane's script if you aren't already :) [00:24:18] RoanKattouw, I am. It's still running, though. I only have 976 total (read/unread). I need at least 2000 to test mlitn's patch. [00:24:35] We should try and see if we can make it work with flow notifications (in Flow maybe?) [00:24:38] Oh, right! [00:24:52] it's pretty annoying that it's only producing 1 message and 10 alerts, when alerts are automatically marked as ready [00:24:53] It's not really a big deal that some got marked as read earlier. I just need a few unread and 2000+ total, to make sure the unread stay unread. [00:24:54] read* [00:26:50] I mean unread are not deleted. [00:31:02] (03Merged) 10jenkins-bot: Use padding instead of margin to separate cross-wiki sections from each other [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274853 (https://phabricator.wikimedia.org/T128069) (owner: 10Catrope) [00:33:46] 3Collaboration-Team-Current, 10Flow, 10Notifications: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2087046 (10jmatazzoni) I wrote up a spec for the language and links on this. Please see [[ https://docs.google.com/spreadsheets/d/1XjPO8RlrFMqNhboWBUZwONJv93... [00:36:02] 3Collaboration-Team-Current, 10Flow, 10Notifications: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2087055 (10jmatazzoni) Copied from T125119: > Regarding the issue of what to do when a topic is both summarized and resolved at the same time: Thanks fo... [00:36:41] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests: Populate echo_unread_wikis table on all wikis - https://phabricator.wikimedia.org/T124233#2087057 (10Catrope) I just started a cluster-wide run with `catrope@terbium:/srv/mediawiki/php-1.27.0-wmf.15$ foreachwiki extensions/Echo/maintenance/backfillUnreadW... [00:36:45] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests: Populate echo_unread_wikis table on all wikis - https://phabricator.wikimedia.org/T124233#2087058 (10Catrope) a:3Catrope [00:44:30] 6Collaboration-Team-Backlog, 10Notifications, 7Design, 7Mobile: When not using MobileFrontend, Echo does not appear well on small screens, because it does not use responsive design - https://phabricator.wikimedia.org/T126106#2087096 (10codynguyen1116) p:5Triage>3High [00:47:34] (03CR) 10Mattflaschen: [C: 032] "Works great now." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [01:00:58] (03Merged) 10jenkins-bot: Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [01:02:07] \o/ [01:02:19] (03Merged) 10jenkins-bot: Mark all as read should not apply to cross-wiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274480 (https://phabricator.wikimedia.org/T128621) (owner: 10Mooeypoo) [01:05:59] Getting dinner [02:26:06] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2087320 (10jmatazzoni) A couple of responses on the issue about local opt in: **Issue #1) ** @Quiddity wrote: > - This invit... [02:31:13] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2087326 (10Catrope) Now that all wikis are on wmf15, I loo... [02:31:36] quiddity: News on the thank-you-edit bug ---^^ [02:32:29] TLDR version: the main bug is fixed, but we're still seeing a few cases of duplication when edits occur in the same second, and why that happens is not a mystery [02:36:32] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2087327 (10Legoktm) >>! In T128249#2087326, @Catrope wrote... [02:37:00] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2087328 (10Catrope) (off-topic) While writing the above, I... [02:38:24] hehe [02:38:30] that's a funny coincidence [02:38:41] * legoktm goes afk [02:41:03] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2087329 (10Catrope) >>! In T128249#2087327, @Legoktm wrote... [02:43:08] (03CR) 10Catrope: [C: 032] Add a short abbreviation for timestamps in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273560 (https://phabricator.wikimedia.org/T125970) (owner: 10Mooeypoo) [02:50:21] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2087342 (10Catrope) >>! In T117669#2087320, @jmatazzoni wrote: >> - This invitation would not be shown to a user, unless/until t... [02:52:25] (03Merged) 10jenkins-bot: Add a short abbreviation for timestamps in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273560 (https://phabricator.wikimedia.org/T125970) (owner: 10Mooeypoo) [03:18:29] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2087390 (10jmatazzoni) > I think this was also referring to an older proposal OMG, I did not see the dates on people's comments... [03:33:33] 3Collaboration-Team-Current, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Fix namespace movable hook - https://phabricator.wikimedia.org/T128694#2087400 (10Catrope) a:3Mattflaschen [03:34:31] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Fix "InvalidDataException from NotificationListener.php: Invalid metadata for revision" - https://phabricator.wikimedia.org/T89691#2087403 (10Catrope) 5Open>3Resolved [04:27:24] legoktm, you around? [04:32:25] matt_flaschen: am now [04:34:56] legoktm, I ran into a problem with ExtensionRegistry and overrides. [04:35:08] I almost figured it out, just need to figure out which merge strategy to change it to. [04:35:46] https://git.wikimedia.org/blob/mediawiki%2Fvagrant.git/master/puppet%2Fmodules%2Frole%2Fmanifests%2Fsitematrix.pp [04:36:01] oh, what's up? I have done a really shitty job of documenting that, by which I mean I haven't documented it at all [04:36:21] :) [04:36:58] Basically, it is setting a sub-sub-field (see link above), but then the merge strategy takes that as *all* of 'wiki' [04:37:03] When it should keep the other parts of 'wiki'. [04:37:14] I just need to play with the PHP shell to remember the right one. [04:37:14] oh, you want a merge strategy of 'array_plus_2d' [04:37:24] I was more stumped when I first pinged you. :) [04:38:48] Okay, cool. In this case, it's also wrong in Vagrant (it needs to override more), but I should fix the merge strategy too. [04:48:45] legoktm, thanks: https://gerrit.wikimedia.org/r/274902 [04:50:14] I will take a look after dinner! [04:54:05] Cool, thanks. [04:54:15] It's just the merge strategy. [04:55:14] Patch for Vagrant coming as well (just because it really ought to set it correctly, not required to pass the test) [05:33:31] (03CR) 10Mattflaschen: [C: 04-1] "When I tested it happened to try to delete notifications, none of which had echo_target_page. This triggered an error." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [05:37:28] Vagrant piece: https://gerrit.wikimedia.org/r/274903 [05:38:18] Have a good night, all. [05:50:23] (03PS1) 10Legoktm: Try and avoid race conditions with thank-you-edit notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274904 (https://phabricator.wikimedia.org/T128249) [05:55:14] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2087509 (10Legoktm) >>! In T128249#2087329, @Catrope wrote... [06:57:18] 3Collaboration-Team-Current, 10Beta-Cluster-Infrastructure, 10DBA, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2087608 (10jcrespo) I can fix production, but I need the original script for that (even if it is non... [07:15:58] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2087627 (10Catrope) >>! In T128249#2087509, @Legoktm wrote... [07:17:14] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-ContentTranslation, 10Notifications, 7Design, 7WorkType-NewFunctionality: Encourage users to publish old inactive unpublished translations - https://phabricator.wikimedia.org/T89707#2087631 (10Arrbee) [08:27:01] 3Collaboration-Team-Current, 10Beta-Cluster-Infrastructure, 10DBA, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2087771 (10hashar) The `wikiadmin_pass` was provisioned via a puppet erb template: ``` #! /bin/bash... [08:37:24] 6Collaboration-Team-Backlog, 6Increasing-content-coverage, 10MediaWiki-extensions-ContentTranslation, 10Notifications, and 5 others: Notify translators about new personalised suggestions being available based on their recently published translation - https://phabricator.wikimedia.org/T119939#2087783 (10Pgin... [10:24:56] 3Collaboration-Team-Current, 10Flow, 10Notifications: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2087994 (10Pginer-WMF) >>! In T125654#2087046, @jmatazzoni wrote: > I'm moving this to Design/Product until the spec is validated. @Pginer-WMF, @Quiddity, @... [11:12:39] 6Collaboration-Team-Backlog, 10Flow, 10Notifications: Combine Flow resolved and summarised events when they are part of the "mark as resolved" workflow - https://phabricator.wikimedia.org/T128848#2088071 (10Pginer-WMF) [11:13:12] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Should get notified for topic summary change on your own user talk - https://phabricator.wikimedia.org/T125119#1978901 (10Pginer-WMF) > Regarding the issue of what to do when a topic is both... [12:13:09] 6Collaboration-Team-Backlog, 10Flow: Unformatted html within message about ip-block (for TOR users) - https://phabricator.wikimedia.org/T128855#2088228 (10Kaganer) [12:25:05] 6Collaboration-Team-Backlog, 10Flow: Unformatted html within message about ip-block (for TOR users) - https://phabricator.wikimedia.org/T128855#2088265 (10Kaganer) [12:35:18] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Action and timestamp position needs adjustment - https://phabricator.wikimedia.org/T125969#2088270 (10Pginer-WMF) In the diagram below I tried to represent (in grey) the icon areas. Since icons will have different shapes and aspect ratios, the... [12:44:45] 6Collaboration-Team-Backlog, 10Flow: Unformatted html within message about ip-block (for TOR users) - https://phabricator.wikimedia.org/T128855#2088294 (10Kaganer) [13:00:00] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2088335 (10Pginer-WMF) I reused the former ticket updating the description, sorry if that generated some confusion. > One thing... [15:41:23] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 3Liaisons-March-2016, 7Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2088584 (10Trizek-WMF) [15:42:09] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 3Liaisons-March-2016, 7Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#1993170 (10Trizek-WMF) Schedule: plan to have this survey finalized for Monday 7th of March. Goal: have that... [15:55:56] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2088604 (10Trizek-WMF) I've been able to move a test Board from one page to an other ("User talk:Trizek (WMF)/Flow test" has been moved to "User talk:Tri... [16:02:11] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 3Liaisons-March-2016: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2088612 (10Trizek-WMF) [16:02:29] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 3Liaisons-March-2016: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2088626 (10Trizek-WMF) [16:02:31] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Roll out cross-wiki notifications beta feature - https://phabricator.wikimedia.org/T124234#2088625 (10Trizek-WMF) [16:03:39] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 3Liaisons-March-2016: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2088612 (10Trizek-WMF) [16:03:53] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 3Liaisons-March-2016: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2088612 (10Trizek-WMF) [16:05:08] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 3Liaisons-March-2016: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2088634 (10Trizek-WMF) p:5Triage>3High [16:08:10] (03CR) 10Paladox: "check experimental" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/274548 (owner: 10L10n-bot) [16:13:41] (03CR) 10Paladox: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274699 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [16:14:01] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 7WorkType-Maintenance: Create XML Schema for Flow dump format(s) - https://phabricator.wikimedia.org/T112799#2088642 (10ArielGlenn) So where are we on this? Can we get it published someplace at any rate? [16:15:41] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 3Liaisons-March-2016: Prepare and review announcements concerning Cross-wiki Notifications as a Beta feature on all wikis - https://phabricator.wikimedia.org/T128865#2088645 (10Trizek-WMF) [16:19:49] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2088669 (10Trizek-WMF) I know I'm posting something useless, but we really need {T114917}... That kind of feature would have given... [16:49:20] (03PS1) 10Haritha28: Merge "Try and avoid race conditions with thank-you-edit notifications" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274980 [16:49:40] (03CR) 10jenkins-bot: [V: 04-1] Merge "Try and avoid race conditions with thank-you-edit notifications" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274980 (owner: 10Haritha28) [16:50:22] I got 5 ancient cross-wiki notifications when I visited mw.o today (neat!). 4 of them say "Could not retrieve notifications. Please try again. (Error Access to the remote domain was denied.)". I can see this is because my no-script rules are not allowing the domains to load js. [16:50:40] I was wondering if there could be a slightly better error message for this. [16:51:05] * bd808 hasn't looked at the code behind the messages [16:51:07] (03Abandoned) 10Haritha28: Merge "Try and avoid race conditions with thank-you-edit notifications" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274980 (owner: 10Haritha28) [17:08:06] 6Collaboration-Team-Backlog, 10Notifications: Notification that is shown in special page but not in flyout - https://phabricator.wikimedia.org/T128148#2088818 (10Quiddity) 5Open>3Invalid Screenshots received via email. The notification does appear in the messages flyout after all. Closing as (invalid) misu... [17:23:30] matt_flaschen: anybody sees PhutilBootloaderException Include of '/srv/phab/libext/misc/__phutil_library_init__.php' failed! ? [17:57:02] 6Collaboration-Team-Backlog, 10Notifications: User preferences for cross-wiki notifications - https://phabricator.wikimedia.org/T114917#2089043 (10jmatazzoni) In T117669, @Trizek-WMF said (referring to this ticket): > I know I'm posting something useless, but we really need T114917: User preferences for cros... [18:20:07] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Better organization for the Notification panel - https://phabricator.wikimedia.org/T113228#1657957 (10Capt_Swing) [18:20:09] 6Collaboration-Team-Backlog, 6Design-Research, 10Notifications: Evaluate designs for new notification panel actions - https://phabricator.wikimedia.org/T116741#1756870 (10Capt_Swing) 5Resolved>3Open [18:24:48] 6Collaboration-Team-Backlog, 10Notifications: User preferences for cross-wiki notifications - https://phabricator.wikimedia.org/T114917#2089162 (10Trizek-WMF) >>! In T114917#2089043, @jmatazzoni wrote: > In T117669, @Trizek-WMF said (referring to this ticket): > >> I know I'm posting something useless, but w... [18:29:48] 3Collaboration-Team-Current, 10Beta-Cluster-Infrastructure, 10DBA, 13Patch-For-Review, 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2089205 (10Mattflaschen) >>! In T95871#2087608, @jcrespo wrote: > I can fix production, but I need t... [18:30:41] 3Collaboration-Team-Current, 10Flow: Unformatted html within message about ip-block (for TOR users) - https://phabricator.wikimedia.org/T128855#2089208 (10Mattflaschen) [18:31:44] 6Collaboration-Team-Backlog, 10Notifications, 10Wikidata, 7Need-volunteer, 7Story: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#2089215 (10matej_suchanek) a:3matej_suchanek I have written a separate extension for this locall... [18:35:53] 6Collaboration-Team-Backlog, 10Notifications, 10Wikidata, 7Need-volunteer, 7Story: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#2089242 (10hoo) So you push an Echo notification to a user on a client once a page (created by the... [18:56:11] 6Collaboration-Team-Backlog, 10Thanks: Use OO.ui.alert() instead of plain alert for Thanks error messages - https://phabricator.wikimedia.org/T128891#2089421 (10Legoktm) [19:34:14] (03PS1) 10Legoktm: Include error code in API failure message [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/275032 (https://phabricator.wikimedia.org/T78697) [20:05:22] (03PS1) 10Legoktm: Remove deprecated API functions [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/275040 [20:09:13] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2089693 (10Mattflaschen) [20:28:34] 6Collaboration-Team-Backlog, 10MediaWiki-Vagrant, 10Notifications: Role echo throws errors at vagrant - https://phabricator.wikimedia.org/T128903#2089743 (10Luke081515) [20:43:32] (03PS1) 10Sbisson: [WIP] [POC] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [20:49:33] (03CR) 10jenkins-bot: [V: 04-1] [WIP] [POC] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [20:52:12] 6Collaboration-Team-Backlog, 10MediaWiki-Vagrant, 10Notifications: Role echo throws errors at vagrant - https://phabricator.wikimedia.org/T128903#2089743 (10Mattflaschen) First, we should figure out why that is failing. Do: vagrant ssh USE wikishared; SOURCE /vagrant/mediawiki/extensions/Echo/db_patches/ec... [20:52:25] (03PS2) 10Sbisson: [WIP] [POC] Moderate notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/275049 (https://phabricator.wikimedia.org/T93673) [20:52:58] 6Collaboration-Team-Backlog, 10MediaWiki-Vagrant, 10Notifications: Role echo throws errors at vagrant - https://phabricator.wikimedia.org/T128903#2089816 (10Mattflaschen) Sorry, I posted the wrong command at first. See edited one. [21:06:29] (03PS1) 10Sbisson: [WIP] [POC] Moderate notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275052 (https://phabricator.wikimedia.org/T93673) [21:13:45] (03CR) 10jenkins-bot: [V: 04-1] [WIP] [POC] Moderate notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275052 (https://phabricator.wikimedia.org/T93673) (owner: 10Sbisson) [21:30:21] 6Collaboration-Team-Backlog, 10Notifications, 10Wikidata, 7Need-volunteer, 7Story: [Story] Notification: Add notification when page is being connected to Wikidata - https://phabricator.wikimedia.org/T110604#2089971 (10Quiddity) The info in the comments of {T110356} might help? If not, we need to file a... [21:32:51] (03PS2) 10Sbisson: [WIP] [POC] Moderate notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/275052 (https://phabricator.wikimedia.org/T93673) [21:35:51] bd808 [2016-03-04 08:49:46] I got 5 ancient cross-wiki notifications when I visited mw.o today (neat!). 4 of them say "Could not retrieve notifications. Please try again. (Error Access to the remote domain was denied.)". I can see this is because my no-script rules are not allowing the domains to load js. [21:36:07] bd808: I'll take suggestions for a better error message, but what we get from the browser is deliberately vague in that case [21:36:30] In your case it was noscript, but it can also be lack of CORS headers, or the server having gone away, or ... [21:36:59] When stuff is blocked for security reasons you tend to get an error code that is as vague and useless as possible [21:37:07] *nod* [21:37:22] when I started typing I hadn't figured out that no-script was the root cause [21:37:32] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2089997 (10Mattflaschen) It looks like the move got interrupted last time and partly completed.. That shouldn't be able to happen if the transactions ar... [21:37:39] I'm sure the js exception/error is mostly useless [21:38:27] RoanKattouw, would like to do a DB hack to work around https://phabricator.wikimedia.org/T127693 . Take a look when you have a chance. I don't know it got into that inconsistent state, but we've since refactored the transactions. [21:39:23] OK, sounds good to me [21:39:31] We'd only need to update 55 rows, right? [21:40:53] Also, use WHERE workflow_wiki='zhwiki' AND workflow_namespace=3 AND workflow_title_text='Nbfreeh' instead of the workflow_page_id thing, to take advantage of the (wiki, ns, title) index [21:40:59] (There is no index covering workflow_page_id) [21:44:14] RoanKattouw, yeah, I will put a LIMIT in too just in case. Good point on the workflow_page_id. [21:45:31] Standard precautions: do an EXPLAIN SELECT first, then a SELECT, then do the actual UPDATE in a transaction so you can inspect the resulting state before committing [21:46:08] Thanks, will do. [21:50:48] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2090045 (10Mattflaschen) That should have been: ``` SELECT HEX(workflow_id), workflow_wiki, workflow_page_id, workflow_namespace, workflow_title_text, w... [21:53:03] RoanKattouw, https://phabricator.wikimedia.org/P2709 . [21:53:26] lgtm [21:53:45] (03PS3) 10Mooeypoo: [wip] Adjust and clean up styles and behavior for mobile [extensions/Echo] - 10https://gerrit.wikimedia.org/r/237510 (https://phabricator.wikimedia.org/T124188) [21:54:50] Wish sql command worked for flowdb [21:54:54] I know how to do it though [22:06:51] 6Collaboration-Team-Backlog, 10MediaWiki-Vagrant, 10Notifications: Role echo throws errors at vagrant - https://phabricator.wikimedia.org/T128903#2090080 (10Luke081515) I got the actual version of echo, (created that cluster temporary today, just for one experiment, and I deleted it two hours ago, but I can... [22:12:33] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2090095 (10Mattflaschen) There is an other Flow board that was apparently deleted earlier. This shouldn't cause any problems, though: ``` mysql:researc... [22:15:22] RoanKattouw, turns out there is another Flow workflow (for a board) with ID 5242488 (maybe deleted). It should not cause any problems, but I don't want to delete it. Also, I removed the UPDATE LIMIT since statement replication complained (I rolled that back): [22:15:26] RoanKattouw: https://phabricator.wikimedia.org/P2709 [22:15:44] Oh, yes [22:15:47] I mean I don't want to overwrite it, so I added the ID. [22:16:01] Sorry for not remembering that [22:16:01] UPDATE ... LIMIT is not deterministic in which rows it touches [22:16:31] But if you run the corresponding SELECT first, you can see it probably won't touch too many rows, and if it did touch too many you can always ROLLBACK; [22:17:01] The reason why you want the SELECT to be fast also has to do with statement-based replication [22:17:15] The replication pipeline gets clogged when a single statement takes a long time to execute [22:17:52] So an UPDATE with a WHERE clause that's slow to resolve (i.e. it takes a long time to find which rows to update) will cause high rep lag for a bit [22:17:56] RoanKattouw, right, makes sense. My final "did it do what I want" select does not use the workflow_page_id so it should be okay. [22:18:09] Cool [22:18:17] The update does use it, but it can probably still use the index since it also has the others. [22:18:31] Oh, yes, that's fine [22:18:47] It'll use the index first, then examine the rows the index found to see if they have the right page ID [22:18:48] RoanKattouw, did you check the updated paste? [22:18:56] Given that the index will narrow it down to ~100 rows that won't be slow [22:19:00] No, checking [22:19:56] Oh OK I see [22:20:12] Yeah that'll be OK [22:20:16] And the "did it do what I want" select as you said purely uses the index [22:21:33] RoanKattouw, okay, going ahead. [22:30:17] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2090167 (10Mattflaschen) Worked around manually with P2709. Page no longer has an error. @Trizek-WMF Please try the move again. [22:32:27] just a health reminder SES-9 is re-schdeuled for liftoff in 1 hour [22:32:38] doh wrong room :P but mayb'e your interested too :) [22:40:26] (03PS9) 10Mooeypoo: Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) [22:44:00] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#2090222 (10Etonkovidova) Re-check... [22:44:32] (03CR) 10Sbisson: [C: 032] Styling adjustments for notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274804 (https://phabricator.wikimedia.org/T125969) (owner: 10Mooeypoo) [22:45:44] (03CR) 10Sbisson: [C: 032] Remove resolved TODO about adding wiki field to Schema:EditInteraction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274343 (owner: 10Catrope) [22:47:32] (03CR) 10Sbisson: [C: 04-1] "Needs a manual rebase, probably because of "Echo API Layer"." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274342 (owner: 10Catrope) [22:48:38] (03PS2) 10Sbisson: build: Enable jscs rule 'requireVarDeclFirst' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274010 (owner: 10Ricordisamoa) [22:54:25] (03CR) 10jenkins-bot: [V: 04-1] build: Enable jscs rule 'requireVarDeclFirst' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274010 (owner: 10Ricordisamoa) [22:55:45] (03Merged) 10jenkins-bot: Styling adjustments for notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274804 (https://phabricator.wikimedia.org/T125969) (owner: 10Mooeypoo) [22:59:10] (03PS3) 10Ricordisamoa: build: Enable jscs rule 'requireVarDeclFirst' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274010 [23:02:38] 6Collaboration-Team-Backlog, 10Thanks, 13Patch-For-Review: "Thank action failed. Please try again." - https://phabricator.wikimedia.org/T78697#851436 (10Legoktm) That patch should expose the actual error code in the error message so these reports are actionable. [23:06:10] (03Merged) 10jenkins-bot: Remove resolved TODO about adding wiki field to Schema:EditInteraction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274343 (owner: 10Catrope) [23:09:30] 6Collaboration-Team-Backlog, 10Thanks: Use OO.ui.alert() instead of plain alert for Thanks error messages - https://phabricator.wikimedia.org/T128891#2090290 (10Legoktm) [23:09:40] 6Collaboration-Team-Backlog, 10Thanks: Use OO.ui.alert() instead of plain alert for Thanks error messages - https://phabricator.wikimedia.org/T128891#2089421 (10Legoktm) [23:26:33] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 5WMF-deploy-2016-03-08_(1.27.0-wmf.16): Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#2090349 (10jmatazzoni) I'm lookin...