[00:05:10] (03PS1) 10Mooeypoo: Allow mark as read for a cross-wiki bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274606 (https://phabricator.wikimedia.org/T128562) [00:12:09] matt_flaschen, how do I know what the wiki IDs are in vagrant? I am running staphane's patch and I want to specify x-wiki [00:12:42] mooeypoo, run: [00:12:44] alldbs [00:12:46] in vagrant ssh [00:13:00] awesome, got it [00:13:04] those are the IDs? [00:13:17] the dbname = wiki ID I assume? [00:13:31] yes [00:15:14] 6Collaboration-Team-Backlog, 10Flow: Creating new topics with existing comments - https://phabricator.wikimedia.org/T128215#2067607 (10Mattflaschen) This is a specific case of {T90054}. [00:15:30] 6Collaboration-Team-Backlog, 10Flow: Creating new topics with existing comments - https://phabricator.wikimedia.org/T128215#2082666 (10Mattflaschen) [00:15:31] 6Collaboration-Team-Backlog, 10Flow: Split topic - https://phabricator.wikimedia.org/T90054#1052058 (10Mattflaschen) [00:15:44] hm, --wiki [wikiID] doesn't seem to work [00:16:08] mooeypoo, what's your full command? [00:16:16] I always get the mwscript order wrong the first time. [00:16:30] php generateSampleNotifications.php -a Test -u Admin -o Moriel -f --wiki frwiki [00:16:46] oh, I should be using mwscript instead [00:17:45] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Items in the more actions menu of notifications are inconsistent - https://phabricator.wikimedia.org/T126734#2022178 (10Etonkovidova) Checked in betalabs - seems to be all in place(except hover stuff): {F3511083} {F3511085} {F3511087} [00:18:13] ... or not [00:18:25] mooeypoo, try: [00:18:27] mwscript extensions/Echo/maintenance/generateSampleNotifications.php --wiki=frwiki -a Watcher -u Admin -o Poster -f [00:18:32] It's working for me. [00:18:38] oh hm = [00:18:41] Switch the usernames obviously. [00:19:01] It's very weird how the mwscript arguments work. It separates the parameters from the script. [00:19:32] pff "User Test does not seem to exist in this wiki" [00:19:41] ... global users... :\ ? [00:20:48] foreachwiki foobar.php --args [00:21:40] ok I explicitly logged in with "Test" in frwiki. Testing again [00:27:21] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2063036 (10Etonkovidova) The space after wiki names has been increased (rather a little big?) {F35... [00:34:06] 6Collaboration-Team-Backlog, 10Notifications: Echo shouldn't send pings on bot-edits. - https://phabricator.wikimedia.org/T128662#2081877 (10Quiddity) >>! In T128662#2082178, @Akoopal wrote: > The first ping is to the nominator who has done the nomination, not the author of the article. It is debatable if that... [00:37:18] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Adjust hover state for actions in the more menu ("...") of notifications - https://phabricator.wikimedia.org/T126740#2022269 (10Etonkovidova) Checked in betalabs - also see the screenshots in {T126734}... [00:51:24] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2082747 (10Quiddity) >> Any reason why we wouldn't just give stewards that right? > This should not be necessary. There is already a permission exception... [01:57:04] Am I going crazy, or did there used to be a titlebar for the moderation dialog box? http://i.imgur.com/GiltCE0.png [02:17:25] (03PS1) 10Mattflaschen: Have NamespaceIsMovable hook set NS_TOPIC to false and not touch others [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274620 [02:17:38] quiddity: I feel like there was one once? [02:17:51] I'm not sure though [02:17:58] ok! [02:21:52] quiddity, I don't think there was. There's a placeholder, right? [02:23:59] 3Collaboration-Team-Current: Fix namespace movable hook - https://phabricator.wikimedia.org/T128694#2083026 (10Mattflaschen) [02:25:04] (03PS2) 10Mattflaschen: Have NamespaceIsMovable hook set NS_TOPIC to false and not touch others [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274620 (https://phabricator.wikimedia.org/T128694) [02:32:36] (03CR) 10Legoktm: [C: 032] Have NamespaceIsMovable hook set NS_TOPIC to false and not touch others [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274620 (https://phabricator.wikimedia.org/T128694) (owner: 10Mattflaschen) [02:43:32] (03Merged) 10jenkins-bot: Have NamespaceIsMovable hook set NS_TOPIC to false and not touch others [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274620 (https://phabricator.wikimedia.org/T128694) (owner: 10Mattflaschen) [03:21:17] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2083117 (10Legoktm) p:5Unbreak!>3High [04:25:57] 40 minutes to run one test, PrefixSearchTest.php . I think partly because of memory crunch in the guest. [04:26:21] On a separate test run, I am getting "Cannot allocate memory" on some popen calls. [04:50:04] that's...crazy. [04:51:44] matt_flaschen: how much memory does your VM have? [04:51:51] it took me 26 seconds [04:55:51] !! [04:56:09] That is crazy. I have 2 GB. [04:57:43] There are some useless services running, though due to VE (things regular VE needs that Flow VE does not). Killed them for now, but wonder if there's something else going on. [04:58:55] I'm also going to try disabling XDebug entirely (it's not running through the debugger, but I've heard it can still have a noticeable impact). [04:59:35] Also, i was running two PHPUnit runs at once, but even before when I was running one it was very slow. [05:02:10] I gave mine 3GB [05:02:52] oh, xdebug? [05:02:56] so you're using zend then? [05:03:23] I've also disabled all the node stuff plus the job queue service [05:04:35] legoktm, yeah, on purpose. I'm running it CLI. I did a quick test and they were about the same, but Zend slightly faster. I've heard Zend is faster on CLI since HHVM doesn't optimize for that. [05:04:37] Not sure if still true. [05:05:24] I'll try 3000 MB and see how the host acts. [05:05:27] zend took 27 seconds for me :P [05:06:45] legoktm, yeah, something is weird. How do you keep the nodejs stuff disabled? Do you disable VE entirely or just hack around restbase, etc.? [05:07:00] I made sure I never installed it ;) [05:07:46] If I have to install it to test something, I'll usually destroy/recreate afterwards [05:08:06] legoktm, :). Yeah, we talked once about whether to make the flow role require VE. We never did (mainly because of browser performance, IIRC). [05:08:14] I should just disable it for now too. [05:43:12] legoktm, do you use NFS or VirtualBox shared folders. [05:43:28] I'm on NFS currently. [05:43:29] vb's shared folders [05:43:40] Hmmm... [05:43:47] NFS is supposed to be faster. *Supposed* to be. [05:43:59] they work good enough on my laptop (fedora) [05:44:15] I have hit random NFS errors, but I haven't seen any sign that it's secretly way slower, unless this is that sign. [05:45:10] I also have full disk encryption, but that should be minimal impact and normal disk activity is not at all slow. [06:43:29] I have full disk encryption too [08:29:32] (03PS1) 10Matthias Mullie: Clear failing listeners from tests where we don't provide sufficient metadata [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274647 (https://phabricator.wikimedia.org/T89691) [08:33:06] 6Collaboration-Team-Backlog, 10Notifications: Echo shouldn't send pings on bot-edits. - https://phabricator.wikimedia.org/T128662#2083460 (10Akoopal) Having the edits only suppressed on minor edits would be a solution. The bot that triggered this is also an archiving bot, who is also doing minor edits. [08:39:12] (03Abandoned) 10Siebrand: Remove double emphasis in string [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273585 (owner: 10Siebrand) [08:39:37] (03Abandoned) 10Siebrand: Remove double emphasis in string [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273588 (owner: 10Siebrand) [09:08:11] 6Collaboration-Team-Backlog, 10Flow, 10Notifications: Remove double emphasis in UI strings - https://phabricator.wikimedia.org/T128711#2083497 (10siebrand) [09:15:44] (03PS1) 10Siebrand: Remove double emphasis in strings [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274656 (https://phabricator.wikimedia.org/T128711) [09:16:08] (03PS1) 10Siebrand: Remove double emphasis in strings [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274657 (https://phabricator.wikimedia.org/T128711) [09:21:28] (03PS1) 10Siebrand: Use strong and em instead of wiki markup bold and italics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274659 [09:25:28] 6Collaboration-Team-Backlog, 10Flow, 10Notifications, 13Patch-For-Review: Remove double emphasis in UI strings - https://phabricator.wikimedia.org/T128711#2083570 (10siebrand) [09:26:21] (03PS1) 10Siebrand: Use strong and em instead of wiki markup bold and italics [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274660 [09:35:03] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2083578 (10Pginer-WMF) >>! In T128069#2082690, @Etonkovidova wrote: > The space after wiki names h... [09:46:35] (03CR) 10Siebrand: "> GENDER uses the current user when you pass nothing" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274162 (owner: 10Catrope) [09:48:19] (03CR) 10Siebrand: "Per https://gerrit.wikimedia.org/r/#/c/273588/ , Please file a bug and discuss on Phabricator first ?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274162 (owner: 10Catrope) [10:09:13] 6Collaboration-Team-Backlog, 10Flow: Give global-flow-create rights to Stewards when whey rename an account - https://phabricator.wikimedia.org/T128567#2083634 (10Trizek-WMF) Cool! :) [10:43:15] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2083682 (10Trizek-WMF) >>! In T127693#2080592, @Catrope wrote: > We could just give the global-flow-create group move rights. Someone should edit https:/... [10:47:48] (03CR) 10Siebrand: "i18n/L10n reviewed. So it appears the i18n is fine after some updates to the message documentation. Thanks." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273560 (https://phabricator.wikimedia.org/T125970) (owner: 10Mooeypoo) [11:17:07] (03CR) 10Siebrand: [C: 032] Hungarian localization for special messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254814 (https://phabricator.wikimedia.org/T119365) (owner: 10Gergő Tisza) [11:34:22] (03Merged) 10jenkins-bot: Hungarian localization for special messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254814 (https://phabricator.wikimedia.org/T119365) (owner: 10Gergő Tisza) [11:58:42] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Roll out cross-wiki notifications beta feature - https://phabricator.wikimedia.org/T124234#2083946 (10Trizek-WMF) [12:02:51] 6Collaboration-Team-Backlog, 10Notifications: Cross-wiki notifications inform me of very old replies - https://phabricator.wikimedia.org/T128373#2083955 (10Trizek-WMF) 5Open>3Invalid I close the task: it is a normal behavior, now documented [[ https://www.mediawiki.org/wiki/Help:Notifications/Cross-wiki |... [12:06:35] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2050743 (10MarcoAurelio) >>! In T127693#2083682, @Trizek-WMF wrote: >>>! In T127693#2080592, @Catrope wrote: >> We could just give the global-flow-create... [12:13:11] 6Collaboration-Team-Backlog, 10Thanks: "Thank action failed. Please try again." - https://phabricator.wikimedia.org/T78697#851436 (10JackPotte) I've got this on this particular case only: https://fr.wikipedia.org/w/index.php?title=Apprentissage_automatique&oldid=prev&diff=123924376 [12:37:53] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests, 13Patch-For-Review, 7user-notice: Override Echo system notification icons for all Wikimedia projects - https://phabricator.wikimedia.org/T49662#527828 (10Johan) Just making sure I'm not mistaken regarding the effect this will have for Wikimedia editor... [13:10:25] (03PS1) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) [13:10:42] (03CR) 10Matthias Mullie: [C: 04-1] "I haven't been able to test this yet!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [13:15:15] (03CR) 10jenkins-bot: [V: 04-1] Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [13:15:26] (03Abandoned) 10Sbisson: Make link labels longer by 3 character [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274481 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [13:16:13] hey mlitn [13:16:29] when you have a minute [13:16:31] hey stephanebisson [13:16:32] sure [13:16:36] I do now [13:16:53] do you see any problem with https://phabricator.wikimedia.org/T93673#2080535 ? [13:52:38] (03PS14) 10Haritha28: Notification when account is blocked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264070 (https://phabricator.wikimedia.org/T100974) [13:53:25] (03CR) 10jenkins-bot: [V: 04-1] Notification when account is blocked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264070 (https://phabricator.wikimedia.org/T100974) (owner: 10Haritha28) [13:59:02] stephanebisson: sorry, had to go help out in bathroom :p [13:59:13] I don’t see any problem with your suggestion [14:00:13] mlitn: ok, thank. any advice on how to proceed to do it? [14:00:21] but we should probably make it very obvious for extensions that use echo, that they have to maintain that table, somehow [14:00:40] (which is not currently the case with target_page, which is just some obscure param) [14:00:58] ehm [14:04:27] (03PS1) 10Sbisson: Notifications: truncate without adjust length [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274699 (https://phabricator.wikimedia.org/T121822) [14:06:25] mlitn: yes, any moderation done on standard wikitext tables would be already done but extensions doing moderation on their own storage (like Flow) have some work to do [14:10:34] (03PS1) 10Sbisson: Notifications: truncate without adjust length [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274702 (https://phabricator.wikimedia.org/T121822) [14:18:03] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#2084246 (10SBisson) Confirmed with @Pginer-WMF that the safety range in Cor... [14:18:50] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264070 (https://phabricator.wikimedia.org/T100974) (owner: 10Haritha28) [14:45:10] yes [14:46:49] I don’t think we have any standardized moderation log/processing that we could reuse [14:50:02] (03PS2) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) [14:54:53] (03CR) 10jenkins-bot: [V: 04-1] Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [15:01:23] (03PS3) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) [15:09:54] (03CR) 10jenkins-bot: [V: 04-1] Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [15:12:57] (03PS4) 10Matthias Mullie: Don't delete unread messages before all read messages have been deleted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) [16:30:48] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Explore possibilities for inviting users to try cross-wiki notifications - https://phabricator.wikimedia.org/T128746#2084591 (10Pginer-WMF) [16:30:58] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Explore possibilities for inviting users to try cross-wiki notifications - https://phabricator.wikimedia.org/T128746#2084606 (10Pginer-WMF) [17:08:31] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2084730 (10Pginer-WMF) [17:09:30] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#1781222 (10Pginer-WMF) >>! In T117669#2074075, @jmatazzoni wrote: > I'm assigning this to Pau to propose a design based on our dis... [17:35:33] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2084889 (10Pginer-WMF) [18:01:04] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Create new notification category for talk pages: flowusertalk - https://phabricator.wikimedia.org/T121663#2085098 (10Etonkovidova) ``` flowusertalk-topic-renamed flowusertalk-post-edited ``` Checked a... [18:08:01] 6Collaboration-Team-Backlog, 10Flow: Session failure when you want to "mark as patrolled" a diff on Flow. - https://phabricator.wikimedia.org/T128379#2085119 (10Quiddity) [18:08:03] 6Collaboration-Team-Backlog, 10Flow: Edit patrol - Flow issues (tracking) - https://phabricator.wikimedia.org/T73456#2085118 (10Quiddity) [18:23:59] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#2085241 (10Etonkovidova) The following are checked as part of verifying {T121663} flowusertalk-topic-renamed flowusertalk-post-edited {F35... [18:30:20] (03CR) 10Catrope: "https://phabricator.wikimedia.org/T121936#2076574" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274162 (owner: 10Catrope) [18:30:33] (03PS2) 10Catrope: Change "Expand N alerts/messages" to "View N alerts/messages" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274162 (https://phabricator.wikimedia.org/T121936) [18:30:55] 6Collaboration-Team-Backlog, 10Notifications, 7Easy, 7Technical-Debt: Echo should not hook into itself with EchoAbortEmailNotification - https://phabricator.wikimedia.org/T128769#2085271 (10Legoktm) [18:37:56] (03CR) 10Catrope: [C: 032] Notifications: truncate without adjust length [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274702 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [18:38:57] (03CR) 10Catrope: [C: 032] Notifications: truncate without adjust length [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274699 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [18:39:26] 6Collaboration-Team-Backlog, 10Flow: Flow editing toolbar should be at the top of the edit window - https://phabricator.wikimedia.org/T128088#2085346 (10Quiddity) [18:41:06] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review: Remove double emphasis in UI strings - https://phabricator.wikimedia.org/T128711#2085355 (10Catrope) [18:41:23] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review: Remove double emphasis in UI strings - https://phabricator.wikimedia.org/T128711#2083497 (10Catrope) @jmatazzoni , @Pginer-WMF : Thoughts? [18:43:00] (03CR) 10Catrope: [C: 032] Use strong and em instead of wiki markup bold and italics [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274659 (owner: 10Siebrand) [18:43:29] (03CR) 10Catrope: [C: 032] Use strong and em instead of wiki markup bold and italics [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274660 (owner: 10Siebrand) [18:44:37] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 7Technical-Debt: Fix "InvalidDataException from NotificationListener.php: Invalid metadata for revision" - https://phabricator.wikimedia.org/T89691#2085378 (10matthiasmullie) a:5EBernhardson>3matthiasmullie [18:44:43] (03CR) 10Catrope: [C: 032] Clear failing listeners from tests where we don't provide sufficient metadata [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274647 (https://phabricator.wikimedia.org/T89691) (owner: 10Matthias Mullie) [18:52:05] (03Merged) 10jenkins-bot: Notifications: truncate without adjust length [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274702 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [18:52:10] (03Merged) 10jenkins-bot: Notifications: truncate without adjust length [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274699 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [18:52:18] (03Merged) 10jenkins-bot: Clear failing listeners from tests where we don't provide sufficient metadata [extensions/Flow] - 10https://gerrit.wikimedia.org/r/274647 (https://phabricator.wikimedia.org/T89691) (owner: 10Matthias Mullie) [18:58:31] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Create new notification category for talk pages: flowusertalk - https://phabricator.wikimedia.org/T121663#2085449 (10jmatazzoni) 5Open>3Resolved [18:58:33] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#2085450 (10jmatazzoni) [19:00:31] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2085455 (10jmatazzoni) [19:00:33] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Adjust hover state for actions in the more menu ("...") of notifications - https://phabricator.wikimedia.org/T126740#2085454 (10jmatazzoni) 5Open>3Resolved [19:03:29] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests, 13Patch-For-Review, 7user-notice: Override Echo system notification icons for all Wikimedia projects - https://phabricator.wikimedia.org/T49662#527828 (10Catrope) >>! In T49662#2084042, @Johan wrote: > Just making sure I'm not mistaken regarding the e... [19:04:00] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2063036 (10jmatazzoni) moving this back to Q&A. [19:05:13] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): 'Mark as read' in dotdotdot menu does nothing - https://phabricator.wikimedia.org/T128432#2085477 (10jmatazzoni) 5Open>3Resolved [19:07:05] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5Security, 7Security-Extensions: XSS in Flow topic titles - https://phabricator.wikimedia.org/T120324#2085483 (10jmatazzoni) [19:07:07] 3Collaboration-Team-Current, 10Flow, 10Thanks, 10Notifications, and 3 others: wikitext in flow titles is parsed (HTML tags like and templates) on echo notifications - https://phabricator.wikimedia.org/T120291#2085482 (10jmatazzoni) 5Open>3Resolved [19:10:36] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2085511 (10jmatazzoni) [19:10:38] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Keep notification excerpts compact and meaningful - https://phabricator.wikimedia.org/T128062#2085510 (10jmatazzoni) 5Open>3Resolved [19:13:55] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Items in the more actions menu of notifications are inconsistent - https://phabricator.wikimedia.org/T126734#2085566 (10jmatazzoni) 5Open>3Resolved [19:13:57] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2085567 (10jmatazzoni) [19:15:11] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Making a null edit triggers a new message notification although null edit is not recorded in page history - https://phabricator.wikimedia.org/T123843#2085569 (10jmatazzoni) 5Open>3Resolved [19:20:20] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Renaming an account doesn't move the Flow board on the user's talk page - https://phabricator.wikimedia.org/T113701#2085587 (10jmatazzoni) [19:20:22] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Update move permission code - https://phabricator.wikimedia.org/T126389#2085586 (10jmatazzoni) 5Open>3Resolved [19:28:30] (03CR) 10Mooeypoo: Echo API layer (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [19:28:57] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests, 13Patch-For-Review, 7user-notice: Override Echo system notification icons for all Wikimedia projects - https://phabricator.wikimedia.org/T49662#2085615 (10Johan) OK, thanks. [19:30:09] (03PS29) 10Mooeypoo: Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [19:32:43] (03CR) 10Catrope: [C: 032] Allow mark as read for a cross-wiki bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274606 (https://phabricator.wikimedia.org/T128562) (owner: 10Mooeypoo) [19:35:27] (03CR) 10Catrope: [C: 032] Mark all as read should not apply to cross-wiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274480 (https://phabricator.wikimedia.org/T128621) (owner: 10Mooeypoo) [19:35:38] (03PS2) 10Catrope: Mark all as read should not apply to cross-wiki bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274480 (https://phabricator.wikimedia.org/T128621) (owner: 10Mooeypoo) [19:36:57] (03CR) 10Mooeypoo: Add a short abbreviation for timestamps in notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273560 (https://phabricator.wikimedia.org/T125970) (owner: 10Mooeypoo) [19:37:10] (03PS2) 10Mooeypoo: Add a short abbreviation for timestamps in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273560 (https://phabricator.wikimedia.org/T125970) [19:41:03] 3Collaboration-Team-Current, 10Notifications: Create Mark Bundle as Read - https://phabricator.wikimedia.org/T128629#2085650 (10Mooeypoo) [19:41:05] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Allow marking whole cross-wiki bundles as read - https://phabricator.wikimedia.org/T128562#2085652 (10Mooeypoo) [19:45:17] (03Merged) 10jenkins-bot: Allow mark as read for a cross-wiki bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274606 (https://phabricator.wikimedia.org/T128562) (owner: 10Mooeypoo) [19:52:52] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#2085707 (10Etonkovidova) Checked in betalabs: ``` flowusertalk-new-topic flowusertalk-post-reply flowboard-description-edited ``` **flowus... [19:54:46] (03PS1) 10Catrope: Revert "Compress PNGs with zopflipng" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274789 [19:54:58] (03Abandoned) 10Catrope: Revert "Compress PNGs with zopflipng" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274789 (owner: 10Catrope) [19:55:37] (03PS1) 10Catrope: Revert "Compress PNGs with zopflipng" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274790 [19:57:05] (03PS2) 10Ori.livneh: Revert "Compress PNGs with zopflipng" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274790 (owner: 10Catrope) [19:57:14] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Librarization, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2085732 (10Legoktm) >>! In T128351#2077688, @brion wrote: > Always worth checking. :) Any particular candidates for a split-out to libs? Off the top of my he... [19:57:32] (03CR) 10Ori.livneh: [C: 032] "Possible puns: "This revert is heartless"; "Have a heart, Roan!"; "I wholeheartedly regret this error", etc." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274790 (owner: 10Catrope) [20:04:19] (03PS1) 10Catrope: Revert "Compress PNGs with zopflipng" [extensions/Echo] (wmf/1.27.0-wmf.15) - 10https://gerrit.wikimedia.org/r/274794 [20:04:31] (03CR) 10Catrope: [C: 032] Revert "Compress PNGs with zopflipng" [extensions/Echo] (wmf/1.27.0-wmf.15) - 10https://gerrit.wikimedia.org/r/274794 (owner: 10Catrope) [20:11:26] (03Merged) 10jenkins-bot: Revert "Compress PNGs with zopflipng" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274790 (owner: 10Catrope) [20:17:11] (03Merged) 10jenkins-bot: Revert "Compress PNGs with zopflipng" [extensions/Echo] (wmf/1.27.0-wmf.15) - 10https://gerrit.wikimedia.org/r/274794 (owner: 10Catrope) [20:39:53] stephanebisson: when you added "notification-header-flow-post-edited-v2": "{{GENDER:$2|Your}} instead of "notification-header-flow-post-edited-v2": "Your post on \"$1\" was edited." [20:40:08] stephanebisson: did you have any specific lang in mind? :) [20:41:06] etonkovidova: I don't remember [20:41:18] stephanebisson: cause I cannot think of any - does not seem that French does it :) and neither German and Russion [20:42:24] stephanebisson: well, I verified that it works as before with the change - and may be there re such languages [20:49:04] Hebrew has a difference, but colloquially it's written the same [20:49:09] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests, 13Patch-For-Review, 7user-notice: Override Echo system notification icons for all Wikimedia projects - https://phabricator.wikimedia.org/T49662#2085997 (10Quiddity) [20:50:54] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests, 13Patch-For-Review, 7user-notice: Override Echo system notification icons for all Wikimedia projects - https://phabricator.wikimedia.org/T49662#527828 (10Quiddity) [20:54:40] (03PS1) 10Mooeypoo: Styling adjustments for notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274804 (https://phabricator.wikimedia.org/T125969) [20:57:30] (03CR) 10Catrope: [C: 031] Styling adjustments for notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274804 (https://phabricator.wikimedia.org/T125969) (owner: 10Mooeypoo) [21:04:26] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Action and timestamp position needs adjustment - https://phabricator.wikimedia.org/T125969#2086029 (10Mooeypoo) Another attempt... and few comments for @Pginer-WMF : * The icons that come from ooui already have internal padding (about 4px in... [21:23:07] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review: Notification-header-flow-topic-renamed-user-talk and Notification-bundle-header-flow-post-edited-user-talk seem to have incorrect parameter documentation - https://phabricator.wikimedia.org/T125253#1982717 (10Etonkovidova) Checked in... [21:46:35] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2086191 (10Mattflaschen) @Trizek-WMF Please try the original move again on zhwiki. If it fails, it should give you the real error now. [21:49:04] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review: notification-header-user-rights-* should have GENDER support for the current user - https://phabricator.wikimedia.org/T125251#2086206 (10Etonkovidova) Checked in betalabs (thanks to @Catrope again) - the same verifying method as in {... [21:50:26] 6Collaboration-Team-Backlog, 10Thanks: "Thank action failed. Please try again." - https://phabricator.wikimedia.org/T78697#851436 (10Mattflaschen) When you try again on the same diff, does it work? [21:53:12] 6Collaboration-Team-Backlog, 10Thanks: "Thank action failed. Please try again." - https://phabricator.wikimedia.org/T78697#851436 (10Etonkovidova) There was the same bug filed - {T128020} - then it got self-resolved. [21:55:53] mooeypoo: are new fixes to Notifications layout will fix https://phabricator.wikimedia.org/T128069 ? [22:01:39] 6Collaboration-Team-Backlog, 10Thanks: "Thank action failed. Please try again." - https://phabricator.wikimedia.org/T78697#2086286 (10JackPotte) On another PC (still with Firefox 44.0.2) it's just worked properly. [22:01:55] etonkovidova, these should be fixed yeah [22:02:04] mooeypoo: ok [22:21:51] (03CR) 10Mattflaschen: "Documentation can be addressed in a followup." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274690 (https://phabricator.wikimedia.org/T124687) (owner: 10Matthias Mullie) [23:01:17] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Should get notified for topic summary change on your own user talk - https://phabricator.wikimedia.org/T125119#2086639 (10jmatazzoni) Matthias notes that: > There was no complete spec for th... [23:11:05] 3Collaboration-Team-Current, 10Notifications: Adjust contrast and hover behaviour for the secondary actions displayed directly on notifications - https://phabricator.wikimedia.org/T128444#2086696 (10Mooeypoo) Should be fixed with https://gerrit.wikimedia.org/r/#/c/274804/ Note that we're using a LESS mixin fo... [23:11:21] (03PS2) 10Mooeypoo: Styling adjustments for notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274804 (https://phabricator.wikimedia.org/T125969) [23:11:53] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Adjust contrast and hover behaviour for the secondary actions displayed directly on notifications - https://phabricator.wikimedia.org/T128444#2074953 (10Mooeypoo) a:3Mooeypoo [23:20:37] 3Collaboration-Team-Current, 10Notifications: Show descriptions as tooltips for actions outside the "..." menu on notifications - https://phabricator.wikimedia.org/T127424#2043390 (10Mooeypoo) This is obviously technically doable, but we ran into questions about what to do in general with descriptions of secon... [23:21:32] 3Collaboration-Team-Current, 10Notifications: Show descriptions for the actions under the "..." menu on notifications - https://phabricator.wikimedia.org/T126738#2086766 (10Mooeypoo) Moving this to the Product/Design column [23:23:09] 3Collaboration-Team-Current, 10MediaWiki-extensions-ContentTranslation, 10Notifications, 5ContentTranslation-Release8, 7WorkType-Maintenance: Unusual dots displayed within a CX notification message - https://phabricator.wikimedia.org/T124422#2086770 (10Mooeypoo) 5Open>3Invalid I can't reproduce, and... [23:34:40] mooeypoo, is it supposed to mark read all the alerts when you open them, or just the visible ones? [23:38:11] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Librarization, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2086827 (10Mattflaschen) >>! In T128351#2085732, @Legoktm wrote: > This seems fine to me as well. My main objection is the code that implements mentions kind... [23:40:15] (03PS30) 10Mattflaschen: Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [23:50:54] (03CR) 10Siebrand: [C: 032] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274162 (https://phabricator.wikimedia.org/T121936) (owner: 10Catrope) [23:55:11] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Should get notified for topic summary change on your own user talk - https://phabricator.wikimedia.org/T125119#2086897 (10jmatazzoni) Regarding the issue of what to do when a topic is both s... [23:56:34] matt_flaschen, all notifications that you have in your bundle, so all "visible" ones [23:56:40] not all notifications in the remote wiki [23:58:27] mooeypoo, I'm not talking about remote. There were 99+ on the local wiki, and it apparently marked them all as read. [23:58:51] Is this one of the TODOs?