[01:50:24] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2071202 (10Catrope) >>! In T128249#2071151, @Legoktm wrote: > [14:11:39] RoanKattouw: there's been a bunch of changes to the caching... [02:18:18] (03CR) 10Catrope: [C: 04-2] "Please file a bug and discuss on Phabricator first" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273588 (owner: 10Siebrand) [02:18:40] (03CR) 10Catrope: [C: 04-2] "Please file a bug and discuss on Phabricator first" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273585 (owner: 10Siebrand) [04:10:21] 6Collaboration-Team-Backlog, 10Notifications: When mentioning other users, indicate mention notifications in the "your edit was saved" message - https://phabricator.wikimedia.org/T68078#682552 (10Alsee) +1 for this being a significant and persistent issue. The fact that you can't add a ping to an existing chun... [05:16:08] (03PS2) 10Gergő Tisza: Hungarian localization for special messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254814 (https://phabricator.wikimedia.org/T119365) [05:16:20] (03CR) 10Gergő Tisza: Hungarian localization for special messages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254814 (https://phabricator.wikimedia.org/T119365) (owner: 10Gergő Tisza) [05:17:08] 6Collaboration-Team-Backlog, 10Flow, 10Wikimedia-Site-Requests, 13Patch-For-Review: Enable Flow for testing on Hungarian Wikipedia - https://phabricator.wikimedia.org/T119365#2071363 (10Tgr) Apologies for the delay. I changed the links to use canonical name, so there should be no links anyore that could br... [05:24:43] 6Collaboration-Team-Backlog, 10Flow: Convert LQT->Flow on Hungarian Wikipedia and freeze LQT - https://phabricator.wikimedia.org/T119571#2071364 (10Tgr) See T119365#2071363. I found those accidentally, there might be more. (As long as they won't cause any errors, losing them is not a problem.) [06:13:46] (03PS1) 10Legoktm: Add some debug logging to thank-you-edit notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273849 (https://phabricator.wikimedia.org/T128249) [06:33:57] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2071386 (10Luke081515) @Catrope You can check my account at dewikivoyage to, this affected my too: T128271. I get double notifications at vagr... [07:25:23] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2071432 (10Legoktm) [07:26:50] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10MediaWiki-Watchlist, 10Notifications: RfC: Need to merge Notifications and Watchlist or lack thereof - https://phabricator.wikimedia.org/T128352#2071445 (10Legoktm) [09:16:26] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2071580 (10Pginer-WMF) > @Pginer-WMF : Any ideas for how we could rework the UI to co... [10:17:39] 6Collaboration-Team-Backlog, 10Flow: Please set up the Flow extension on the Konkani Wikipedia (gom) - https://phabricator.wikimedia.org/T128359#2071624 (10The_Discoverer) [10:20:19] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Should get notified for topic summary change on your own user talk - https://phabricator.wikimedia.org/T125119#2071640 (10Pginer-WMF) >>! In T125119#2068467, @Mattflaschen wrote: >>>! In T125... [11:17:37] 6Collaboration-Team-Backlog, 10Flow, 10Wikimedia-Site-Requests: Please set up the Flow extension on the Konkani Wikipedia (gom) - https://phabricator.wikimedia.org/T128359#2071752 (10Aklapper) Setting project to #Wikimedia-Site-Requests, as this request is about settings / configuration of a Wikimedia websit... [11:36:56] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Items in the more actions menu of notifications are inconsistent - https://phabricator.wikimedia.org/T126734#2071781 (10Pginer-WMF) Thanks for the adjustments @Mooeypoo with the size specifications (e.g., those on T119374), I'm more interested... [11:43:53] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: [minor] Notification panel layout issues for multiline messages - https://phabricator.wikimedia.org/T125909#2071790 (10Pginer-WMF) >>! In T125909#2068334, @Mooeypoo wrote: > This is going to be a mess to implement, honestly, mostly because of... [11:50:55] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Rephrase Flow notifications, move content from body into header - https://phabricator.wikimedia.org/T121950#2071799 (10Pginer-WMF) I think it makes sense to keep them consistent, with the board (the talk page i... [11:59:43] 3Collaboration-Team-Current, 10Notifications: Project labels inside the cross-wiki bundle should link to the target wiki Notification Page - https://phabricator.wikimedia.org/T127419#2071816 (10Pginer-WMF) >>! In T127419#2067327, @Catrope wrote: > I'm not sure linking to Special:Notifications is a good idea at... [12:09:39] (03PS3) 10Matthias Mullie: Better error handling and hook use for moves [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273414 (https://phabricator.wikimedia.org/T127693) (owner: 10Mattflaschen) [12:09:42] (03PS1) 10Matthias Mullie: TalkpageManager method renames [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273878 [12:10:03] (03CR) 10Matthias Mullie: Better error handling and hook use for moves (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273414 (https://phabricator.wikimedia.org/T127693) (owner: 10Mattflaschen) [12:11:41] (03CR) 10Matthias Mullie: Better error handling and hook use for moves (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273414 (https://phabricator.wikimedia.org/T127693) (owner: 10Mattflaschen) [12:17:06] (03CR) 10Matthias Mullie: [C: 032] "My feedback was not blocking, so I've submitted my suggestions as a follow-up patch that we can discuss, and I'm going to merge this" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273414 (https://phabricator.wikimedia.org/T127693) (owner: 10Mattflaschen) [12:31:11] (03Merged) 10jenkins-bot: Better error handling and hook use for moves [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273414 (https://phabricator.wikimedia.org/T127693) (owner: 10Mattflaschen) [12:38:18] (03CR) 10Matthias Mullie: Add notifications for summary changes (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273231 (https://phabricator.wikimedia.org/T125119) (owner: 10Matthias Mullie) [12:39:03] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2071918 (10Pginer-WMF) >>! In T128069#2067699, @Mooeypoo wrote: > For the sake of consistency, and, more importantly, for the sake of Mobile... [13:53:44] 6Collaboration-Team-Backlog, 10Notifications: Cross-wiki notifications inform me of very old replies - https://phabricator.wikimedia.org/T128373#2072064 (10Elitre) [14:28:19] (03PS1) 10Matthias Mullie: Split SourceStore classes in separate files [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273902 [14:28:22] (03PS1) 10Matthias Mullie: Add a source store that uses import results [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273903 (https://phabricator.wikimedia.org/T119509) [14:29:26] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#2072125 (10Pginer-WMF) > @Pginer-WMF, what do you think? I was thinking of... [15:25:21] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2072252 (10matmarex) >>! In T121936#2071580, @Pginer-WMF wrote: > First, I'd like to... [15:27:19] 6Collaboration-Team-Backlog, 10Flow: Session failure when you want to "mark as patrolled" a diff on Flow. - https://phabricator.wikimedia.org/T128379#2072268 (10Trizek-WMF) [15:27:27] 6Collaboration-Team-Backlog, 10Flow: Session failure when you want to "mark as patrolled" a diff on Flow. - https://phabricator.wikimedia.org/T128379#2072282 (10Trizek-WMF) [15:43:10] (03PS1) 10Ricordisamoa: build: Update grunt-jscs to 2.7.0 and disable failing rules [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273918 [15:58:47] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-LiquidThreads: Blank talk pages on Portuguese Wikibooks: Fatal exception of type MWUnknownContentModelException - https://phabricator.wikimedia.org/T128293#2072391 (10He7d3r) [16:14:40] SWAT completed; Board moves confirmed fixed in production (tested MediaWiki.org, but should be fixed everywhere). [16:15:15] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/Flow] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/273536 (https://phabricator.wikimedia.org/T127785) (owner: 10Mattflaschen) [16:19:56] (03CR) 10Anomie: Converted WikiLove to new extension registration (031 comment) [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/262719 (https://phabricator.wikimedia.org/T87996) (owner: 10Mhutti1) [16:20:24] Okay, I misread it, and only the edit notification one was out. I do not see a spurious edit notification on MediaWiki.org, but I only tested one edit (but disabled is disabled). [16:20:31] I don't know why the move suddenly worked, though. [16:25:06] (03Merged) 10jenkins-bot: Fix board move DB issue using new hook TitleMoveStarting [extensions/Flow] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/273536 (https://phabricator.wikimedia.org/T127785) (owner: 10Mattflaschen) [16:29:52] (03CR) 10Jforrester: [C: 032] build: Update grunt-jscs to 2.7.0 and disable failing rules [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273918 (owner: 10Ricordisamoa) [16:38:53] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-Requests: Please set up the Flow extension on the Konkani Wikipedia (gom) - https://phabricator.wikimedia.org/T128359#2072495 (10Trizek-WMF) [16:44:29] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-Requests: Please set up the Flow extension on the Konkani Wikipedia (gom) - https://phabricator.wikimedia.org/T128359#2072519 (10Trizek-WMF) Have you checked if all translations are ready? Do you want to have a Flow... [16:49:09] (03Merged) 10jenkins-bot: build: Update grunt-jscs to 2.7.0 and disable failing rules [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273918 (owner: 10Ricordisamoa) [17:03:54] (03PS1) 10Ricordisamoa: build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273935 [17:04:20] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2072613 (10RobLa-WMF) [17:04:56] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2071432 (10RobLa-WMF) [17:15:39] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10MediaWiki-Watchlist, 10Notifications: RfC: Need to merge Notifications and Watchlist or lack thereof - https://phabricator.wikimedia.org/T128352#2071445 (10RobLa-WMF) @Legoktm - thanks for filing this! I'd like to alter the description field of this ticket in... [17:16:22] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 10Wikimedia-Site-Requests: Please set up the Flow extension on the Konkani Wikipedia (gom) - https://phabricator.wikimedia.org/T128359#2072676 (10The_Discoverer) Hi @Trizek-WMF, we can have a trial page if you want or if the process... [17:16:24] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10Notifications: RfC: Notifications in core - https://phabricator.wikimedia.org/T128351#2071432 (10RobLa-WMF) [17:23:54] 6Collaboration-Team-Backlog, 10Notifications: cross-wiki: If a user sees Alerts and marks as read Messages in local wikis, then the cross-wiki bundle displays 'There are no notifications' - https://phabricator.wikimedia.org/T127242#2072713 (10Etonkovidova) Checked in betalabs - the issue is fixed. [17:24:12] 6Collaboration-Team-Backlog, 10Notifications: cross-wiki: If a user sees Alerts and marks as read Messages in local wikis, then the cross-wiki bundle displays 'There are no notifications' - https://phabricator.wikimedia.org/T127242#2072716 (10Etonkovidova) 5Open>3Resolved [17:26:21] my dad's car ran out of oil so I need to run and get him some more [17:29:57] * legoktm will bbl [17:32:20] 3Collaboration-Team-Current, 10Flow, 5MW-1.27-release-notes, 13Patch-For-Review, and 3 others: Board moves in Flow not working - https://phabricator.wikimedia.org/T127785#2072768 (10Mattflaschen) It turns out this worked without the fix on wikis that use a separate flowdb. I don't really understand why.... [17:36:55] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2072785 (10Pginer-WMF) > "Catalan Wikipedia" in this sentence means the actual Catala... [17:42:01] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2072811 (10Mattflaschen) We could consider: "More messages from 4 other wikis". rat... [17:49:16] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2072833 (10matmarex) >>! In T121936#2072785, @Pginer-WMF wrote: >> "Catalan Wikipedia... [17:50:39] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Unread count in echo_unread_wikis cannot go back to zero - https://phabricator.wikimedia.org/T127331#2040107 (10Etonkovidova) Checked in betalabs - foreign wik... [18:00:14] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-02-16_(1.27.0-wmf.14), 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Unread count in echo_unread_wikis cannot go back to zero - https://phabricator.wikimedia.org/T127331#2072869 (10jmatazzoni) 5Open>3Resolved [18:32:28] greg-g, can I do an urgent hotfix to fix Flow on ptwikibooks? https://gerrit.wikimedia.org/r/#/c/273948/1/dblists/nonflow.dblist [18:34:03] matt_flaschen: sure [18:43:09] (03CR) 10Mooeypoo: Add a short abbreviation for timestamps in notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273560 (https://phabricator.wikimedia.org/T125970) (owner: 10Mooeypoo) [18:52:42] (03CR) 10Jforrester: [C: 032] Remove redundant vendor prefix for border-radius [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/273741 (https://phabricator.wikimedia.org/T128301) (owner: 10Krinkle) [18:54:19] (03Merged) 10jenkins-bot: Remove redundant vendor prefix for border-radius [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/273741 (https://phabricator.wikimedia.org/T128301) (owner: 10Krinkle) [19:07:37] 6Collaboration-Team-Backlog, 10Notifications: Have the home-wiki first on Cross-wiki Notifications - https://phabricator.wikimedia.org/T128398#2073112 (10Trizek-WMF) [19:12:51] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2073145 (10Pginer-WMF) A promising option we explored is to not mention the wikis as... [19:25:46] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2073209 (10Catrope) [19:34:03] 6Collaboration-Team-Backlog, 10Notifications: Cross-wiki notifications inform me of very old replies - https://phabricator.wikimedia.org/T128373#2072064 (10Catrope) I don't think this is really a bug. If someone replied to you on mediawikiwiki, that means you were once active there, and apparently you then did... [19:37:39] 6Collaboration-Team-Backlog, 10Notifications: Cross-wiki notifications inform me of very old replies - https://phabricator.wikimedia.org/T128373#2073237 (10Elitre) Yeah, I guess the question was, does it really need to tell me about those long-forgotten messages? :) [19:47:12] (03CR) 10Catrope: [C: 032] Add some debug logging to thank-you-edit notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273849 (https://phabricator.wikimedia.org/T128249) (owner: 10Legoktm) [19:57:01] (03Merged) 10jenkins-bot: Add some debug logging to thank-you-edit notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273849 (https://phabricator.wikimedia.org/T128249) (owner: 10Legoktm) [20:03:54] mooeypoo: BTW https://gerrit.wikimedia.org/r/#/c/272651/ is -1ed and would be nice to get fixed today so it can be merged and make it into tomorrow's cut [20:04:22] matt_flaschen: You said you'd re-review https://gerrit.wikimedia.org/r/#/c/264766/ right? [20:06:59] RoanKattouw, added it in now, but I'm having a problem testing - my notification text isn't that wide, the wordwrap works to obscure the issue. Can you test with the notification you saw it in once I push the new fix? [20:07:25] (03PS4) 10Mooeypoo: Transform the notification action bar to css table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272651 (https://phabricator.wikimedia.org/T125909) [20:07:32] RoanKattouw, ^^ [20:07:58] mooeypoo: I lost that one so I had to manually change the notification text to trigger [20:07:58] it [20:07:58] But yes will test [20:08:11] oh, I didn't consider that, ha [20:08:22] I thought you saw it somewhere on dutch or german text [20:08:24] I'll double-check too [20:08:59] mooeypoo: Also, I looked at Stephane's changes to https://gerrit.wikimedia.org/r/#/c/271690/6 in response to your review, and they look good to me. Wanna take a last look at that and merge if you approve? [20:09:12] yep was going to do that next [20:11:48] (03CR) 10Catrope: [C: 032] Transform the notification action bar to css table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272651 (https://phabricator.wikimedia.org/T125909) (owner: 10Mooeypoo) [20:15:31] RoanKattouw, yeah. [20:15:37] I'm working on it. [20:15:57] Cool, thank you both [20:16:23] mooeypoo: Another item for your queue: https://gerrit.wikimedia.org/r/272934 [20:16:44] (03PS2) 10Catrope: Adjust group bundle styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273533 (https://phabricator.wikimedia.org/T128069) (owner: 10Mooeypoo) [20:17:54] 6Collaboration-Team-Backlog, 10Notifications: Have the home-wiki first on Cross-wiki Notifications - https://phabricator.wikimedia.org/T128398#2073435 (10Mattflaschen) Idea is to get this from CentralAuth. Need to consider whether this helpful, and whether the CentralAuth data matches well enough with user's... [20:19:38] 6Collaboration-Team-Backlog, 10Notifications: Have the home-wiki first on Cross-wiki Notifications - https://phabricator.wikimedia.org/T128398#2073112 (10Catrope) Somewhat related: https://gerrit.wikimedia.org/r/273569 orders the wikis in cross-wiki notifications by timestamp, whereas previously the order was... [20:20:17] (03CR) 10Mooeypoo: [C: 04-1] "Small documentation note. Looks great otherwise!" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) (owner: 10Sbisson) [20:22:00] RoanKattouw, why are we bidi-isolating "mark as read" ? It seems to never be in a context where isolating it is needed? [20:22:19] (03CR) 10Catrope: Include cross-wiki notifications in unread count (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) (owner: 10Sbisson) [20:22:31] mooeypoo: Ha, good point [20:24:36] (03CR) 10Catrope: [C: 032] Adjust group bundle styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273533 (https://phabricator.wikimedia.org/T128069) (owner: 10Mooeypoo) [20:25:26] (03CR) 10Mooeypoo: Include cross-wiki notifications in unread count (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) (owner: 10Sbisson) [20:25:45] RoanKattouw, ok, I'll add the comment inline, I was just wondering if I was missing something [20:26:26] No, I was just trying to be "consistent" :P [20:26:37] Without considering the real-world consequences [20:28:24] (03PS2) 10Catrope: Bidi-isolate secondary link labels and notification bodies [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272934 (https://phabricator.wikimedia.org/T127407) [20:28:36] (03Merged) 10jenkins-bot: Transform the notification action bar to css table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272651 (https://phabricator.wikimedia.org/T125909) (owner: 10Mooeypoo) [20:30:45] (03CR) 10Mooeypoo: [C: 04-1] Bidi-isolate secondary link labels and notification bodies [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272934 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [20:31:19] mooeypoo: I think there's a race condition there where you -1ed after I already amended my patch to fix that? [20:31:24] RoanKattouw, bidi-isolate is best used when it's isolating inline strings inside different-context strings [20:31:39] RoanKattouw, oh... I had a couple more comments [20:31:43] Ph [20:31:45] I'll look again [20:31:55] I don't see them though, you might have to submit them separately because they're on PS1 [20:32:02] but anyways, the isolation is a bit weird here. We are isolating *full strings* that are themselves encapsulated in or
[20:32:28] there's no need for that. What there is a need for is the dir=auto, to make the string behave "properly" *if* it's in a different direction than your current interface dir [20:32:47] so the "content" of the notification should be dir=auto, but not because we are "isolating" it... that makes sense? [20:33:16] OK so you're saying that instead of wrapping in I should be applying dir=auto to the ? [20:33:22] Hm, wait, the secondary button... I may be wrong there.... let me rethink the examples [20:33:58] Also note I already used dir=auto for the body, I had to to make text-overflow: ellipsis; work sensibly [20:34:03] The message content uses dir=auto already, my comment was more about the comment you wrote... it's probably the right thing to do not just because of the ellipses.... [20:34:31] Happy to use dir=auto on these label spans too, it's visually identical to . I used because I thought that would be better semantically, but if dir=auto is better then I'll use that [20:34:39] * RoanKattouw changes [20:34:40] but wait [20:34:42] waaaait [20:34:47] RoanKattouw, hang on a minute. [20:34:54] (03CR) 10Catrope: [C: 032] Adjust styling of the 'more actions' menu items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273541 (https://phabricator.wikimedia.org/T126734) (owner: 10Mooeypoo) [20:35:14] The "mark as read" needs no isolation -- but help me out here, why do we need an isolation for the secondary actions? What cases am I missing? I'm sure I am [20:35:43] (03Merged) 10jenkins-bot: Adjust group bundle styles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273533 (https://phabricator.wikimedia.org/T128069) (owner: 10Mooeypoo) [20:36:04] mooeypoo: Most notification types have the agent (user) as a secondary action [20:36:09] So about 30-40% of all secondary action labels are user names [20:36:28] However we can do that isolation on the server side too [20:36:39] That's probably a better idea come to think of it [20:37:40] okay, yeah [20:37:56] (03PS3) 10Catrope: Bidi-isolate notification bodies [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272934 (https://phabricator.wikimedia.org/T127407) [20:38:03] I would isolate usernames on the serverside in any case, just so we can also have them isolated inside the messages [20:38:07] when/if we get them [20:38:36] Yeah we already do that [20:38:37] RoanKattouw, But yeah, ignore my ocmment about the secondary actions. isolation there is a good idea. [20:38:59] There's a different patch I wrote that's already merged that bidi-embeds the $1 parameter that contains the user name [20:39:22] mooeypoo: You've already convinced me that it was a bad idea and should be done server-side [20:39:22] So that's what I'm doing now [20:39:42] Less code, anyway [20:39:51] RoanKattouw, okay either way works, yeah [20:40:11] RoanKattouw, sorry, I was getting confused about which was a fixed label for the button and which wasn't [20:40:38] Flipping the content of a notification *body* is a good idea, though. [20:41:00] Yes [20:41:04] That's all the patch does now as of PS3 [20:41:10] * mooeypoo nods [20:41:12] I'm testing [20:42:16] I have a "I know how to try and break this" Roan-moment. If it passes, I'm +2ing. [20:42:23] haha [20:42:33] Note that I tried ellipsis already :) [20:43:04] RoanKattouw, flying colors. [20:43:24] nono I wrote in my Admin talk page a note with a sentence in hebrew that ends with a question mark [20:43:39] without your fix, the notification body had the question mark at the wrong end... with it, at the correct end. Win. [20:44:03] Yes, I tried that too [20:44:45] (03Merged) 10jenkins-bot: Adjust styling of the 'more actions' menu items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273541 (https://phabricator.wikimedia.org/T126734) (owner: 10Mooeypoo) [20:45:10] You think of gnihtyreve [20:47:02] (03CR) 10Mooeypoo: [C: 032] "Beautiful" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272934 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [20:48:16] matt_flaschen: betalabs - Moving any page to any location shows "User does not have the "Create Flow boards in any location" permission" [20:48:28] matt_flaschen: is it expected? [20:48:35] (03PS1) 10Catrope: Bidi-embed user names and page names in secondary links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273968 (https://phabricator.wikimedia.org/T127407) [20:49:53] etonkovidova, what user are you testing with? [20:50:20] mooeypoo: ---^^ [20:50:33] That's the server-side patch [20:50:40] matt_flaschen: ET4 and ET1. I am just puzzled why creating Flow board permission? [20:51:14] matt_flaschen: esp if I am moving pages just in artcile namespace [20:52:34] etonkovidova, because otherwise you can bypass the restrictions. E.g. move a talk page from a Flow namespace (like Wikpedia talk on Catalan Wikipedia) to article namespace. [20:52:54] If you have the ability to create a Flow board anyway in article talk, that's fine. If not, then you shouldn't be able to do it a roundabout way either. [20:53:17] So it's based on whether the user has the right to create a Flow board at that destination. [20:53:31] matt_flaschen: hmm... well, makes sense . Kind of a very strict limitation though [20:53:33] (03PS7) 10Sbisson: Include cross-wiki notifications in unread count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) [20:54:35] etonkovidova, we could look at allowing moves within a non-Flow namespace, but that might still be problematic. [20:54:45] (03PS2) 10Catrope: Bidi-embed user names and page names in secondary links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273968 (https://phabricator.wikimedia.org/T127407) [20:54:52] matt_flaschen: I was just typing that :) [20:56:07] matt_flaschen: I thinking - right now we allow many categories of users to move pages, right? And after enabling Flow - the number of users who can do that would be much much less? [20:56:42] Yeah, the reason it might still be problematic is that we sometimes carefully choose which pages to enable. We don't want people moving Wikipedia_talk:Some_minor_page to Wikipedia_talk:Administrators_noticeboard if Wikipedia_talk is not default-Flow. [20:56:47] etonkovidova, define "enabling Flow". [20:57:03] If it's enabled on one board, only that board will be move-restricted. [20:57:12] If it's enabled on a whole namespace, anyone can still move within that namespace. [20:57:20] (03Merged) 10jenkins-bot: Bidi-isolate notification bodies [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272934 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [20:58:15] It's also possible to fully configure who gets flow-create-board, but you're right it's more restricted (how much more depends). [20:58:17] (03CR) 10jenkins-bot: [V: 04-1] Include cross-wiki notifications in unread count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) (owner: 10Sbisson) [20:58:26] matt_flaschen: hmm... I''ll re-check but it looks that users without "Create Flow boards in any location" permission cannot move any page [20:59:21] etonkovidova, any page? They should be able to move within Flow_test_talk (or Wikipedia_talk on Catalan Wikipedia). Non-Flow boards should not be affected in any way. This might be a regression, though, let me look. [20:59:25] I think I tested that, though. [20:59:55] matt_flaschen: I am looking too... [21:01:27] Looks broken, testing locally. [21:02:11] (03PS8) 10Sbisson: Include cross-wiki notifications in unread count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) [21:02:53] etonkovidova, really glad you caught that. [21:03:12] matt_flaschen: :) good [21:07:30] (03CR) 10Mooeypoo: [C: 032] "Works well, and makes the truncated username label consistent with the truncated username inside the main notification message." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273968 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [21:09:46] (03PS1) 10Mattflaschen: Fix regression requiring flow-create-board for non-Flow moves [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273971 [21:11:08] RoanKattouw_away: do you want to SWAT the logging patch? [21:11:43] ^ RoanKattouw_away https://gerrit.wikimedia.org/r/273971 must go in before branch cut. [21:14:17] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-LiquidThreads: Blank talk pages on Portuguese Wikibooks: Fatal exception of type MWUnknownContentModelException - https://phabricator.wikimedia.org/T128293#2069760 (10Mattflaschen) Fixed by https://gerrit.wikimedia.org/r/#/c/273948/1 , which is depl... [21:14:56] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-LiquidThreads: Blank talk pages on Portuguese Wikibooks: Fatal exception of type MWUnknownContentModelException - https://phabricator.wikimedia.org/T128293#2073635 (10Mattflaschen) a:3Mattflaschen [21:18:30] RoanKattouw_away, also if we want to SWAT out the move hook patch (to investigate https://phabricator.wikimedia.org/T127693), that also needs to be merged and SWATed (but we can wait if needed for that). [21:24:20] (03Merged) 10jenkins-bot: Bidi-embed user names and page names in secondary links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273968 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [21:25:36] (03CR) 10Legoktm: [C: 032] Fix regression requiring flow-create-board for non-Flow moves [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273971 (owner: 10Mattflaschen) [21:43:38] (03Merged) 10jenkins-bot: Fix regression requiring flow-create-board for non-Flow moves [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273971 (owner: 10Mattflaschen) [21:47:42] matt_flaschen: That would involve SWATting both move-related patches, right? In that case I think we might as well wait for tomorrow's branch cut given how not-small those patches are [21:47:59] Re logging patch, yes I'll add that one to the SWAT [21:48:27] (03PS1) 10Catrope: Add some debug logging to thank-you-edit notifications [extensions/Echo] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/273981 (https://phabricator.wikimedia.org/T128249) [21:51:04] RoanKattouw, yeah, I'm fine with waiting. [21:53:34] 6Collaboration-Team-Backlog, 10Notifications: [betalabs] Regression: Creating Summary notifications dipslay <notification-header-flow-summary-edited-first> - https://phabricator.wikimedia.org/T128414#2073828 (10Etonkovidova) [22:14:29] RoanKattouw: can you please check if https://gerrit.wikimedia.org/r/#/c/273232/ was really Merged? There is a simple fix and I do not see it ... [22:16:30] Should be... [22:17:03] etonkovidova: Hmm it should be... [22:17:15] RoanKattouw: well, then the patch does not work :( [22:17:38] wtf http://en.wikipedia.beta.wmflabs.org/w/index.php?title=MediaWiki:Notification-header-flow-mention-post-summary&action=edit [22:18:07] I think that might be related to https://phabricator.wikimedia.org/T128414#2073828 [22:19:24] 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure: Set up second External Store cluster on Beta - https://phabricator.wikimedia.org/T128417#2073927 (10Mattflaschen) [22:20:10] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Generate flow-mention for create/edit of board desc, topic, post, summary - https://phabricator.wikimedia.org/T125427#2073941 (10Etonkovidova) @SBisson - There is a regression issue with displaying Summary noti... [22:26:22] (03CR) 10Catrope: [C: 032] Include cross-wiki notifications in unread count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) (owner: 10Sbisson) [22:36:04] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Should get notified for topic summary change on your own user talk - https://phabricator.wikimedia.org/T125119#1978901 (10Etonkovidova) Re-check after {T128414} is fixed. [22:36:39] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): 'Mark as read' dots menu is misaligned - https://phabricator.wikimedia.org/T126686#2020813 (10Catrope) It's no longer misaligned, but now it's all the way over to the right. Is that what we want? CC @... [22:39:45] (03Merged) 10jenkins-bot: Include cross-wiki notifications in unread count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) (owner: 10Sbisson) [22:43:22] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7Voice & Tone, and 2 others: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#2074012 (10jmatazzoni) Matt wrote: > ...since the board name doesn't app... [22:43:41] (03CR) 10Jforrester: [C: 032] build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273935 (owner: 10Ricordisamoa) [22:45:42] 3Collaboration-Team-Current, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2054765 (10jmatazzoni) a:3jmatazzoni [22:46:02] 3Collaboration-Team-Current, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2054765 (10jmatazzoni) I'll take a stab at writing the copy for these. [22:55:04] 6Collaboration-Team-Backlog, 10Notifications: Echo (Notifications) popup controls should be moved to the top of the list - https://phabricator.wikimedia.org/T128094#2074044 (10jmatazzoni) Hi Chris. Consistency is definitely one of the polestars of UI design, so thanks for bringing your observation to our atten... [22:58:27] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2074052 (10jmatazzoni) [22:59:05] It's a little confusing how it gives you an overall notification count when you only request notifications for a single section. [22:59:53] (03Merged) 10jenkins-bot: build: Enable jscs rule 'requireSpacesInsideBrackets' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273935 (owner: 10Ricordisamoa) [23:01:09] etonkovidova: Reedy just told me that the beta cluster i18n thing should be fixed now [23:01:25] RoanKattouw: great! [23:02:09] matt_flaschen: "it"? [23:03:29] RoanKattouw, ApiEchoNotifications [23:04:19] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#1781222 (10jmatazzoni) Here are notes from the 2/29/16 Collab Team Discussion meeting: Do we want to send a message to users abou... [23:04:32] Oh, hah [23:04:37] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2074075 (10jmatazzoni) a:3Pginer-WMF [23:05:17] matt_flaschen: Speaking of, https://gerrit.wikimedia.org/r/273569 is stuck on a similar issue. It basically does what it says on the tin except that the timestamp info output by ApiEchoNotifications is in the wrong place and so is global instead of per-section [23:05:24] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#1781222 (10jmatazzoni) I'm assigning this to Pau to propose a design based on our discussion. [23:05:33] I can and will change that, but it was late on Friday night so I put that off [23:18:33] (03PS1) 10Ricordisamoa: build: Enable jscs rule 'requireVarDeclFirst' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/274010 [23:29:11] (03CR) 10Mattflaschen: [C: 04-1] "A couple simple things." (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo)