[00:00:33] (03CR) 10Catrope: [C: 04-1] "Let's not use all this dirty log stuff." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273544 (owner: 10Jforrester) [00:02:15] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: [minor] Notification panel layout issues for multiline messages - https://phabricator.wikimedia.org/T125909#2068334 (10Mooeypoo) a:3Mooeypoo [00:03:47] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: [minor] Notification panel layout issues for multiline messages - https://phabricator.wikimedia.org/T125909#2000378 (10Mooeypoo) This is going to be a mess to implement, honestly, mostly because of the table layout that solves a lot of other i... [00:10:35] (03Merged) 10jenkins-bot: Provide three more edit threshold congratulatory notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273543 (owner: 10Jforrester) [00:27:56] James_F, awesome that you added up to a million. Now I have 100K to look forward to. [00:28:19] matt_flaschen: I wrote and then dropped a ten millionth one. ;-) [00:28:39] matt_flaschen: Bots can accept not getting one. :-0 [00:29:27] James_F, also, me when I started editing Wikipedia would have loved your log commit. Check out my first edit. :) [00:30:10] RIP Superm401 [00:30:12] matt_flaschen: https://en.wikipedia.org/w/index.php?title=Natural_logarithm&diff=prev&oldid=3221490 ? [00:30:30] matt_flaschen: :-) [00:30:42] legoktm, and RIP superm40 (before I forgot that AOL password and had to switch to superm401). [00:30:46] James_F, yep. [00:31:11] hah [00:31:36] at one point my AIM username was legoktm11 until I lost that password and switched to ktmlego11 [00:32:09] * James_F grins. [00:32:31] Wow, thanks to legoktm I suddenly remembered my ICQ id for the first time in at least a decade. [00:32:34] (15108888) [00:32:53] I have mine written down somewhere :P [00:33:18] I don't think mine's active anymore for like... 15 years [00:41:11] 6Collaboration-Team-Backlog, 10Notifications: cross-wiki: If a user sees Alerts and marks as read Messages in local wikis, then the cross-wiki bundle displays 'There are no notifications' - https://phabricator.wikimedia.org/T127242#2068429 (10Etonkovidova) Re-checked with {T127331} - whether that fix also fix... [01:13:29] (03CR) 10Mattflaschen: [C: 032] Add notifications for summary changes (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273231 (https://phabricator.wikimedia.org/T125119) (owner: 10Matthias Mullie) [01:14:26] 3Collaboration-Team-Current, 10Flow, 10Notifications, 13Patch-For-Review: Should get notified for topic summary change on your own user talk - https://phabricator.wikimedia.org/T125119#2068467 (10Mattflaschen) >>! In T125119#2064079, @Pginer-WMF wrote: > The idea is for resolved to take precedence over sum... [01:15:04] (03PS3) 10Catrope: Transform the notification action bar to css table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272651 (https://phabricator.wikimedia.org/T125909) (owner: 10Mooeypoo) [01:17:13] matt_flaschen: Thanks for reviewing that. Can I grab a quick +2 on https://gerrit.wikimedia.org/r/#/c/273531/ as well? [01:17:36] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7Voice & Tone, and 2 others: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#2068484 (10Mattflaschen) >>! In T56433#2063991, @jmatazzoni wrote: >> Menti... [01:17:44] mooeypoo: https://gerrit.wikimedia.org/r/#/c/272934/ [01:19:01] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7Voice & Tone, and 2 others: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#2068491 (10Mattflaschen) Never mind, that's not applicable, since the board... [01:19:33] Sure [01:20:23] (03PS1) 10Mooeypoo: Add a short abbreviation for timestamps in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273560 (https://phabricator.wikimedia.org/T125970) [01:20:29] RoanKattouw, same question/issue as mlitn's patch. Can't we keep it, but just not make it non-prioritized? Does that work yet (to go in ... if non-prioritized)? [01:20:39] I mean *yes* make it non-prioritized. [01:20:53] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Use more compact timestamps for notifications - https://phabricator.wikimedia.org/T125970#2068500 (10Mooeypoo) a:3Mooeypoo [01:21:11] We've never tested it but it should work I think [01:21:13] Yeah we could do that [01:21:30] RoanKattouw, okay, I'll test it after you amend. Two birds. [01:21:46] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Use more compact timestamps for notifications - https://phabricator.wikimedia.org/T125970#2001832 (10Mooeypoo) Timestamps are now short with this commit; only caveat is that we have to make sure these abbreviations are translated. Also, this... [01:23:21] (03CR) 10Mattflaschen: [C: 032] Remove unneeded variable assignment [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268643 (owner: 10Umherirrender) [01:30:53] (03CR) 10Catrope: [C: 04-1] "You should add some padding-right on content-message in the bundled case. Right now the text can get very close to the timestamp. Looks go" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272651 (https://phabricator.wikimedia.org/T125909) (owner: 10Mooeypoo) [01:33:20] (03PS2) 10Catrope: MentionPresentationModel: Deprioritize pageLink [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273531 (https://phabricator.wikimedia.org/T125949) [01:33:27] matt_flaschen: ---^^ WFM [01:36:49] 3Collaboration-Team-Current, 10Notifications: Provide items inside a bundle with a more concise text copy - https://phabricator.wikimedia.org/T127813#2068507 (10Catrope) [01:39:00] 3Collaboration-Team-Current, 10Notifications, 7Performance: Echo makes too many round-trips to memcached - https://phabricator.wikimedia.org/T127687#2068508 (10Catrope) >>! In T127687#2052218, @Catrope wrote: > As for the others, I agree a single key would be better. Could you elaborate on what you mean by t... [01:39:27] RoanKattouw, it works. I didn't realize it was the same as the primary link. Which patch set do you think is better? I can merge either. [01:39:39] It might be slightly redundant, but I could go either way. [01:39:57] matt_flaschen: I'm more in favor of removing it altogether because of how redundant it is [01:40:05] At least for Flow notifs, board != topic [01:40:24] But for wikitext mentions, the primary link is just a #section link to the same page [01:40:30] RoanKattouw, agreed. I'll merge PS 1. [01:40:49] Thanks [01:40:56] Sorry, I should have checked that before asking you to amend. [01:41:21] (03PS3) 10Mattflaschen: MentionPresentationModel: Remove pageLink from secondary links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273531 (https://phabricator.wikimedia.org/T125949) (owner: 10Catrope) [01:41:37] No worries, I also only thought of it after amending [01:41:58] I was doing something else so I just went into robot mode and programmed what you asked for without thinking about it :) [01:43:19] (03CR) 10Mattflaschen: [C: 032] MentionPresentationModel: Remove pageLink from secondary links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273531 (https://phabricator.wikimedia.org/T125949) (owner: 10Catrope) [01:43:37] Good to know the non-prioritized things works, though, for future cases where it's more suitable. [01:43:41] 3Collaboration-Team-Current, 10Notifications: Measure how often the "mark all as read" action is used in the Notification Panel - https://phabricator.wikimedia.org/T127955#2068511 (10Catrope) [01:43:52] Yeah [01:46:18] 3Collaboration-Team-Current: Check that Collaboration team projects don't use session state in load.php - https://phabricator.wikimedia.org/T128005#2060929 (10Catrope) Why would any Echo or Flow code be run from load.php? They don't have custom ResourceLoader modules, and they don't hook into ResourceLoaderGetCo... [01:48:30] 3Collaboration-Team-Current, 10Flow, 10VisualEditor: default VE makes board description/post blink when opening for Edit - https://phabricator.wikimedia.org/T128013#2068518 (10Catrope) [01:54:06] 3Collaboration-Team-Current: Check that Collaboration team projects don't use session state in load.php - https://phabricator.wikimedia.org/T128005#2068523 (10Mattflaschen) >>! In T128005#2068512, @Catrope wrote: > Why would any Echo or Flow code be run from load.php? They don't have custom ResourceLoader module... [01:55:34] 3Collaboration-Team-Current: Check that Collaboration team projects don't use session state in load.php - https://phabricator.wikimedia.org/T128005#2068524 (10Mattflaschen) 5Open>3Resolved Also, Flow does hook into ResourceLoaderGetConfigVars, but it correctly does not vary by user. [02:03:23] (03PS1) 10Catrope: Pass through deletion reason parameters to talk page notif templates as well [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/273563 (https://phabricator.wikimedia.org/T128024) [02:48:47] 6Collaboration-Team-Backlog, 10Notifications: Notification that is shown in special page but not in flyout - https://phabricator.wikimedia.org/T128148#2065511 (10Catrope) This is what I found in the database: ``` mysql:research@s3-analytics-slave [enwiki]> select user_id from user where user_name='Soetermans';... [03:16:36] 6Collaboration-Team-Backlog, 10MoodBar, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): MoodBar background images are repeating - https://phabricator.wikimedia.org/T126311#2068556 (10Catrope) 5Open>3Resolved [03:33:57] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2068560 (10Catrope) Verified that translations are working in French and Ukranian: {... [04:07:38] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2068591 (10Smalyshev) Ukrainian one is unfortunately wrong - it uses wrong case. [05:08:49] Have a good weekend, everyone. [05:17:36] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2068605 (10Catrope) >>! In T121936#2068591, @Smalyshev wrote: > Ukrainian one is unfo... [05:23:43] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2068618 (10Catrope) Thankfully this isn't a problem in Dutch (where I just translated... [05:34:07] 6Collaboration-Team-Backlog, 10Notifications: Editing Wikidata triggered multiple notification of hundredth edit - https://phabricator.wikimedia.org/T128249#2068619 (10Kenrick95) [05:39:22] 6Collaboration-Team-Backlog, 10Notifications: Editing Wikidata triggered multiple notification of hundredth edit - https://phabricator.wikimedia.org/T128249#2068619 (10Catrope) ....wow. Most likely, this had the same root cause as {T123843}: when an article is saved, we look at your edit count, and if it's 99... [05:41:11] 6Collaboration-Team-Backlog, 10Notifications: Editing Wikidata triggered multiple notification of hundredth edit - https://phabricator.wikimedia.org/T128249#2068636 (10Catrope) Is this still happening, i.e. are new hundredth-edit notifications still being generated? The database tells me that User:Kenrick95 on... [05:54:57] (03CR) 10Catrope: [C: 032] "Jenkins...?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273231 (https://phabricator.wikimedia.org/T125119) (owner: 10Matthias Mullie) [05:56:24] (03PS1) 10Catrope: [WIP] In cross-wiki notifications, sort wikis by timestamp of most recent notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273569 [06:07:39] (03Merged) 10jenkins-bot: Add notifications for summary changes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273231 (https://phabricator.wikimedia.org/T125119) (owner: 10Matthias Mullie) [07:29:27] 6Collaboration-Team-Backlog, 10Notifications: Editing Wikidata triggered multiple notification of hundredth edit - https://phabricator.wikimedia.org/T128249#2068864 (10Kenrick95) Yup, I tried editing another item, and the notification is still being triggered. [07:56:48] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2068896 (10Nikerabbit) WHAT? How comes I did not notice you wanted to use this in a s... [08:04:05] (03CR) 10Catrope: [C: 032] "Jenkins...?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273531 (https://phabricator.wikimedia.org/T125949) (owner: 10Catrope) [08:20:58] (03Merged) 10jenkins-bot: MentionPresentationModel: Remove pageLink from secondary links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273531 (https://phabricator.wikimedia.org/T125949) (owner: 10Catrope) [10:45:21] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268643 (owner: 10Umherirrender) [10:46:25] (03Merged) 10jenkins-bot: Remove unneeded variable assignment [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268643 (owner: 10Umherirrender) [11:16:09] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) (owner: 10Bmansurov) [11:30:14] 6Collaboration-Team-Backlog, 10Flow, 7I18n: [[MediaWiki:Notification-body-flow-summary-edited/en]] i18n issue - https://phabricator.wikimedia.org/T128268#2069045 (10Liuxinyu970226) [11:48:32] 6Collaboration-Team-Backlog, 10Notifications: Double editcounter notifications - https://phabricator.wikimedia.org/T128271#2069079 (10Luke081515) [11:53:09] 3Collaboration-Team-Current, 10Notifications: Double editcounter notifications - https://phabricator.wikimedia.org/T128271#2069111 (10Luke081515) p:5Triage>3Unbreak! this is completly broken: I get this notification now **every time** I make an edit, see here: {F3436958 size=full} still from https://de.wik... [13:40:23] 3Collaboration-Team-Current, 10Notifications: Double editcounter notifications - https://phabricator.wikimedia.org/T128271#2069166 (10matej_suchanek) [13:40:25] 6Collaboration-Team-Backlog, 10Notifications: Editing Wikidata triggered multiple notification of hundredth edit - https://phabricator.wikimedia.org/T128249#2069167 (10matej_suchanek) [13:43:25] 6Collaboration-Team-Backlog, 10Notifications: Editing Wikidata triggered multiple notification of hundredth edit - https://phabricator.wikimedia.org/T128249#2069183 (10Luke081515) p:5Triage>3Unbreak! This is very annoying for users, so triaging this as UBN. [14:30:28] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2069241 (10MGChecker) [14:30:30] 3Collaboration-Team-Current, 10Notifications: Show descriptions for the actions under the "..." menu on notifications - https://phabricator.wikimedia.org/T126738#2069240 (10MGChecker) 5Open>3stalled [18:03:55] (03CR) 10Siebrand: Add notifications for summary changes (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273231 (https://phabricator.wikimedia.org/T125119) (owner: 10Matthias Mullie) [18:12:03] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273560 (https://phabricator.wikimedia.org/T125970) (owner: 10Mooeypoo) [18:16:10] (03CR) 10Siebrand: Don't use a hard-coded array of thresholds but impute it (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273544 (owner: 10Jforrester) [18:22:03] (03CR) 10Siebrand: "I submitted https://gerrit.wikimedia.org/r/#/c/273585/ for this, and will soon submit patch for core and all other Gerrit extensions that " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273231 (https://phabricator.wikimedia.org/T125119) (owner: 10Matthias Mullie) [18:46:14] (03PS1) 10Siebrand: Remove double emphasis in string [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273588 [18:58:02] (03CR) 10Siebrand: Bold title in summary mention notification (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273232 (https://phabricator.wikimedia.org/T125427) (owner: 10Matthias Mullie) [19:03:24] (03PS1) 10Siebrand: Remove double emphasis in string [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273590 [19:07:36] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273414 (https://phabricator.wikimedia.org/T127693) (owner: 10Mattflaschen) [19:08:08] 3Collaboration-Team-Current, 10Notifications: Multiple "You just made your first edit, thank you and welcome!" notifications - https://phabricator.wikimedia.org/T128288#2069566 (10Elitre) [19:11:39] 3Collaboration-Team-Current, 10Notifications: Multiple "You just made your first edit, thank you and welcome!" notifications - https://phabricator.wikimedia.org/T128288#2069578 (10Luke081515) [19:11:41] 6Collaboration-Team-Backlog, 10Notifications: Editing Wikidata triggered multiple notification of hundredth edit - https://phabricator.wikimedia.org/T128249#2069579 (10Luke081515) [19:12:09] 6Collaboration-Team-Backlog, 10Notifications: Multible "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2068619 (10Luke081515) [19:12:26] 3Collaboration-Team-Current, 10Notifications: Multible "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2068619 (10Luke081515) [19:13:40] 3Collaboration-Team-Current, 10Notifications: Multiple "You made your edit!" notifications - https://phabricator.wikimedia.org/T128249#2069598 (10Elitre) [20:10:21] (03PS2) 10Siebrand: Remove double emphasis in string [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273590 [21:25:05] 6Collaboration-Team-Backlog, 10Flow: Following a diff link to a post you don't have access to triggers fatal error - https://phabricator.wikimedia.org/T94863#2069742 (10Aklapper) @EBernhardson: Could you please reply to @Mattflaschen's last comment? [21:31:57] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-LiquidThreads: Blank talk pages on Portuguese Wikibooks: Fatal exception of type MWUnknownContentModelException - https://phabricator.wikimedia.org/T128293#2069760 (10He7d3r) [21:32:30] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-LiquidThreads: Blank talk pages on Portuguese Wikibooks: Fatal exception of type MWUnknownContentModelException - https://phabricator.wikimedia.org/T128293#2069774 (10He7d3r) p:5Triage>3High [23:29:09] (03CR) 10Legoktm: [C: 032] Remove double emphasis in string [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273590 (owner: 10Siebrand) [23:40:39] (03Merged) 10jenkins-bot: Remove double emphasis in string [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273590 (owner: 10Siebrand)