[00:10:57] (03CR) 10Aaron Schulz: [C: 031] Fix board move DB issue using new hook TitleMoveStarting (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272665 (https://phabricator.wikimedia.org/T127785) (owner: 10Mattflaschen) [00:27:24] (03CR) 10Catrope: "Is replacing newlines necessary? 'body' is HTML, right? So shouldn't newlines be semantically equivalent to spaces already?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273284 (https://phabricator.wikimedia.org/T128062) (owner: 10Sbisson) [00:37:22] RoanKattouw, I just noticed this - https://phabricator.wikimedia.org/T126863 - I assume I should say "No, this request won't work, because the "Notifications" tab is added by the optional extension Echo, and might not be there in all MediaWiki installations" or something? [00:39:01] quiddity, James_F has talked about moving Echo to core. No imminent plans, though. [00:39:16] legoktm or anyone, have you seen: [00:39:18] I know. And this is the reverse of that! But not worth tangenting [00:39:30] Fatal error: Class already declared: MWEchoDbFactoryTest in /vagrant/mediawiki/extensions/Echo/tests/phpunit/includes/EchoDbFactoryTest.php on line 3 [00:39:38] eh, I'll just reply and decline it [00:39:41] I get it when I try to run all PHPUnit tests. [00:39:53] quiddity, if Echo were in core, the Notifications tab would be part of core, so it would be doable. [00:40:06] hhvm phpunit.php --exclude-group Broken,ParserFuzz,Stub,ParserTests [00:43:32] quiddity: Your instinct is correct, although we may be able to get Echo to move the preference, but that's kind of ugly [00:50:19] 6Collaboration-Team-Backlog, 10MediaWiki-Recent-changes, 10Notifications: Move setting "Email on watchlist changed" from tab "User profile" → "Notification" - https://phabricator.wikimedia.org/T126863#2065477 (10Quiddity) a:5Devirk>3None Hi. There is a problem with this feature request, because the "Noti... [00:51:02] 6Collaboration-Team-Backlog, 10MediaWiki-Recent-changes, 10Notifications: Move setting "Email on watchlist changed" from tab "User profile" → "Notification" - https://phabricator.wikimedia.org/T126863#2065486 (10Quiddity) [01:00:35] (03PS6) 10Mooeypoo: [wip] Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) [01:01:45] (03PS21) 10Mooeypoo: Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [01:01:59] (03PS7) 10Mooeypoo: [wip] Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) [01:02:05] Matt? [01:02:29] jmatazzoni__, hey [01:02:57] If it's after hours for you I can talk to someone else. [01:03:21] jmatazzoni__, it's not. [01:03:28] I'm looking here. https://meta.wikimedia.org/wiki/User:Krinkle/Tools/Real-Time_Recent_Changes How do I get this up and running on my account? [01:04:34] Do I have to install something, go to a certain page, what? [01:04:48] jmatazzoni__, I've never tried it yet, but I'm testing it now. I'll let you know when I get it so I can give you good instructions. [01:05:16] Or, if you're more familiar, I'd like to look at Huggle as well. [01:06:31] jmatazzoni__, no, haven't used Huggle either, but I just got RTRC working. [01:06:38] jmatazzoni__: In other news, https://twitter.com/legoktm/status/703021927221211136 [01:06:54] Go to https://en.wikipedia.org/wiki/User:JMatazzoni_%28WMF%29/common.js?action=edit and add the two lines from https://meta.wikimedia.org/wiki/User:Krinkle/Tools/Real-Time_Recent_Changes#Install [01:07:23] RoanKattouw, jmatazzoni__, RTRC loads the ORES from Labs too. :) [01:07:42] Oh, nice :) [01:07:47] jmatazzoni__, then after that's saved, clear your browser cache. Then go to https://en.wikipedia.org/wiki/Special:BlankPage/RTRC and click Apply. [01:07:59] Yeah at the time we talked to Timo, that had just been merged but wasn't working for him yet [01:08:20] RTRC is pretty sweet. I never actually used it before. [01:09:04] The ORES is not actually working for me yet (or if it is I'm not seeing it). I just know because it does a JS request to ores.wmflabs.org [01:10:13] Also, I got my PHP debugger (GEBEN) working better. [01:11:56] jmatazzoni__, any luck? [01:14:32] OK, I see the panel. Not sure just how this works yet. Will go and look at the documentation again. [01:14:40] Thanks Matt! [01:15:42] 6Collaboration-Team-Backlog, 10Notifications: Notification that is shown in special page but not in flyout - https://phabricator.wikimedia.org/T128148#2065511 (10Quiddity) [01:16:02] No problem. :) [01:16:46] jmatazzoni__, you have to click Apply to see anything, but there are also also knobs to fiddle with (you have to click Apply each time you change something I believe). [01:18:56] Got that, but not understanding how to review anything from the list. When I click on anything, i just go to that page--but lose the panel. [01:24:01] does enwiki allow use of the "patrolright"? If so, how do I apply? I tried looking it up on Meta but don't see any info... [01:24:31] jmatazzoni__, yes, enwiki has new page patrol. [01:25:33] quiddity, do you know how to apply for enwiki 'patrol' right? I'm looking now. [01:26:42] jmatazzoni__, okay, found it. You need to be auto-confirmed. [01:26:56] jmatazzoni__, you should do actual patrolling on your personal account probably, though this is kind of a borderline case. [01:29:08] But I would recommend you make a personal account. Then you can either make 10 edits or request permissions at https://en.wikipedia.org/wiki/Wikipedia:Requests_for_permissions/Confirmed , or maybe you could get someone on staff to give you 'confirmed'. [01:29:27] (03PS8) 10Mooeypoo: Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) [01:30:00] If you want to go the make 10 edits route, https://en.wikipedia.org/wiki/Category:Wikipedia_articles_needing_copy_edit an easy place to find articles that need spelling and grammar fixes. If you do the 10-edit approach you also need to wait 4 days. [01:30:19] Thanks Matt. I'll install on my personal account, which has more edits. Then see if I qualify there -- qhich is prob where I should do this stuff anyway. Stand by. [01:30:49] Have to step out now. Will pick up in the Am. [01:31:13] jmatazzoni__, oh, what's your personal account? [02:17:29] just jmatazzoni [02:38:28] Oh, okay. Yeah, that account can patrol. [06:36:01] (03PS1) 10Mattflaschen: Better error handling and hook use for moves [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273414 (https://phabricator.wikimedia.org/T127693) [06:36:24] (03PS2) 10Mattflaschen: Better error handling and hook use for moves [extensions/Flow] - 10https://gerrit.wikimedia.org/r/273414 (https://phabricator.wikimedia.org/T127693) [10:33:48] (03CR) 10Hashar: [C: 032] Cleanup Cucumber tags in Selenium tests [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/271780 (https://phabricator.wikimedia.org/T127423) (owner: 10Zfilipin) [10:34:46] (03Merged) 10jenkins-bot: Cleanup Cucumber tags in Selenium tests [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/271780 (https://phabricator.wikimedia.org/T127423) (owner: 10Zfilipin) [12:00:43] (03PS2) 10Sbisson: Force notification body on a single line [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273284 (https://phabricator.wikimedia.org/T128062) [12:01:28] (03CR) 10Sbisson: "Yes, updated, thanks." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273284 (https://phabricator.wikimedia.org/T128062) (owner: 10Sbisson) [13:49:26] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#2066471 (10SBisson) >>! In T121822#2065291, @jmatazzoni wrote: > Thanks for... [15:58:27] 3Collaboration-Team-Current, 10Notifications: Update enwiki customizations for page triage notification - https://phabricator.wikimedia.org/T126803#2066709 (10SBisson) 'review' vs. 'patrol' was discussed in T114415 a few months ago, if it can be of any help. [16:55:10] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#2066848 (10jmatazzoni) Thanks Stephane. Pau, my guess is that when you said... [17:10:31] (03CR) 10Catrope: [C: 032] Force notification body on a single line [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273284 (https://phabricator.wikimedia.org/T128062) (owner: 10Sbisson) [17:21:50] (03Merged) 10jenkins-bot: Force notification body on a single line [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273284 (https://phabricator.wikimedia.org/T128062) (owner: 10Sbisson) [17:30:01] (03CR) 10Mooeypoo: Include cross-wiki notifications in unread count (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) (owner: 10Sbisson) [18:17:50] (03PS6) 10Sbisson: Include cross-wiki notifications in unread count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) [18:17:58] (03CR) 10Sbisson: Include cross-wiki notifications in unread count (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) (owner: 10Sbisson) [18:27:21] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): DomainException on Special:Notifications on mediawiki.org - https://phabricator.wikimedia.org/T127728#2067017 (10jmatazzoni) 5Open>3Resolved [19:13:39] 3Collaboration-Team-Current, 10Notifications: Show descriptions for the actions under the "..." menu on notifications - https://phabricator.wikimedia.org/T126738#2067188 (10Catrope) [19:30:42] 3Collaboration-Team-Current, 10Notifications: 'Mark as read' dots menu is misaligned - https://phabricator.wikimedia.org/T126686#2067223 (10Catrope) [19:39:51] (03PS1) 10Catrope: Fix repeating background images [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/273506 (https://phabricator.wikimedia.org/T126311) [20:01:26] 3Collaboration-Team-Current, 10Notifications: Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2067272 (10Catrope) [20:09:48] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2067317 (10Catrope) [20:09:50] 6Collaboration-Team-Backlog, 10Notifications: Omit the user-talk namespace on notifications - https://phabricator.wikimedia.org/T125951#2067315 (10Catrope) 5Open>3Resolved This is what it looks like in master right now: {F3433528} So I think that addresses what's described in the task description. Treatm... [20:10:19] 3Collaboration-Team-Current, 10Notifications: Show descriptions as tooltips for actions outside the "..." menu on notifications - https://phabricator.wikimedia.org/T127424#2067319 (10Catrope) [20:10:45] 3Collaboration-Team-Current, 10Notifications: Cross-wiki bundles should appear after local unread notifications in the panel - https://phabricator.wikimedia.org/T127422#2067320 (10Catrope) [20:12:26] 6Collaboration-Team-Backlog, 10Notifications: Project labels inside the cross-wiki bundle should link to the target wiki Notification Page - https://phabricator.wikimedia.org/T127419#2043253 (10Catrope) I'm not sure linking to Special:Notifications is a good idea at this time, because going there still marks a... [20:12:33] 3Collaboration-Team-Current, 10Notifications: Project labels inside the cross-wiki bundle should link to the target wiki Notification Page - https://phabricator.wikimedia.org/T127419#2067332 (10Catrope) [20:20:10] (03CR) 10Catrope: [C: 031] "Looks good to me, but I don't know enough about what's going on to merge this. Maybe Matthias could look at this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272665 (https://phabricator.wikimedia.org/T127785) (owner: 10Mattflaschen) [20:20:34] matt_flaschen: Could you respond to Aaron's comment on that commit? ---^^ [20:23:02] RoanKattouw, yeah, I saw it, about to respond. [20:24:57] I've also emailed Matthias to ask him to review both of those move-related changes with the aim of getting them into the next wmf branch [20:25:32] (IRC says mlitn is not /away but since it's Friday night at 9:30pm I doubt that's true) [20:28:03] RoanKattouw, we should try to cherry-pick them on Monday. Even if there is the possibility if cache inconsistency (only if the commit rolls back after the Flow endAtomic, which probably also means after the move endAtomic, since they're the same place, that can be fixed with action=purge whereas right now it's totally broken. [20:32:13] (03CR) 10Jforrester: [C: 032] Fix repeating background images [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/273506 (https://phabricator.wikimedia.org/T126311) (owner: 10Catrope) [20:33:44] (03Merged) 10jenkins-bot: Fix repeating background images [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/273506 (https://phabricator.wikimedia.org/T126311) (owner: 10Catrope) [20:35:17] RoanKattouw, greg-g, I thought 14 wasn't going to move along the train this week. [20:35:56] Did I misunderstand SoS, or did they change their mind? [20:39:02] (03PS1) 10Bmansurov: Update mobile event logging code [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) [20:39:29] (03PS2) 10Bmansurov: Update mobile event logging code [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) [20:42:19] (03CR) 10Mattflaschen: "I don't have a great answer. Only solutions I can think of right now (in order of increasing drasticness):" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272665 (https://phabricator.wikimedia.org/T127785) (owner: 10Mattflaschen) [20:43:38] RoanKattouw, it's even more complicated than it seems because sometimes Flow uses two DB connections (flowdb and regular) and sometimes one. [20:43:55] matt_flaschen: My understanding was that wmf15 was gonna be cut on Tuesday [20:44:03] But maybe it changed? [20:44:31] (03CR) 10jenkins-bot: [V: 04-1] Update mobile event logging code [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) (owner: 10Bmansurov) [20:44:51] I could have sworn someone asked about backports to wmf14 in SoS, and then someone said, "well, you can, but it won't actually roll out to Wikipedias/somewhere til next week" or something like that. [20:46:39] (03CR) 10Mattflaschen: "We could have it only use begin/commit only for the flowdb case. We would need a hook change to be able to do commit right after the page" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272665 (https://phabricator.wikimedia.org/T127785) (owner: 10Mattflaschen) [20:54:36] 3Collaboration-Team-Current, 10MobileFrontend, 10Notifications, 7Mobile, 13Patch-For-Review: Use same OOUI widgets for notifications popup on mobile and desktop - https://phabricator.wikimedia.org/T124188#1948520 (10Mooeypoo) Please notice that in order to test this, you need to pull the patch for Mobile... [20:55:44] (03PS2) 10Mooeypoo: Transform the notification action bar to css table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272651 (https://phabricator.wikimedia.org/T125909) [20:55:56] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Action and timestamp position needs adjustment - https://phabricator.wikimedia.org/T125969#2067470 (10Mooeypoo) a:3Mooeypoo [20:56:08] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: 'Mark as read' dots menu is misaligned - https://phabricator.wikimedia.org/T126686#2067472 (10Mooeypoo) a:3Mooeypoo [20:56:24] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Rephrase Flow notifications, move content from body into header - https://phabricator.wikimedia.org/T121950#2067473 (10Etonkovidova) >Add 'userSpeechBubble' icon First screenshot: In the screenshot below, user... [20:57:47] (03PS3) 10Bmansurov: Update mobile event logging code [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) [21:03:38] (03CR) 10jenkins-bot: [V: 04-1] Update mobile event logging code [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) (owner: 10Bmansurov) [21:04:19] matt_flaschen: I thought this week wmf.14 was definitely going ahead. Certainly, it's live everywhere… [21:05:49] James_F, I know it is now. I'm saying that was not my understanding from SoS. But it's possible I misunderstood. [21:06:37] matt_flaschen: I didn't get to go to SoS this week, so I can't speak to that, sorry. :-) [21:11:08] (03PS1) 10Mooeypoo: Reorder x-wiki bundles to be after local notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273518 (https://phabricator.wikimedia.org/T127422) [21:11:13] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Cross-wiki bundles should appear after local unread notifications in the panel - https://phabricator.wikimedia.org/T127422#2067518 (10Mooeypoo) a:3Mooeypoo [21:14:30] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Email's footer should not be partially displayed in Email Notifications for short email messages - https://phabricator.wikimedia.org/T127098#2067541 (10Etonkovidova) Adding screenshots for the case wit... [21:25:26] (03PS4) 10Mattflaschen: Update mobile event logging code [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) (owner: 10Bmansurov) [21:25:41] (03CR) 10Mattflaschen: "I think it didn't work because you used Dependency instead of Depends-On." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) (owner: 10Bmansurov) [21:26:14] (03CR) 10Bmansurov: "Oh OK, thanks!" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) (owner: 10Bmansurov) [21:31:13] (03PS1) 10Catrope: ForeignNotifications::populate(): Fix max timestamp computation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273521 [21:31:57] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Rephrase Flow notifications, move content from body into header - https://phabricator.wikimedia.org/T121950#2067597 (10jmatazzoni) These look good with one exception. Re. [[ https://phab.wmfusercontent.org/file... [21:32:56] (03PS2) 10Catrope: ForeignNotifications::populate(): Fix max timestamp computation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273521 [21:34:08] (03CR) 10Mooeypoo: [C: 032] "Works!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273521 (owner: 10Catrope) [21:34:42] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Email's footer should not be partially displayed in Email Notifications for short email messages - https://phabricator.wikimedia.org/T127098#2067602 (10jmatazzoni) 5Open>3Resolved [21:39:18] RoanKattouw, http://stackoverflow.com/a/9548101/47773 is scary even for PHP (re your DateInterval patch). [21:39:50] 6Collaboration-Team-Backlog, 10Notifications, 7Epic, 7WorkType-NewFunctionality, 7user-notice: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#2067605 (10jmatazzoni) [21:39:53] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#2067604 (10jmatazzoni) 5Open>3Resolved [21:40:36] 6Collaboration-Team-Backlog, 10Flow: Creating new threads with existing comments - https://phabricator.wikimedia.org/T128215#2067607 (10tarlocesilion) [21:41:41] (03Merged) 10jenkins-bot: ForeignNotifications::populate(): Fix max timestamp computation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273521 (owner: 10Catrope) [21:42:35] matt_flaschen: What the .... [21:42:46] matt_flaschen: Yeah < and > don't work anyway because MWTimestamp is a wrapper object, not a native DateTime, but ... wow [21:43:54] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): cross-wiki notification[betalabs]: 'Mark as read' appears in ellipsis's menu for bundled notificaitons - https://phabricator.wikimedia.org/T125155#2067624 (10jmatazzoni) 5Open>3Resolved [21:47:14] 120 [21:47:14] Whoops, ww [21:49:37] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Rephrase Flow notifications, move content from body into header - https://phabricator.wikimedia.org/T121950#2067655 (10SBisson) >>! In T121950#2067597, @jmatazzoni wrote: > These look good with one exception. R... [21:50:28] RoanKattouw, however diff returns a native DateInterval, which the answer is actually about. [21:50:35] Or partly about. [21:51:07] Oh, this is < and > on DateIntervals? [21:51:08] Yeah that's a more meta comparison than I need [21:51:27] RoanKattouw, it would be better than the weird invert thing if it worked sanely on 0. [21:51:32] $dateDiff < 0 [21:51:45] Of course, isBefore would be better still. [21:55:06] Yeah isBefore/isAfter would be nice [22:11:09] (03PS2) 10Mooeypoo: Reorder x-wiki bundles to be after local notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273518 (https://phabricator.wikimedia.org/T127422) [22:16:48] 3Collaboration-Team-Current, 10Notifications: Adjust label layout inside cross-wiki notification bundles - https://phabricator.wikimedia.org/T128069#2067699 (10Mooeypoo) a:3Mooeypoo For the sake of consistency, and, more importantly, for the sake of Mobile (which might use different font size) I am using em'... [22:17:12] (03PS1) 10Catrope: MentionPresentationModel: Remove pageLink from secondary links [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273531 (https://phabricator.wikimedia.org/T125949) [22:17:36] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: For items with more than 2 actions, hide the rest under the "..." menu - https://phabricator.wikimedia.org/T125949#2001363 (10Catrope) The fact that mention notifications had three secondary links was a mistake. The attached patch removes the... [22:19:03] (03CR) 10Catrope: [C: 032] Reorder x-wiki bundles to be after local notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273518 (https://phabricator.wikimedia.org/T127422) (owner: 10Mooeypoo) [22:23:05] 3Collaboration-Team-Current, 10Flow, 10Notifications: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#2067748 (10Catrope) [22:27:38] (03PS1) 10Mooeypoo: Adjust group bundle stules [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273533 (https://phabricator.wikimedia.org/T128069) [22:29:40] (03Merged) 10jenkins-bot: Reorder x-wiki bundles to be after local notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273518 (https://phabricator.wikimedia.org/T127422) (owner: 10Mooeypoo) [22:35:58] (03CR) 10Aaron Schulz: [C: 032] "This should fix the large known problem now. Unikely-to-occur matters can be fixed later patches." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272665 (https://phabricator.wikimedia.org/T127785) (owner: 10Mattflaschen) [22:40:30] 6Collaboration-Team-Backlog, 10Flow: Improve how transactions work for board moves - https://phabricator.wikimedia.org/T128228#2067926 (10Mattflaschen) [22:40:53] 3Collaboration-Team-Current, 10Flow, 7Availability: Use WAN cache delete() and slave populations to avoid merge() - https://phabricator.wikimedia.org/T120009#2067929 (10Mattflaschen) [22:40:56] 6Collaboration-Team-Backlog, 10Flow: Improve how transactions work for board moves - https://phabricator.wikimedia.org/T128228#2067928 (10Mattflaschen) [22:41:02] 6Collaboration-Team-Backlog, 10Flow: Improve how transactions work for board moves - https://phabricator.wikimedia.org/T128228#2067910 (10Mattflaschen) [22:41:52] (03CR) 10Mattflaschen: "Follow up is T128228" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272665 (https://phabricator.wikimedia.org/T127785) (owner: 10Mattflaschen) [22:45:47] (03Merged) 10jenkins-bot: Fix board move DB issue using new hook TitleMoveStarting [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272665 (https://phabricator.wikimedia.org/T127785) (owner: 10Mattflaschen) [22:50:31] (03PS1) 10Mattflaschen: Fix board move DB issue using new hook TitleMoveStarting [extensions/Flow] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/273536 (https://phabricator.wikimedia.org/T127785) [22:56:37] quiddity, scheduled the first board move fix for morning SWAT on Monday. If the troubleshooting patch is merged, we can SWAT it out then if there are still slots. [23:01:48] (03CR) 10Mattflaschen: [C: 04-1] "I saw an empty scheme error. Figuring it out now." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) (owner: 10Bmansurov) [23:09:00] matt_flaschen, sounds good. Also, I'm out for the rest of today. Plumbing leak from my kitchen sink is showering the apt below. Lots of fun cleanup. [23:09:42] quiddity, oh, jeez. That sucks. [23:09:56] quiddity: the way you said showering, it sounded like a good thing for a second [23:15:25] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 3 others: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365 - https://phabricator.wikimedia.org/T128231#2068016 (10ssastry) [23:16:08] 3Collaboration-Team-Current, 10Notifications: Items in the more actions menu of notifications are inconsistent - https://phabricator.wikimedia.org/T126734#2068034 (10Mooeypoo) @Pginer-WMF: I've adjusted the pixels to ems with the help of mathematical-css-savant @Catrope. The numerical pixels (when inspected in... [23:17:28] (03PS1) 10Mooeypoo: Adjust styling of the 'more actions' menu items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273541 (https://phabricator.wikimedia.org/T126734) [23:17:47] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Items in the more actions menu of notifications are inconsistent - https://phabricator.wikimedia.org/T126734#2068040 (10Mooeypoo) a:3Mooeypoo [23:21:33] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Items in the more actions menu of notifications are inconsistent - https://phabricator.wikimedia.org/T126734#2068046 (10Mooeypoo) >>! In T126734#2068034, @Mooeypoo wrote: > One question that came up, though, is what to do with the hover effect... [23:21:42] (03PS2) 10Mooeypoo: Adjust styling of the 'more actions' menu items [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273541 (https://phabricator.wikimedia.org/T126734) [23:21:48] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Adjust hover state for actions in the more menu ("...") of notifications - https://phabricator.wikimedia.org/T126740#2068052 (10Mooeypoo) a:3Mooeypoo [23:23:56] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Rephrase Flow notifications, move content from body into header - https://phabricator.wikimedia.org/T121950#2068058 (10jmatazzoni) Stephane asks: > flowusertalk-new-topic is not a separate notification type... [23:29:28] (03CR) 10Mattflaschen: [C: 032] "Never mind, it was a local problem, this patch is fine." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/273514 (https://phabricator.wikimedia.org/T122504) (owner: 10Bmansurov) [23:32:11] 6Collaboration-Team-Backlog, 10Flow: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365 - https://phabricator.wikimedia.org/T128236#2068154 (10ssastry) [23:37:36] 6Collaboration-Team-Backlog, 10Flow: Flow: Add Accept: header to your HTML requests to RESTBase/Parsoid as per T124365 - https://phabricator.wikimedia.org/T128236#2068260 (10ssastry) [23:54:47] (03PS1) 10Jforrester: Provide three more edit threshold congratulatory notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273543 [23:54:49] (03PS1) 10Jforrester: Don't use a hard-coded array of thresholds but impute it [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273544 [23:55:09] RoanKattouw: ^^^ I live to make people happy. [23:59:16] (03CR) 10Catrope: [C: 032] Provide three more edit threshold congratulatory notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273543 (owner: 10Jforrester)