[01:25:17] (03CR) 10Catrope: [C: 032] Echo API returns absolute URLs in notification links [extensions/Echo] (wmf/1.27.0-wmf.13) - 10https://gerrit.wikimedia.org/r/272780 (https://phabricator.wikimedia.org/T125738) (owner: 10Catrope) [01:25:22] (03CR) 10Catrope: [C: 032] Echo API returns absolute URLs in notification links [extensions/Echo] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/272781 (https://phabricator.wikimedia.org/T125738) (owner: 10Catrope) [01:25:56] 3Collaboration-Team-Current, 10Flow: Convert LQT to Flow on remaining wikis - https://phabricator.wikimedia.org/T127575#2047323 (10Mattflaschen) I assume Wikinews is excluded per our discussion and since it's not listed. [01:26:28] 3Collaboration-Team-Current, 10Flow: Convert LQT to Flow on remaining wikis - https://phabricator.wikimedia.org/T127575#2058488 (10Catrope) >>! In T127575#2058486, @Mattflaschen wrote: > I assume Wikinews is excluded per our discussion and since it's not listed. That's right. [01:27:17] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Email's footer should not be partially displayed in Email Notifications for short email messages - https://phabricator.wikimedia.org/T127098#2058503 (10Mattflaschen) [01:33:16] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests, 13Patch-For-Review, 7user-notice: Override Echo system notification icons for all Wikimedia projects - https://phabricator.wikimedia.org/T49662#2058537 (10Jdforrester-WMF) 5Open>3Resolved [01:33:52] (03Merged) 10jenkins-bot: Echo API returns absolute URLs in notification links [extensions/Echo] (wmf/1.27.0-wmf.13) - 10https://gerrit.wikimedia.org/r/272780 (https://phabricator.wikimedia.org/T125738) (owner: 10Catrope) [01:33:55] (03Merged) 10jenkins-bot: Echo API returns absolute URLs in notification links [extensions/Echo] (wmf/1.27.0-wmf.14) - 10https://gerrit.wikimedia.org/r/272781 (https://phabricator.wikimedia.org/T125738) (owner: 10Catrope) [01:40:09] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: Email's footer should not be partially displayed in Email Notifications for short email messages - https://phabricator.wikimedia.org/T127098#2058560 (10jmatazzoni) Thanks for he change of title @Mattflaschen. I thought this was a new feature b... [01:50:05] 3Collaboration-Team-Current, 10Beta-Cluster-Infrastructure, 10DBA, 10Staging: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2058573 (10demon) >>! In T95871#2047217, @greg wrote: > Adding Chad for their help/expertise. So I'm not exactly sure what's needed here from me :) I... [02:01:58] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-02-09_(1.27.0-wmf.13), 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Generate flow-mention for create/edit of board desc, topic, post, summary - https://phabricator.wikimedia.org/T125427#2058583 (10jmatazzoni) Thanks Elena. Yes, the mess... [02:03:57] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Mentions in board description and topic summary don't generate flow-mention notifications - https://phabricator.wikimedia.org/T125120#1978916 (10jmatazzoni) This is a duplicate of T125427 I think. Closing this. [02:04:19] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Mentions in board description and topic summary don't generate flow-mention notifications - https://phabricator.wikimedia.org/T125120#2058588 (10jmatazzoni) 5Open>3Resolved [02:44:56] 3Collaboration-Team-Current, 10Beta-Cluster-Infrastructure, 10DBA, 10Staging: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2058642 (10Mattflaschen) Talked to @demon a bit about this. >>! In T95871#2047174, @Mattflaschen wrote: > make-all-blobs blobs1 If no one o... [03:00:44] 3Collaboration-Team-Current, 10Beta-Cluster-Infrastructure, 10DBA: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2058648 (10Mattflaschen) The config change will first be done for one Beta wiki, then if that goes fine I'll do the rest. [03:16:18] 3Collaboration-Team-Current, 10Beta-Cluster-Infrastructure, 10DBA: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#2058661 (10demon) Yep, that about summarizes it. Ping me on IRC when you wanna do this so you can have a second set of hands :) [03:57:39] (03CR) 10Catrope: Remove footer from email notification excerpt (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272836 (https://phabricator.wikimedia.org/T127098) (owner: 10Sbisson) [04:47:19] Heading out, have a good night. [05:13:22] (03PS1) 10Catrope: Bidi-isolate secondary link labels and notification bodies [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272934 (https://phabricator.wikimedia.org/T127407) [05:13:41] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: User names in notifications should be bidi-isolated - https://phabricator.wikimedia.org/T127407#2042930 (10Catrope) a:3Catrope [05:23:29] (03PS1) 10Catrope: Wrap $1 (user name) in {{bidi:}} in notification-header-* messages. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/272935 (https://phabricator.wikimedia.org/T127407) [05:23:48] (03CR) 10jenkins-bot: [V: 04-1] Wrap $1 (user name) in {{bidi:}} in notification-header-* messages. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/272935 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [05:24:25] (03CR) 10Catrope: "Are automated changes to all *.json files like this OK, or is there a different way I should be doing this?" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/272935 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [05:27:40] (03PS2) 10Catrope: Wrap $1 (user name) in {{bidi:}} in notification-header-* messages. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/272935 (https://phabricator.wikimedia.org/T127407) [05:29:45] (03PS3) 10Catrope: Wrap $1 (user name) in {{bidi:}} in notification-header-* messages. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/272935 (https://phabricator.wikimedia.org/T127407) [05:32:52] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: User names in notifications should be bidi-isolated - https://phabricator.wikimedia.org/T127407#2058747 (10Catrope) https://gerrit.wikimedia.org/r/272934 takes care of bidi-isolation in the interface. We still have to do bidi-isolation of user... [05:45:59] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: User names in notifications should be bidi-isolated - https://phabricator.wikimedia.org/T127407#2058757 (10Catrope) To test 272934: - Create a user called `Bob (WMF)` - While logged in as `Bob (WMF)`, edit `User talk:Alice` (replace `Alice` wi... [07:26:53] (03CR) 10Nikerabbit: "Did you consider doing this in a way similar to LogFormatter? There is one parameter for the plain username to be used in GENDER. And ther" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/272935 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [08:27:35] (03PS1) 10Matthias Mullie: Don't process null edits (or other warnings in article save process) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272940 (https://phabricator.wikimedia.org/T123843) [09:18:39] 6Collaboration-Team-Backlog, 10Notifications, 7WorkType-NewFunctionality: Clarify read/unread status for notifications - https://phabricator.wikimedia.org/T126214#2058938 (10Pginer-WMF) I agree with what @Volker_E and @jmatazzoni say: the checkmark represents that you are done with the item (which goes beyon... [09:34:41] 6Collaboration-Team-Backlog, 10Notifications, 7Design, 7Easy: Notification icons are not ready for high-density displays (use SVG instead of PNG where supported) - https://phabricator.wikimedia.org/T55875#2058979 (10Pginer-WMF) >>! In T55875#2056910, @Volker_E wrote: > @Pginer-WMF How much true is this sti... [10:05:55] (03PS4) 10Matthias Mullie: Add secondary links for edited topic/post on user talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272730 (https://phabricator.wikimedia.org/T121663) [11:10:08] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#2059159 (10Pginer-WMF) Along the lines of the designs captured in T115316, I'd recommend having one action to mark as r... [11:14:50] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#2059182 (10Pginer-WMF) [11:48:59] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272730 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [12:06:44] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 3Liaisons-February-2016, and 2 others: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2059261 (10Trizek-WMF) Good point. I should define a schedule :D [12:37:11] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#2059323 (10Pginer-WMF) [12:48:43] (03PS2) 10Sbisson: Remove footer from email notification excerpt [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272836 (https://phabricator.wikimedia.org/T127098) [12:57:09] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#1726587 (10TheDJ) >>! In T115528#2059159, @Pginer-WMF wrote: > While a single "mark all as read" action can be more eff... [13:14:46] (03CR) 10Siebrand: [C: 04-1] "Please do this in code. This doesn't add anything translators should be able to localise." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/272935 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [13:24:08] (03PS5) 10Sbisson: Include cross-wiki notifications in unread count [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) [13:30:38] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 7Regression: Board moves in Flow not working - https://phabricator.wikimedia.org/T127785#2059536 (10matthiasmullie) A TitleMoveStarting hook after the startAtomic seems same and the rest of that patch also looks good. I'm sure I'm overlooking someth... [13:33:56] 3Collaboration-Team-Current, 10Flow, 10Notifications: Should get notified for topic summary change on your own user talk - https://phabricator.wikimedia.org/T125119#2059538 (10matthiasmullie) a:3matthiasmullie [13:42:43] 6Collaboration-Team-Backlog, 10Notifications: Measure how often the "mark all as read" action is used in the Notification Panel - https://phabricator.wikimedia.org/T127955#2059562 (10Pginer-WMF) [13:50:16] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#2059597 (10Pginer-WMF) Thanks @TheDJ for providing details on your usual workflows. At a smaller scale, it would be gr... [14:36:09] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272308 (https://phabricator.wikimedia.org/T127311) (owner: 10Haritha28) [15:22:26] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#2059988 (10TheDJ) > The problem is what to do when you want to keep some item for later which requires follow-up. For... [16:02:41] 6Collaboration-Team-Backlog, 10Notifications: Echo notifications for user permissions should point to the log - https://phabricator.wikimedia.org/T67673#2060127 (10matej_suchanek) [16:02:43] 3Collaboration-Team-Current, 10Notifications: User-right notifications - provide log access - https://phabricator.wikimedia.org/T127249#2060128 (10matej_suchanek) [16:15:23] 3Collaboration-Team-Current, 10Notifications: User-right notifications - provide log access - https://phabricator.wikimedia.org/T127249#2060200 (10SBisson) 'Learn more' is already the label for the primary action (visible on Special:Notifications and email). Can we think of another label for the Log link (or t... [16:36:56] (03PS1) 10Sbisson: [WIP] Add 'Log' link to user-rights notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272997 (https://phabricator.wikimedia.org/T127249) [16:43:01] (03PS1) 10Sbisson: Handle null user when trying to generate a link for notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272998 (https://phabricator.wikimedia.org/T127728) [16:43:13] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: DomainException on Special:Notifications on mediawiki.org - https://phabricator.wikimedia.org/T127728#2060328 (10SBisson) a:3SBisson [16:46:33] 3Collaboration-Team-Current, 10Notifications: [betalabs] cross-wiki notification: Alerts - cannot mark as read - https://phabricator.wikimedia.org/T124222#2060336 (10SBisson) a:3SBisson [17:27:53] 3Collaboration-Team-Current, 10Notifications: [betalabs] cross-wiki notification: Alerts - cannot mark as read - https://phabricator.wikimedia.org/T124222#2060603 (10SBisson) @Etonkovidova Can you confirm this is still an issue? I cannot reproduce it locally. [17:31:29] (03PS3) 10Mattflaschen: Use msg() from context rather than wfMessage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/190415 [17:32:07] (03CR) 10Mattflaschen: "This is very old, but I just rebased and retested it and it should be ready for review." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/190415 (owner: 10Mattflaschen) [17:58:42] stephanebisson: is the fix in https://phabricator.wikimedia.org/T125738 in production? [18:00:29] etonkovidova: it should have been deployed yesterday by RoanKattouw_away or matt_flaschen [18:01:47] 3Collaboration-Team-Current, 10Notifications, 13Patch-For-Review: User-right notifications - provide log access - https://phabricator.wikimedia.org/T127249#2060709 (10jmatazzoni) > 'Learn more' is already the label for the primary action Arghhh. Sorry. Thanks Stephane. In that case, I can't think of anythi... [18:03:13] etonkovidova, yes, RoanKattouw_away did. [18:04:25] matt_flaschen: stephanebisson : thanks! I was checking it in the right place then :) [18:05:58] Could someone review and merge https://gerrit.wikimedia.org/r/#/c/265904/ and https://gerrit.wikimedia.org/r/#/c/265882/ together ? [18:06:02] I'll be back in a few minutes. [18:15:01] 3Collaboration-Team-Current, 10Thanks, 10Notifications, 13Patch-For-Review: Cross-wiki notifications: Links for thanks notifications point to the local wiki - https://phabricator.wikimedia.org/T125738#2060762 (10Etonkovidova) Checked Mention and Thanks for cross wiki notifications on testwiki, fr.wiki, he... [18:23:50] (03PS2) 10Sbisson: Add 'Log' link to user-rights notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272997 (https://phabricator.wikimedia.org/T127249) [19:01:41] 3Collaboration-Team-Current: Check that Collaboration team projects don't use session state in load.php - https://phabricator.wikimedia.org/T128005#2060929 (10Mattflaschen) [19:03:07] ^ Main take away from Scrum of Scrums. Getting lunch. [19:06:28] (03CR) 10Mooeypoo: [C: 04-1] "Overall the strategy seems okay to me. Just a couple of comments about specifics -- and some that we might want to add as a //TODO comment" (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) (owner: 10Sbisson) [19:07:03] (03CR) 10Catrope: [C: 032] Use msg() from context rather than wfMessage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/190415 (owner: 10Mattflaschen) [19:07:25] stephanebisson, not sure if I missedthe bot announcement or something, but I added comments on https://gerrit.wikimedia.org/r/#/c/271690/ [19:07:34] and I need to reboot apparently.. my computer is having problems updating itself :\ be back in a bit [19:23:42] (03Merged) 10jenkins-bot: Use msg() from context rather than wfMessage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/190415 (owner: 10Mattflaschen) [19:39:34] 6Collaboration-Team-Backlog, 10Parsoid, 10VisualEditor, 7Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#1437960 (10Whatamidoing-WMF) Here's an example of what one editor is doing manually, to get a visual diff: https://en.wikipedia.org/w/index.php?title=User:Anthonyhc... [19:48:34] (03CR) 10Catrope: [C: 032] Add secondary links for edited topic/post on user talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272730 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [19:57:43] (03CR) 10Catrope: Include cross-wiki notifications in unread count (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) (owner: 10Sbisson) [20:01:28] (03CR) 10Catrope: [C: 032] Add 'Log' link to user-rights notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272997 (https://phabricator.wikimedia.org/T127249) (owner: 10Sbisson) [20:04:19] (03CR) 10jenkins-bot: [V: 04-1] Add secondary links for edited topic/post on user talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272730 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [20:12:18] (03CR) 10Sbisson: "Thanks for reviewing!" (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/271690 (https://phabricator.wikimedia.org/T124109) (owner: 10Sbisson) [20:13:11] (03Merged) 10jenkins-bot: Add 'Log' link to user-rights notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272997 (https://phabricator.wikimedia.org/T127249) (owner: 10Sbisson) [20:14:15] (03CR) 10Catrope: "legoktm independently suggested the same thing as you guys did. $1 is already the formatter username as well (the username for GENDER is $" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/272935 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [20:14:50] (03Abandoned) 10Catrope: Wrap $1 (user name) in {{bidi:}} in notification-header-* messages. [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/272935 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [20:32:48] 6Collaboration-Team-Backlog: default VE makes board description blink when opening for Edit - https://phabricator.wikimedia.org/T128013#2061343 (10Etonkovidova) [20:40:27] 6Collaboration-Team-Backlog: default VE makes board description/post blink when opening for Edit - https://phabricator.wikimedia.org/T128013#2061397 (10Etonkovidova) [20:55:32] stephanebisson, was it a bug that caused the agent to be null for edit-thank? [20:55:35] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 7user-notice: Create new notification type for when a board description changes - https://phabricator.wikimedia.org/T125429#1987306 (10Etonkovidova) All specs seems to be in place - checked in betalabs. - s... [20:56:27] matt_flaschen: I don't know of anything that would cause it to be null [20:56:43] matt_flaschen: and I don't know how/where to investigate it [20:57:56] stephanebisson, I'll do a query. [20:58:09] matt_flaschen: can a user be deleted? [20:58:39] I mean, really deleted, so that User::newFromId returns null? [20:58:42] stephanebisson, I don't think so. They can be renamed, and the username can be hidden. [20:59:35] There are weird cases where there may be no user ID or IP, e.g. mass imports. [21:07:14] 6Collaboration-Team-Backlog: [betalabs] "Thank action failed" message - https://phabricator.wikimedia.org/T128020#2061520 (10Etonkovidova) [21:07:28] stephanebisson, there's 12 cases of edit-thank totally null on mediawikiwiki (maybe mass import, maybe a bug), but also 3997 page-linked (not sure cause). [21:07:32] Didn't check the other wikis. [21:07:40] Also, my update for before standup: [21:09:36] Talked to Chad about External Store on Beta. Going to move forward soon after giving a little longer for feedback. [21:09:38] Caught up on email and updated some very old patches that were still valid: [21:09:39] * Flow i18n (content language) [21:09:41] * Looked at the patches to extend login expiration when you choose 'remember me'. Too much has changed due to SessionManager, so I abandoned these and updated the task. [21:09:42] * Put up a pywikibot script. [21:11:51] (03CR) 10Mattflaschen: [C: 032] Handle null user when trying to generate a link for notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272998 (https://phabricator.wikimedia.org/T127728) (owner: 10Sbisson) [21:20:28] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 7RTL: User names in notifications should be bidi-isolated - https://phabricator.wikimedia.org/T127407#2061583 (10Legoktm) [21:21:06] RoanKattouw_away: did you already work on a patch for the bidi-stuff in presentation models or can I take a stab at it? [21:25:18] (03CR) 10Catrope: [C: 032] Remove footer from email notification excerpt [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272836 (https://phabricator.wikimedia.org/T127098) (owner: 10Sbisson) [21:26:57] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7Easy: Page Curation: User talk messages regarding A10 speedy tags do not correctly include the name of the duplicated article - https://phabricator.wikimedia.org/T128024#2061616 (10Swpb) [21:27:08] (03CR) 10Catrope: [C: 032] Don't process null edits (or other warnings in article save process) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272940 (https://phabricator.wikimedia.org/T123843) (owner: 10Matthias Mullie) [21:27:28] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7Easy: Page Curation: User talk messages regarding A10 speedy tags do not correctly include the name of the duplicated article - https://phabricator.wikimedia.org/T128024#2061649 (10Swpb) [21:29:29] (03Merged) 10jenkins-bot: Handle null user when trying to generate a link for notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272998 (https://phabricator.wikimedia.org/T127728) (owner: 10Sbisson) [21:32:42] (03CR) 10Catrope: [C: 032] Notification: use speechBubbles icon for all talk pages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272700 (https://phabricator.wikimedia.org/T56433) (owner: 10Sbisson) [21:35:43] (03PS1) 10Catrope: Bidi-embed formatter user names (the $1 parameter) in notification messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/273113 (https://phabricator.wikimedia.org/T127407) [21:36:00] (03Merged) 10jenkins-bot: Remove footer from email notification excerpt [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272836 (https://phabricator.wikimedia.org/T127098) (owner: 10Sbisson) [21:36:11] (03CR) 10Catrope: "New change: https://gerrit.wikimedia.org/r/273113" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/272935 (https://phabricator.wikimedia.org/T127407) (owner: 10Catrope) [21:37:28] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 7RTL: User names in notifications should be bidi-isolated - https://phabricator.wikimedia.org/T127407#2061692 (10Catrope) >>! In T127407#2058757, @Catrope wrote: > To test 272935: These same things are now fixed by 273113 instead.... [21:39:39] (03Merged) 10jenkins-bot: Don't process null edits (or other warnings in article save process) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/272940 (https://phabricator.wikimedia.org/T123843) (owner: 10Matthias Mullie) [21:43:03] (03CR) 10Catrope: [C: 032] Add secondary links for edited topic/post on user talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272730 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [21:54:54] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 7user-notice: Create new notification type for when a board description changes - https://phabricator.wikimedia.org/T125429#2061716 (10jmatazzoni) Hi @Etonkovidova, looks good but I'm noticing what looks like... [21:57:46] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15), 7user-notice: Create new notification type for when a board description changes - https://phabricator.wikimedia.org/T125429#2061722 (10Etonkovidova) @jmatazzoni - It's just a template {{CURRENTTIME}} which is... [22:00:21] legoktm: Sorry, didn't see your comment before. I just wrote https://gerrit.wikimedia.org/r/273113 [22:00:37] no worries, I'll review that :) [22:00:46] s/comment/question [22:01:00] 3Collaboration-Team-Current, 10Flow, 10DBA, 7Blocked-on-schema-change, and 2 others: ref_target should be NOT NULL - https://phabricator.wikimedia.org/T122111#2061727 (10Mattflaschen) [22:01:04] There are a few other things that need this applied to them too, such as topic titles. Maybe page titles as well [22:01:12] (03Merged) 10jenkins-bot: Add secondary links for edited topic/post on user talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/272730 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [22:01:21] But those will take more time to track down, so I decided to start with user names which is the biggest problem [22:01:25] and easiest to fix centrally [22:03:02] 3Collaboration-Team-Current, 10Flow, 10DBA, 7Blocked-on-schema-change, and 2 others: ref_target should be NOT NULL - https://phabricator.wikimedia.org/T122111#2061729 (10Mattflaschen) [22:03:22] 3Collaboration-Team-Current, 10Flow, 10DBA, 7Blocked-on-schema-change, and 2 others: ref_target should be NOT NULL - https://phabricator.wikimedia.org/T122111#1896903 (10Mattflaschen) @jcrespo Should I create a separate task for this, or does this one work? It's ready to run. [22:10:54] 3Collaboration-Team-Current, 10Notifications: Update enwiki customizations for page triage notification - https://phabricator.wikimedia.org/T126803#2061739 (10Mattflaschen) >>! In T126803#2039293, @SBisson wrote: > Given that enwiki is the only user of PageTriage, should we use 'patrol' instead of 'review' and... [22:14:19] bd808, have time to look at a really brief (2 line) MediaWiki-Vagrant patch? https://gerrit.wikimedia.org/r/#/c/271544/ [22:17:13] matt_flaschen: +2'd [22:17:39] matt_flaschen: also, don't be afraid or ashamed to self +2 fixes like that [22:26:55] bd808, alright, I'll try, if I can untrain myself. ;) [22:27:10] bd808, thnks. [22:27:12] yw [22:27:34] matt_flaschen: and thanks for taking such an interest in mw-vagrant [22:29:31] bd808, no problem, thanks for all your help. I have a few more if you have time (ignore the WIP). [22:29:46] bd808, anything I can review for you, core maybe? [22:30:13] https://gerrit.wikimedia.org/r/#/q/project:mediawiki/vagrant+owner:mattflaschen+status:open,n,z [22:30:51] I'm only waiting on review for some esoteric things right now. kafka avro log schemas and such [22:47:10] matt_flaschen, I remember you told me something about this, but I can't remember what it was. Do you know what to do if I'm getting a "500 hphp_invoke" error in an API request? so.. api.php seems to return this? [22:48:23] ha, forget it, I see the issue (uncaught error) [22:49:33] (03PS20) 10Mooeypoo: Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [22:50:42] mooeypoo, okay, good, 'cause my answer was going to be, "I did?" [22:51:45] haha [22:52:01] matt_flaschen, I attribute all knowledge to you whether it is correctly attributed or not. [22:52:05] And I always blame RoanKattouw [22:52:15] it is the Natural Order of Things. [22:52:15] mooeypoo: HTTP 500 almost always means a PHP fatal [22:52:43] yeah, it was... I've updated Flow (where it seemed to come from) but it seems to still fail, so I'm rebasing the Echo side of this commit and hoping that'll do it [22:53:05] LMAO [22:53:13] You may have it backwards. [22:53:45] (03PS4) 10Mooeypoo: Add MobileNotificationsWrapper for Mobile display [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (https://phabricator.wikimedia.org/T124188) [22:53:48] mooeypoo, I did give you knowledge for this scenario, though. Zend. :) [22:53:56] Often gives better error messages. [22:53:56] Ah! that's what I remembered [22:54:03] See? I wasn't that far off attributing knowledge to you [22:54:22] Yeah I see a decent error message, but I am now trying to fix it [23:18:53] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 7Regression: Board moves in Flow not working - https://phabricator.wikimedia.org/T127785#2061914 (10Mattflaschen) Because there is an attempt to commit the Flow transaction with 'flush' before TitleMoveComplete gets to run. That attempt now triggers... [23:25:19] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 7Regression: Board moves in Flow not working - https://phabricator.wikimedia.org/T127785#2061918 (10Mattflaschen) I updated the docs re this 'flush' change in https://gerrit.wikimedia.org/r/#/c/273133/ . [23:28:04] 3Collaboration-Team-Current, 10Flow, 13Patch-For-Review, 7Regression: Board moves in Flow not working - https://phabricator.wikimedia.org/T127785#2061923 (10Mattflaschen) [23:28:05] 3Collaboration-Team-Current, 10Flow: "Create Flow boards in any location" permission lost on zh.wp - https://phabricator.wikimedia.org/T127693#2061922 (10Mattflaschen) [23:28:52] 3Collaboration-Team-Current, 10Flow: Flow board move fails on zh.wp - https://phabricator.wikimedia.org/T127693#2050743 (10Mattflaschen) [23:30:35] 3Collaboration-Team-Current, 10Flow: Flow board move requiring allowCreation fails on zh.wp - https://phabricator.wikimedia.org/T127693#2061927 (10Mattflaschen) [23:48:53] 3Collaboration-Team-Current, 10Flow: Problems encountered when enabling Flow on Chinese Wikipedia - https://phabricator.wikimedia.org/T118567#2061972 (10Mattflaschen) But we need to fix {T127693} and {T127785}, which may be relevant. [23:52:23] aaaa... matt_flaschen I'm getting SSL errors trying to connect to the x-wiki in vagrant when I try to login... "An error occurred during a connection to he.wiki.local.wmftest.net:8080. SSL received a record that exceeded the maximum permissible length. (Error code: ssl_error_rx_record_too_long) " [23:54:39] mooeypoo, make sure you specify https:// and port 4430 in the URL, and make sure your MWV includes https://gerrit.wikimedia.org/r/271733 (it's merged now, but you may need to pull and/or provision). [23:54:55] mooeypoo, if you don't want to deal with it, disable https role. I already did (but I'm still using it until I re-provision). [23:55:37] matt_flaschen, https isn't enabled [23:56:08] mooeypoo, you probably have https in the URL, though. [23:56:22] Make sure protocol is http if port is 8080 or you don't have https role. [23:56:26] Got to go to dinner in a minute. [23:56:38] meh it gives me https when I click "login" [23:56:49] even though that role isn't enabled [23:56:50] mooeypoo, hmm, did you test https role before? [23:56:54] Clear all your cookies if so. [23:57:02] not that I remember? [23:57:31] mooeypoo, do you have forceHTTPS cookie set? [23:57:38] not sure how to check [23:57:59] firefox is the bigger issue. I change 'https://...' to 'http://...' and it reverts it to https [23:58:10] mooeypoo, I use CookiesManager+, but you can also check in Firefox. [23:58:15] mooeypoo, it's probably the cookie, not Firefox. [23:58:36] mooeypoo, about:preferences#privacy then 'remove individual cookies' (it also has search). [23:59:14] I do have forceHTTPS [23:59:18] where the hell did that come from [23:59:23] https role is not enabled [23:59:42] mooeypoo, check value of wgSecureLogin in hhvmsh. [23:59:43] 3Collaboration-Team-Current, 10Notifications, 7I18n, 13Patch-For-Review, 5WMF-deploy-2016-03-01_(1.27.0-wmf.15): Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1902666 (10Etonkovidova) Currently, betalabs displays wiki names in English only - se...