[00:18:11] 3Collaboration-Team-Current, 10Flow: Error in Flow page move - https://phabricator.wikimedia.org/T126701#2024651 (10Mattflaschen) @Quiddity and I decided to defer this to Tuesday. I've been using variants of: ``` $username = 'Roan Kattouw (WMF)'; $user = User::newFromName( $username ); // Get move token $mo... [00:21:46] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth, 5Patch-For-Review: localnames is not up to date because migratePass0 does not run - https://phabricator.wikimedia.org/T126480#2024664 (10Mattflaschen) a:3Mattflaschen [00:21:59] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 10MediaWiki-extensions-CentralAuth, 5Patch-For-Review: Not all wikis are attached to the global username - https://phabricator.wikimedia.org/T126484#2024665 (10Mattflaschen) a:3Mattflaschen [00:23:57] 6Collaboration-Team-Backlog, 10Notifications, 7Browser-Support-Firefox, 5Patch-For-Review: Formatting of footer in Echo notification drop-downs is messed up in Firefox - https://phabricator.wikimedia.org/T115052#2024687 (10Catrope) 5Open>3Resolved a:3Catrope AFAICT this is fixed now [00:24:10] 6Collaboration-Team-Backlog, 10Flow, 5Patch-For-Review: Add a README - https://phabricator.wikimedia.org/T65125#2024700 (10Catrope) 5Open>3Resolved a:3Catrope [00:26:12] 6Collaboration-Team-Backlog, 10Notifications, 5MW-1.27-release-notes, 5Patch-For-Review, 7Wikimedia-log-errors: "Title::newFromTitle: $text must be a string" from Echo - https://phabricator.wikimedia.org/T116034#2024715 (10Catrope) 5Open>3Resolved a:3Catrope [00:26:26] 6Collaboration-Team-Backlog, 10Flow, 5Patch-For-Review: GENDER support for Flow-notification-link-text-enabled-on-talkpage - https://phabricator.wikimedia.org/T113784#2024718 (10Catrope) 5Open>3Resolved a:3Catrope [00:26:34] 6Collaboration-Team-Backlog, 10Flow, 5Patch-For-Review: Flow shouldn't assume Parsoid is source of all VRS errors - https://phabricator.wikimedia.org/T112566#2024723 (10Catrope) 5Open>3Resolved a:3Catrope [00:26:36] 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, and 2 others: In current VRS deployment scenarios, error logging should not assume Parsoid is the source of all errors. - https://phabricator.wikimedia.org/T112330#2024725 (10Catrope) [00:27:40] 6Collaboration-Team-Backlog, 10Notifications, 5Patch-For-Review: Set up phpcs for Echo - https://phabricator.wikimedia.org/T101074#2024727 (10Catrope) 5Open>3Resolved a:3Catrope [00:29:32] Ok, out now. Have a good weekend, all! [00:29:58] 3Collaboration-Team-Current, 10MediaWiki-extensions-Scribunto, 10Wikidata, 7HHVM, and 2 others: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma) - https://phabricator.wikimedia.org/T103346#2024729 (10Catrope) 5Open>3Resolved [00:30:37] 6Collaboration-Team-Backlog, 10Notifications, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#2024734 (10Catrope) [00:30:39] 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10Notifications, 3Liaisons-February-2016, and 2 others: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#2024733 (10Catrope) 5Open>3Resolved [00:30:41] 6Collaboration-Team-Backlog, 10Notifications, 7Epic, 7WorkType-NewFunctionality, 7user-notice: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#2024735 (10Catrope) [00:31:17] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Fix EventLogging for cross-wiki notifications - https://phabricator.wikimedia.org/T120158#2024736 (10Catrope) 5Open>3Resolved [00:31:34] (03CR) 10Mattflaschen: "I put in the commit message (but forgot) that this is supposed to be merged at the same time as Ifc6f0c25ecd6a0a6d84481e18b512cf0af09d22f " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/269171 (https://phabricator.wikimedia.org/T120291) (owner: 10Mattflaschen) [00:31:49] (03CR) 10Mattflaschen: "I'm fixing the other patch now." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/269171 (https://phabricator.wikimedia.org/T120291) (owner: 10Mattflaschen) [00:35:36] (03PS4) 10Mattflaschen: Add script to populate rev_content_model for $wgFlowOccupyPages [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/260869 (https://phabricator.wikimedia.org/T105574) [00:39:10] (03CR) 10jenkins-bot: [V: 04-1] Add script to populate rev_content_model for $wgFlowOccupyPages [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/260869 (https://phabricator.wikimedia.org/T105574) (owner: 10Mattflaschen) [01:03:13] (03PS2) 10Mattflaschen: Use plaintextParams for topic title escaping [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/269172 (https://phabricator.wikimedia.org/T120291) [01:05:07] (03CR) 10Mattflaschen: Use plaintextParams for topic title escaping (032 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/269172 (https://phabricator.wikimedia.org/T120291) (owner: 10Mattflaschen) [01:07:11] RoanKattouw, can you review https://gerrit.wikimedia.org/r/#/c/269172/2 before branch cut (to avoid an wikitext escaping regression)? Shouldn't be a security issue, but this is a pair to the Flow patch. [01:07:17] Sure [01:07:22] If CI will let me merge it :/ [01:07:53] (03CR) 10Catrope: [C: 032] Use plaintextParams for topic title escaping [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/269172 (https://phabricator.wikimedia.org/T120291) (owner: 10Mattflaschen) [01:18:18] (03Merged) 10jenkins-bot: Use plaintextParams for topic title escaping [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/269172 (https://phabricator.wikimedia.org/T120291) (owner: 10Mattflaschen) [01:21:05] Thanks [01:28:39] 6Collaboration-Team-Backlog, 10Wikimedia-Site-Requests, 5Patch-For-Review: Override Echo system notification icons for all Wikimedia projects - https://phabricator.wikimedia.org/T49662#2024818 (10Mattflaschen) a:3Mattflaschen >>! In T49662#2023011, @Jdforrester-WMF wrote: > I made https://commons.wikimedia... [01:28:49] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests, 5Patch-For-Review: Override Echo system notification icons for all Wikimedia projects - https://phabricator.wikimedia.org/T49662#2024820 (10Mattflaschen) [01:46:58] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests, 5Patch-For-Review: Override Echo system notification icons for all Wikimedia projects - https://phabricator.wikimedia.org/T49662#2024823 (10Mattflaschen) For the remaining two (Wikimedia Labs and foundationwiki, I found suitable images I think we can ju... [02:14:23] Heading out for tonight. Have a good weekend. [07:09:21] (03CR) 10Legoktm: Have EventPresentationModel implement JsonSerializable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270419 (owner: 10Legoktm) [07:09:28] (03CR) 10Legoktm: [C: 032] "..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270419 (owner: 10Legoktm) [07:16:16] (03CR) 10jenkins-bot: [V: 04-1] Have EventPresentationModel implement JsonSerializable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270419 (owner: 10Legoktm) [07:16:19] (03CR) 10jenkins-bot: [V: 04-1] Get rid of pre-5.4 CallbackFilterIterator implementation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270424 (owner: 10Legoktm) [07:16:22] (03CR) 10jenkins-bot: [V: 04-1] Run scripts/gen-autoload.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270425 (owner: 10Legoktm) [07:17:16] (03CR) 10Legoktm: [C: 032] "I can do this all day jenkins." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270419 (owner: 10Legoktm) [07:23:52] (03Merged) 10jenkins-bot: Have EventPresentationModel implement JsonSerializable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270419 (owner: 10Legoktm) [07:25:53] (03Merged) 10jenkins-bot: Get rid of pre-5.4 CallbackFilterIterator implementation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270424 (owner: 10Legoktm) [07:25:56] (03Merged) 10jenkins-bot: Run scripts/gen-autoload.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270425 (owner: 10Legoktm) [09:04:39] hi there [09:56:51] 3Collaboration-Team-Current, 10MediaWiki-extensions-Scribunto, 10Wikidata, 7HHVM, and 2 others: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma) - https://phabricator.wikimedia.org/T103346#2025145 (10JanZerebecki) 5Resolved>3Open The bug is not fixed,... [10:36:50] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata broken on branch REL1_25 causing other extensions to fail. - https://phabricator.wikimedia.org/T125722#2025178 (10JanZerebecki) [10:36:54] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2025176 (10JanZerebecki) 5Open>3Resolved I merged https://ger... [10:37:12] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata broken on branch REL1_25 causing other extensions to fail. - https://phabricator.wikimedia.org/T125722#2025179 (10JanZerebecki) 5Open>3Resolved a:3JanZerebecki See T12... [12:18:26] 6Collaboration-Team-Backlog, 10MediaWiki-Recent-changes, 10Notifications, 7Easy: Move setting "Email on watchlist changed" from tab "User profile" → "Notification" - https://phabricator.wikimedia.org/T126863#2025269 (10Perhelion) 3NEW [17:19:19] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow\Exception\FlowException from line 159 of Flow/includes/Formatter/ChangesListQuery.php: Revision not found in revisionCache - https://phabricator.wikimedia.org/T122329#2025641 (10Southparkfan) {F3351040} This is likely what you need [18:16:44] 6Collaboration-Team-Backlog, 10Notifications, 7I18n: MediaWiki:Notification-header-thank-you-1000-edit should avoid SITENAME - https://phabricator.wikimedia.org/T126876#2025741 (10Legoktm) [18:24:27] 6Collaboration-Team-Backlog, 10Notifications, 7I18n: MediaWiki:Notification-header-thank-you-1000-edit should avoid SITENAME - https://phabricator.wikimedia.org/T126876#2025750 (10matmarex) [18:24:40] ^ phab's lack of conflict detection strikes again [18:40:05] 6Collaboration-Team-Backlog, 10Notifications, 7I18n: MediaWiki:Notification-header-thank-you-1-edit should not use SITENAME - https://phabricator.wikimedia.org/T126875#2025774 (10Purodha) [20:18:39] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/268172 (owner: 10Sbisson) [20:28:56] (03Merged) 10jenkins-bot: Generate bundled page-linked notifications in test script [extensions/Echo] - 10https://gerrit.wikimedia.org/r/268172 (owner: 10Sbisson) [21:23:34] (03Abandoned) 10Hashar: Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 (owner: 10Paladox)