[00:18:56] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10Notifications, 5Patch-For-Review: Update PageTriage notifications to new language and format - https://phabricator.wikimedia.org/T125693#2021190 (10Mattflaschen) This was done for {T114415}, because someone felt: ``` User:MyName was patro... [00:23:03] 3Collaboration-Team-Current, 6Editing-Analysis, 10Notifications: Research: How Many Users Get a Lot of Notifications? - https://phabricator.wikimedia.org/T125180#2021197 (10Neil_P._Quinn_WMF) I'm planning to pull data for the following wikis: * commons * enwiki * jawiki * frwiki [heavy Flow use] * zhwiki [h... [00:27:02] (03CR) 10Catrope: [C: 032] Bold pages and sections in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269169 (https://phabricator.wikimedia.org/T121724) (owner: 10Sbisson) [00:38:29] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Update and retest the convertToText script - https://phabricator.wikimedia.org/T90075#2021251 (10Catrope) 5Open>3Resolved [00:38:31] 6Collaboration-Team-Backlog, 10Flow: Solution for disabling Flow on a page - https://phabricator.wikimedia.org/T96301#2021253 (10Catrope) [00:39:06] (03CR) 10jenkins-bot: [V: 04-1] Bold pages and sections in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269169 (https://phabricator.wikimedia.org/T121724) (owner: 10Sbisson) [00:39:15] (03CR) 10Catrope: [C: 032] Do not bold the quotes in notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/270019 (https://phabricator.wikimedia.org/T121724) (owner: 10Sbisson) [00:39:23] Oh for... [00:46:48] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: If user only has foreign messages, the messages badge should not be suppressed - https://phabricator.wikimedia.org/T124372#2021260 (10Etonkovidova) Checked in betalabs - it's fixed. If a user with Enhanced notifications enabled and has only f... [00:51:23] (03Merged) 10jenkins-bot: Do not bold the quotes in notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/270019 (https://phabricator.wikimedia.org/T121724) (owner: 10Sbisson) [00:52:30] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#2021264 (10jmatazzoni) Comparing E... [00:57:19] matt_flaschen: Help? [00:57:30] quiddity and I are trying to move [[Wikipedia talk:WikiProject Breakfast]] to [[Wikipedia talk:WikiProject Breakfast/Flow archive]] [00:57:34] And we get the following exception: [00:57:52] 2016-02-12 00:55:06 mw1081 enwiki 1.27.0-wmf.13 exception ERROR: [de946867] /w/index.php?title=Special:MovePage&action=submit Flow\Exception\DataModelException from line 156 of /srv/mediawiki/php-1.27.0-wmf.13/extensions/Flow/includes/Data/Index/TopKIndex.php: Unable to find specified offset in query results {"exception_id":"de946867"} [00:57:53] [Exception Flow\Exception\DataModelException] (/srv/mediawiki/php-1.27.0-wmf.13/extensions/Flow/includes/Data/Index/TopKIndex.php:156) Unable to find specified offset in query results [00:57:55] #0 /srv/mediawiki/php-1.27.0-wmf.13/extensions/Flow/includes/Data/Index/TopKIndex.php(104): Flow\Data\Index\TopKIndex->getOffsetFromOffsetValue(array, string) [01:01:34] That's a new one... [01:02:19] Looking [01:02:55] (03CR) 10Catrope: [C: 032] Bold pages and topics in notifications [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/269170 (https://phabricator.wikimedia.org/T121724) (owner: 10Sbisson) [01:05:40] 3Collaboration-Team-Current, 10Flow: Error in Flow page move - https://phabricator.wikimedia.org/T126701#2021288 (10Mattflaschen) 3NEW a:3Mattflaschen [01:06:58] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 10Notifications, 3Liaisons-February-2016, 7user-notice: Cross-wiki Notification announcement on a small group of wikis - https://phabricator.wikimedia.org/T126485#2021297 (10Quiddity) [01:07:00] 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 3Liaisons-February-2016, 7user-notice: Cross-wiki notifications - announcements planning - https://phabricator.wikimedia.org/T123570#2021296 (10Quiddity) [01:08:43] 3Collaboration-Team-Current, 10Flow: Error in Flow page move - https://phabricator.wikimedia.org/T126701#2021300 (10Mattflaschen) [01:11:46] RoanKattouw, which user did the move? [01:11:58] Or attempted it. [01:12:03] matt_flaschen, I tried with staff account, which is autoconfirmed. [01:12:36] quiddity, Quiddity (WMF)? [01:12:41] yup [01:13:13] then roan tried, I'm not sure with presumably the same. [01:15:40] Yeah also with my WMF account [01:16:05] (03Merged) 10jenkins-bot: Bold pages and topics in notifications [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/269170 (https://phabricator.wikimedia.org/T121724) (owner: 10Sbisson) [01:16:10] The exception details I pasted are for my account, Roan Kattouw (WMF) [01:31:24] 3Collaboration-Team-Current, 10Flow: Error in Flow page move - https://phabricator.wikimedia.org/T126701#2021347 (10Mattflaschen) generateHtml is in the stacktrace, but when I try to isolate it to that and use the old page, it succeeds: ``` $oldTitle = Title::newFromText( 'Wikipedia talk:WikiProject Breakfast... [02:06:07] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#2021407 (10jmatazzoni) Re. my comm... [02:07:29] ebernhardson, do you know if your trick for debugging in production still works? [02:07:40] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 7user-notice: Roll out cross-wiki notifications beta feature - https://phabricator.wikimedia.org/T124234#2021408 (10Quiddity) [02:08:08] matt_flaschen: running an instance of hhvm from mw1017? i used it a few weeks ago. If you are testing an api request rather than a web request though the new `mwrepl` might be easier [02:08:14] s/weeks/months/ [02:08:14] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 7user-notice: Roll out cross-wiki notifications beta feature - https://phabricator.wikimedia.org/T124234#1949751 (10Quiddity) [02:08:19] 6Collaboration-Team-Backlog, 10Notifications, 7Epic, 7WorkType-NewFunctionality, 7user-notice: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#2021409 (10Quiddity) [02:08:24] matt_flaschen: afaik it would still work though :) [02:09:43] i should really try and work that into something more official and less of a hack so it could be considered reliable ... [02:11:16] Thanks, ebernhardson. Is mwrepl documented somewhere? Any particular differences from eval.php? Maybe less fondness for failing and making you start over from scratch? [02:11:53] matt_flaschen: basically mwrepl is just the hhvm interactive debugger, all the `mwrepl` script adds around the outside is managing per user configuration even though everyone is sudo'd to www-data, and filling in the right command line options [02:13:20] matt_flaschen, I'm heading out for the evening, so please don't actually move the Breakfast page until tomorrow, if you determine the problem before then. (Unless you really really want to do all the followup moves, protection, and messaging... ;-) [02:13:35] ebernhardson, oh, okay. Yeah, an actual debugger definitely beats eval.php. [02:13:51] have a good [time of day], all. o/ :) [02:14:08] matt_flaschen: api requests just happen to be easy to debug because you can do a FauxRequest [02:14:27] matt_flaschen: yup, it doesn't fall over like eval.php, and you get breakpoints and such :) [02:14:30] quiddity, yeah, I'm trying to figure out why we can't move it without actually moving it, which is difficult. [02:15:28] matt_flaschen: oh and you asked about documentation, i poked around but hhvm never released documentation in a web or man page based format. But the `help` command or `help ` inside the debugger are pretty complete [02:15:45] * ebernhardson has resolved that he will never learn to speak proper english ... [02:15:50] s/speak/type/ [02:22:52] matt_flaschen: also just for kicks i tried out my scripts on mw1017, they still seem to work to boot up an instance and run web requests through it [02:26:24] ebernhardson, how do I set which wiki mwrepl uses for context? It's not finding the page in question, which is probably because it's looking on the wrong wiki or missing context. [02:27:15] Oh, mwrepl enwiki [03:34:11] 3Collaboration-Team-Current, 10Flow: Error in Flow page move - https://phabricator.wikimedia.org/T126701#2021510 (10Mattflaschen) I haven't figured it out yet. Tomorrow, I would like to try debugging through mwrepl with FauxRequst and API:Move. (I couldn't recall using the move API with Flow before, but I ju... [08:29:45] 6Collaboration-Team-Backlog, 10Notifications: Use smart quotes in notifications - https://phabricator.wikimedia.org/T126719#2021734 (10Pginer-WMF) 3NEW [08:30:18] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2021740 (10Pginer-WMF) [08:34:26] 6Collaboration-Team-Backlog, 10Notifications: 'Mark as read' dots menu is misaligned - https://phabricator.wikimedia.org/T126686#2021748 (10Pginer-WMF) [08:34:28] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2021747 (10Pginer-WMF) [08:49:22] 3Collaboration-Team-Current, 10Notifications: Use more compact timestamps for notifications - https://phabricator.wikimedia.org/T125970#2021761 (10Pginer-WMF) > I would submit that after "1 day," simple date notation would be just as helpful-- or more helpful, in fact. If we used dates and added a rule that we... [09:29:16] 6Collaboration-Team-Backlog, 10Notifications: Use smart quotes in notifications - https://phabricator.wikimedia.org/T126719#2021797 (10Quiddity) I'm not sure about this one. There are numerous quotation mark „standards”, https://en.wikipedia.org/wiki/Quotation_mark and I don't think we have a system for match... [10:20:15] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#2021872 (10Pginer-WMF) >>! In T121... [11:55:44] 6Collaboration-Team-Backlog, 10Wikimedia-Extension-setup, 7Community-consensus-needed, 5Patch-For-Review: Install WikiLove extension at Azerbaijani Wikipedia - https://phabricator.wikimedia.org/T119727#2022057 (10Serkanland) @Dereckson, there is consensus: https://az.wikipedia.org/wiki/Vikipediya:Kənd_meyd... [12:07:05] 3Collaboration-Team-Current, 10Flow: [betalabs] Editing Flow board entries not possible in VE - https://phabricator.wikimedia.org/T123011#2022069 (10Aklapper) Any news here from Product Review after three weeks? [12:07:20] 6Collaboration-Team-Backlog, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Fatal error: Cannot redeclare class CallbackFilterIterator when linting (pre-deploy) on mira - https://phabricator.wikimedia.org/T124828#2022070 (10Aklapper) >>! In T124828#1968032, @dduvall wrote: > It... [12:50:04] 6Collaboration-Team-Backlog, 10Notifications: Items in the more actions menu of notifications are inconsistent - https://phabricator.wikimedia.org/T126734#2022178 (10Pginer-WMF) 3NEW [12:51:19] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2022184 (10Pginer-WMF) [13:19:37] 6Collaboration-Team-Backlog, 10Notifications: Show descriptions for the actions under the "..." menu on notifications - https://phabricator.wikimedia.org/T126738#2022242 (10Pginer-WMF) 3NEW [13:20:28] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2022250 (10Pginer-WMF) [13:35:06] 6Collaboration-Team-Backlog, 10Notifications: Adjust hover state for actions in the more menu ("...") of notifications - https://phabricator.wikimedia.org/T126740#2022269 (10Pginer-WMF) 3NEW [13:35:42] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2022276 (10Pginer-WMF) [13:38:16] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 5WMF-deploy-2016-02-09_(1.27.0-wmf.13): Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#2022283 (10Pginer-WMF) > Do the li... [14:54:16] (03CR) 10Siebrand: "i18n/L10n reviewed. Please add message documentation when adding messages. See https://www.mediawiki.org/wiki/I18n#Message_documentation f" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [14:54:31] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed. Please add message documentation when adding messages. See https://www.mediawiki.org/wiki/I18n#Message_documentation f" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [14:56:56] (03CR) 10Siebrand: [C: 04-1] "i18n/L10n reviewed." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269169 (https://phabricator.wikimedia.org/T121724) (owner: 10Sbisson) [15:42:01] \o [15:42:12] hmm, wrong room. but hi too :) [16:02:46] (03CR) 10Krinkle: Use WatchedItemStore from core (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267682 (owner: 10Addshore) [16:34:01] 6Collaboration-Team-Backlog, 10Flow, 5Patch-For-Review, 7Tracking: Track Flow Beta Feature activation on users talk pages - https://phabricator.wikimedia.org/T114111#2022669 (10Milimetric) FYI the manual enables are easy to add, but we can't get historical data so if you want it, ask me soon or add the que... [16:47:59] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#2022695 (10MGChecker) [16:48:01] 6Collaboration-Team-Backlog, 10Notifications: Too long line for secondary actions results in adding a horizontal scroll bar - https://phabricator.wikimedia.org/T126617#2022696 (10MGChecker) [17:33:41] 6Collaboration-Team-Backlog, 10Wikimedia-Site-Requests, 5Patch-For-Review: Override Echo system notification icons for all Wikimedia projects - https://phabricator.wikimedia.org/T49662#2023011 (10Jdforrester-WMF) I made https://commons.wikimedia.org/wiki/Category:Notifications_icons to help with this. [17:35:39] mlitn, any thoughts on https://phabricator.wikimedia.org/T126701 ? [17:48:05] matt_flaschen: no idea [17:48:08] would have to look into it [17:48:26] I guess there’s some bug in our cache layer, somewhere :p [17:49:20] mlitn, that's never happened. :) [17:49:25] :D [17:49:45] mlitn, okay, I am going to try to debug through an actual move in prod, using someone's account (if I can get an OK on that). [17:49:55] mwrepl is nice (debugger in prod!) [17:53:21] I haven’t tried it yet [17:53:30] sounds very interesting though [18:03:17] 6Collaboration-Team-Backlog, 10MobileFrontend: Very long talk pages unreadable - https://phabricator.wikimedia.org/T116686#2023241 (10Florian) Hmm, I like your idea Jon, but it seems that the talk page structure is very very complicated to style :/ Example: {F3337094} [18:08:53] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: The action menu ("...") for bundled notifications cannot be closed by clicking on it again - https://phabricator.wikimedia.org/T123754#2023267 (10jmatazzoni) 5Open>3Resolved [18:12:08] 6Collaboration-Team-Backlog, 10MobileFrontend: Very long talk pages unreadable - https://phabricator.wikimedia.org/T116686#2023285 (10JKatzWMF) [18:48:30] (03CR) 10Catrope: [C: 032] Bold pages and sections in notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269169 (https://phabricator.wikimedia.org/T121724) (owner: 10Sbisson) [18:56:33] (03CR) 10Catrope: [C: 04-1] Add email body preview to emailuser notification (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269845 (https://phabricator.wikimedia.org/T121831) (owner: 10Sbisson) [19:00:07] (03CR) 10Catrope: [C: 04-1] Include reason in user-rights notification body (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269306 (https://phabricator.wikimedia.org/T126277) (owner: 10Sbisson) [19:00:58] (03CR) 10Catrope: [C: 032] Add thank icon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269146 (https://phabricator.wikimedia.org/T125693) (owner: 10Sbisson) [19:07:20] 6Collaboration-Team-Backlog, 10Notifications: Use smart quotes in notifications - https://phabricator.wikimedia.org/T126719#2023574 (10Catrope) I'm pretty sure all our English i18n messages use straight quotes. Some languages use different things; for example, the French translations use [[https://en.wikipedia... [19:07:39] 3Collaboration-Team-Current, 10Flow: [betalabs] Editing Flow board entries not possible in VE - https://phabricator.wikimedia.org/T123011#2023577 (10Catrope) 5Open>3Resolved [19:13:50] 6Collaboration-Team-Backlog, 10Notifications: Use smart quotes in notifications - https://phabricator.wikimedia.org/T126719#2023609 (10matmarex) {T12352} ;) [19:16:11] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10Notifications, 5Patch-For-Review: Update PageTriage notifications to new language and format - https://phabricator.wikimedia.org/T125693#2023625 (10jmatazzoni) Thanks for the history @Mattflaschen. On that score: I assume the main notific... [19:22:16] 6Collaboration-Team-Backlog, 10Notifications: Use smart quotes in notifications - https://phabricator.wikimedia.org/T126719#2023657 (10matmarex) >>! In T126719#2021797, @Quiddity wrote: > I'm not sure about this one. > There are numerous quotation mark „standards”, https://en.wikipedia.org/wiki/Quotation_mark... [19:23:08] (03CR) 10Catrope: [C: 032] Generate CX notifications in maintenance script [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269145 (owner: 10Sbisson) [19:23:45] (03PS3) 10Catrope: Generate bundled page-linked notifications in test script [extensions/Echo] - 10https://gerrit.wikimedia.org/r/268172 (owner: 10Sbisson) [19:23:49] (03Merged) 10jenkins-bot: Bold pages and sections in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269169 (https://phabricator.wikimedia.org/T121724) (owner: 10Sbisson) [19:23:52] (03CR) 10jenkins-bot: [V: 04-1] Add thank icon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269146 (https://phabricator.wikimedia.org/T125693) (owner: 10Sbisson) [19:24:32] 3Collaboration-Team-Current, 10Flow, 10Notifications: Bundled flow-post-reply notifications, should send editors to the top-most reply - https://phabricator.wikimedia.org/T126264#2023663 (10jmatazzoni) a:3Catrope [19:24:40] (03CR) 10Catrope: [C: 032] Generate bundled page-linked notifications in test script [extensions/Echo] - 10https://gerrit.wikimedia.org/r/268172 (owner: 10Sbisson) [19:24:59] 3Collaboration-Team-Current, 10Flow, 10Notifications: Bundled flow-post-reply notifications, should send editors to the top-most reply - https://phabricator.wikimedia.org/T126264#2023669 (10Catrope) a:5Catrope>3None [19:25:47] 3Collaboration-Team-Current, 10Flow, 10Notifications: Bundled flow-post-reply notifications, should send editors to the top-most reply - https://phabricator.wikimedia.org/T126264#2023675 (10jmatazzoni) Roan, please look at this and let's decide if it's something we want to address in the current work. This... [19:27:42] 3Collaboration-Team-Current, 10Flow, 10Notifications: Bundled flow-post-reply notifications, should send editors to the top-most reply - https://phabricator.wikimedia.org/T126264#2023693 (10jmatazzoni) a:3Catrope [19:38:15] (03Merged) 10jenkins-bot: Generate CX notifications in maintenance script [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269145 (owner: 10Sbisson) [19:38:18] (03CR) 10jenkins-bot: [V: 04-1] Generate bundled page-linked notifications in test script [extensions/Echo] - 10https://gerrit.wikimedia.org/r/268172 (owner: 10Sbisson) [19:38:38] 3Collaboration-Team-Current, 10Notifications: Update enwiki customizations for page triage notification - https://phabricator.wikimedia.org/T126803#2023764 (10jmatazzoni) 3NEW [19:41:25] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10Notifications, 5Patch-For-Review: Update PageTriage notifications to new language and format - https://phabricator.wikimedia.org/T125693#2023803 (10jmatazzoni) [19:41:27] 3Collaboration-Team-Current, 10Notifications: Update enwiki customizations for page triage notification - https://phabricator.wikimedia.org/T126803#2023804 (10jmatazzoni) [19:41:37] (03PS6) 10Sbisson: Rephrase notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268691 (https://phabricator.wikimedia.org/T125693) [19:41:46] (03PS7) 10Sbisson: Rephrase notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268691 (https://phabricator.wikimedia.org/T125693) [19:45:41] (03PS4) 10Sbisson: Generate bundled page-linked notifications in test script [extensions/Echo] - 10https://gerrit.wikimedia.org/r/268172 [19:49:54] (03CR) 10Catrope: [C: 032] Generate bundled page-linked notifications in test script [extensions/Echo] - 10https://gerrit.wikimedia.org/r/268172 (owner: 10Sbisson) [19:50:17] 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, and 3 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#2023848 (10Esanders) @cscott There's already something set in data-parsoid, we could just move that definition to da... [19:50:25] (03PS2) 10Sbisson: Add email body preview to emailuser notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269845 (https://phabricator.wikimedia.org/T121831) [19:51:41] (03CR) 10Catrope: [C: 032] Add email body preview to emailuser notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269845 (https://phabricator.wikimedia.org/T121831) (owner: 10Sbisson) [19:55:28] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Put email subject in notification body of emailuser notifications - https://phabricator.wikimedia.org/T121831#2023896 (10Legoktm) Sorry, I'm a bit late here but I still don't think this is a good idea to do. The email system in MediaWiki is cur... [19:58:15] (03PS2) 10Sbisson: Include reason in user-rights notification body [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269306 (https://phabricator.wikimedia.org/T126277) [20:00:32] (03Merged) 10jenkins-bot: Add email body preview to emailuser notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269845 (https://phabricator.wikimedia.org/T121831) (owner: 10Sbisson) [20:01:58] (03CR) 10jenkins-bot: [V: 04-1] Generate bundled page-linked notifications in test script [extensions/Echo] - 10https://gerrit.wikimedia.org/r/268172 (owner: 10Sbisson) [20:02:20] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Put email subject in notification body of emailuser notifications - https://phabricator.wikimedia.org/T121831#2023935 (10Sjoerddebruin) I agree with @LegoKTM, we should keep this separate. [20:05:21] (03PS8) 10Sbisson: Rephrase notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268691 (https://phabricator.wikimedia.org/T125693) [20:17:48] 6Collaboration-Team-Backlog, 10Notifications: Use smart quotes in notifications - https://phabricator.wikimedia.org/T126719#2023950 (10Quiddity) >>! In T126719#2023657, @matmarex wrote: >>>! In T126719#2021797, @Quiddity wrote: >> and I don't think we have a system for matching them (?), like {{int:parentheses... [20:25:07] (03CR) 10Catrope: [C: 032] Make TopicTitleWidget pending on save [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266588 (https://phabricator.wikimedia.org/T124796) (owner: 10Sbisson) [20:32:30] looking for lunch. back in 30-45. [20:35:26] (03Merged) 10jenkins-bot: Make TopicTitleWidget pending on save [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266588 (https://phabricator.wikimedia.org/T124796) (owner: 10Sbisson) [20:49:39] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Put email subject in notification body of emailuser notifications - https://phabricator.wikimedia.org/T121831#2024034 (10jmatazzoni) Thanks for your comments Legoktm and Sjoerddebruin. After discussing this, Roan and I ran the issue past James.... [21:00:06] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Put email subject in notification body of emailuser notifications - https://phabricator.wikimedia.org/T121831#2024041 (10Legoktm) Which James? ;-) [21:14:34] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Put email subject in notification body of emailuser notifications - https://phabricator.wikimedia.org/T121831#2024077 (10Catrope) >>! In T121831#2024041, @Legoktm wrote: > Which James? ;-) Forrester. Sorry, didn't notice Alexander was mentione... [21:20:08] (03CR) 10Catrope: [C: 04-1] Add flow-description-edited notification (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268164 (https://phabricator.wikimedia.org/T125429) (owner: 10Matthias Mullie) [21:29:27] (03CR) 10Catrope: "Looks OK. Some comments inline. Also, visiting the Flow board (e.g. by clicking the primary link) should make the notification read, but c" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268164 (https://phabricator.wikimedia.org/T125429) (owner: 10Matthias Mullie) [21:37:57] (03CR) 10Catrope: [C: 032] Add mention notification for changes in board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268165 (https://phabricator.wikimedia.org/T125427) (owner: 10Matthias Mullie) [21:50:11] RoanKattouw: https://gerrit.wikimedia.org/r/#/c/264900/ :-) [21:53:19] (03CR) 10Catrope: [C: 04-1] "Bugs I found while testing this:" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/269105 (https://phabricator.wikimedia.org/T125120) (owner: 10Matthias Mullie) [21:54:02] (03CR) 10Catrope: [C: 032] Add thank icon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269146 (https://phabricator.wikimedia.org/T125693) (owner: 10Sbisson) [21:58:02] quiddity, what should I put as the reason field for the move? [21:59:00] (03CR) 10Catrope: [C: 04-1] "Minor comment inline, plus what Liangent said. Looks good otherwise." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) (owner: 10Jforrester) [21:59:38] matt_flaschen, "Moving to subpage. The converted page will be relocated here, shortly." [21:59:48] legoktm: Re https://gerrit.wikimedia.org/r/#/c/264900/15..18/Echo.php , are you sure that we don't need primary-link, title-message, etc there for the email formatter? [21:59:55] (The old one that is) [22:01:39] Thanks, quiddity [22:02:14] (03Merged) 10jenkins-bot: Add thank icon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/269146 (https://phabricator.wikimedia.org/T125693) (owner: 10Sbisson) [22:03:56] matt_flaschen, please let me know when complete, and also please protect the /Flow_archive. I'll then page-move the converted page, into the main location, and add a message. [22:06:30] 3Collaboration-Team-Current, 6Editing-Department, 10Notifications, 5Patch-For-Review, 7user-notice: Automatically congratulate users for reaching certain edit count milestones - https://phabricator.wikimedia.org/T124003#2024221 (10Jdlrobson) [22:06:37] 3Collaboration-Team-Current, 6Editing-Department, 10Notifications, 5Patch-For-Review, 7user-notice: Automatically congratulate users for reaching certain edit count milestones - https://phabricator.wikimedia.org/T124003#1943040 (10Jdlrobson) Fwiw the growth team and mobile team have attempted to congratu... [22:07:03] RoanKattouw: uhh, that notification type is listed as web only? [22:07:12] LOL [22:07:14] OK [22:07:15] Sure [22:07:18] I'm an idiot [22:07:28] Well spotted :) [22:11:30] (03PS19) 10Catrope: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) (owner: 10Jforrester) [22:12:14] (03CR) 10Catrope: [C: 032] Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) (owner: 10Jforrester) [22:12:32] James_F: I simplified a bit https://gerrit.wikimedia.org/r/#/c/264900/18..19/Hooks.php and +2ed [22:12:37] However, in testing I noticed it also doesn't pick up on rollback [22:12:39] s [22:12:44] In addition to Flow posts [22:13:08] So longer term I think we should add an EditCountIncrement hook [22:15:58] (03PS1) 10Legoktm: Have EventPresentationModel implement JsonSerializable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270419 [22:16:16] (03CR) 10Catrope: [C: 032] Have EventPresentationModel implement JsonSerializable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270419 (owner: 10Legoktm) [22:17:14] quiddity, none of us are admins on work account, so we'll have to bug someone to protect the Flow board. I'll ping you when the move is done. [22:17:43] ty :) [22:18:17] (03PS1) 10Legoktm: Make some functions actually abstract since PHP 5.3.9+ lets us [extensions/Flow] - 10https://gerrit.wikimedia.org/r/270423 [22:19:07] (03Merged) 10jenkins-bot: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) (owner: 10Jforrester) [22:20:32] (03PS1) 10Legoktm: Get rid of pre-5.4 CallbackFilterIterator implementation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270424 [22:20:35] (03PS1) 10Legoktm: Run scripts/gen-autoload.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270425 [22:21:54] (03CR) 10Catrope: [C: 032] Make some functions actually abstract since PHP 5.3.9+ lets us [extensions/Flow] - 10https://gerrit.wikimedia.org/r/270423 (owner: 10Legoktm) [22:22:23] (03CR) 10Catrope: [C: 032] Get rid of pre-5.4 CallbackFilterIterator implementation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270424 (owner: 10Legoktm) [22:22:33] (03CR) 10Catrope: [C: 032] Run scripts/gen-autoload.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270425 (owner: 10Legoktm) [22:22:55] (03CR) 10jenkins-bot: [V: 04-1] Have EventPresentationModel implement JsonSerializable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270419 (owner: 10Legoktm) [22:22:59] o.O [22:23:33] 22:17:11 npm ERR! path /mnt/jenkins-workspace/workspace/npm/node_modules/grunt-jsonlint/node_modules/jsonlint/node_modules/JSV/jsdoc-toolkit/app/lib/JSDOC/TokenStream.js [22:23:33] 22:17:11 npm ERR! code ENOENT [22:23:55] (03CR) 10Legoktm: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270419 (owner: 10Legoktm) [22:24:11] (03CR) 10jenkins-bot: [V: 04-1] Get rid of pre-5.4 CallbackFilterIterator implementation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270424 (owner: 10Legoktm) [22:24:19] Yeah, both the npm job and the other one have bogus failures related to npm [22:24:41] sigh. [22:25:07] Oh look and this error periodically happens too [22:25:20] Maybe one slave is broken? [22:25:20] 22:23:33 Query: SHOW TABLES [22:25:21] 22:23:33 Function: MediaWikiTestCase::listTables [22:25:22] 22:23:33 Error: 1049 Unknown database 'jenkins_u2_mw' (127.0.0.1:3306) [22:25:47] (03CR) 10jenkins-bot: [V: 04-1] Run scripts/gen-autoload.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270425 (owner: 10Legoktm) [22:26:55] 3Collaboration-Team-Current, 6Editing-Department, 10Notifications, 5Patch-For-Review, 7user-notice: Automatically congratulate users for reaching certain edit count milestones - https://phabricator.wikimedia.org/T124003#2024294 (10Ricordisamoa) >>! In T124003#2024221, @Jdlrobson wrote: > Fwiw the growth... [22:27:05] no, they're all different slaves [22:30:25] Whoa! https://gerrit.wikimedia.org/r/#/c/267259/13 [22:30:37] Submit Type RULE_ERROR o.O [22:30:52] (03CR) 10Legoktm: [C: 032] Have EventPresentationModel implement JsonSerializable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270419 (owner: 10Legoktm) [22:31:00] (03CR) 10Legoktm: [C: 032] Get rid of pre-5.4 CallbackFilterIterator implementation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270424 (owner: 10Legoktm) [22:31:07] (03CR) 10Legoktm: [C: 032] Run scripts/gen-autoload.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270425 (owner: 10Legoktm) [22:31:10] 3Collaboration-Team-Current, 6Editing-Department, 10Notifications, 7Community-consensus-needed, and 2 others: Automatically congratulate users for reaching certain edit count milestones - https://phabricator.wikimedia.org/T124003#2024319 (10Ricordisamoa) [22:37:07] 3Collaboration-Team-Current, 10Flow, 10Thanks, 10Notifications, 5Patch-For-Review: wikitext in flow titles is parsed (HTML tags like and templates) on echo notifications - https://phabricator.wikimedia.org/T120291#2024360 (10Quiddity) [22:39:02] (03Merged) 10jenkins-bot: Make some functions actually abstract since PHP 5.3.9+ lets us [extensions/Flow] - 10https://gerrit.wikimedia.org/r/270423 (owner: 10Legoktm) [22:39:23] (03CR) 10jenkins-bot: [V: 04-1] Have EventPresentationModel implement JsonSerializable [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270419 (owner: 10Legoktm) [22:39:26] (03CR) 10jenkins-bot: [V: 04-1] Get rid of pre-5.4 CallbackFilterIterator implementation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270424 (owner: 10Legoktm) [22:39:29] (03CR) 10jenkins-bot: [V: 04-1] Run scripts/gen-autoload.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/270425 (owner: 10Legoktm) [22:40:05] 3Collaboration-Team-Current, 6Editing-Department, 10Notifications, 7user-notice: Automatically congratulate users for reaching certain edit count milestones - https://phabricator.wikimedia.org/T124003#2024371 (10Jdforrester-WMF) 5Open>3Resolved [22:41:19] 6Collaboration-Team-Backlog, 6Editing-Department: Consider providing a mechanism to prompt users to congratulate other users for reaching milestones - https://phabricator.wikimedia.org/T126820#2024375 (10Jdforrester-WMF) 3NEW [22:41:23] (03CR) 10Catrope: [C: 04-1] Use WatchedItemStore from core (0311 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267682 (owner: 10Addshore) [22:42:03] I give up for now. [22:43:24] 3Collaboration-Team-Current, 6Editing-Department, 10Notifications, 7user-notice: Automatically congratulate users for reaching certain edit count milestones - https://phabricator.wikimedia.org/T124003#2024385 (10Mattflaschen) >>! In T124003#2024221, @Jdlrobson wrote: > Fwiw the growth team and mobile team... [22:55:28] legoktm: On death-to-5.3-isms? :-) [22:55:38] on getting my patches merged [22:55:40] lol [22:56:03] legoktm: *cough* mediawiki-codesniffer *cough* [23:16:04] RoanKattouw: Some open tasks of yours that probably (?) shouldn't be: https://phabricator.wikimedia.org/maniphest/query/2v4v4tqF9bF1/#R https://phabricator.wikimedia.org/maniphest/query/vtM7v2J_A_03/#R [23:18:45] Thanks, will look later [23:33:04] matt_flaschen, can we bump the page-move till Tuesday? I'd like to take an early Friday in about 30 minutes, and also to be more relaxed over the weekend... [23:42:52] quiddity, are you working on Monday? [23:44:14] I've pretty much got the debugger environment working, but it's unlikely to get fixed fully in the next 30 minutes (unless it magically fixed itself). [23:44:50] I would like to keep playing with it for a couple minutes, though, but I can stop at 4:15 your time if that works. [23:44:59] matt_flaschen, nope, hence Tuesday. [23:45:38] (My days off are rare enough as it is! ;) [23:46:05] Oh, I forgot what you said. I was going to offer to reschedule my day in case you were just saying that because I said I was taking off. [23:47:13] quiddity, alright, how about I stop at 4 just in case it actually succeeds? [23:47:54] ok :)