[01:01:32] (03CR) 10Aude: [C: 032] Bring back user-rights lego messages [extensions/Echo] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268439 (https://phabricator.wikimedia.org/T125584) (owner: 10Mattflaschen) [01:16:44] (03Merged) 10jenkins-bot: Bring back user-rights lego messages [extensions/Echo] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268439 (https://phabricator.wikimedia.org/T125584) (owner: 10Mattflaschen) [01:43:41] (03PS1) 10Sbisson: Truncate title and topic title in 'flow-thank' notification [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/268605 (https://phabricator.wikimedia.org/T121822) [01:53:17] SWAT worked. :) [03:12:07] (03PS1) 10Mattflaschen: Fix escaping for Special:EnableFlow page name [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268612 [03:14:55] ebernhardson, I'm building HHVM in preparation for my first patch. [03:24:35] To be continued [04:02:55] (03CR) 10Liuxinyu970226: [C: 04-1] "Per above, should be abandoned" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265788 (owner: 10IoannisKydonis) [04:45:53] (03PS1) 10MtDu: Use new trash icon *On deletion-related notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/268621 (https://phabricator.wikimedia.org/T125785) [06:56:18] (03PS3) 10Matthias Mullie: Get rid of old flyout formatter code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263788 [07:50:24] (03Abandoned) 10IoannisKydonis: Reword echo-notification-alert-text-only [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265788 (owner: 10IoannisKydonis) [10:56:31] (03PS1) 10Umherirrender: Remove unneeded variable assignment [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268643 [11:01:31] (03PS1) 10Umherirrender: require_once is not a function [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268644 [11:40:33] (03CR) 10Sbisson: [C: 032] Generate mentions for existing edit notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267909 (https://phabricator.wikimedia.org/T125427) (owner: 10Matthias Mullie) [11:45:09] mlitn: hey [11:45:38] did you say you want to wait for the new email formatter before merging any of the 'board-description-edited' stuff? [12:06:21] yeah [12:06:29] didn’t implement anything related to mail yet [12:06:47] (03Merged) 10jenkins-bot: Generate mentions for existing edit notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267909 (https://phabricator.wikimedia.org/T125427) (owner: 10Matthias Mullie) [12:06:48] so unless the new mail formatter is still far out, I’m gonna wait [12:07:09] could you -1 the specific patches so it doesn't happen by accident? [12:12:48] (03CR) 10Hashar: "recheck" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268484 (owner: 10Paladox) [12:13:40] (03CR) 10Hashar: "Was to confirm that jsduck is no more triggered on Flow @ REL1_25 (CI change is https://gerrit.wikimedia.org/r/#/c/268557/ )" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268484 (owner: 10Paladox) [12:46:50] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268656 [12:47:37] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268656 [12:47:58] (03CR) 10jenkins-bot: [V: 04-1] Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268656 (owner: 10Hashar) [12:51:43] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268656 (owner: 10Hashar) [12:53:49] (03CR) 10Hashar: "recheck" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [12:59:47] (03PS3) 10Hashar: Add composer test with just php-parallel-lint [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [13:02:22] (03CR) 10Hashar: "I have updated the composer.lock manually via:" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [13:05:40] (03CR) 10jenkins-bot: [V: 04-1] Add composer test with just php-parallel-lint [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [13:08:42] (03CR) 10Paladox: "Hashar: should we skip rel1_25 branch for qunit tests for flow. I could have a look at the errors tonight and see if they were fixed later" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [13:11:21] grbblblb [13:13:36] (03CR) 10Hashar: "I would keep the qunit job around. Since two of the tests failing are in Flow, maybe we can comment them out or ideally attempt to get th" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [13:15:13] (03CR) 10Paladox: "Hashar I believed that the qunit tests fail on REL1_25 branch because of flow. So I would say maybe disable the qunit tests for flow on br" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [13:17:24] (03CR) 10Hashar: "The problem is that mediawiki-extensions-qunit is cloning several extensions and it is triggered by all such extensions. So it is also fa" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [14:15:12] (03CR) 10Matthias Mullie: [C: 032] Truncate title and topic title in 'flow-thank' notification [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/268605 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [14:34:41] (03Merged) 10jenkins-bot: Truncate title and topic title in 'flow-thank' notification [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/268605 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [15:55:52] (03CR) 10Mattflaschen: [C: 032] require_once is not a function [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268644 (owner: 10Umherirrender) [15:57:49] (03Merged) 10jenkins-bot: require_once is not a function [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268644 (owner: 10Umherirrender) [16:42:55] (03PS1) 10Sbisson: [WIP] Rephrase notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268691 (https://phabricator.wikimedia.org/T125693) [16:44:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Rephrase notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268691 (https://phabricator.wikimedia.org/T125693) (owner: 10Sbisson) [16:47:15] (03PS2) 10Sbisson: [WIP] Rephrase notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268691 (https://phabricator.wikimedia.org/T125693) [16:48:52] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Rephrase notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268691 (https://phabricator.wikimedia.org/T125693) (owner: 10Sbisson) [16:51:16] (03PS3) 10Sbisson: [WIP] Rephrase notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/268691 (https://phabricator.wikimedia.org/T125693) [16:55:37] 6Collaboration-Team-Backlog, 10Flow: Change propagation for Flow - https://phabricator.wikimedia.org/T125857#2002563 (10GWicke) My first thought is to tackle this in two layers: 1) Figure out which pages / flow boards need to be updated in reaction to template / image changes and page creations, using the reg... [17:10:49] 6Collaboration-Team-Backlog, 10Notifications: Echo notifications are cluttered - https://phabricator.wikimedia.org/T125936#2002607 (10kaldari) 5Open>3declined a:3kaldari I'm going to close this ticket as declined. However, I would like to express my continued preference for a simple notification interfac... [17:27:29] 6Collaboration-Team-Backlog, 10Notifications: Echo notifications are cluttered - https://phabricator.wikimedia.org/T125936#2002639 (10Mattflaschen) > Back when I was working on Echo, I begged and begged the designer and project manager (who are both gone now) to let us have more than 1 link per notification (i... [17:39:09] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10Notifications, 5Patch-For-Review: Update PageTriage notifications to new language and format - https://phabricator.wikimedia.org/T125693#2002700 (10SBisson) @pginer-wmf Do you know where I can find the 'Thank' icon in png? There's one in t... [17:42:03] 6Collaboration-Team-Backlog, 10Parsoid, 10VisualEditor, 7Epic: HTML diffs of edits for everything - https://phabricator.wikimedia.org/T105173#2002737 (10Jdforrester-WMF) [17:43:38] 3Collaboration-Team-Current, 10MediaWiki-extensions-EducationProgram, 10Notifications: Update EducationProgram notifications to new language and format - https://phabricator.wikimedia.org/T125692#2002744 (10SBisson) a:3SBisson [17:49:33] matt_flaschen: I still get varnish errors when I provision. Are/were you working on it? [17:58:53] stephanebisson, what are the errors? I fixed one (https://phabricator.wikimedia.org/T124711), but I can't remember if there were more. [17:59:19] stephanebisson, I just did a clean provision with varnish, though, on https://gerrit.wikimedia.org/r/#/c/268707/ . [18:00:00] that's the same error I get [18:00:17] stephanebisson, the /home? It should be fixed. [18:00:24] (I committed the wrong version of grunt, fixing now). [18:02:30] matt_flaschen: should I "kill varnish"? [18:03:02] stephanebisson, what do you get for: [18:03:03] grep varnish /etc/passwd [18:03:18] varnish:x:1002:1002::/var/run/varnish: [18:03:18] varnishlog:x:112:119::/home/varnishlog:/bin/false [18:03:57] stephanebisson, okay, so you probably already fixed it manually, or it wasn't running when it switched it to /var/run/varnish. [18:04:04] I was trying to avoid manual fixes, but too late in this case. [18:04:16] So yeah, kill it then run: [18:04:36] what exactly do I kill? [18:04:55] sudo /etc/init.d/varnish stop [18:04:59] sudo usermod -d /home/varnish varnish [18:06:10] ok, and provision? [18:06:33] stephanebisson, yeah. It should work going forward now. [18:13:00] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 3Liaisons-February-2016, 7Surveys: Work on a satisfaction survey concerning Flow - https://phabricator.wikimedia.org/T125632#2002894 (10egalvezwmf) That list is looking great. A suggestion to move translation until after the surve... [18:16:58] matt_flaschen: same error... [18:17:13] matt_flaschen: also, there's no /home/varnish [18:19:34] stephanebisson, I don't have /home/varnish either. It doesn't really use it. [18:19:57] stephanebisson, you changed the home directory manually with the usermod I posted? [18:20:04] yes [18:20:14] stephanebisson, can you post the error excerpt? [18:20:36] matt_flaschen: Error: Could not set home on user[varnish]: Execution of '/usr/sbin/usermod -d /home/varnish varnish' returned 8: usermod: user varnish is currently used by process 25547 [18:21:27] stephanebisson, what does the grep show: [18:21:28] grep varnish /etc/passwd [18:21:29] ? [18:21:55] varnish:x:1002:1002::/home/varnish: [18:21:55] varnishlog:x:112:119::/home/varnishlog:/bin/false [18:25:46] stephanebisson, for some the reason the shell isn't set, so it's trying to change that. Try: [18:26:01] sudo usermod -s /bin/false varnish [18:26:30] ok, and then? [18:26:46] provision. Gal is to get the user how it expects, so it doesn't think it needs to run a usermod call. [18:26:54] s/Gal/Goal [18:46:06] stephanebisson, let me know if it works this time. [18:46:20] matt_flaschen: All good. Thanks! [18:48:00] Great, no problem. :) [18:55:30] 6Collaboration-Team-Backlog, 10Flow: Change propagation for Flow - https://phabricator.wikimedia.org/T125857#2003226 (10Mattflaschen) [19:00:31] 6Collaboration-Team-Backlog, 10Flow: Change propagation for Flow - https://phabricator.wikimedia.org/T125857#2003264 (10Mattflaschen) >>! In T125857#2002563, @GWicke wrote: > We have a lot of infrastructure for 1), including the RESTBase update stuff & EventBus. If we could figure out that a specific page is a... [19:08:03] My first HHVM pull request: https://github.com/facebook/hhvm/issues/6303 [19:08:42] It fixes a bug in HHVM (inconsistent with standard PHP) with html_entity_decode that I discovered while troubleshooting unnecessary encoding I was seeing while debugging. [19:09:26] It turned out our code is actually broken, but HHVM was covering it up. I have a fix for that coming, too. [19:58:15] (03CR) 10Paladox: "recheck" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [20:05:44] (03PS1) 10Paladox: Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 [20:06:18] (03PS4) 10Paladox: Add composer test with just php-parallel-lint [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [20:06:35] (03CR) 10Paladox: "Remove Depends-On: I7e44d98c29ba9b9f5443665fc046382f696193c9 not needed since that was merged." [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [20:06:38] (03CR) 10jenkins-bot: [V: 04-1] Add composer test with just php-parallel-lint [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [20:09:09] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 (owner: 10Paladox) [20:09:49] (03PS2) 10Paladox: Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 [20:10:20] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 (owner: 10Paladox) [20:11:40] (03PS3) 10Paladox: Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 [20:12:00] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 (owner: 10Paladox) [20:16:00] (03PS4) 10Paladox: Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 [20:17:24] 3Collaboration-Team-Current: Show all New Icons on Notification Spreadsheet - https://phabricator.wikimedia.org/T123691#2003545 (10jmatazzoni) Declaring this closed. [20:17:57] 3Collaboration-Team-Current: Show all New Icons on Notification Spreadsheet - https://phabricator.wikimedia.org/T123691#2003548 (10jmatazzoni) 5Open>3Resolved [20:18:45] (03PS5) 10Paladox: Add composer test with just php-parallel-lint [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [20:21:51] (03CR) 10jenkins-bot: [V: 04-1] Add composer test with just php-parallel-lint [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [20:21:57] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 (owner: 10Paladox) [20:34:42] (03PS5) 10Paladox: Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 [20:36:58] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 (owner: 10Paladox) [20:45:09] 6Collaboration-Team-Backlog, 10Notifications: Echo notifications are cluttered - https://phabricator.wikimedia.org/T125936#2003660 (10kaldari) >I don't understand. By 'drop-downs' do you mean in a menu, like we have now? Are you saying you changed your mind, or am I misunderstanding? Yes, in menus like we have... [20:48:26] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review, and 2 others: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#2003672 (10jmatazzoni) The language in the screenshots above, with the double colons, is definitely wrong and should be fixed.... [20:56:34] 6Collaboration-Team-Backlog, 10Notifications: Echo notifications are cluttered - https://phabricator.wikimedia.org/T125936#2003699 (10Mattflaschen) >>! In T125936#2003660, @kaldari wrote: >>That is basically what the primary link (what you get when you click the notification itself) takes you to (that one key... [20:58:09] (03PS1) 10Mattflaschen: Disable two tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268792 [20:59:50] (03Abandoned) 10Mattflaschen: Disable two tests [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268792 (owner: 10Mattflaschen) [21:01:24] (03PS1) 10Mattflaschen: Fix default branch [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268796 [21:01:27] (03PS1) 10Mattflaschen: Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 [21:02:03] (03CR) 10Mattflaschen: "Worked around by disabling those two tests: https://gerrit.wikimedia.org/r/#/c/268797/" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [21:13:45] (03CR) 10jenkins-bot: [V: 04-1] Fix default branch [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268796 (owner: 10Mattflaschen) [21:14:19] (03CR) 10jenkins-bot: [V: 04-1] Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [21:19:31] (03PS2) 10Paladox: Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [21:20:55] (03CR) 10Paladox: "Thanks wikibase will only fail qunit tests on REL1_25 branch so I disabled it here https://gerrit.wikimedia.org/r/#/c/268790/" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [21:21:38] (03PS2) 10Paladox: Fix default branch [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268796 (owner: 10Mattflaschen) [21:22:41] (03PS3) 10Paladox: Fix default branch [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268796 (owner: 10Mattflaschen) [21:25:20] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review, and 2 others: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#2003861 (10SBisson) @jmatazzoni, @etonkovidova I'm removing the colons in `added to: Group1` and `member of: Group1`. > Notice... [21:26:06] (03CR) 10jenkins-bot: [V: 04-1] Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [21:26:37] (03CR) 10jenkins-bot: [V: 04-1] Fix default branch [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268796 (owner: 10Mattflaschen) [21:42:12] (03Abandoned) 10Mattflaschen: Fix default branch [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268796 (owner: 10Mattflaschen) [21:42:24] (03PS2) 10Mattflaschen: Change defaultbranch to REL1_25 in .gitreview in branch REL1_25 [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [21:42:29] (03CR) 10Paladox: Disable two tests (032 comments) [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [21:43:23] (03PS3) 10Mattflaschen: Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 [21:45:38] (03CR) 10jenkins-bot: [V: 04-1] Change defaultbranch to REL1_25 in .gitreview in branch REL1_25 [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [21:45:47] (03CR) 10jenkins-bot: [V: 04-1] Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [21:46:48] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review, and 2 others: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#2003945 (10jmatazzoni) A capital after the colon does appear to be Wikipedia style when the bit after the colon is a complete s... [21:47:57] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review, and 2 others: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#2003946 (10jmatazzoni) A capital after the colon does appear to be Wikipedia style when the bit after the colon is a complete s... [21:55:10] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Provide access to Notifications for anonymous users - https://phabricator.wikimedia.org/T58828#2003964 (10Jdforrester-WMF) [21:55:27] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Provide access to Notifications for anonymous users - https://phabricator.wikimedia.org/T58828#613252 (10Jdforrester-WMF) [21:55:29] 6Collaboration-Team-Backlog, 10Thanks, 7Community-Wishlist-Survey: Add ability to thank anonymous/IP users - https://phabricator.wikimedia.org/T63022#2003965 (10Jdforrester-WMF) [22:03:20] (03CR) 10Mattflaschen: Disable two tests (031 comment) [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [22:06:30] (03PS3) 10Mattflaschen: Change defaultbranch to REL1_25 in .gitreview in branch REL1_25 [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [22:07:09] (03PS4) 10Mattflaschen: Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 [22:10:40] (03CR) 10jenkins-bot: [V: 04-1] Change defaultbranch to REL1_25 in .gitreview in branch REL1_25 [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [22:14:26] (03CR) 10jenkins-bot: [V: 04-1] Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [22:15:51] (03PS3) 10Mattflaschen: Add script to populate rev_content_model for $wgFlowOccupyPages [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/260869 (https://phabricator.wikimedia.org/T105574) [22:19:14] (03CR) 10jenkins-bot: [V: 04-1] Add script to populate rev_content_model for $wgFlowOccupyPages [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/260869 (https://phabricator.wikimedia.org/T105574) (owner: 10Mattflaschen) [22:20:09] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004019 (10Mattflaschen) 3NEW [22:20:35] (03CR) 10Mattflaschen: "I think the remaining failures are all from Wikidata. Paladox found https://github.com/wikimedia/data-values-value-view/commit/7925b64b72" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [22:23:24] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004046 (10Paladox) Its really strange that this is causing wikid... [22:23:34] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004047 (10Mattflaschen) a:3Mattflaschen [22:24:17] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004019 (10Mattflaschen) >>! In T126073#2004046, @Paladox wrote:... [22:26:17] 3Collaboration-Team-Current, 10MediaWiki-extensions-Scribunto, 10Wikidata, 7HHVM, and 2 others: phpunit hhvm failure: LuaSandbox: TextLibraryTests[87]: json decode, invalid values (trailing comma) - https://phabricator.wikimedia.org/T103346#2004066 (10Mattflaschen) [22:26:27] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004067 (10Paladox) @Mattflaschen ok. Is there any way we could p... [22:27:03] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004068 (10Paladox) @Mattflaschen would you like me to do the ass... [22:30:38] (03CR) 10Paladox: "Thanks." [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [22:41:58] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004134 (10Mattflaschen) a:5Mattflaschen>3Paladox You can. I... [22:43:10] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004153 (10Mattflaschen) >>! In T126073#2004134, @Mattflaschen wr... [22:43:46] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004156 (10Paladox) @Mattflaschen ok will do it in a sec seems th... [22:54:48] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004197 (10Mattflaschen) [23:19:22] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004321 (10Mattflaschen) @Paladox Okay, I tried to figure out wha... [23:20:05] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004329 (10Mattflaschen) The other approach is to run whatever ve... [23:21:18] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004334 (10Paladox) @Mattflaschen I found a better solution we co... [23:22:13] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004335 (10Paladox) @Mattflaschen yes it is possible by using gru... [23:29:16] (03PS5) 10Paladox: Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [23:29:39] (03CR) 10jenkins-bot: [V: 04-1] Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [23:32:21] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004377 (10Mattflaschen) >>! In T126073#2004334, @Paladox wrote:... [23:33:17] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata QUnit broken on branch REL1_25 causing other extensions to fail - https://phabricator.wikimedia.org/T126073#2004383 (10Paladox) ValueView is not the only problem its repo, l... [23:33:57] (03PS6) 10Paladox: Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [23:34:08] (03PS7) 10Paladox: Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [23:34:21] (03CR) 10jenkins-bot: [V: 04-1] Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [23:34:33] (03CR) 10jenkins-bot: [V: 04-1] Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [23:36:59] (03PS6) 10Paladox: Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 [23:39:50] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 (owner: 10Paladox) [23:43:44] (03PS2) 10Mattflaschen: build: Updating development dependencies [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268034 [23:44:03] (03CR) 10jenkins-bot: [V: 04-1] build: Updating development dependencies [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268034 (owner: 10Mattflaschen) [23:44:41] (03PS7) 10Paladox: Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 [23:46:32] (03CR) 10jenkins-bot: [V: 04-1] Test [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 (owner: 10Paladox) [23:46:35] (03PS8) 10Paladox: Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [23:46:51] (03CR) 10Paladox: [C: 031] "Force merge this please." [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [23:47:08] (03CR) 10jenkins-bot: [V: 04-1] Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [23:48:14] (03PS4) 10Mattflaschen: Change defaultbranch to REL1_25 in .gitreview in branch REL1_25 [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [23:48:37] (03CR) 10jenkins-bot: [V: 04-1] Change defaultbranch to REL1_25 in .gitreview in branch REL1_25 [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [23:50:27] (03CR) 10Mattflaschen: [V: 032] "Changed my mind. Forcing it." [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [23:51:25] (03PS9) 10Mattflaschen: Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 [23:53:06] matt_flaschen: Wow. How much demand is there really for Flow on 1.25.x that you're spending this much effort? :-( [23:53:37] (03CR) 10jenkins-bot: [V: 04-1] Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [23:53:51] (And is there anything I can do to help?) [23:54:27] 6Collaboration-Team-Backlog, 10Thanks, 7Community-Wishlist-Survey: Add ability to thank anonymous/IP users - https://phabricator.wikimedia.org/T63022#2004481 (10DannyH) [23:54:54] James_F, it's an upgrade script. We say (https://www.mediawiki.org/wiki/Extension:Flow#Upgrading) "Before upgrading to 1.26 or later", run FlowUpdateRevContentModelFromOccupyPages.php. [23:54:58] James_F, which is kind of hard if that doesn't exist in REL1_25. [23:55:21] Ha. [23:55:21] Fair. [23:55:29] Yeah, it's taking too long, but also our release branches should work, and the problems are mostly not on Flow's side. We're actually fixing Wikidata too. [23:55:37] * James_F nods. [23:55:42] James_F, can you review and force-merge https://gerrit.wikimedia.org/r/#/c/268797/ ? [23:55:59] Since I wrote it and Paladox doesn't have +2. [23:57:02] (03CR) 10Paladox: "recheck" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268728 (owner: 10Paladox) [23:57:07] No composer file? [23:57:54] (03CR) 10Jforrester: [C: 032 V: 032] Disable two tests [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268797 (owner: 10Mattflaschen) [23:58:16] (Done.) [23:59:35] James_F, it has a composer.json, but not composer.json. That's fixed in https://gerrit.wikimedia.org/r/#/c/268033/5 , which you'll note fails with QUnit (partly Flow which will go away now, partly Wikidata). [23:59:42] James_F, I mean not composer test.