[00:14:20] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1996414 (10Mattflaschen) I'll keep this moving while Moriel is at linux.conf.au. [00:24:07] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review, and 2 others: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#1996448 (10Etonkovidova) Checked in betalabs and compared to specs in [[ https://docs.google.com/spreadsheets/d/1XjPO8RlrFMqNh... [00:28:37] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review, and 2 others: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#1996456 (10Etonkovidova) The email notification issue {T125584} is still present. [00:32:03] 3Collaboration-Team-Current, 10Thanks, 10Notifications: Cross-wiki notifications: Links for thanks notifications point to the local wiki - https://phabricator.wikimedia.org/T125738#1996470 (10Etonkovidova) I just checked it in beta - cross-wiki thanks worked correctly. [00:50:26] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Create new notification type for when a board description changes - https://phabricator.wikimedia.org/T125429#1996522 (10jmatazzoni) @matthiasmullie asks: > The proposed text for that currently says: "The description of PageName was edited multiple tim... [02:45:10] Heading out. See you tomorrow. [07:35:22] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-ContentTranslation, 10Notifications, 5ContentTranslation-Release8, 7WorkType-Maintenance: Special:ContentTranslation three-dots menu overflows the Notifications fly-out - https://phabricator.wikimedia.org/T124873#1996962 (10santhosh) Not dupe of {T12442... [07:41:11] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata broken on branch REL1_25 causing other extensions to fail. - https://phabricator.wikimedia.org/T125722#1996660 (10Anomie) >>! In T125722#1995833, @Paladox wrote: > Scribunto... [07:41:15] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata broken on branch REL1_25 causing other extensions to fail. - https://phabricator.wikimedia.org/T125722#1996662 (10Anomie) [07:57:16] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1996667 (10Mattflaschen) >>! In T121936#1989111, @Nikerabbit wrote: >>>! In T121936#1988798, @Mattflaschen wrote: >>>>! In T1219... [08:11:39] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Mention in topic title does not generate flow-mention notification - https://phabricator.wikimedia.org/T124794#1996691 (10Etonkovidova) Checked in betalabs. - New topic with [[User:username]] triggers flow-ment... [08:36:02] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata broken on branch REL1_25 causing other extensions to fail. - https://phabricator.wikimedia.org/T125722#1997021 (10Paladox) But why does it fail on REL1_25 branch but not on... [08:41:13] 3Collaboration-Team-Current, 10Thanks, 10Notifications: Cross-wiki notifications: Links for thanks notifications point to the local wiki - https://phabricator.wikimedia.org/T125738#1996722 (10Mattflaschen) a:5Mattflaschen>3None [09:28:45] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Generate flow-mention for create/edit of board desc, topic, post, summary - https://phabricator.wikimedia.org/T125427#1996632 (10jmatazzoni) @SBisson asks: > Note: maybe create specific language to differentiate between those 4 situations. Here's my t... [09:34:53] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Mention in topic title does not generate flow-mention notification - https://phabricator.wikimedia.org/T124794#1997119 (10matthiasmullie) Renaming indeed won't trigger a mention notification yet. That'll come so... [09:55:27] (03PS2) 10Matthias Mullie: Generate mentions for existing edit notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267909 (https://phabricator.wikimedia.org/T125427) [09:56:25] (03PS2) 10Matthias Mullie: Mentions are the primary notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267877 (https://phabricator.wikimedia.org/T125428) [09:56:35] (03PS2) 10Matthias Mullie: Allow certain users to be excluded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267876 (https://phabricator.wikimedia.org/T125428) [09:58:44] (03PS3) 10Matthias Mullie: Allow certain users to be excluded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267876 (https://phabricator.wikimedia.org/T125428) [09:59:20] (03CR) 10jenkins-bot: [V: 04-1] Mentions are the primary notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267877 (https://phabricator.wikimedia.org/T125428) (owner: 10Matthias Mullie) [10:01:00] (03CR) 10jenkins-bot: [V: 04-1] Generate mentions for existing edit notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267909 (https://phabricator.wikimedia.org/T125427) (owner: 10Matthias Mullie) [10:03:45] (03CR) 10jenkins-bot: [V: 04-1] Allow certain users to be excluded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267876 (https://phabricator.wikimedia.org/T125428) (owner: 10Matthias Mullie) [10:06:01] (03PS4) 10Matthias Mullie: Allow certain users to be excluded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267876 (https://phabricator.wikimedia.org/T125428) [10:12:12] (03CR) 10Legoktm: "Can we have constants instead of hardcoded strings please? looks good otherwise" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267876 (https://phabricator.wikimedia.org/T125428) (owner: 10Matthias Mullie) [10:21:06] (03PS5) 10Matthias Mullie: Allow certain users to be excluded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267876 (https://phabricator.wikimedia.org/T125428) [10:32:30] 3Collaboration-Team-Current: Show all New Icons on Notification Spreadsheet - https://phabricator.wikimedia.org/T123691#1997202 (10Pginer-WMF) >>! In T123691#1995746, @jmatazzoni wrote: > Pau, what about secondary link icons? I see a number on the spreadsheet still marked as TODO or ?? Should we add that to this... [10:44:36] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 7user-notice: Add excerpt of edit summary to reverted notification - https://phabricator.wikimedia.org/T121808#1997266 (10Johan) So wmf.11 was reverted and this wasn't included in wmf.12 (right?). It will be in wmf.13? [10:56:40] 6Collaboration-Team-Backlog, 10Notifications: Use updated trash icon on deletion-related notifications - https://phabricator.wikimedia.org/T125785#1997291 (10Pginer-WMF) 3NEW [11:20:21] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10MediaWiki-Special-pages: Introduce article creation log - https://phabricator.wikimedia.org/T12331#1997335 (10daniel) For the record, we do have log_user_text now, so recording page creation by anons is no longer a problem. [11:20:44] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10MediaWiki-Special-pages: Introduce article creation log - https://phabricator.wikimedia.org/T12331#1997336 (10daniel) [11:21:01] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10MediaWiki-Special-pages: Introduce article creation log - https://phabricator.wikimedia.org/T12331#147694 (10daniel) [11:50:50] 6Collaboration-Team-Backlog, 10MediaWiki-Patrolling, 10Notifications: Echo should provide notification when your revision/page/file is patrolled - https://phabricator.wikimedia.org/T123632#1997466 (10MGChecker) [11:50:52] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#1997465 (10MGChecker) [12:15:14] 6Collaboration-Team-Backlog, 10Flow, 10Notifications: Should get notified for topic summary change on your own user talk - https://phabricator.wikimedia.org/T125119#1997517 (10Pginer-WMF) I created a couple of example mockups to discuss. I assumed we can have a different message when there was a former summa... [12:20:27] 6Collaboration-Team-Backlog, 10Flow, 10Notifications: Notify when a topic is marked as resolved or reopened - https://phabricator.wikimedia.org/T125654#1997530 (10Pginer-WMF) I created a couple of example mockups to discuss, resolving and reopening (thanks @Mattflaschen for pointing to the complementary acti... [12:22:15] (03PS3) 10Matthias Mullie: Generate mentions for existing edit notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267909 (https://phabricator.wikimedia.org/T125427) [12:36:31] 6Collaboration-Team-Backlog, 10Flow, 10Notifications: Re-evaluate Flow user locators (who gets notified) for notifications - https://phabricator.wikimedia.org/T125121#1997549 (10matthiasmullie) 5Open>3Resolved a:3matthiasmullie Closing this. Stephane already created a bunch of new tickets that came out... [12:37:58] (03PS4) 10Matthias Mullie: Get rid of $legacyMapping [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263763 [12:38:22] (03PS6) 10Matthias Mullie: Deprecate ApiEchoNotifications.php format params flyout & html [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264718 [12:39:25] (03PS4) 10Matthias Mullie: Use current HTML formatter (for special page) instead of previous [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263764 [12:39:49] (03PS2) 10Matthias Mullie: Get rid of old flyout formatter code [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263788 [12:40:53] (03PS4) 10Matthias Mullie: If user only has foreign messages, the messages badge should not be suppressed [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266235 (https://phabricator.wikimedia.org/T124372) [12:43:31] (03PS2) 10Matthias Mullie: Add flow-description-edited notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268164 (https://phabricator.wikimedia.org/T125429) [12:44:38] (03CR) 10Matthias Mullie: [C: 04-1] Add flow-description-edited notification (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268164 (https://phabricator.wikimedia.org/T125429) (owner: 10Matthias Mullie) [12:49:26] (03PS2) 10Matthias Mullie: Add mention notification for changes in board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268165 (https://phabricator.wikimedia.org/T125427) [12:55:48] (03PS4) 10Matthias Mullie: Generate mentions for existing edit notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267909 (https://phabricator.wikimedia.org/T125427) [12:57:10] (03PS3) 10Matthias Mullie: Add flow-description-edited notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268164 (https://phabricator.wikimedia.org/T125429) [12:57:32] (03PS3) 10Matthias Mullie: Add mention notification for changes in board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268165 (https://phabricator.wikimedia.org/T125427) [13:07:53] (03CR) 10Siebrand: "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263788 (owner: 10Matthias Mullie) [13:09:44] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267909 (https://phabricator.wikimedia.org/T125427) (owner: 10Matthias Mullie) [13:17:13] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268164 (https://phabricator.wikimedia.org/T125429) (owner: 10Matthias Mullie) [14:05:05] 3Collaboration-Team-Current, 10Flow, 10Notifications: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#1997810 (10matthiasmullie) I don't think we should focus on moderation too much: there may also be other reasons why we would not want to render a... [15:16:54] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10MediaWiki-Special-pages: Introduce article creation log - https://phabricator.wikimedia.org/T12331#1998069 (10MZMcBride) >>! In T12331#1997335, @daniel wrote: > For the record, we do have log_user_text now, so recording page creation by anons is no longer a probl... [15:19:09] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 7user-notice: Add excerpt of edit summary to reverted notification - https://phabricator.wikimedia.org/T121808#1998071 (10SBisson) >>! In T121808#1997266, @Johan wrote: > So wmf.11 was reverted and this wasn't included in wmf.12 (right?). It... [15:24:22] 3Collaboration-Team-Current, 10Flow: Clicking Flow "new replies" notifications highlights only the most recent reply - https://phabricator.wikimedia.org/T124175#1998075 (10SBisson) You should now see the new message and new links for this kind of notification (multiple replies). Clicking on it should go to the... [15:25:21] (03PS4) 10Matthias Mullie: Add mention notification for changes in board description [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268165 (https://phabricator.wikimedia.org/T125427) [15:29:06] 3Collaboration-Team-Current, 10Flow: Clicking Flow "new replies" notifications highlights only the most recent reply - https://phabricator.wikimedia.org/T124175#1998091 (10Anomie) It seems to function. I have no opinion yet on the new messages. [15:32:51] 3Collaboration-Team-Current, 10Flow: Clicking Flow "new replies" notifications highlights only the most recent reply - https://phabricator.wikimedia.org/T124175#1998099 (10SBisson) 5Open>3Resolved >>! In T124175#1998091, @Anomie wrote: > It seems to function. I have no opinion yet on the new messages. Fai... [15:33:02] 6Collaboration-Team-Backlog, 10Flow: Clicking Flow "new replies" notifications highlights only the most recent reply - https://phabricator.wikimedia.org/T124175#1998103 (10SBisson) [16:03:44] 6Collaboration-Team-Backlog, 10Notifications: Notification link text overflows out of the main notification popup - https://phabricator.wikimedia.org/T125831#1998204 (10Glaisher) 3NEW [16:08:36] 6Collaboration-Team-Backlog, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Fatal error: Cannot redeclare class CallbackFilterIterator when linting (pre-deploy) on mira - https://phabricator.wikimedia.org/T124828#1998232 (10Aklapper) >>! In T124828#1968032, @dduvall wrote: > It... [16:19:58] 3Collaboration-Team-Current, 10Flow, 10Notifications: Remove Notifications about posts/topics that have been Moderated - https://phabricator.wikimedia.org/T93673#1998275 (10SBisson) >>! In T93673#1997810, @matthiasmullie wrote: > [...] The thing the notification was about may have been revoked/undone. Notif... [16:24:56] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review, and 2 others: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#1998285 (10SBisson) >>! In T121661#1996456, @Etonkovidova wrote: > The email notification issue {T125584} is still present. T... [16:29:06] stephanebisson: RE: “The thing the notification was about may have been revoked/undone.” [16:29:20] I mean this more like Flow’s “undo” after having hidden a topic [16:29:27] our undo still creates a “restore” revision [16:29:33] but that’s mostly for practical reasons [16:29:58] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Mention in topic title does not generate flow-mention notification - https://phabricator.wikimedia.org/T124794#1998309 (10Etonkovidova) Thx! Since the issue with renaming will be addressed in a different ticket... [16:29:59] ideally, that “undo” would not create a restore revision, but *actually* undo what you’ve just done :p [16:30:25] but coming back to notifications, if anything builds something like that, it should be smart enough to only send the notification when *undo time* is over [16:32:36] I'm sorry, I don't quite underrstand [16:34:17] sorry, let me try again :p [16:34:30] I’m taking Flow as an example [16:34:41] I thought undos were always new revisions in order to preserve the full history [16:34:55] ha [16:35:31] when hiding a topic, it is replaced by the collapsed topic, along with a “undo” link (that is no longer there when you refresh the page) [16:35:52] aahhh, I get it [16:36:23] like having a grace period in gmail where you can "undo" sending that drunk email... [16:36:35] the reason that “undo” link is there was that we wanted an easy way for people to “undo” what they did if they did it by mistake (= if they thought “hide” meant “ok, I’ve read this, get it out of my sight”, not “hide it for everyone”) [16:36:37] exactly [16:36:49] the way we implemented that was just lazy, it’s not a proper unhide [16:37:02] it's presented as a "undo" but it's like a delayed confirmation [16:37:09] indeed [16:37:29] but coming back to notifications, you could argue that whatever implements “undo” like that, should just delay sending the notification [16:37:39] so your argument is still valed then :p [16:37:40] valid* [16:38:02] I think that's a different feature, a nice one [16:38:23] but I have another question [16:38:25] “Formatters can try/catch presentation models and make sure to log and discard those who don't play nice. We don't have to rely on, or trust, canRender() for that.” [16:38:30] I’m not sure what you mean here? [16:38:57] where I was coming from is the notification count [16:39:11] right now, it’s very much possible to insert notifications that can’t even be rendered [16:39:22] because to render it, it needs data that is not there [16:39:26] yes, it's possible [16:39:33] so you would never see that, but the count would go up [16:39:40] that is something that should not even be possible, imo [16:39:45] but I think it is safer to actually try to render them than rely on canRender [16:39:53] ha [16:40:01] even if it is a insertion-time [16:40:06] ok, I see what you mean [16:40:12] yeah however we do it :p [16:40:26] if we're afraid of bugs... bugs can be in canRender [16:40:57] then again, if we’re try/catching, canRender is mostly useless anyway :p [16:41:06] true [16:41:24] things that are now invalid could throw a specific exception [16:41:41] but canRender is also a nice place to encapsulate that idea [16:41:48] canRender is probably mostly because of different error handling [16:42:02] php notices/warnings/errors, exceptions, Status, ... [16:42:46] 1 try/catch around the block wouldn’t work, everything needs to be validated in detail anyway :p [16:43:28] anyway, however we end up implementing that, it seems we agree unrenderable things shouldn’t even make it to DB [16:43:37] yes [16:54:57] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Create new notification type for when a board description changes - https://phabricator.wikimedia.org/T125429#1998378 (10jmatazzoni) @matthiasmullie also asks: > similar to other notifications, do we also want a different message if the description was... [16:57:40] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: email notification format for User rights changed displays placeholder label - https://phabricator.wikimedia.org/T125584#1998407 (10Etonkovidova) Verified the fix in betalabs: {F3310622} {F3310624} [17:00:27] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review, and 2 others: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#1998424 (10Etonkovidova) Verified {T125584} in betalabs - the fix looks great. [17:00:33] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Create new notification type for when a board description changes - https://phabricator.wikimedia.org/T125429#1998426 (10matthiasmullie) Actually, in code, `flowusertalk-post-edited` doesn't exist. It is just a flow-post-edited, rendered with that sligh... [17:24:21] 3Collaboration-Team-Current, 10Flow, 10Thanks, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Thank does not work if nested replies are present. - https://phabricator.wikimedia.org/T125168#1998559 (10Etonkovidova) Verified the fix in betalabs - 'Thank' for parent replies works. [17:33:41] 6Collaboration-Team-Backlog, 10MassMessage, 10Notifications, 5Patch-For-Review: Override user-talk Echo notification with something more MassMessage-specific - https://phabricator.wikimedia.org/T59234#1998601 (10MGChecker) [17:33:43] 6Collaboration-Team-Backlog, 10Notifications: Couple page link notification to watchlist - https://phabricator.wikimedia.org/T70060#1998600 (10MGChecker) [17:33:45] 6Collaboration-Team-Backlog, 10Notifications: Sitewide notifications through Echo - https://phabricator.wikimedia.org/T58361#1998603 (10MGChecker) [17:33:47] 6Collaboration-Team-Backlog, 10Notifications: Show Echo web notification (asking users to consider providing an email) to users who don't have an e-mail address associated with their account - https://phabricator.wikimedia.org/T58028#1998605 (10MGChecker) [17:33:49] 6Collaboration-Team-Backlog, 10Flow, 10Notifications: Allow users to create custom notifications onwiki - https://phabricator.wikimedia.org/T58362#1998602 (10MGChecker) [17:33:51] 6Collaboration-Team-Backlog, 10Notifications: Remind users who have entered an email address, but haven't confirmed it - https://phabricator.wikimedia.org/T58074#1998604 (10MGChecker) [17:33:53] 6Collaboration-Team-Backlog, 10Notifications, 7Easy: Echo should provide notifications when a redirect is converted into a non-redirect - https://phabricator.wikimedia.org/T56533#1998606 (10MGChecker) [17:33:55] 6Collaboration-Team-Backlog, 10Notifications: Notification when user becomes auto-confirmed - https://phabricator.wikimedia.org/T54690#1998608 (10MGChecker) [17:33:57] 6Collaboration-Team-Backlog, 10Notifications: Echo should provide notifications when a page created by the user is deleted - https://phabricator.wikimedia.org/T56532#1998607 (10MGChecker) [17:33:59] 6Collaboration-Team-Backlog, 10Notifications: Extend edit-user-talk notification to include edits to subpages of a user's talk page - https://phabricator.wikimedia.org/T5234#1998613 (10MGChecker) [17:34:01] 6Collaboration-Team-Backlog, 10MediaWiki-Email, 10Notifications: Send a notification when someone else edits your userpage - https://phabricator.wikimedia.org/T3876#1998614 (10MGChecker) [17:34:03] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#1998598 (10MGChecker) [17:34:05] 6Collaboration-Team-Backlog, 10Notifications: Support cross-wiki rights change notification in Echo - https://phabricator.wikimedia.org/T53540#1998611 (10MGChecker) [17:34:09] 6Collaboration-Team-Backlog, 10MediaWiki-Page-editing, 10Notifications: Notify user when username used in an edit summary - https://phabricator.wikimedia.org/T32750#1998612 (10MGChecker) [17:35:56] 6Collaboration-Team-Backlog, 10MediaWiki-Unit-tests, 10MediaWiki-extensions-AbuseFilter, 10Notifications: Notify SOMEONE that an abusefilter had a sudden increase in the number of logs - https://phabricator.wikimedia.org/T100892#1998640 (10MGChecker) [17:35:58] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#1998639 (10MGChecker) [17:36:10] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10MediaWiki-Special-pages: Introduce article creation log - https://phabricator.wikimedia.org/T12331#1998641 (10daniel) >>! In T12331#1998069, @MZMcBride wrote: > We also have a "Only show edits that are page creations" checkbox at 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Create new notification type for when a board description changes - https://phabricator.wikimedia.org/T125429#1998721 (10jmatazzoni) > flowusertalk-post-edited doesn't exist. OK, now you're messing with my mind. So the answer, I suppose, is that it... [17:55:24] 6Collaboration-Team-Backlog, 10Notifications: Notify when an article linked at at watched page is created - https://phabricator.wikimedia.org/T125847#1998736 (10MGChecker) 3NEW [17:56:48] 6Collaboration-Team-Backlog, 10Notifications: Notify when a page linked at a watched page is created - https://phabricator.wikimedia.org/T125847#1998756 (10MGChecker) [17:58:07] 6Collaboration-Team-Backlog, 10Notifications: Notify when a watched non-existent page is created - https://phabricator.wikimedia.org/T125849#1998764 (10MGChecker) 3NEW [17:58:28] 6Collaboration-Team-Backlog, 10Notifications: Notify when a watched non-existent page is created - https://phabricator.wikimedia.org/T125849#1998764 (10MGChecker) [17:58:30] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Create new types of notifications - https://phabricator.wikimedia.org/T125653#1998772 (10MGChecker) [17:58:32] 6Collaboration-Team-Backlog, 10Notifications: Notify when a page linked at a watched page is created - https://phabricator.wikimedia.org/T125847#1998736 (10MGChecker) [18:06:41] (03PS3) 10Addshore: Use WatchedItemStore from core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267682 [18:11:44] (03CR) 10jenkins-bot: [V: 04-1] Use WatchedItemStore from core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267682 (owner: 10Addshore) [18:13:03] (03PS4) 10Addshore: Use WatchedItemStore from core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267682 [18:18:20] (03PS4) 10Matthias Mullie: Add flow-description-edited notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/268164 (https://phabricator.wikimedia.org/T125429) [18:26:39] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Update Flow for Parsoid changes re data-mw - https://phabricator.wikimedia.org/T124837#1999022 (10Mattflaschen) [18:27:07] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Update Flow for Parsoid changes re data-mw - https://phabricator.wikimedia.org/T124837#1967531 (10Mattflaschen) After meeting, we decided to still talk to RESTbase: https://etherpad.wikimedia.org/p/Flow-Restbase-2016-02-04 [18:30:29] 6Collaboration-Team-Backlog, 10Flow: Change propagation for Flow - https://phabricator.wikimedia.org/T125857#1999050 (10Mattflaschen) 3NEW [18:32:00] (03PS5) 10Addshore: Use WatchedItemStore from core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267682 [18:38:11] 6Collaboration-Team-Backlog, 10Flow, 7Design: Visual design for new Flow indentation model - https://phabricator.wikimedia.org/T88865#1999075 (10qdinar) from my post in https://www.mediawiki.org/wiki/Topic:Senq838us190rqlp : ... adding: ... i wanted to make this (almost just a link) a sub-thread, (comment f... [18:39:11] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Generate flow-mention for create/edit of board desc, topic, post, summary - https://phabricator.wikimedia.org/T125427#1999078 (10matthiasmullie) Mention notification for topic title (+edits), post (+edits) & board description (+edits) is done. TODO: top... [18:39:39] 3Collaboration-Team-Current, 10Flow: Mentions in board description and topic summary don't generate flow-mention notifications - https://phabricator.wikimedia.org/T125120#1978916 (10matthiasmullie) Mention in board description has been fixed as part of T125427. Topic summary mentions remains to be done. [18:39:44] 3Collaboration-Team-Current, 10Flow: Mentions in board description and topic summary don't generate flow-mention notifications - https://phabricator.wikimedia.org/T125120#1999091 (10matthiasmullie) a:3matthiasmullie [18:41:03] 6Collaboration-Team-Backlog, 10Notifications, 7Browser-Support-Opera: Opening the notifications flyout fairly consistently crashes Opera 12 - https://phabricator.wikimedia.org/T125859#1999095 (10matmarex) 3NEW [18:41:21] 6Collaboration-Team-Backlog, 10Notifications, 10OOjs-UI, 10UI-Standardization, and 2 others: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1999105 (10Jdforrester-WMF) [18:41:42] 6Collaboration-Team-Backlog, 10Notifications, 10OOjs-UI, 10UI-Standardization, and 2 others: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1999106 (10Jdforrester-WMF) 5Open>3Resolved a:3Esanders [18:44:17] 6Collaboration-Team-Backlog, 10Notifications, 7Browser-Support-Opera: Opening the notifications flyout fairly consistently crashes Opera 12 - https://phabricator.wikimedia.org/T125859#1999118 (10matmarex) (It seems much easier to reproduce when I have new notifications than when I don't, but I don't think it... [18:48:23] matt_flaschen: do you think we should swat this out: https://gerrit.wikimedia.org/r/#/c/268104/ ? [18:50:50] stephanebisson, yeah. It only affects one of the current release branches, and it's not essential (these events don't happen that often), but it would be nice. [18:50:52] I'll list it. [18:51:22] matt_flaschen: can you babysit it? [18:51:37] stephanebisson, yep. [18:52:07] to test it effectively, you need email notifications for user-rights and someone to add/remove groups for you [18:53:36] stephanebisson, yeah, I'm an admin on MediaWiki.org (one of the affected sites). So I can get someone to add/remove one of the groups admin implies but I don't actually have. [18:54:35] 6Collaboration-Team-Backlog, 10ArchCom-RfC, 10MediaWiki-Special-pages: Introduce article creation log - https://phabricator.wikimedia.org/T12331#1999186 (10Spinningspark) Yes, page moves are really cluttering that list on my contributions too. For the same reason, it would be handy if creation of redirects... [18:54:56] 6Collaboration-Team-Backlog, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q1. New model for indentation (French, Catalan) - https://phabricator.wikimedia.org/T88501#1999189 (10qdinar) i comment, because it is not clear to me from texts in this page that the interface texts shown in... [18:55:13] The release branches are weird right now. enwiki is on 1.27.0-wmf.10, MediaWiki.org and others are on 1.27.0-wmf.12, and for some reason both wmf/1.27.0-wmf.12 and wmf/1.27.0-wmf12 exist. [18:55:35] greg-g, is there going to be train movement today? I know the schedule is unusual, but I forget what it is. [18:55:58] (03PS1) 10Mattflaschen: Bring back user-rights lego messages [extensions/Echo] (wmf/1.27.0-wmf.12) - 10https://gerrit.wikimedia.org/r/268439 (https://phabricator.wikimedia.org/T125584) [18:56:30] matt_flaschen: yep, normal day today, wmf.12 to group2 (everywhere) [18:58:06] Okay, all the more reason then. [18:59:56] 6Collaboration-Team-Backlog, 10Notifications, 10OOjs-UI, 10UI-Standardization, and 2 others: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1999211 (10Jdforrester-WMF) [19:06:00] 3Collaboration-Team-Current, 10Notifications: Remove unused Echo code - https://phabricator.wikimedia.org/T125861#1999234 (10matthiasmullie) 3NEW a:3matthiasmullie [19:06:21] (03CR) 10Sbisson: [C: 032] Allow certain users to be excluded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267876 (https://phabricator.wikimedia.org/T125428) (owner: 10Matthias Mullie) [19:24:50] (03Merged) 10jenkins-bot: Allow certain users to be excluded [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267876 (https://phabricator.wikimedia.org/T125428) (owner: 10Matthias Mullie) [19:26:12] (03CR) 10Sbisson: [C: 032] Mentions are the primary notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267877 (https://phabricator.wikimedia.org/T125428) (owner: 10Matthias Mullie) [19:27:07] 6Collaboration-Team-Backlog, 10Flow, 7Design: Visual design for new Flow indentation model - https://phabricator.wikimedia.org/T88865#1999353 (10DannyH) [19:36:53] (03Merged) 10jenkins-bot: Mentions are the primary notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267877 (https://phabricator.wikimedia.org/T125428) (owner: 10Matthias Mullie) [19:37:18] (03CR) 10Sbisson: [C: 032] Deprecate ApiEchoNotifications.php format params flyout & html [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264718 (owner: 10Matthias Mullie) [19:55:22] (03CR) 10Sbisson: [C: 031] "Looks good and works fine." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267909 (https://phabricator.wikimedia.org/T125427) (owner: 10Matthias Mullie) [19:55:36] (03Merged) 10jenkins-bot: Deprecate ApiEchoNotifications.php format params flyout & html [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264718 (owner: 10Matthias Mullie) [19:57:09] (03PS5) 10Sbisson: Get rid of $legacyMapping [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263763 (owner: 10Matthias Mullie) [19:58:14] (03PS5) 10Matthias Mullie: Generate mentions for existing edit notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267909 (https://phabricator.wikimedia.org/T125427) [20:02:58] (03CR) 10Sbisson: [C: 032] Get rid of $legacyMapping [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263763 (owner: 10Matthias Mullie) [20:03:22] (03PS5) 10Sbisson: Use current HTML formatter (for special page) instead of previous [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263764 (owner: 10Matthias Mullie) [20:15:57] oh [20:16:20] (03Merged) 10jenkins-bot: Get rid of $legacyMapping [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263763 (owner: 10Matthias Mullie) [20:16:26] 3Collaboration-Team-Current, 10MediaWiki-extensions-BounceHandler, 10Notifications: Update BounceHandler notifications to new language and format - https://phabricator.wikimedia.org/T125713#1999561 (10SBisson) 5Open>3Invalid a:3SBisson No changes in the spreadsheet. [20:16:37] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-BounceHandler, 10Notifications: Update BounceHandler notifications to new language and format - https://phabricator.wikimedia.org/T125713#1999564 (10SBisson) [20:20:17] 6Collaboration-Team-Backlog, 10Flow, 7Wikimedia-log-errors: Flow\Data\Storage\BasicDbStorage::find Unknown column 'workflow_last_update_timestamp' in 'order clause' - https://phabricator.wikimedia.org/T125872#1999591 (10hashar) 3NEW [20:20:52] so the poor Flow\Data\Storage\BasicDbStorage::find method on mediawikiwiki reports an unknown column workflow_last_update_timestamp on the database flowdb :( [20:23:21] 6Collaboration-Team-Backlog, 10Flow, 7Wikimedia-log-errors: Flow\Data\Storage\BasicDbStorage::find Unknown column 'workflow_last_update_timestamp' in 'order clause' - https://phabricator.wikimedia.org/T125872#1999627 (10hashar) 49 events over two days. Some other packages impacted but all on `mediawikiwiki`.... [20:26:55] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10Notifications: Update PageTriage notifications to new language and format - https://phabricator.wikimedia.org/T125693#1999648 (10SBisson) a:3SBisson [20:42:33] matt_flaschen: do you know if we can Thank a user directly or is it always for an edit? [20:43:00] stephanebisson, always for an edit or Flow post. [20:43:02] 6Collaboration-Team-Backlog, 10Flow: Clicking Flow "new replies" notifications highlights only the most recent reply - https://phabricator.wikimedia.org/T124175#1999732 (10Whatamidoing-WMF) @Catrope: Yes, Safari drops the fragment (the part after the #) from redirect URLs. Example: I received "thanks" for... [20:43:27] thanks [20:43:38] (for your edit in irc) [20:43:43] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Create new notification type for when a board description changes - https://phabricator.wikimedia.org/T125429#1999735 (10jmatazzoni) The language, icons and links for this have been documented as of today in the spreadsheet [[ https://docs.google.com/s... [20:46:21] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata broken on branch REL1_25 causing other extensions to fail. - https://phabricator.wikimedia.org/T125722#1999759 (10Mattflaschen) >>! In T125722#1997021, @Paladox wrote: > But... [20:49:03] (03CR) 10Luke081515: [C: 04-1] "Please rebase again:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263788 (owner: 10Matthias Mullie) [20:50:34] greg-g, do you know why when I try to "git review" from some release branches, it fails because the master has been closed (! [remote rejected] HEAD -> refs/publish/master/268473 (change 219550 closed)) [20:50:50] I can work around it by changing defaultbranch, but is that just a bug in the branch setup, or am I missing something? [20:55:18] (03PS2) 10Paladox: Add composer test with just php-parallel-lint [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [20:59:34] (03CR) 10jenkins-bot: [V: 04-1] Add composer test with just php-parallel-lint [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268033 (owner: 10Mattflaschen) [21:00:11] 3Collaboration-Team-Current, 10Flow, 7Wikimedia-log-errors: Fail to load more topics above current topic due to psuedo-column being queried - https://phabricator.wikimedia.org/T121644#1999839 (10Mattflaschen) [21:00:29] 6Collaboration-Team-Backlog, 10Flow, 7Wikimedia-log-errors: Flow\Data\Storage\BasicDbStorage::find Unknown column 'workflow_last_update_timestamp' in 'order clause' - https://phabricator.wikimedia.org/T125872#1999842 (10Mattflaschen) [21:00:31] 3Collaboration-Team-Current, 10Flow, 7Wikimedia-log-errors: Fail to load more topics above current topic due to psuedo-column being queried - https://phabricator.wikimedia.org/T121644#1884567 (10Mattflaschen) [21:01:44] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Rephrase Flow notifications, move content from body into header - https://phabricator.wikimedia.org/T121950#1999853 (10jmatazzoni) NOTE: the proposed Flow notification language and links at the top of this ticke... [21:04:11] 6Collaboration-Team-Backlog, 10Flow: Change propagation for Flow - https://phabricator.wikimedia.org/T125857#1999869 (10Mattflaschen) [21:04:28] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Changes in templates are not immediately reflected in Flow posts which transclude those templates - https://phabricator.wikimedia.org/T59991#1999874 (10Mattflaschen) [21:04:30] 6Collaboration-Team-Backlog, 10Flow: Change propagation for Flow - https://phabricator.wikimedia.org/T125857#1999050 (10Mattflaschen) [21:04:43] 6Collaboration-Team-Backlog, 10Flow: If a template is deleted, the text is still shown - https://phabricator.wikimedia.org/T60012#1999877 (10Mattflaschen) [21:04:45] 6Collaboration-Team-Backlog, 10Flow: Change propagation for Flow - https://phabricator.wikimedia.org/T125857#1999050 (10Mattflaschen) [21:05:03] 6Collaboration-Team-Backlog, 10Flow: Header area should automatically update transcluded templates - https://phabricator.wikimedia.org/T90070#1999882 (10Mattflaschen) [21:05:05] 6Collaboration-Team-Backlog, 10Flow: Change propagation for Flow - https://phabricator.wikimedia.org/T125857#1999050 (10Mattflaschen) [21:05:37] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase, 5Patch-For-Review: Switch Flow from ExternalStore to RESTBase - https://phabricator.wikimedia.org/T94574#1167306 (10Mattflaschen) [21:05:40] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Changes in templates are not immediately reflected in Flow posts which transclude those templates - https://phabricator.wikimedia.org/T59991#602434 (10Mattflaschen) [21:05:49] (03PS1) 10Paladox: Add jsduck and support rake [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268484 [21:06:56] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase, 5Patch-For-Review: Switch Flow from ExternalStore to RESTBase - https://phabricator.wikimedia.org/T94574#1999895 (10Mattflaschen) See {T125857} for the canonical task about the actual problem here. [21:07:19] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10RESTBase, 5Patch-For-Review: Switch Flow from ExternalStore to RESTBase - https://phabricator.wikimedia.org/T94574#1999897 (10Mattflaschen) [21:07:40] (03CR) 10jenkins-bot: [V: 04-1] Add jsduck and support rake [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268484 (owner: 10Paladox) [21:09:11] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Switch Flow storage to store a pagebundle blob instead of HTML - https://phabricator.wikimedia.org/T125885#1999900 (10Mattflaschen) 3NEW [21:09:45] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Run migration script (HTML => wikitext => page bundle) in production - https://phabricator.wikimedia.org/T125886#1999907 (10Mattflaschen) 3NEW [21:10:30] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Write migration script (HTML => wikitext => page bundle) in production - https://phabricator.wikimedia.org/T125888#1999921 (10Mattflaschen) 3NEW [21:11:57] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Switch Flow storage to store a pagebundle blob instead of HTML - https://phabricator.wikimedia.org/T125885#1999929 (10Mattflaschen) [21:13:30] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Update code (extractors, converters) that uses data-mw to deal with separate components - https://phabricator.wikimedia.org/T125889#1999940 (10Mattflaschen) 3NEW [21:13:33] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10Notifications: Update PageTriage notifications to new language and format - https://phabricator.wikimedia.org/T125693#1999947 (10jmatazzoni) There was a proposal that we add a link to Thank the users who reviewed pages, but Stephane doesn't... [21:15:10] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10VisualEditor: Figure out how to get page bundle from Flow VE - https://phabricator.wikimedia.org/T125890#1999951 (10Mattflaschen) 3NEW [21:16:32] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Switch Flow storage to store a page bundle blob instead of HTML - https://phabricator.wikimedia.org/T125885#1999971 (10Mattflaschen) [21:20:56] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 10Continuous-Integration-Infrastructure, and 2 others: Wikidata broken on branch REL1_25 causing other extensions to fail. - https://phabricator.wikimedia.org/T125722#1999988 (10Paladox) Thanks. [21:21:05] 6Collaboration-Team-Backlog, 10Flow, 7Design: Make topic title a link to the Topic page - https://phabricator.wikimedia.org/T89783#1999991 (10Mattflaschen) 5Open>3declined This is no longer feasible (without inconsistencies and confusion) now that we allow wikilinks in topic title. [21:22:58] 6Collaboration-Team-Backlog, 10Flow: Investigate usability of dot-dot-dot menu (...) - https://phabricator.wikimedia.org/T125893#2000001 (10Mattflaschen) 3NEW [21:29:55] matt_flaschen: probably get a knowledgeable response in -releng :) [21:33:31] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10Notifications: Update PageTriage notifications to new language and format - https://phabricator.wikimedia.org/T125693#2000035 (10Mattflaschen) >>! In T125693#1999947, @jmatazzoni wrote: > There was a proposal that we add a link to Thank the... [21:46:37] (03Abandoned) 10Paladox: Add jsduck and support rake [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268484 (owner: 10Paladox) [22:03:47] (03PS1) 10Paladox: Change defaultbranch to REL1_25 in .gitreview in branch REL1_25 [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 [22:07:20] (03CR) 10jenkins-bot: [V: 04-1] Change defaultbranch to REL1_25 in .gitreview in branch REL1_25 [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [22:27:37] 6Collaboration-Team-Backlog, 10Notifications: cross-wiki Notifications: short and long Notifications - https://phabricator.wikimedia.org/T124973#2000296 (10Etonkovidova) Re-checked when testing {T121822} - long title are truncated now and there is more info when reply/edit are done. [22:29:59] 6Collaboration-Team-Backlog, 10Collaboration-Team-Sprint-Q-2015-02-25, 10Flow, 5Patch-For-Review: Q1. New model for indentation (French, Catalan) - https://phabricator.wikimedia.org/T88501#2000309 (10Mattflaschen) >>! In T88501#1999189, @qdinar wrote: > i comment, because it is not clear to me from texts i... [22:33:39] 6Collaboration-Team-Backlog, 10Flow: Clicking Flow "new replies" notifications highlights only the most recent reply - https://phabricator.wikimedia.org/T124175#2000322 (10Whatamidoing-WMF) The Safari problem is {T124108} [22:36:49] 6Collaboration-Team-Backlog, 10Notifications: cross-wiki Notifications: short and long Notifications - https://phabricator.wikimedia.org/T124973#2000350 (10Etonkovidova) 5Open>3Resolved [22:53:15] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 10Notifications: Update PageTriage notifications to new language and format - https://phabricator.wikimedia.org/T125693#2000368 (10jmatazzoni) Thanks Matt. In the end, Stephane clarified that we can't do Thanks easily for pagetriage-mark-as-re... [22:54:56] 6Collaboration-Team-Backlog, 10Notifications: [minor] Notificaiton panel layout issues for multiline messages - https://phabricator.wikimedia.org/T125909#2000378 (10Etonkovidova) 3NEW [23:14:14] (03CR) 10Mattflaschen: [C: 032] "+2 to this specific issue. But it won't merge until the other issues are fixed." [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [23:17:20] (03CR) 10Paladox: "You can v+2 since this change will not break anything." [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [23:23:28] (03CR) 10jenkins-bot: [V: 04-1] Change defaultbranch to REL1_25 in .gitreview in branch REL1_25 [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [23:31:45] (03CR) 10Mattflaschen: [V: 032] Change defaultbranch to REL1_25 in .gitreview in branch REL1_25 [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [23:45:55] I just realized I hit a HHVM/PHP5 inconsistency in htmlToPlaintext. [23:45:57] Isolating... [23:47:55] (03CR) 10Paladox: "@Mattflaschen please re c+2 and re v+2." [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [23:51:13] (03CR) 10Mattflaschen: [C: 032 V: 032] "I don't know if this works or if it just ignores human V+2." [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox) [23:51:41] vagrant@mediawiki-vagrant:~$ php -r 'echo phpversion() . "\n"; echo html_entity_decode( strip_tags( "I'll try this again\n" ) );' [23:51:42] 5.6.99-hhvm [23:51:44] I'll try this again [23:51:45] vagrant@mediawiki-vagrant:~$ php5 -r 'echo phpversion() . "\n"; echo html_entity_decode( strip_tags( "I'll try this again\n" ) );' [23:51:47] 5.5.9-1ubuntu4.14 [23:51:48] I'll try this again [23:53:26] https://github.com/facebook/hhvm/issues/6303 [23:54:24] (03CR) 10jenkins-bot: [V: 04-1] Change defaultbranch to REL1_25 in .gitreview in branch REL1_25 [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/268567 (owner: 10Paladox)