[00:13:36] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Unbalanced space in bundled cross-wiki notifications - https://phabricator.wikimedia.org/T124023#1980375 (10Etonkovidova) Checked in betalabs. {F3289485} [01:45:15] 6Collaboration-Team-Backlog, 10Notifications: Research: How Many Users Get a Lot of Notifications? - https://phabricator.wikimedia.org/T125180#1980620 (10jmatazzoni) [01:47:49] 3Collaboration-Team-Current, 10Notifications: Research: How Many Users Get a Lot of Notifications? - https://phabricator.wikimedia.org/T125180#1980625 (10jmatazzoni) a:3Neil_P._Quinn_WMF [02:26:25] 3Collaboration-Team-Current, 6Editing-Analysis, 10Notifications: Research: How Many Users Get a Lot of Notifications? - https://phabricator.wikimedia.org/T125180#1980682 (10Neil_P._Quinn_WMF) [02:48:42] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 6 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1980700 (10mobrovac) [04:24:25] 6Collaboration-Team-Backlog, 10MoodBar, 3Google-Code-In-2015, 7I18n, and 2 others: Add GENDER support to MediaWiki:Moodbar-log-hide and friends - https://phabricator.wikimedia.org/T45481#1980779 (10MtDu) a:3MtDu Closing as resolved. [04:24:31] 6Collaboration-Team-Backlog, 10MoodBar, 3Google-Code-In-2015, 7I18n, and 2 others: Add GENDER support to MediaWiki:Moodbar-log-hide and friends - https://phabricator.wikimedia.org/T45481#1980781 (10MtDu) 5Open>3Resolved [04:42:54] 6Collaboration-Team-Backlog, 10Notifications, 5Patch-For-Review: Adjust the mark as read "X" icon size - https://phabricator.wikimedia.org/T124025#1980820 (10MtDu) When someone gets a chance, this patch is in need of review. Thanks! MtDu [09:21:47] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed. Nice work." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267044 (https://phabricator.wikimedia.org/T121661) (owner: 10Sbisson) [09:22:56] (03CR) 10Siebrand: Add GENDER support to tooltip messages (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266988 (owner: 10MtDu) [10:20:03] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement: Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#1981086 (10Trizek-WMF) Good question... What about people who hate VE and don't want to hear about it, but like Notifications? (I pick t... [11:38:57] (03CR) 10Matthias Mullie: [C: 031] "Looks good. Feel free to merge if you disagree with the suggestion." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265177 (https://phabricator.wikimedia.org/T56433) (owner: 10Sbisson) [11:44:19] (03CR) 10Sbisson: Rephrase mention notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265177 (https://phabricator.wikimedia.org/T56433) (owner: 10Sbisson) [11:49:06] 6Collaboration-Team-Backlog, 10Flow, 6operations: Flow messages are not editable and new topics can't be posted (API outage) - https://phabricator.wikimedia.org/T125080#1981245 (10mark) 5Open>3Resolved a:3mark We have no indication that anything is wrong other than some brief effects shortly after the... [11:59:43] (03CR) 10Matthias Mullie: "coding standards nitpick. looks good otherwise" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265495 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [12:04:43] (03PS4) 10Sbisson: Rephrase mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265177 (https://phabricator.wikimedia.org/T56433) [12:04:46] (03PS4) 10Sbisson: Truncate usernames, titles and excerpts in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265495 (https://phabricator.wikimedia.org/T121822) [12:05:07] (03CR) 10Sbisson: Truncate usernames, titles and excerpts in notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265495 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [12:05:40] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement: Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#1981256 (10Elitre) I for one don't care much about //all// the things-Editing. For existing products, much of the interest depends on s... [12:10:34] (03CR) 10jenkins-bot: [V: 04-1] Rephrase mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265177 (https://phabricator.wikimedia.org/T56433) (owner: 10Sbisson) [12:12:28] (03CR) 10Sbisson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265177 (https://phabricator.wikimedia.org/T56433) (owner: 10Sbisson) [13:31:54] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration: the green "reviewed" icon sometimes does not show upon page load - https://phabricator.wikimedia.org/T43279#1981404 (10Ironholds) [13:32:10] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration: Parameter missing from "deleted after a previous deletion discussion" - https://phabricator.wikimedia.org/T43913#1981405 (10Ironholds) [13:32:23] 6Collaboration-Team-Backlog, 10Notifications: All notifications… is sometimes unnecessary - https://phabricator.wikimedia.org/T44074#1981407 (10Ironholds) [13:33:47] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration: PageTriage: error appearing as edit summary - https://phabricator.wikimedia.org/T46752#1981413 (10Ironholds) [13:35:07] 6Collaboration-Team-Backlog, 10Flow: Flow: events not showing up in Special:Contributions - https://phabricator.wikimedia.org/T59868#1981425 (10Ironholds) [13:40:51] stephanebisson: about the i18n params [13:41:15] I’m not sure it’s something other also do, but I definitely have added redundant params before [13:41:22] not all too often, but it has happened [13:41:46] mostly when I expect a message may be changed at some point (and this one has changed a couple of times already) [13:42:05] because it gets annoying having to change the i18n message string, just because you need yet another param in there [13:42:45] I wouldn't want to be the one retranslating them all the time... [13:43:02] thats why I’d just add the title for that msg as well - just in case we ever change our minds again (or someone else does - every wiki can override every message) [13:43:25] but if you’d rather not add that useless param, I’m not going to fight it [13:43:41] it was just a trivial remark & rest of the code looks fine & I’ll +2 it anyway :p [13:43:42] I'm not sure... [13:44:09] doing something "for the future" is almost always wrong in my experience [13:45:04] but I really don't know what's the guideline in terms of allowing other languages to make different messages by providing more args [13:46:07] I’d do it more for consistency with the other messages (the “for the future” part is that I expect all of them, or none of them to change at some point, and having them all have the same params would be more straightforward) [13:46:10] in a way, I wish all relevant information was available for all messages (maybe in key-value pair instead of positional) so they have a lot of flexibility for creating messages [13:46:16] but you’re right arbout “for the future” always being wrong :) [13:46:43] I don’t think there are guidelines for letting others change messages (other than GENDER stuff etc) [13:46:50] but that goes against consistency across languages [13:47:36] it’s more of a “it happens in rare cases where an exact copy of the original message doesn’t make sense”, I think - usually translations should just be the same [13:48:44] do we have a good feedback chanel for translators to say "I can't translate it, please add arg X"? [13:49:03] I wouldn’t call it good, but it exists [13:49:37] people can post things on translatewiki, about specific messages and why they’re unable to translate them [13:49:53] siebrand make sure someone relevant sees them at some point :p [13:51:05] e.g. https://translatewiki.net/wiki/Thread:Support/About_MediaWiki:Apihelp-flow%2Bview-topiclist-param-limit/sv#About_[[MediaWiki:Apihelp-flow+view-topiclist-param-limit/sv]]_45116 [13:51:52] stephanebisson: I’ll just merge that patch as-is, ok? [13:51:54] LQT OMG [13:52:02] :) [13:52:04] sure, thanks [13:52:13] (03CR) 10Matthias Mullie: [C: 032] Rephrase mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265177 (https://phabricator.wikimedia.org/T56433) (owner: 10Sbisson) [13:52:22] (03CR) 10Matthias Mullie: [C: 032] Truncate usernames, titles and excerpts in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265495 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [13:54:47] (03PS4) 10Sbisson: Truncate page titles and topic titles in notifications header message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265521 (https://phabricator.wikimedia.org/T121822) [14:00:31] (03Merged) 10jenkins-bot: Rephrase mention notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265177 (https://phabricator.wikimedia.org/T56433) (owner: 10Sbisson) [14:01:07] (03CR) 10Matthias Mullie: [C: 032] Dry run for external store [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265524 (https://phabricator.wikimedia.org/T119566) (owner: 10Mattflaschen) [14:07:32] (03CR) 10Matthias Mullie: [C: 032] Truncate page titles and topic titles in notifications header message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265521 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [14:09:25] (03Merged) 10jenkins-bot: Truncate usernames, titles and excerpts in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265495 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [14:11:58] (03CR) 10Matthias Mullie: "Maybe add some "or try again later if the problem persists" or "please file a bug", so users know it's not necessarily a problem on their " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265703 (owner: 10IoannisKydonis) [14:14:46] (03CR) 10Matthias Mullie: "Do we want to push forward with this cherry-pick into 1.25, or can we abandon this?" [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/260869 (https://phabricator.wikimedia.org/T105574) (owner: 10Mattflaschen) [14:24:25] (03CR) 10Nemo bis: "Good idea. Then details like "for Parsoid conversion" can be dropped too." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265703 (owner: 10IoannisKydonis) [14:26:31] (03Merged) 10jenkins-bot: Dry run for external store [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265524 (https://phabricator.wikimedia.org/T119566) (owner: 10Mattflaschen) [14:26:34] (03Merged) 10jenkins-bot: Truncate page titles and topic titles in notifications header message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265521 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [14:37:10] (03PS3) 10IoannisKydonis: Simplify flow-error-parsoid-failure for end users. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265703 [14:50:21] 6Collaboration-Team-Backlog, 10Flow: Flow: & in wikilink triggers exception, Flow doesn't render - https://phabricator.wikimedia.org/T60455#1981569 (10Ironholds) [14:50:34] 6Collaboration-Team-Backlog, 10Flow, 6Security: Flow: Can bypass any protection and blank pages - https://phabricator.wikimedia.org/T62218#1981571 (10Ironholds) [14:52:03] 6Collaboration-Team-Backlog, 10Flow: Flow: "fetchSubtreeNodeList() on a non-object" errors viewing history of some topics - https://phabricator.wikimedia.org/T62417#1981576 (10Ironholds) [14:52:32] 6Collaboration-Team-Backlog, 10Flow: Flow not respecting spam blacklist on mediawiki.org - https://phabricator.wikimedia.org/T61755#1981578 (10Ironholds) [14:52:43] 6Collaboration-Team-Backlog, 10Notifications: Fatal error at https://en.wikipedia.org/wiki/Special:Notifications - https://phabricator.wikimedia.org/T62985#1981581 (10Ironholds) [15:29:44] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-WikibaseRepository, 10Notifications, 10Wikidata: Revert notifications in Echo on Wikidata should display label as well as Q id - https://phabricator.wikimedia.org/T116762#1981680 (10Sjoerddebruin) Not sure if I need to make another task, but there are als... [15:32:22] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 7Voice & Tone, and 2 others: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#1981683 (10matej_suchanek) @Sbisson Does parameter $4 in `notification-header... [16:09:38] (03PS1) 10Sbisson: Support GENDER in mention-on-user-talk messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267266 (https://phabricator.wikimedia.org/T56433) [16:12:48] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 7Voice & Tone, and 2 others: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#1981716 (10SBisson) >>! In T56433#1981683, @matej_suchanek wrote: > @Sbisson... [16:13:53] (03PS2) 10Sbisson: Support GENDER in mention-on-user-talk messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267266 (https://phabricator.wikimedia.org/T56433) [16:19:18] (03PS3) 10Sbisson: Support GENDER in mention-on-user-talk messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267266 (https://phabricator.wikimedia.org/T56433) [16:20:06] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#1981739 (10matthiasmullie) "You are now a member of the X, Y and Z group" implies that the groups mentioned are *all* those that you belong t... [16:21:33] (03CR) 10Matthias Mullie: [C: 032] Fix lego messages in 'user-rights' notification (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267044 (https://phabricator.wikimedia.org/T121661) (owner: 10Sbisson) [16:30:08] (03Merged) 10jenkins-bot: Fix lego messages in 'user-rights' notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267044 (https://phabricator.wikimedia.org/T121661) (owner: 10Sbisson) [16:34:18] (03CR) 10Matthias Mullie: [C: 032] Support GENDER in mention-on-user-talk messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267266 (https://phabricator.wikimedia.org/T56433) (owner: 10Sbisson) [16:37:19] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 7Voice & Tone, and 2 others: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#1981818 (10Nemo_bis) Nice to see some i18n love in this area! [16:47:26] (03Merged) 10jenkins-bot: Support GENDER in mention-on-user-talk messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267266 (https://phabricator.wikimedia.org/T56433) (owner: 10Sbisson) [18:22:54] (03PS1) 10Sbisson: Truncate titles in messages [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/267291 (https://phabricator.wikimedia.org/T121822) [18:32:05] Trying to join, the wifi here is dicey, thogh. [18:34:32] Hey matt_flaschen. [18:38:26] matt_flaschen, are you there? You look like you're there but you're not responding [19:30:02] 3Collaboration-Team-Current, 10Flow, 10Thanks: Thank does not work if nested replies are present. - https://phabricator.wikimedia.org/T125168#1982512 (10SBisson) p:5Triage>3High a:3SBisson [19:30:12] (03PS1) 10Sbisson: Fix Flow thank of post with descendents [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/267305 (https://phabricator.wikimedia.org/T125168) [19:39:46] 6Collaboration-Team-Backlog, 10MediaWiki-Vagrant, 10Notifications, 15User-bd808: ::role::echo uses scoped variables instead of hiera for default settings - https://phabricator.wikimedia.org/T125152#1982572 (10Jdforrester-WMF) [19:50:51] 6Collaboration-Team-Backlog, 10Notifications, 7I18n, 7Voice & Tone: Some Echo issues of GENDER and untranslatability - https://phabricator.wikimedia.org/T63904#1982585 (10Quiddity) [20:26:01] (03PS1) 10Aaron Schulz: Remove use of $wgEnotifUseJobQ and always enqueue [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/267317 [20:28:27] (03CR) 10Addshore: [C: 032] Remove use of $wgEnotifUseJobQ and always enqueue [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/267317 (owner: 10Aaron Schulz) [20:40:39] mooeypoo: shalom from Jerusalem [20:42:49] aharoni, heyhey [20:43:08] (03Merged) 10jenkins-bot: Remove use of $wgEnotifUseJobQ and always enqueue [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/267317 (owner: 10Aaron Schulz) [20:43:21] looks like notification-header-user-rights-add-only could use gender support for the current user [20:43:45] at least for Hebrew it's more relevant than gender support for the performer of the action. [20:44:02] is it faster for you to fix it or for me to report a bug? [20:45:40] I am on my way for lunch, actually. Can you report a quick bug? [20:46:02] mooeypoo: ok, beteavon [20:46:06] Thanks! [20:52:06] 6Collaboration-Team-Backlog, 10Notifications, 7I18n: notification-header-user-rights-* should have GENDER support for the current user - https://phabricator.wikimedia.org/T125251#1982696 (10Amire80) 3NEW [20:52:28] 6Collaboration-Team-Backlog, 10Notifications, 7I18n: notification-header-user-rights-* should have GENDER support for the current user - https://phabricator.wikimedia.org/T125251#1982707 (10Amire80) [20:53:49] 6Collaboration-Team-Backlog, 10Notifications, 7I18n: Notification-header-flow-topic-renamed-user-talk and Notification-bundle-header-flow-post-edited-user-talk seem to have incorrect parameter documentation - https://phabricator.wikimedia.org/T125253#1982717 (10Amire80) 3NEW [21:05:02] stephanebisson: I am checking https://phabricator.wikimedia.org/T56433 -- and one of interesting thing - I do not see Notifications translated anymore... [21:05:34] stephanebisson: old notificaitons (three months ago) were translated [21:06:06] etonkovidova: These are new messages. It takes a little bit of time for them to be translated. [21:06:40] stephanebisson: I see hmm - seems that gender support cannot be verified yet [21:08:21] 3Collaboration-Team-Current, 10Notifications, 7I18n: notification-header-user-rights-* should have GENDER support for the current user - https://phabricator.wikimedia.org/T125251#1982768 (10SBisson) p:5Triage>3Normal a:3SBisson [21:08:27] (03PS1) 10Sbisson: Gender support for viewing user in user-rights notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/267325 (https://phabricator.wikimedia.org/T125251) [21:25:37] 3Collaboration-Team-Current, 10Notifications, 7I18n: Notification-header-flow-topic-renamed-user-talk and Notification-bundle-header-flow-post-edited-user-talk seem to have incorrect parameter documentation - https://phabricator.wikimedia.org/T125253#1982811 (10SBisson) p:5Triage>3Normal a:3SBisson [21:25:45] (03PS1) 10Sbisson: Fix documentation for 'post-edited' and 'topic-renamed' notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267331 (https://phabricator.wikimedia.org/T125253) [21:38:16] (03PS2) 10Sbisson: Fix documentation for 'post-edited' and 'topic-renamed' notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/267331 (https://phabricator.wikimedia.org/T125253) [21:45:36] stephanebisson, re https://gerrit.wikimedia.org/r/#/c/267331/1/i18n/qqq.json <-- aren't all the parameters the same because that's supposedly what all the models output? [21:46:42] as in, shouldn't the name+gender be $1 and $2 in all models? I remember something like that was said, but I'm not sure I remember right [22:26:37] 6Collaboration-Team-Backlog, 10Notifications, 7I18n: Notifications - talk-page-bundle - the number of messages left by $1 - https://phabricator.wikimedia.org/T125264#1982960 (10Quiddity) 3NEW