[00:07:03] matt_flaschen, in case you didn't see https://phabricator.wikimedia.org/T124828#1968032 [00:08:52] matt_flaschen, yep [00:09:18] matt_flaschen, it wasn't actually working right, and the majority of the exceptions that did work right, had their "sitename" written correctly too anyways [00:11:11] mooeypoo, yeah, you didn't need to have it for the ones where it was right in SiteMatrix. Not sure why it didn't work for the other ones, maybe mismatch between code and wiki name? [00:11:50] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1968159 (10Mooeypoo) Update, here is a preliminary list of generated project names: https://gist.github.com/mooeypoo/011120a9748... [00:12:26] matt_flaschen, maybe, but also, there were a bunch of them still missing the exception rule and i noticed that if I start adding them in, it would be the same as just correcting them manually and individually [00:12:38] the rules were per individual wikis, not really something I could do for batches anyways [00:13:02] It still goes over exceptions, but whatever isn't caught, it just fills in the name from sitename [00:13:23] 6Collaboration-Team-Backlog, 10Flow, 7Design, 7Easy: Flow: Topic history page doesn't reflect action in h1 heading or tag - https://phabricator.wikimedia.org/T72472#1968162 (10Mattflaschen) >>! In T72472#1968112, @Tgr wrote: > The first is an echo bug, the second maybe a combination of a network is... [00:14:48] <matt_flaschen> quiddity, yeah, I did. [00:17:07] <quiddity> matt_flaschen, how are you tracking recently filed tasks, nowadays? I know you were experimenting with muting wikibugs/grrrit-wm a while ago, and that checking certain types of email (particular lists) can be erratic. [00:17:45] <quiddity> (I still haven't settled on a preferred method, and use wikibugs/email in equal measure) [00:19:36] <matt_flaschen> quiddity, I don't mute anything on iRC currently. It is redundant, which sucks, but when I did that I occasionally wished I had seen something right away. Still might reconsider, but it works for now. [00:20:05] <matt_flaschen> quiddity, I still use my email inbox as my primary inbox, though, plus what I'm assigned to on -Current and going through stuff that needs code review. [00:20:08] <quiddity> nod, ty :) [00:23:28] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Create new notification category for talk pages: flowusertalk - https://phabricator.wikimedia.org/T121663#1968191 (10jmatazzoni) I'm sorry, but I'm not following this. Can you explain more fully? And do you need me to change the spec here? [00:31:00] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1968225 (10Mooeypoo) >>! In T121936#1965091, @Nikerabbit wrote: > Can/should we place the automatically generated names somewher... [00:35:02] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Tweak page-linked notification - https://phabricator.wikimedia.org/T121812#1968236 (10jmatazzoni) @Pginer-WMF Hey Pau, are you OK with this new language: "A link was made from Easter Island to Moai."... [00:43:54] <mooeypoo> matt_flaschen, new version https://gerrit.wikimedia.org/r/266461 [00:49:04] <matt_flaschen> mooeypoo, thanks. [01:06:05] <wikibugs> 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10Notifications, 7user-notice: Revise Sorting of Notifications on the Fly-Out Menu - https://phabricator.wikimedia.org/T123018#1968334 (10Quiddity) [01:06:41] <mooeypoo> quiddity. POPUP. [01:06:51] * mooeypoo will change this one instance at a time [01:07:04] <quiddity> flyout panel dropdown [01:07:36] * mooeypoo sobs [01:08:39] <quiddity> idk. I like flyout. It's what it was called at the start, and it makes sense in English (i would guess it's a problem in other languages?). Popup is illogical (it goes downwards) plus ambiguous with Navpopups. Panel (which Pau likes) is non-intuitive. [01:08:59] <quiddity> YMMV! [01:27:59] <mooeypoo> quiddity, "like" has nothing to do with it. OOUI defines it as a Popup. It's popup in the *code*. IN THE CODE! I rest my case, QED, yourewelcome. [01:28:20] <quiddity> heh ;p [01:28:33] <mooeypoo> Also, quiddity, it doesn't "fly out" of anywhere. It pops into existence out of the badge... [01:29:04] * mooeypoo will continue to push for a nomenclature change regardless of opposition! [01:29:05] <mooeypoo> ;) [01:29:12] <quiddity> it pops down though!!! [01:29:22] * quiddity isn't getting dragged into this! not this evening, at least ;p [01:29:30] <mooeypoo> You american-centriec. It doesn't pop down in australia! [01:29:41] <quiddity> as always, https://www.mediawiki.org/wiki/Naming_things is hard. [01:29:43] <quiddity> lol [01:29:46] <mooeypoo> hehe [01:30:05] <mooeypoo> aaaanyways [01:30:12] <mooeypoo> I'm packing up. See you guys tomorrow [01:30:29] <quiddity> o/ [01:33:57] <grrrit-wm> (03PS1) 10Kaldari: Adjusting schema to match user_id definition in core [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/266645 [01:36:56] <grrrit-wm> (03PS2) 10Kaldari: Adjusting schema to match user_id definition in core [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/266645 [01:39:14] <grrrit-wm> (03CR) 10Aaron Schulz: [C: 032] Adjusting schema to match user_id definition in core [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/266645 (owner: 10Kaldari) [01:40:45] <grrrit-wm> (03Merged) 10jenkins-bot: Adjusting schema to match user_id definition in core [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/266645 (owner: 10Kaldari) [02:50:12] <matt_flaschen> quiddity, it pops up in the Z-index (towards your face). Same index as old-school popups that were a separate window. [04:09:33] <wikibugs> 3Collaboration-Team-Current, 10Notifications: Remove user names from some notification messages in favor of secondary link - https://phabricator.wikimedia.org/T121739#1968486 (10MtDu) a:3MtDu I'll work on this. [04:14:32] <wikibugs> 3Collaboration-Team-Current, 10Notifications: Remove user names from some notification messages in favor of secondary link - https://phabricator.wikimedia.org/T121739#1968488 (10MtDu) @Catrope, So to make sure I'm doing what is desired, this is the reverted stuff. https://dpaste.de/0TzT#L12,14,16. So what I'm... [07:30:17] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1968640 (10Nikerabbit) Maybe the url if that is easy to get? Or dbname if that is not possible. Then something like {{projectnam... [07:56:38] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265703 (owner: 10IoannisKydonis) [08:05:00] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [08:15:56] <grrrit-wm> (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266474 (https://phabricator.wikimedia.org/T121936) (owner: 10Matthias Mullie) [10:06:41] <grrrit-wm> (03PS1) 10Addshore: @author Addshore everywhere for me [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/266691 [11:03:29] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 7Easy: Edit description link should be grey by default, not blue - https://phabricator.wikimedia.org/T112872#1969197 (10Aklapper) [11:06:42] <wikibugs> 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10Notifications, and 2 others: Create landing page for Echo Beta Feature information link - https://phabricator.wikimedia.org/T123307#1969216 (10Trizek-WMF) [11:06:54] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 10MediaWiki-extensions-GuidedTour, 3Liaisons-February-2016: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#1969220 (10Trizek-WMF) [11:08:30] <wikibugs> 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 6Community-Liaison, 10Notifications, and 4 others: [Tracking] Update Help:Notifications - https://phabricator.wikimedia.org/T119713#1969223 (10Trizek-WMF) [11:11:41] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: Flow doesn't render <gallery> correctly - https://phabricator.wikimedia.org/T124876#1969230 (10QuimGil) 3NEW [11:37:11] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Have a cheat sheet about Flow shortcuts - https://phabricator.wikimedia.org/T117251#1969292 (10Trizek-WMF) p:5Normal>3Lowest Changing priority: at the moment, there is no real feedback concerning shortcuts. [11:37:48] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 6Community-Liaison, and 2 others: [Tracking] Create a general public documentation for Flow - https://phabricator.wikimedia.org/T111367#1969294 (10Trizek-WMF) p:5Normal>3Low [11:37:54] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Flow history system - https://phabricator.wikimedia.org/T113581#1969296 (10Trizek-WMF) p:5Normal>3Low [11:37:56] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a page about (more) advanced Flow features - https://phabricator.wikimedia.org/T111529#1969298 (10Trizek-WMF) p:5Normal>3Low [11:38:41] <wikibugs> 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 6Community-Liaison, 10WMF-Product-Development-Process: Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#1969301 (10Trizek-WMF) [11:38:43] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 7Tracking: Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#1969300 (10Trizek-WMF) [11:39:29] <wikibugs> 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 6Community-Liaison, 10WMF-Product-Development-Process, 3Liaisons-February-2016: Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#1932012 (10Trizek-WMF) [11:40:42] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications, 7Documentation: Create a page about Notifications badges - https://phabricator.wikimedia.org/T119717#1969307 (10Trizek-WMF) [11:40:44] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications, 7Documentation: Create a page about the different notifications you can receive (messages panel) - https://phabricator.wikimedia.org/T119730#1969305 (10Trizek-WMF) 5Open>3Resolved Done on [[ https://www.mediawiki.org/wiki/Help:Notifications | Help:Notificatio... [11:40:54] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications, 7Documentation: Create a page about Notifications badges - https://phabricator.wikimedia.org/T119717#1833994 (10Trizek-WMF) [11:40:56] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications, 7Documentation: Create a page about the different notifications you can receive (alert panel) - https://phabricator.wikimedia.org/T119722#1969308 (10Trizek-WMF) 5Open>3Resolved Done on [[ https://www.mediawiki.org/wiki/Help:Notifications | Help:Notifications ]] [11:41:03] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications, 7Documentation, 3Liaisons-January-2016: Create a page about the different notifications you can receive (alert panel) - https://phabricator.wikimedia.org/T119722#1969311 (10Trizek-WMF) [11:41:10] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications, 7Documentation, 3Liaisons-January-2016: Create a page about the different notifications you can receive (messages panel) - https://phabricator.wikimedia.org/T119730#1969312 (10Trizek-WMF) [11:41:37] <wikibugs> 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 6Community-Liaison, 10Notifications, and 4 others: [Tracking] Update Help:Notifications - https://phabricator.wikimedia.org/T119713#1969315 (10Trizek-WMF) [11:41:44] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications, 7Documentation, 3Liaisons-January-2016: Create a page about Notifications badges - https://phabricator.wikimedia.org/T119717#1969316 (10Trizek-WMF) [11:43:02] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications, 7Documentation, 3Liaisons-February-2016: Create a page about how to mention people - https://phabricator.wikimedia.org/T119720#1969317 (10Trizek-WMF) [11:44:28] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 7Tracking: Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#1969318 (10Trizek-WMF) 5Open>3stalled Status changed: waiting for decisions concerning T123538 [11:44:36] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement: Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#1969322 (10Trizek-WMF) [11:45:16] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement: Create a newsletter about Collaboration team products - https://phabricator.wikimedia.org/T112864#1648523 (10Trizek-WMF) [11:46:47] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Create new notification category for talk pages: flowusertalk - https://phabricator.wikimedia.org/T121663#1969324 (10SBisson) >>! In T121663#1968191, @jmatazzoni wrote: > I'm sorry, but I'm not following this. Can you explain more fully? And do... [11:47:40] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Tweak page-linked notification - https://phabricator.wikimedia.org/T121812#1969327 (10SBisson) It looks like the header message for bundled notification is still in the old style `$4 and $5 other {{PLUR... [12:43:26] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Gallery: Flow doesn't render <gallery> correctly - https://phabricator.wikimedia.org/T124876#1969462 (10Aklapper) [13:24:53] <grrrit-wm> (03PS1) 10Lokal Profil: Fix typo in English text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266712 [13:47:28] <grrrit-wm> (03CR) 10Sbisson: [C: 032] Fix typo in English text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266712 (owner: 10Lokal Profil) [13:50:09] <wikibugs> 3Collaboration-Team-Current, 10Flow: Clicking Flow "new replies" notifications highlights only the most recent reply - https://phabricator.wikimedia.org/T124175#1969610 (10SBisson) It looks like the changes to Flow notifications will be deployed next week. Sorry for the delay. [13:50:44] <grrrit-wm> (03Merged) 10jenkins-bot: Fix typo in English text [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266712 (owner: 10Lokal Profil) [15:39:18] <wikibugs> 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke, 5Patch-For-Review, and 2 others: Add Flow support to Nuke - https://phabricator.wikimedia.org/T115695#1969878 (10SBisson) >>! In T115695#1930138, @Etonkovidova wrote: > Notes: > - the topics are displayed by topic id - e.g. Topic:Svz6km0cj82... [15:43:16] <wikibugs> 3Collaboration-Team-Current, 10Flow, 10Notifications: Echo notification about renaming a topic title shows the new title twice and doesn't show the old title - https://phabricator.wikimedia.org/T94340#1969903 (10SBisson) [15:45:34] <wikibugs> 3Collaboration-Team-Current, 10Flow, 10Notifications: Echo notification about renaming a topic title shows the new title twice and doesn't show the old title - https://phabricator.wikimedia.org/T94340#1969914 (10SBisson) [15:45:36] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Email notification: The new renamed topic title is displayed in place for the previous title - https://phabricator.wikimedia.org/T109784#1969915 (10SBisson) [16:28:19] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Tweak page-linked notification - https://phabricator.wikimedia.org/T121812#1970041 (10jmatazzoni) @SBisson -- the bundled message would be in this format : Links were made from **Easter Island **and 9... [16:42:58] <grrrit-wm> (03PS5) 10Matthias Mullie: Engage full surveillance mode for Flow talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) [16:46:23] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Engage full surveillance mode for Flow talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [17:13:09] <grrrit-wm> (03PS6) 10Matthias Mullie: Engage full surveillance mode for Flow talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) [17:27:13] <grrrit-wm> (03PS1) 10Sbisson: Fix bundled header message for 'page-linked' notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266770 (https://phabricator.wikimedia.org/T121812) [17:28:56] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Tweak page-linked notification - https://phabricator.wikimedia.org/T121812#1970316 (10SBisson) >>! In T121812#1970041, @jmatazzoni wrote: > @SBisson -- the bundled message would be in this format : >... [17:50:54] <matt_flaschen> Anyone have anything to bring up at Scrum of Scrums? [17:56:14] <mooeypoo> matt_flaschen, human-readable names may be relevant to other teams [17:57:14] <matt_flaschen> mooeypoo, oh yeah, thanks. [18:00:55] <grrrit-wm> (03PS1) 10Mattflaschen: Fix documentation error in dumpBackup.php (import -> export) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266781 [18:01:40] <grrrit-wm> (03CR) 10Mattflaschen: [C: 032] Fix documentation error in dumpBackup.php (import -> export) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266781 (owner: 10Mattflaschen) [18:03:26] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Add dry-run mode to Flow External Store migration script - https://phabricator.wikimedia.org/T119566#1970451 (10Mattflaschen) @Jcrespo Do you want to review the dry run patch, or should we just review it in-team? [18:05:36] <grrrit-wm> (03Merged) 10jenkins-bot: Fix documentation error in dumpBackup.php (import -> export) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266781 (owner: 10Mattflaschen) [18:05:38] <grrrit-wm> (03CR) 10Sbisson: [C: 04-1] "Looks good. A few comments inline." (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [18:09:20] <grrrit-wm> (03CR) 10Jcrespo: [C: 031] "Looks good, let's try to test it on beta." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265524 (https://phabricator.wikimedia.org/T119566) (owner: 10Mattflaschen) [18:19:31] <etonkovidova> stephanebisson: I agree with your comment on T115695 [18:20:36] <stephanebisson> etonkovidova: could you agree in the ticket? ;) [18:22:05] <etonkovidova> stephanebisson: sure, but my understanding was that by moving the ticket to Product review I implicitly agreed that the outstanding issues are minor :))) [18:22:26] <stephanebisson> alright then [18:23:31] <wikibugs> 3Collaboration-Team-Current, 10Flow: [betalabs] Special:Nuke - empty Flow pages are not listed - https://phabricator.wikimedia.org/T123450#1970526 (10SBisson) [18:23:33] <wikibugs> 3Collaboration-Team-Current, 10Flow: [betalabs] Special:Nuke - 'Pattern for the page name' filter does not work - https://phabricator.wikimedia.org/T123449#1970527 (10SBisson) [18:23:35] <wikibugs> 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke, 5Patch-For-Review, and 2 others: Add Flow support to Nuke - https://phabricator.wikimedia.org/T115695#1730512 (10SBisson) [18:24:32] <etonkovidova> stephanebisson: aaa... somehow I after I did git checkout master git pull --rebase -- I do not have Enhanced notifications. Help? [18:25:30] <etonkovidova> stephanebisson: git show-branch [master] Merge "Change Varnish home directory to /home/varnish" [18:25:57] <stephanebisson> etonkovidova: it's not enabled in mw-vagrant yet, someone needs to review and merge https://gerrit.wikimedia.org/r/#/c/264876 [18:26:40] <stephanebisson> ^ I vote for.... matt_flaschen [18:28:16] <matt_flaschen> stephanebisson, I will. Last time I tried to test it I hit a related (but not caused by your patch) bug with CentralAuth on Vagrant that was interfering with me testing it. I will try to merge it today or tomorrow. [18:28:30] <stephanebisson> thanks [18:28:32] <etonkovidova> stephanebisson: yikes I was on a special matt_flaschen's backfill branch and all was working sigh ... [18:29:39] <matt_flaschen> Yeah, I need to rebase that, however that only affects backfill not the feature itself (it will still update as new notifications come in). [18:32:52] <grrrit-wm> (03PS7) 10Matthias Mullie: Engage full surveillance mode for Flow talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) [18:32:57] <grrrit-wm> (03CR) 10Matthias Mullie: Engage full surveillance mode for Flow talk pages (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [18:35:18] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Engage full surveillance mode for Flow talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [18:35:39] <grrrit-wm> (03CR) 10Matthias Mullie: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [18:36:19] <grrrit-wm> (03CR) 10Matthias Mullie: [C: 032] Fix whitespace in FlowExternalStoreMoveCluster to use tabs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265638 (owner: 10Mattflaschen) [18:40:26] <grrrit-wm> (03Merged) 10jenkins-bot: Fix whitespace in FlowExternalStoreMoveCluster to use tabs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265638 (owner: 10Mattflaschen) [18:48:01] <grrrit-wm> (03CR) 10Sbisson: Engage full surveillance mode for Flow talk pages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [18:51:29] <grrrit-wm> (03CR) 10Matthias Mullie: Engage full surveillance mode for Flow talk pages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [19:02:30] <matt_flaschen> Nothing new for us at scrum of scrums, except that language team wants to talk to AbuseFilter, so I said they could talk to us if helpful (since we've done some integration). [19:03:23] <matt_flaschen> My standup update: Still working on topic title parsing, put up a simpler fix for the Vagrant Varnish update, did a little more review on the human-readable patch. After topic title, I need to catch up on code review. I'll also probably spend some more time on my lightning talk. [19:05:27] <grrrit-wm> (03CR) 10Sbisson: Engage full surveillance mode for Flow talk pages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [19:06:06] <matt_flaschen> I'll be leaving early today, around 5:20 Pacific. [19:08:33] <stephanebisson> matt_flaschen: quiddity was asking if the convertToText.php was ready to go. Your comment about "options vs args" seems to have been addressed. [19:09:35] <stephanebisson> matt_flaschen: I can also do some testing on it if you think it's useful [19:14:41] <wikibugs> 3Collaboration-Team-Current, 10Notifications: Unread notification count is wrong when presentationModel::canRender() returns false - https://phabricator.wikimedia.org/T124948#1970819 (10SBisson) 3NEW [19:42:19] <etonkovidova> mooeypoo: T124023 "Unbalanced space in bundled cross-wiki notifications" - is it deployed to testwiki and test2wiki? I do not see the fix :( [19:43:56] <mooeypoo> hm, i am not sure because of the rollback [19:44:12] <mooeypoo> I think it will only be there next week [19:44:16] <mooeypoo> But it should be on beta [19:45:21] <etonkovidova> mooeypoo: sigh... [19:45:25] <etonkovidova> mooeypoo: ok [19:45:27] <mooeypoo> Yeah :\ [19:54:25] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971084 (10Mooeypoo) >>! In T121936#1968640, @Nikerabbit wrote: > Maybe the url if that is easy to get? Or dbname if that is not... [20:09:27] <matt_flaschen> stephanebisson, I'll re-review that as well today. [20:19:40] <mooeypoo> matt_flaschen, I found out why my exceptions in "specials" didn't work >.< [20:19:52] <matt_flaschen> mooeypoo, how come? [20:19:57] <mooeypoo> I was checking "in_array( ... )" for an object :( [20:20:02] <mooeypoo> just replaced it with array_key_exists( ... ) [20:20:07] <mooeypoo> I completely didn't notice, ha. [20:20:15] <mooeypoo> Now it works. Less manual corrections! [20:20:19] <matt_flaschen> Also the 'code' thing before. [20:20:26] <mooeypoo> Yeah that I fixed yesterday [20:47:59] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971298 (10Nikerabbit) My point for template was rather to include the whole burb "this is a project name for bar... see foo for... [20:50:18] <grrrit-wm> (03PS1) 10Mattflaschen: Don't accidentally parse topic title on log pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266908 (https://phabricator.wikimedia.org/T124804) [20:50:51] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications: cross-wiki Notifications: short and long Notifications - https://phabricator.wikimedia.org/T124973#1971315 (10Etonkovidova) 3NEW [20:51:29] <grrrit-wm> (03CR) 10John Vandenberg: Don't accidentally parse topic title on log pages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266908 (https://phabricator.wikimedia.org/T124804) (owner: 10Mattflaschen) [20:52:00] <grrrit-wm> (03PS2) 10Mattflaschen: Don't accidentally parse topic title on log pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266908 (https://phabricator.wikimedia.org/T124608) [20:53:32] <grrrit-wm> (03CR) 10Mattflaschen: Don't accidentally parse topic title on log pages (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266908 (https://phabricator.wikimedia.org/T124608) (owner: 10Mattflaschen) [20:56:15] <matt_flaschen> Would be good to get that out for evening SWAT. [20:57:48] <wikibugs> 3Collaboration-Team-Current, 10Flow, 10Thanks, 10Notifications, 7user-notice: wikitext in flow titles is parsed (HTML tags like <tt> and templates) on echo notifications - https://phabricator.wikimedia.org/T120291#1971347 (10Mattflaschen) [20:59:52] <matt_flaschen> mooey|lunch, niedzielski is going to post some info about what Android is currently doing. I don't think they have all of them, it's just for context. [21:00:23] <wikibugs> 3Collaboration-Team-Current, 10Flow, 10Thanks, 10Notifications, 7user-notice: wikitext in flow titles is parsed (HTML tags like <tt> and templates) on echo notifications - https://phabricator.wikimedia.org/T120291#1971356 (10Mattflaschen) [21:06:42] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications: cross-wiki: the tooltip in ellipses menu has large font - https://phabricator.wikimedia.org/T124256#1971380 (10Etonkovidova) @MtDu: you need 1) Enable Beta - 'Enhanced notifications' feature 2) then you'll receive notifications from other wiki - e.g. somebody pos... [21:06:51] <grrrit-wm> (03CR) 10Sbisson: [C: 032] Don't accidentally parse topic title on log pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266908 (https://phabricator.wikimedia.org/T124608) (owner: 10Mattflaschen) [21:08:29] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications: cross-wiki: the tooltip in ellipses menu has large font - https://phabricator.wikimedia.org/T124256#1971389 (10Etonkovidova) Presently on testwiki {F3286923} {F3286925} [21:10:37] <grrrit-wm> (03Merged) 10jenkins-bot: Don't accidentally parse topic title on log pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266908 (https://phabricator.wikimedia.org/T124608) (owner: 10Mattflaschen) [21:13:22] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Add "mark as read" as a deprioitized secondary action to every unread notification - https://phabricator.wikimedia.org/T121935#1971412 (10Etonkovidova) For testing: check the status of {... [21:17:34] <matt_flaschen> mooey|lunch, are you able to monitor the topic title patch if we SWAT it out? I'll do the initial testing to make sure it works in prod, but then I have to go so someone has to be available from the team, for an hour or so (until at least 6 Pacific would be good). [21:21:23] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971445 (10Niedzielski) Leaving a comment here at the request of @mattflaschen. The Android app does not have notifications yet.... [21:25:02] <mooeypoo> matt_flaschen, I can be around, but I am not sure I'm familiar enough with the patch to do something if it breaks right now [21:25:08] <mooeypoo> what patch is it? [21:27:52] <matt_flaschen> mooeypoo, https://gerrit.wikimedia.org/r/#/c/266908/ . Realistically if it breaks, you can ask the SWATers to revert it. I will also test it on Beta first, so it's possible but unlikely to break in prod. [21:28:52] <matt_flaschen> And you would also be able to message me if needed. [21:30:06] * mooeypoo nods [21:30:31] <mooeypoo> I just want to know what it is so I can also properly test in case there are issues [21:30:47] <mooeypoo> I'll be around until 5:30pm for sure, and I can stay later if needed [21:34:38] <matt_flaschen> mooeypoo, you can test with just {{Cn}}. That will work on both mediawiki.org and enwiki. To make sure it doesn't trigger a parse (topic titles are only supposed to support internal wiki links and http://en.wikipedia.org/wiki/Special:Search?go=Go&search=Media:Foo.jpg). [21:35:04] <matt_flaschen> And then delete it or ask someone to, and check the deletion log. [21:35:09] <matt_flaschen> mooeypoo, are you admin on MediaWiki.org? [21:35:30] <matt_flaschen> I'll be able to test that it works before I leave, though. It's just in case it somehow causes problems a little later, which is unlikely but possible. [21:35:47] <matt_flaschen> Maybe legoktm will be available. ^ ping [21:36:09] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971478 (10Mooeypoo) >>! In T121936#1971445, @Niedzielski wrote: > Leaving a comment here at the request of @mattflaschen. The A... [21:36:18] <matt_flaschen> mooeypoo, whoops, that Media: was just supposed to use wikilink syntax, my IRC client expanded it... [21:36:29] <mooeypoo> matt_flaschen, I'm not, no [21:37:01] <mooeypoo> matt_flaschen, lego is on his way to Australia [21:37:40] <mooeypoo> I'll be around. If it creates a problem, I'll be at least able to help whoever can access the logs and delete stuff before we revert if we must [21:37:54] <matt_flaschen> Oh yeah. [21:38:15] <mooeypoo> wait, your IRC client expands wikilink syntax?! [21:38:22] <matt_flaschen> Yes. http://en.wikipedia.org/wiki/Special:Search?go=Go&search=Earth [21:38:36] <matt_flaschen> You'll have to take my word for it, but you know KDE loves bells and whistles. [21:38:49] <mooeypoo> I am jealous now. [21:39:04] <mooeypoo> I could add that to xchat... it takes python scripts.... [21:39:20] <James_F> Do you need a +sysop on MW.org still? [21:39:45] <matt_flaschen> James_F, not really. I can test it before I leave. I'm just asking mooeypoo to be resident person here Just In Case In Breaks. [21:39:54] <James_F> OK, sure. [21:40:14] <James_F> I can just make some sysops if needed. [21:40:14] * James_F coughs. :-) [21:40:44] <mooeypoo> I shall reside. [21:40:44] <matt_flaschen> mooeypoo, can you stay until 6 your time, though? That is an hour after SWAT ends, which I try to aim for. [21:40:53] * mooeypoo nods [21:40:58] <matt_flaschen> Thanks, I appreciate it. [21:41:08] <matt_flaschen> It's kind of a bad bug, so I want to get the fix out. [21:41:20] <mooeypoo> Yeah I'll be around. I was going to pack, so I'll just have IRC open in the background and look at it :) [21:41:28] <mooeypoo> yeah no problems, don't rush back or anything [21:42:08] <mooeypoo> (brb) [21:43:14] <matt_flaschen> Just to clarify, I won't actually be back at 9, but under standard unexpected bug half-life, probability is low by that point. [21:43:23] <matt_flaschen> 9 my time, 6 yours. [21:49:28] <stephanebisson> re: parsed topic title: you don't have to delete live when you test. You can create a topic with a template, delete it now, checks that the log expands the template now and that the same entry isn't expanded after the patch is deployed [21:56:42] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971582 (10Niedzielski) @Mooeypoo, if I understand correctly this Gist would replace only our Wikipedia main page title generati... [21:59:00] <grrrit-wm> (03PS1) 10Sbisson: [WIP] Generate sample notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266920 [22:00:19] <matt_flaschen> Yeah, Stephane is right. However, I will also be able to do both parts before I leave. [22:08:14] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971608 (10Mooeypoo) >>! In T121936#1971582, @Niedzielski wrote: > @Mooeypoo, if I understand correctly this Gist would replace... [22:12:45] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971619 (10Mattflaschen) >>! In T121936#1971445, @Niedzielski wrote: > Leaving a comment here at the request of @mattflaschen. T... [22:15:22] <matt_flaschen> mooeypoo, sorry, didn't see your post before posting. I think niedzielski was asking about the main page title, i.e. "Main Page" on English Wikipedia, "Wikipedia:Portada" on Spanish Wikipedia. [22:15:28] <matt_flaschen> I.E. where you go when you visit the root of the domain. [22:16:39] <mooeypoo> Oh [22:17:03] <mooeypoo> Hm. I guess so? It's the name of the project, what the project calls itself. That is most often found in that main page, but it's not the name *of* the main page [22:17:06] <mooeypoo> does that make sense? [22:17:08] <mooeypoo> I am confused. [22:18:32] <mooeypoo> matt_flaschen, also, I'm trying to add a template to translatewiki, so I need to have a page with the list of all the generated names. I'm going to add a page to mw.org -- should I just add a page, or should this be under MediaWiki:XXX or do we have a Wikimedia:XXXX namespace? or..? [22:19:01] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971633 (10Mattflaschen) >>! In T121936#1971582, @Niedzielski wrote: > @Mooeypoo, if I understand correctly this Gist would repl... [22:20:24] <matt_flaschen> mooeypoo, he's just not trying to do the same thing as you. They don't really need "German Wiktionary" in "Spanish", since I think they only deal with Wikipedias. [22:21:39] <matt_flaschen> mooeypoo, why does the template need to refer to the list? I get having a temporary list in a paste/gist until it's imported into translatewiki.net, but I don't think we want two places to update. [22:22:15] <matt_flaschen> There is no Wikimedia language. MediaWiki is used for on-wiki translations/customizations, so instead it's called Project on mediawiki.org. [22:22:21] <matt_flaschen> I mean no Wikimedia namespace. [22:23:53] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971655 (10Mooeypoo) >>! In T121936#1971619, @Mattflaschen wrote: > For our use case, we also need an unambiguous way to refer t... [22:23:57] <mooeypoo> I think I understand now... [22:24:25] <mooeypoo> matt_flaschen, isn't that what this meant? https://phabricator.wikimedia.org/T121936#1968640 [22:24:39] <mooeypoo> or this, rather https://phabricator.wikimedia.org/T121936#1971298 [22:25:37] <mooeypoo> matt_flaschen, the list is WMF-cluster-specific, so I was looking for the namespace to use there.. not quite MediaWiki: namespace. [22:26:14] <mooeypoo> Anywyas, we may not need the list [22:27:33] <mooeypoo> also, am I being unreasonable to not really like templates in qqq messages? [22:27:57] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971667 (10Mattflaschen) >>! In T121936#1971655, @Mooeypoo wrote: > If I understand correctly, this retrieves the name of the **... [22:28:02] <mooeypoo> I mean... I get the use of templates to change the text, but then if people are using it elsewhere or in the code, you have to go back and forth to the template to see what it is [22:28:32] <mooeypoo> matt_flaschen, I'd prefer generating the same message in qqq.json rather than using a template... what do you think? [22:29:10] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971668 (10Mooeypoo) >>! In T121936#1971667, @Mattflaschen wrote: >>>! In T121936#1971655, @Mooeypoo wrote: >> If I understand c... [22:29:34] <matt_flaschen> mooeypoo, I think translatewiki.net prefers templates, and we should probably defer to that. [22:29:38] <matt_flaschen> But I don't think we're on the same page. Pun not intended. [22:29:46] <matt_flaschen> mooeypoo, what's your draft template? [22:29:52] <mooeypoo> Hang on, let me save it [22:31:19] <matt_flaschen> I don't know what Nikerabbit means by "see foo for automatically generated names". I don't see why they would need the full list of initial English names. [22:31:29] <mooeypoo> https://translatewiki.net/wiki/Template:ProjectNameDocumentation [22:31:45] <mooeypoo> Right, that's what I was wondering... I only included the first part for now [22:31:56] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971697 (10Niedzielski) > That's why the i18n keys use dbname and not language key. @Mooeypoo, nice! For the Android client, is... [22:32:23] <mooeypoo> but also, meh on templates on qqq.json. I would mean that looking up that string in the code (which we do a lot) would be useless; we'll have to go get that template from translatewiki [22:32:59] <matt_flaschen> mooeypoo, what would the code need qqq for? [22:33:14] <matt_flaschen> Shouldn't it be using the current user's UI language? [22:34:15] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971714 (10Mooeypoo) >>! In T121936#1971697, @Niedzielski wrote: >> That's why the i18n keys use dbname and not language key. >... [22:34:55] <mooeypoo> Hm. I guess so. I refer to qqq.json a lot in the code, but that's usually when there are parameters in the *message* itself. Not hte QQQ message. [22:35:05] <mooeypoo> In this case, no params anyways in the message [22:36:20] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10Front-end-Standards-Group, 10MediaWiki-General-or-Unknown, and 6 others: Should be a standard way to access tablet browser width threshold - https://phabricator.wikimedia.org/T93675#1971731 (10Jdlrobson) [22:36:27] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10Front-end-Standards-Group, 10MediaWiki-General-or-Unknown, and 6 others: Should be a standard way to access tablet browser width threshold - https://phabricator.wikimedia.org/T93675#1143254 (10Jdlrobson) [22:37:09] <matt_flaschen> mooeypoo, oh, you mean when developing you consult qqq. [22:37:21] <matt_flaschen> I thought you by "looking up that string in the code" you meant looking it up at runtime. [22:37:43] <matt_flaschen> Yeah, I read qqq often too, but in this case what it does it pretty clear and like you said it doesn't take params. [22:37:44] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10Front-end-Standards-Group, 10MediaWiki-General-or-Unknown, and 6 others: Should be a standard way to access tablet browser width threshold - https://phabricator.wikimedia.org/T93675#1971752 (10Jdlrobson) 5Open>3Resolved [22:38:35] <mooeypoo> matt_flaschen, yeah, when developing [22:38:40] <mooeypoo> But yeah, good point [22:39:43] <mooeypoo> pfft haha $out->addWikitext( $output_qqq ); renders the (nonexisting locally) template [22:40:22] <mooeypoo> matt_flaschen, I guess addHTML() is an alternative? or is there some 'addText' ? [22:41:17] <matt_flaschen> mooeypoo, yeah, addHTML doesn't do anything except just dump it to the output. [22:41:27] <matt_flaschen> So that's what you want. [22:43:14] * mooeypoo nods [22:43:18] <matt_flaschen> mooeypoo, while you're modifying the script, it should be comma (,), not semi-colon (;). Or you can just use FormatJson::encode and let it worry about it. [22:44:09] <mooeypoo> matt_flaschen, https://gist.github.com/mooeypoo/39f51763d1ff5aa7d71a [22:44:23] <mooeypoo> Where? [22:45:15] <mooeypoo> matt_flaschen, new version for the script https://gerrit.wikimedia.org/r/266461 [22:49:03] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971831 (10matmarex) >>! In T121936#1971697, @Niedzielski wrote: >> That's why the i18n keys use dbname and not language key. >... [22:51:42] <matt_flaschen> mooeypoo, in the output. JSON uses , [22:52:00] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1971845 (10Mooeypoo) Update to the script output: en.json: https://gist.github.com/mooeypoo/011120a9748a4e06bcf2 qqq.json: http... [22:52:16] <mooeypoo> oh!! [22:52:22] <mooeypoo> matt_flaschen, pff, *wow* [22:52:25] <mooeypoo> Thank you [22:53:10] <matt_flaschen> mooeypoo, not a big deal. I would also just use FormatJson::encode. I know it's a hack and all, but they you don't need to worry about pesky things like that. :) [22:53:32] <mooeypoo> Yeah, good point. I should just create an object and output it [22:54:23] <matt_flaschen> mooeypoo, it even has pretty printing available, second argument true. [22:54:34] <matt_flaschen> FormatJson::encode( $val, true ); [22:56:36] <matt_flaschen> mooeypoo, working on Beta, despite Special:Version showing the wrong commit (mentioned that to marxarelli in #wikimedia-releng). [22:56:40] <matt_flaschen> Anyway, putting it up for SWAT now. [22:57:31] <mooeypoo> matt_flaschen, yeah, you're right, I didn't think about it because I knew I'm basically copy/pasting it into the json files later as a partial json [23:00:39] * mooeypoo stares at MW [23:00:42] <mooeypoo> matt_flaschen, "Syntax only allowed in Hack files (" [23:00:43] <mooeypoo> ... [23:01:08] <matt_flaschen> mooeypoo, that means you're running on HHVM, had a syntax error, but it *would* work in Hack. :) [23:01:17] <matt_flaschen> Is that from the latest Gerrit, or since changed? [23:01:21] <mooeypoo> no, changed [23:01:31] <mooeypoo> I changed to work with objects + json_encode [23:01:44] <matt_flaschen> mooeypoo, if you use the Zend URL it will give you a different version of the error , maybe more useful. [23:01:56] <matt_flaschen> php5.local.wmftest.net [23:01:58] <mooeypoo> I'm using your php5.local -- yes [23:02:00] <mooeypoo> that [23:02:02] <MatmaRex> mooeypoo: you have a trailing comma? [23:02:02] <mooeypoo> found the error [23:02:15] <mooeypoo> MatmaRex, personally, or in this code? [23:02:44] <MatmaRex> mooeypoo: in whatever told you "Syntax only allowed in Hack files" :D [23:03:13] <mooeypoo> oh, apparently it's a "Parse error: syntax error, unexpected ')' in /vagrant/mediawiki/includes/specials/SpecialBlankpage.php on line 153" [23:03:22] <matt_flaschen> etonkovidova, have you seen edit-topic-title not fire? I can't get it to work locally. I was trying earlier. [23:03:31] <MatmaRex> mooeypoo: hmm, that has quite a few untranslated language names. [23:03:44] <mooeypoo> MatmaRex, good guess. i wote this: json_encode( $out_en, ) ... pff [23:03:58] <matt_flaschen> Yeah, HHVM has bad syntax error diagnostics. [23:04:39] <mooeypoo> MatmaRex, there are several , yeah. Shouldn't be that horrible, though. Most of them are failing CLDR translation [23:05:24] <MatmaRex> yeah, but it's pretty lame. isn't CLDR supposed to have them all? :/ [23:05:39] <matt_flaschen> The other languages are used to English randomly cropping into their UI due to fallbacks. [23:05:41] <matt_flaschen> Now we know how they feel! [23:07:46] <MatmaRex> mooeypoo: hmm, calling it a "humanreadable-name" sounds vaguely offensive. can we call it a project name or something? [23:07:55] <MatmaRex> mooeypoo: also, there are several duplicates. [23:08:41] <MatmaRex> hmm. [23:08:42] <MatmaRex> "project-humanreadable-name-labswiki": "Wikipedia"; [23:08:42] <MatmaRex> "project-humanreadable-name-labtestwiki": "Wikipedia"; [23:08:42] <MatmaRex> "project-humanreadable-name-nostalgiawiki": "Wikipedia"; [23:08:56] <matt_flaschen> MatmaRex, yeah, those are missing exceptions. There are some for "Wikimedia" too. [23:09:05] <MatmaRex> and four "Arbitration Committee" wikis [23:09:17] <matt_flaschen> Basically, these are cases where no one bothered to set the site name correctly so it's somehow assuming "Wikipedia", either at site creation time or in site matrix (not sure). [23:09:33] <James_F> MatmaRex: nostalgiawiki *is* the English Wikipedia, just an old version of it. [23:09:48] <matt_flaschen> That would be good to fix on the cluster too (wherever Site Matrix is reading from) if it won't break the world. [23:09:54] <MatmaRex> yeah, that amused me. it is the original "Wikipedia". [23:10:29] <mooeypoo> MatmaRex, offensive? heh, didn't thnk abvout that. We can change it. I just put in the first thing that looked reasonable. [23:11:47] <mooeypoo> MatmaRex, yeah, the "specials" were an annoying concern with the names. They have no real way to get proper names from their dbname or their "sitename" which is, almost always "Wikipedia" :\ [23:11:52] <mooeypoo> so I'll be fixing those by hand [23:13:42] <matt_flaschen> Pennsylvania has the only inactive (or active I think) state-level psuedo-chapter. And the site name is right in Site Matrix. :) [23:13:51] <matt_flaschen> Of course, NYC has one just for the city... [23:13:54] <mooeypoo> ha... the other effect of using objects with json_encode ? It encodes the foreign languages into unicode values [23:14:13] <mooeypoo> That's because NYC is the only real city in NY [23:14:23] * mooeypoo waits for James_F to jump up and object Britishly [23:15:20] <matt_flaschen> mooeypoo, you're also lucky my mom isn't here. [23:16:20] <mooeypoo> Is she from somewhere in New York that is not New York City? [23:16:28] <mooeypoo> Also, NYC is the center of the world. Everyone knows that. [23:17:03] <matt_flaschen> mooeypoo, yeah. :) [23:17:18] <matt_flaschen> mooeypoo, that's why the organization using the Flat Earth Society map is based there. :) [23:18:33] <mooeypoo> It's a blessing and a curse. [23:19:15] <matt_flaschen> I mean the UN (well, according to the Flat Earth Society). ;) [23:19:30] <matt_flaschen> Although they have a point. :) [23:19:56] <mooeypoo> Yep. That's what happens when you're the American Capital of Media [23:24:09] <mooeypoo> matt_flaschen, MatmaRex https://gerrit.wikimedia.org/r/266461 [23:29:29] <grrrit-wm> (03PS1) 10Mattflaschen: Don't accidentally parse topic title on log pages [extensions/Flow] (wmf/1.27.0-wmf.10) - 10https://gerrit.wikimedia.org/r/266938 (https://phabricator.wikimedia.org/T124608) [23:29:46] <grrrit-wm> (03PS1) 10Mattflaschen: Don't accidentally parse topic title on log pages [extensions/Flow] (wmf/1.27.0-wmf.11) - 10https://gerrit.wikimedia.org/r/266939 (https://phabricator.wikimedia.org/T124608) [23:33:38] <mooeypoo> ok, I'm going to make some coffee, brb [23:42:17] <matt_flaschen> etonkovidova, you said notifications weren't working for you on the Beta cluster, right? I'm seeing the same thing. [23:42:52] <etonkovidova> matt_flaschen: thank you - it's been almost a week :( And it;s not only one thing that does not work on beta [23:43:08] <matt_flaschen> Okay, I guess I'll debug into edit-topic-title locally and file that separately. [23:43:13] <matt_flaschen> Locally other ones work... [23:43:39] <etonkovidova> matt_flaschen: crosswiki works locally? [23:43:55] <etonkovidova> matt_flaschen: with master? [23:44:27] <matt_flaschen> etonkovidova, I got the cross-wiki backend working locally. I hit a problem, so I still haven't tested it in full locally. [23:45:05] <etonkovidova> matt_flaschen: yes, that what I understood [23:45:24] <matt_flaschen> etonkovidova, you didn't file a bug about notifications not working on Beta (not even single-wiki), did you? I just don't want a duplicate task. [23:46:25] <etonkovidova> matt_flaschen: I did not file tasks - cause beta was overall broked - cannot even navigate to some pages and Error page is displayed after couple of action [23:46:35] <matt_flaschen> Okay, I'm going to [23:46:55] <matt_flaschen> etonkovidova, were single-wiki notifications working for you before, or neither single-wiki nor cross-wiki? [23:47:19] <etonkovidova> matt_flaschen: and, in fact, some notifications (not sure if all of them) do come - with some random delay [23:47:50] <matt_flaschen> etonkovidova, okay, let me check if Beta is using the job queue. Also, which domain do you normally use on Beta? I was testing enwiki beta just now. [23:48:16] <etonkovidova> matt_flaschen: enwiki, cawiki, and hewiki [23:48:28] <matt_flaschen> Okay, thanks. [23:49:22] <matt_flaschen> Ahg! Why are we using job queue everywhere on Beta when we hardly use it in production. [23:49:37] <etonkovidova> matt_flaschen: do we have EventLogging in betalabs db like we have it in analytic-slave production? [23:49:47] <etonkovidova> matt_flaschen: I do not see it in db1.eqiad.wmflabs... [23:50:07] <matt_flaschen> etonkovidova, it is hooked up in Beta, though it uses the schemas from production metawiki. Can you ask in #wikimedia-analytics ? [23:50:27] <etonkovidova> matt_flaschen: thx will do [23:52:10] <matt_flaschen> etonkovidova, well, that explains the random delay, and probably the job queue just breaks ocasionally on Beta, which is why they fail entirely. I would like it to shadow production, so e.g. since we don't use job queue for production enwiki, we don't use it for Labs enwiki either. [23:57:44] <matt_flaschen> etonkovidova, https://gerrit.wikimedia.org/r/266949 [23:58:00] <etonkovidova> matt_flaschen: thanks and hopefully there will be one problem less!