[00:26:35] eh, there are so many exceptions to our projects' names [00:26:57] The only reason I'm okay with this code is because it's supposedly a one-time-script to only get a base list [00:27:12] otherwise it is pretty shameful [00:55:27] mooeypoo, example? I know a few of the language codes are funky... [00:58:15] look at the "specials" bit at the bottom of https://en.wikipedia.org/w/api.php?action=sitematrix&format=jsonfm&formatversion=2 [01:01:00] mooeypoo, oh, the "Wikipedia" thing. Yeah, that's messed up (all the ones ending in wiki are wrongly considered Wikipedia). [01:01:18] For zero, they really shouldn't have used that DB name also... [01:01:33] matt_flaschen: Originally the DB name was just 'wiki'. [01:01:38] James_F, for zero? [01:01:43] Or enwiki? [01:01:49] matt_flaschen: Be happy we specified it down to 'enwiki'. ;-) [01:02:04] Well, everyone knows they're only un idioma. [01:02:06] matt_flaschen: The latter, sorry. [01:02:28] * James_F nods. [01:02:42] James_F, also, we really shouldn't make new wikis with DB name ending in wiki, unless they're Wikipedias. [01:02:45] At this point we know better. [01:02:50] That includes the Wikimanias. [01:03:17] matt_flaschen: I think at this point we should stop pretending that there's a programmatic link between the db name and the site type. [01:03:29] One rule with 200 exceptions is no rule at all. [01:03:43] James_F, yeah. It would be nice if there was a programmatic way to detect if I'm on a Wikipedia, though. [01:04:16] mooeypoo, also, https://upload.wikimedia.org/wikipedia/commons/e/e8/Point_de_vue_du_Gras_by_Ni%C3%A9pce%2C_1826.jpg [01:04:22] matt_flaschen: For choosing to deploy stuff in config, server side, or client side? [01:04:39] James_F, say, in WikimediaMessages to use a different message key. [01:05:31] That's not a variant URL, that *is* the URL... [01:05:48] James_F probably knows whether Wikimedia Commons was briefly called Wikipedia Commons or whether there's even less excuse. [01:06:36] matt_flaschen: I'd just use {{SITENAME}} with remote evaluation. ;-) [01:07:08] I'm too scared to ask what remote evaluation is. [01:07:11] ;) [01:07:11] :-D [02:03:04] 3Collaboration-Team-Current, 10Flow, 10Thanks, 10Notifications, 7user-notice: wikitext in flow titles is parsed (HTML tags like and templates) on echo notifications - https://phabricator.wikimedia.org/T120291#1964759 (10Etonkovidova) See @etonkovidova comment on {120324}. [02:03:37] 6Collaboration-Team-Backlog, 10Notifications: Research the use of notifications and evaluate the designs for the Notification Page - https://phabricator.wikimedia.org/T124416#1964768 (10jmatazzoni) **JM COMMENTS ON NOTIFICATION PAGE PROTOTYPE FROM 1/22/16** http://pauginer.github.io/prototypes/notifications/n... [02:15:57] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 7Varnish: Varnish failed to provision - https://phabricator.wikimedia.org/T124711#1963478 (10Mattflaschen) [02:41:12] anyways, matt_flaschen it's not just the 'Wikipedia' thing.. things like "Wikimania 2016" etc, or Wikimedia Argentina, or Wikimedia Belgium, etc.. their dbnames are unhelpful to automatically pick out the right names and neither are their "code" -- and the "sitename" is just not helpful, since it appears in the respective language. [02:41:19] Some of those are private wikis that I should ignore, but some aren't. [02:43:05] * matt_flaschen nods [02:46:37] matt_flaschen, I would love to share this script code to have a second pair of eyes on it, but it's *not for merge* and I'm using the blankpage for convenience... [02:46:51] Should be okay if I tag the commit as [DONOTMERGETHISEVER] or something? [02:48:11] mooeypoo, yeah. [02:48:41] mooeypoo, but you should extend BlankPage. It will be more object-oriented that way. [02:48:43] ;) [02:49:34] oh the number of things I "should" be doing better in that commit is staggering :P [02:49:48] :) [02:49:57] I'm being somewhat lazy, I am concentrating more on the output than the quality of the code... so... I hope you don't get blind looking at it [02:50:11] * mooeypoo removes responsibility [02:50:11] :p [02:50:18] The BlankPage thing was a joke anyway, no need for maintainable code if it's only supposed to run once... [02:50:26] Said many the developer of a batch job that still runs today... [02:50:34] The only issue I have is that this will pop up in "CORE" queue [02:50:36] ... eh [02:50:41] haha [02:50:46] mooeypoo, abandon it real fast. ;) [02:51:04] Or better don't worry about it. [02:51:10] mooeypoo, do you by any chance have the varnish role enabled? [02:51:18] oh, not yet [02:51:37] Okay, never mind, there is a stupid provisioning error, but I think I may just hack around it. [02:51:51] I'm not sure if it effects new installs or only upgrades and don't want to wait 20 minutes to find out. [02:52:10] I would fix it if it also hit new installs, but if so I'm sure we'll here about it. [02:53:43] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 7Varnish: Varnish failed to provision - https://phabricator.wikimedia.org/T124711#1964822 (10Mattflaschen) Questions I asked on IRC: ``` [01/25/16 21:38] gilles, in https://gerrit.wikimedia.org/r/#/c/265370/ is there a reason the varnish user... [02:54:00] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 7Varnish: Varnish failed to provision - https://phabricator.wikimedia.org/T124711#1964823 (10Mattflaschen) 5Open>3declined For now at least. See above. [02:55:40] https://gerrit.wikimedia.org/r/#/c/266461/ <-- matt_flaschen [02:56:08] Reviewing [02:56:50] I think my "do not merge this" was pretty thorough with the warnings and -2... and yet I half wish I could put a tag around that warning [02:56:50] :D [02:58:07] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Vagrant: Use custom $wgFlowCluster and $wgFlowDefaultWikiDb in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T121827#1964827 (10bd808) [02:58:10] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 6Security, 5Patch-For-Review: MediaWiki should not connect as root database user on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T86373#1964826 (10bd808) 5Open>3Resolved [02:58:28] mooeypoo, although what you should do as a good citizen is add this to https://wikitech.wikimedia.org/wiki/Add_a_wiki once the initlal list is merged. [02:58:56] matt_flaschen, not really, though... when you add a wiki, you add a SINGLE wiki, you won't need this script [02:59:08] but we should add the "add the new wiki name to the message" in there [02:59:10] mooeypoo, I know. I mean to just add that one wiki to WikimediaMessages. [02:59:14] Sorry, jinx [02:59:15] oh, right, yes [02:59:27] I also want to make sure my message prefix is reasonable [03:00:36] oh, crap, I have a syntax error in there [03:00:37] [03:00:48] "syntax error, unexpected ')'" ... thanks, mediawiki [03:01:42] Okay, that's more WAT-y than I expected. Not the code, just what's missing. [03:02:06] Though to be fair, Wikibase is just the platform powering Wikidata, so there's no reason they should have a message for Wiktionary if they happened not to use it for their feature. [03:02:24] Though I actually don't know why that's not in the sidebar. [03:03:17] Some of the messages have different prefixes btw [03:03:36] it's even worse.. :\ so I couldn't even do an automatic search properly with "blah-bla-message-" . $dbname [03:05:21] mooeypoo, well, that's because they're used for different features. I could get into my theory of why there's no Wiktionary for either, but it's kind of off topic. [03:05:46] yeah but that aids my point regarding needing a proper consistent message for our projects [03:05:49] mooeypoo, why are you making exceptions even when the sitename is right for a special. [03:05:58] E.g. Wikimedia Commons [03:06:02] It's not always right? [03:06:12] I couldn't use the sitename for them all, though [03:06:50] But you could just use exceptions when it's actuallly wrong. [03:06:53] https://en.wikipedia.org/w/api.php?action=sitematrix&format=jsonfm&formatversion=2 <-- look for 'ruwikimedia' [03:07:12] Or not necessarily wrong, but wrong or non-English. [03:07:13] I guess so.. I didn't really trust it at all, honestly, but yeah [03:07:38] Some are right, some are wrong. I think it's probably that some people bothered when setting up the wiki, others didn't. [03:08:01] Even several of the ones ending in wiki are right. [03:08:28] mooeypoo, legoktm, when cross-wiki notifications is fully rolled out, what will it include? [03:08:33] Some had "Wikipedia" when it's not... some had weird names in therre, some had non english names [03:08:37] what do you mean? [03:08:43] Yeah, I'm not arguing some are straight wrong. [03:08:45] what wikis? [03:08:58] I'm just saying you could list just the ones that are actually exceptions, but doesn't need to be changed now. [03:09:01] matt_flaschen, yeah, no, that's part of the reason I just went for "they're all friggin exceptions" [03:09:13] Want to double-check the part in that script about fishbowl, closed, private. [03:09:19] but yes, I went over a bunch and then just stopped bothering to check one-by-one... but you're right [03:09:20] I.E. whether cross-wiki needs them. [03:09:30] oh, as far as I understood, that's a no [03:09:32] mooeypoo, although maybe we should just do all regardless for the next person? [03:09:36] but... not sure now? [03:09:53] Good point [03:12:57] mooeypoo, you didn't have any problems from the language code? [03:13:49] I didn't go over all the messages I got, but so far I don't think so [03:14:21] I think the "code" part gives me the correct language code even if the domain prefix isn't the same [03:14:28] Cool [03:14:32] but I'll have to examine more when the messages are produced [03:14:43] for now I'm trying to figure out where the hell I have an extra ) [03:15:13] mooeypoo, it didn't explode on simple? [03:15:26] That is actually in the regular list, don't know if it's a cldr code but actually maybe. [03:15:30] oh... hm, it didn't explode before, but I didn't check "simple" [03:16:07] I can't verify because the code's dead right now >.< [03:17:17] mooeypoo, line 118 [03:17:27] Like I said, use Zend. :) [03:18:01] ... omg [03:18:04] okay, I need to use that [03:19:13] Hm. I am still getting the project names in other languages [03:19:57] There we go [03:20:03] mooeypoo, keep zend role off (to use hhvm by default), then use php5.local.wmftest.net:8080/wiki/Special:BlankPage when you need it (either for that or if HHVM XDebug gives you problems). [03:21:11] ok, thanks for that, bookmarked the local domain [03:21:24] matt_flaschen, ok, I fixed up 2 errors I found and now it at least shows english-only names, so.. progress [03:21:36] I'll push it in, -2 again, and then retire for the evening and continue tomorrow [03:21:49] I think it's the right *direction* at least... now there's the exceptions and additions [03:22:01] should I abandon the patch and move it to some github gist or something [03:22:03] ? [03:22:18] mooeypoo, it's fine. As long as it's -2'ed it shouldn't be a problem. [03:23:10] ok, -2 doesn't go away with new patchsets? [03:23:15] i thought it gets reset [03:23:20] mooeypoo, no that's the difference with -1. [03:23:24] oh, that's right [03:23:36] ok, so I am safe. I fixed it up a bit, if you run it you'll see the list [03:23:44] it's at least all English [03:23:56] ... most... crap, I just noticed an arabic one [03:25:08] ... You know what I just realized? [03:25:16] matt_flaschen, .... we... need... qqq.json ... [03:25:36] mooeypoo, isn't it all the same, though? [03:25:46] "Human-readable name for abwiki" [03:25:57] [19:08:28] mooeypoo, legoktm, when cross-wiki notifications is fully rolled out, what will it include? <-- what is "it"? [03:25:57] They might even template it, but I wouldn't worry about that. They can do it if they want to. [03:25:57] I guess we can make them the same with the change of the human-readable name [03:26:07] legoktm, which wikis, i.e. fishbowl, etc.? [03:26:20] mooeypoo, what do you mean? [03:26:34] matt_flaschen: all SUL linked wikis, minus loginwiki [03:26:53] legoktm, okay, so that includes pretty much everything except wikitech, right? [03:27:07] Including closed, private, fishbowl. [03:27:28] no, those are not SUL linked [03:27:43] matt_flaschen, "Human readable name for German Wikipedia" is better than "Human readable name for dewiki" ? [03:27:43] Oh, okay, thanks. [03:28:21] We can also play with the variation of it [03:28:25] mooeypoo, yeah. Though the translators will see the English, so it's not a big deal. [03:28:36] True [03:28:45] Plus, hopefully we won't have any errors [03:29:06] Okay, I'm going to head out too. [03:29:09] ok, I'm going to leave for the evening [03:29:12] jinx [03:29:17] what is it, third time today? [03:29:18] :d [03:29:23] have a good night ! see you tomorrow [03:29:44] matt_flaschen: the return value of GlobalUserPage::getEnabledWikis() on the cluster should be all the wikis [03:30:48] legoktm, thanks. [03:44:05] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Integrate cross-wiki notifications - https://phabricator.wikimedia.org/T121829#1964874 (10Etonkovidova) Checked in betalabs - below are some screenshots to illustrate crosswiki notifications in flyout.... [03:49:45] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Inconsistent distance between actions in cross-wiki notifications - https://phabricator.wikimedia.org/T123762#1964881 (10Etonkovidova) Checked in betalabs - the space on both sides of ellipses is equal... [05:46:36] (03CR) 10Liangent: Introduce congratulatory notifications for reaching edit thresholds (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) (owner: 10Jforrester) [07:53:14] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Fix link i18n messages - https://phabricator.wikimedia.org/T91598#1965035 (10matej_suchanek) [08:09:10] 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10Notifications, 7user-notice: Revise Sorting of Notifications on the Fly-Out Menu - https://phabricator.wikimedia.org/T123018#1965051 (10Quiddity) [08:12:23] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Inconsistent distance between actions in cross-wiki notifications - https://phabricator.wikimedia.org/T123762#1965053 (10Pginer-WMF) >>! In T123762#1964881, @Etonkovidova wrote: > Checked in betalabs -... [08:23:50] (03PS1) 10Matthias Mullie: Display human-readable wiki names for cross-wiki notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266474 (https://phabricator.wikimedia.org/T121936) [08:26:42] (03CR) 10Mooeypoo: [C: 04-1] "We're already working on the list of 900 wikis, according to the discussion on that ticket. There's a script in the works, and an experime" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266474 (https://phabricator.wikimedia.org/T121936) (owner: 10Matthias Mullie) [08:27:07] mlitn, yo, you there? [08:27:14] yeah [08:27:24] I just noticed there’a a pretty long converstation that I hadn’t read :) [08:27:27] I just don't want you to waste time :p [08:27:30] I’m catching up now :p [08:27:44] Hehe yeah, and I'm working on it -- I just forgot to move it to "in development" since it was under discussion for so long [08:28:04] There's a script I'm working on. It's ugly as hell, but it is meant for a one-time run to produce the base messages: https://gerrit.wikimedia.org/r/#/c/266461/ [08:29:27] 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10Notifications, 7user-notice: Revise Sorting of Notifications on the Fly-Out Menu - https://phabricator.wikimedia.org/T123018#1965081 (10Quiddity) [08:29:39] I also have an extremely-wip-experimental patch that does similar to what you created, but it has a bunch of issues... first, there are a lot of exceptions to namings of projects, and the "siteFromDB" doesn't really work well for many of them... *however* your fallback seems a lot better than my attempt [08:29:48] We should keep yours as the fallback, probably [08:30:22] I just ran into tons of exceptions to the naming, and lots of inconsistencies with the dbnames that siteFromDB couldn't figure out :( [08:30:41] 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10Notifications, 7user-notice: Revise Sorting of Notifications on the Fly-Out Menu - https://phabricator.wikimedia.org/T123018#1919410 (10Quiddity) [08:31:02] mlitn, https://gerrit.wikimedia.org/r/#/c/265876/ <-- my (ugly...ugly) experimental patch [08:31:43] mlitn, it's similar to yours, except it tries to also take into account the exception cases... which is also why it's ugly and crappy. It shouldn't be meged in production with production-names and such. But that seems to make things clear about needing i18n message list [08:36:38] damn, that’s a lengthy discussion :) [08:37:50] (03CR) 10Matthias Mullie: [C: 04-2] "Damn, I hadn't noticed there was a very lengthy discussion on that ticket :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266474 (https://phabricator.wikimedia.org/T121936) (owner: 10Matthias Mullie) [08:41:30] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1965089 (10Mooeypoo) >>! In T121936#1961678, @matmarex wrote: > I like the idea of translateable messages for each wiki, and I... [08:41:41] mlitn, aye, that's why I wanted to point it out before you rush to work on code :D [08:42:28] yeah, I have a bad habbit of starting to work on things & only then do the rest of the housekeeping [08:42:40] your patch should replace my crappy experiment though. I'll abandone mine. -- but we do need to see how it behaves with the exception cases like Mediawiki and Commons and some others that have seriously frustrated the hell out of me in the past days [08:42:43] I was about to move it to “awaiting review” when I noticed it had your name [08:42:48] and then I noticed the discussion :) [08:42:54] and by then, you had also responded :p [08:43:14] I got the email and wondered what patch was added to this lengthy convoluted discussion... [08:43:15] :D [08:43:23] ^^ [08:43:38] Mine only does what was initially proposed, in task summary [08:44:00] Yeah, that's a good thing for the fallback in any case [08:44:13] “Project - Language”, or just “Language” if on the same project (or only “Project” for things like commons) [08:44:27] Someone also proposed that some of the fallback might be better in core, but I'll let that be a separate argument/discussion.... [08:44:31] all of the i18n-able combinations are not in there [08:44:52] Yeah, there are tons of language-related issues with those, though :( [08:45:22] "Hebrew Wikipedia" is written completely differently in Hebrew. It's more like "The Wikipedia The Hebrew" [08:45:44] so producing automated compound names will be somewhat weird in some languages. That's why we started discussing i18n messages for all of our projects [08:46:16] Also, I really think we should have that available to other codebase... the fact there's no real way of getting a project name, from its dbname, in the user language, is weird to me. [08:46:22] yeah, that shouldn’t be part of echo, that should be folded into core [08:46:36] Yeah. The messages themselves will be in WikimediaMessages [08:46:43] (I’m worried half of them will never be properly translated though, but what do I know :p) [08:46:50] yeah, that’s where they should be [08:46:53] Yeah, no, you're not the only one [08:47:13] We're discussing that now too... thing is.. it might still be better than the compound words [08:47:24] Having it appear in English may be better than having it be half-gibberish [08:47:44] And we can try and help the translations. If the script creates the english version properly, then creating other languages should be relatively easy. [08:48:20] yeah, translations should probably be left to translators entirely [08:48:34] unless for the languages we speak ourselves and can confidently generate :p [08:48:54] Indeed [08:49:12] but I’m sure you, Amir, Niklas, … know much more about that subject :) [08:49:20] the right people seem to be involved already ) [08:49:29] And maybe send a note to i18n and actively poach for translators. It's a lot of messages, but it's only a one-time translation project [08:49:42] Yeah, I asked Amir to pitch in [08:50:16] Anyways, I'm going to sleep ;) I'll see you in standup! [08:50:23] night :) [08:51:51] night! [08:55:35] 3Collaboration-Team-Current, 10Notifications, 7I18n, 5Patch-For-Review: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1965091 (10Nikerabbit) Can/should we place the automatically generated names somewhere which we can link from qqq? [11:32:49] (03PS3) 10Sbisson: Truncate page titles and topic titles in notifications header message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265521 (https://phabricator.wikimedia.org/T121822) [14:19:15] (03CR) 10Sbisson: Truncate usernames, titles and excerpts in notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265495 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [14:20:08] (03CR) 10Sbisson: Truncate page titles and topic titles in notifications header message (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265521 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [16:21:38] (03CR) 10Sbisson: [C: 031] "I will +2 this afternoon after the cut." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265549 (https://phabricator.wikimedia.org/T121935) (owner: 10Mooeypoo) [16:31:13] stephanebisson: There's no cut today. [16:31:48] James_F: oh, are we not back to the regular scheduled programs? [16:32:01] (The whole train derailment last week means they're re-running last week's train; wmf.12 will be cut in a week's time.) [16:32:27] ok, thanks for letting me know [16:33:57] (03CR) 10Sbisson: [C: 032] "No train this week so we can play with this a bit before it goes out." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265549 (https://phabricator.wikimedia.org/T121935) (owner: 10Mooeypoo) [16:37:14] (03Merged) 10jenkins-bot: Add 'mark as read' as secondary action to unread notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265549 (https://phabricator.wikimedia.org/T121935) (owner: 10Mooeypoo) [17:43:41] 3Collaboration-Team-Current, 10Flow: Mention in topic title does not generate flow-mention notification - https://phabricator.wikimedia.org/T124794#1966201 (10SBisson) 3NEW [17:51:45] 3Collaboration-Team-Current, 10Flow: Clicking "change title" does not give user feedback - https://phabricator.wikimedia.org/T124796#1966228 (10SBisson) 3NEW [18:02:27] (03CR) 10Sbisson: [C: 032] Move remaining usage of EchoGetDefaultNotifiedUsers into UserLocator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265460 (owner: 10Matthias Mullie) [18:06:17] (03Merged) 10jenkins-bot: Move remaining usage of EchoGetDefaultNotifiedUsers into UserLocator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265460 (owner: 10Matthias Mullie) [18:09:48] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Add "mark as read" as a deprioitized secondary action to every unread notification - https://phabricator.wikimedia.org/T121935#1966294 (10Luke081515) [18:13:28] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Overflow on Notification panel with very long page names - https://phabricator.wikimedia.org/T123657#1966312 (10Luke081515) [18:13:30] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11), 7user-notice: Add excerpt of edit summary to reverted notification - https://phabricator.wikimedia.org/T121808#1966313 (10Luke081515) [18:13:32] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 7user-notice: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#1966314 (10Luke081515) [18:27:25] 3Collaboration-Team-Current, 10Flow: Creating a new topic with a mention generates both events - https://phabricator.wikimedia.org/T124803#1966448 (10SBisson) 3NEW [18:28:42] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Create new notification category for talk pages: flowusertalk - https://phabricator.wikimedia.org/T121663#1966458 (10SBisson) >>! In T121663#1896823, @jmatazzoni wrote: > **Mention:** we don't need a new item for flowusertalk-mention. As now ha... [18:35:06] legoktm: standup? [18:38:41] (03PS4) 10Matthias Mullie: Engage full surveillance mode for Flow talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) [18:38:56] stephanebisson: just rebased, it was trivial enough :) [18:39:06] mlitn: thanks [18:47:40] (03CR) 10Mooeypoo: "I'm abandoning my (botched and yucky) patch and instead keeping yours for now. Having this as a fallback to the messages is probably a goo" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266474 (https://phabricator.wikimedia.org/T121936) (owner: 10Matthias Mullie) [18:48:18] (03Abandoned) 10Mooeypoo: [EXPERIMENTAL] [WIP] Hack a human-readable temporary solution for wiki names [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265876 (https://phabricator.wikimedia.org/T121936) (owner: 10Mooeypoo) [19:10:04] 6Collaboration-Team-Backlog, 10Flow, 7Design, 7Easy: Flow: Topic history page doesn't reflect action in h1 heading or tag - https://phabricator.wikimedia.org/T72472#1966701 (10dg711) Provision : https://phabricator.wikimedia.org/P2530 Reload : https://phabricator.wikimedia.org/P2529 [20:05:17] <grrrit-wm> (03CR) 10Sbisson: [C: 04-1] "Creating a new topic on a talk page generates both flow-new-topic and flow-post-reply notifications." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [20:28:32] <grrrit-wm> (03PS2) 10IoannisKydonis: Simplify flow-error-parsoid-failure for end users. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265703 [21:11:27] <grrrit-wm> (03PS1) 10Sbisson: Make TopicTitleWidget pending on save [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266588 (https://phabricator.wikimedia.org/T124796) [21:11:41] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Clicking "change title" does not give user feedback - https://phabricator.wikimedia.org/T124796#1967326 (10SBisson) a:3SBisson [21:13:51] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Make TopicTitleWidget pending on save [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266588 (https://phabricator.wikimedia.org/T124796) (owner: 10Sbisson) [21:14:29] <grrrit-wm> (03PS2) 10Sbisson: Make TopicTitleWidget pending on save [extensions/Flow] - 10https://gerrit.wikimedia.org/r/266588 (https://phabricator.wikimedia.org/T124796) [21:15:27] <wikibugs> 3Collaboration-Team-Current, 10Notifications: Put email subject in notification body of emailuser notifications - https://phabricator.wikimedia.org/T121831#1967354 (10SBisson) >>! In T121831#1889636, @Legoktm wrote: > Does MediaWiki store this info anywhere else? I'm not sure what the privacy expectations are... [21:18:13] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Clicking "change title" does not give user feedback - https://phabricator.wikimedia.org/T124796#1967361 (10SBisson) p:5Triage>3Normal [21:20:18] <matt_flaschen> Getting lunch [21:21:09] <mooeypoo> me too, though half a country away [21:37:26] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications: Fatal error: Cannot redeclare class CallbackFilterIterator when linting (pre-deploy) on mira - https://phabricator.wikimedia.org/T124828#1967418 (10dduvall) 3NEW [21:37:46] <marxarelli> hey all. ^ is holding up the train [21:38:12] <marxarelli> fyi :) [21:39:32] <marxarelli> might need a !class_exists from the looks of it [21:44:10] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications: Fatal error: Cannot redeclare class CallbackFilterIterator when linting (pre-deploy) on mira - https://phabricator.wikimedia.org/T124828#1967460 (10dduvall) More context from the [[ https://wikitech.wikimedia.org/wiki/Server_Admin_Log#2016-01-26 | SAL ]]: ``` == 2... [21:51:26] <grrrit-wm> (03PS1) 10BryanDavis: Wrap CallbackFilterIterator in an check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266598 (https://phabricator.wikimedia.org/T124828) [21:52:44] <grrrit-wm> (03CR) 10Reedy: [C: 031] Wrap CallbackFilterIterator in an check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266598 (https://phabricator.wikimedia.org/T124828) (owner: 10BryanDavis) [21:54:10] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Wrap CallbackFilterIterator in an check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266598 (https://phabricator.wikimedia.org/T124828) (owner: 10BryanDavis) [21:57:35] <grrrit-wm> (03PS2) 10BryanDavis: Wrap CallbackFilterIterator in a condition check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266598 (https://phabricator.wikimedia.org/T124828) [22:01:09] <grrrit-wm> (03PS1) 10Dduvall: Wrap CallbackFilterIterator in a condition check [extensions/Echo] (wmf/1.27.0-wmf.11) - 10https://gerrit.wikimedia.org/r/266601 (https://phabricator.wikimedia.org/T124828) [22:01:31] <grrrit-wm> (03CR) 10Dduvall: [C: 032] Wrap CallbackFilterIterator in a condition check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266598 (https://phabricator.wikimedia.org/T124828) (owner: 10BryanDavis) [22:03:10] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10RESTBase: Migrate Flow to talk with RESTBase instead of Parsoid - https://phabricator.wikimedia.org/T124837#1967531 (10ssastry) 3NEW [22:06:11] <grrrit-wm> (03Merged) 10jenkins-bot: Wrap CallbackFilterIterator in a condition check [extensions/Echo] - 10https://gerrit.wikimedia.org/r/266598 (https://phabricator.wikimedia.org/T124828) (owner: 10BryanDavis) [22:06:14] <grrrit-wm> (03CR) 10Dduvall: [C: 032] Wrap CallbackFilterIterator in a condition check [extensions/Echo] (wmf/1.27.0-wmf.11) - 10https://gerrit.wikimedia.org/r/266601 (https://phabricator.wikimedia.org/T124828) (owner: 10Dduvall) [22:09:26] <grrrit-wm> (03Merged) 10jenkins-bot: Wrap CallbackFilterIterator in a condition check [extensions/Echo] (wmf/1.27.0-wmf.11) - 10https://gerrit.wikimedia.org/r/266601 (https://phabricator.wikimedia.org/T124828) (owner: 10Dduvall) [22:10:02] <wikibugs> 3Collaboration-Team-Current, 10Notifications: Put email subject in notification body of emailuser notifications - https://phabricator.wikimedia.org/T121831#1967562 (10Legoktm) @Jalexander is probably a good start? :) [22:33:58] <mooeypoo> eh. matt_flaschen LanguageNames::getNames( 'en' ); returns some results not in English. This ruins my fallbacks :\ [22:35:13] <matt_flaschen> mooeypoo, yeah, I was guessing that was the case when you said one was randomly in Arabic. How many are there like that? [22:39:54] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): "Could not retrieve notifications" error message should not contain raw "$1" - https://phabricator.wikimedia.org/T123797#1967816 (10Etonkovidova) The following will be displayed as in the screenshot bel... [22:49:31] <wikibugs> 3Collaboration-Team-Current, 10Notifications: Put email subject in notification body of emailuser notifications - https://phabricator.wikimedia.org/T121831#1967876 (10Mattflaschen) And @mpaulson of Legal. [22:56:27] <mooeypoo> matt_flaschen, not that many. I can't find a decent solution for it, I may have to manually fix them [22:56:49] <mooeypoo> I'm trying to think if we will ever need this script for long-term stuff at all [22:57:13] <mooeypoo> if not, we shouldn't bother trying that hard for fallbacks, but if we want to use it to produce auto-translations for languages, then.... [22:57:33] <matt_flaschen> mooeypoo, only thing I can think of is if someone wants to run it for another language, where the CLDR data is pretty good and (like English) they don't have to worry about grammar issues. [22:57:58] <matt_flaschen> That's not essential, though (they can be done via normal translation). I think MatmaRex said he is working on a different approach for Polish as well. [22:58:07] <mooeypoo> Yeah that's what I was wondering [22:58:16] <mooeypoo> okay, I won't worry about it much then. I think I'll try to manually fix them up [22:58:30] <mooeypoo> still dealing with a couple of exceptional names in the code, but I think i'm almost there [22:58:52] <mooeypoo> Also, removed the ignoring of fishbowl and private wikis, so we'll have those names too, but I left the statement for ignoring closed wikis [22:58:57] * MatmaRex perks up his ears [22:59:10] <mooeypoo> MatmaRex, wanna see the ugliest script ever? [22:59:15] <MatmaRex> heh [22:59:16] <mooeypoo> ... okay, not ever. There were uglier out there [22:59:31] <mooeypoo> seriously, though, I'm working on the one-time-script to produce the base i18n messages for the human-readable project names [22:59:44] <mooeypoo> https://gerrit.wikimedia.org/r/#/c/266461/ [23:00:28] <wikibugs> 3Collaboration-Team-Current, 10Flow, 6Security, 5Patch-For-Review, 7Security-Extensions: XSS in Flow topic titles - https://phabricator.wikimedia.org/T120324#1967935 (10Bawolff) @Mattflaschen To clarify, did you re-open due to further security issues, or do you just have related concerns with title handl... [23:02:19] <wikibugs> 3Collaboration-Team-Current, 10Flow, 6Security, 5Patch-For-Review, 7Security-Extensions: XSS in Flow topic titles - https://phabricator.wikimedia.org/T120324#1967942 (10Mattflaschen) 5Open>3Resolved I don't think any of the remaining parts are strictly security. I'll use {T120291} and file a new bug... [23:02:50] <matt_flaschen> mooeypoo, do you need to exclude closed? I'm just thinking it might be better to do all, in case closed is displayed anywhere in the future that would want this. [23:03:10] <mooeypoo> I can do that, I just thought that "closed" is eternal [23:03:21] <mooeypoo> and they've lost their usefulness...? but I might be wrong [23:03:35] <MatmaRex> mooeypoo: i must say that looks better than i expected. :P [23:03:48] <mooeypoo> We're going to have about 900 messages, I didn't want to spam with unnecessary ones, especially since we will need to trust translators with them [23:03:59] <matt_flaschen> mooeypoo, they're closed, but they're still accessible. [23:04:19] <mooeypoo> MatmaRex, haha thank you :P lots of fallbacks and annoying twisty exceptions :\ but there doesn't seem to be a good way around it for now [23:04:41] <mooeypoo> matt_flaschen, yeah, good point. I just wanted to try and reduce the load on the translators to only things we actually need [23:04:46] <matt_flaschen> I just think it's better to error on the over-thorough. There are 130, though, so it is a bit of work. I don't feel that strongly about it. [23:05:17] <mooeypoo> I was going to start another patch with the messages in WikimediaMessages and then tweak/fix the incomplete ones [23:05:32] <mooeypoo> Let me count how many are produced [23:05:57] <mooeypoo> (Also, I'm missing some of the other "specials" still) [23:06:05] <wikibugs> 3Collaboration-Team-Current, 10Thanks, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Add secondary link to Flow board for flow-thanks notifications - https://phabricator.wikimedia.org/T121954#1967963 (10Etonkovidova) Checked locally and on test.wikipedia. {F3283991} [23:06:11] <matt_flaschen> mooeypoo, closed is not eternal: 50391a46076aa5e4fee1c94d4e333b25a31bc1ba [23:06:32] <MatmaRex> mooeypoo: hmm, is that handling domain names being different from language names? [23:06:40] <MatmaRex> i'm not sure what "code" is… [23:06:51] <MatmaRex> the sitematrix format is pretty creative. [23:07:15] <mooeypoo> MatmaRex, it *seems* to from my output, but there are still a few that aren't loaded correctly (see my question in #mediawiki-i18n) so maybe not [23:07:28] <mooeypoo> but there are few of those exceptions, so at this point, since it's one-time, we can probably fix those by hand [23:07:30] <MatmaRex> like which ones? (i'm not in that channel) [23:07:40] <mooeypoo> hang on let me see [23:07:52] <MatmaRex> hmm [23:07:57] <MatmaRex> als vs gsw should be one [23:07:58] <mooeypoo> <mooeypoo> Nikerabbit, also, I am looking at the output from LanguageNames::getNames( 'en' ); and some of those results are not in English (example, 'azb' => 'تۆرکجه' and 'zh-my' => '中文（马来西亚' ) ==> is there a way to force the output to only give me results in English, and not hand out the results that aren't available in English, so that I can have my own fallback in the code? [23:08:13] <MatmaRex> and i'm sure be-tarask and be-x-old are also problematic [23:08:20] <mooeypoo> MatmaRex, actually, "project-humanreadable-name-alswiki": "Alemannisch Wikipedia" [23:08:20] <matt_flaschen> And maybe simple? [23:08:22] <mooeypoo> that works [23:08:35] <mooeypoo> yeah simple is one of those that I still need to work on [23:08:54] <mooeypoo> "project-humanreadable-name-simplewiki": "Simple English Wikipedia" [23:08:54] <mooeypoo> "project-humanreadable-name-simplewiktionary": "Simple English Wiktionary" [23:08:57] <MatmaRex> mooeypoo: yeah, i just mean that we have als.wikipedia.org and alswiki, but the language code for it is gsw. [23:09:01] <mooeypoo> (It's missing a few of the simple projects) [23:09:38] <MatmaRex> so you might need to look at LanguageNames::getNames( 'en' )[ 'gsw' ], instead of …[ 'als' ], or something [23:09:49] <mooeypoo> MatmaRex, yeah, but the above message showed it seems to extract the proper language (Alemannisch? ) [23:10:06] <mooeypoo> http://www.loc.gov/standards/iso639-2/php/langcodes-keyword.php?SearchTerm=gsw&SearchType=ALL [23:10:31] <mooeypoo> MatmaRex, this suggests that the method of using the "code" we're getting from sitematrix is decently working? [23:10:37] <MatmaRex> yeah. interesting. [23:18:29] <mooeypoo> MatmaRex, matt_flaschen I'm actually quite impressed with the output... O.o [23:18:31] <mooeypoo> it's fairly good [23:18:44] <mooeypoo> I just realized that the reason I didn't have all of "simple english" is because 2 of those are marked "closed" [23:18:49] <mooeypoo> checking now after removing that if statement [23:18:58] <mooeypoo> "project-humanreadable-name-simplewiki": "Simple English Wikipedia" [23:18:58] <mooeypoo> "project-humanreadable-name-simplewiktionary": "Simple English Wiktionary" [23:18:58] <mooeypoo> "project-humanreadable-name-simplewikibooks": "Simple English Wikibooks" [23:18:58] <mooeypoo> "project-humanreadable-name-simplewikiquote": "Simple English Wikiquote" [23:19:01] <mooeypoo> \o/ [23:20:27] <mooeypoo> MatmaRex, matt_flaschen https://gist.github.com/mooeypoo/011120a9748a4e06bcf2 <-- initial output [23:20:49] <mooeypoo> There are a couple of languages that are presented wrong, but it seems relatively few... we can just tweak those by hand [23:21:20] <legoktm> you're missing commas :P [23:22:02] <legoktm> awesome though [23:22:10] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11), 5WMF-deploy-2016-02-02_(1.27.0-wmf.12): Fatal error: Cannot redeclare class CallbackFilterIterator when linting (pre-deploy) on mira - https://phabricator.wikimedia.org/T124828#1968032 (10dduvall) Thi... [23:22:12] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-02-02_(1.27.0-wmf.12), 7user-notice: Overflow on Notification panel with very long page names - https://phabricator.wikimedia.org/T123657#1968034 (10Etonkovidova) Checked locally - ellipses are added to indicate long titles... [23:23:56] <mooeypoo> legoktm, HA! you're right! Thanks! :P [23:24:32] <mooeypoo> Also, I need to devise a way to compare the generated list to whatever we have in sitematrix to see if any of the sites are dropped [23:24:57] <mooeypoo> i am fairly sure we're losing a couple from "specials" because of me ignoring the else clause, but i wonder if there are others that are falling between the code-cracks [23:25:40] <legoktm> commons/meta/wikidata/etc are missing, but those are doable by hand I think [23:26:31] <mooeypoo> legoktm, those are supposed to be caught with my "specials" stuff [23:26:32] <mooeypoo> meh [23:26:55] <mooeypoo> Also, I am amused.. there's a yiddish wikipedia! [23:26:59] <mooeypoo> Oy vey! [23:31:22] * mooeypoo stares at the 'specials' section and wonders where it went [23:32:50] <mooeypoo> pfft [23:41:29] <mooeypoo> MatmaRex, legoktm matt_flaschen I've updated the gist, look at the bottom for the "specials" -- I'll have to manually correct most of those. https://gist.github.com/mooeypoo/011120a9748a4e06bcf2 [23:41:38] <mooeypoo> There's no real usable actual pattern to go by :\ [23:46:09] <matt_flaschen> mooeypoo, did you remove the exceptions array from the code? [23:55:47] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 7Design, 7Easy: Flow: Topic history page doesn't reflect action in h1 heading or <title> tag - https://phabricator.wikimedia.org/T72472#1968112 (10Tgr) The relevant parts are ``` ==> default: Notice: /Stage[main]/Role::Echo/Mysql::Sql[create echo_unread_wikis]/Exec[crea... [23:56:42] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 7Regression, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Notifications about being mentioned don't point to the section of the mention anymore - https://phabricator.wikimedia.org/T123847#1968117 (10Etonkovidova) Checked locally - clicking on Me...