[00:04:27] oy, I'm silly [00:04:44] I was meaning to put it in echo and instead put it in settings.pp and then wondered why i get tons of errors [00:08:26] matt_flaschen, remember that "intermittent failure" error "resource temporarily unavailable" when doing vagrant up? [00:08:35] It's pretty common for my machine :( [00:15:25] mooeypoo, hmm. Yeah, I still don't know what actually causes that. Some kind of NFS lock or race condition, I guess. [00:15:34] For me, it *usually* goes away on its own if I just retry. [00:15:54] I get a simliar thing where my editor doesn't always save NFS-shared files the first time, again usually goes away on retry. [00:16:36] mooeypoo, you have the command I gave you to restart NFS? I've never had to do that, but if it's more common on your machine might be useful. [00:23:32] yeah it goes away if I retry, but it's annoying [00:24:52] ok, provision finished, but CORS repeats. I will try without the wildcard, maybe [00:26:00] oh, according to RoanKattouw (who incidentally, apparently, wrote the wgCrossSiteAJAXdomains var) I need to specify the port because it's non-standard [00:26:06] matt_flaschen, vagrant will always use 8080 ? [00:26:29] mooeypoo: nope. the user can change that [00:26:40] Is it a variable in puppet that I can reference? :\ [00:26:57] a FACTOR fact, yeah... let me find it [00:27:13] I'm testing right now with hard coded 8080 port to see if that solves it, but to make it general I will need to do something i think [00:27:18] $::forwarded_port [00:27:26] hmm [00:27:54] Oh, I thought it wasn't necessary but on further thought I see why it is. [00:27:54] puppet is weird. How do you concatenate a string with a var? like in PHP? Like in JS? like in Ruby? [00:28:15] well.. it depends [00:28:25] mooeypoo, PHP style usually works: [00:28:29] 'blah' $var ? 'blah' . $var ? 'blah' + $var ? [00:28:33] easiest is to make a new var that interploates the values [00:28:34] * mooeypoo nods [00:28:58] 127.0.0.1:${::forwarded_port} [00:28:59] I think. [00:29:03] "blah${::forwared_port}" [00:29:03] bd808, what do you mean? [00:29:24] oh, right, I forgot about that [00:29:50] bd808, that won't handle Varnish's 6081, right? Would be good to add that as well. [00:29:58] Since I normally use that. [00:30:41] the varnish port should be a hiera value you can get to [00:30:58] you might have to use scope() in a template to reach it...? [00:31:59] bd808, I agree, it should be... [00:32:39] bd808, looks to be hard-coded everywhere, probably since it's default port. [00:32:52] bleh. we should fix that [00:33:05] bd808, yeah, filing. [00:34:21] https://phabricator.wikimedia.org/T124378?workflow=create [00:37:24] It's not working :\ [00:37:28] still CORS errors [00:39:40] mooeypoo, you re-provisioned, right? [00:39:49] yeah, but I think I found my issue, re-testing [00:54:43] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests: Populate echo_unread_wikis table on all wikis - https://phabricator.wikimedia.org/T124233#1954349 (10Catrope) a:5Catrope>3None [00:59:05] matt_flaschen, bd808 https://gerrit.wikimedia.org/r/#/c/265668/ [00:59:24] Initially the failures were me being an idiot with the quotation marks... now it works [00:59:30] And I confirmed it fixes the CORS error [01:00:22] Cool [01:00:57] mooey, do you think it makes sense to add the 6081 port? [01:01:06] what's that port? [01:01:21] Varnish. To make the caching setup slightly more like production. [01:01:39] E.g. Flow depends on it. [01:01:58] (You don't have to use Varnish with Flow on MWV, but I've been trying to sell people on it) [01:02:09] matt_flaschen, sure... is that a variable too? It wouldn't hurt adding it into the array [01:02:20] mooey, unfortunately not yet. [01:02:34] matt_flaschen, I can just duplicate with the hard-coded port then, for now [01:03:43] matt_flaschen, I added it in [01:03:52] But I can't test with varnish, sinc eI don't have that setup [01:04:13] mooey, I'll test it. [01:05:11] If you want to set it up, you just do enable-role varnish (due to https://phabricator.wikimedia.org/T118605) [01:05:41] (03PS1) 10Mooeypoo: Fix table layout width for bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265670 (https://phabricator.wikimedia.org/T124023) [01:06:35] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Unbalanced space in bundled cross-wiki notifications - https://phabricator.wikimedia.org/T124023#1954371 (10Mooeypoo) a:3Mooeypoo [01:10:38] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-26_(1.27.0-wmf.12): "Could not retrieve notifications" error message should not contain raw "$1" - https://phabricator.wikimedia.org/T123797#1954378 (10Mooeypoo) a:3Mooeypoo [01:15:59] 3Collaboration-Team-Current, 10Notifications: cross-wiki notification: bundled notifications are not counted - https://phabricator.wikimedia.org/T124109#1954390 (10Mooeypoo) Bundled notifications shouldn't be counted in the badge -- that is, the badge should recognize it has an extra (+1) notification that is... [01:17:48] (03CR) 10Catrope: [C: 032] Fix table layout width for bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265670 (https://phabricator.wikimedia.org/T124023) (owner: 10Mooeypoo) [01:18:16] ok, I'm out for the evening. matt_flaschen bd808 thanks for the help! [01:21:36] (03Merged) 10jenkins-bot: Fix table layout width for bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265670 (https://phabricator.wikimedia.org/T124023) (owner: 10Mooeypoo) [06:36:51] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 7user-notice: Roll out cross-wiki notifications beta feature - https://phabricator.wikimedia.org/T124234#1954729 (10matej_suchanek) [08:07:11] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration: Feature request: move to draftspace and tag accordingly - https://phabricator.wikimedia.org/T124396#1954833 (10czar) 3NEW [10:21:57] (03PS1) 10IoannisKydonis: Simplify flow-error-parsoid-failure for end users. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265703 [10:48:16] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow\Exception\FlowException from line 159 of Flow/includes/Formatter/ChangesListQuery.php: Revision not found in revisionCache - https://phabricator.wikimedia.org/T122329#1955007 (10matthiasmullie) I don't really know why this would be happening. But w... [10:48:22] (03PS1) 10Matthias Mullie: Check for & report result of fatal Status objs returned by occupationcontroller [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265707 (https://phabricator.wikimedia.org/T122329) [11:12:03] (03PS2) 10Matthias Mullie: Engage full surveillance mode for Flow talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) [11:12:34] (03PS3) 10Matthias Mullie: Move remaining usage of EchoGetDefaultNotifiedUsers into UserLocator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265460 [11:13:00] (03CR) 10jenkins-bot: [V: 04-1] Engage full surveillance mode for Flow talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [11:17:27] (03PS3) 10Matthias Mullie: Engage full surveillance mode for Flow talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) [11:23:28] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration: Allow moving to draftspace and tagging accordingly - https://phabricator.wikimedia.org/T124396#1955083 (10Aklapper) [12:27:13] (03CR) 10PranavK: Simplify flow-error-parsoid-failure for end users. (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265703 (owner: 10IoannisKydonis) [13:35:05] (03PS3) 10Matthias Mullie: Deprecate ApiEchoNotifications.php format params flyout & html [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264718 [13:39:40] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#1955264 (10Pginer-WMF) [13:44:01] (03PS1) 10IoannisKydonis: Reword thanks-confirmation2 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/265723 [13:44:12] (03PS7) 10Haritha28: Notification when account is blocked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264070 (https://phabricator.wikimedia.org/T100974) [13:51:00] 3Collaboration-Team-Current, 10Notifications, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1955281 (10Nikerabbit) >>! In T121936#1949198, @Amire80 wrote: >> Creating a dynamic message out of elements we already have ("ProjectName" + "Langua... [13:51:17] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LocalisationUpdate, 10Notifications: Some Echo messages don't appear on the live site, even though they were translated - https://phabricator.wikimedia.org/T124415#1955282 (10Amire80) 3NEW [13:52:41] 6Collaboration-Team-Backlog, 10Notifications: Research the use of notifications and evaluate the designs for the Notification Page - https://phabricator.wikimedia.org/T124416#1955291 (10Pginer-WMF) 3NEW a:3Capt_Swing [13:52:49] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#1955298 (10Pginer-WMF) [14:00:08] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LocalisationUpdate, 10Notifications: Some Echo messages don't appear on the live site, even though they were translated - https://phabricator.wikimedia.org/T124415#1955309 (10Reedy) Probably a dupe of T103879 [14:00:43] (03PS1) 10IoannisKydonis: Clarify documentation of apihelp-flow+edit-title-param-content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265725 [14:11:20] (03PS2) 10IoannisKydonis: Reword and add tags to messages [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/265723 [14:19:06] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LocalisationUpdate, 10Notifications: Some Echo messages don't appear on the live site, even though they were translated - https://phabricator.wikimedia.org/T124415#1955350 (10Nikerabbit) So wearing my Holmes gloves: ``` "messages:notification-bundle-heade... [14:32:35] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LocalisationUpdate, 10Notifications: Some Echo messages don't appear on the live site, even though they were translated - https://phabricator.wikimedia.org/T124415#1955361 (10Nikerabbit) 5Open>3Invalid a:3Nikerabbit This behavior is as expected: ``` -... [14:43:09] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-ContentTranslation, 10Notifications, 5ContentTranslation-Release8, and 5 others: Notify translators about new personalised suggestions being available based on their recently published translation - https://phabricator.wikimedia.org/T119939#1955378 (10Arrb... [15:24:14] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LocalisationUpdate, 10Notifications: Some Echo messages don't appear on the live site, even though they were translated - https://phabricator.wikimedia.org/T124415#1955508 (10Amire80) Huh? Ultimately, the expected behavior is that the the live site would sh... [15:35:24] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LocalisationUpdate, 10Notifications: Some Echo messages don't appear on the live site, even though they were translated - https://phabricator.wikimedia.org/T124415#1955525 (10Nikerabbit) >>! In T124415#1955508, @Amire80 wrote: > Huh? Ultimately, the expecte... [15:51:27] (03PS1) 10IoannisKydonis: Add GENDER support to pagetriage-info-problem-blocked [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/265743 [16:05:17] (03CR) 10MtDu: "Thanks for the patch. Please see https://translatewiki.net/wiki/Thread:Translating_talk:MediaWiki/About_MediaWiki:Pagetriage-byline-new-ed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/265743 (owner: 10IoannisKydonis) [16:06:14] (03CR) 10IoannisKydonis: "I have already started doing them. Almost finished :)" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/265743 (owner: 10IoannisKydonis) [16:09:56] 3Collaboration-Team-Current, 10Notifications: cross-wiki notification: bundled notifications are not counted - https://phabricator.wikimedia.org/T124109#1955698 (10Pginer-WMF) > For example, if I have 10 unread notifications locally, and a bundle with 5 unread from wiki1, 2 unread from wiki2, and 1 unread from... [16:16:24] 3Collaboration-Team-Current, 10Flow, 6Security, 5Patch-For-Review, 7Security-Extensions: XSS in Flow topic titles - https://phabricator.wikimedia.org/T120324#1955720 (10Etonkovidova) Please review the following - any suggestions(follow-up bugs/more testing) are welcomed. Tested on test.wikipedia.org |... [16:17:39] 3Collaboration-Team-Current, 10Flow, 6Security, 5Patch-For-Review, 7Security-Extensions: XSS in Flow topic titles - https://phabricator.wikimedia.org/T120324#1955730 (10Etonkovidova) Please review the following - any suggestions(follow-up bugs/more testing) are welcomed. Tested on test.wikipedia.org |... [16:19:08] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Timestamp in compressed notification appears in different places depending on its length - https://phabricator.wikimedia.org/T121933#1955739 (10Etonkovidova) Checked the fix in betalabs - the timestamp is placed consistently. [16:22:33] (03PS2) 10IoannisKydonis: Add GENDER support to PageTriage messages [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/265743 [16:40:23] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 10VisualEditor-MediaWiki-Links: [Regression wmf23] On creating an inter-wiki link, the nice regex strips section parts of the link - https://phabricator.wikimedia.org/T112898#1955807 (10Trizek-WMF) Also concerns #Flow [18:22:33] (03CR) 10Legoktm: [C: 04-1] "-2 to the changing "public" to "private" - that was discussed at T90486. The kbd changes are fine, and I'll merge those if you remove the " [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/265723 (owner: 10IoannisKydonis) [18:34:46] mooeypoo, I can't make standup. Please pass on my apologies. (Today I'm doing the same as yesterday) [18:36:26] quiddity, ok will do [18:36:30] have a good weekend [18:47:32] (03PS3) 10IoannisKydonis: Reword and add tags to messages [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/265723 [18:50:54] Getting lunch [19:02:57] (03PS4) 10Legoktm: Add tags to messages [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/265723 (owner: 10IoannisKydonis) [19:03:10] (03CR) 10Legoktm: [C: 032] "Thanks!" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/265723 (owner: 10IoannisKydonis) [19:03:23] (03PS1) 10IoannisKydonis: Reword echo-notification-alert-text-only [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265788 [19:07:13] (03Merged) 10jenkins-bot: Add tags to messages [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/265723 (owner: 10IoannisKydonis) [19:32:25] (03CR) 10Nemo bis: "Note to self: used for https://codein.withgoogle.com/dashboard/tasks/6632788748926976/" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/265723 (owner: 10IoannisKydonis) [19:40:20] (03CR) 10Nemo bis: "Please check if there is a phabricator report for this already." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265788 (owner: 10IoannisKydonis) [19:47:09] (03CR) 10Nemo bis: [C: 04-1] "AFAICS, $wgResourceModules['ext.pageTriage.article'] needs to state the dependency on jqueryMsg" (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/265743 (owner: 10IoannisKydonis) [19:50:13] (03CR) 10Nemo bis: "Note to self: used for https://codein.withgoogle.com/dashboard/tasks/5672625925783552/" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/265743 (owner: 10IoannisKydonis) [19:55:25] (03CR) 10Mattflaschen: [C: 04-1] "There's not much the end user can do in this situation, other than:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265703 (owner: 10IoannisKydonis) [19:57:27] (03CR) 10Mattflaschen: "See https://gerrit.wikimedia.org/r/265707" [extensions/Flow] (REL1_26) - 10https://gerrit.wikimedia.org/r/260902 (https://phabricator.wikimedia.org/T122329) (owner: 10Mattflaschen) [20:06:43] (03CR) 10Nemo bis: "What is the need to mention "Parsoid"?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265703 (owner: 10IoannisKydonis) [20:07:06] (03CR) 10Nemo bis: [C: 04-1] Clarify documentation of apihelp-flow+edit-title-param-content (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265725 (owner: 10IoannisKydonis) [20:08:01] (03CR) 10Mattflaschen: [C: 04-1] "topic-title-wikitext is a format string, and I don't think it should be translated." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265725 (owner: 10IoannisKydonis) [20:09:33] (03PS3) 10IoannisKydonis: Add GENDER support to PageTriage messages [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/265743 [20:12:45] 3Collaboration-Team-Current, 10Notifications: cross-wiki notification: bundled notifications are not counted - https://phabricator.wikimedia.org/T124109#1956844 (10jmatazzoni) It's clear that the behavior of x-wiki notifications puts them in a somewhat ambiguous status. These messages both are and, in some way... [20:19:53] 3Collaboration-Team-Current, 10Flow, 6Security, 5Patch-For-Review, 7Security-Extensions: XSS in Flow topic titles - https://phabricator.wikimedia.org/T120324#1956890 (10Mattflaschen) >>! In T120324#1955720, @Etonkovidova wrote: > Please review the following - any suggestions(follow-up bugs/more testing)... [20:20:30] 3Collaboration-Team-Current, 10Flow, 6Security, 5Patch-For-Review, 7Security-Extensions: XSS in Flow topic titles - https://phabricator.wikimedia.org/T120324#1956892 (10Mattflaschen) 5Resolved>3Open [20:20:51] (03PS13) 10Mooeypoo: Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [20:21:04] (03PS2) 10IoannisKydonis: Clarify documentation of apihelp-flow+edit-title-param-content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265725 [20:21:22] 3Collaboration-Team-Current, 10Flow, 10Thanks, 10Notifications, 7user-notice: wikitext in flow titles is parsed (HTML tags like and templates) on echo notifications - https://phabricator.wikimedia.org/T120291#1956896 (10Mattflaschen) [20:21:24] 3Collaboration-Team-Current, 10Flow, 6Security, 5Patch-For-Review, 7Security-Extensions: XSS in Flow topic titles - https://phabricator.wikimedia.org/T120324#1850988 (10Mattflaschen) [20:25:50] (03CR) 10Mattflaschen: [C: 04-2] "This has significant product impact and should not be merged in this form." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265788 (owner: 10IoannisKydonis) [20:26:40] 3Collaboration-Team-Current, 10Notifications, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1956922 (10Mooeypoo) >>! In T121936#1955281, @Nikerabbit wrote: >>>! In T121936#1949198, @Amire80 wrote: >>> Creating a dynamic message out of elemen... [20:28:16] (03CR) 10Mattflaschen: [C: 032] "Thanks for clarifying this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265725 (owner: 10IoannisKydonis) [20:31:20] (03CR) 10Mattflaschen: "It makes it more obvious to a developer seeing the error what happened; it might save a grep." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265703 (owner: 10IoannisKydonis) [20:31:35] (03Merged) 10jenkins-bot: Clarify documentation of apihelp-flow+edit-title-param-content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265725 (owner: 10IoannisKydonis) [20:47:37] 6Collaboration-Team-Backlog, 6Commons, 10MediaWiki-Uploading, 6Multimedia, and 2 others: Fix async upload by url - https://phabricator.wikimedia.org/T119336#1956966 (10MarkTraceur) 5Open>3Resolved a:3MarkTraceur Fixed it by removing it. [20:57:47] 6Collaboration-Team-Backlog, 6Commons, 10MediaWiki-Uploading, 6Multimedia, and 2 others: Fix async upload by url - https://phabricator.wikimedia.org/T119336#1957009 (10matmarex) 5Resolved>3declined [20:59:43] 6Collaboration-Team-Backlog, 6Commons, 10MediaWiki-Uploading, 6Multimedia, and 2 others: Fix async upload by url - https://phabricator.wikimedia.org/T119336#1823771 (10matmarex) a:5MarkTraceur>3matmarex [21:03:32] (03CR) 10Anomie: [C: 031] "Looks good now. I left a few suggestions, but they're completely not essential." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264718 (owner: 10Matthias Mullie) [21:06:07] (03CR) 10Nemo bis: "Note to self: used for GCI task" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265725 (owner: 10IoannisKydonis) [21:22:38] (03CR) 10Nemo bis: "Note to self: used for GCI task" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265703 (owner: 10IoannisKydonis) [21:22:40] (03CR) 10Nemo bis: "Note to self: used for GCI task" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [21:38:44] 3Collaboration-Team-Current, 10Flow, 10Thanks, 10Notifications, 7user-notice: wikitext in flow titles is parsed (HTML tags like and templates) on echo notifications - https://phabricator.wikimedia.org/T120291#1957235 (10Mattflaschen) >>! In T120291#1850995, @Catrope wrote: > I've split off the XSS b... [21:45:45] 6Collaboration-Team-Backlog, 10Flow, 7Design, 7Easy: Flow: Topic history page doesn't reflect action in h1 heading or tag - https://phabricator.wikimedia.org/T72472#1957248 (10Mattflaschen) >>! In T72472#1947052, @dg711 wrote: > My vagrant installation always return either the "stack overflow" or "... [21:47:17] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 7Design, 7Easy: Flow: Topic history page doesn't reflect action in h1 heading or <title> tag - https://phabricator.wikimedia.org/T72472#1957257 (10Mattflaschen) >>! In T72472#1947052, @dg711 wrote: > Should I just go with manual installation ? That's an option, if you... [21:57:25] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 7Design, 7Easy: Flow: Topic history page doesn't reflect action in h1 heading or <title> tag - https://phabricator.wikimedia.org/T72472#1957331 (10dg711) Well, I use windows actually , so its WAMP for me . Should have switched to linux earlier :/ I'll give a few more a... [22:20:47] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications: "A link was made from" message does not contain any links to pages - https://phabricator.wikimedia.org/T124481#1957434 (10Luke081515) 3NEW [22:27:14] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 7Design, 7Easy: Flow: Topic history page doesn't reflect action in h1 heading or <title> tag - https://phabricator.wikimedia.org/T72472#1957464 (10Mattflaschen) >>! In T72472#1957331, @dg711 wrote: > Well, I use windows actually , so its WAMP for me . Should have switch... [22:29:08] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1957471 (10Nemo_bis) [22:29:34] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1891949 (10Nemo_bis) [22:29:47] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications: Raise space between Icon and text of "Show changes" secondary action - https://phabricator.wikimedia.org/T124483#1957487 (10MGChecker) 3NEW [22:31:16] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications: Raise space between Icon and text of "Show changes" secondary action - https://phabricator.wikimedia.org/T124483#1957498 (10Luke081515) [22:31:59] <wikibugs> 3Collaboration-Team-Current, 10Notifications, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1957502 (10Nemo_bis) The task needs requirements to be clarified. For instance, what's wrong with showing the sitename autonym, as we do in interlang... [22:32:11] <matt_flaschen> mooeypoo, is there a task about primary links being a big link on Special:Notifications? [22:33:22] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications: "A link was made from" message does not contain any links to pages - https://phabricator.wikimedia.org/T124481#1957518 (10Mattflaschen) There will be changes to the notifications page. I think we will add a big link that goes to the primary link (IceTre in this ca... [22:45:27] <wikibugs> 6Collaboration-Team-Backlog, 10Notifications: "A link was made from" message does not contain any links to pages - https://phabricator.wikimedia.org/T124481#1957601 (10Quiddity) There were many inconsistencies regarding how a notification was structured. Some notifications included many links, as well as the e... [23:04:13] <James_F> legoktm: So… https://gerrit.wikimedia.org/r/#/c/264900/ [23:05:36] <legoktm> James_F: uh, looking at this cookie thing right now [23:05:53] <James_F> No worries. [23:07:54] <grrrit-wm> (03PS17) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) [23:08:01] <grrrit-wm> (03PS18) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) [23:08:26] <quiddity> The qqq of this string, says "Do not alter the string "(wikitext|html)" in your translation." ---- Does that mean I should change all the translations which use variations? (e.g. "(wikiteksti|html)" and "(вікітекст|html)" and "(wikitext oder html)") [23:08:28] <quiddity> https://translatewiki.net/w/i.php?title=Special:Translations&message=MediaWiki%3AApihelp-flow%2Bedit-header-param-format%2Fde [23:10:48] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) (owner: 10Jforrester) [23:11:39] * James_F sighs at CI. [23:13:13] <mooeypoo> matt_flaschen, what do you mean 'big links' ? [23:14:12] <mooeypoo> also, matt_flaschen I could use your help for a minute if you have it about vagrant's dbname stuff... I'm running into issues with trying to do the "quickfix" version of the human readable names but things fail for me in spectacular ways -- James_F pointed out it might actually be because of the way vagrant is set up, though. [23:14:25] <mooeypoo> matt_flaschen, so, example, this works: > list( $project, $lang ) = $wgConf->siteFromDB( 'enwiki' ); var_dump( $project, $lang ); [23:14:32] <mooeypoo> 'wiki', 'en' [23:14:48] <mooeypoo> This doesn't list( $project, $lang ) = $wgConf->siteFromDB( 'hewiki' ); var_dump( $project, $lang ); --> 'hewiki', '' [23:15:37] <mooeypoo> same with frwiki, frwiktionary, etc, things that are in the vagrant cross-wiki installation [23:15:46] <matt_flaschen> mooeypoo, one sec. [23:15:59] <mooeypoo> is this a local vagrant thing that fails, or is that just showing I can't at all trust that method? [23:16:09] <mooeypoo> matt_flaschen, yeah, I'm mjust laying out the issue, see/help when you are available. [23:16:55] <matt_flaschen> Yeah, brb. [23:21:57] <matt_flaschen> mooeypoo, I mean how the popup has one big link to the primary link (that takes up the whole notification area). [23:22:05] <matt_flaschen> The notification page doesn't have anything equivalent. [23:22:20] <matt_flaschen> quiddity, yes. [23:22:38] <quiddity> ty [23:22:39] <matt_flaschen> re wikitext and html format strings. [23:23:31] <matt_flaschen> mooeypoo, yeah, that's one of the things that wasn't in my initial commit. [23:23:42] <matt_flaschen> Looking now. [23:24:41] <mooeypoo> matt_flaschen, currently the Special:Notifications page shows notifs from the "old" API version, so they actually do have a wrapper <a> (or should? I think?) -- but I wanted to change them to OOUI PHP widgets in (a) preparation for the bigger Special:Notifications fix that will likely require them for the 'nojs' version and (b) so we can have the same design of the notification, including all the secondary links *and* an ability to [23:24:41] <mooeypoo> add "mark as read" in there [23:25:12] <mooeypoo> there's no ticket for the link, but there is for 'mark as read' ability in Special:Notifications, which I partially fixed by removing the 'mark automatically as read' in Special:Notifications [23:26:24] <matt_flaschen> mooeypoo, don't have a wrapper <a> for me on page linked, or for filer of https://phabricator.wikimedia.org/T124481#1957518 [23:26:47] <matt_flaschen> mooeypoo, also, I found a Vagrant problem where if there is a global user, but not all wikis are attached, they won't be reattached later. [23:27:05] <mooeypoo> "attached" ? you mean the user as global user? [23:27:18] <matt_flaschen> mooeypoo, yes, basically there is a global user, but not all wikis are attached to it. [23:27:38] <matt_flaschen> Some are still local, like pre-Single User Finalization. And this is not corrected by a provision run because it thinks it's already done. [23:27:39] <mooeypoo> I see [23:28:05] <mooeypoo> I didn't really encounter an issue with this so far, but I didn't test x-wiki notifications too ruthlessly [23:28:39] <mooeypoo> also, yes, I am looking at Special:Notifications, and there's no link. Meh. I remember now... the popup used to "pluck out" the link from the DOM it was given (!!!!!!) and wrap the notification with it [23:28:43] <matt_flaschen> mooeypoo, also, you probably aren't disabling/enabling roles and re-provisioning to test bd808's patches. :) [23:29:08] <mooeypoo> whatever we do here will be a hack unless we decide to unify with the popup design (in which case OOUI php + infuse is probably best) [23:29:27] <mooeypoo> I spoke briefly to Roan about this option, he theoretically agrees but said there are more urgent things to finish first. [23:29:37] <mooeypoo> but we should discuss this, maybe in the next discussion meeting? [23:29:44] <matt_flaschen> mooeypoo, theoretically agrees with what? [23:29:54] <mooeypoo> as in -- what do we do, if anything, to the Special:Notification page *while* the big-giant-effort is underway [23:30:06] <mooeypoo> oh, working on OOUI PHP widgets for notifications in Special:Notifications [23:30:34] <matt_flaschen> Yeah, that seems like the long-term solution. I was just wondering if we were tracking this task. I guess not, so this is now that task. Don't have a strong preference on whether we put in a workaround. [23:30:38] <matt_flaschen> People can already deal with it. [23:31:22] <mooeypoo> YEah, I think the ooui php is a semi-workaround, because I think we will need it in the future for the NOJS version of the big-giant-effort in Special:Notifications that pau is working on anyways -- but it is a bit of work [23:31:39] <mooeypoo> it will, however, make long-term work easier and unify the code [23:32:03] <mooeypoo> right now, the JS for Special:Notifications is completely separate and un-updated since before the switch to OOUI [23:35:27] <matt_flaschen> mooeypoo, the siteFromDB thing should be easy to fix. The only question is how many people mistakenly think I broke it... ;) [23:35:48] <matt_flaschen> There are a lot of weird local wikis like mobilewiki, and it's not clear if people expect those to be Wikipedias or not. [23:35:51] <mooeypoo> Why would anyone think you broke it? :P [23:36:29] <matt_flaschen> mooeypoo, since depending how I do it, it might go from: [23:36:34] <mooeypoo> Yeah, that solution is NOT GOOD. But the task is semi urgent, and (a) the discussion takes a while, (b) the implementation of the translated messages will take a bit--- so... maybe this as a stopgap quickfix? :\ [23:36:58] <mooeypoo> Oh, plus, I'm leaving to Australia in a week... [23:37:01] <matt_flaschen> array( "mobilewiki", "" ) to array( "wikipedia", "mobile" ) [23:37:24] <matt_flaschen> mooeypoo, I meant the MWV, not your fix. [23:37:50] <mooeypoo> oh, well if you are fixing it to actually recognize the project, then yay [23:37:56] <mooeypoo> though 'mobile' is still not a language [23:37:57] <mooeypoo> :P [23:38:01] <mooeypoo> ... yet [23:38:48] <matt_flaschen> > list( $project, $lang ) = $wgConf->siteFromDB( 'commonswiki' ); var_dump( $project, $lang ); [23:38:49] <matt_flaschen> string(9) "wikipedia" [23:38:51] <matt_flaschen> string(7) "commons" [23:38:52] <matt_flaschen> From production. :) [23:39:12] <mooeypoo> awesome! [23:39:22] <matt_flaschen> Yeah, that caused some interesting problems for GettingStarted... [23:39:26] <mooeypoo> but that also means I can't trust the $lang to be $lang [23:40:02] <mooeypoo> Now I understand why they're called $major and $minor in ForeignNotifications.php [23:40:41] <matt_flaschen> mooeypoo, I think I would want to special case them, since I just realized otherwise even zhwikivoyagewiki (*not* matching production), would be zhwikivoyage Wikipedia. [23:41:23] <matt_flaschen> mooeypoo, but we already knew Commons and Meta woulds be exceptions, so this is still worth fixing in Vagrant, right? [23:41:36] <mooeypoo> Seems so [23:41:44] <mooeypoo> I'm trying to come up with code fallbacks, too, just in case [23:58:55] <grrrit-wm> (03CR) 10Legoktm: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) (owner: 10Jforrester)