[00:37:30] 6Collaboration-Team-Backlog, 10Notifications: cross-wiki: the tooltip in ellipses menu has large font - https://phabricator.wikimedia.org/T124256#1950728 (10Etonkovidova) 3NEW [00:39:46] 3Collaboration-Team-Current, 10Notifications, 7Easy, 7I18n, and 2 others: [[MediaWiki:Notification-bundle-header-edit-user-talk-v2/en]] i18n issue - https://phabricator.wikimedia.org/T124135#1950745 (10Etonkovidova) Checked in betalabs {F3252591} {F3252604} [01:02:19] (03PS1) 10Reedy: Call UserMailer::send() with reply to address correctly [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265431 [01:03:35] (03CR) 10Alex Monk: [C: 032] Call UserMailer::send() with reply to address correctly [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265431 (owner: 10Reedy) [01:07:28] (03Merged) 10jenkins-bot: Call UserMailer::send() with reply to address correctly [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265431 (owner: 10Reedy) [01:12:39] (03CR) 10Mattflaschen: "Removing myself" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 (owner: 10Paladox) [01:29:40] (03PS24) 10Mooeypoo: Add a demo special page to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254612 (https://phabricator.wikimedia.org/T115551) [01:58:27] (03CR) 10Mattflaschen: [C: 04-1] "Sorry, I only caught this when testing." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/264249 (https://phabricator.wikimedia.org/T90075) (owner: 10Matthias Mullie) [02:29:27] 3Collaboration-Team-Current, 10Flow: Clicking Flow "new replies" notifications highlights only the most recent reply - https://phabricator.wikimedia.org/T124175#1951068 (10Anomie) >>! In T124175#1948932, @Whatamidoing-WMF wrote: > Anomie, what's your web browser and OS? Firefox (well, really Iceweasel) 44.0b6... [02:33:50] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Update and retest the convertToText script - https://phabricator.wikimedia.org/T90075#1951086 (10Mattflaschen) >>! In T90075#1942630, @Quiddity wrote: > Re: `:` vs `*` - I think the `:` indents are slightly clearer overall, particularly for multiline po... [02:36:56] 3Collaboration-Team-Current, 10Flow: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#1951096 (10Mattflaschen) I don't know about this one in particular, but {T113682} and {T117907} are still open, and I believe that's correct (it is indeed not completed yet). [02:55:46] Have a good night, all. [06:06:46] (03PS1) 10Matthias Mullie: Move remaining usage of EchoGetDefaultNotifiedUsers into UserLocator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265460 [06:06:49] (03PS1) 10Matthias Mullie: [WIP] Engage full surveillance mode for Flow talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) [06:07:23] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Engage full surveillance mode for Flow talk pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265461 (https://phabricator.wikimedia.org/T121663) (owner: 10Matthias Mullie) [06:07:37] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Create new notification category for talk pages: flowusertalk - https://phabricator.wikimedia.org/T121663#1951216 (10matthiasmullie) Where can I find the icons? Barring the icons, this patch is ready. [06:09:12] (03PS2) 10Matthias Mullie: Move remaining usage of EchoGetDefaultNotifiedUsers into UserLocator [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265460 [07:23:11] (03PS6) 10Matthias Mullie: Fix convertToText.php & let it query remote APIs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/264249 (https://phabricator.wikimedia.org/T90075) [07:23:16] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Update and retest the convertToText script - https://phabricator.wikimedia.org/T90075#1951246 (10matthiasmullie) I restored `:`-based indents. The signatures were indeed because I'm running this from my machine, where these users don't exist. I've upda... [08:42:49] (03PS2) 10Nemo bis: Clarify "user information" in apihelp-feedbackdashboardresponse-param-anonymize [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [08:43:39] (03CR) 10Nemo bis: [C: 04-1] "Still not clear what user is being talked about. Please add GENDER support for "user", so that we have to find out who the user is. :)" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [09:30:38] (03PS3) 10IoannisKydonis: Clarify "user information" in apihelp-feedbackdashboardresponse-param-anonymize [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 [09:34:51] (03PS2) 10Matthias Mullie: Deprecate ApiEchoNotifications.php format params flyout & html [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264718 [09:52:59] (03PS4) 10IoannisKydonis: Clarify "user information" in apihelp-feedbackdashboardresponse-param-anonymize [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 [10:00:18] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests: Populate echo_unread_wikis table on all wikis - https://phabricator.wikimedia.org/T124233#1951419 (10Legoktm) [10:00:20] 3Collaboration-Team-Current, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable Echo tracking table on all wikis - https://phabricator.wikimedia.org/T124232#1951417 (10Legoktm) 5Open>3Resolved [10:04:13] (03CR) 10IoannisKydonis: "recheck" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [11:12:20] (03CR) 10PranavK: "recheck" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [11:13:21] (03CR) 10PranavK: "You need to be whitelisted for +2 testing in order for "recheck" to work :)" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [11:14:11] (03CR) 10IoannisKydonis: "Ok, thank you :)" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [11:18:10] (03CR) 10IoannisKydonis: "In an above comment Nemo bis said that i should add GENDER." [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [11:19:37] (03CR) 10PranavK: "I believe that PLURAL should also be added (because of what the thread says), but it's better to check with Nemo! :)" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [11:22:29] (03CR) 10IoannisKydonis: "Thanks for the help :)" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [11:35:19] (03CR) 10Nemo bis: "For $1 to be a username that GENDER can use, we must be talking of a single user. If there can be more than one, that wouldn't work. It mi" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [12:03:11] (03PS5) 10IoannisKydonis: Clarify "user information" in apihelp-feedbackdashboardresponse-param-anonymize [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 [12:12:34] (03CR) 10PranavK: "I still feel that this does not clarify the "one user or many users" issue..." [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [14:36:07] 6Collaboration-Team-Backlog, 10Notifications, 7Easy, 7I18n: Links on notification-page-linked, -bundle, -flyout etc. - https://phabricator.wikimedia.org/T69942#1951743 (10matej_suchanek) At the moment, the only odd-out is: ``` "notification-page-linked": "[[:$2]] was {{GENDER:$1|linked}} from [[:$3]]. [[Sp... [14:51:58] 6Collaboration-Team-Backlog, 10Thanks, 7Community-Wishlist-Survey: Opt out of Thanks feature - https://phabricator.wikimedia.org/T120753#1951827 (10Aklapper) IMPORTANT: **If you are a community developer interested in working on this task:** The [[ https://www.mediawiki.org/wiki/Wikimedia_Hackathon_2016 | W... [14:54:16] 6Collaboration-Team-Backlog, 10Flow, 10Notifications, 7Community-Wishlist-Survey: Create a Timer based reminder for workflows - https://phabricator.wikimedia.org/T88781#1951940 (10Aklapper) IMPORTANT: **If you are a community developer interested in working on this task:** The [[ https://www.mediawiki.org... [14:54:27] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7Community-Wishlist-Survey, 7I18n: Make PageTriage wiki agnostic - https://phabricator.wikimedia.org/T50552#1951950 (10Aklapper) IMPORTANT: **If you are a community developer interested in working on this task:** The [[ https://www.mediawik... [14:55:05] (03PS1) 10Sbisson: Revert "Follow-up 88d6f01c33: postpone greying out notification bodies for now" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265491 [14:56:55] (03PS1) 10Sbisson: Truncate usernames, titles and excerpts in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265495 (https://phabricator.wikimedia.org/T121822) [14:59:27] (03CR) 10jenkins-bot: [V: 04-1] Truncate usernames, titles and excerpts in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265495 (https://phabricator.wikimedia.org/T121822) (owner: 10Sbisson) [15:01:30] (03PS2) 10Sbisson: Truncate usernames, titles and excerpts in notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265495 (https://phabricator.wikimedia.org/T121822) [15:02:41] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10VisualEditor, 10VisualEditor-MediaWiki-Links: Section links are not being saved - https://phabricator.wikimedia.org/T123782#1951994 (10Elitre) T112898 ? [15:13:38] (03CR) 10Nemo bis: Clarify "user information" in apihelp-feedbackdashboardresponse-param-anonymize (032 comments) [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 (owner: 10IoannisKydonis) [15:19:23] (03PS2) 10Sbisson: Add snippet to mention notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265182 (https://phabricator.wikimedia.org/T121817) [15:20:37] (03CR) 10Anomie: Deprecate ApiEchoNotifications.php format params flyout & html (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264718 (owner: 10Matthias Mullie) [16:05:50] 6Collaboration-Team-Backlog, 10Flow: Allow preloading summary with explicit text - https://phabricator.wikimedia.org/T94283#1952259 (10Trizek-WMF) >>! In T94283#1756608, @Trizek-WMF wrote: > I'll see if that is enough for users. So [[ https://fr.wikipedia.org/w/index.php?title=Sujet:Swk1r05o9qux1pn0&topic_sho... [16:13:21] (03PS1) 10Sbisson: Truncate title [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/265503 (https://phabricator.wikimedia.org/T121822) [16:15:42] 6Collaboration-Team-Backlog, 10Notifications, 7Design: Echo: The "You have new messages" link should go to a diff and/or subsection - https://phabricator.wikimedia.org/T58475#1952296 (10matej_suchanek) [16:54:45] 6Collaboration-Team-Backlog, 10Notifications, 7I18n, 7Voice & Tone: Some Echo issues of GENDER and untranslatability - https://phabricator.wikimedia.org/T63904#1952442 (10matej_suchanek) [16:56:12] 6Collaboration-Team-Backlog, 10Notifications, 7I18n, 7Voice & Tone: Some Echo issues of GENDER and untranslatability - https://phabricator.wikimedia.org/T63904#654754 (10matej_suchanek) [18:01:15] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Create new notification category for talk pages: flowusertalk - https://phabricator.wikimedia.org/T121663#1952612 (10Pginer-WMF) >>! In T121663#1951216, @matthiasmullie wrote: > Where can I find the icons? Barring the icons (which are currently... [18:03:10] (03PS6) 10IoannisKydonis: Clarify "user information" in apihelp-feedbackdashboardresponse-param-anonymize [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/265407 [18:16:16] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10VisualEditor, 10VisualEditor-MediaWiki-Links: Section links are not being saved - https://phabricator.wikimedia.org/T123782#1952673 (10Arlolra) @Elitre, yes, thanks. [18:16:44] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid, 10VisualEditor, 10VisualEditor-MediaWiki-Links: Section links are not being saved - https://phabricator.wikimedia.org/T123782#1952681 (10Arlolra) [18:21:34] (03PS1) 10Sbisson: Truncate page titles and topic titles in notifications header message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265521 (https://phabricator.wikimedia.org/T121822) [18:22:59] (03PS2) 10Sbisson: Truncate page titles and topic titles in notifications header message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265521 (https://phabricator.wikimedia.org/T121822) [18:26:54] (03PS1) 10Mattflaschen: WIP: Dry run for external store [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265524 (https://phabricator.wikimedia.org/T119566) [18:30:41] (03CR) 10Krinkle: WIP: Dry run for external store (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/265524 (https://phabricator.wikimedia.org/T119566) (owner: 10Mattflaschen) [18:30:44] I'm going to be late to standup, just got out of the MW foundation meeting and I need some food [18:45:50] no one in hangout? [18:47:01] * legoktm assumes he missed it [18:47:06] legoktm: we finished early [18:47:40] matt_flaschen: when you have a minute... [18:47:58] stephanebisson, yep, now's good. [18:49:08] matt_flaschen: everything was fine when I merged your Echo cross-wiki mw-vagrant patch but then I did something to my ruby env and I now get those errors when I provision: [18:49:20] "Warning: Scope(Class[Role::Echo]): Could not look up qualified variable '::mediawiki::multiwiki::extension_db_cluster'; class ::mediawiki::multiwiki has not been evaluated" [18:49:47] yes,it's a warning, but it generates the following error later on: "Error: Could not find dependency Mysql::Db[undef] for Mysql::Sql[create echo_unread_wikis] at /vagrant/puppet/modules/role/manifests/echo.pp:26" [18:50:08] essentially, $::mediawiki::multiwiki::... cannot be read [18:50:14] have you even seen that? [18:50:25] stephanebisson, no. [18:50:53] stephanebisson, what commit are you at? [18:51:13] matt_flaschen: 735ba688aecaab99c26b0ab2cc9a5f3b9ba4010f [18:51:32] matt_flaschen: it's the same at 083ca4ffd6af77399ab6b58305e269dfdfd79215 (Cross-wiki notification support) [18:53:06] stephanebisson, it's strange. It is basically copying a variable from a singleton class ($::mediawiki::multiwiki::extension_db_cluster from $::mediawiki::multiwiki). Not sure why it stopped working. [18:53:20] matt_flaschen: does it work for you? [18:53:21] stephanebisson, just in case, what version of puppet do you have in the guest? [18:53:27] puppet --version [18:53:43] stephanebisson, I will reprovision right now and check (I was testing an old Vagrant commit for External Store). [18:53:50] I've never seen that error. [18:53:57] matt_flaschen: 3.4.3 [18:54:00] Same [18:54:13] matt_flaschen: what version of vagrant? [18:55:11] 1.6.5 [18:55:21] it all started when I ran `bundle install` in my vagrant dir to be able to do `rake lint` to troubleshoot a build error [18:55:39] ok, I'll try to install that specific version [18:55:55] stephanebisson, I think you had 1.7.2 when we were in SF. [18:56:10] yeah, I think so [18:56:10] It seems weird that upgrading Vagrant's Ruby would break it. It seems like more of a Puppet thing. [18:56:24] indeed [18:56:32] I think Vagrant bundles its own Ruby, not sure whether bundle install could mess with it. [18:57:47] I'll let you know what I get from the provision. [18:57:59] I'm at the same MWV commit. [18:58:55] after I `bundle install`, vagrant was complaining that it was running in a bundle env. and could not load it's plugins [18:59:44] Uh oh. [19:00:08] stephanebisson, maybe that's just one symptom, and everything is messed up? Were there other errors? [19:00:31] nothing else [19:00:44] I get the same error with 1.7.2 [19:00:46] Hmm [19:01:10] stephanebisson, you mean 1.6.5, or did you just revert to clean 1.7.2? [19:01:30] I just installed 1.7.2 [19:01:46] stephanebisson, what did you have before that? [19:01:57] 1.5.4 [19:02:18] after trying 1.8.x [19:06:36] stephanebisson, I didn't get any errors provisioning. [19:06:55] good [19:07:10] I prefer my env. to be broken instead of the code [19:09:16] stephanebisson, do you know where the gems get installed in this case? Normally it's .gem, right, but I don't see such a directory. [19:09:23] stephanebisson, if you have one, you could try deleting it. [19:10:37] yes, I'll delete them [19:25:49] Getting lunch [19:30:27] (03PS1) 10Mooeypoo: Add 'mark as read' as secondary action to unread notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265549 (https://phabricator.wikimedia.org/T121935) [19:54:12] 6Collaboration-Team-Backlog, 10Notifications, 7Easy, 7I18n: Links on notification-page-linked, -bundle, -flyout etc. - https://phabricator.wikimedia.org/T69942#1953102 (10Catrope) >>! In T69942#1951743, @matej_suchanek wrote: > At the moment, the only odd-out is: > ``` > "notification-page-linked": "[[:$2]... [19:54:39] (03CR) 10Catrope: [C: 032] Revert "Follow-up 88d6f01c33: postpone greying out notification bodies for now" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265491 (owner: 10Sbisson) [19:57:17] (03Merged) 10jenkins-bot: Revert "Follow-up 88d6f01c33: postpone greying out notification bodies for now" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265491 (owner: 10Sbisson) [20:10:34] stephanebisson, working now? [20:11:23] matt_flaschen: recreating from scratch... not yet at provisioning step [20:14:41] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#1953189 (10jmatazzoni) @SBisson asked: > How should we truncate section names? I imagine we should treat them the sam... [20:15:06] 6Collaboration-Team-Backlog, 10Thanks, 7Community-Wishlist-Survey: Opt out of Thanks feature - https://phabricator.wikimedia.org/T120753#1953190 (10Mattflaschen) Needs product input from Collaboration team. [22:35:37] (03PS1) 10Mooeypoo: Don't auto mark notifications as read in Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265641 (https://phabricator.wikimedia.org/T115528) [22:36:12] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#1953751 (10Mooeypoo) The above commit only deals with not automatically marking notifications as read when visiting Special:Notification... [23:04:08] (03PS1) 10Mooeypoo: Create a specific message for CORS failure in cross-wiki API request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265652 (https://phabricator.wikimedia.org/T123797) [23:17:33] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Add "mark as read" as a deprioitized secondary action to every unread notification - https://phabricator.wikimedia.org/T121935#1953936 (10Catrope) >>! In T121935#1953002, @Mooeypoo wrote: > Just a note: At the moment, secondary actions do not h... [23:23:33] (03CR) 10Catrope: [C: 032] "Looks good, but perhaps we can come up with a less technobabbly error message." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265652 (https://phabricator.wikimedia.org/T123797) (owner: 10Mooeypoo) [23:26:17] (03Merged) 10jenkins-bot: Create a specific message for CORS failure in cross-wiki API request [extensions/Echo] - 10https://gerrit.wikimedia.org/r/265652 (https://phabricator.wikimedia.org/T123797) (owner: 10Mooeypoo) [23:32:22] matt_flaschen, trying to work with the cross-wiki notifications, I'm getting CORS errors. I need to add domains to $wgCrossSiteAJAXdomains... how do I do that properly in vagrant? [23:32:59] Is there a single "global" LocalSettings ? [23:33:57] mooeypoo, yeah, there's two ways you can do it: [23:35:56] mooeypoo, well, it's best to puppetize it, which means you would put it in puppet/modules/role /manifests /echo.pp [23:36:44] mooeypoo, as a mediawiki::settings block. See the examples in mediawiki/manifests/settings.pp [23:38:21] If you tell me what settings you want to add I can help you with the puppet part. [23:38:56] 3Collaboration-Team-Current, 10Notifications: If user only has foreign messages, the messages badge should not be suppressed - https://phabricator.wikimedia.org/T124372#1954042 (10Catrope) 3NEW [23:40:10] matt_flaschen, I just want to add all of the local domains that are created as part of the multiple wikis in vagrant into the $wgCrossSiteAJAXdomains array [23:43:13] mooeypoo, trying now. [23:43:42] matt_flaschen, oh, good, because I'm getting a bit confused with the way to do it. I see settings.pp and echo.pp but can't figure out how to manipulate a specific variable [23:43:52] oh, I see it I think [23:44:45] mooeypoo, it's easy if you just want to assign it, but in this case I think it's better to use array append. [23:44:53] * mooeypoo nods [23:45:09] Are you trying it, or should i continue to try and figure it out? [23:45:20] not sure how to append. I think i see how to set [23:45:58] mooeypoo, I'm just using a string. Testing now. [23:49:53] mooeypoo, https://phabricator.wikimedia.org/P2513 [23:50:45] mooeypoo, the Puppet works. I didn't test the actual CORS, but you should be able to tweak it to have whatever domains are needed. Wildcards are supposed to work per https://www.mediawiki.org/wiki/Manual:$wgCrossSiteAJAXdomains . [23:53:09] Testing [23:54:00] I need to reprovision, I assume? [23:54:28] mooeypoo, yes. [23:55:04] mooeypoo, I put it in echo.pp [23:57:56] Oh, forgot I already said that. :)