[00:00:39] (03CR) 10jenkins-bot: [V: 04-1] Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [00:02:47] (03PS3) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 [00:04:45] (03CR) 10jenkins-bot: [V: 04-1] Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [00:14:53] (03PS4) 10Catrope: Don't blur talk icon echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264564 (https://phabricator.wikimedia.org/T123656) (owner: 10MtDu) [00:15:48] 3Collaboration-Team-Current, 10Flow, 10Notifications, 5Patch-For-Review: blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1942665 (10Catrope) I decided to keep the status quo in this patch and just change the icon size. The patch for {T122646} can then center the icon and ch... [00:32:11] RoanKattouw: Working on the patch now. [00:32:34] MtDu: Which one? [00:32:52] RoanKattouw: The one you and mooey posted comments on. I saw your commit on the bluring on. :) [00:33:05] OK [00:33:15] The blurring one is ready, I just need mooeypoo to review it [00:33:23] But she and I are working on setting up VNC right now :) [00:33:27] So you're working on the alignment one then>? [00:33:55] Yep. :) [00:34:13] I'll probably ping you every now and then for help [00:34:20] And what does VNC mean? [00:38:10] https://en.wikipedia.org/wiki/Virtual_Network_Computing [00:38:17] It's a remote desktop thing [00:42:11] RoanKattouw: Sweet. Found the icon. https://dpaste.de/k8o7 Which line do I modify to move it to the right. [00:42:48] do I just give it a padding left? [00:44:39] Hmm [00:45:11] It looks like it isn't actually misaligned in the DOM, but there's some blank space in the image itself so it looks wrong [00:45:30] So what do you want me to do? [00:45:53] And also, what is the action icon that you guys are talking about? Like what is it in the notification header so I can find it. [00:45:58] RoanKattouw:^ [00:46:56] I think what Pau meant was a margin-right of -0.5em (note: negative) [00:47:39] By the action icons I think he means the ones highlighted in orange and purple in https://phab.wmfusercontent.org/file/data/yrl3vdhcwdfzqo4vzefs/PHID-FILE-hc7hqfogbdqqitwsxhqx/m2j3yt7mozcem4zj/action-layout.png [00:47:43] Not all notifications have those [00:48:36] mooeypoo: Could you reviw https://gerrit.wikimedia.org/r/#/c/264564/3 ? [00:51:22] (03CR) 10Mooeypoo: [C: 032] Don't blur talk icon echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264564 (https://phabricator.wikimedia.org/T123656) (owner: 10MtDu) [00:51:47] (03CR) 10Mooeypoo: [C: 032] Fix content text alignment in GroupItemWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264899 (owner: 10Catrope) [00:52:53] MtDu: Also, these two things ---^^ merging will impact your alignment patch, and will probably cause a rebase conflict. I'll help you that once 1) they've actually merged and 2) you have time to deal with it [00:52:57] *help you with that [00:55:51] (03Merged) 10jenkins-bot: Fix content text alignment in GroupItemWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264899 (owner: 10Catrope) [00:56:39] RoanKattouw: https://phabricator.wikimedia.org/project/board/1384/query/v1w0Jd_7xI_C/ has quite a few items in "for pickup"… [00:56:58] James_F: What is that query? [00:57:31] RoanKattouw: Notifications && Patch-For-Review. [00:57:35] aha [00:57:36] (&& Open) [00:57:38] Yeah I haven't cleaned that up yet [00:57:57] Just because there's a patch doens't mean the patch fixes all of it [00:58:11] But yes [00:58:11] You can inspect by clicking "Filter: Custom Filter" > "Custom Filter" [00:58:13] Sure, but there's a column for that. ;-) [00:58:39] Thanks for that BTW [00:58:45] I was going to clean up this exact thing [00:58:58] * James_F lives to be helpful. [00:59:09] (03Merged) 10jenkins-bot: Don't blur talk icon echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264564 (https://phabricator.wikimedia.org/T123656) (owner: 10MtDu) [00:59:36] (03PS4) 10Catrope: Organize items in bundles with CSS table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260689 (https://phabricator.wikimedia.org/T121933) (owner: 10Mooeypoo) [00:59:48] (03CR) 10Catrope: [C: 032] Organize items in bundles with CSS table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260689 (https://phabricator.wikimedia.org/T121933) (owner: 10Mooeypoo) [01:00:30] brb, rebooting [01:00:33] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Allow updating user's last seen time in action=echomarkread API - https://phabricator.wikimedia.org/T110216#1942751 (10Catrope) [01:00:46] 3Collaboration-Team-Current, 10Notifications, 7WorkType-NewFunctionality: Allow updating user's last seen time in action=echomarkread API - https://phabricator.wikimedia.org/T110216#1572362 (10Catrope) Removing Patch to Review, since the attached patch depends on an abandoned patch. [01:01:04] 3Collaboration-Team-Current, 10Flow: Give the user the number of history items they asked for - https://phabricator.wikimedia.org/T108291#1942756 (10Catrope) [01:01:26] 3Collaboration-Team-Current, 10Flow: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#1942757 (10Catrope) [01:01:32] 3Collaboration-Team-Current, 10Flow: Cleanup ptwikibooks conversion - https://phabricator.wikimedia.org/T119509#1828142 (10Catrope) Anything left to be done here? [01:02:05] WTF: https://integration.wikimedia.org/ci/job/mwext-mw-selenium/2418/console [01:02:13] (03CR) 10Catrope: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [01:02:55] 3Collaboration-Team-Current, 10Flow, 10Dumps-Generation, 7Blocked-on-Operations, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#1942764 (10Catrope) [01:04:14] (03Merged) 10jenkins-bot: Organize items in bundles with CSS table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260689 (https://phabricator.wikimedia.org/T121933) (owner: 10Mooeypoo) [01:04:44] RoanKattouw: Can https://phabricator.wikimedia.org/T121987 be closed? [01:05:03] RoanKattouw: Is this right now? https://dpaste.de/QK6c#L36,37,60,61,117 [01:05:08] 3Collaboration-Team-Current, 10Flow, 10VisualEditor, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Flow VE: Link inspector displays 'Edit' and 'delete'(oo-ui-buttonElement-framed) in different sizes - https://phabricator.wikimedia.org/T121987#1942776 (10Catrope) 5Open>3Resolved [01:05:15] Ta. [01:05:30] MtDu: Yeah that looks right [01:05:45] RoanKattouw: Pushing a patch now. [01:05:51] MtDu: Although later, when you reconcile this with the 2.5em -> 30px change, that'll need to change, but let's cross that bridge when we come to it [01:06:29] mooeypoo: Also https://gerrit.wikimedia.org/r/264880 [01:06:48] mooeypoo: and https://gerrit.wikimedia.org/r/264216 [01:07:03] 3Collaboration-Team-Current, 10Flow, 10VisualEditor, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Flow VE: Link inspector displays 'Edit' and 'delete'(oo-ui-buttonElement-framed) in different sizes - https://phabricator.wikimedia.org/T121987#1892942 (10Jdforrester-WMF) [01:07:05] (03CR) 10Catrope: Rephrase Flow notifications (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263795 (https://phabricator.wikimedia.org/T121950) (owner: 10Sbisson) [01:07:08] (03PS5) 10MtDu: Adjust layout for new notification panel designs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263805 (https://phabricator.wikimedia.org/T122646) [01:07:30] (03CR) 10jenkins-bot: [V: 04-1] Adjust layout for new notification panel designs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263805 (https://phabricator.wikimedia.org/T122646) (owner: 10MtDu) [01:07:55] RoanKattouw: Here we are. What do I do? [01:08:36] MtDu: OK, so I'll walk you through the process for dealing with rebase conflicts [01:09:05] The reason you're in this situation is because your patch is based on an old version of the code, and since you started this patch, things happened that conflict with what this patch is trying to do [01:09:21] In particular, the "blurred icons" patch was merged, and that touches some of the same stuff as this one [01:09:26] RoanKattouw: Ok. [01:09:31] I think I remember doing this before. [01:09:41] So, first run git review -d 263805 [01:09:51] Then run git fetch [01:09:56] Then git rebase origin/master [01:10:01] This will probably yell "CONFLICT" a few times [01:10:11] Tell me when you get there [01:10:12] Just git fetch [01:10:17] Or something after that? [01:10:28] yeah [01:10:34] No just git fetch is enough [01:10:52] I'm there. [01:10:59] Now I go and find the <<< and >>> places? [01:11:03] Or something like that? [01:11:16] Yeah [01:11:26] Also, run "git status", and it'll tell you which files have conflicts [01:11:35] Just one in this case right? [01:11:47] Let me see [01:11:54] * RoanKattouw follows the same steps locally [01:12:13] Wait no [01:12:15] There's two [01:12:31] I see two [01:12:40] Ok [01:12:46] both modified: modules/echo.variables.less [01:12:46] both modified: modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less [01:12:46] So yeah, once you are done with a file, run "git add filename" [01:12:47] I keep the 500px one right? [01:12:49] That'll move it out of the list of files with conflicts [01:12:57] Yeah [01:13:07] But also make sure you don't delete the bundle-group-padding line that was added [01:13:21] Silly conflict, git just got confused because the surroundings changed [01:13:48] Like this right? https://dpaste.de/GOdS#L15,16 [01:14:01] Yeah [01:14:07] Which one do I keep for the other one? [01:14:12] Then save that, run git add filename , and then run git diff --staged filename [01:14:15] The latter will show you the diff it wants to commit [01:14:29] That way you can verify that you're not accidentally deleting something that someone else added [01:14:35] For the other one, you need a mix [01:15:18] 30px (not 2.5em) for the icon size, but 0.8em (not 1em) for the right margin [01:15:33] And you'll need the calc version of the line [01:15:36] Because the units are mixed [01:15:42] (px vs em) [01:16:04] Yep yep [01:16:06] Gotcha [01:16:32] Like this? https://dpaste.de/BP4f [01:16:50] Yup [01:18:10] RoanKattouw, you need me for more review? If not, I'm going to take a bit of a break, possibly for the rest of the evening, will likely work on something later though [01:18:50] RoanKattouw: After that, what do I do? [01:19:04] git rebase --continue? [01:19:05] mooeypoo: https://gerrit.wikimedia.org/r/264216 [01:19:09] Yes [01:19:22] Then push the patch? [01:20:09] RoanKattouw:^ [01:20:24] yeah [01:20:51] (03PS6) 10MtDu: Adjust layout for new notification panel designs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263805 (https://phabricator.wikimedia.org/T122646) [01:21:13] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/264216/2/includes/Notifications/Controller.php <-- is this deletion on purpose? nothing replaces it ...? [01:21:27] Or is that how discussion and non-flow discussion having the same icons now? [01:22:21] The flow-discussion icon was the generic icon for all flow notifs [01:22:31] But it's no longer used, because we gave every flow notif its own icon [01:22:36] oh, I see, we're using specific icons [01:22:38] yeah I just saw [01:22:50] (Some being the same as the equivalent Echo notifs) [01:23:45] ok, looks good to me, but I could only test mention and chat, because I am having issues with Flow on my vagrant currently... which also should be the only icons, I think, anyways [01:23:51] there aren't any others we missed, I don't think [01:23:54] MtDu: OK that change looks good at a glance now, I'm gonna test it and go over Pau's list to check that you got them all [01:24:19] RoanKattouw: Great. Thanks! [01:24:24] (03CR) 10Mooeypoo: [C: 032] Update Flow notification icons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/264216 (https://phabricator.wikimedia.org/T121735) (owner: 10Catrope) [01:25:05] ok, I'm semi-off for the evening, if you need anything hangout me [01:25:28] Thanks [01:26:36] (03CR) 10Catrope: [C: 04-1] Introduce congratulatory notifications for reaching edit thresholds (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [01:27:34] Whoa :D [01:28:23] MtDu: I think there may be a bug in your patch :P http://i.imgur.com/LmRjkUF.png [01:28:35] I'll see if I can figure out what happened there [01:30:25] (03PS4) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 [01:30:30] (03CR) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [01:30:33] Hah, I found it [01:30:54] (03Merged) 10jenkins-bot: Update Flow notification icons [extensions/Flow] - 10https://gerrit.wikimedia.org/r/264216 (https://phabricator.wikimedia.org/T121735) (owner: 10Catrope) [01:32:52] (03CR) 10jenkins-bot: [V: 04-1] Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [01:33:45] What happened? [01:34:39] 6Collaboration-Team-Backlog, 10Notifications, 7Technical-Debt: Use OOUI icons for the 'big' icons, not just the little ones, in Notifications - https://phabricator.wikimedia.org/T123996#1942825 (10Jdforrester-WMF) 3NEW [01:34:40] (03CR) 10Catrope: [C: 04-1] Adjust layout for new notification panel designs (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263805 (https://phabricator.wikimedia.org/T122646) (owner: 10MtDu) [01:35:00] MtDu: Comment inline ---^^ basically you added width: 1.5em; at too high a level [01:36:04] So it should go under .oo-ui-labelElement-label? [01:36:30] Ahm, looking [01:37:36] No, it should go under .oo-ui-iconElement-icon, which should be added as a sibling to .oo-ui-labelElement-label [01:41:19] (03PS5) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 [01:43:12] (03PS7) 10MtDu: Adjust layout for new notification panel designs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263805 (https://phabricator.wikimedia.org/T122646) [01:45:06] (03CR) 10jenkins-bot: [V: 04-1] Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [01:47:49] (03PS6) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 [01:49:54] (03CR) 10Catrope: [C: 04-1] Introduce congratulatory notifications for reaching edit thresholds (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [01:50:14] RoanKattouw:New patch. [01:50:47] Thanks, will look [01:51:24] (03PS7) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 [01:52:04] Ugh, specificity problems :( [01:52:34] Let me try adding parent selectors, we should have had those there anyway [01:53:13] (03PS8) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 [01:53:27] Meh, or not [02:00:22] (03PS8) 10Catrope: Adjust layout for new notification panel designs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263805 (https://phabricator.wikimedia.org/T122646) (owner: 10MtDu) [02:01:40] MtDu: OK, so I had to add !important to the width/height rules because OOUI was trying to set the icon width/height really aggressively with high-specificity rules; and I had to remove a now-useless rule that for some reason set margin-right back to 0 on the action buttons https://gerrit.wikimedia.org/r/#/c/263805/7..8/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less [02:02:00] I also had to update the obscure compensation math for group items that I introduced earlier today https://gerrit.wikimedia.org/r/#/c/263805/7..8/modules/ooui/styles/mw.echo.ui.NotificationGroupItemWidget.less [02:02:26] With that, everything looks good, so I'll merge [02:02:35] (03CR) 10Catrope: [C: 032] Adjust layout for new notification panel designs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263805 (https://phabricator.wikimedia.org/T122646) (owner: 10MtDu) [02:04:10] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Adjust layout for the new notification panel designs - https://phabricator.wikimedia.org/T122646#1909757 (10Catrope) @PGiner-WMF: these changes should be on beta in 15 mins or so, please check if we got it all right. [02:05:57] (03Merged) 10jenkins-bot: Adjust layout for new notification panel designs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263805 (https://phabricator.wikimedia.org/T122646) (owner: 10MtDu) [02:11:21] (03PS4) 10Catrope: Add @integration tag to browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [02:11:38] (03CR) 10Catrope: [C: 032] Add @integration tag to browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [02:18:10] (03Merged) 10jenkins-bot: Add @integration tag to browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [02:20:23] 3Collaboration-Team-Current, 10Notifications: Read E-Mail and Welcome notifcations aren't displayed correctly - https://phabricator.wikimedia.org/T123756#1942860 (10Catrope) Ha! Good catch. This happens in cases where there is no primary link. [02:20:41] 3Collaboration-Team-Current, 10Notifications: Notifications with no primary link do not get the correct text color - https://phabricator.wikimedia.org/T123756#1942861 (10Catrope) [02:27:58] (03PS1) 10Catrope: Set text color on header directly, not on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264913 (https://phabricator.wikimedia.org/T123756) [02:29:07] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review: Notifications with no primary link do not get the correct text color - https://phabricator.wikimedia.org/T123756#1942866 (10Catrope) a:3Catrope [02:32:30] (03CR) 10Catrope: [C: 031] "Looks fine, let's merge this tomorrow after the cut to give translators some time." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263795 (https://phabricator.wikimedia.org/T121950) (owner: 10Sbisson) [02:35:29] (03CR) 10Jforrester: [C: 031] Reorganize NotificationBadgeWidget.less [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264880 (owner: 10Catrope) [02:38:00] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Inconsistent 'Cancel' button color for 'Edit title' and 'Edit post'/ 'Reply' - https://phabricator.wikimedia.org/T118427#1942877 (10Catrope) 5Open>3Resolved [02:38:09] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): "You are not logged in..." warning is not displayed when a non-logged user edits a title - https://phabricator.wikimedia.org/T104252#1942879 (10Catrope) 5Open>3Resolved [02:38:20] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: No-JavaScript - Flow glitches (tracking) - https://phabricator.wikimedia.org/T60019#1942882 (10Catrope) [02:38:22] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Error when trying to edit topic title in new tab / noJS mode - https://phabricator.wikimedia.org/T100851#1942881 (10Catrope) 5Open>3Resolved [02:39:10] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality, 7user-notice: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1942886 (10Catrope) [02:39:14] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 10Dumps-Generation, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1942883 (10Catrope) 5Open>3Resolved [02:39:17] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow dump import - https://phabricator.wikimedia.org/T114703#1942888 (10Catrope) 5Open>3Resolved [02:39:19] 3Collaboration-Team-Current, 10Flow, 10Dumps-Generation, 7Blocked-on-Operations, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#1828193 (10Catrope) [02:39:21] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Vagrant: Preload MediaWiki-Vagrant with Flow boards - https://phabricator.wikimedia.org/T119485#1942891 (10Catrope) [02:39:24] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Fix Flow Nuke support for dedicated Flow DB - https://phabricator.wikimedia.org/T121828#1942892 (10Catrope) 5Open>3Resolved [02:39:27] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke, 5Patch-For-Review, and 2 others: Add Flow support to Nuke - https://phabricator.wikimedia.org/T115695#1942894 (10Catrope) [02:39:49] 3Collaboration-Team-Current, 10Flow: Fix en:Wikipedia_talk:Flow/Developer_test_page - https://phabricator.wikimedia.org/T117812#1942898 (10Catrope) 5Open>3Resolved [02:40:05] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1942900 (10Catrope) 5Open>3Resolved [02:40:39] 3Collaboration-Team-Current, 10Flow: [betalabs] Special:Nuke - 'Pattern for the page name' filter does not work - https://phabricator.wikimedia.org/T123449#1942901 (10Catrope) [02:40:54] 3Collaboration-Team-Current, 10Flow: [betalabs] Special:Nuke - empty Flow pages are not listed - https://phabricator.wikimedia.org/T123450#1942903 (10Catrope) [02:41:38] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Relative timestamps in notification panel are wrong - https://phabricator.wikimedia.org/T121813#1942905 (10Catrope) 5Open>3Resolved [02:42:38] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Add filtering for unread notifications only to meta=notifications API - https://phabricator.wikimedia.org/T119890#1942906 (10Catrope) 5Open>3Resolved [02:42:59] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Put more space between adjacent category links - https://phabricator.wikimedia.org/T121955#1942907 (10Catrope) 5Open>3Resolved [02:43:05] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): [betalabs] Persistent notifications - X mark as read does not work - https://phabricator.wikimedia.org/T122087#1942908 (10Catrope) 5Open>3Resolved [02:43:33] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Anonymous reply warning should be connected to the text area - https://phabricator.wikimedia.org/T119491#1942910 (10Catrope) 5Open>3Resolved [02:59:55] (03PS1) 10Catrope: Tweak link-blue and revert icons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264914 (https://phabricator.wikimedia.org/T121624) [03:00:23] James_F: https://gerrit.wikimedia.org/r/#/c/264914 [03:00:44] (03CR) 10Jforrester: [C: 032] Tweak link-blue and revert icons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264914 (https://phabricator.wikimedia.org/T121624) (owner: 10Catrope) [03:01:14] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Clarify notification icons - https://phabricator.wikimedia.org/T121735#1942924 (10Catrope) [03:01:16] 3Collaboration-Team-Current, 10Notifications, 3Google-Code-In-2015, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Clarify link and revert icons on notifications - https://phabricator.wikimedia.org/T121624#1942923 (10Catrope) 5Open>3Resolved [03:02:44] 3Collaboration-Team-Current, 10Notifications: cross-wiki notification: "Could not retrieve notifications. Please try again. (Error 1)" - https://phabricator.wikimedia.org/T123797#1942930 (10Catrope) The actual cause of the error (https vs http) is a beta labs configuration issue, but the error message shouldn'... [03:03:04] 3Collaboration-Team-Current, 10Notifications: "Could not retrieve notifications" error message should not contain raw "$1" - https://phabricator.wikimedia.org/T123797#1942931 (10Catrope) [03:04:34] 3Collaboration-Team-Current, 10Flow: [betalabs] Editing Flow board entries not possible in VE - https://phabricator.wikimedia.org/T123011#1942936 (10Catrope) This should be fixed with https://gerrit.wikimedia.org/r/263642 [03:04:38] (03Merged) 10jenkins-bot: Tweak link-blue and revert icons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264914 (https://phabricator.wikimedia.org/T121624) (owner: 10Catrope) [03:04:44] 3Collaboration-Team-Current, 10Flow: [betalabs] Editing Flow board entries not possible in VE - https://phabricator.wikimedia.org/T123011#1942938 (10Catrope) a:3Catrope [03:08:45] 3Collaboration-Team-Current, 10Flow: [betalabs] 'Uncaught TypeError: Cannot read property 'commandRegistry' of null' for posting new topic - https://phabricator.wikimedia.org/T121614#1942963 (10Catrope) I can't reproduce with the steps you gave, but this bug is a month old. Is this still happening? [03:09:08] 3Collaboration-Team-Current, 10Notifications: Create new notification category for talk pages: flowusertalk - https://phabricator.wikimedia.org/T121663#1942965 (10Catrope) [03:09:10] 3Collaboration-Team-Current, 10Notifications: Create icons for Flowusertalk notifications - https://phabricator.wikimedia.org/T123434#1942964 (10Catrope) 5Open>3Resolved [03:14:51] (03PS1) 10Catrope: Add progress markers to backfillUnreadWikis.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264916 [03:15:00] https://gerrit.wikimedia.org/r/264916James_F: [03:15:03] James_F: https://gerrit.wikimedia.org/r/264916 [03:15:38] (03CR) 10Jforrester: [C: 032] Add progress markers to backfillUnreadWikis.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264916 (owner: 10Catrope) [03:18:54] RoanKattouw: " html( 'userlangattributes' ) ?>>exists() ? $msgObj->text() : $msg ); ?> " [03:19:29] (03Merged) 10jenkins-bot: Add progress markers to backfillUnreadWikis.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264916 (owner: 10Catrope) [03:20:43] (03CR) 10Mooeypoo: [C: 032] Set text color on header directly, not on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264913 (https://phabricator.wikimedia.org/T123756) (owner: 10Catrope) [03:42:27] 6Collaboration-Team-Backlog, 10Notifications, 7I18n: The notifications drop down menu displays numbers using the wrong numeral system on Arabic Wikipedia (arwiki) - https://phabricator.wikimedia.org/T123845#1942978 (10Catrope) This only applies to the timestamp ("6 hours ago"), right? I think that's because... [03:44:24] (03PS2) 10Jforrester: build: Update grunt-contrib-jshint to 0.12.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264622 (owner: 10Paladox) [03:44:29] (03CR) 10Jforrester: [C: 032] build: Update grunt-contrib-jshint to 0.12.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264622 (owner: 10Paladox) [03:45:03] (03PS2) 10Jforrester: build: Remove grunt-contrib-csslint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264623 (owner: 10Paladox) [03:45:12] (03CR) 10Jforrester: [C: 032] build: Remove grunt-contrib-csslint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264623 (owner: 10Paladox) [03:48:07] (03Merged) 10jenkins-bot: build: Update grunt-contrib-jshint to 0.12.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264622 (owner: 10Paladox) [03:48:10] (03CR) 10jenkins-bot: [V: 04-1] build: Remove grunt-contrib-csslint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264623 (owner: 10Paladox) [03:51:11] (03PS3) 10Jforrester: build: Remove grunt-contrib-csslint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264623 (owner: 10Paladox) [03:51:28] (03CR) 10Jforrester: [C: 032] "PS3 is a rebase." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264623 (owner: 10Paladox) [03:55:11] (03Merged) 10jenkins-bot: build: Remove grunt-contrib-csslint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264623 (owner: 10Paladox) [04:00:03] (03PS9) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 [04:02:08] (03CR) 10Legoktm: "Do we really need separate notification types for each one...?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [04:03:15] https://integration.wikimedia.org/ci/job/mwext-mw-selenium/2909/console <-- that was fast [04:09:53] (03CR) 10Catrope: [C: 04-1] "Typo; LGTM otherwise but haven't tested" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [04:10:07] legoktm: Yeah. I suppose we could tag a few more, provided they're stable [04:10:20] (03PS10) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 [04:10:29] Not too many though. [04:10:57] (03CR) 10MZMcBride: "Does this have an associated Phabricator Maniphest task?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [04:11:16] (03CR) 10Jforrester: "> Does this have an associated Phabricator Maniphest task?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [04:11:33] legoktm: Re them being different types vs the same: we could do that, that's how CX does theirs, but then you end up with a switch-case in getHeaderMessage instead [04:11:39] Which I suppose might be less ugly then repeating a 10-15 line definition in Echo.php five times [04:11:49] *four [04:12:07] "notification-good-job-$count-blah-blah" [04:12:25] Hah, right, yes [04:12:27] Good point [04:12:39] With CX we had to use the existing message keys, that's not an issue here [04:12:56] legoktm: Why oh why oh why does Echo, an extension YOU work on, not use extension registration? [04:13:14] James_F: because it relies on too much global state which we're slowly killing [04:13:30] Meh. [04:13:30] OK. [04:18:53] * legoktm runs away for dinner [04:26:46] (03PS11) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 [04:32:05] (03PS12) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 [04:32:08] legoktm: Hope you're happy. :-) [04:37:04] 3Collaboration-Team-Current, 6Editing-Department, 10Notifications, 7user-notice: Automatically congratulate users for reaching certain edit count milestones - https://phabricator.wikimedia.org/T124003#1943040 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF [04:37:22] (03PS13) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) [04:56:27] (03PS14) 10Catrope: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [05:10:23] (03PS15) 10Catrope: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [05:10:44] (03CR) 10Catrope: [C: 031] "Looks good to me and tested locally, but I wrote some of the code." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [05:12:10] (03CR) 10Catrope: "Also let's hold this until after the cut." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [06:18:55] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-ContentTranslation, 10Notifications, 5ContentTranslation-Release8, and 4 others: Notify translators about new personalised suggestions being available based on their recently published translation - https://phabricator.wikimedia.org/T119939#1943167 (10sant... [06:24:40] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-ContentTranslation, 10Notifications, 5ContentTranslation-Release8, and 4 others: Notify translators about new personalised suggestions being available based on their recently published translation - https://phabricator.wikimedia.org/T119939#1943169 (10sant... [07:28:00] (03CR) 10Paladox: "Thanks." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264623 (owner: 10Paladox) [07:28:19] (03CR) 10Paladox: "Thanks." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264622 (owner: 10Paladox) [07:46:49] (03CR) 10Ori.livneh: "An empty commit message is not very useful. You may want to reference (03CR) 10Legoktm: [C: 04-1] Introduce congratulatory notifications for reaching edit thresholds (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [07:53:33] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 10Dumps-Generation, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1943232 (10Nemo_bis) Where on https://dumps.wikimedia.org/backup-index.html do I see the dumps? [07:55:01] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 10Dumps-Generation, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1943233 (10Nemo_bis) Ah, I see, reversed dependencies. [07:55:26] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 10Dumps-Generation, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1943235 (10Nemo_bis) [07:55:28] 3Collaboration-Team-Current, 10Flow, 10Dumps-Generation, 7Blocked-on-Operations, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#1943234 (10Nemo_bis) [07:55:39] 3Collaboration-Team-Current, 10Flow, 10Dumps-Generation, 7Blocked-on-Operations, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#1828193 (10Nemo_bis) [07:55:41] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 10Dumps-Generation, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1035296 (10Nemo_bis) [07:55:50] 3Collaboration-Team-Current, 10Flow, 10Datasets-General-or-Unknown, 10Dumps-Generation, and 3 others: Add Flow to database dumps - https://phabricator.wikimedia.org/T89398#1943238 (10Nemo_bis) 5Resolved>3Open [07:55:52] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality, 7user-notice: Opt-in for Flow on your own user talk page - https://phabricator.wikimedia.org/T98270#1943239 (10Nemo_bis) [07:56:55] 3Collaboration-Team-Current, 10Flow, 10Dumps-Generation, 7Blocked-on-Operations, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#1943244 (10Nemo_bis) p:5Normal>3High Fix priority per blocked task. [07:58:23] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-ContentTranslation, 10Notifications, 5ContentTranslation-Release8, and 4 others: Notify translators about new personalised suggestions being available based on their recently published translation - https://phabricator.wikimedia.org/T119939#1943247 (10Pgin... [08:00:17] (03PS16) 10Legoktm: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) (owner: 10Jforrester) [08:00:50] 3Collaboration-Team-Current, 6Editing-Department, 10Notifications, 5Patch-For-Review, 7user-notice: Automatically congratulate users for reaching certain edit count milestones - https://phabricator.wikimedia.org/T124003#1943250 (10Legoktm) @ori mentioned 6Collaboration-Team-Backlog, 10Notifications, 7Regression: Notifications about being mentioned don't point to the section of the mention anymore - https://phabricator.wikimedia.org/T123847#1943273 (10Legoktm) Yeah, I noticed this too. Should be added as an additional secondary link IMO. [08:06:44] 3Collaboration-Team-Current, 10Notifications, 7Regression: Notifications about being mentioned don't point to the section of the mention anymore - https://phabricator.wikimedia.org/T123847#1943275 (10Legoktm) [08:07:05] 6Collaboration-Team-Backlog, 10Notifications, 7Technical-Debt: Use OOUI icons for the 'big' icons, not just the little ones, in Notifications - https://phabricator.wikimedia.org/T123996#1943277 (10Legoktm) Which icons are the "big" ones? [08:07:39] 6Collaboration-Team-Backlog, 10Notifications, 7Technical-Debt: Use OOUI icons for the 'big' icons, not just the little ones, in Notifications - https://phabricator.wikimedia.org/T123996#1943285 (10Legoktm) `$wgEchoNotificationIcons`? [08:26:45] 6Collaboration-Team-Backlog, 10Notifications, 7Easy, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Deprecated: Use of UserMailer::send with $replyto as 5th parameter was deprecated in MediaWiki 1.26. [Called from MWEchoEmailBatch::sendEmail i... - https://phabricator.wikimedia.org/T123641#1943307 [08:39:45] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Run subset of Echo browser tests on patch submission in Jenkins - https://phabricator.wikimedia.org/T109679#1943319 (10Legoktm) 5Open>3Resolved a:3Legoktm [10:45:30] 6Collaboration-Team-Backlog, 10Notifications: Unbalanced space in bundled cross-wiki notifications - https://phabricator.wikimedia.org/T124023#1943469 (10Pginer-WMF) 3NEW [11:14:05] 6Collaboration-Team-Backlog, 10Notifications: Adjust the mark as read "X" icon size - https://phabricator.wikimedia.org/T124025#1943484 (10Pginer-WMF) 3NEW [11:17:13] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Adjust layout for the new notification panel designs - https://phabricator.wikimedia.org/T122646#1943512 (10Pginer-WMF) >>! In T122646#1942850, @Catrope wrote: > @PGiner-WMF: these changes should be on... [12:38:42] 6Collaboration-Team-Backlog, 10Notifications: Adjust the mark as read "X" icon size - https://phabricator.wikimedia.org/T124025#1943677 (10MtDu) a:3MtDu This is mark as read one right? Am I just supposed to change the svg? [12:59:21] 6Collaboration-Team-Backlog, 10Collaboration-Community-Engagement, 6Community-Liaison, 10WMF-Product-Development-Process: Rethink the way we communicate with communities concerning Collaboration team work - https://phabricator.wikimedia.org/T123538#1943713 (10Qgil) The "rethink" exercise needs to be done f... [13:37:53] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Echo for anonymous users - https://phabricator.wikimedia.org/T58828#1943793 (10matej_suchanek) [14:32:38] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow\Exception\FlowException from line 159 of Flow/includes/Formatter/ChangesListQuery.php: Revision not found in revisionCache - https://phabricator.wikimedia.org/T122329#1943936 (10Southparkfan) ``` root@mw1:/srv/mediawiki/w/extensions/Flow/maintenanc... [14:35:59] 3Collaboration-Team-Current, 10Flow, 10Datasets-Archiving, 10Dumps-Generation, and 2 others: Publish recurring Flow dumps at http://dumps.wikimedia.org/ - https://phabricator.wikimedia.org/T119511#1943950 (10Hydriz) [15:09:12] 6Collaboration-Team-Backlog, 10Flow: Flow should be able to enumerate all flow enabled pages on a wiki - https://phabricator.wikimedia.org/T63747#1944005 (10Trizek-WMF) Quarry does the job, but it is not a general-public tool: as many users, I don't know how to create SQL requests :) A category would allow peo... [15:48:11] 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 3Liaisons-January-2016, 7user-notice: Cross-wiki notifications - announcements planning - https://phabricator.wikimedia.org/T123570#1944100 (10Trizek-WMF) >>! In T123570#1942342, @Billinghurst wrote: > @... [16:49:16] 6Collaboration-Team-Backlog, 10Notifications: Adjust the mark as read "X" icon size - https://phabricator.wikimedia.org/T124025#1944313 (10Pginer-WMF) >>! In T124025#1943677, @MtDu wrote: > This is mark as read one right? Am I just supposed to change the svg? This refers to the action of marking an individua... [17:19:39] 6Collaboration-Team-Backlog, 10Notifications, 7I18n: The notifications drop down menu displays numbers using the wrong numeral system on Arabic Wikipedia (arwiki) - https://phabricator.wikimedia.org/T123845#1944380 (10Meno25) >>! In T123845#1942978, @Catrope wrote: > This only applies to the timestamp ("6 ho... [17:28:01] 3Collaboration-Team-Current, 10Notifications: Unbalanced space in bundled cross-wiki notifications - https://phabricator.wikimedia.org/T124023#1944394 (10Catrope) [17:30:25] 3Collaboration-Team-Current, 10Notifications, 7Regression: Notifications about being mentioned don't point to the section of the mention anymore - https://phabricator.wikimedia.org/T123847#1944400 (10Catrope) Hah, weird. I can confirm that it doesn't work, but I can also see that the code tries to make it work. [17:35:11] 3Collaboration-Team-Current, 10Notifications, 7Regression: Notifications about being mentioned don't point to the section of the mention anymore - https://phabricator.wikimedia.org/T123847#1944410 (10Catrope) a:3Catrope [17:36:01] (03PS1) 10Catrope: Make the mention notification actually link to the right section [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264971 (https://phabricator.wikimedia.org/T123847) [17:40:50] (03CR) 10Jforrester: [C: 032] Make the mention notification actually link to the right section [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264971 (https://phabricator.wikimedia.org/T123847) (owner: 10Catrope) [17:45:06] (03Merged) 10jenkins-bot: Make the mention notification actually link to the right section [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264971 (https://phabricator.wikimedia.org/T123847) (owner: 10Catrope) [17:47:01] (03CR) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds (034 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (https://phabricator.wikimedia.org/T124003) (owner: 10Jforrester) [18:11:44] 6Collaboration-Team-Backlog, 10Flow: [betalabs] Edit post minor issues when VE is default editor - https://phabricator.wikimedia.org/T124067#1944549 (10Etonkovidova) 3NEW [18:11:59] 6Collaboration-Team-Backlog, 10Flow: [betalabs] Edit post - minor issues when VE is default editor - https://phabricator.wikimedia.org/T124067#1944560 (10Etonkovidova) [18:13:29] 3Collaboration-Team-Current, 10Flow: [betalabs] Editing Flow board entries not possible in VE - https://phabricator.wikimedia.org/T123011#1919277 (10Etonkovidova) Checked in betalabs - filed {T124067} [18:23:24] 3Collaboration-Team-Current, 10Notifications, 7Voice & Tone, 7WorkType-NewFunctionality: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#1944597 (10SBisson) a:3SBisson [18:27:23] 3Collaboration-Team-Current, 10Notifications: Making a null edit triggers a new message notification although null edit is not recorded in page history - https://phabricator.wikimedia.org/T123843#1944629 (10Catrope) [18:39:47] 3Collaboration-Team-Current, 10Notifications: Unbalanced space in bundled cross-wiki notifications - https://phabricator.wikimedia.org/T124023#1944665 (10Mooeypoo) This should be fixed by this (merged) commit: https://gerrit.wikimedia.org/r/#/c/260689/ [18:46:05] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests: Remove Flow from Wikipedia talk:WikiProject Breakfast on enwp - https://phabricator.wikimedia.org/T122961#1944685 (10Quiddity) @Alsee The change back to wikitext contentmodel is as originally described. (Standard disclaimer for this is not legal... [18:51:28] 3Collaboration-Team-Current, 10Notifications: Unbalanced space in bundled cross-wiki notifications - https://phabricator.wikimedia.org/T124023#1944716 (10Catrope) >>! In T124023#1944665, @Mooeypoo wrote: > This should be fixed by this (merged) commit: https://gerrit.wikimedia.org/r/#/c/260689/ It isn't. This... [19:19:02] RoanKattouw: For this, https://phabricator.wikimedia.org/T124025 I just have to add a rule under the markasread section where I added the -.5 margin? (https://gerrit.wikimedia.org/r/#/c/263805/8/modules/ooui/styles/mw.echo.ui.NotificationItemWidget.less) [19:20:20] Yeah you should be able to set width+height on the button I think [19:20:25] Or maybe on the icon inside of it [19:21:19] RoanKattouw: Ok. Will do in a few minutes. You'll probably need to review it. [19:21:37] I'm in a meeting till noon so I may be slow to review [19:22:13] That's fine. I'll push it later then. Oh, so is andre. You guys together? [19:22:30] No, different meeting [19:23:08] 10am and 11am PT are popular meeting times because of the timezone overlap between the US and Europe [19:47:05] (03PS1) 10MtDu: Adjust mark as read icon size [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264995 (https://phabricator.wikimedia.org/T124025) [19:53:52] MtDu: Hmm, apparently applying width+height to the button itself just screws with the alignment and doesn't actually make it smaller [19:54:07] You can try that kind of thing in the browser console BTW [19:54:08] Interesting. [19:54:50] Probably because OOUI still forces the icon to be 1.875em [19:55:07] So I think you need to override the icon size [19:55:07] Also Pau asked for 1.7em, not 1.5 [19:55:30] And you'll need !important again because of how strong the OOUI rule are [19:55:32] *rules [19:56:20] Yep yep I saw. [19:56:32] Do you want me to comment on it as in previous paches? [19:57:09] (03CR) 10Catrope: [C: 04-1] "Summarizing from IRC: rules need to be applied to the icon instead of the button (layout gets messed up otherwise) and the task asks for 1" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264995 (https://phabricator.wikimedia.org/T124025) (owner: 10MtDu) [19:57:31] You mean write a comment like "we have to put !important here to override OOUI's rules"? [19:57:48] (or whatever the standard phrasing we use for that is) [19:58:06] Or a comment about something else? [19:58:38] Yeah [19:59:14] (03CR) 10Catrope: [C: 032] Rephrase Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263795 (https://phabricator.wikimedia.org/T121950) (owner: 10Sbisson) [19:59:19] Yeah let's include that [20:04:33] (03CR) 10Sbisson: [C: 04-1] "I think we left a few "internal" when we merged. And not all comments are up to date." (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [20:04:40] (03Merged) 10jenkins-bot: Rephrase Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263795 (https://phabricator.wikimedia.org/T121950) (owner: 10Sbisson) [20:07:12] RoanKattouw: This look ok? https://dpaste.de/zwc8 Or am I calling the wrong class. Is there like a doc with all the mediawiki oojs-ui stuff? [20:07:17] 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 3Liaisons-January-2016, 7user-notice: Cross-wiki notifications - announcements planning - https://phabricator.wikimedia.org/T123570#1945120 (10Quiddity) @Billinghurst, The mw:Help:Notifications doc page... [20:11:16] RoanKattouw:^ [20:24:55] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Notifications with no primary link do not get the correct text color - https://phabricator.wikimedia.org/T123756#1945356 (10Etonkovidova) Checked the fix in betalabs -both E-ail and Welcome notification... [20:25:42] (03PS2) 10MtDu: Adjust mark as read icon size [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264995 (https://phabricator.wikimedia.org/T124025) [20:31:25] 6Collaboration-Team-Backlog, 10Notifications, 7Epic, 7WorkType-NewFunctionality, 7user-notice: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#1945420 (10MGChecker) One question, what happens in this cases: * At mediawiki, I disable Flow notifications. *... [20:36:38] 6Collaboration-Team-Backlog, 10MediaWiki-Change-tagging, 10Notifications, 7Easy: Notify user when a tag is added to/removed from their edit - https://phabricator.wikimedia.org/T112119#1945460 (10Adeora7) @matej_suchanek which notification category should be used? Or a new notification category should be made? [20:37:32] MtDu: Sorry, I was out getting lunch and forgot to use /away [20:38:01] MtDu: Looks mostly fine except I'd recommend using .oo-ui-iconElement-icon instead, because that way if we ever change the icon to something other than 'close', it won't break [20:38:12] Will do. [20:39:02] (03CR) 10Catrope: [C: 04-1] Adjust mark as read icon size (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264995 (https://phabricator.wikimedia.org/T124025) (owner: 10MtDu) [20:41:41] (03PS3) 10MtDu: Adjust mark as read icon size [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264995 (https://phabricator.wikimedia.org/T124025) [20:54:02] 6Collaboration-Team-Backlog, 10MediaWiki-Change-tagging, 10Notifications, 7Easy: Notify user when a tag is added to/removed from their edit - https://phabricator.wikimedia.org/T112119#1945584 (10matej_suchanek) I'm not a developer, this is rather a question for them, though I don't think any of the default... [21:01:38] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Clarify notification icons - https://phabricator.wikimedia.org/T121735#1945620 (10MtDu) Closing this as resolved. [21:01:43] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Clarify notification icons - https://phabricator.wikimedia.org/T121735#1945624 (10MtDu) 5Open>3Resolved [21:02:18] 6Collaboration-Team-Backlog, 10Flow, 7Easy, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): ext.flow.mediawiki.ui.tooltips and ext.flow.mediawiki.ui.modal should not use addModuleStyles - https://phabricator.wikimedia.org/T97467#1945627 (10MtDu) 5Open>3Resolved [21:02:51] 3Collaboration-Team-Current, 10Flow, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1945636 (10MtDu) Closing as resolved. [21:02:58] 3Collaboration-Team-Current, 10Flow, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1945638 (10MtDu) 5Open>3Resolved [21:03:29] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Adjust layout for the new notification panel designs - https://phabricator.wikimedia.org/T122646#1945641 (10MtDu) Closing as resolved. [21:03:36] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#1945644 (10MtDu) [21:03:38] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Adjust layout for the new notification panel designs - https://phabricator.wikimedia.org/T122646#1945643 (10MtDu) 5Open>3Resolved [21:05:08] 6Collaboration-Team-Backlog, 10Notifications: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#1945666 (10Mooeypoo) [21:05:10] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Adjust layout for the new notification panel designs - https://phabricator.wikimedia.org/T122646#1945664 (10Mooeypoo) 5Resolved>3Open @MtDu, thanks for the commit! we are usually keeping the merged... [21:06:43] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Adjust layout for the new notification panel designs - https://phabricator.wikimedia.org/T122646#1945683 (10MtDu) @mooeypoo, Ok thanks for the notice. I just needed to clean up some of the tasks I was a... [21:10:27] 6Collaboration-Team-Backlog, 10Flow, 10Front-end-Standards-Group, 10MediaWiki-General-or-Unknown, and 4 others: Should be a standard way to access tablet browser width threshold - https://phabricator.wikimedia.org/T93675#1945719 (10Jdlrobson) [21:32:18] stephanebisson: Sorry for the delay, heading upstairs now [21:32:36] 3Collaboration-Team-Current, 10Flow, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1945807 (10Catrope) 5Resolved>3Open [21:32:57] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Clarify notification icons - https://phabricator.wikimedia.org/T121735#1945809 (10Catrope) 5Resolved>3Open [22:09:32] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Adjust layout for the new notification panel designs - https://phabricator.wikimedia.org/T122646#1945928 (10Etonkovidova) Verifying the fixes in betalabs - going through the list of @Pgner-WMF's Adjus... [22:11:53] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): Use the globe icon for cross-wiki notification bundle - https://phabricator.wikimedia.org/T123757#1945935 (10Etonkovidova) Checked in betalabs - the cross-wiki notification bundle is correctly indicated... [22:21:20] 6Collaboration-Team-Backlog, 10Notifications, 7Testme: Changes to my user talk page no longer trigger the orange "You have new messages" box - https://phabricator.wikimedia.org/T38662#1945974 (10Quiddity) 5Open>3Invalid a:3Quiddity >>! In T38662#1398432, @Redrose64 wrote: > Well, since the change to Ec... [22:41:01] 3Collaboration-Team-Current, 10Notifications, 5Patch-For-Review, 5WMF-deploy-2016-01-19_(1.27.0-wmf.11): The action menu ("...") for bundled notifications cannot be closed by clicking on it again - https://phabricator.wikimedia.org/T123754#1946013 (10Etonkovidova) Checked in betalabs - the ellipsis's menu... [22:45:08] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 10Notifications: Flow Thanks workflow= URLs are not redirected to the specific post in Safari - https://phabricator.wikimedia.org/T124108#1946035 (10Quiddity) 3NEW [22:57:53] 6Collaboration-Team-Backlog, 10Notifications: cross-wiki notification: bundled notifications are not counted - https://phabricator.wikimedia.org/T124109#1946068 (10Etonkovidova) 3NEW [23:06:37] 3Collaboration-Team-Current, 10Notifications: cross-wiki notification: bundled notifications are not counted - https://phabricator.wikimedia.org/T124109#1946146 (10Catrope) [23:07:09] 6Collaboration-Team-Backlog, 10Wikimedia-Extension-setup, 7Community-consensus-needed, 5Patch-For-Review: Install WikiLove extension at Azerbaijani Wikipedia - https://phabricator.wikimedia.org/T119727#1946149 (10Dereckson) @Serkanland Is there now a consensus to enable the extension? [23:14:55] 3Collaboration-Team-Current, 10Notifications, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1946184 (10Mooeypoo) After a couple of in-person discussions, here is the current idea for moving forward: The current idea is to create a base list... [23:27:33] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 10Notifications, 7Browser-Support-Apple-Safari: Flow Thanks workflow= URLs are not redirected to the specific post in Safari - https://phabricator.wikimedia.org/T124108#1946216 (10Legoktm) [23:34:05] (03PS10) 10Mooeypoo: [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [23:36:20] (03CR) 10jenkins-bot: [V: 04-1] [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [23:50:35] (03PS11) 10Mooeypoo: Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766