[00:29:43] 6Collaboration-Team-Backlog, 10Flow: Flow should be able to enumerate all flow enabled pages on a wiki - https://phabricator.wikimedia.org/T63747#1940303 (10Catrope) I agree we should expose this in the software, probably with a tracking category, but in the meantime you can get a list from Quarry pretty easil... [06:26:21] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release8, and 3 others: Notify translators about new personalised suggestions being available based on their recently published translation - https://phabricator.wikimedia.org/T119939#1940522 (10santhosh) [06:27:22] (03PS3) 10Matthias Mullie: EchoModelFormatter extends EchoEventFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263748 [06:27:26] (03PS1) 10Matthias Mullie: Deprecate ApiEchoNotifications.php format params flyout & html [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264718 [06:27:47] (03CR) 10Matthias Mullie: "I must've messed up when stuffing the deprecation in between the patch chain :) split up now" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263748 (owner: 10Matthias Mullie) [06:30:37] (03PS3) 10Matthias Mullie: Get rid of $legacyMapping [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263763 [06:31:51] (03CR) 10Legoktm: [C: 032] EchoModelFormatter extends EchoEventFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263748 (owner: 10Matthias Mullie) [06:33:43] (03CR) 10Legoktm: "Hmm, is there no way to mark in the autogenerated docs that those two formats are deprecated?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264718 (owner: 10Matthias Mullie) [06:34:59] (03Merged) 10jenkins-bot: EchoModelFormatter extends EchoEventFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263748 (owner: 10Matthias Mullie) [06:36:12] (03CR) 10Matthias Mullie: "I took a quick look at API classes, but couldn't really find something like that. Maybe Anomie knows of a way to mark specific values for " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264718 (owner: 10Matthias Mullie) [07:34:09] 3Collaboration-Team-Current, 10MediaWiki-Revision-deletion, 7Easy, 5Patch-For-Review, 7user-notice: Button option to 'choose all/none/reverse' for revdel - https://phabricator.wikimedia.org/T92230#1940605 (10Legoktm) +user-notice so projects are aware and can remove their JavaScript hacks. [07:34:17] 3Collaboration-Team-Current, 10MediaWiki-Revision-deletion, 7Easy, 5Patch-For-Review, 7user-notice: Button option to 'choose all/none/reverse' for revdel - https://phabricator.wikimedia.org/T92230#1940607 (10Legoktm) 5Open>3Resolved [07:36:02] 3Collaboration-Team-Current, 10MediaWiki-Revision-deletion, 7Easy, 7user-notice: Button option to 'choose all/none/reverse' for revdel - https://phabricator.wikimedia.org/T92230#1940611 (10revi) [07:40:26] 3Collaboration-Team-Current, 10MediaWiki-Revision-deletion, 7Easy, 7user-notice: Button option to 'choose all/none/reverse' for revdel - https://phabricator.wikimedia.org/T92230#1940614 (10Legoktm) 5Resolved>3Open Patch only covered Special:Log, still need something for action=history. [07:43:40] 3Collaboration-Team-Current, 10MediaWiki-Revision-deletion, 7Easy, 7user-notice: Button option to 'choose all/none/reverse' for revdel - https://phabricator.wikimedia.org/T92230#1940616 (10lfaraone) >>! In T92230#1940614, @Legoktm wrote: > Patch only covered Special:Log, still need something for action=his... [13:40:38] 3Collaboration-Team-Current, 10Echo: Create icons for Flowusertalk notifications - https://phabricator.wikimedia.org/T123434#1940960 (10Pginer-WMF) Here are the proposed icons for flowusertalk: flowusertalk-new-topic: {F3239527} {F3239526} Flowusertalk-post-reply (same as "edit-user-talk" in T121735): {F3239... [13:40:58] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Change-tagging, 7Easy: Notify user when a tag is added to/removed from their edit - https://phabricator.wikimedia.org/T112119#1940963 (10Adeora7) Hello, I am looking forward to solve my first bug. This bug is from the extension https://www.mediawiki.org/wik... [14:18:49] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Change-tagging, 7Easy: Notify user when a tag is added to/removed from their edit - https://phabricator.wikimedia.org/T112119#1941012 (10TTO) @Adeora7: When looking at a task that you want to work on, be sure to check the "Projects" field. It will show you... [14:25:20] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1941030 (10Nemo_bis) [15:10:19] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Change-tagging, 7Easy: Notify user when a tag is added to/removed from their edit - https://phabricator.wikimedia.org/T112119#1941116 (10Adeora7) @matej_suchanek @TTO thanks. I thought MediaWiki-Change-tagging is a separate extension. [15:14:21] (03PS3) 10Sbisson: Display revert edit summary in revert notification body [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264299 (https://phabricator.wikimedia.org/T121808) [15:35:24] (03CR) 10Anomie: "The API doesn't currently have a way to mark specific values of an enum-style parameter as deprecated; currently when this is needed we ju" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264718 (owner: 10Matthias Mullie) [15:35:57] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison, 10MediaWiki-General-or-Unknown, 10VisualEditor: Feedback tool doesn't require the subject, and posting fails when the page points to a Flow board if the subject isn't required - https://phabricator.wikimedia.org/T122414#1941183 (10Jdforrester-WMF) [16:03:28] (03CR) 10Sbisson: Display revert edit summary in revert notification body (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264299 (https://phabricator.wikimedia.org/T121808) (owner: 10Sbisson) [16:23:09] 3Collaboration-Team-Current, 10Echo: Rephrase Echo 'edit-user-talk' notifications - https://phabricator.wikimedia.org/T123934#1941313 (10SBisson) 3NEW a:3SBisson [16:23:48] (03PS2) 10Sbisson: Rephrase Echo 'edit-user-talk' notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264332 (https://phabricator.wikimedia.org/T123934) [16:25:45] (03CR) 10Sbisson: "Now there is a phab task. I was working off the spreadsheet (V 2.0)" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264332 (https://phabricator.wikimedia.org/T123934) (owner: 10Sbisson) [17:40:01] (03PS1) 10Mooeypoo: [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [17:40:26] (03CR) 10jenkins-bot: [V: 04-1] [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [17:40:34] stephanebisson, I realized that I forgot to publish/share the code we worked on. It would be good if we can continue pairing today, but regardless, the WIP is in gerrit now [17:40:50] sorry for the delay, I completely forgot. [17:51:21] mooeypoo: hello [18:13:28] are we having a standup at all today given it's supposedly a day off? [18:13:38] stephanebisson, when/how/if do you want to continue? [18:16:39] mooeypoo: don't know... it's a regular day outside the US but at least Nick and Benoit are not working [18:16:51] I don't know about Matthias and Pau [18:17:41] stephanebisson, do you want to try and start or wait to see if there's a standup? [18:18:01] mooeypoo: let's have a quick standup at the regular time and work together right after [18:18:10] * mooeypoo nods [18:18:20] are you in the office? [18:31:13] stephanebisson: No, she's not. :-) [18:33:27] I am working from home today [18:33:36] James_F, aww how alone are you? [18:34:03] mooeypoo: There's a couple of people here. Feel free to come in. :-P [18:36:35] stephanebisson, mlitn great, hangouts decided to revoke my password access and is now making me sign up again with 2 step authentication... :\ I'm trying to come back to standup [18:36:56] :) [18:39:24] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison, 10MediaWiki-General-or-Unknown, 10VisualEditor: Feedback tool doesn't require the subject, and posting fails when the page points to a Flow board if the subject isn't required - https://phabricator.wikimedia.org/T122414#1941765 (10Jdforrester-WMF)... [19:14:17] RoanKattouw: You going to merge my SVG changes? ;-) [19:14:31] Yes :) [19:14:59] That commit is already the 11th most recent in Echo though [19:17:17] I can keep rebasing until you merge it. ;-) [19:17:29] It also depends on a change of mien [19:17:47] (03CR) 10Catrope: [C: 032] Crush all SVGs with svgo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264430 (owner: 10Jforrester) [19:17:52] I can +2 yours if you twist my arm. ;-) [19:18:13] But ideally mooeypoo would +2 https://gerrit.wikimedia.org/r/#/c/264394/ [19:24:53] (03CR) 10Catrope: [C: 04-1] Rephrase Echo 'edit-user-talk' notification (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264332 (https://phabricator.wikimedia.org/T123934) (owner: 10Sbisson) [19:43:12] (03CR) 10Catrope: [C: 032] Display revert edit summary in revert notification body [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264299 (https://phabricator.wikimedia.org/T121808) (owner: 10Sbisson) [19:46:46] (03CR) 10Catrope: [C: 04-1] "This doesn't fix anything, it just renames a variable. The issue is that UserMailer::send() now expects the 5th parameter to be an array o" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [19:46:52] (03Merged) 10jenkins-bot: Display revert edit summary in revert notification body [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264299 (https://phabricator.wikimedia.org/T121808) (owner: 10Sbisson) [19:53:36] 6Collaboration-Team-Backlog, 10Echo: On a stale (?) tab, I opened the 'messages' panel and was told I had a dewiki notification – but on expanding the group, I was told I didn't (went away on refresh) - https://phabricator.wikimedia.org/T123953#1941873 (10Jdforrester-WMF) 3NEW [20:01:29] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Update and retest the convertToText script - https://phabricator.wikimedia.org/T90075#1941895 (10matthiasmullie) Mmh yeah, that's wrong. If we use `*`, we can't prefix every line with it. I'm also concerned that when using an asterisk, it will be confu... [20:05:45] (03PS2) 10Mooeypoo: [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [20:06:00] (03CR) 10jenkins-bot: [V: 04-1] [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [20:07:35] (03PS7) 10Mooeypoo: Mark bundles as read except when it is automatic [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261290 (https://phabricator.wikimedia.org/T121930) [20:11:33] (03PS8) 10MtDu: Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) [20:15:21] (03CR) 10jenkins-bot: [V: 04-1] Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [20:16:38] (03PS3) 10Mooeypoo: [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [20:17:26] (03PS9) 10MtDu: Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) [20:17:41] (03PS4) 10Mooeypoo: [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [20:23:14] (03CR) 10jenkins-bot: [V: 04-1] [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [20:24:59] (03CR) 10Mooeypoo: [C: 032] Use globe icon for cross-wiki bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264394 (https://phabricator.wikimedia.org/T123757) (owner: 10Catrope) [20:28:55] (03Merged) 10jenkins-bot: Use globe icon for cross-wiki bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264394 (https://phabricator.wikimedia.org/T123757) (owner: 10Catrope) [20:28:59] (03Merged) 10jenkins-bot: Crush all SVGs with svgo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264430 (owner: 10Jforrester) [20:29:13] Gosh. [20:44:23] (03PS3) 10Sbisson: Rephrase Echo 'edit-user-talk' notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264332 (https://phabricator.wikimedia.org/T123934) [20:46:39] (03CR) 10Catrope: [C: 032] Rephrase Echo 'edit-user-talk' notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264332 (https://phabricator.wikimedia.org/T123934) (owner: 10Sbisson) [20:50:41] (03Merged) 10jenkins-bot: Rephrase Echo 'edit-user-talk' notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264332 (https://phabricator.wikimedia.org/T123934) (owner: 10Sbisson) [20:55:55] (03PS3) 10Catrope: Remove unused icon files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264140 [20:56:38] (03CR) 10Jforrester: [C: 031] Remove unused icon files [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264140 (owner: 10Catrope) [20:57:43] (03CR) 10Catrope: [C: 031] "Looks good to me, but haven't tested." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [21:18:10] (03CR) 10Catrope: Don't blur talk icon echo notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264564 (https://phabricator.wikimedia.org/T123656) (owner: 10MtDu) [21:18:58] 3Collaboration-Team-Current, 10Flow, 10Notifcations, 5Patch-For-Review: blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1942132 (10Catrope) @PGiner-WMF: The patch at https://gerrit.wikimedia.org/r/264564 looks good to me, but it reduces the space between the icon and the te... [21:19:18] (03CR) 10MtDu: Don't blur talk icon echo notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264564 (https://phabricator.wikimedia.org/T123656) (owner: 10MtDu) [21:19:45] (03PS10) 10Reedy: Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [21:19:50] (03CR) 10Reedy: [C: 032] Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [21:26:23] (03Merged) 10jenkins-bot: Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [22:02:30] (03CR) 10Catrope: [C: 032] Mark bundles as read except when it is automatic [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261290 (https://phabricator.wikimedia.org/T121930) (owner: 10Mooeypoo) [22:03:52] (03CR) 10Catrope: [C: 032] Avoid pure black icons in Notification Panel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/262886 (https://phabricator.wikimedia.org/T119378) (owner: 10Haritha28) [22:03:57] (03PS5) 10Mooeypoo: [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [22:06:14] (03Merged) 10jenkins-bot: Mark bundles as read except when it is automatic [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261290 (https://phabricator.wikimedia.org/T121930) (owner: 10Mooeypoo) [22:07:38] (03CR) 10jenkins-bot: [V: 04-1] [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [22:08:19] (03Merged) 10jenkins-bot: Avoid pure black icons in Notification Panel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/262886 (https://phabricator.wikimedia.org/T119378) (owner: 10Haritha28) [22:08:58] RoanKattouw: Could you help me find the styling rule for the close icon? https://phabricator.wikimedia.org/T122646 [22:09:11] RoanKattouw: (Teach me how to find it) [22:09:24] WTF vagrant. Why is my qunit tests aligned RTL when my wiki is LTR... [22:09:30] heya MtDu_ [22:09:39] mooeypoo: Hello! [22:09:41] MtDu_, I can try and help, let me see [22:09:55] MtDu_, do you know how to work with Chrome's "console" ? [22:10:09] Yeah, but vagrant's not working for me. :p [22:10:16] oh, noooo [22:10:25] wait, so you're working "blind" ? No actual testing environment? [22:10:36] Well, yeah I guess. [22:10:44] That's... actually pretty impressive.... if not entirely annoying. [22:10:51] Most of the stuff I do that needs testing has been for pywikibot [22:11:03] And I test those. Believe me on that one. [22:11:06] * mooeypoo nods [22:11:09] I can imagine :P [22:11:20] but it would be great if we can set you up with a working dev environment [22:11:21] But yeah. School hasn't been nice to me, so Ihaven't had the time to reconfigure vagrant. [22:11:25] let me look for that rule, though [22:11:32] aw :( [22:11:48] Ok, School's way more important. But if/when you get a break, do come back ! we'll set you up. [22:11:57] There might not presently be a rule targeting the close icon [22:12:03] in Echo I mean [22:12:03] I, for one, was hoping you'll stick around to help us out even after Google Code In is done :) [22:12:05] You might have to add it [22:12:31] mooeypoo: You know I will. I've already been doing stuff outside of GCI. :) [22:12:48] oh! I have an idea, MtDu_ , I completely forgot... go to mediawiki.org and use chrome's console there [22:13:05] ou won't be able to test your *fix* but at least it'll always help you find the right rule (if it exists) or narrow it down [22:13:59] I'm logged in and in the notification header, but I don't see a close icon. Probably because I only have one notification. [22:14:08] You can test CSS too, but it's a bit complicated, and given that you have to add stuff to a LESS file it's not watertight [22:14:30] Hmm, maybe they mean the "mark as read" thing [22:14:35] I was going to ask that [22:14:41] What "close" icon are we talking about? [22:14:52] An X icon (probably named close in the CSS) appears to the right of notifs that are unread, to let you mark them as read [22:14:55] mark as read for individual notifications, or mark as read for all (which doesn't have an icon) ? [22:15:29] Yeah, we should really rethink that X icon in general (it's not "close" :\ ) but ok -- that should have styling, I do believe I made it slightly smaller [22:15:31] See the phabricator task. There's pictures there. [22:15:54] wait, RoanKattouw, did we merge the table layout? [22:15:54] What is it called then? [22:16:09] Not yet [22:16:22] MtDu_, its filename is "close.svg" so you're right on that, but it's basically the "mark as read" icon [22:16:23] Going to review that today [22:16:29] RoanKattouw, it might fix that issue... [22:16:40] MtDu_: Best course of action is to make one appear in your browser so you can inspect it [22:16:45] also, even if it doesn't, it will be best to apply whatever alignment fix on *top* of that commit [22:17:01] It's easy enough to get a new unread notifcation, just edit your user talk page while logged out in an incognito window [22:17:04] Sure [22:17:45] I am fairly sure I worked with 'table' display and then rows, so the alignment *should* be correct on that fix [22:17:52] ... "should" is the key word here [22:18:26] (03PS2) 10Mooeypoo: Organize items in bundles with CSS table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260689 (https://phabricator.wikimedia.org/T121933) [22:19:31] RoanKattouw: Ok. I got it. Inspecting now. Do you think I should wait and see if Mooeypoo's patch fixes it? [22:19:43] MtDu_, this is for a code-in task? [22:19:49] Nope. :) [22:19:59] Just contributing. :) [22:20:19] Oh, then I'd say wait. I didn't want to stretch the time of the code-in task if it dependent on it, but I have a feeling that my fix may correct a lot of those alignment issues [22:20:20] Normally I'd tell you to download her patch and see if it fixes it, but if you don't have a working local install that'll be difficult [22:20:49] (03PS1) 10Catrope: Set opacity:0.8; on the buttons in the footer of the notification popup too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264877 (https://phabricator.wikimedia.org/T119378) [22:21:48] (03PS6) 10Mooeypoo: [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [22:23:04] (03CR) 10Mooeypoo: [C: 04-1] Set opacity:0.8; on the buttons in the footer of the notification popup too (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264877 (https://phabricator.wikimedia.org/T119378) (owner: 10Catrope) [22:25:05] (03CR) 10jenkins-bot: [V: 04-1] [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [22:25:07] RoanKattouw, MtDu_ looking back at my patch, it only does the table layout for the *bundles* (mostly because the other notifications were much more complicated and dynamic to redo as table layouts) -- so the fix should still be necessary [22:26:13] RoanKattouw, meh, why is this passing qunit locally for me but not on jenkins? https://gerrit.wikimedia.org/r/#/c/264766/ I can't figure out the failure [22:26:44] except for having tons of "FAILURE" notes that seem very vague [22:27:26] (03PS1) 10MtDu: Call UserMailer::send() correctly [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/264879 [22:27:52] ... got it. [22:28:26] (03PS2) 10Catrope: Set opacity:0.8; on the buttons in the footer of the notification popup too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264877 (https://phabricator.wikimedia.org/T119378) [22:28:29] (03PS7) 10Mooeypoo: [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [22:29:10] (03CR) 10Catrope: Set opacity:0.8; on the buttons in the footer of the notification popup too (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264877 (https://phabricator.wikimedia.org/T119378) (owner: 10Catrope) [22:29:22] (03PS2) 10MtDu: Call UserMailer::send() correctly [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/264879 (https://phabricator.wikimedia.org/T123979) [22:30:05] (03CR) 10Mooeypoo: [C: 032] Set opacity:0.8; on the buttons in the footer of the notification popup too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264877 (https://phabricator.wikimedia.org/T119378) (owner: 10Catrope) [22:30:08] 3Collaboration-Team-Current, 10Collaboration-Community-Engagement, 10WMF-Product-Development-Process, 3Liaisons-January-2016, 7user-notice: Cross-wiki notifications - announcements planning - https://phabricator.wikimedia.org/T123570#1942342 (10Billinghurst) @Trizek-WMF @quiddity There is an announcemen... [22:30:55] egh, qunit failed again. [22:31:23] (03CR) 10jenkins-bot: [V: 04-1] [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [22:31:27] yesyes [22:33:17] (03Merged) 10jenkins-bot: Set opacity:0.8; on the buttons in the footer of the notification popup too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264877 (https://phabricator.wikimedia.org/T119378) (owner: 10Catrope) [22:33:21] (03PS1) 10Catrope: Reorganize NotificationBadgeWidget.less [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264880 [22:35:36] 6Collaboration-Team-Backlog, 10Notifcations: Styling adjustments for the Notification Panel - https://phabricator.wikimedia.org/T119374#1942353 (10Catrope) [22:35:37] 6Collaboration-Team-Backlog, 10Notifcations, 7Easy, 5Patch-For-Review: Avoid pure black icons in the Notification Panel - https://phabricator.wikimedia.org/T119378#1942352 (10Catrope) 5Open>3Resolved [22:40:14] (03PS8) 10Mooeypoo: [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [22:42:37] (03CR) 10jenkins-bot: [V: 04-1] [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 (owner: 10Mooeypoo) [22:43:18] meh [22:46:43] (03PS9) 10Mooeypoo: [wip] Echo API layer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264766 [22:50:50] mooeypoo: So your table layout patch looks great, the only thing is, I'm not that enthused about us having different HTML structures and different CSS for bundles vs not [22:51:00] Did you consider making normal notifs table layouts as well? [22:51:20] And then maybe the differences in HTML structure and CSS between notifications inside bundles vs outside would be much smaller? [22:51:31] Yeah I wasn't entirely happy about this, but the way that the normal notifications are made, the table layout became really messy [22:51:52] Oh, because there's stuff below? [22:51:54] It would've been a nested layout, because you would need 2 columns for icon|the-rest [22:52:07] and then "the-rest" would have to be in its own table layout with 2 rows [22:52:09] Right [22:52:09] The icon has colspan=2 [22:52:11] or more [22:52:13] *rowspan [22:52:19] Yeah, OK [22:52:22] yes, but you can't do rowspan in css [22:53:19] Hm. It's probably possible to redo it as table layout... just requires maybe a bit more thinking. It was messy enough to make me want to only deal with the separation, but we should probably have a TODO comment in there to unify the styles? [22:53:27] Yeah, I meant conceptually [22:53:45] Yeah, that means that the styles became nested weirdly, though [22:54:01] Yeah I guess you still need pretty different styles [22:54:03] because you need a wrapper for the table, then 2 columns, which one of them needs to be a table of its own (so you need another internal wrapper) [22:54:20] and then you need to "undo that" for the bundles because they look different [22:54:45] it was messy enough that I figured I'd deal with bundles-only, but yeah we should rethink the structure. The fact that it *is* messy to do might hint that the structure may not be as good as it should be [22:55:18] Though the main issues are the fact that in non-bundles, the [...] menu and actions are below the content and in a different *cell* than the X and the timestamp [22:55:40] Yeah, no, you're right, they're very different [22:55:45] (and that cell is nested inside another table layout, because it needs to be 2 rows... [22:55:47] anyhoo, yeah [22:55:56] Different enough that it's gonna be messy no matter what [22:56:23] It might be good to redo the structure at some point to make it less potentially-messy, but it will probably end up being a bit of work + messy anyways [23:01:07] (03CR) 10Reedy: [C: 04-1] Call UserMailer::send() correctly (031 comment) [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/264879 (https://phabricator.wikimedia.org/T123979) (owner: 10MtDu) [23:01:50] (03PS1) 10Catrope: ActionMenuPopupWidget: Close correctly when button is clicked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264890 (https://phabricator.wikimedia.org/T123754) [23:02:03] 3Collaboration-Team-Current, 10Notifcations, 5Patch-For-Review: The action menu ("...") for bundled notifications cannot be closed by clicking on it again - https://phabricator.wikimedia.org/T123754#1942440 (10Catrope) [23:02:34] mooeypoo: Can haz review? ---^^ [23:02:48] 3Collaboration-Team-Current, 10Notifcations, 5Patch-For-Review: The action menu ("...") for bundled notifications cannot be closed by clicking on it again - https://phabricator.wikimedia.org/T123754#1942444 (10Catrope) a:3Catrope [23:04:08] ... really? that's it? [23:04:20] OOUI already has a facility for it [23:04:44] (03PS3) 10MtDu: Call UserMailer::send() correctly [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/264879 (https://phabricator.wikimedia.org/T123979) [23:04:45] It just isn't called what I thought it was because I was thinking of the equivalent thing in PopupWidget which is called something else (autoCloseIgnore) [23:05:29] (03CR) 10Catrope: [C: 032] "In the future, we should try to reduce the difference between the HTML+CSS for inside bundles vs outside; however, because they look prett" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260689 (https://phabricator.wikimedia.org/T121933) (owner: 10Mooeypoo) [23:07:07] (03PS1) 10Mooeypoo: Hide 'mark as read' for foreign NotificationGroupItem bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264893 (https://phabricator.wikimedia.org/T121930) [23:07:13] RoanKattouw, I'll exchange my review for yours on this ^^ [23:07:17] (03PS3) 10Catrope: Organize items in bundles with CSS table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260689 (https://phabricator.wikimedia.org/T121933) (owner: 10Mooeypoo) [23:07:27] (03CR) 10Catrope: [C: 032] Organize items in bundles with CSS table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260689 (https://phabricator.wikimedia.org/T121933) (owner: 10Mooeypoo) [23:07:42] (03CR) 10jenkins-bot: [V: 04-1] Organize items in bundles with CSS table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260689 (https://phabricator.wikimedia.org/T121933) (owner: 10Mooeypoo) [23:07:48] RoanKattouw, can we (should we?) add a phab ticket for unifying the bundle design? We should at least have it for when we decide we want to do it [23:07:54] ... why is that failing [23:07:56] RoanKattouw: Fixed: https://phabricator.wikimedia.org/tag/notifications/ [23:08:04] Thanks [23:08:38] mooeypoo: The commit message seems to conflate individual mark as read with "mark all [as] read" [23:08:44] (03CR) 10jenkins-bot: [V: 04-1] Organize items in bundles with CSS table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260689 (https://phabricator.wikimedia.org/T121933) (owner: 10Mooeypoo) [23:08:57] RoanKattouw, meh, I have no notifications with ... menu to test. It looks good, I assume you tested? I'll +2 [23:08:57] Oh nm [23:08:59] No I see [23:09:02] it's touching groupitem [23:09:08] mooeypoo: Yeah I did [23:09:37] RoanKattouw, it's "mark as read" for the *group* which basically marks the entire bundle as read, and has potential conflicting behaviors and, imho, shouldn't be an option [23:09:49] but we decided to test without it and maybe re-add it in the future [23:09:59] (03CR) 10Reedy: [C: 032] Call UserMailer::send() correctly [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/264879 (https://phabricator.wikimedia.org/T123979) (owner: 10MtDu) [23:10:14] (03CR) 10Mooeypoo: [C: 032] ActionMenuPopupWidget: Close correctly when button is clicked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264890 (https://phabricator.wikimedia.org/T123754) (owner: 10Catrope) [23:10:34] (03Merged) 10jenkins-bot: Call UserMailer::send() correctly [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/264879 (https://phabricator.wikimedia.org/T123979) (owner: 10MtDu) [23:11:01] Yeah, sorry, I got confused, I see what it's doing now [23:11:20] (03CR) 10Catrope: [C: 032] Hide 'mark as read' for foreign NotificationGroupItem bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264893 (https://phabricator.wikimedia.org/T121930) (owner: 10Mooeypoo) [23:12:12] 6Collaboration-Team-Backlog, 10Notifications, 7Epic: Echo for anonymous users - https://phabricator.wikimedia.org/T58828#1942470 (10Jdforrester-WMF) [23:12:30] crap... crap... RoanKattouw can you stop the merge? [23:12:35] I found an idiotic mistake [23:12:44] donie [23:12:46] What? [23:13:34] (03Merged) 10jenkins-bot: ActionMenuPopupWidget: Close correctly when button is clicked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264890 (https://phabricator.wikimedia.org/T123754) (owner: 10Catrope) [23:14:16] the markAsRead button toggles "itself" also when the notification is read/unread [23:14:21] I have to add those conditions in there too [23:14:44] aha [23:15:13] 3Collaboration-Team-Current, 10Flow, 10Notifications, 5Patch-For-Review: blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1942479 (10Catrope) >>! In T123656#1942132, @Catrope wrote: > @PGiner-WMF: The patch at https://gerrit.wikimedia.org/r/264564 looks good to me, but it re... [23:16:05] RoanKattouw, and I can't automatically show it if it's not a foreign bundle, in case it's already read... in short, I'm fixing it up a bit [23:17:03] (03PS2) 10Mooeypoo: Hide 'mark as read' for foreign NotificationGroupItem bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264893 (https://phabricator.wikimedia.org/T121930) [23:17:05] RoanKattouw, ^^ [23:17:12] Sorry about that [23:17:16] 3Collaboration-Team-Current, 10Flow, 10Notifications, 5Patch-For-Review: blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1942488 (10Catrope) >>! In T123656#1942479, @Catrope wrote: >>>! In T123656#1942132, @Catrope wrote: >> @PGiner-WMF: The patch at https://gerrit.wikimedi... [23:17:41] (03CR) 10Catrope: [C: 032] Hide 'mark as read' for foreign NotificationGroupItem bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264893 (https://phabricator.wikimedia.org/T121930) (owner: 10Mooeypoo) [23:18:02] (03PS3) 10Mooeypoo: Hide 'mark as read' for foreign NotificationGroupItem bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264893 (https://phabricator.wikimedia.org/T121930) [23:18:09] oh ffs, you're faster. [23:18:50] oh, lol [23:18:52] RoanKattouw, sorry, you trust me way too much with this commit. I made another booboo. I'm going to take a breather and THEN do this again. [23:18:54] (03CR) 10Catrope: [C: 032] Hide 'mark as read' for foreign NotificationGroupItem bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264893 (https://phabricator.wikimedia.org/T121930) (owner: 10Mooeypoo) [23:19:02] yeah, this one should be fine [23:19:04] ... I think [23:19:07] gods [23:19:35] Brainfart moment that extended to 3 moments. [23:23:22] (03Merged) 10jenkins-bot: Hide 'mark as read' for foreign NotificationGroupItem bundles [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264893 (https://phabricator.wikimedia.org/T121930) (owner: 10Mooeypoo) [23:29:04] (03CR) 10Catrope: [C: 04-1] Adjust layout for new notification panel designs (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263805 (https://phabricator.wikimedia.org/T122646) (owner: 10MtDu) [23:31:39] mooeypoo: Why does GroupItemWidget have a margin-left of 0.5em on its icon? [23:33:04] Oh, I see [23:33:10] Normal items have a padding-left of 0.5em [23:35:33] Oh, and this layout was already broken [23:35:35] * RoanKattouw fixes [23:37:20] (03PS1) 10Catrope: Follow-up 27092b7ae: add missing .prototype [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264897 [23:37:24] oh [23:37:25] hm [23:37:28] mooeypoo: Brainfart #4 ---^^ [23:37:39] ... omg [23:37:44] ... wow [23:37:48] But that's not what I was talking about, I was talking about the misalignment of the text in group items [23:37:55] Which looked worse with Justin's patch, but was already there [23:38:08] So I'll fix that next [23:38:14] Well, the icon was smaller, so the alignment, iirc, was also smaller [23:38:32] (the font isn't smaller, so the em doesn't automatically adjusts) [23:38:36] -s [23:38:51] (03CR) 10Mooeypoo: [C: 032] "Oy vey." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264897 (owner: 10Catrope) [23:39:22] Sorry, I mean in the main content of group itmes [23:39:25] Not the nested notifs [23:40:06] What seems to be happening is GroupItem zeroes out the padding from Item because it doesn't want the expanded stuff to be indented [23:40:21] But then it indents it anyway [23:40:24] I'm gonna try to clean this up [23:40:28] Because it's causing issues [23:41:55] (03Merged) 10jenkins-bot: Follow-up 27092b7ae: add missing .prototype [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264897 (owner: 10Catrope) [23:43:54] (03CR) 10Mooeypoo: Adjust layout for new notification panel designs (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263805 (https://phabricator.wikimedia.org/T122646) (owner: 10MtDu) [23:43:58] OK never mind that'll make a mess [23:44:02] RoanKattouw, where is that repeated 0.8em coming from? [23:44:20] we keep repeating it in the less fixes -- should it be a variable in that case? I'm not sure where it's coming from? [23:44:40] I don't know, Pau asked for it [23:44:45] It doesn't always mean the same in every case [23:44:49] For margins? [23:44:50] oh [23:44:50] But yes some of that should be a variable [23:44:55] * mooeypoo nods [23:45:06] The padding around the items for example should be avar [23:45:06] *a var [23:45:08] That damn difference between math and reality [23:45:09] ;) [23:45:14] Not Ævar :D [23:45:33] yes, we don't want it to explode and strand our dev team in Europe [23:47:14] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Update and retest the convertToText script - https://phabricator.wikimedia.org/T90075#1942630 (10Quiddity) Re: `:` vs `*` - I think the `:` indents are slightly clearer overall, particularly for multiline posts. Please also switch the signature used: *... [23:51:15] (03PS1) 10Catrope: Fix content text alignment in GroupItemWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264899 [23:55:50] (03PS1) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 [23:57:30] (03CR) 10jenkins-bot: [V: 04-1] Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900 (owner: 10Jforrester) [23:58:23] (03PS2) 10Jforrester: Introduce congratulatory notifications for reaching edit thresholds [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264900