[01:46:12] (03CR) 10Jforrester: [C: 031] Use globe icon for cross-wiki bundle [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264394 (https://phabricator.wikimedia.org/T123757) (owner: 10Catrope) [02:49:04] 6Collaboration-Team-Backlog, 10Flow, 7Design, 7Easy: Flow: Topic history page doesn't reflect action in h1 heading or tag - https://phabricator.wikimedia.org/T72472#1939446 (10dg711) HI , which repo should I browse the code exactly in. I've installed and run mediawiki on my local machine both manua... [03:43:06] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Update and retest the convertToText script - https://phabricator.wikimedia.org/T90075#1939454 (10matthiasmullie) That can be done. I've updated my earlier comment to reflect what the source would look like with asterisks instead of `:`. Who can confirm... [03:43:19] <grrrit-wm> (03PS5) 10Matthias Mullie: Fix convertToText.php & let it query remote APIs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/264249 (https://phabricator.wikimedia.org/T90075) [03:45:28] <grrrit-wm> (03CR) 10Matthias Mullie: Fix convertToText.php & let it query remote APIs (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/264249 (https://phabricator.wikimedia.org/T90075) (owner: 10Matthias Mullie) [04:10:19] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 7Design, 7Easy: Flow: Topic history page doesn't reflect action in h1 heading or <title> tag - https://phabricator.wikimedia.org/T72472#1939476 (10Sn1per) This is a #Flow task, so you would need to enable the 'flow' vagrant role. Once you do that and then `vagrant provi... [05:37:18] <wikibugs> 3Collaboration-Team-Current, 10Echo, 10Flow: blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1939524 (10MtDu) a:3MtDu I'll take care of this quickly. [05:52:47] <grrrit-wm> (03PS1) 10MtDu: Don't blur talk icon echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264564 (https://phabricator.wikimedia.org/T123656) [05:55:20] <wikibugs> 3Collaboration-Team-Current, 10Echo, 10Flow, 5Patch-For-Review: blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1939535 (10MtDu) >>! In T123656#1935831, @Pginer-WMF wrote: > There is also a broader issue about the computing of ems to pixels, which is affected by the element... [05:57:01] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Don't blur talk icon echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264564 (https://phabricator.wikimedia.org/T123656) (owner: 10MtDu) [05:59:14] <wikibugs> 3Collaboration-Team-Current, 10Echo, 10Flow, 5Patch-For-Review: blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1939536 (10eranroz) MtDu - thank you for the quick fix. It is no-doubt better than the current status. However I think this creates a bit too large padding so we... [06:50:47] <wikibugs> 6Collaboration-Team-Backlog, 10Echo, 7I18n: The notifications drop down menu displays numbers using the wrong numeral system on Arabic Wikipedia (arwiki) - https://phabricator.wikimedia.org/T123845#1939547 (10Meno25) [07:35:03] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Update and retest the convertToText script - https://phabricator.wikimedia.org/T90075#1939558 (10Alsee) I agree * enhances readability. Something appears to have gone astray at a few spots though, for example the comment at 06:26, 30 November 2015. A si... [07:44:57] <wikibugs> 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests: Remove Flow from Wikipedia talk:WikiProject Breakfast on enwp - https://phabricator.wikimedia.org/T122961#1939560 (10Alsee) @Quiddity, could you clarify the "detailed attribution" issue? Ideally the conversion would use a series of synthetic ed... [11:10:31] <wikibugs> 3Collaboration-Team-Current, 10Echo: Read E-Mail and Welcome notifcations aren't displayed correctly - https://phabricator.wikimedia.org/T123756#1939638 (10MGChecker) [11:36:22] <wikibugs> 3Collaboration-Team-Current, 10Echo: Read E-Mail and Welcome notifcations aren't displayed correctly - https://phabricator.wikimedia.org/T123756#1939653 (10MGChecker) For Welcome notifcations it's the same. [13:05:06] <grrrit-wm> (03CR) 10MtDu: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264564 (https://phabricator.wikimedia.org/T123656) (owner: 10MtDu) [13:21:38] <wikibugs> 3Collaboration-Team-Current, 10Echo, 10Flow, 5Patch-For-Review: blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1939723 (10MtDu) @eranroz, I don't see a padding right of 3.5 em. Do you mean the padding left in the file mw.echo.ui.NotificationItemWidget.less? Thanks, MtDu [13:25:27] <wikibugs> 3Collaboration-Team-Current, 10Echo, 10Flow, 5Patch-For-Review: blurred talk icon echo notifications - https://phabricator.wikimedia.org/T123656#1939725 (10MtDu) @eranroz, It seems like it is padding-left, according to Pginer's comment above. Will push a patch with that. Thanks for the reminder! MtDu [13:26:02] <grrrit-wm> (03PS2) 10MtDu: Don't blur talk icon echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264564 (https://phabricator.wikimedia.org/T123656) [13:27:24] <wikibugs> 6Collaboration-Team-Backlog, 10Echo, 7Easy: Deprecated: Use of UserMailer::send with $replyto as 5th parameter was deprecated in MediaWiki 1.26. [Called from MWEchoEmailBatch::sendEmail in extensions/Echo/includes/EmailBatch.php at line 287] - https://phabricator.wikimedia.org/T123641#1939727 (10MtDu) a:3Mt... [13:32:40] <grrrit-wm> (03PS1) 10MtDu: Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) [13:35:27] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [13:41:24] <grrrit-wm> (03CR) 10PranavK: Deprecated use of 5th parameter in UserMailer::send (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [13:50:31] <grrrit-wm> (03CR) 10MtDu: Deprecated use of 5th parameter in UserMailer::send (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [13:50:36] <grrrit-wm> (03PS2) 10MtDu: Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) [13:55:17] <grrrit-wm> (03CR) 10Eranroz: [C: 04-1] Don't blur talk icon echo notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264564 (https://phabricator.wikimedia.org/T123656) (owner: 10MtDu) [14:24:05] <grrrit-wm> (03PS3) 10MtDu: Don't blur talk icon echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264564 (https://phabricator.wikimedia.org/T123656) [15:51:42] <wikibugs> 6Collaboration-Team-Backlog, 10Echo: Notify users about deletion tags being added to pages they created - https://phabricator.wikimedia.org/T123866#1939819 (10OdMishehu) 3NEW [15:56:15] <wikibugs> 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-PageCuration: Notify users about deletion tags being added to pages they created - https://phabricator.wikimedia.org/T123866#1939828 (10Luke081515) [20:50:21] <grrrit-wm> (03CR) 10Alex Monk: [C: 04-1] "Instead of completely getting rid of the parameter, you need to pass an options array into UserMailer::send instead, containing this exist" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [20:57:51] <grrrit-wm> (03PS3) 10MtDu: Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) [21:01:36] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [21:03:01] <grrrit-wm> (03PS22) 10Paladox: Update grunt-jscs to 2.5.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 [21:03:50] <grrrit-wm> (03PS4) 10MtDu: Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) [21:03:58] <grrrit-wm> (03PS23) 10Paladox: Update grunt-jscs to 2.5.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 [21:08:57] <grrrit-wm> (03PS24) 10Paladox: Update grunt-jscs to 2.6.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 [21:09:01] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Update grunt-jscs to 2.6.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 (owner: 10Paladox) [21:11:28] <grrrit-wm> (03PS1) 10Paladox: Update grunt-contrib-jshint to 0.12.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264622 [21:12:51] <grrrit-wm> (03PS1) 10Paladox: Remove grunt-contrib-csslint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264623 [21:17:20] <grrrit-wm> (03CR) 10Alex Monk: [C: 04-1] Deprecated use of 5th parameter in UserMailer::send (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [21:29:49] <grrrit-wm> (03CR) 10MtDu: "Whoops. Sorry. I'll fix it in a few minutes." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [22:00:43] <grrrit-wm> (03PS5) 10MtDu: Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) [22:03:29] <wikibugs> 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: OOUI widgets for new notification design - https://phabricator.wikimedia.org/T115419#1940186 (10matmarex) T123810 has been resolved now, which should change the icon inside the popup. The icon on the personal bar comes from the Vector skin (last modifi... [22:12:41] <grrrit-wm> (03CR) 10Alex Monk: [C: 04-1] "See previous patch set" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [22:16:24] <grrrit-wm> (03PS6) 10MtDu: Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) [22:17:03] <grrrit-wm> (03CR) 10MtDu: "@Alex Monk," [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [22:20:22] <grrrit-wm> (03CR) 10Alex Monk: [C: 04-1] "This is still not right, per PS4 comment. I'm not sure how much help I should give you, but to be honest you should also test this to see " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [22:31:09] <grrrit-wm> (03PS7) 10MtDu: Deprecated use of 5th parameter in UserMailer::send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) [22:32:16] <grrrit-wm> (03CR) 10MtDu: "If it's not right, I'll try again, but please do not give it away. I want to figure it out myself." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu) [22:34:23] <grrrit-wm> (03CR) 10Reedy: "https://github.com/wikimedia/mediawiki/blob/master/includes/mail/UserMailer.php#L95-L117" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/264588 (https://phabricator.wikimedia.org/T123641) (owner: 10MtDu)