[00:01:41] 3Collaboration-Team-Current, 10Echo: [betalabs] No notification of Mention event - https://phabricator.wikimedia.org/T123320#1926194 (10Etonkovidova) 3NEW [00:08:35] 3Collaboration-Team-Current, 10Flow: Update and retest the convertToText script - https://phabricator.wikimedia.org/T90075#1926269 (10Mattflaschen) p:5Low>3High [00:12:44] 3Collaboration-Team-Current, 10Flow: "Undefined is not a valid UUID" in Flow - https://phabricator.wikimedia.org/T123264#1926307 (10Mattflaschen) [00:13:45] 3Collaboration-Team-Current, 10Flow: "Undefined is not a valid UUID" in Flow - https://phabricator.wikimedia.org/T123264#1924854 (10Mattflaschen) [00:15:50] (03CR) 10Catrope: [C: 04-1] Log cross-wiki & bundle items impressions and add their source wiki (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260776 (https://phabricator.wikimedia.org/T120158) (owner: 10Mooeypoo) [00:15:55] 3Collaboration-Team-Current, 10Echo, 10Collaboration-Community-Engagement, 5Patch-For-Review, 7user-notice: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#1926330 (10Trizek-WMF) [00:16:13] 6Collaboration-Team-Backlog, 10Flow, 7Easy, 7I18n, 5Patch-For-Review: the flow-rev-message-locked-topic-irc message must be documented or removed - https://phabricator.wikimedia.org/T101941#1926331 (10Mattflaschen) 5Open>3Resolved [00:24:43] 6Collaboration-Team-Backlog, 10Echo: Offer choice about where a new topic notification should be displayed (watchlist or notification) - https://phabricator.wikimedia.org/T123298#1926365 (10Mattflaschen) [00:33:02] Can someone review https://gerrit.wikimedia.org/r/263554 ? You can test it in isolation by just running the command after vagrant ssh-ing. It will unblock pginer. [00:38:25] (03PS2) 10Mooeypoo: Log cross-wiki & bundle items impressions and add their source wiki [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260776 (https://phabricator.wikimedia.org/T120158) [00:38:30] RoanKattouw, ^^ [00:43:29] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Special-pages: Flow posts are not fully integrated with namespace filter on Special:Contributions - https://phabricator.wikimedia.org/T123336#1926483 (10Scott) 3NEW [00:48:06] (03CR) 10Mooeypoo: Mark bundles as read except when it is automatic (035 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261290 (https://phabricator.wikimedia.org/T121930) (owner: 10Mooeypoo) [00:48:26] (03PS3) 10Mooeypoo: Mark bundles as read except when it is automatic [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261290 (https://phabricator.wikimedia.org/T121930) [00:49:20] (03CR) 10Pginer: [C: 031] "This is definitely an improvement." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261188 (https://phabricator.wikimedia.org/T119375) (owner: 10Mhutti1) [00:51:40] 3Collaboration-Team-Current, 10Flow: Rephrase Flow notifications, move content from body into header - https://phabricator.wikimedia.org/T121950#1926542 (10SBisson) [00:52:09] (03PS13) 10Matthias Mullie: Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) (owner: 10Catrope) [00:59:30] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a page describing Flow interface - https://phabricator.wikimedia.org/T117192#1926554 (10Trizek-WMF) 5Open>3Resolved Not a page but an addition [[ https://www.mediawiki.org/wiki/Help:Flow/Quick_tour | to the Quick Tour page ]]. [00:59:31] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 6Community-Liaison, and 2 others: [Tracking] Create a general public documentation for Flow - https://phabricator.wikimedia.org/T111367#1926556 (10Trizek-WMF) [01:01:06] (03PS14) 10Matthias Mullie: Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) (owner: 10Catrope) [01:03:13] (03CR) 10Pginer: "A couple of comments:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/262886 (https://phabricator.wikimedia.org/T119378) (owner: 10Haritha28) [01:11:51] 6Collaboration-Team-Backlog, 10Echo: Special:Notifications not showing "More..." at bottom at some wikis - https://phabricator.wikimedia.org/T123338#1926579 (10Quiddity) 3NEW [01:12:47] (03PS3) 10Catrope: Log cross-wiki & bundle items impressions and add their source wiki [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260776 (https://phabricator.wikimedia.org/T120158) (owner: 10Mooeypoo) [01:13:48] (03CR) 10Catrope: [C: 032] "There's an issue with all notif impressions being logged twice, but that can be fixed separately." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260776 (https://phabricator.wikimedia.org/T120158) (owner: 10Mooeypoo) [01:14:31] mooeypoo: https://gerrit.wikimedia.org/r/#/c/261290/2..3/modules/viewmodel/mw.echo.dm.NotificationGroupItem.js [01:15:46] (03CR) 10Catrope: [C: 04-1] Mark bundles as read except when it is automatic [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261290 (https://phabricator.wikimedia.org/T121930) (owner: 10Mooeypoo) [01:15:50] 3Collaboration-Team-Current, 10Echo: [betalabs] No notification of Mention event - https://phabricator.wikimedia.org/T123320#1926599 (10Mattflaschen) @Etonkovidova You said this notification did eventually arrive? [01:15:58] (03CR) 10Catrope: Mark bundles as read except when it is automatic (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261290 (https://phabricator.wikimedia.org/T121930) (owner: 10Mooeypoo) [01:16:23] (03PS4) 10Mooeypoo: Mark bundles as read except when it is automatic [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261290 (https://phabricator.wikimedia.org/T121930) [01:17:09] (03CR) 10Catrope: Avoid pure black icons in Notification Panel (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/262886 (https://phabricator.wikimedia.org/T119378) (owner: 10Haritha28) [01:17:25] 6Collaboration-Team-Backlog, 10Echo: Special:Notifications not showing "More..." at bottom at some wikis, erratically - https://phabricator.wikimedia.org/T123338#1926605 (10Quiddity) [01:18:06] (03CR) 10Catrope: [C: 032] "Pau, could you file a separate bug about that?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261188 (https://phabricator.wikimedia.org/T119375) (owner: 10Mhutti1) [01:19:23] (03Merged) 10jenkins-bot: Log cross-wiki & bundle items impressions and add their source wiki [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260776 (https://phabricator.wikimedia.org/T120158) (owner: 10Mooeypoo) [01:21:48] (03Merged) 10jenkins-bot: Resized notification panel footer to be the same size as header [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261188 (https://phabricator.wikimedia.org/T119375) (owner: 10Mhutti1) [01:40:19] 6Collaboration-Team-Backlog, 10Echo, 7Easy: [[MediaWiki:Flow-error-parsoid-failure/en]] "internet" should be spelled "Internet" - https://phabricator.wikimedia.org/T123203#1926715 (10MtDu) a:3MtDu I'll go ahead and fix this typo as well. I've pushed some other patches fixing these types of issues. It would... [01:48:18] (03CR) 10Catrope: Mark bundles as read except when it is automatic (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261290 (https://phabricator.wikimedia.org/T121930) (owner: 10Mooeypoo) [01:50:04] (03PS1) 10MtDu: Capitalize 'internet' in error-parsoid-failure message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263568 (https://phabricator.wikimedia.org/T123203) [01:54:45] (03CR) 10Catrope: [C: 04-1] Cross-wiki notifications integration (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) (owner: 10Catrope) [02:03:58] (03PS15) 10Matthias Mullie: Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) (owner: 10Catrope) [02:06:18] (03CR) 10jenkins-bot: [V: 04-1] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) (owner: 10Catrope) [02:15:16] (03CR) 10Catrope: [C: 04-1] "Looks great, two minor things" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) (owner: 10Catrope) [02:18:52] (03CR) 10Catrope: Cross-wiki notifications integration (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) (owner: 10Catrope) [02:23:28] (03CR) 10Catrope: [C: 04-1] Don't hardcode English parentheses in one message (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [02:37:57] (03PS2) 10Catrope: Bring back edit-title to no-js mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260077 (owner: 10Sbisson) [02:38:31] (03CR) 10Liangent: "IoannisKydonis, I suggest you actually run the code before submitting." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [02:39:48] (03CR) 10Catrope: [C: 04-1] "Looks great, minor comments inline." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [02:40:06] (03CR) 10Catrope: [C: 032] Bring back edit-title to no-js mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260077 (owner: 10Sbisson) [03:17:25] (03CR) 10Mattflaschen: "It isn't enough to just remove it from addModuleStyles. That will prevent it from being served to no-JS users, but we also need to make s" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263212 (https://phabricator.wikimedia.org/T97467) (owner: 10MtDu) [03:29:51] (03CR) 10MtDu: "Could you elaborate more on the solution and how to implement it? I'm trying to learn as I go. Thanks!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263212 (https://phabricator.wikimedia.org/T97467) (owner: 10MtDu) [04:03:06] (03CR) 10Mattflaschen: "I need to check with the team first." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263212 (https://phabricator.wikimedia.org/T97467) (owner: 10MtDu) [05:45:30] (03PS9) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) [06:11:33] 6Collaboration-Team-Backlog, 10Flow: Explore ideas for workflow support - https://phabricator.wikimedia.org/T103082#1926990 (10Alsee) > Wittylama wrote: Simply stating that "we" want, or don't want, something is overstating your case I clearly began by saying //I believe...// about what the Community would wa... [12:11:52] (03PS2) 10Haritha28: Avoid pure black icons in Notification Panel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/262886 (https://phabricator.wikimedia.org/T119378) [12:29:00] 3Collaboration-Team-Current, 10Echo: Make "mark as read" an explicit action on Special:Notifications - https://phabricator.wikimedia.org/T115528#1927348 (10Devirk) [12:37:50] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests: Remove Flow from Wikipedia talk:WikiProject Breakfast on enwp - https://phabricator.wikimedia.org/T122961#1927357 (10Alsee) The close was challenged, reviewed, and confirmed as correct: https://en.wikipedia.org/w/index.php?title=Wikipedia%3AAdmi... [13:30:00] (03PS10) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) [17:00:48] (03CR) 10Sbisson: Various fixes to edit-title (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [17:21:45] (03PS5) 10Sbisson: Various fixes to edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) [17:26:31] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#1927759 (10Trizek-WMF) [17:26:41] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#1927760 (10Trizek-WMF) p:5Normal>3High [17:26:51] 6Collaboration-Team-Backlog, 10Flow, 10Collaboration-Community-Engagement, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#1645088 (10Trizek-WMF) [17:28:37] 6Collaboration-Team-Backlog, 10Echo, 10Collaboration-Community-Engagement, 7Documentation: Create documentation about new Beta Notification system - https://phabricator.wikimedia.org/T123380#1927763 (10Trizek-WMF) 3NEW a:3Trizek-WMF [17:28:51] 6Collaboration-Team-Backlog, 10Echo, 10Collaboration-Community-Engagement, 7Documentation: Create documentation about new Beta Notification system - https://phabricator.wikimedia.org/T123380#1927771 (10Trizek-WMF) [17:28:52] 6Collaboration-Team-Backlog, 10Echo, 10Collaboration-Community-Engagement, 6Community-Liaison, and 2 others: [Tracking] Update Help:Notifications - https://phabricator.wikimedia.org/T119713#1927770 (10Trizek-WMF) [17:29:29] 6Collaboration-Team-Backlog, 10Echo, 10Collaboration-Community-Engagement, 7Documentation: Create documentation about new Beta Notification system - https://phabricator.wikimedia.org/T123380#1927763 (10Trizek-WMF) [17:29:30] 6Collaboration-Team-Backlog, 10Echo, 10Collaboration-Community-Engagement: Create landing page for Echo Beta Feature information link - https://phabricator.wikimedia.org/T123307#1927775 (10Trizek-WMF) [17:52:39] (03CR) 10Sbisson: "I propose to get rid of the code that listens to onbeforeunload (mw-ui.enhance.js:452)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [17:53:12] (03PS6) 10Sbisson: Various fixes to edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) [17:57:56] (03PS16) 10Matthias Mullie: Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) (owner: 10Catrope) [17:59:01] (03CR) 10Matthias Mullie: Cross-wiki notifications integration (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) (owner: 10Catrope) [18:06:23] (03PS17) 10Matthias Mullie: Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) (owner: 10Catrope) [18:08:40] (03PS3) 10Sbisson: Bring back edit-title to no-js mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260077 [18:11:40] (03PS3) 10Sbisson: Update page-linked notification text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260631 (https://phabricator.wikimedia.org/T121812) [18:14:46] (03CR) 10Legoktm: [C: 032] Update page-linked notification text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260631 (https://phabricator.wikimedia.org/T121812) (owner: 10Sbisson) [18:15:53] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Instrument opening of cross-wiki notification GroupItems - https://phabricator.wikimedia.org/T121945#1927974 (10SBisson) a:3Mooeypoo [18:21:18] (03Merged) 10jenkins-bot: Update page-linked notification text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260631 (https://phabricator.wikimedia.org/T121812) (owner: 10Sbisson) [18:23:11] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Tweak page-linked notification - https://phabricator.wikimedia.org/T121812#1928034 (10Legoktm) 5Open>3Resolved [18:43:33] (03PS1) 10Legoktm: Add missing mw.Title depenency to ext.echo.ui [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263640 [18:43:48] mooeypoo / RoanKattouw: ^ [18:45:50] 3Collaboration-Team-Current, 10Echo: [betalabs] No notification of Mention event - https://phabricator.wikimedia.org/T123320#1928129 (10Etonkovidova) Re-checked in betalabs - Mention notifications come promptly. The automated tests all passed at: https://integration.wikimedia.org/ci/view/BrowserTests/view/Ec... [18:48:37] 6Collaboration-Team-Backlog, 10Echo: Secondary links without an icon are misaligned in MonoBook/apex - https://phabricator.wikimedia.org/T123388#1928154 (10Legoktm) 3NEW [18:51:43] 6Collaboration-Team-Backlog, 10Echo: Special:Notifications should show secondary link icons - https://phabricator.wikimedia.org/T123389#1928165 (10Legoktm) 3NEW [18:53:09] 3Collaboration-Team-Current, 10Echo: [betalabs] No notification of Mention event - https://phabricator.wikimedia.org/T123320#1928187 (10Etonkovidova) 5Open>3Resolved [18:54:17] 3Collaboration-Team-Current, 10Echo: Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#1928190 (10jmatazzoni) a:5Pginer-WMF>3None [18:59:35] 3Collaboration-Team-Current, 10Echo: Create new notification category for talk pages: flowusertalk - https://phabricator.wikimedia.org/T121663#1928205 (10jmatazzoni) [18:59:48] (03PS1) 10Catrope: Follow-up 8088e888: unbreak loading HTML into VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263642 [19:04:42] (03CR) 10Catrope: [C: 032] Add missing mw.Title depenency to ext.echo.ui [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263640 (owner: 10Legoktm) [19:05:01] legoktm: I'll trade you for that one ---^^ [19:05:32] (03CR) 10Legoktm: [C: 032] Follow-up 8088e888: unbreak loading HTML into VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263642 (owner: 10Catrope) [19:05:47] Thanks [19:05:58] I'll cherry-pick both once they merge [19:13:05] (03Merged) 10jenkins-bot: Add missing mw.Title depenency to ext.echo.ui [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263640 (owner: 10Legoktm) [19:13:08] (03Merged) 10jenkins-bot: Follow-up 8088e888: unbreak loading HTML into VE [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263642 (owner: 10Catrope) [19:15:26] (03PS1) 10Catrope: Follow-up 8088e888: unbreak loading HTML into VE [extensions/Flow] (wmf/1.27.0-wmf.10) - 10https://gerrit.wikimedia.org/r/263644 [19:15:33] (03PS1) 10Catrope: Add missing mw.Title depenency to ext.echo.ui [extensions/Echo] (wmf/1.27.0-wmf.10) - 10https://gerrit.wikimedia.org/r/263645 [19:17:31] (03CR) 10Catrope: [C: 032] Various fixes to edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [19:20:15] 3Collaboration-Team-Current, 10Echo: Create new notification category for talk pages: flowusertalk - https://phabricator.wikimedia.org/T121663#1928324 (10jmatazzoni) Added an item to the spec above to clarify functionality of flowusertalk-post-edited: **flowusertalk-post-edited** Unlike flow-post-edited, whi... [19:22:36] (03Merged) 10jenkins-bot: Various fixes to edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [19:22:41] (03Merged) 10jenkins-bot: Bring back edit-title to no-js mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260077 (owner: 10Sbisson) [19:37:51] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about preloading contents on a new Flow topic - https://phabricator.wikimedia.org/T113583#1928565 (10Trizek-WMF) 5stalled>3Resolved Resolved for the moment. Will be updated when Templates preloading will be fixed. [19:37:52] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a page about (more) advanced Flow features - https://phabricator.wikimedia.org/T111529#1928567 (10Trizek-WMF) [20:01:05] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about preloading contents on a new Flow topic - https://phabricator.wikimedia.org/T113583#1928984 (10Aklapper) @Trizek-WMF: Where/how to see that help page? Any link to share? Also, the //Blocked By// task here is still open so maybe th... [20:18:37] 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI, 10UI-Standardization, 7WorkType-Maintenance: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1929071 (10Jdforrester-WMF) [20:23:17] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Flow VE: Link inspector displays 'Edit' and 'delete'(oo-ui-buttonElement-framed) in different sizes - https://phabricator.wikimedia.org/T121987#1929096 (10Jdforrester-WMF) [21:15:47] (03CR) 10Hoo man: [C: 04-1] "Some minor things, but looks good in general :)" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [21:19:38] (03PS11) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) [21:21:41] (03PS12) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) [21:34:39] 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI, 10UI-Standardization, 7WorkType-Maintenance: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1929404 (10Pginer-WMF) @violetto created an updated version of the icon: {F3221371} {F3221389,size=full} [21:47:16] (03PS1) 10Matthias Mullie: Make links follow the expected format [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/263726 [21:51:25] (03CR) 10Legoktm: [C: 032] Make links follow the expected format [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/263726 (owner: 10Matthias Mullie) [21:51:32] (03PS1) 10Matthias Mullie: Be more clear about what data types we expect in links array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263737 [21:55:28] (03PS1) 10Matthias Mullie: Get link of LinkNormalizer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263739 [21:55:36] (03Merged) 10jenkins-bot: Make links follow the expected format [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/263726 (owner: 10Matthias Mullie) [21:56:37] (03CR) 10Legoktm: [C: 032] Be more clear about what data types we expect in links array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263737 (owner: 10Matthias Mullie) [21:56:54] (03PS2) 10Legoktm: Get link of LinkNormalizer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263739 (owner: 10Matthias Mullie) [21:58:13] (03PS1) 10Catrope: Fix sizes of VE buttons in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263742 (https://phabricator.wikimedia.org/T121987) [21:58:41] (03CR) 10Legoktm: [C: 032] Get link of LinkNormalizer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263739 (owner: 10Matthias Mullie) [21:59:57] (03CR) 10Hoo man: [C: 04-1] "Almost there" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [22:00:18] (03Merged) 10jenkins-bot: Be more clear about what data types we expect in links array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263737 (owner: 10Matthias Mullie) [22:01:29] (03PS13) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) [22:04:22] (03PS14) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) [22:05:20] (03Merged) 10jenkins-bot: Get link of LinkNormalizer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263739 (owner: 10Matthias Mullie) [22:09:39] (03PS15) 10IoannisKydonis: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) [22:10:22] (03CR) 10Hoo man: [C: 032] "No change for English, improvement for other languages :)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [22:16:58] 3Collaboration-Team-Current, 10Echo: Notice: Undefined index in LinkNormalizer.php - https://phabricator.wikimedia.org/T121694#1929542 (10matthiasmullie) 5Open>3Resolved a:3matthiasmullie https://gerrit.wikimedia.org/r/#/c/263739/ just removed this class. This error, however, indicates that method `getPr... [22:17:52] (03CR) 10Matthias Mullie: Get link of LinkNormalizer (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263739 (owner: 10Matthias Mullie) [22:21:06] (03Merged) 10jenkins-bot: Don't hardcode English parentheses in one message [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263170 (https://phabricator.wikimedia.org/T115175) (owner: 10IoannisKydonis) [22:26:40] stephanebisson: https://gerrit.wikimedia.org/r/263742 [22:29:48] (03CR) 10Sbisson: [C: 032] Fix sizes of VE buttons in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263742 (https://phabricator.wikimedia.org/T121987) (owner: 10Catrope) [22:32:23] (03PS1) 10Matthias Mullie: EchoModelFormatter extends EchoEventFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263748 [22:35:03] RoanKattouw, https://phabricator.wikimedia.org/T114991 [22:38:52] (03PS1) 10Catrope: Follow-up 88d6f01c33: postpone greying out notification bodies for now [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263750 [22:38:58] (03Merged) 10jenkins-bot: Fix sizes of VE buttons in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/263742 (https://phabricator.wikimedia.org/T121987) (owner: 10Catrope) [22:39:36] (03PS2) 10Gergő Tisza: Complete move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259065 (owner: 10Anomie) [22:40:04] (03CR) 10Pginer: [C: 031] Follow-up 88d6f01c33: postpone greying out notification bodies for now [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263750 (owner: 10Catrope) [22:42:05] (03PS1) 10Matthias Mullie: Get rid of EchoFlyoutFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263752 [22:42:41] (03CR) 10Sbisson: [C: 032] Follow-up 88d6f01c33: postpone greying out notification bodies for now [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263750 (owner: 10Catrope) [22:46:21] (03Merged) 10jenkins-bot: Follow-up 88d6f01c33: postpone greying out notification bodies for now [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263750 (owner: 10Catrope) [22:51:21] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 5 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1929647 (10mobrovac) [23:04:18] 3Collaboration-Team-Current, 10Echo: Create icons for Flowusertalk notifications - https://phabricator.wikimedia.org/T123434#1929685 (10jmatazzoni) 3NEW a:3Pginer-WMF [23:04:56] 3Collaboration-Team-Current, 10Echo: Create new notification category for talk pages: flowusertalk - https://phabricator.wikimedia.org/T121663#1929696 (10jmatazzoni) a:5jmatazzoni>3None [23:18:31] (03PS1) 10Matthias Mullie: Get rid of $legacyMapping [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263763 [23:18:35] (03PS1) 10Matthias Mullie: Get rid of flyout & html (superseeded by special) formats in old formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263764 [23:21:56] (03CR) 10jenkins-bot: [V: 04-1] Get rid of flyout & html (superseeded by special) formats in old formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263764 (owner: 10Matthias Mullie) [23:23:12] mooeypoo: Meh, can we change the mw-echo-icon to render at the native size (or as a PNG)? The fuzziness gives me a headache. [23:25:52] (In Flow, I guess?) [23:26:02] 6Collaboration-Team-Backlog, 10Echo, 6Design-Research: Evaluate designs for new notification panel actions - https://phabricator.wikimedia.org/T116741#1929782 (10Capt_Swing) [23:34:17] (03CR) 10Gergő Tisza: [C: 032] Complete move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259065 (owner: 10Anomie) [23:38:47] (03Merged) 10jenkins-bot: Complete move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259065 (owner: 10Anomie) [23:38:50] (03PS2) 10Matthias Mullie: Get rid of flyout & html (superseeded by special) formats in old formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/263764 [23:40:25] what do we plan to do for old ¬format params (in Echo API)? [23:40:45] we currently have: text, flyout, html, model, special [23:41:00] (03PS1) 10Catrope: Follow-up 88d6f01c33: postpone greying out notification bodies for now [extensions/Echo] (wmf/1.27.0-wmf.10) - 10https://gerrit.wikimedia.org/r/263767 [23:41:13] html was the old format for the special page “load more”, so we no longer need it [23:41:39] flyout was the old pre-rendered version for the flyout, but that one is now using ‘model’ (and renders on frontend) [23:41:53] is there any reason to keep the old ones around? (3rd parties) [23:42:20] Deprecate in this version, remove in the next? [23:42:21] legoktm: ? [23:43:55] do we have data on whether these are still being called at all? (a not-sampled log) [23:44:15] (in which case we could probably just remove them right away?) [23:45:36] mlitn: api.log on fluorine [23:45:41] I think crosswatch uses html [23:47:51] mlitn: Thanks for being our deprecation machine :D [23:48:05] I've enjoyed watching commits ripping out old code come by so quickly [23:49:06] legoktm: Could I get you to review https://gerrit.wikimedia.org/r/#/c/255328/17 ? It's the cross-wiki notifs integration change [23:49:16] 6Collaboration-Team-Backlog, 10Flow, 10ContentTranslation-cxserver, 10Parsoid, and 5 others: Store & load data-mw separately - https://phabricator.wikimedia.org/T78676#1929878 (10GWicke) Etherpad of recent discussion between reading, parsing & services about reducing the HTML size: https://etherpad.wikime... [23:49:22] It seems mostly sane to me, but I'm not sure how to evaluate some of the choices mlitn made, and some of the code is my own [23:49:47] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about preloading contents on a new Flow topic - https://phabricator.wikimedia.org/T113583#1929883 (10DannyH) [23:52:49] ok [23:55:17] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about preloading contents on a new Flow topic - https://phabricator.wikimedia.org/T113583#1929907 (10Trizek-WMF) Oh, I forgot the basic information: https://www.mediawiki.org/wiki/Help:Flow/Preloading Thanks @Aklapper! [23:55:26] 6Collaboration-Team-Backlog, 10Flow: Prefill loads all template contents, including elements - https://phabricator.wikimedia.org/T116002#1929910 (10Trizek-WMF) [23:55:28] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about preloading contents on a new Flow topic - https://phabricator.wikimedia.org/T113583#1929909 (10Trizek-WMF)