[00:22:36] matt_flaschen: is there a list of the mw.hooks that a tour can subscribe to? The thing I'm looking for right now is a hook related to clicking the Cite button. [00:31:13] ragesoss, we never got around to adding a mw.hook for the Cite button (or any of the toolbar buttons I believe), or jQuery listener support. [01:19:30] (03CR) 10Mattflaschen: [C: 032] "Works great, thanks." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260226 (https://phabricator.wikimedia.org/T117837) (owner: 10Sn1per) [01:23:39] (03Merged) 10jenkins-bot: Reload if board is new [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260226 (https://phabricator.wikimedia.org/T117837) (owner: 10Sn1per) [01:37:00] mooeypoo, did you figure out the array of ID thing above? [01:48:05] Going to go home and keep working. [02:01:43] 6Collaboration-Team-Backlog, 10Flow, 7Easy, 3Google-Code-In-2015: Reload board when it is created to show page actions - https://phabricator.wikimedia.org/T117837#1907614 (10Sn1per) 5Open>3Resolved [02:29:02] matt_flaschen, yeah, I made the promise return the model it comes from. That was probably the best solution. [11:16:04] 6Collaboration-Team-Backlog, 6Community-Liaison: Create a Collaboration-community-liaising board - https://phabricator.wikimedia.org/T121555#1907926 (10Qgil) I still think that creating this project is a good idea, but can we standardize the name? #Collaboration-Community-Engagement [11:38:16] 3Collaboration-Team-Current, 10Flow: Rephrase Flow notifications, move content from body into header - https://phabricator.wikimedia.org/T121950#1907948 (10Pginer-WMF) > The icon for the user name secondary actions is userAvatar, the one for Flow boards is speechBubbles, and the one for the user talk page (in... [12:57:45] 3Collaboration-Team-Current, 10Echo: Clarify notification icons - https://phabricator.wikimedia.org/T121735#1908081 (10Pginer-WMF) [13:06:38] 3Collaboration-Team-Current, 10Echo: Clarify notification icons - https://phabricator.wikimedia.org/T121735#1908085 (10Pginer-WMF) [13:07:58] 3Collaboration-Team-Current, 10Echo: Clarify notification icons - https://phabricator.wikimedia.org/T121735#1886585 (10Pginer-WMF) I added the icons (and extended the list with "flow-post-edited" and "flow-topic-renamed"). Moving it to ready to pick up, unless anything else is missing. [13:08:39] 3Collaboration-Team-Current, 10Echo: Clarify notification icons - https://phabricator.wikimedia.org/T121735#1908091 (10Pginer-WMF) a:5Pginer-WMF>3None [16:09:26] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-header-edit-user-talk-with-section/ksh]]: Parameter $3 is superfluous - https://phabricator.wikimedia.org/T122580#1908226 (10Aklapper) [16:09:38] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-header-edit-user-talk/ksh]]: Parameter $3 is superfluous - https://phabricator.wikimedia.org/T122579#1908228 (10Aklapper) [16:09:57] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-header-edit-user-talk/ksh]]: Parameter $3 is superfluous - https://phabricator.wikimedia.org/T122579#1908231 (10Aklapper) 5Open>3stalled > Parameter $3 is superfluous. Why do you think so? Please elaborate. [16:10:40] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-bundle-header-edit-user-talk/ksh]] i18n issues - https://phabricator.wikimedia.org/T122577#1908233 (10Aklapper) [16:11:44] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-bundle-header-edit-user-talk/ksh]] i18n issues - https://phabricator.wikimedia.org/T122577#1908237 (10Aklapper) > Parameter $3 is superfluous Why do you think so? Please elaborate. [16:21:12] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-header-edit-user-talk-with-section/ksh]]: Parameter $3 is superfluous - https://phabricator.wikimedia.org/T122580#1908238 (10Purodha) >>! In T122580#1908193, @Aklapper wrote: > (For future reference, please summarize the actual issue in the... [16:26:27] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-header-edit-user-talk-with-section/ksh]]: Parameter $3 is superfluous - https://phabricator.wikimedia.org/T122580#1908240 (10Purodha) >>! In T122580#1908215, @Aklapper wrote: >> Parameter $3 is superfluous. > > Why do you think so? Please... [16:29:00] (03CR) 10Ankitashukla: [C: 031] "Resolved. Can be merged." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261188 (https://phabricator.wikimedia.org/T119375) (owner: 10Mhutti1) [16:31:23] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-header-edit-user-talk/ksh]]: Parameter $3 is superfluous - https://phabricator.wikimedia.org/T122579#1908247 (10Purodha) >>! In T122579#1908231, @Aklapper wrote: >> Parameter $3 is superfluous. > > Why do you think so? Please elaborate. I... [16:33:32] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-bundle-header-edit-user-talk/ksh]] i18n issues - https://phabricator.wikimedia.org/T122577#1908248 (10Purodha) It is superfluous, since if you omit the exact string "$3" from the message, it renders exactly the same. Details in https://tran... [18:23:11] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-bundle-header-edit-user-talk/ksh]] i18n issues - https://phabricator.wikimedia.org/T122577#1908395 (10matej_suchanek) For "a message", see {T121328}. Suggesting wontfix as ksh and en are not the only languages in the world. [18:28:14] 6Collaboration-Team-Backlog, 6Community-Liaison: Create a Collaboration-community-liaising board - https://phabricator.wikimedia.org/T121555#1908404 (10Aklapper) Whatever is wanted and agreed on I'm happy to create. See checklist on https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects#New_... [19:05:44] (03CR) 10Mooeypoo: "We can test it only on top of the demo commit..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260392 (https://phabricator.wikimedia.org/T121929) (owner: 10Mooeypoo) [19:24:09] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261433 [19:28:08] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/Flow] - 10https://gerrit.wikimedia.org/r/261444 [19:41:23] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/261485 [19:45:32] 3Collaboration-Team-Current, 10Echo, 7Voice & Tone, 7WorkType-NewFunctionality: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#1908592 (10Mattflaschen) For the secondary links, we decided: Refer in links to just “Pari... [19:45:34] (03CR) 10Addshore: [C: 032] build: Updating development dependencies [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261433 (owner: 10Legoktm) [19:46:31] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/261499 [19:48:05] (03CR) 10Addshore: [C: 032] build: Updating development dependencies [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/261485 (owner: 10Legoktm) [19:51:12] (03CR) 10Addshore: [C: 032] build: Updating development dependencies [extensions/Flow] - 10https://gerrit.wikimedia.org/r/261444 (owner: 10Legoktm) [19:57:47] (03PS1) 10Legoktm: build: Updating development dependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/261534 [19:58:46] matt_flaschen: from within an on-wiki tour, is it possible to detect whether the firstedit tour is active? Or, is it possible from an on-wiki tour to tell mediawiki that it's already been completed, so that it doesn't show up in the middle of the active tour? [20:01:49] 3Collaboration-Team-Current, 10Flow: Deleted wikitext Talk page cannot be restored after EnableFlow creates the same page - https://phabricator.wikimedia.org/T104591#1908635 (10Etonkovidova) [20:02:20] 3Collaboration-Team-Current, 10Flow: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#1908636 (10Etonkovidova) [20:02:54] 3Collaboration-Team-Current, 10Flow: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#1908640 (10Etonkovidova) [20:09:36] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/Echo] - 10https://gerrit.wikimedia.org/r/261433 (owner: 10Legoktm) [20:14:03] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/261485 (owner: 10Legoktm) [20:17:35] (03CR) 10Addshore: [C: 032] build: Updating development dependencies [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/261499 (owner: 10Legoktm) [20:17:36] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1908704 (10jmatazzoni) For the record: on the 12/29 Collab Team Discussion, we decided to go with the plan to remove the X for the X-Wiki bundles and make people X out bun... [20:23:39] 3Collaboration-Team-Current, 10Echo: Flow posts on one's own user talk page should use a notification more like edit-user-talk - https://phabricator.wikimedia.org/T121663#1908748 (10jmatazzoni) For the record, regarding use of the Orange Bar for flowusertalk Notifications: In the 12/29 Collab Team Discussion... [20:33:42] (03CR) 10Addshore: [C: 032] build: Updating development dependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/261534 (owner: 10Legoktm) [20:34:45] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/Flow] - 10https://gerrit.wikimedia.org/r/261444 (owner: 10Legoktm) [20:51:36] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/261499 (owner: 10Legoktm) [21:07:54] (03Merged) 10jenkins-bot: build: Updating development dependencies [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/261534 (owner: 10Legoktm) [21:16:51] 6Collaboration-Team-Backlog, 10Echo: When mentioning other users, indicate mention notifications in the "your edit was saved" message - https://phabricator.wikimedia.org/T68078#1908867 (10Luke081515) Some people at the german wikipedia rated this as very useful, because there are often unsure, if a notificatio... [21:36:23] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: OOUI widgets for new notification design - https://phabricator.wikimedia.org/T115419#1908907 (10Mooeypoo) >>! In T115419#1900484, @Pginer-WMF wrote: >>>! In T115419#1888350, @Etonkovidova wrote: >> User icon shown in Alerts - a working link. >> {F3113... [21:43:44] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-header-edit-user-talk-with-section/ksh]]: Parameter $3 is superfluous - https://phabricator.wikimedia.org/T122580#1908929 (10Mattflaschen) 5stalled>3declined a:3Mattflaschen Please use $3 for GENDER (if needed in your language), rathe... [21:44:40] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-bundle-header-edit-user-talk/ksh]] i18n issues - https://phabricator.wikimedia.org/T122577#1908937 (10Mattflaschen) [21:44:41] 3Collaboration-Team-Current, 10Echo, 7I18n, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): notification-bundle-header-edit-user-talk should say "messages" instead of "a message" - https://phabricator.wikimedia.org/T121328#1908938 (10Mattflaschen) [21:45:23] 6Collaboration-Team-Backlog, 10Echo, 7I18n: [[MediaWiki:Notification-bundle-header-edit-user-talk/ksh]] i18n issues - https://phabricator.wikimedia.org/T122577#1907955 (10Mattflaschen) $3 was filed as {T122580}. [21:46:13] (03CR) 10Mattflaschen: "Still working on this. I've hit some other blockers in Vagrant, but if I can't unblock, I will try to bypass." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260392 (https://phabricator.wikimedia.org/T121929) (owner: 10Mooeypoo) [21:46:30] (03CR) 10Mattflaschen: "Working on making it testable on MWV I mean." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260392 (https://phabricator.wikimedia.org/T121929) (owner: 10Mooeypoo) [21:48:08] ragesoss, what do you mean by "Or, is it possible from an on-wiki tour to tell mediawiki that it's already been completed, so that it doesn't show up in the middle of the active tour?" exactly? [21:49:16] matt_flaschen: I'm building a tour that will, in many cases, be loaded for newcomers the first time that they click Edit. So for those users, the first edit tour that is build in on Wikipedia will *also* be active. [21:49:23] I'm trying to figure out a good way to work around that. [21:49:52] because some of the guiders may overlap, and the blue dots will lead users off the intended path. [21:50:47] ragesoss, you mean the blue dots on the VisualEditor toolbar? [21:50:48] My current approach is to basically have a first edit that doesn't give any specific guidance at all and just tells the user to make an edit. That way, it's more or less compatible. [21:51:17] matt_flaschen: that's right. As well as the 'Start Editing' modal (visualeditor-welcomedialog) [21:51:39] ragesoss, those are not part of GuidedTour. [21:51:52] They're a VE feature. [21:52:01] Which is not implemented as a tour. [21:52:45] but would it be possible to disable it from a tour? [21:53:14] ragesoss, yeah, probably. [21:53:27] I'll take a quick look for you. [21:53:28] I think I've found an okay workaround for now, but having a little more control over the experience would be nice. [21:56:10] ragesoss, the dialog is the one with visualeditor-welcomedialog-content-text class? [21:56:10] matt_flaschen: one other thing that has been frustrating is how the hooks behave... it's hard to reliably use use the VE activated and deactivated hooks to chain a series of edits, because even post-edit, those hooks all seem to be triggered, so the tour ends up skipping steps. [21:56:10] matt_flaschen: that's the one. [21:57:29] named steps makes a huge difference in the ability to reorganize a tour. kudos for that. [21:57:54] Thanks [21:58:18] Yeah, I don't think I considered that scenario (multiple edits before page reload). It's an issue with how mw.hook in core memorizes the last fired version. [21:58:26] ragesoss, you could hack around it by triggering a refresh. [21:58:31] yes, that's what I've done. [21:58:52] I'm using external links with step=foo, instead of 'next' [22:00:18] ragesoss, oh, it's pretty easy to hide the dialog turns out. [22:00:30] Just send them to VE with vehidebetadialog=1. [22:00:43] They will still see it later, but not while that's in the URL. [22:01:10] If you wanted, you could disable it in preferences, but probably not a good idea. [22:01:20] ragesoss, I think blue dots are separate, let me check that now. [22:01:39] matt_flaschen: awesome. do you know if the opposite is possible? to make that stuff appear (for testing) even if you already viewed it? [22:06:38] ragesoss, I think in both cases you could fake it by changing mw.user.options. [22:07:11] ragesoss, but if you're doing it for real, it's more complicated, and for the blue dots, you might want to ask the VE team to implement a way to hide the dots (similar to vehidebetadialog). [22:07:19] Faking it will only work if there's no page load. [22:08:03] well, hiding the dialog is already very helpful, and I've designed around the blue dots to some extent. [22:08:24] I'll ping the VE team, though... another parameter to hide the dots would be handy. [22:08:51] Otherwise, you need to actually change the user options. Setting visualeditor-hideusered and visualeditor-hidebetawelcome to 0 (and not using the hdie URL parameter) should make both show. You would have to use https://www.mediawiki.org/wiki/API:Options [22:09:00] or better yet, make vehidedialog *also* hide the dots. [22:09:17] ragesoss, yeah, that is worth considering. [22:10:44] Getting "lunch" [22:54:51] I have to go pick someone up. I'll be back. [23:53:42] Devs: unclear question about "Exception caught inside exception handler" and "wgShowExceptionDetails" at https://www.mediawiki.org/wiki/Topic:Svhoibbfdbwjlynb . I can't see anything in phab. Should I ask the person for more details, or is there enough context there for you to answer? [23:54:33] quiddity: Perhaps he should try setting $wgShowExceptionDetails = true; at the bottom of LocalSettings.php to show detailed debugging information. [23:54:49] ;p [23:55:39] (More seriously... Perhaps that should be the default, for 3rd party users of the extension?) [23:56:29] * Deskana shrugs