[00:03:17] matt_flaschen: anybody knows what's happened with betalabs -InvalidArgumentException for everything [00:03:38] etonkovidova, no, but I'll look. [00:04:11] matt_flaschen: thx! looks like beta cluster errors to me [00:09:10] etonkovidova, other people are working on it in #wikimedia-releng [00:09:38] matt_flaschen: as I thought :) [00:13:48] 6Collaboration-Team-Backlog, 10Flow: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#1899790 (10Mattflaschen) 3NEW [00:15:16] 6Collaboration-Team-Backlog, 10Flow: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#1899800 (10Mattflaschen) 3NEW [00:15:24] 6Collaboration-Team-Backlog, 10Flow: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#1899790 (10Mattflaschen) [00:15:26] 6Collaboration-Team-Backlog, 10Flow: Improve Flow deletion/undeletion resilience - https://phabricator.wikimedia.org/T122262#1899811 (10Mattflaschen) [00:16:08] 6Collaboration-Team-Backlog, 10Flow: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#1899790 (10Mattflaschen) [00:17:07] 6Collaboration-Team-Backlog, 10Flow: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#1899790 (10Mattflaschen) [00:17:23] 3Collaboration-Team-Current, 10Flow: Fix en:Wikipedia_talk:Flow/Developer_test_page - https://phabricator.wikimedia.org/T117812#1899816 (10Mattflaschen) [00:21:24] 6Collaboration-Team-Backlog, 10Flow: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#1899819 (10Mattflaschen) [00:32:25] 3Collaboration-Team-Current, 10Flow: Fix en:Wikipedia_talk:Flow/Developer_test_page - https://phabricator.wikimedia.org/T117812#1899838 (10Mattflaschen) Ran: ``` UPDATE flow_workflow SET workflow_page_id = 41854369 WHERE workflow_wiki = 'enwiki' AND workflow_namespace = 5 AND workflow_title_text = 'Flow/Devel... [00:39:18] 6Collaboration-Team-Backlog, 10Flow: Come up with scenarios for deletion/undeletion of Flow boards and figure out how to handle them - https://phabricator.wikimedia.org/T122261#1899840 (10Mattflaschen) [00:39:42] 3Collaboration-Team-Current, 10Flow: Fix en:Wikipedia_talk:Flow/Developer_test_page - https://phabricator.wikimedia.org/T117812#1899844 (10Mattflaschen) Worked-around (through above and then just doing a straight undelete). Everything should be back to normal on that page. See {T122261} and {T122262} for fol... [00:40:55] 3Collaboration-Team-Current, 10Flow: Fix en:Wikipedia_talk:Flow/Developer_test_page - https://phabricator.wikimedia.org/T117812#1899848 (10Mattflaschen) [00:51:33] (03CR) 10Legoktm: [C: 032] Add agent link to all PageTriage notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/260594 (https://phabricator.wikimedia.org/T121737) (owner: 10Sbisson) [00:51:53] (03CR) 10Mattflaschen: "I changed my mind. I am going to review this now, then if possible retest it after the Vagrant stuff is done, but before it goes to produ" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260068 (https://phabricator.wikimedia.org/T121828) (owner: 10Sbisson) [00:53:03] (03CR) 10Legoktm: Add agent link to most notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260587 (https://phabricator.wikimedia.org/T121737) (owner: 10Sbisson) [01:16:51] (03CR) 10Mattflaschen: [C: 04-1] "This approach looks right." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260068 (https://phabricator.wikimedia.org/T121828) (owner: 10Sbisson) [01:25:51] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-Vagrant: Setup cross-wiki notifications in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T119999#1899909 (10Mattflaschen) [01:30:06] 3Collaboration-Team-Current, 10Echo, 3Google-Code-In-2015, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Clarify link and revert icons on notifications - https://phabricator.wikimedia.org/T121624#1899910 (10Etonkovidova) More screenshots from betalabs: {F3136791} {F3136787} [01:33:43] 6Collaboration-Team-Backlog, 10Echo, 5MW-1.27-release-notes, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): page-linked notifications seems to be broken - https://phabricator.wikimedia.org/T121780#1899914 (10Krinkle) 5Open>3Resolved [02:21:26] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-Vagrant: Setup cross-wiki notifications in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T119999#1899946 (10Mattflaschen) [02:57:28] (03CR) 10Mattflaschen: [C: 04-1] "We may not want to do this. This will cause the echo_unread_wikis table to be created on every database on Beta, whereas we actually just " [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260254 (owner: 10Paladox) [08:47:55] 3Collaboration-Team-Current, 10Echo: Make page titles bold in notifications - https://phabricator.wikimedia.org/T121724#1900395 (10Pginer-WMF) >>! In T121724#1899373, @Mattflaschen wrote: > I thought we were going to use a convention of bold for board titles, and quotes (but not bold) for topics. This seems t... [08:54:39] 6Collaboration-Team-Backlog, 10Echo, 7Epic, 7WorkType-NewFunctionality: Better organisation for the Notification System - https://phabricator.wikimedia.org/T114351#1900406 (10Pginer-WMF) [08:59:25] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1900411 (10Pginer-WMF) >>! In T121923#1896705, @jmatazzoni wrote: > (Parenthetically, I'm sure there is a style guide for... [09:16:47] 3Collaboration-Team-Current, 10Echo: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1900432 (10Pginer-WMF) > What do you think? Marking **only** the items in the bundle makes sense. Otherwise it can be confusing to get side-effects you cannot anticipate. These kind of actions... [10:06:33] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: OOUI widgets for new notification design - https://phabricator.wikimedia.org/T115419#1900484 (10Pginer-WMF) >>! In T115419#1888350, @Etonkovidova wrote: > User icon shown in Alerts - a working link. > {F3113109} For the user action, I used the standa... [10:16:58] (03CR) 10Matthias Mullie: "What's wrong with seenTime? It doesn't really matter what format it's stored at (pretty much all timestamps are stored in TS_MW format), s" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260591 (https://phabricator.wikimedia.org/T121813) (owner: 10Matthias Mullie) [10:35:49] (03CR) 10Paladox: "Ok. So you doint want it added to hooks.php but could it be added to echo.sql." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260254 (owner: 10Paladox) [10:51:52] 3Collaboration-Team-Current, 10Echo, 3Google-Code-In-2015, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Clarify link and revert icons on notifications - https://phabricator.wikimedia.org/T121624#1900526 (10Pginer-WMF) Thanks for the screenshots @Etonkovidova. Based on those, I think we coul... [10:52:18] 6Collaboration-Team-Backlog, 10Flow: Moving a URL reduces it to index.php only - https://phabricator.wikimedia.org/T122285#1900527 (10Trizek-WMF) 3NEW [10:52:25] 6Collaboration-Team-Backlog, 10Flow: Moving a URL reduces it to index.php only - https://phabricator.wikimedia.org/T122285#1900535 (10Trizek-WMF) [10:54:35] 3Collaboration-Team-Current, 10Echo: Notifications- Revert and Alerts -design updates - https://phabricator.wikimedia.org/T122254#1900546 (10Pginer-WMF) I added some comments about size inconsistency in the main ticket (T121624#1900526). Taking the current icons as reference it seems the available area is of... [11:04:18] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7I18n, 5Patch-For-Review: Add GENDER support to pagetriage-byline and friend - https://phabricator.wikimedia.org/T95050#1900565 (10Liuxinyu970226) [13:48:59] 3Collaboration-Team-Current, 10Flow: Rephrase Flow notifications, move content from body into header - https://phabricator.wikimedia.org/T121950#1900818 (10Pginer-WMF) [13:50:03] 3Collaboration-Team-Current, 10Flow: Rephrase Flow notifications, move content from body into header - https://phabricator.wikimedia.org/T121950#1892159 (10Pginer-WMF) [14:13:09] (03PS3) 10Sbisson: Flow Nuke: remove join on user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260068 (https://phabricator.wikimedia.org/T121828) [14:13:25] (03CR) 10Sbisson: Flow Nuke: remove join on user (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260068 (https://phabricator.wikimedia.org/T121828) (owner: 10Sbisson) [14:23:08] (03PS2) 10Sbisson: Add agent link to most notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260587 (https://phabricator.wikimedia.org/T121737) [14:23:38] (03CR) 10Sbisson: Add agent link to most notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260587 (https://phabricator.wikimedia.org/T121737) (owner: 10Sbisson) [14:27:15] (03PS1) 10Sbisson: Replace 'a message' with 'messages' in 'notification-edit-talk-page-bundle' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260758 (https://phabricator.wikimedia.org/T121328) [14:28:39] 3Collaboration-Team-Current, 10Echo, 7I18n, 5Patch-For-Review: notification-bundle-header-edit-user-talk should say "messages" instead of "a message" - https://phabricator.wikimedia.org/T121328#1900890 (10SBisson) a:3SBisson [15:36:28] mlitn, I think I may be confused, but I am not entirely sure...you got a second for sanity-checking my brain for seenTime ? [15:37:35] mlitn, my only worry is that the UI fetches the current 'seen time' for each popup, and then compares each notification timestamp against the seenTime to see if the notification should be marked as "unseen"... if seenTime is in a different format than the notification timestamp, aren't we running a risk of having that process fail? [15:42:27] ... okay, they're not a different format, they're both MW timestamps, I missed that... [15:42:57] mlitn, sorry, I got confused with what the actual fix was doing vs. what I thought the problem was (and wasn't). I'm merging. Thanks for this! [15:43:52] (03CR) 10Mooeypoo: [C: 032] "Yes, sorry, I got confused with what I thought the problem was vs. what it actually was. The issue of the UTC seemed to have been mainly i" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260591 (https://phabricator.wikimedia.org/T121813) (owner: 10Matthias Mullie) [15:44:50] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Relative timestamps in notification panel are wrong - https://phabricator.wikimedia.org/T121813#1900992 (10Mooeypoo) This looks good and works, thanks @matthiasmullie! Just a reminder for us and QA -- we should retest this when cross-wiki notifications... [15:48:19] (03Merged) 10jenkins-bot: Use UTC timestamps in flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260591 (https://phabricator.wikimedia.org/T121813) (owner: 10Matthias Mullie) [15:51:11] Popup. [16:15:42] 6Collaboration-Team-Backlog, 10Echo, 10Flow, 7Easy, and 3 others: Remove BatchRowUpdate from Flow and Echo and use the one in MediaWiki core instead - https://phabricator.wikimedia.org/T119253#1901034 (10Sn1per) 5Open>3Resolved [16:19:24] 3Collaboration-Team-Current, 10Flow: Rephrase Flow notifications, move content from body into header - https://phabricator.wikimedia.org/T121950#1901036 (10SBisson) a:3SBisson [16:22:02] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#1901037 (10Mooeypoo) We had a couple of chats about this, and I believe the agreement in the most recent meeting was to make this more general, like... [16:44:19] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#1901077 (10Pginer-WMF) >>! In T114237#1901037, @Mooeypoo wrote: > We had a couple of chats about this, and I believe the agreement in the most recent... [16:50:24] 3Collaboration-Team-Current, 10Echo: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1901083 (10Mooeypoo) >>! In T121930#1900432, @Pginer-WMF wrote: > Marking **only** the items in the bundle makes sense. Otherwise it can be confusing to get side-effects you cannot anticipate.... [17:21:11] (03PS4) 10Mooeypoo: [WIP - waiting for copy] Add cross-wiki as a beta feature [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256138 (https://phabricator.wikimedia.org/T114237) [17:32:59] (03PS1) 10Mooeypoo: Add space between notification item buttons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260769 (https://phabricator.wikimedia.org/T121955) [17:33:18] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Put more space between adjacent category links - https://phabricator.wikimedia.org/T121955#1901215 (10Mooeypoo) a:3Mooeypoo [17:40:27] I'm adding another action type to the echo logging operation "notification-bundle-expand" - this is just adding another string to the 'action' property of the event.. Anyone knows if I should do anything special for that? I don't think it changes the actual schema, does mw.eventLog have some preset action list? [17:42:34] (03PS1) 10Mooeypoo: Log the expand action of a notification group item [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260772 (https://phabricator.wikimedia.org/T121945) [17:43:31] I do not know [17:43:42] let me know when you find out [17:43:48] mooeypoo: ^ [17:45:08] * mooeypoo shall [17:45:29] I don't *think* so.. sounds weird that it would require anything, but my previous experience with the logger made me doubt my own logic. [17:46:55] Also, I just rediscovered the fact that we *do* store the wiki dbname in the logging operations, so cross-wiki logging should work without having to change the schema like we feared. [17:47:18] Though we will probably have to change the way the graphs are displayed [17:48:46] .... actually, now I see why I discovered it now rather than before. It's new! https://gerrit.wikimedia.org/r/#/c/258178/1 meh, why is this ticket not in QA review [17:51:30] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Fix EventLogging for cross-wiki notifications - https://phabricator.wikimedia.org/T120158#1901329 (10Mooeypoo) a:3Mooeypoo The only thing I have is the "source" name, which the API sends for cross-wiki bundles.... [17:53:31] oh, ha. never mind me. I'll go back to working on actual code rather than confusing myself with petty READING THE TICKET stuff... [18:05:00] (03PS1) 10Sbisson: Fix casing of Whatlinkshere in page-linked presentation model [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260774 [18:07:53] (03PS18) 10Mooeypoo: Add a demo special page to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254612 (https://phabricator.wikimedia.org/T115551) [18:14:56] 3Collaboration-Team-Current, 10Echo: Notifications- Revert and Alerts -design updates - https://phabricator.wikimedia.org/T122254#1901372 (10Etonkovidova) [18:16:51] 3Collaboration-Team-Current, 10Echo: Notifications- Revert and Alerts -design updates - https://phabricator.wikimedia.org/T122254#1901374 (10Etonkovidova) 5Open>3Resolved [18:37:13] 3Collaboration-Team-Current, 10Echo: Notifications- Revert and Alerts -design updates - https://phabricator.wikimedia.org/T122254#1901447 (10Luke081515) [18:38:29] (03PS1) 10Mooeypoo: Log cross-wiki & bundle items impressions and add their source wiki [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260776 (https://phabricator.wikimedia.org/T120158) [18:48:05] (03CR) 10Legoktm: [C: 032] Fix casing of Whatlinkshere in page-linked presentation model [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260774 (owner: 10Sbisson) [18:48:42] (03CR) 10Legoktm: [C: 032] Replace 'a message' with 'messages' in 'notification-edit-talk-page-bundle' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260758 (https://phabricator.wikimedia.org/T121328) (owner: 10Sbisson) [18:53:21] (03CR) 10Legoktm: Add agent link to most notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260587 (https://phabricator.wikimedia.org/T121737) (owner: 10Sbisson) [18:53:54] (03CR) 10Legoktm: [C: 04-1] "Per PS1 comments" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260587 (https://phabricator.wikimedia.org/T121737) (owner: 10Sbisson) [18:54:20] (03Merged) 10jenkins-bot: Fix casing of Whatlinkshere in page-linked presentation model [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260774 (owner: 10Sbisson) [18:57:30] Take-away from Scrum of Scrums: Discovery team is looking at a PHP language detector. We could use this to detect language for Flow content to auto-fix directionality. [18:58:30] matt_flaschen, oooo... though I'd talk to David (from VE) about that. I think that he researched into language "detector" for VE and there are a whole lot of issues when it comes to different scripts [18:58:38] scripts as in unicode values [19:00:16] (03Merged) 10jenkins-bot: Replace 'a message' with 'messages' in 'notification-edit-talk-page-bundle' [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260758 (https://phabricator.wikimedia.org/T121328) (owner: 10Sbisson) [19:00:35] 6Collaboration-Team-Backlog, 10Flow: Detect LTR/RTL directionality on a per-post basis when it's saved - https://phabricator.wikimedia.org/T90523#1901502 (10Mattflaschen) The Discovery team is also now working on {T121538}. They're porting a library to PHP, which could make hooking up to the MediaWiki API more... [19:01:34] mooeypoo: is the demo special page mostly done now? [19:04:00] 6Collaboration-Team-Backlog, 10Flow: Detect LTR/RTL directionality on a per-post basis when it's saved - https://phabricator.wikimedia.org/T90523#1901518 (10Mattflaschen) >>! In T90523#1595070, @Mattflaschen wrote: > I think this would probably have to be simpler and 100% client-side, but it might be a place t... [19:07:04] mooeypoo, dchan on Phabricator, right? [19:07:23] matt_flaschen, yep, he goes by that in IRC so I think that's his name on there too [19:07:37] 6Collaboration-Team-Backlog, 10Flow: Detect LTR/RTL directionality on a per-post basis when it's saved - https://phabricator.wikimedia.org/T90523#1901531 (10Mattflaschen) @mooeypoo says to ask @dchan about this. [19:08:19] matt_flaschen, I think he was checking into it for a 'as you type' functionality, but either way, I remember he had some issues. Not 100% sure what it was. [19:09:13] legoktm, yes, except for a TINY MINOR CHANGE I was just about to make to the data files (found it through fixing another bug) [19:09:17] was about to push it [19:09:38] (03PS19) 10Mooeypoo: Add a demo special page to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254612 (https://phabricator.wikimedia.org/T115551) [19:09:41] legoktm, NOW it's ready. [19:11:03] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Moving a URL reduces it to index.php only - https://phabricator.wikimedia.org/T122285#1901537 (10Mattflaschen) [19:11:54] mooeypoo: i was wondering if we want the demo to be enabled on the production wikis, or whether we should guard it with a $wgEchoEnableDemo = false so we only turn it on for dev wikis? [19:12:18] (I know it's unlisted, but people tend to find those really fast) [19:12:34] 6Collaboration-Team-Backlog, 10Flow: Detect LTR/RTL directionality on a per-post basis when it's saved - https://phabricator.wikimedia.org/T90523#1901542 (10Mooeypoo) I remember we were looking into something like this for VisualEditor's language detection, but then ran into a few problems. I am not sure if th... [19:12:44] hmm [19:13:43] legoktm, good point. Sure, we can hide it behind a config variable. [19:14:00] I mena, I can see its use either way. I don't mind which. [19:14:31] It's not like if people discover it we're doomed. It's a demonstration of several options of the notifications to play around with safely. We can eithre let those who are resourceful enough to find it play with it, or hide it. Works ether way [19:17:10] mooeypoo, yeah, ideally the language detector would be Good Enough, and maybe the user could override it. [19:17:50] I think we generally hide that kind of thing, not because it's Super Secret, but just because it's for development use. [19:19:07] matt_flaschen, also, Google and Facebook and Twitter each have a different algorithm to when to flip the textarea, and each of those is great for X cases and horrific for Y cases [19:19:11] ... you can't win in RTL [19:19:13] :P [19:20:07] wow, vagrant is loading and seems to download the entire npm library online [19:20:54] mooeypoo, yeah, the npm downloads always look crazy. I always assume it's being cached properly..., but I think libraries can also have dependencies with different versions of the same libraries. [19:21:17] mooeypoo, we don't have to win, though, we just have to do better than "every post on Commons is considered LTR". [19:21:37] And then try to improve from there. [19:23:59] mooeypoo, so EventLogging fields like action should always be enums (and it is in this case). [19:24:15] That means it will keep track of invalid instrumentation so they can be fixed. [19:24:20] So to add a new action you have to: [19:24:25] 1. Update https://meta.wikimedia.org/wiki/Schema:EchoInteraction . [19:25:19] 2. Update the revision ID at https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FEcho.git/master/Echo.php#L477 [19:25:28] 3. Update the actual instrumentation to send the new field, which you did. [19:26:27] (03CR) 10Mattflaschen: [C: 04-1] "Per IRC, you need to update the EchoInteraction schema, and then the revision ID of EchoInteraction in Echo.php." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260772 (https://phabricator.wikimedia.org/T121945) (owner: 10Mooeypoo) [19:26:44] ^ stephanebisson [19:27:04] thanks [19:28:16] Basically the same process for other schema changes as well. [19:29:06] Getting lunch [19:33:08] matt_flaschen, awesome, thanks! [19:33:23] I didn't think that included a schema change, but good to know. Makes sense with enums. [19:36:03] 6Collaboration-Team-Backlog, 10Echo, 3Google-Code-In-2015, 7Mobile: There is no way to distinguish old and new notifications in mobile - https://phabricator.wikimedia.org/T119597#1901620 (10nicoco007) I can't seem to find the issue described. In both the desktop and mobile interfaces, unread notifications... [19:36:39] (03PS2) 10Mooeypoo: Log the expand action of a notification group item [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260772 (https://phabricator.wikimedia.org/T121945) [19:40:04] Hm. We're not planning to have nested group items in the notifications, are we? [19:42:37] 6Collaboration-Team-Backlog, 10Flow: Flow\Exception\FlowException from line 159 of Flow/includes/Formatter/ChangesListQuery.php: Revision not found in revisionCache - https://phabricator.wikimedia.org/T122329#1901636 (10Southparkfan) 3NEW [19:58:42] (03PS3) 10Sbisson: Add agent link to most notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260587 (https://phabricator.wikimedia.org/T121737) [19:59:29] (03CR) 10Sbisson: Add agent link to most notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260587 (https://phabricator.wikimedia.org/T121737) (owner: 10Sbisson) [20:11:05] (03CR) 10Sbisson: [C: 032] Add space between notification item buttons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260769 (https://phabricator.wikimedia.org/T121955) (owner: 10Mooeypoo) [20:14:18] (03CR) 10Sbisson: [C: 032] Display readable API error message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260495 (https://phabricator.wikimedia.org/T121923) (owner: 10Mooeypoo) [20:16:50] (03Merged) 10jenkins-bot: Add space between notification item buttons [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260769 (https://phabricator.wikimedia.org/T121955) (owner: 10Mooeypoo) [20:18:37] (03Merged) 10jenkins-bot: Display readable API error message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260495 (https://phabricator.wikimedia.org/T121923) (owner: 10Mooeypoo) [20:52:51] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7Epic: Associate non-body content such as annotations and talk to a location in the article - https://phabricator.wikimedia.org/T89575#1901926 (10awight) p:5Low>3Normal I don't see any reason this should be less than "Normal" priority, but feel free... [20:54:39] 6Collaboration-Team-Backlog, 10Echo: Invalid language code "hu_hu" - https://phabricator.wikimedia.org/T122343#1901932 (10aaron) 3NEW [20:56:12] (03PS1) 10Mattflaschen: WIP: Move up FlowUpdateWorkflowPageId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260800 (https://phabricator.wikimedia.org/T122329) [20:57:19] 6Collaboration-Team-Backlog, 10Flow, 5Patch-For-Review: Flow\Exception\FlowException from line 159 of Flow/includes/Formatter/ChangesListQuery.php: Revision not found in revisionCache - https://phabricator.wikimedia.org/T122329#1901947 (10Mattflaschen) It seems you have a corrupt row in your database. The s... [20:58:06] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow\Exception\FlowException from line 159 of Flow/includes/Formatter/ChangesListQuery.php: Revision not found in revisionCache - https://phabricator.wikimedia.org/T122329#1901950 (10Mattflaschen) [21:07:24] (03PS1) 10Mattflaschen: Add README pointing to Extension:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260850 (https://phabricator.wikimedia.org/T65125) [21:07:35] 3Collaboration-Team-Current, 10Echo: Invalid language code "hu_hu" - https://phabricator.wikimedia.org/T122343#1902004 (10Luke081515) [21:08:02] 3Collaboration-Team-Current, 10Echo: Invalid language code "hu_hu" - https://phabricator.wikimedia.org/T122343#1902007 (10Luke081515) p:5Triage>3High (High or UBN) [21:11:30] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow\Exception\FlowException from line 159 of Flow/includes/Formatter/ChangesListQuery.php: Revision not found in revisionCache - https://phabricator.wikimedia.org/T122329#1902018 (10Southparkfan) Output of your SQL: ``` MariaDB [permanentfuturelabwiki]... [21:36:49] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow\Exception\FlowException from line 159 of Flow/includes/Formatter/ChangesListQuery.php: Revision not found in revisionCache - https://phabricator.wikimedia.org/T122329#1902174 (10Southparkfan) NB: I'm actually not sure whether I got the same error a... [21:39:04] stephanebisson, just curious, when you were testing Nuke, did you see https://phabricator.wikimedia.org/T32584 for all normal pages? That's what I'm seeing. [21:41:39] matt_flaschen: Never seen that with topics. But, when I select too many topics and try to delete them, the call times out but it is still looping and deleting in the background so if I search again right away I get back topics that will have been deleted by the time I try to delete them again. [21:42:01] stephanebisson, yeah, I don't see it for topics either, but I do see it for normal pages. [21:42:12] Not just images. [21:42:30] the normal Nuke thing is based on the recentchanges table [21:42:44] Yeah, I'm surprised it doesn't remove it from RC to prevent that. [21:42:56] when you delete a page it flips rc_new=0 but I think it's deferred [21:45:57] Hmm, I'm not going to investigate further, but I noted on the bug that I do see it for pages. [21:46:34] this bug is from 2011 [21:46:44] makes me wonder how many people are using Nuke [21:49:27] stephanebisson, it could go to the job queue or something and get flipped eventually (Pretty Soon), though that seems weird. Or it could be quirk of my local setup. ^ quiddity. [21:49:44] I was also surprised, as it seems annoying, though I guess not a big deal if the spam is < 500 per user. [21:50:23] I have no experience with it. try legoktm ^ [21:50:52] (starting 10 mins ago) [21:51:06] ? [21:51:19] (the thread, for him) [21:52:18] matt_flaschen: I've never seen that before when using Nuke...maybe it's slave lag? [21:52:30] (03CR) 10Mattflaschen: [C: 032] "I think we've got it this time." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260068 (https://phabricator.wikimedia.org/T121828) (owner: 10Sbisson) [21:55:25] legoktm, shouldn't be slave lag locally right? I don't think the fake slave lag is in anymore. [21:55:43] no.... [21:56:01] (03Merged) 10jenkins-bot: Flow Nuke: remove join on user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260068 (https://phabricator.wikimedia.org/T121828) (owner: 10Sbisson) [21:56:04] oh I guess the RC entries might be deferred now? [22:05:35] every time someone says "Nuke" I have an instant nostalgic memory blast to the 1990s with PHP-Nuke [22:07:42] (03CR) 10Mooeypoo: [C: 032] Add README pointing to Extension:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260850 (https://phabricator.wikimedia.org/T65125) (owner: 10Mattflaschen) [22:11:20] (03Merged) 10jenkins-bot: Add README pointing to Extension:Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260850 (https://phabricator.wikimedia.org/T65125) (owner: 10Mattflaschen) [22:14:42] (03CR) 10Mooeypoo: [C: 04-1] "There's a small issue to solve now, though. With this fix, we get the blue-dot "help" message for the link inspector, but when it opens, t" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258521 (owner: 10Esanders) [22:26:05] (03PS1) 10Mattflaschen: Add script to populate rev_content_model for $wgFlowOccupyPages [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/260869 (https://phabricator.wikimedia.org/T105574) [22:30:07] (03CR) 10jenkins-bot: [V: 04-1] Add script to populate rev_content_model for $wgFlowOccupyPages [extensions/Flow] (REL1_25) - 10https://gerrit.wikimedia.org/r/260869 (https://phabricator.wikimedia.org/T105574) (owner: 10Mattflaschen) [22:31:17] legoktm, do wikis have some "wiki name" variable that is local? [22:31:34] wfWikiID()? that's the database name [22:31:37] They should, I imagine? en.wikipedia.org is "enwiki" in the dbname, but something calls it "English Wikipedia" in the titles? [22:31:43] oh, $wgSitename I think? [22:31:46] no, a title they're using locally [22:31:47] hm [22:31:52] Is this available in the API ? [22:32:26] https://en.wikipedia.org/w/api.php?action=query&meta=siteinfo "sitename" [22:32:33] but that's just "Wikipedia" [22:33:30] 3Collaboration-Team-Current, 10Echo, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1902420 (10Mooeypoo) Okay, after quite a bit of research and experimentation, I have a few things to report, here, that we need to make a decision over. 1. U... [22:33:50] legoktm, hm. Yeah, but I just realized that it doesn't help me, since it's localized. [22:33:53] thanks, though. [22:35:59] mooeypoo: what are you looking for? [22:36:20] legoktm, see that ticket https://phabricator.wikimedia.org/T121936#1902420 [22:36:25] yeah, reading :) [22:36:36] we're trying to figure out a way to write, instead of "enwiki" or "hewiki" or whatever, the actual human-readable name [22:36:46] which is a good point, I'm just not entirely sure how we can properly do it. [22:37:03] Projects are fine. "Wikibooks" etc, they're available + translateable. But individual wiki names, meh. [22:37:20] I can't believe we don't have a friggin list of all Wikipedia language/name/titles with their translations. [22:37:22] sounds so useful [22:37:33] can we create a "$1 Wikipedia" message and add the language name as a parameter? [22:37:41] No, because "Wikipedia" is localized too [22:37:43] Hrm, what is Wikibase doing [22:38:26] Oh, you mean languages? sure, I guess. We can do that, but then I need to translate between wiki's dbname (enwiki) to its language code (en) so I can get the language itself (English) [22:38:27] https://www.wikidata.org/wiki/Q42 sitename and raw language code [22:38:31] AND it has to be translateable [22:38:45] going from enwiki -> "en" is pretty doable [22:39:03] sure, but I don't know if all dbnames are this easy [22:39:09] uh [22:39:22] why are 'bar' and 'bg' and some other language codes "Doublas Adams" ? [22:39:55] As in, "bar" is bavarian [22:40:40] legoktm, eh, I'm not seeing what I need there... what am I missing? [22:40:53] language code => language name (translateable) [22:41:49] I am starting to think we should just add our own messages to Wikimedia Messages for the wikis. I think mobile had the same problem, and it strikes me as something we really should have in general for our projects. This is way more complicated than it should be. [22:44:28] do you want to add a message for every single wiki? or one per family? [22:44:56] what do you mean "Family" ? [22:45:02] Project? [22:45:39] family = Wikipedia/Wiktionary/etc. [22:45:56] We already have those, https://github.com/wikimedia/mediawiki-extensions-WikimediaMessages/blob/master/i18n/wikimedia/en.json#L175-L191 [22:46:20] That doesn't solve the issue of what to display in a cross-wiki bundle where your notifications are from Spanish Wiki, English Wiki and Arabic Wiki or something [22:47:15] And CLDR's database is insane. We might as well query it. [22:51:39] Hm. This is tricksy. [22:53:47] Also, I am not entirely sure that the language codes are completely enough. I think there are several Wikis that actually contain and work with *more than one* language code. [22:53:53] But I guess we can have some fallback for those. [22:54:27] Also, I think language is the most common way to separate between the wikis anyways. [23:04:58] ok, I'm off to spend the last evening in this vacation with parental units. Have a great holiday, everyone. [23:07:23] 3Collaboration-Team-Current, 10Echo, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1902569 (10Mooeypoo) Related, Mobile has been dealing with a related issue of translating language code to language names in various languages. {T121128} [23:13:14] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1902596 (10violetto) >>! In T121923#1900411, @Pginer-WMF wrote: >>>! In T121923#... [23:33:00] 3Collaboration-Team-Current, 10Echo, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1902666 (10Mattflaschen) >>! In T121936#1902420, @Mooeypoo wrote: > 2. CLDR, however, may be our solution here. I am still investigating how to utilize it pr... [23:33:32] 3Collaboration-Team-Current, 10Echo, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1902667 (10Mattflaschen) There are few enough multilingual wikis (Commons, Meta, etc.) we can probably just hard-code a list if there isn't a better way already. [23:37:04] 3Collaboration-Team-Current, 10Echo, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1902680 (10Mattflaschen) Thankfully, the mockup has "Wikipedia - Spanish", not "Spanish Wikipedia", because I'm not sure how to do the second one without a ma... [23:43:46] 3Collaboration-Team-Current, 10Echo: Make page titles bold in notifications - https://phabricator.wikimedia.org/T121724#1902731 (10Mattflaschen) >>! In T121724#1900395, @Pginer-WMF wrote: > So the feedback I'm looking for is: at which point in the examples above the bold starts becoming annoying or of little h... [23:45:12] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#1902733 (10jmatazzoni) I think Pau's messaging above is on the right track. Here are some edits and variations: - "Extended" is more about making... [23:46:20] 3Collaboration-Team-Current, 10Echo, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1902744 (10Reedy) And "Wikipedia - Spanish" just looks stupid. We don't call it that anywhere. And we shouldn't start now. You'll end up annoying people when... [23:54:07] 3Collaboration-Team-Current, 10Echo, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1902782 (10Reedy) ``` > $names = LanguageNames::getNames( 'en' ); > var_dump( $names['de'] ); string(6) "German" ``` [23:55:31] (03CR) 10Mattflaschen: [C: 032] Log the expand action of a notification group item [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260772 (https://phabricator.wikimedia.org/T121945) (owner: 10Mooeypoo) [23:57:43] Getting dinner then heading home. [23:57:47] See you later.