[00:01:31] with .isEditing, the transition works as expected for 'edit source'. [00:01:51] just can't get the VE part to do anything. [00:02:13] ragesoss, you're missing listenForMwHooks from firsteditve. [00:02:44] 've.activationComplete' means "tell me when VE is done loading" [00:03:06] "ve.toolbarSaveButton.stateChanged" means, "Tell me when the VE save button changes state" (i.e. goes from enabled to disabled or vice versa). [00:03:26] I just tested firsteditve in production. Seems to still work right. [00:04:36] matt_flaschen: thanks. I was assuming that those were somehow only necessary for non-on-wiki tours. [00:05:24] ok I'm off for the day. See you guys tomorrow! [00:07:03] (03PS5) 10Sn1per: Reload if board is new [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260226 (https://phabricator.wikimedia.org/T117837) [00:08:30] mooey|away, have a good night. [00:13:53] matt_flaschen: okay, that got it working with .isEditing, after ve loading completes... [00:14:14] but .isVisualEditorOpen and .isEditingWithVisualEditor don't work for me still. [00:23:55] ragesoss, that's weird. isEditing is just: [00:24:08] isEditingWithWikitext OR isEditingWithVisualEditor [00:24:31] So I don't know why isEditingWithVisualEditor would be false, but isEditing true (unless it wrongly thinks it's in wikitext editing). [00:28:22] 6Collaboration-Team-Backlog, 10Flow: [Spike] Changing the displayed name, in Flow - https://phabricator.wikimedia.org/T90055#1896665 (10Quiddity) >>! In T90055#1893133, @Peteforsyth wrote: > It's my understanding that bugs entered here are supposed to have consensus first -- rather than generating consensus he... [00:32:14] thanks matt_flaschen [00:32:52] legoktm, no problem, thank you. [00:49:11] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1896705 (10jmatazzoni) I'd like to help but not sure a) about button styles and b) what exactly the error message is meant... [01:07:12] 6Collaboration-Team-Backlog, 10Flow: [Spike] Changing the displayed name, in Flow - https://phabricator.wikimedia.org/T90055#1896768 (10Peteforsyth) Absolutely helps, Quiddity -- thanks. And I'm glad to hear that WMF product dev process aims to document all this stuff better. Every time I ask about something l... [01:11:52] 3Collaboration-Team-Current, 10Echo: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1896778 (10jmatazzoni) Can I back up a step here? I'd like to understand how you get bundled notifications from multiple wikis. My understanding was that notifications are bundled only if they... [01:17:00] One of the things I applied for at FOSDEM was to organize our (MediaWiki's) stand presence. [01:17:16] The stand has been accepted. :) Not really a huge surprise, but will be nice to help run this. [01:17:33] woo! awesome. :) [01:26:05] 3Collaboration-Team-Current, 10Echo: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1896805 (10Mooeypoo) Internal bundles are as you say -- bundled by topic/page/post. Cross-wiki bundle is a single bundle that contains all your notifications from external wikis. It may have "... [01:28:37] 3Collaboration-Team-Current, 10Echo: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1896811 (10Mooeypoo) There it is: {T114350} Notice the design of the bundle with notifications from "Commons" and "Wikipedia - Spanish" (The third image from the top) [01:38:21] 3Collaboration-Team-Current, 10Echo: Flow posts on one's own user talk page should use a notification more like edit-user-talk - https://phabricator.wikimedia.org/T121663#1896823 (10jmatazzoni) **SPEC FOR NEW NOTIFICATION CATEGORY** To address the concerns raised in this ticket, we propose a new category of Fl... [01:39:33] Niharika et al, as promised (https://www.youtube.com/watch?v=IHdHhECHOe0) (people from my coworking place, including me, singing Jingle Bells parody). [02:13:59] phpstorm finished cloning mw over sftp! moment of truth [02:50:40] 3Collaboration-Team-Current, 10Flow: ref_target should be not null - https://phabricator.wikimedia.org/T122111#1896903 (10Mattflaschen) 3NEW [02:50:47] 3Collaboration-Team-Current, 10Flow: ref_target should be not null - https://phabricator.wikimedia.org/T122111#1896912 (10Mattflaschen) [02:51:18] 3Collaboration-Team-Current, 10Flow: ref_target should be not null - https://phabricator.wikimedia.org/T122111#1896903 (10Mattflaschen) This needs a simple patch from our side. [02:56:14] 3Collaboration-Team-Current, 10Flow, 10DBA, 7Blocked-on-schema-change, and 2 others: Make ref_id of flow_wiki_ref and flow_ext_ref not null and PK (DBA phase 2) - https://phabricator.wikimedia.org/T117787#1896918 (10Mattflaschen) >>! In T117787#1887263, @jcrespo wrote: > Please check the current schema to... [02:58:28] 3Collaboration-Team-Current, 10Flow: ref_target should be not null - https://phabricator.wikimedia.org/T122111#1896921 (10Mattflaschen) I checked, and there are no violations of this in production: ``` mysql:research@s2-analytics-slave [officewiki]> SELECT * FROM flow_ext_ref WHERE ref_target IS NULL; Empty s... [02:59:31] 3Collaboration-Team-Current, 10Flow: ref_target should be NOT NULL - https://phabricator.wikimedia.org/T122111#1896922 (10Mattflaschen) [03:51:40] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-General-or-Unknown, 7Technical-Debt: Get rid of LinksUpdate::setTriggeringUser() hacks - https://phabricator.wikimedia.org/T122113#1896981 (10Legoktm) 3NEW [06:35:47] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, and 3 others: Notify translators about new personalised suggestions being available based on their recently published translation - https://phabricator.wikimedia.org/T119939#1897116 (10santhosh) [08:10:39] 3Collaboration-Team-Current, 10Echo: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1897156 (10Catrope) >>! In T121930#1895292, @Mooeypoo wrote: > After double-checking the code, this is the way things behave right now. Individual sub-items in cross-wiki notifications are mark... [10:23:49] 6Collaboration-Team-Backlog, 10Flow: Global preferences concerning talk pages indexation are not respected by Flow - https://phabricator.wikimedia.org/T122119#1897283 (10Trizek-WMF) 3NEW [11:38:28] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: ability to show notification about new messages to user between edits - https://phabricator.wikimedia.org/T47285#1897383 (10matej_suchanek) [11:40:25] 6Collaboration-Team-Backlog, 10Echo, 6Security-Team: Send echo notification to user of how many failed logins there was since last successful login - https://phabricator.wikimedia.org/T122123#1897395 (10Reedy) [11:46:22] 3Collaboration-Team-Current, 10Echo: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1897419 (10Pginer-WMF) With cross-wiki notifications we have notifications from other wikis represented in a group (or bundle). The bundle represents that group of notifications. If we provide... [14:24:13] (03CR) 10Sbisson: [C: 032] Remove read item from counter after it was actually marked as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260511 (https://phabricator.wikimedia.org/T122087) (owner: 10Mooeypoo) [14:28:07] (03Merged) 10jenkins-bot: Remove read item from counter after it was actually marked as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260511 (https://phabricator.wikimedia.org/T122087) (owner: 10Mooeypoo) [14:42:25] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1898334 (10SBisson) I know the message was already there and not changed as part of this ticket/patch but I just saw it fo... [14:43:13] (03CR) 10Sbisson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [14:45:56] (03CR) 10Sbisson: [C: 032] Make notification body text lighter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [14:47:26] 3Collaboration-Team-Current, 10Echo: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#1898336 (10SBisson) a:3SBisson [14:50:35] (03Merged) 10jenkins-bot: Make notification body text lighter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [14:57:34] 6Collaboration-Team-Backlog, 10Flow: Can not undelete flow board at test2 - https://phabricator.wikimedia.org/T122211#1898352 (10Luke081515) 3NEW [14:57:50] 6Collaboration-Team-Backlog, 10Flow: Can not undelete flow board at test2 - https://phabricator.wikimedia.org/T122211#1898360 (10Luke081515) The page is not needed, so the undeletion is not urgent. [15:01:14] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1898363 (10Mooeypoo) Yeah, I tend to agree with you both, but I think that if we do that, we should change the current mes... [15:13:43] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison, 7Documentation, 7Tracking: Create a general public documentation for Flow - https://phabricator.wikimedia.org/T111367#1898385 (10Trizek-WMF) [15:59:13] (03PS1) 10Sbisson: Add agent link to most notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260587 (https://phabricator.wikimedia.org/T121737) [15:59:43] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#1898415 (10SBisson) [16:01:56] (03PS1) 10Sbisson: Add agent link to most Flow notifications [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260589 (https://phabricator.wikimedia.org/T121737) [16:03:22] (03PS1) 10Sbisson: Add agent link to all Thanks notifications [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260590 (https://phabricator.wikimedia.org/T121737) [16:04:56] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#1898425 (10SBisson) [16:13:42] (03PS1) 10Matthias Mullie: Use UTC timestamps in flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260591 (https://phabricator.wikimedia.org/T121813) [16:13:52] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Relative timestamps in notification panel are wrong - https://phabricator.wikimedia.org/T121813#1898443 (10matthiasmullie) a:3matthiasmullie [16:14:25] stephanebisson, sanity check for a moment. The "you must login" message came from this patch: https://gerrit.wikimedia.org/r/#/c/257661/4 [16:14:52] It makes sense to add the more "nicer" message you and jmatazzoni__ talked about (plus the login link) to it, rather than create another one, right? [16:15:59] changing the existing message instead of creating a new one makes sense to me [16:16:08] We're showing this to a non-logged-in user in Special:Notifications, I think it probably makes sense to do the same message as in the popup. I'm just trying to see that I'm not missing some special behavior here. [16:16:17] yeah just verifying [16:16:19] thanks [16:16:51] We still need to decide what to show if a user "updates" the popup, but that's a different issue [16:19:14] (03PS1) 10Sbisson: Add agent link to all PageTriage notifications [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/260594 (https://phabricator.wikimedia.org/T121737) [16:19:40] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#1898451 (10SBisson) [16:22:44] hm. legoktm maybe you know? Is there a significant difference in i18n message between writing something like "Please log in to see your notifications. Visit the [[Special:UserLogin login page]] to proceed." (where that link is 'hard coded' because it's a special page anyways) and writing "Visit the [$2 log in] page to proceed" and handing that link with a parameter? [16:23:09] the message "echo-anon" does the latter (with the parameter) but this is a standard special page... isn't it easier to wikitextify it? [16:24:24] Actually, we're not using echo-anon message anywhere. Meh. [16:29:53] mlitn, thank you for the timestamp commit, I got so confused yesterday. There are timestamps also in the email batch formatter and other places... those don't affect anything? [16:30:44] I didn’t check those ^^ [16:30:50] only checked Special:Notifications [16:31:08] but I assume emails won’t have any “x time ago” things probably :) [16:31:59] mooeypoo: are special pages url translated? [16:32:56] stephanebisson, they can be, but the original Special:Whatever is always true (is forwarded) as far as I know. [16:33:02] But that's a good point. [16:33:39] even if it redirects, you still see the url when you hover over the link [16:34:02] but I don't know if those links are usually translated [16:34:22] mlitn, there are such weird things with timestamps, though.. in EmailBatch.php line #80, for instance. [16:34:24] $nextBatch = wfTimestamp( TS_UNIX, $userLastBatch ) + $userEmailSetting * 20 * 60 * 60; [16:34:24] if ( $enforceFrequency && wfTimestamp( TS_MW, $nextBatch ) > wfTimestampNow() ) { [16:34:24] return false; [16:34:24] } [16:34:38] TS_UNIX in one, TS_MW in another, comparing to "now"... etc. [16:35:08] I just want to make sure we're consistent, the timestamp issue struck me as inherently confusing. *But* admittedly I have little experience with the php timestamp creation. Not sure. [16:35:19] they don't seem to be, at least they are not when I use ?uselang=fr [16:35:35] stephanebisson, no, they're not translated inthe UI but they are localized for wikis [16:36:01] Hebrew wiki, for instance, has מיוחד:כניסה_לחשבון [16:36:19] indeed, I just checked fr.wp [16:36:21] And Special:UserLogin redirects there [16:36:26] mooeypoo: what happens in these lines seems correct (2nd argument can be whatever format, it’ll be recognized & formatted to 1st argument - defaulting to TS_MW) [16:36:33] but it’s indeed confusing to say the least ^^ [16:36:34] You have a point, though. We should probably use the localized version. [16:36:45] I’ll see if I can clean that up a bit more [16:36:57] mlitn, awesome, yeah, I just wanted to make sure. Thanks for taking that up! [16:37:11] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#1898485 (10SBisson) [16:40:03] stephanebisson, meh, I'm not sure there's a clear way of getting the localized name of a special page in Javascript :( [16:40:13] geez, the docs are so horrible [16:40:48] hm. Title object. Come here, title object. Work with me. [17:11:41] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1898568 (10jmatazzoni) I like SBisson's version. Please log in to see your notifications. [17:23:33] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1898610 (10Pginer-WMF) I agree with @SBisson, I'd prefer a positive message. I'd suggest turning the background of the i... [17:50:13] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1898660 (10Mooeypoo) Perfect, I'll work on that. My initial plan to unify the messages failed; the original message I saw... [18:34:17] mooeypoo: are you joining standup? [18:34:41] sbisson-away, didn't we say it's at 10:45 ? [18:35:00] mooeypoo: we went back to 10:30 [18:35:21] oh, oops, okay, I'm joining [18:35:55] (03PS2) 10Mooeypoo: Display readable API error message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260495 (https://phabricator.wikimedia.org/T121923) [18:35:58] legoktm: standup? [18:42:54] 6Collaboration-Team-Backlog, 10Echo: "Your user rights have changed on Wikipedia" e-mail notification needs to tell me which language Wikipedia this message came from - https://phabricator.wikimedia.org/T122229#1898814 (10Whatamidoing-WMF) 3NEW [18:50:42] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#1898836 (10SBisson) [18:59:08] 3Collaboration-Team-Current, 10Echo: Put email subject in notification body of emailuser notifications - https://phabricator.wikimedia.org/T121831#1898849 (10SBisson) It doesn't seem to be stored but it's available at `Echo/Hooks.php:1019` [19:33:15] 3Collaboration-Team-Current, 10Echo: Tweak page-linked notification - https://phabricator.wikimedia.org/T121812#1898897 (10SBisson) a:3SBisson [19:50:10] 3Collaboration-Team-Current, 10Echo: Tweak page-linked notification - https://phabricator.wikimedia.org/T121812#1898934 (10SBisson) > Change the secondary link icon to modules/icons/link-blue.svg (currently this secondary link does not have an icon) Already using the right icon, thanks to https://gerrit.wikime... [19:52:49] (03PS1) 10Sbisson: Update page-linked notification text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260631 (https://phabricator.wikimedia.org/T121812) [21:07:28] (03PS2) 10Sbisson: Update page-linked notification text [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260631 (https://phabricator.wikimedia.org/T121812) [21:54:22] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): [betalabs] Persistent notifications - X mark as read does not work - https://phabricator.wikimedia.org/T122087#1899368 (10Etonkovidova) Checked the fix in betalabs. [21:56:45] 3Collaboration-Team-Current, 10Echo: Make page titles bold in notifications - https://phabricator.wikimedia.org/T121724#1899373 (10Mattflaschen) >>! In T121724#1890261, @Pginer-WMF wrote: >>>! In T121724#1886328, @Catrope wrote: >> @PGiner-WMF, @jmatazzoni: Thoughts as to whether this should be applied to user... [22:02:32] (03CR) 10Legoktm: [C: 04-1] Add agent link to most notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260587 (https://phabricator.wikimedia.org/T121737) (owner: 10Sbisson) [22:07:00] 6Collaboration-Team-Backlog, 10Echo, 6Security-Team: Send echo notification to user of how many failed logins there was since last successful login - https://phabricator.wikimedia.org/T122123#1899421 (10Bawolff) [22:08:25] (03CR) 10Mooeypoo: [C: 04-1] "In general it seems to work for the notification timestamps (though I can't check cross-wiki yet) -- but I think we should also change "se" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260591 (https://phabricator.wikimedia.org/T121813) (owner: 10Matthias Mullie) [22:10:53] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#1899434 (10He7d3r) I also noticed a few topics on my talk page now have "empty" comments: https://pt.wikibooks.org/wiki/Topic:Spjei8hugwd82xad Looking at the histo... [22:11:00] (03PS17) 10Mooeypoo: Add a demo special page to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254612 (https://phabricator.wikimedia.org/T115551) [22:22:16] Can I add a bulleted list to a Flow post? [22:22:24] That doesn't seem to be an option. [22:27:25] Deskana, https://www.mediawiki.org/wiki/Topic:Sv21oati3vvio5jm [22:27:30] Deskana, use wikitext. [22:27:45] mooeypoo: But I don't want toooooooooooooooo [22:27:59] mooeypoo: Thanks. :-) [22:28:01] Deskana, The VE options are reduced in Flow, but it should accept most wikitext [22:28:02] np :) [22:32:55] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1899502 (10Etonkovidova) Notes for testing (after the fix) - different browsers tests: - Login in to two different browse... [22:50:24] 6Collaboration-Team-Backlog, 10Flow: Flow does not follow $wgNamespaceRobotPolicies - https://phabricator.wikimedia.org/T122119#1899553 (10Mattflaschen) [22:50:39] 6Collaboration-Team-Backlog, 10Flow: Flow does not follow $wgNamespaceRobotPolicies - https://phabricator.wikimedia.org/T122119#1897283 (10Mattflaschen) [22:50:41] 6Collaboration-Team-Backlog, 10Flow: Support noindex - https://phabricator.wikimedia.org/T105322#1899555 (10Mattflaschen) [22:50:51] 6Collaboration-Team-Backlog, 10Flow: Support noindex - https://phabricator.wikimedia.org/T105322#1440969 (10Mattflaschen) [22:52:54] 6Collaboration-Team-Backlog, 10Flow: Have Flow support __INDEX__ and __NOINDEX__ per-page directives - https://phabricator.wikimedia.org/T122252#1899561 (10Mattflaschen) 3NEW [22:53:19] 6Collaboration-Team-Backlog, 10Flow: Support robot indexing policies (tracking) - https://phabricator.wikimedia.org/T105322#1899567 (10Mattflaschen) [23:04:09] 3Collaboration-Team-Current, 10Echo: Notifications- Revert and Alerts -design updates - https://phabricator.wikimedia.org/T122254#1899583 (10Etonkovidova) 3NEW a:3Pginer-WMF [23:05:08] 3Collaboration-Team-Current, 10Echo, 3Google-Code-In-2015, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Clarify link and revert icons on notifications - https://phabricator.wikimedia.org/T121624#1899592 (10Etonkovidova) The link icon usage. {F3136462} Filed {T122254} for design sign-off. [23:08:06] wow. I'm working on LESS stuff, and I broke everything... while trying to figure out where, I found out that the "width" css value of one of my divs is this: http://pastebin.com/pEDY29sL [23:08:14] ... which explains why everything broke. I'm actually impressed. [23:08:24] Anyways, turns out I forgot a ~ [23:08:27] ... yikes. [23:10:29] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1899596 (10Mattflaschen) >>! In T121923#1898568, @jmatazzoni wrote: > I like SBisson's version. > > Please log in to see... [23:16:21] 6Collaboration-Team-Backlog, 10Echo: "Your user rights have changed on Wikipedia" e-mail notification needs to tell me which language Wikipedia this message came from - https://phabricator.wikimedia.org/T122229#1899625 (10Mattflaschen) [23:17:46] (03PS1) 10Mooeypoo: Organize items in bundles with CSS table layout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260689 (https://phabricator.wikimedia.org/T121933) [23:18:00] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Timestamp in compressed notification appears in different places depending on its length - https://phabricator.wikimedia.org/T121933#1899632 (10Mooeypoo) a:3Mooeypoo [23:24:16] 3Collaboration-Team-Current, 10Echo: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1899654 (10Mooeypoo) @PGiner-WMF, I am having reservations with this method, especially due to this concern/scenario: What happens if you have 50 notifications in Commons and 20 in Spanish, an... [23:27:19] Ok, I'm off to the city for the evening. See you guys tomorrow! [23:27:59] (03CR) 10Mattflaschen: [C: 032] Replace EchoBatchRowUpdate with BatchRowUpdate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259406 (https://phabricator.wikimedia.org/T119253) (owner: 10Sn1per) [23:28:04] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1899669 (10Mooeypoo) The patch is ready for re-review according to @PGiner-WMF's design. [23:28:16] There. *now* i'm ready to leave... ;) see you guys tomorrow! [23:32:09] (03Merged) 10jenkins-bot: Replace EchoBatchRowUpdate with BatchRowUpdate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259406 (https://phabricator.wikimedia.org/T119253) (owner: 10Sn1per) [23:32:44] (03Merged) 10jenkins-bot: Replace EchoBatchRowUpdate with BatchRowUpdate [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259397 (https://phabricator.wikimedia.org/T119253) (owner: 10Sn1per) [23:33:30] OH-: :D [23:44:09] thanks matt_flaschen :) [23:44:16] legoktm: :P [23:45:06] No problem. :)