[02:35:32] 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI, 10UI-Standardization, 7WorkType-Maintenance: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1894174 (10dchan) To me, 大 stands out as somewhat arbitrary because it's hard to ignore its meaning of "big". To me... [09:51:26] 6Collaboration-Team-Backlog, 10Thanks, 7Easy, 3Google-Code-In-2015: Thanks: Take advantage of new parameters passed to HistoryRevisionTools and DiffRevisionTools hooks - https://phabricator.wikimedia.org/T121369#1894357 (10Mhutti1) a:3Mhutti1 [10:57:00] (03PS1) 10Mhutti1: HistoryRevisionTools and DiffRevisionTools no longer use $wgUser [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260342 (https://phabricator.wikimedia.org/T121369) [11:19:13] 6Collaboration-Team-Backlog, 10Flow, 10Continuous-Integration-Config, 6Release-Engineering-Team, 5MW-1.25-release: Flow (or tests) broken in REL1_25 - https://phabricator.wikimedia.org/T122025#1894507 (10hashar) Looks like some QUnit test is falling with: `'Could not find .flow-board', Object{0: {0: (03CR) 10Sbisson: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260168 (https://phabricator.wikimedia.org/T121954) (owner: 10Catrope) [16:08:05] mlitn, you around? I have a question that you may be able to help (I hope?) my MW-php is meh, and the docs are... uhm... lovely. [16:15:43] hm, I think I'm going to leave this ticket be for now and deal with others until I can discuss this with you and legoktm. Timestamps are a mess. :\ [16:16:18] heya stephanebisson [16:16:30] mooeypoo: allo [16:16:48] stephanebisson, I have good news... I think... ish [16:17:15] that doesn't sound convincing.. [16:17:26] Yes... [16:17:31] what's so great, good, maybe? [16:17:48] Hehe, seriously though -- I received a request from a fellow student in NYIT (my masters' school) that he wants to help and join MW projects, and his passion is QA and automation [16:18:15] I'm going to help him set up the base systems of vagrant, etc, and give him some background about mediawiki, but I was thinking of hijacking him to *us* [16:18:34] he wants to volunteer? [16:18:34] He apparently has 4+ years experience in a company in India that does browser testing and automation and he loves it [16:18:36] yep [16:18:47] sure [16:18:48] he eventually is looking for internships, but there's none to be had until the summer [16:18:52] so he wants to start volunteering [16:20:09] do you know how much time per week he wants to put? [16:21:16] I don't yet, he's a student, so probably not a whole lot, but he sounds extremely excited, so I'm hopeful [16:22:00] Even 5-6 hours a week will be god for us. I don't know yet. If it works out, we can see if we want to do something for Google Summer of Code with Flow or Echo browser tests and have him full time for that [16:22:34] cool [16:26:42] So I was wondering, do you have an idea for a beginner/intro task for him? [16:27:04] Do we have anything automation-related to have him play with to get his bearings? [16:28:22] mooeypoo: being able to run the browser tests locally and successfully is a good start [16:28:37] after that, increasing coverage on feature X or Y [16:29:40] 3Collaboration-Team-Current, 10Echo: Instrument opening of cross-wiki notification GroupItems - https://phabricator.wikimedia.org/T121945#1895014 (10Mooeypoo) There's another issue here, though -- we need to add the wiki name to the logging schema, so we can log where the bundle came from. I think we can star... [16:30:12] Ok, I'll have him set up first, then. Vagrant + running the tests, and we'll see after that. Good point. [16:35:51] (03CR) 10Sbisson: [C: 032] Add secondary link to Flow board for flow-thanks notifications [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260168 (https://phabricator.wikimedia.org/T121954) (owner: 10Catrope) [16:39:59] (03Merged) 10jenkins-bot: Add secondary link to Flow board for flow-thanks notifications [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260168 (https://phabricator.wikimedia.org/T121954) (owner: 10Catrope) [16:44:25] 6Collaboration-Team-Backlog, 10Flow: Tags for workflows -- ErikM's ideas - https://phabricator.wikimedia.org/T90069#1895055 (10He7d3r) [16:45:07] (03PS15) 10Mooeypoo: [wip] Add a demo special page to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254612 (https://phabricator.wikimedia.org/T115551) [16:52:11] 3Collaboration-Team-Current, 10Echo: Clicking a NotificationGroupItem should expand it - https://phabricator.wikimedia.org/T121929#1895075 (10Mooeypoo) a:3Mooeypoo [16:52:22] (03PS1) 10Mooeypoo: Expand group item on click [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260392 (https://phabricator.wikimedia.org/T121929) [17:05:03] (03PS16) 10Mooeypoo: Add a demo special page to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254612 (https://phabricator.wikimedia.org/T115551) [17:13:48] 3Collaboration-Team-Current, 10Echo: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1895193 (10Mooeypoo) As far as I remember (and please correct me if I remember wrong -- or perhaps we need to rethink this) here's what we agreed: 1. A bundle item (the group notification) is... [17:37:35] jmatazzoni__, what is your phabricator username? [17:42:10] 3Collaboration-Team-Current, 10Echo: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1895292 (10Mooeypoo) After double-checking the code, this is the way things behave right now. Individual sub-items in cross-wiki notifications are marked as read individually per their wiki, bu... [17:44:49] jmatazzoni__, Found it. [17:45:37] stephanebisson, did you manage to install several wikis in vagrant like RoanKattouw did? I can't test cross-wiki behavior without it, but I am having a hard time figurig this out. :\ [17:46:15] stephanebisson, I have the demo page that shows the behavior, but it has a bunch of operations that are mocked (especially in the API) so I can't actually test things... did RoanKattouw explain how he did it? I remember we talked about something with agrant, but then left for vacation. [17:46:29] mooeypoo: I stopped trying after mlitn picked up T119523, maybe he figured it out [17:46:39] * mooeypoo nods [17:47:10] mooeypoo: RoanKattouw said he did it manually but he didn't say how exactly [17:47:31] Yeah he said something about lots of duct tape, too [17:47:52] matt_flaschen said something about being able to create multiple wikis in vagrant out of the box, though.... iirc [17:47:55] mooeypoo: we really need that in vagrant, it's not fair to have everybody struggle independently to put it together [17:48:04] Yeah, agreed [17:48:15] vagrant should be able to deal with it, that's its purpose, generally speaking [17:48:24] not sure how to do it specifically with mediawiki, though. [17:48:42] let's check with matt at standup [17:48:47] * mooeypoo nods [17:49:41] stephanebisson, speaking of the demo page, I removed the [wip] from it. We should consider merging it, it's very useful for testing, and adding browser tests on top of it like we discussed. [17:49:51] * mooeypoo adds that to her standup list [17:50:22] mooeypoo: I'll look at it right away [17:52:11] awesome, thanks! [18:26:08] mooeypoo: what's up? [18:26:15] and welcome back :) [18:26:19] legoktm, yo [18:26:24] how are you feeling?? [18:28:08] stephanebisson, mooeypoo, yeah, I can definitely set that up. I think I may have already filed a task, I'll check. [18:28:27] matt_flaschen: that would be super useful [18:28:49] indeed [18:29:20] Yeah. I'm working on a different Vagrant thing right now (changing it to use separate DBs and users for regular and Flow), so I'm tempted stay in Vagrant mode and do it next, but I need to look at the board when I'm done the current thing. [18:29:31] To see i there's something more urgent I should really be doing. [18:31:49] matt_flaschen, if it helps, *I* consider it semi urgent because I can't test some of the cross-wiki notification bugs to fix :\ [18:32:03] (and obviously my subjective view on the board is what matters, duh) :p [18:32:22] mooeypoo: I'm doing alright :) [18:32:24] seriously, though, barring any other important bugs, this is really going to be helpful. [18:51:13] 3Collaboration-Team-Current, 10Echo: Notification panel updates remote seentime too aggressively - https://phabricator.wikimedia.org/T121928#1895451 (10Mooeypoo) a:3Mooeypoo [18:51:18] (03PS1) 10Mooeypoo: Only update seenTime in the local API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260410 (https://phabricator.wikimedia.org/T121928) [18:53:44] (03CR) 10Sbisson: Add a demo special page to Echo notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254612 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [19:15:16] (03CR) 10Florianschmidtwelzow: [C: 04-1] "One little thing :)" (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260342 (https://phabricator.wikimedia.org/T121369) (owner: 10Mhutti1) [19:17:00] (03PS2) 10Mhutti1: HistoryRevisionTools and DiffRevisionTools no longer use $wgUser [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260342 (https://phabricator.wikimedia.org/T121369) [19:24:10] (03CR) 10Florianschmidtwelzow: [C: 032] HistoryRevisionTools and DiffRevisionTools no longer use $wgUser [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260342 (https://phabricator.wikimedia.org/T121369) (owner: 10Mhutti1) [19:24:20] 6Collaboration-Team-Backlog, 10Thanks, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Thanks: Take advantage of new parameters passed to HistoryRevisionTools and DiffRevisionTools hooks - https://phabricator.wikimedia.org/T121369#1895540 (10Florian) 5Open>3Resolved [19:30:34] (03Merged) 10jenkins-bot: HistoryRevisionTools and DiffRevisionTools no longer use $wgUser [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/260342 (https://phabricator.wikimedia.org/T121369) (owner: 10Mhutti1) [19:35:59] 6Collaboration-Team-Backlog, 10Echo, 10OOjs-UI, 10UI-Standardization, 7WorkType-Maintenance: Don't use 大 ("big") character for translation icons - https://phabricator.wikimedia.org/T121976#1895582 (10violetto) Another user on github where the font repo is at has expressed the suggestion for 文 as well, wh... [20:05:40] 3Collaboration-Team-Current, 10Echo, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1895783 (10Mooeypoo) Is this something that exists in our databases, a "human readable" name for each wiki? If not, we will have to sort something out so the... [20:16:41] I'll be back in 20-30. [20:21:34] in 2030?? whew [20:21:50] ... okay that was a lame joke. I apologize. [20:23:57] 3Collaboration-Team-Current, 10Echo, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1895846 (10Reedy) >>! In T121936#1895783, @Mooeypoo wrote: > Is this something that exists in our databases, a "human readable" name for each wiki? If not, we... [20:40:48] 3Collaboration-Team-Current, 10Echo, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1895907 (10Mooeypoo) >>! In T121936#1895846, @Reedy wrote: > Closest first off to my knowledge is https://github.com/wikimedia/mediawiki-extensions-Wikimedia... [20:44:01] Anyone available for a GCI Flow review :) ? [20:46:47] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-Vagrant: Setup cross-wiki notifications in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T119999#1895934 (10Mooeypoo) As for what would be useful for testing, the ideal, I think would be: - More than 2 wikis (so, 3 at least) so we can verify that bund... [20:47:46] 6Collaboration-Team-Backlog, 10Flow, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: History tab should show as soon as board is created, before refresh - https://phabricator.wikimedia.org/T117837#1895944 (10Mattflaschen) >>! In T117837#1892465, @Sn1per wrote: > I found that it is not simple to grab the... [20:47:49] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-Vagrant: Setup cross-wiki notifications in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T119999#1895945 (10Mooeypoo) Also, I believe all three wikis must have some unified login (CentralAuth?) to work as cross-wiki notifications for the same user. [20:47:53] Hydronium: link? [20:48:10] matt_flaschen, I added my wishlist to your cross-wiki Vagrant task [20:48:19] https://gerrit.wikimedia.org/r/#/c/260227/ eh, but may be obsolete because refresh is a better idea [20:51:16] * Hydronium resurrects a dead patch [20:52:44] (03Restored) 10Sn1per: [WIP] Reload if board is new [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260226 (https://phabricator.wikimedia.org/T117837) (owner: 10Sn1per) [20:54:37] (03Abandoned) 10Sn1per: Client-side loading of History tab [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260227 (https://phabricator.wikimedia.org/T117837) (owner: 10Sn1per) [20:59:35] legoktm: 'page-linked' notifications are inserted with event_agent_id = NULL when executing in a deferred update, any idea why? [21:13:39] 3rd party dev question at https://www.mediawiki.org/wiki/Topic:Submkmfbawhqfkzj - "My topics disappear after update [...] upgrade my wiki from 1.25 to 1.26 [...] " [21:14:55] 3Collaboration-Team-Current, 10Echo, 3Google-Code-In-2015, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Clarify link and revert icons on notifications - https://phabricator.wikimedia.org/T121624#1896071 (10Etonkovidova) Reverted icon: {F3132991} {F3132994} Note: Presently cannot verify t... [21:25:19] legoktm: should the triggeringUser tracking be removed from RefreshLinksJob.php? https://gerrit.wikimedia.org/r/#/c/257166/1/includes/jobqueue/jobs/RefreshLinksJob.php [21:27:40] (03PS2) 10Sn1per: Reload if board is new [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260226 (https://phabricator.wikimedia.org/T117837) [21:28:08] is location.reload() suitable for reloading in Flow, or are there things that need to be unloaded etc. ? [21:29:20] (03PS3) 10Sn1per: Reload if board is new [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260226 (https://phabricator.wikimedia.org/T117837) [21:31:02] (03PS4) 10Sn1per: Reload if board is new [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260226 (https://phabricator.wikimedia.org/T117837) [21:35:43] 3Collaboration-Team-Current, 10Echo: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1896163 (10Mooeypoo) For clarification: there are actually two bugs that are described here: [object Object] appearing instead of a legible API... [21:35:50] 3Collaboration-Team-Current, 10Echo: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1896164 (10Mooeypoo) a:3Mooeypoo [21:39:23] jmatazzoni__, are you around for a question? [21:49:46] 3Collaboration-Team-Current, 10Echo: Instrument how frequently Special:Notifications is visited - https://phabricator.wikimedia.org/T121939#1896213 (10Mattflaschen) It would be a little tricky (Echo.alias.php is not yet in JSON form, and the namespace part (Especial) is separate from the other part (Notificati... [21:50:33] mooeypoo: what states we have for notification status - Seen (changes from blue to gray) and Read (X is clicked and counter number changed) - correct? [21:51:12] mooeypoo: is there somewhat different status after 'Mark all as read' ? [21:51:25] etonkovidova, yes [21:51:47] uhm... not really? Mark all as read should mark all notifications as both read and seen [21:51:56] there shouldn't be a case where a *read* notification is unseen [21:52:15] ... these states are the bane of my existence, btw. [21:55:23] mooeypoo: I know :) 'Mark all as read' works as usual but X does not - the status unread comes back after refreshing the page [21:57:07] etonkovidova, for bundles, or for everyhting? [21:57:39] for cross-wiki, I know -- I posted a few questions for pau and jmatazzoni__ in the ticket about that [21:57:46] if this happens to "regular" items, though, that's a bug [21:58:43] (03PS1) 10Mooeypoo: Display readable API error message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260495 (https://phabricator.wikimedia.org/T121923) [21:58:54] etonkovidova, https://phabricator.wikimedia.org/T121930 [21:59:14] etonkovidova, also see my concerns on that bug, I am not sure how things should work with cross-wiki "mark as read". I think we added this to tomorrow's discussion [21:59:22] mooeypoo: not for bundles - for ordinary edits on Flow pages [21:59:47] :\ meh [21:59:54] etonkovidova, that's a bug, then. [22:00:00] mooeypoo: yeah [22:00:43] etonkovidova, can you posta quick bug? [22:00:47] post a* [22:01:51] mooeypoo: I am seeing many pseudo-regression - no notifications about linking, no notifications from non-Flow page - it feels like transitory stuff :) [22:06:47] 3Collaboration-Team-Current, 10Echo: [betalabs] Persistent notifications - X mark as read does not work - https://phabricator.wikimedia.org/T122087#1896261 (10Etonkovidova) 3NEW [22:07:28] hmmm [22:07:38] but it shouldn't be transitory anymore, no? We've had this up for a week [22:08:09] brb [22:17:08] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Add filtering for unread notifications only to meta=notifications API - https://phabricator.wikimedia.org/T119890#1896317 (10Etonkovidova) Can be seen, e.g. https://en.wikipedia.beta.wmflabs.org/w/api.php?action... [22:23:09] late lunch. bbiab. [22:31:21] I can't figure out how to make a guided tour skip to the next step when the user opens VE. [22:39:44] ragesoss, did you try the approach the built-in tours use (https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/master/modules%2Ftours%2Ffirsteditve.js)? [22:40:00] ragesoss, I haven't tested, but it *should* work. If not, please file a bug and subscribe me. [22:40:07] I mean I tested it :), but not recently. [22:42:08] matt_flaschen: I've been playing around with some of those things, but I can't figure out how .transition is supposed to work with gt.defineTour and an array of steps. [22:43:14] ragesoss, not sure if you know, but gt.defineTour is deprecated. .transition is not supported with that. [22:43:36] matt_flaschen: that explains why I couldn't find it in the documentation! [22:43:58] ragesoss, yeah. It will show, but only if you go into the Show menu and check Deprecated. [22:44:50] ragesoss, is this for an extension, or for on-wiki (like Wikipedia Adventure)? [22:45:11] matt_flaschen: on-wiki [22:45:36] I'm trying to update the tours I build for student training to be for VE instead of edit source. [22:45:43] built* [22:47:06] ragesoss, right. I recommend you look at firsteditve, and consult https://www.mediawiki.org/wiki/Extension:GuidedTour/Write_an_on-wiki_tour . That should cover most of it, and you can consult the generated docs for any remaining nitty-gritty (https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/master/modules%2Ftours%2Ffirsteditve.js). [22:47:22] Whoops, generated docs are https://doc.wikimedia.org/GuidedTour/master/#!/api/mw.guidedTour [22:47:35] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1896411 (10Mooeypoo) @PGiner-WMF and @jmatazzoni, the current commit fixes the described issue -- if a user is logged out... [22:51:04] matt_flaschen: thanks. so it sounds like my best bet is to start them from scratch. [22:51:07] sigh. [22:51:40] oh javascript. why are you so horrible? [22:51:44] ragesoss, well, not exactly. You'll find a lot of stuff is the same. [22:53:36] 3Collaboration-Team-Current, 10Echo: [betalabs] Persistent notifications - X mark as read does not work - https://phabricator.wikimedia.org/T122087#1896428 (10Mooeypoo) a:3Mooeypoo [22:54:01] matt_flaschen, is it safe to assume this bug is "High" (if not unbreak now) ? https://phabricator.wikimedia.org/T122087 [22:54:19] I'm basically dropping the other bugs to deal with that one, just want to make sure. Sounds pretty urgent to me if that's what's happening consistently [22:54:35] ragesoss, it's mainly the shouldSkip (old) vs. transition (new) and handling of back/next that is different. Compare https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/6784fd66d3535e6582493c40fd7cf45e46bfbbd4/modules%2Ftours%2Ffirstedit.js (old API) to https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/6784fd66d3535e6582493c40fd7cf45e46bfbbd4/modules%2Ftours%2Ffirstedit.js (new API). [22:54:39] Ug. [22:55:43] Old (https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/6784fd66d3535e6582493c40fd7cf45e46bfbbd4/modules%2Ftours%2Ffirstedit.js), New (https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGuidedTour.git/e7e5cde0d55e0088094a91c09078ea5bf576244f/modules%2Ftours%2Ffirstedit.js) [22:56:30] mooeypoo, yes, Unbreak Now in my opinion. [22:56:37] * mooeypoo nods [22:56:49] 3Collaboration-Team-Current, 10Echo: [betalabs] Persistent notifications - X mark as read does not work - https://phabricator.wikimedia.org/T122087#1896433 (10Mooeypoo) p:5Triage>3Unbreak! [23:02:26] oy vey. I'm getting an error when I try to switch to VisualEditor in Flow... "TypeError: ve.init.mw.ArticleTarget is undefined"... anyone else encountered this? [23:03:27] hm, okay, I re-updated VisualEditor repo and it's fixed. This is weird ,though... I run "vagrant git-update" every day, it should've been updated. [23:03:47] mooeypoo, it's won't update a repo if you have a branch other than master checked out. That's usually what it is for me. [23:03:57] Yeah, but it was on master. [23:04:16] I think i may have had a temporary error today... vagrant didn't load properly, I had to 'vagrant reload' but I thought it was AFTER the git-update. maybe not. [23:09:13] hmm, i found quite a lot of tickets around messaging and communication inside the "Interface" project... [23:09:22] do we have a suitable project for that kind of stuff ? [23:09:48] "what Echo doesn't do, but sort of like echo" [23:10:49] thedj, sometimes MediaWiki-Email. Or Echo if it could realistically fit in Echo, or Extension requests. Not sure other than that. [23:11:10] ... wow this is a seriously sloppy bug. Question of the day: The API saves itself the trouble of marking an item as read by making sure, first, that there *are* unread items to mark. Riddle: What do you think will happen if, when the system recognizes an item that is to be marked unread, it first removes it from the count of unread items, and then asks the API to mark it? ONE GUESS. [23:11:19] * mooeypoo shakes her head and goes to fix her sloppy piece of code [23:12:09] matt_flaschen: hmm. [23:14:51] mooeypoo, does it work if there are more than one unread to start with? [23:15:38] thedj: mediawiki-general-or-unknown ;) [23:16:01] matt_flaschen, it does. [23:16:03] legoktm: tsstt. i'm cleaning up here, not further obfuscating :) [23:16:13] thedj, you mean like the youhavenewmessagesfromusers bugs? e.g. https://phabricator.wikimedia.org/T45728 and https://phabricator.wikimedia.org/T44313 [23:16:31] matt_flaschen, because my "oh so smart" test is so ... smart... :P [23:16:35] (and huge <3 for the cleanup, which i've seen some of in my incoming phab-mail :) [23:16:39] yes that's a large group of them [23:17:36] quiddity: if this doesn't get me at the top of the ticket closers this week, i guess i'll have to mass close an entire tag ;) [23:17:43] XD [23:17:59] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor: Talk page VE: Link inspector displays 'Edit' and 'delete'(oo-ui-buttonElement-framed) in different sizes - https://phabricator.wikimedia.org/T121987#1896480 (10Mattflaschen) [23:18:28] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-General-or-Unknown, 10MobileFrontend, and 3 others: Should be a standard way to access tablet browser width threshold - https://phabricator.wikimedia.org/T93675#1896488 (10Jdlrobson) a:3Jdlrobson [23:18:44] (03PS1) 10Mooeypoo: Remove read item from counter after it was actually marked as read [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260511 (https://phabricator.wikimedia.org/T122087) [23:18:49] 6Collaboration-Team-Backlog, 10Thanks, 10MediaWiki-extensions-AbuseFilter: Allow thanking users for edits to edit filters - https://phabricator.wikimedia.org/T121988#1896496 (10Mattflaschen) [23:18:51] 6Collaboration-Team-Backlog, 10Thanks: Allow thanks of log entry - https://phabricator.wikimedia.org/T60485#1896497 (10Mattflaschen) [23:22:19] 3Collaboration-Team-Current, 10Echo: Flow posts on one's own user talk page should use a notification more like edit-user-talk - https://phabricator.wikimedia.org/T121663#1896517 (10Mattflaschen) >>! In T121663#1893048, @pere_prlpz wrote: > The "you have a new message" notification has been always there for at... [23:28:05] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Interface: To create a new message displayed in reading mode for article's talk pages - https://phabricator.wikimedia.org/T19163#1896561 (10Quiddity) I think this is related to the planned work in https://www.mediawiki.org/wiki/Collaboration/Workflows and to s... [23:30:53] 3Collaboration-Team-Current, 10Flow, 10Continuous-Integration-Config, 6Release-Engineering-Team, 5MW-1.25-release: Flow (or tests) broken in REL1_25 - https://phabricator.wikimedia.org/T122025#1896566 (10Mattflaschen) [23:32:34] thedj, I can't see/think of any better #projects to list those under. I'd be inclined to just make a few tracking tasks, if they can be bucketed at all well. [23:33:44] matt_flaschen: can I override the > icon for 'next' on a tour? [23:34:32] I guess I'm late to the party, but the new style of defining a tour is much less painful. [23:36:35] nevermind, found it. [23:38:11] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-Vagrant: Setup cross-wiki notifications in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T119999#1896581 (10Mattflaschen) [23:45:09] ragesoss, thanks. :) Really glad to hear the new GuidedTour API works better for you. [23:46:31] 6Collaboration-Team-Backlog, 10Flow, 7Browser-Tests: More Flow no-JS browser tests - https://phabricator.wikimedia.org/T114729#1896619 (10Mattflaschen) [23:47:09] mooeypoo, idea for the NYIT student: "More Flow no-JS browser tests" (https://phabricator.wikimedia.org/T114729). A good way to get into our browser test environment IMHO, and will save me manual testing each week the deployment train runs. [23:47:23] ooh great [23:50:29] Hydronium, you can just reload. We dont have any kind of special "preserve unsaved changes as draft" teardown mode. Normally things are saved explicitly as the user goes (there are some bugs about saving text areas to localStorage, but we don't actually do it yet). [23:53:34] Ok, thanks. the patch should be ok, then [23:55:45] Checking to see if the history tab is present is a bit of a hack to see if the page needs reloading, but i figured it would be better than making an API call to check if the page exists [23:58:23] Hydronium, you can use mw.config.get( 'wgArticleId' ). If it's 0, the page didn't exist when first loaded. [23:58:35] matt_flaschen: I can't get any of the VE hooks to work. [23:58:50] matt_flaschen: https://en.wikipedia.org/wiki/MediaWiki:Guidedtour-tour-wikiedbebold.js [23:59:03] oh, that's a useful thing to know [23:59:33] I've tried .isVisualEditorOpen, .isEditingWithVisualEditor, and .isEditing.