[00:00:21] I think it's because you cherry-picked the dependency before merging the commit that depended on it [00:01:16] Yeah [00:05:46] 3Collaboration-Team-Current, 10Echo: Relative timestamps in notification panel are wrong - https://phabricator.wikimedia.org/T121813#1889389 (10Catrope) >>! In T121813#1889334, @Mooeypoo wrote: > I remember we were discussing the problem of timezones in relation to the "seenTime" issue, which is going to be ev... [00:19:36] (03CR) 10Catrope: [C: 032] Include Flow topics in Nuke [extensions/Flow] (wmf/1.27.0-wmf.9) - 10https://gerrit.wikimedia.org/r/259892 (https://phabricator.wikimedia.org/T115695) (owner: 10Mattflaschen) [00:23:53] (03Merged) 10jenkins-bot: Include Flow topics in Nuke [extensions/Flow] (wmf/1.27.0-wmf.9) - 10https://gerrit.wikimedia.org/r/259892 (https://phabricator.wikimedia.org/T115695) (owner: 10Mattflaschen) [00:35:36] (03PS1) 10Mattflaschen: Fix a database connection that was not cluster-aware in Nuke hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259924 (https://phabricator.wikimedia.org/T115695) [00:38:06] (03CR) 10Catrope: [C: 032] Fix a database connection that was not cluster-aware in Nuke hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259924 (https://phabricator.wikimedia.org/T115695) (owner: 10Mattflaschen) [00:40:24] (03PS1) 10Catrope: Fix a database connection that was not cluster-aware in Nuke hook [extensions/Flow] (wmf/1.27.0-wmf.9) - 10https://gerrit.wikimedia.org/r/259946 (https://phabricator.wikimedia.org/T115695) [00:40:31] (03CR) 10Catrope: [C: 032 V: 032] Fix a database connection that was not cluster-aware in Nuke hook [extensions/Flow] (wmf/1.27.0-wmf.9) - 10https://gerrit.wikimedia.org/r/259946 (https://phabricator.wikimedia.org/T115695) (owner: 10Catrope) [00:42:28] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Vagrant: Use custom $wgFlowCluster and $wgFlowDefaultWikiDb in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T121827#1889516 (10Mattflaschen) 3NEW [00:42:48] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Vagrant: Use custom $wgFlowCluster and $wgFlowDefaultWikiDb in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T121827#1889527 (10Mattflaschen) [00:50:24] (03PS1) 10Catrope: Revert "Fix a database connection that was not cluster-aware in Nuke hook" [extensions/Flow] (wmf/1.27.0-wmf.9) - 10https://gerrit.wikimedia.org/r/259956 [00:50:31] (03CR) 10Catrope: [C: 032 V: 032] Revert "Fix a database connection that was not cluster-aware in Nuke hook" [extensions/Flow] (wmf/1.27.0-wmf.9) - 10https://gerrit.wikimedia.org/r/259956 (owner: 10Catrope) [00:50:47] (03PS1) 10Catrope: Revert "Include Flow topics in Nuke" [extensions/Flow] (wmf/1.27.0-wmf.9) - 10https://gerrit.wikimedia.org/r/259957 [00:50:53] (03CR) 10Catrope: [C: 032 V: 032] Revert "Include Flow topics in Nuke" [extensions/Flow] (wmf/1.27.0-wmf.9) - 10https://gerrit.wikimedia.org/r/259957 (owner: 10Catrope) [00:53:46] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Fix Flow Nuke support for dedicated Flow DB - https://phabricator.wikimedia.org/T121828#1889553 (10Mattflaschen) 3NEW [00:53:49] 3Collaboration-Team-Current, 10Echo: Integrate cross-wiki notifications - https://phabricator.wikimedia.org/T121829#1889561 (10Catrope) 3NEW a:3matthiasmullie [00:54:02] (03PS10) 10Catrope: [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) [00:54:42] (03Merged) 10jenkins-bot: Fix a database connection that was not cluster-aware in Nuke hook [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259924 (https://phabricator.wikimedia.org/T115695) (owner: 10Mattflaschen) [00:55:03] 3Collaboration-Team-Current, 10Echo: Flow posts on one's own user talk page should use a notification more like edit-user-talk - https://phabricator.wikimedia.org/T121663#1889579 (10Catrope) p:5Triage>3Normal [00:55:14] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Vagrant: Use custom $wgFlowCluster and $wgFlowDefaultWikiDb in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T121827#1889581 (10Mattflaschen) a:3Mattflaschen [00:55:29] 3Collaboration-Team-Current, 10Echo: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1889583 (10Catrope) p:5Triage>3Normal [00:55:38] 3Collaboration-Team-Current, 10Echo: Add secondary link icon for "view changes" - https://phabricator.wikimedia.org/T121736#1889584 (10Catrope) p:5Triage>3High [00:56:04] 3Collaboration-Team-Current, 10Echo, 7Voice & Tone, 7WorkType-NewFunctionality: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#1889586 (10jmatazzoni) Her's my go at defining messaging for the scenarios described above:... [00:56:15] 3Collaboration-Team-Current, 10Echo, 3Google-Code-In-2015, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Clarify link and revert icons on notifications - https://phabricator.wikimedia.org/T121624#1889587 (10Catrope) a:3MtDu [00:59:58] 3Collaboration-Team-Current, 10Echo, 7Voice & Tone, 7WorkType-NewFunctionality: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#1889592 (10jmatazzoni) a:5jmatazzoni>3None [01:06:53] (03PS4) 10Sn1per: Replace EchoBatchRowUpdate with BatchRowUpdate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259406 (https://phabricator.wikimedia.org/T119253) [01:10:00] 3Collaboration-Team-Current, 10Echo: Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#1889627 (10Catrope) Places where `EchoDiscussionParser::getTextSnippet()` (which internally calls `Language::truncate()`) is currently used: - Secti... [01:10:09] (03PS5) 10Sn1per: Replace EchoBatchRowUpdate with BatchRowUpdate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259406 (https://phabricator.wikimedia.org/T119253) [01:11:44] marxarelli, you have a couple minutes for MediaWiki-Vagrant Puppet brainstorming? [01:11:57] (03PS6) 10Sn1per: Replace EchoBatchRowUpdate with BatchRowUpdate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259406 (https://phabricator.wikimedia.org/T119253) [01:12:02] 3Collaboration-Team-Current, 10Echo: Put email subject in notification body of emailuser notifications - https://phabricator.wikimedia.org/T121831#1889628 (10Catrope) 3NEW [01:13:06] matt_flaschen: sure thing [01:13:47] (03PS1) 10Catrope: Add a period at the end of notification-header-emailuser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259966 [01:13:55] marxarelli, so in prod we have extension1 (separate DB cluster), which is used for shared databases (e.g. wikishared, flowdb). [01:14:28] (03PS7) 10Sn1per: Replace EchoBatchRowUpdate with BatchRowUpdate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259406 (https://phabricator.wikimedia.org/T119253) [01:14:32] I want to implement that in MediaWiki-Vagrant. A role seems overkill, but I'm not sure where to put it. I was thinking maybe in the mediawiki module, then have Echo instantiate it (since Flow depends on Echo and both of those can use it among others). [01:14:46] 3Collaboration-Team-Current, 10Echo: Put email subject in notification body of emailuser notifications - https://phabricator.wikimedia.org/T121831#1889636 (10Legoktm) Does MediaWiki store this info anywhere else? I'm not sure what the privacy expectations are w/r to MediaWiki storing info about emails. [01:14:48] But there are actually other extensions that could use it as well, e.g. BounceHandler. [01:15:18] (03CR) 10Legoktm: [C: 032] Add a period at the end of notification-header-emailuser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259966 (owner: 10Catrope) [01:16:21] marxarelli, or maybe mediawiki::multiwiki, even though it might go unused, depending on your roles. [01:16:24] matt_flaschen: what does the MW config look like behind that. i'm not familiar enough with it [01:17:17] matt_flaschen: mw-vagrant uses multiwiki under the hood, so that might be the route to take [01:17:50] bd808 switched it to multiwiki a while back [01:17:58] * marxarelli throws bd808 under the bus [01:19:12] marxarelli, I think it's defined (so you can connect to the extension1 cluster) at https://git.wikimedia.org/blob/operations%2Fmediawiki-config.git/master/wmf-config%2Fdb-eqiad.php#L494 . [01:19:25] Then different extensions have config telling them to optionally use DBs in that cluster. [01:19:30] Yeah, I think multiwiki should work. [01:20:08] marxarelli, I meant that the extension1-equivalent might go unused, even if multiwiki is used. I think we can live with that, but if not might be another option. [01:20:28] If it's unused, it would only have minimal config enabling the "cluster", not any actual DBs. [01:21:04] matt_flaschen: got it [01:22:10] are there any other side effects to enabling sharding that we should be aware of in a dev environment? [01:25:56] marxarelli, I don't think so. I don't plan to spin up a separate MySQL instance, so there shouldn't be performance ramifications. I might use a separate user to make the test more realistic (so app code can't jump contexts improperly). [01:26:17] I.E. use a DB from the wrong connection. [01:26:46] matt_flaschen: a separate user might make sense [01:29:27] marxarelli, for that to work in both directions, MW also needs to not use root on the main DB. So I'll try to implement https://phabricator.wikimedia.org/T86373 too. [01:29:54] matt_flaschen: right. that shouldn't be too difficult to lock down though [01:30:51] marxarelli, yeah, shouldn't be too bad. https://phabricator.wikimedia.org/T121827 if you're curious. I'll link them together. [01:31:01] it's all parameterized/hiera-ized already [01:31:49] matt_flaschen: awesome. i'm about to head offline, but submit a patch and i'll review it tomorrow [01:32:08] feel free to ping me then as well if you want to go over it realtime [01:32:10] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Vagrant: Use custom $wgFlowCluster and $wgFlowDefaultWikiDb in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T121827#1889667 (10Mattflaschen) [01:32:19] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Vagrant: Use custom $wgFlowCluster and $wgFlowDefaultWikiDb in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T121827#1889516 (10Mattflaschen) [01:42:02] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (https://phabricator.wikimedia.org/T121829) (owner: 10Catrope) [02:15:36] Heading home [06:33:22] 3Collaboration-Team-Current, 10MediaWiki-Vagrant, 6Security: MediaWiki should not connect as root database user on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T86373#967279 (10Mattflaschen) [06:34:17] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Vagrant: Use custom $wgFlowCluster and $wgFlowDefaultWikiDb in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T121827#1889821 (10Mattflaschen) [06:34:18] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Fix Flow Nuke support for dedicated Flow DB - https://phabricator.wikimedia.org/T121828#1889820 (10Mattflaschen) [07:21:40] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Redirects, 6operations, and 2 others: Flow notification links on mobile point to desktop - https://phabricator.wikimedia.org/T107108#1889836 (10QuimGil) It looks like there has been a **regression**? Now both clicking the topic link and the rectangle will le... [08:46:11] 6Collaboration-Team-Backlog, 10Thanks, 10UI-Standardization, 7Easy, and 2 others: Convert Special:Thanks to use OOUI HTMLForm - https://phabricator.wikimedia.org/T118794#1889917 (10Glaisher) 5Open>3Resolved a:3Glaisher [12:06:53] 3Collaboration-Team-Current, 10Echo: Make page titles bold in notifications - https://phabricator.wikimedia.org/T121724#1890261 (10Pginer-WMF) >>! In T121724#1886328, @Catrope wrote: > @PGiner-WMF, @jmatazzoni: Thoughts as to whether this should be applied to user names as well? We're planning to move user nam... [13:04:10] 6Collaboration-Team-Backlog, 10Echo: Notifications excessive right padding makes text to wrap unnecesarily - https://phabricator.wikimedia.org/T121859#1890288 (10Pginer-WMF) 3NEW [13:41:33] 3Collaboration-Team-Current, 10Flow: "You are not logged in..." warning is not displayed when a non-logged user edits a title - https://phabricator.wikimedia.org/T104252#1890315 (10SBisson) a:3SBisson [13:41:46] 3Collaboration-Team-Current, 10Flow: Inconsistent 'Cancel' button color for 'Edit title' and 'Edit post'/ 'Reply' - https://phabricator.wikimedia.org/T118427#1890318 (10SBisson) a:3SBisson [14:03:36] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke, 5Patch-For-Review, and 3 others: Add Flow support to Nuke - https://phabricator.wikimedia.org/T115695#1890346 (10Trizek-WMF) [14:13:39] (03CR) 10Sbisson: [C: 032] Add a period at the end of notification-header-emailuser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259966 (owner: 10Catrope) [14:14:21] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Fix Flow Nuke support for dedicated Flow DB - https://phabricator.wikimedia.org/T121828#1890368 (10SBisson) a:3SBisson [14:17:18] (03Merged) 10jenkins-bot: Add a period at the end of notification-header-emailuser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259966 (owner: 10Catrope) [14:19:11] (03CR) 10Sbisson: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259880 (owner: 10Catrope) [14:29:12] (03PS1) 10Sbisson: [WIP] Various fixes to edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) [14:32:04] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Various fixes to edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [14:56:01] (03PS2) 10Sbisson: [WIP] Various fixes to edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) [14:59:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Various fixes to edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [15:05:23] (03PS3) 10Sbisson: [WIP] Various fixes to edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) [16:49:12] (03CR) 10Anomie: "Missing i18n." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258162 (https://phabricator.wikimedia.org/T119890) (owner: 10Matthias Mullie) [17:32:08] (03PS1) 10Anomie: Remove deprecated API help methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260052 [17:32:13] (03PS1) 10Anomie: Flag API module as needing a token [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/260055 [17:32:16] (03PS1) 10Anomie: Add missing i18n message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260056 [17:34:20] (03CR) 10Anomie: "i18n added in If2694de72a62e46cfdc29401c4d2d3756897c998, feel free to amend if you want to reword the message" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258162 (https://phabricator.wikimedia.org/T119890) (owner: 10Matthias Mullie) [17:36:55] 6Collaboration-Team-Backlog, 10Echo, 7Documentation: Create a page about the different notifications you can receive (messages panel) - https://phabricator.wikimedia.org/T119730#1834187 (10Trizek-WMF) [18:04:51] (03CR) 10Jdlrobson: "bumppppppppppp ;-)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 (owner: 10Mooeypoo) [18:18:33] 6Collaboration-Team-Backlog, 10Flow: Link dialog doesn't autocomplete other flow thread names - https://phabricator.wikimedia.org/T121891#1891050 (10Aklapper) Hi @LuisV_WMF. For future reference, please try to associate at least one [[ https://phabricator.wikimedia.org/project/query/active/ | project ]] with t... [18:29:24] (03CR) 10Legoktm: [C: 032] Remove deprecated API help methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260052 (owner: 10Anomie) [18:29:39] (03CR) 10Legoktm: [C: 032] Add missing i18n message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260056 (owner: 10Anomie) [18:31:13] (03CR) 10Legoktm: [C: 032] Flag API module as needing a token [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/260055 (owner: 10Anomie) [18:34:50] legoktm: Meeting? [18:36:23] oops [18:38:34] (03Merged) 10jenkins-bot: Remove deprecated API help methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260052 (owner: 10Anomie) [18:38:37] (03Merged) 10jenkins-bot: Add missing i18n message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260056 (owner: 10Anomie) [18:38:41] (03Merged) 10jenkins-bot: Flag API module as needing a token [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/260055 (owner: 10Anomie) [18:43:27] 3Collaboration-Team-Current, 10Echo: Notifications excessive right padding makes text to wrap unnecesarily - https://phabricator.wikimedia.org/T121859#1891189 (10Catrope) [18:43:56] 3Collaboration-Team-Current, 10Echo: Notifications excessive right padding makes text to wrap unnecesarily - https://phabricator.wikimedia.org/T121859#1891195 (10Catrope) p:5Triage>3High This probably happened because an earlier version of the code used padding to make space for the X icon. [18:57:47] (03PS1) 10Catrope: Make notification body text lighter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 [19:14:04] (03CR) 10Legoktm: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259875 (owner: 10Mattflaschen) [19:14:37] (03CR) 10Legoktm: [C: 032] "Re-trigger jenkins" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259397 (https://phabricator.wikimedia.org/T119253) (owner: 10Sn1per) [19:15:05] (03CR) 10Legoktm: "Oh, missing dependency" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259397 (https://phabricator.wikimedia.org/T119253) (owner: 10Sn1per) [19:30:53] 6Collaboration-Team-Backlog, 10Thanks, 7Community-Wishlist-Survey: Add ability to thank anonymous/IP users - https://phabricator.wikimedia.org/T63022#1891338 (10RobLa-WMF) I think this would be awesome. Thanking an anonymous edit obviously couldn't work the same as thanking a logged-in account, but it would... [19:36:46] 6Collaboration-Team-Backlog, 10Thanks, 7Community-Wishlist-Survey: Add ability to thank anonymous/IP users - https://phabricator.wikimedia.org/T63022#1891353 (10Ricordisamoa) >>! In T63022#1891338, @RobLa-WMF wrote: > The way I could see this still being useful in practical terms is to have the "thanks" coun... [19:40:11] (03PS1) 10Catrope: Change topic-renamed primary link label from "View post"(?!?) to "View topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260063 [19:45:39] (03CR) 10Sbisson: [C: 032] Change topic-renamed primary link label from "View post"(?!?) to "View topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260063 (owner: 10Catrope) [19:49:16] (03Merged) 10jenkins-bot: Change topic-renamed primary link label from "View post"(?!?) to "View topic" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260063 (owner: 10Catrope) [19:54:23] 3Collaboration-Team-Current, 10Echo: Notifications excessive right padding makes text to wrap unnecesarily - https://phabricator.wikimedia.org/T121859#1891378 (10Mooeypoo) >>! In T121859#1891195, @Catrope wrote: > This probably happened because an earlier version of the code used padding to make space for the... [19:58:10] 3Collaboration-Team-Current, 10Echo: Notifications excessive right padding makes text to wrap unnecesarily - https://phabricator.wikimedia.org/T121859#1891399 (10Catrope) >>! In T121859#1891378, @Mooeypoo wrote: >>>! In T121859#1891195, @Catrope wrote: >> This probably happened because an earlier version of th... [20:03:15] (03CR) 10Sbisson: "Which class does it affect exactly, and where is it set?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [20:17:52] 3Collaboration-Team-Current, 10Echo: Notifications excessive right padding makes text to wrap unnecesarily - https://phabricator.wikimedia.org/T121859#1891428 (10Mooeypoo) Actually, erase everything we both said -- I just noticed that this isn't the new notification design, it is the old 'unstructured' one tha... [20:40:21] (03PS1) 10Sbisson: Flow Nuke: remove join on user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260068 (https://phabricator.wikimedia.org/T121828) [20:44:04] (03PS2) 10Sbisson: Flow Nuke: remove join on user [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260068 (https://phabricator.wikimedia.org/T121828) [20:44:46] (03CR) 10Catrope: "It affects mw-echo-ui-notificationItemWidget-content-message-body , which is set by NotificationItemWidget on the div that contains the bo" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [20:46:55] (03CR) 10Mattflaschen: "I'll review and test this after I get the Vagrant stuff working." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260068 (https://phabricator.wikimedia.org/T121828) (owner: 10Sbisson) [20:50:53] (03CR) 10Sbisson: "Logical enough :) but I can't see the difference. What am I missing?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [20:53:07] (03CR) 10Catrope: "Not many notifications have a body, so you need to view one that does. Without this patch, the body text is the same color as the header t" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [20:54:10] (03CR) 10Catrope: "Re special page: good point. The current styling there is even more wrong, will fix." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [21:00:23] (03PS1) 10Catrope: Add mw-echo-payload class to body in Special:Notifications as well [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260074 [21:00:46] (03PS2) 10Catrope: Make notification body text lighter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 [21:02:53] (03CR) 10jenkins-bot: [V: 04-1] Make notification body text lighter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [21:03:11] (03CR) 10Sbisson: "This is the one that gets applied for me:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [21:04:50] (03CR) 10Catrope: "Ugh, right, I have a specificity problem :(" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [21:06:24] (03CR) 10Sbisson: "The colors could also be put into variables." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [21:07:39] (03PS3) 10Catrope: Make notification body text lighter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 [21:08:09] (03CR) 10Catrope: "PS3: Turned out I didn't have a specificity problem, just a failure-to-understand-scoping problem" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [21:08:23] (03CR) 10Catrope: "Yes, good point, I'll put them in variables" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [21:10:40] (03CR) 10jenkins-bot: [V: 04-1] Make notification body text lighter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [21:12:38] (03PS4) 10Sbisson: Various fixes to edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) [21:13:39] (03PS4) 10Catrope: Make notification body text lighter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 [21:16:00] (03CR) 10jenkins-bot: [V: 04-1] Various fixes to edit-title [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [21:16:07] (03CR) 10jenkins-bot: [V: 04-1] Make notification body text lighter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260058 (owner: 10Catrope) [21:16:37] Sigh, there are infrastructural CI issues it looks like [21:16:41] Everything's getting V-1ed [21:17:10] (03CR) 10Sbisson: "rm: cannot remove ‘/mnt/home/jenkins-deploy/tmpfs/jenkins-0/lessphp_805a13p17e8skww04swww4s0w48w00w.lesscache’: Permission denied" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [21:17:21] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [21:17:29] me too [21:18:41] I've reported this in #wikimedia-releng [21:20:55] (03PS1) 10Sbisson: Bring back edit-title to no-js mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260077 [21:23:23] (03CR) 10jenkins-bot: [V: 04-1] Bring back edit-title to no-js mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260077 (owner: 10Sbisson) [21:27:14] (03CR) 10Sbisson: [C: 032] Remove link from mention notification header [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259880 (owner: 10Catrope) [21:28:47] (03CR) 10Sbisson: "Do we can it payload or body?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260074 (owner: 10Catrope) [21:29:55] (03CR) 10Sbisson: "Do we CALL it payload or body?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260074 (owner: 10Catrope) [21:30:29] (03CR) 10jenkins-bot: [V: 04-1] Remove link from mention notification header [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259880 (owner: 10Catrope) [21:32:13] (03CR) 10Catrope: "payload is the old name (and already has CSS associated with it), body is the new name. Normally I'd say "yes, we should definitely rename" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260074 (owner: 10Catrope) [21:33:41] (03CR) 10Sbisson: [C: 032] "Sold. But let's keep that in mind when we redo special:notifications." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260074 (owner: 10Catrope) [21:33:46] (03CR) 10Catrope: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260006 (https://phabricator.wikimedia.org/T100851) (owner: 10Sbisson) [21:33:51] (03CR) 10Catrope: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/260077 (owner: 10Sbisson) [21:38:07] (03CR) 10jenkins-bot: [V: 04-1] Add mw-echo-payload class to body in Special:Notifications as well [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260074 (owner: 10Catrope) [21:38:53] (03CR) 10Catrope: [C: 032] "Jenkins failure was bogus:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260074 (owner: 10Catrope) [21:42:03] (03CR) 10jenkins-bot: [V: 04-1] Add mw-echo-payload class to body in Special:Notifications as well [extensions/Echo] - 10https://gerrit.wikimedia.org/r/260074 (owner: 10Catrope) [22:11:19] (03CR) 10Bartosz Dziewoński: "Needs manual rebase :(" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 (owner: 10Paladox) [22:15:46] marxarelli, I can't figure out why it isn't picking up mediawiki::wiki::db_host from hiera: https://gerrit.wikimedia.org/r/#/c/260097/ [22:15:50] It just uses '' from the class definition. [22:15:58] I want it to use 127.0.0.1 from hiera. [22:17:15] matt_flaschen: non-singleton resource parameters can't be assigned via hiera [22:17:40] i.e. resources defined as `define foo` won't pick up params from hiera [22:17:47] only classes [22:19:10] marxarelli, oh, thanks. So I guess I can call hiera() explicitly. [22:19:55] matt_flaschen: that will work technically, but it's highly discouraged [22:20:09] it's better to reference a class parameter as the default value, and set that up via hiera [22:20:28] e.g. the other parameters of mediawiki::wiki [22:20:46] db_user for example, references ::mediawiki::multiwiki::db_user [22:21:12] marxarelli, I thought I tried that, but I must have done something wrong. [22:21:16] which _is_ a class parameter and can be setup in hiera [22:22:04] Okay, i think I know what I did wrong before. [22:22:10] matt_flaschen: did you remember to implement the class parameter before specifying it in hiera? [22:22:35] puppet will hork if you don't [22:24:25] Yeah, i think that's what I missed before. [22:30:43] matt_flaschen: it's looking pretty good so far [22:32:11] if you want to expose the new mysql::db's user/pass that you're creating for flow, you'll have to encapsulate that in its own class as well [22:32:24] not sure that's necessary for what you're doing though [22:32:51] sorry, i meant *expose in hiera* [22:34:12] marxarelli, I might just put it in the role. [22:34:37] matt_flaschen: that works [22:34:52] I'm also going to combine them in one commit, since otherwise I still need to make sure the user can still access the Flow DB somehow, so I might as well just do it all. [22:35:16] * marxarelli nods [22:44:58] 3Collaboration-Team-Current, 10Echo: Show a useful error message when notification popup opens while the user is logged out - https://phabricator.wikimedia.org/T121923#1891777 (10Catrope) 3NEW [23:08:35] I'll be back on in about an hour and a half. [23:11:22] 3Collaboration-Team-Current, 10Echo: Notification panel updates remote seentime too aggressively - https://phabricator.wikimedia.org/T121928#1891855 (10Catrope) 3NEW [23:17:21] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2016-01-12_(1.27.0-wmf.10): Anonymous reply warning should be connected to the text area - https://phabricator.wikimedia.org/T119491#1891869 (10Etonkovidova) Checked in betalabs - checked with expanded board, with permalinks, and with seve... [23:18:20] RoanKattouw: matt_flaschen I am leaving now - will work on QA sign off column on Sat. [23:20:38] 3Collaboration-Team-Current, 10Echo: Clicking a NotificationGroupItem should expand it - https://phabricator.wikimedia.org/T121929#1891871 (10Catrope) 3NEW [23:29:31] 3Collaboration-Team-Current, 10Echo: Cross-wiki mark as read doesn't work - https://phabricator.wikimedia.org/T121930#1891883 (10Catrope) 3NEW [23:31:51] 3Collaboration-Team-Current, 10Echo: "Mark all as read" button completely ignores cross-wiki notification group item - https://phabricator.wikimedia.org/T121931#1891889 (10Catrope) 3NEW [23:40:26] 3Collaboration-Team-Current, 10Echo: "Mark all as read" button completely ignores cross-wiki notification group item - https://phabricator.wikimedia.org/T121931#1891916 (10Mooeypoo) Yes, we agreed (as I remember) that the "automatic" functions of mark as read (both the 'mark read as seen' and the 'mark all rea... [23:41:41] 3Collaboration-Team-Current, 10Echo: "Mark all as read" button completely ignores cross-wiki notification group item - https://phabricator.wikimedia.org/T121931#1891917 (10Catrope) 5Open>3declined a:3Catrope Makes sense to me. Let's say this is working as designed, unless and until @jmatazzoni, @PGiner-W... [23:41:50] 3Collaboration-Team-Current, 10Echo: "Mark all as read" button completely ignores cross-wiki notification group item - https://phabricator.wikimedia.org/T121931#1891921 (10Catrope) a:5Catrope>3None [23:44:36] 3Collaboration-Team-Current, 10Echo: "Mark all as read" button completely ignores cross-wiki notification group item - https://phabricator.wikimedia.org/T121931#1891925 (10Mooeypoo) Just to clarify -- when you have a *local* bundle, marking individual notifications inside it as "read" moves those notificaions... [23:46:20] 3Collaboration-Team-Current, 10Echo: Timestamp in compressed notification appears in different places depending on its length - https://phabricator.wikimedia.org/T121933#1891927 (10Catrope) 3NEW [23:48:08] 3Collaboration-Team-Current, 10Echo: Add "mark as read" as a deprioitized secondary action to every unread notification - https://phabricator.wikimedia.org/T121935#1891940 (10Catrope) 3NEW [23:48:29] 3Collaboration-Team-Current, 10Echo: Add "mark as read" as a deprioitized secondary action to every unread notification - https://phabricator.wikimedia.org/T121935#1891947 (10Catrope) a:3Pginer-WMF Assigning to Pau for clarification and icon assets. [23:52:47] 3Collaboration-Team-Current, 10Echo: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1891949 (10Catrope) 3NEW [23:54:45] 3Collaboration-Team-Current, 10Echo, 7I18n: Display human-readable wiki names for cross-wiki notifications - https://phabricator.wikimedia.org/T121936#1891966 (10Legoktm)