[00:03:32] (03PS3) 10MtDu: Use the double speech bubble icon in the Messages panel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259620 (https://phabricator.wikimedia.org/T119377) [00:05:15] (03CR) 10Mattflaschen: "We weren't originally going to do this, I don't think. We should discuss (unless Matthias and you already did)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259444 (https://phabricator.wikimedia.org/T109676) (owner: 10Catrope) [00:10:39] (03CR) 10Catrope: [C: 032] Use the double speech bubble icon in the Messages panel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259620 (https://phabricator.wikimedia.org/T119377) (owner: 10MtDu) [00:14:43] (03Merged) 10jenkins-bot: Use the double speech bubble icon in the Messages panel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259620 (https://phabricator.wikimedia.org/T119377) (owner: 10MtDu) [00:14:57] 3Collaboration-Team-Current, 10Flow, 10DBA, 5Patch-For-Review, and 2 others: Run maintenance/FlowPopulateRefId.php on all production wikis - https://phabricator.wikimedia.org/T117786#1886484 (10Mattflaschen) This is done on officewiki too: ``` mysql:research@s2-analytics-slave [officewiki]> select count(*... [00:16:42] 3Collaboration-Team-Current, 10Flow, 10DBA, 7Blocked-on-schema-change, and 2 others: Make ref_id of flow_wiki_ref and flow_ext_ref not null and PK (DBA phase 2) - https://phabricator.wikimedia.org/T117787#1886488 (10Mattflaschen) This needs to be done on officewiki too. Currently, that also looks ready:... [00:19:11] * quiddity gets groceries before the evening rush. bbl. [00:38:01] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Use the double speech bubble icon in the Messages panel - https://phabricator.wikimedia.org/T119377#1886562 (10Catrope) Hmm, I just realized that patch replaced both the big icon in the panel and also the small icon in t... [00:38:13] 3Collaboration-Team-Current, 10Echo, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Use the double speech bubble icon in the Messages panel - https://phabricator.wikimedia.org/T119377#1886564 (10Catrope) [00:38:30] 3Collaboration-Team-Current, 10Echo, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Use the double speech bubble icon in the Messages panel - https://phabricator.wikimedia.org/T119377#1886569 (10Catrope) a:3MtDu [00:45:03] 6Collaboration-Team-Backlog, 10Echo: Clarify notification icons - https://phabricator.wikimedia.org/T121735#1886585 (10Catrope) 3NEW [00:45:33] 6Collaboration-Team-Backlog, 10Echo: Clarify notification icons - https://phabricator.wikimedia.org/T121735#1886595 (10Catrope) a:3Pginer-WMF Assigning to Pau so he can upload the individual icons as and when they are ready. [00:45:44] 3Collaboration-Team-Current, 10Echo: Clarify notification icons - https://phabricator.wikimedia.org/T121735#1886597 (10Catrope) [00:46:45] (03CR) 10Catrope: [C: 032] Migrate MoodBar to the new way MW logs stuff [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258921 (owner: 10Mooeypoo) [00:46:51] (03PS4) 10Catrope: Add GENDER support for log entries [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258698 (https://phabricator.wikimedia.org/T45481) (owner: 10MtDu) [00:47:17] (03CR) 10Catrope: [C: 032] Add GENDER support for log entries [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258698 (https://phabricator.wikimedia.org/T45481) (owner: 10MtDu) [00:47:41] (03Merged) 10jenkins-bot: Migrate MoodBar to the new way MW logs stuff [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258921 (owner: 10Mooeypoo) [00:48:08] (03Merged) 10jenkins-bot: Add GENDER support for log entries [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258698 (https://phabricator.wikimedia.org/T45481) (owner: 10MtDu) [00:48:23] 3Collaboration-Team-Current, 10Echo, 7I18n: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#1886603 (10jmatazzoni) Below is my suggested language. Note that I'm recommending a colon followed by a capital letter after "changed." This reads well in English and conf... [00:49:00] legoktm: Would you happen to know why we sometimes need to require_once individual files in maintenance scripts, and when that is necessary? https://gerrit.wikimedia.org/r/#/c/259406/2/maintenance/FlowAddMissingModerationLogs.php [00:52:08] 3Collaboration-Team-Current, 10Echo, 7I18n: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#1886608 (10Catrope) a:5jmatazzoni>3None [00:52:30] 3Collaboration-Team-Current, 10Echo, 7I18n: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#1884917 (10Catrope) p:5Triage>3Normal [01:01:52] 3Collaboration-Team-Current, 10Echo: Add secondary link icon for "view changes" - https://phabricator.wikimedia.org/T121736#1886624 (10Catrope) 3NEW [01:02:29] 3Collaboration-Team-Current, 10Echo: Add secondary link icon for "view changes" - https://phabricator.wikimedia.org/T121736#1886633 (10Catrope) a:3Pginer-WMF Assigning to Pau so he can upload the icon assets when they're ready. [01:03:41] 3Collaboration-Team-Current, 10Echo: Clarify notification icons - https://phabricator.wikimedia.org/T121735#1886635 (10Catrope) [01:03:42] 3Collaboration-Team-Current, 10Echo: Clarify link and revert icons on notifications - https://phabricator.wikimedia.org/T121624#1886636 (10Catrope) [01:11:49] 3Collaboration-Team-Current, 10Echo: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#1886641 (10Catrope) 3NEW [01:12:01] 3Collaboration-Team-Current, 10Echo: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#1886648 (10Catrope) p:5Triage>3High [01:13:30] 3Collaboration-Team-Current, 10Echo: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#1886641 (10Catrope) [01:13:59] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-GuidedTour: Create a guided tour about Flow - https://phabricator.wikimedia.org/T112757#1886655 (10Mattflaschen) 5stalled>3Open Yes, I think so. [01:14:07] 3Collaboration-Team-Current, 10Echo: Clarify link and revert icons on notifications - https://phabricator.wikimedia.org/T121624#1886658 (10MtDu) Catrope. I'd be interested in doing this task as I just did a similar one. Would it be possible to import this into the GCI website? Thanks, MtDu [01:15:40] 3Collaboration-Team-Current, 10Echo: Clarify link and revert icons on notifications - https://phabricator.wikimedia.org/T121624#1886660 (10Catrope) >>! In T121624#1886658, @MtDu wrote: > Catrope. > I'd be interested in doing this task as I just did a similar one. Great! > Would it be possible to import this... [01:24:10] 3Collaboration-Team-Current, 10Echo, 7I18n: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#1886683 (10Catrope) Thanks for that copy, Joe. That also nicely takes care of removing the user name from the message, which we already wanted to do in light of {T121737}.... [01:24:21] 3Collaboration-Team-Current, 10Echo: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#1886641 (10Catrope) [01:24:22] 3Collaboration-Team-Current, 10Echo, 7I18n: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#1886685 (10Catrope) [01:45:06] 3Collaboration-Team-Current, 10Echo: Remove user names from some notification messages in favor of secondary link - https://phabricator.wikimedia.org/T121739#1886710 (10Catrope) 3NEW [01:45:17] 3Collaboration-Team-Current, 10Echo: Add secondary link for the agent to some notification types - https://phabricator.wikimedia.org/T121737#1886641 (10Catrope) [01:45:18] 3Collaboration-Team-Current, 10Echo: Remove user names from some notification messages in favor of secondary link - https://phabricator.wikimedia.org/T121739#1886720 (10Catrope) [01:46:00] 3Collaboration-Team-Current, 10Echo, 7I18n: Clean up lego message in user-rights notification - https://phabricator.wikimedia.org/T121661#1884917 (10Catrope) >>! In T121661#1886683, @Catrope wrote: > which we already wanted to do in light of {T121737} I meant {T121739} [01:46:28] 3Collaboration-Team-Current, 10Echo: Remove user names from some notification messages in favor of secondary link - https://phabricator.wikimedia.org/T121739#1886725 (10Catrope) p:5Triage>3Normal [03:29:14] 3Collaboration-Team-Current, 10Flow: Fix en:Wikipedia_talk:Flow/Developer_test_page - https://phabricator.wikimedia.org/T117812#1886780 (10Mattflaschen) >>! In T117812#1858309, @Mattflaschen wrote: > This will be easier if I get temporary admin access on my work account. > > My idea for this (if @Jdforrester-... [03:29:50] Better luck tomorrow, hopefully. [03:45:45] nod. [05:07:32] RoanKattouw_away: you have to do it if you reference the classes in a class Bar extends Foo type thing that gets parsed before the autoloader kicks in (require_once RUN_MAINT IF MAIN) [05:51:10] (03PS3) 10Sn1per: Replace EchoBatchRowUpdate with BatchRowUpdate [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259406 (https://phabricator.wikimedia.org/T119253) [05:51:43] (03CR) 10Sn1per: [C: 04-1] "WIP" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259406 (https://phabricator.wikimedia.org/T119253) (owner: 10Sn1per) [07:21:27] 3Collaboration-Team-Current, 10Echo, 3Google-Code-In-2015: Clarify link and revert icons on notifications - https://phabricator.wikimedia.org/T121624#1886937 (10Legoktm) Imported to the GCI site as: https://codein.withgoogle.com/dashboard/tasks/6515819940937728/ (should be published shortly) [08:05:38] 3Collaboration-Team-Current, 10Echo, 3Google-Code-In-2015: Clarify link and revert icons on notifications - https://phabricator.wikimedia.org/T121624#1886983 (10D3r1ck01) Will like to mentor this task. [09:51:36] 6Collaboration-Team-Backlog, 10Flow: If page content is a group of templates, talk page conversion to Flow does not archive the old content - https://phabricator.wikimedia.org/T116787#1887090 (10Trizek-WMF) 5Open>3Invalid a:3Trizek-WMF Thanks @Mattflaschen! This is normal behaviour, documentation in pro... [11:02:16] (03PS6) 10Matthias Mullie: Script to remove topics before a certain date [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) [11:02:35] (03CR) 10jenkins-bot: [V: 04-1] Script to remove topics before a certain date [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [11:13:44] (03PS7) 10Matthias Mullie: Script to remove topics before a certain date [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) [11:40:49] 3Collaboration-Team-Current, 10Flow, 10DBA, 7Blocked-on-schema-change, and 2 others: Make ref_id of flow_wiki_ref and flow_ext_ref not null and PK (DBA phase 2) - https://phabricator.wikimedia.org/T117787#1887263 (10jcrespo) Please check the current schema to validate the changes: ``` $ mysql -A -h s3-mas... [11:48:16] 3Collaboration-Team-Current, 10Echo: Flow posts on one's own user talk page should use a notification more like edit-user-talk - https://phabricator.wikimedia.org/T121663#1887281 (10Trizek-WMF) I use Flow on my volunteer talk page since July, and, when I have 5 notifications from Flow, I really appreciate to k... [11:49:26] 3Collaboration-Team-Current, 10Flow, 10DBA, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1887290 (10jcrespo) [11:49:27] 3Collaboration-Team-Current, 10Flow, 10DBA, 7Blocked-on-schema-change, and 2 others: Make ref_id of flow_wiki_ref and flow_ext_ref not null and PK (DBA phase 2) - https://phabricator.wikimedia.org/T117787#1887289 (10jcrespo) 5Open>3Resolved [12:02:57] 3Collaboration-Team-Current, 10Flow, 7Wikimedia-log-errors: Fail to load more topics above current topic - https://phabricator.wikimedia.org/T121644#1887312 (10jcrespo) I can see this error on mediawikiwiki logs, generated by api calls (I arrived here independently): ``` { "_index": "logstash-2015.12.17"... [12:26:07] (03CR) 10Matthias Mullie: "Catrope: can you try that import again - see if the new patch fixes the exception?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [14:14:18] (03PS1) 10Zfilipin: Update mediawiki_selenium Ruby gem to the latest version [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/259688 (https://phabricator.wikimedia.org/T114241) [14:16:47] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Document Flow activation - https://phabricator.wikimedia.org/T121510#1887502 (10Trizek-WMF) [[https://www.mediawiki.org/wiki/Help:Flow/Activation|Draft is online]] [14:25:05] (03PS1) 10Matthias Mullie: Stop silently ignoring DB errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259692 (https://phabricator.wikimedia.org/T121702) [14:26:29] (03PS2) 10Matthias Mullie: Stop silently ignoring DB errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259692 (https://phabricator.wikimedia.org/T121702) [14:26:48] (03CR) 10jenkins-bot: [V: 04-1] Stop silently ignoring DB errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259692 (https://phabricator.wikimedia.org/T121702) (owner: 10Matthias Mullie) [14:28:22] (03CR) 10jenkins-bot: [V: 04-1] Stop silently ignoring DB errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259692 (https://phabricator.wikimedia.org/T121702) (owner: 10Matthias Mullie) [15:12:34] (03PS3) 10Matthias Mullie: Stop silently ignoring DB errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259692 (https://phabricator.wikimedia.org/T121702) [15:16:04] (03CR) 10jenkins-bot: [V: 04-1] Stop silently ignoring DB errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259692 (https://phabricator.wikimedia.org/T121702) (owner: 10Matthias Mullie) [15:42:44] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Wikimedia-log-errors: Flow errors with array_slice and array_filter - https://phabricator.wikimedia.org/T121702#1887658 (10matthiasmullie) a:3matthiasmullie [15:43:01] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Wikimedia-log-errors: Flow errors with array_slice and array_filter - https://phabricator.wikimedia.org/T121702#1885845 (10matthiasmullie) The problem lies earlier in the code, where apparently there must've been an improperly handled query error. Ab... [17:23:49] 6Collaboration-Team-Backlog, 10Flow, 7Easy, 3Google-Code-In-2015: History tab should show as soon as board is created, before refresh - https://phabricator.wikimedia.org/T117837#1887863 (10Sn1per) a:3Sn1per [17:43:44] 6Collaboration-Team-Backlog, 10Echo: page-linked notifications seems to be broken - https://phabricator.wikimedia.org/T121780#1887945 (10Glaisher) 3NEW [17:44:24] 6Collaboration-Team-Backlog, 10Echo: page-linked notifications seems to be broken - https://phabricator.wikimedia.org/T121780#1887958 (10Glaisher) [17:46:20] (03CR) 10Hashar: [C: 032] Update mediawiki_selenium Ruby gem to the latest version [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/259688 (https://phabricator.wikimedia.org/T114241) (owner: 10Zfilipin) [17:49:47] (03Merged) 10jenkins-bot: Update mediawiki_selenium Ruby gem to the latest version [extensions/WikiLove] - 10https://gerrit.wikimedia.org/r/259688 (https://phabricator.wikimedia.org/T114241) (owner: 10Zfilipin) [17:53:29] 6Collaboration-Team-Backlog, 10Echo: page-linked notifications seems to be broken - https://phabricator.wikimedia.org/T121780#1888007 (10Glaisher) p:5Triage>3High Seems to be the case on beta too. I linked to http://en.wikipedia.beta.wmflabs.org/wiki/ContentPage on http://en.wikipedia.beta.wmflabs.org/wiki... [18:09:29] 6Collaboration-Team-Backlog, 10Echo, 7I18n: notification-bundle-header-edit-user-talk may need to say "messages" instead of "a message" - https://phabricator.wikimedia.org/T121328#1888114 (10Jesus10071984) I don't get paid people hex me so I can't steal off like everyone says to me 35% of what everyone makes... [18:10:57] wtf? [18:21:17] 6Collaboration-Team-Backlog, 10Echo: page-linked notifications seems to be broken - https://phabricator.wikimedia.org/T121780#1888196 (10Legoktm) a:3Legoktm [18:22:05] 6Collaboration-Team-Backlog, 10Flow: [betalabs] minor formatting issues on Notifications page - https://phabricator.wikimedia.org/T121784#1888206 (10Etonkovidova) 3NEW [18:30:02] legoktm, I think that's the first rap I've seen on Phabricator. [18:49:14] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, and 2 others: patch-reference_wiki.sql patch does not handle database prefix - https://phabricator.wikimedia.org/T121486#1888268 (10Catrope) 5Open>3Resolved [19:06:08] Hah. We should get him blocked. [19:10:55] Hah! [19:10:59] I meant to file that bug last night [19:14:26] I would totally have filed a duplicate if I'd either had more time last night or hadn't seen this rap comment today [19:17:18] Looks like a GCI-level task. (In case anyone's got time to mentor) [19:19:20] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: OOUI widgets for new notification design - https://phabricator.wikimedia.org/T115419#1888307 (10Etonkovidova) Checked in beta >Move timestamp to the bottom right, make its font a bit larger >(While we're at it, we may want to fix T112217: Mark as read '... [19:22:14] Just recorded a Indy Hall (my coworking place) song to the tune of Jingle Bells. [19:23:11] Proof or it didn't happen. :P [19:25:10] 3Collaboration-Team-Current, 10Echo: Make page titles bold in notifications - https://phabricator.wikimedia.org/T121724#1888325 (10Mattflaschen) >>! In T121724#1886325, @Catrope wrote: > This means editing the English versions of the i18n messages for notifications and adding `...` in a bunch of places.... [19:36:14] RoanKattouw, legoktm, I'm reviewing Matthias's change (Stop silently ignoring DB errors). [19:36:43] Niharika, hopefully the final version will be public. If so, I'll post it here. [19:37:22] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: OOUI widgets for new notification design - https://phabricator.wikimedia.org/T115419#1888350 (10Etonkovidova) User icon shown in Alerts - a working link. {F3113109} [19:41:20] mlitn, you there? [19:43:37] 3Collaboration-Team-Current, 10Echo, 7I18n: notification-bundle-header-edit-user-talk may need to say "messages" instead of "a message" - https://phabricator.wikimedia.org/T121328#1888365 (10Catrope) [19:43:58] 3Collaboration-Team-Current, 10Echo, 7I18n: notification-bundle-header-edit-user-talk may need to say "messages" instead of "a message" - https://phabricator.wikimedia.org/T121328#1875897 (10Catrope) Yes it should. Thanks for filing this, Amir; I was about to file this myself, then found this task by accident. [19:44:07] 3Collaboration-Team-Current, 10Echo, 7I18n: notification-bundle-header-edit-user-talk may need to say "messages" instead of "a message" - https://phabricator.wikimedia.org/T121328#1888370 (10Catrope) p:5Triage>3Normal [19:44:37] 3Collaboration-Team-Current, 10Echo, 7I18n: notification-bundle-header-edit-user-talk should say "messages" instead of "a message" - https://phabricator.wikimedia.org/T121328#1888371 (10Catrope) [19:47:31] 3Collaboration-Team-Current, 10Echo: Make page titles bold in notifications - https://phabricator.wikimedia.org/T121724#1888403 (10Catrope) >>! In T121724#1888325, @Mattflaschen wrote: >>>! In T121724#1886325, @Catrope wrote: >> This means editing the English versions of the i18n messages for notifications and... [19:54:01] (03PS1) 10MtDu: Clarify link and revert icons on notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259785 (https://phabricator.wikimedia.org/T121735) [19:59:11] (03PS2) 10MtDu: Clarify link and revert icons on notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259785 (https://phabricator.wikimedia.org/T121735) [20:03:39] (03CR) 10Catrope: [C: 032] Clarify link and revert icons on notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259785 (https://phabricator.wikimedia.org/T121735) (owner: 10MtDu) [20:04:35] (03PS3) 10Legoktm: Clarify link and revert icons on notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259785 (https://phabricator.wikimedia.org/T121624) (owner: 10MtDu) [20:05:02] (03CR) 10Legoktm: [C: 032] Clarify link and revert icons on notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259785 (https://phabricator.wikimedia.org/T121624) (owner: 10MtDu) [20:08:54] (03PS5) 10Mattflaschen: Stop silently ignoring DB errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259692 (https://phabricator.wikimedia.org/T121702) (owner: 10Matthias Mullie) [20:09:16] (03CR) 10Mattflaschen: Stop silently ignoring DB errors (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259692 (https://phabricator.wikimedia.org/T121702) (owner: 10Matthias Mullie) [20:09:34] (03CR) 10Mattflaschen: [C: 032] "Looks good." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259692 (https://phabricator.wikimedia.org/T121702) (owner: 10Matthias Mullie) [20:10:07] (03Merged) 10jenkins-bot: Clarify link and revert icons on notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259785 (https://phabricator.wikimedia.org/T121624) (owner: 10MtDu) [20:10:22] matt_flaschen: here now [20:10:39] though I may just be too late? :p [20:13:59] (03Merged) 10jenkins-bot: Stop silently ignoring DB errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259692 (https://phabricator.wikimedia.org/T121702) (owner: 10Matthias Mullie) [20:14:16] mlitn, I was going to ask whether maybe the single-object methods (find/get) should be treated differently. I decided you probably knew what you were doing, though, and checked that internal compatibility was preserved. [20:15:58] well, find is not a single-object method: it’s a single query (but could have multiple results) [20:36:32] technical question about updating a Flow installation, at https://www.mediawiki.org/wiki/Topic:Suhcu6rc7cq9lz90 [20:44:08] mlitn, you're right, I spoke too quickly. Part of the reason I was originally wanted to ask you is I thought get might use find, but it doesn't so it's a moot point. [21:28:30] quiddity, the Beta Features are $wgBetaFeatures (empty on enwiki), then the order of hook registration for GetBetaFeaturePreferences. [21:28:36] quiddity, in other words, doesn't seem to be explicit. [21:30:08] (03CR) 10Mattflaschen: Include Flow topics in Nuke (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [21:30:21] hmm, so it's determined semi-randomly at the time the betafeature is merged, based on ordering of hook-parsing? (probably incorrect keywords, but basically: does "doesn't seem to be explicit" = stochastic ?) [21:40:20] quiddity, not that random. It's based on the ordering in CommonSettings.php, and then within an individual extension if it defines more than one BetaFeature. [21:40:43] nod. ty. :) [21:44:35] (Context: I was trying to figure out why newest BFs aren't always at the [top/bottom]. Now I understand that it's because we're trying to maintain sanity within the ordering of CommonSettings.php) [21:53:01] I was looking at it a little more, and there's some complexity that I'm not seeing (either the registration order isn't what I expect from reading it, or something else), but that's the basic idea. [21:55:09] (03PS2) 10Legoktm: Convert Special:Thanks to OOUI form [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/255147 (https://phabricator.wikimedia.org/T118794) (owner: 10Glaisher) [21:55:16] (03CR) 10Legoktm: [C: 032] Convert Special:Thanks to OOUI form [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/255147 (https://phabricator.wikimedia.org/T118794) (owner: 10Glaisher) [21:55:49] bd808, have you seen "Failed to set owner to '33': Operation not permitted"? Got that on Vagrant provision. [21:57:12] matt_flaschen: what file? 33 is the UID for the www-data user in my VM. [21:57:19] are you seeing that for a log file? [22:01:18] bd808, yeah, it's from the Puppet log. Series of errors like: [22:01:21] ==> default: Error: Failed to set owner to '33': Operation not permitted - /vagrant/logs/zotero.log [22:01:22] ==> default: Error: /Stage[main]/Zotero/File[/vagrant/logs/zotero.log]/owner: change from vagrant to www-data failed: Failed to set owner to '33': Operation not permitted - /vagrant/logs/zotero.log [22:01:44] bd808, that was after a git pull into vagrant then provision. [22:01:51] I'll see if it goes away on reload --provision. [22:01:59] *nod* I changed something related to that [22:02:40] the old setup had puppet setting the owner to $SHARE_OWNER but then the init script for the various node services chmoded to www-data [22:02:52] I changed the puppet to use ww-data too [22:04:03] It's working cleanly for me but maybe I have something funky in my setup [22:04:14] (03Merged) 10jenkins-bot: Convert Special:Thanks to OOUI form [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/255147 (https://phabricator.wikimedia.org/T118794) (owner: 10Glaisher) [22:05:10] matt_flaschen: I see that the VM I've been testing this in is *not* using NFS. :/ [22:05:26] bd808, it failed on reload too. I'll give the you the trace from the first run. Do you need the PUPPET_DEBUG, or is just regular okay? [22:05:54] matt_flaschen: this is what caused it -- https://gerrit.wikimedia.org/r/#/c/259341/ [22:06:34] bd808, okay, do you want a trace? [22:06:57] matt_flaschen: naw. Want to test and +2 the revert? https://gerrit.wikimedia.org/r/#/c/259866/ [22:07:10] bd808, sure. [22:07:24] I am running NFS, BTW. [22:07:45] yeah. that's the default [22:08:00] I think the problems I was seeing are probably because I'm not seeing NFS [22:08:06] *using NFS [22:16:27] (03PS1) 10Catrope: Follow-up d62649e62c6: crush and clean up SVGs [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259868 [22:17:09] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/259406/3/includes/MaintenanceGenerators.php shouldn't be necessary, right? [22:17:34] He can just keep require_once any classes that are used prior to the autoloader (not all of the ones he requires are, though). [22:19:05] matt_flaschen: Can you explain in simple language what that commit is doing? [22:19:21] Cause I was already confused by the require_once stuff in the previous patchset but now I'm lost [22:20:28] RoanKattouw, ultimately, all it's supposed to do is get rid of EchoBatchRowIterator in friends. Those classes were originally in Echo (and still are), but there were copied to core. Goal is to get rid of them in Echo. [22:20:37] I'm about to test https://gerrit.wikimedia.org/r/#/c/259406/2/maintenance/FlowAddMissingModerationLogs.php . I don't think he needs those requires. [22:20:55] s/in friends/and friends/ [22:21:34] OK [22:21:43] I was wondering a similar thing about requires that might not be needed [22:21:56] Perhaps legoktm can help you answer that [22:23:48] [21:07:32] RoanKattouw_away: you have to do it if you reference the classes in a class Bar extends Foo type thing that gets parsed before the autoloader kicks in (require_once RUN_MAINT IF MAIN) [22:23:59] Oh, sorry, I missed that [22:24:04] Aaah I see [22:24:13] Yeah, I saw legoktm, and it makes sense and is not consistent with the change above. [22:24:24] What's weird is it doesn't work for an unrelated reason... [22:24:24] I haven't looked at the change [22:24:30] It's fine, I'll comment. [22:26:44] 3Collaboration-Team-Current, 10Echo: Add excerpt of edit summary to reverted notification - https://phabricator.wikimedia.org/T121808#1888971 (10Catrope) 3NEW [22:28:55] (03PS1) 10Mattflaschen: Fix definition and call for getModerationChangeTypes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259875 [22:31:33] (03CR) 10Catrope: [C: 032] Fix definition and call for getModerationChangeTypes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259875 (owner: 10Mattflaschen) [22:36:04] (03CR) 10jenkins-bot: [V: 04-1] Fix definition and call for getModerationChangeTypes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259875 (owner: 10Mattflaschen) [22:46:59] 3Collaboration-Team-Current, 10Echo: Tweak page-linked notification - https://phabricator.wikimedia.org/T121812#1889074 (10Catrope) 3NEW [22:53:54] (03PS3) 10Alex Monk: build: Enable mediawiki-codesniffer and make pass [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/236581 (owner: 10Jforrester) [22:55:40] (03CR) 10jenkins-bot: [V: 04-1] build: Enable mediawiki-codesniffer and make pass [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/236581 (owner: 10Jforrester) [22:58:01] 3Collaboration-Team-Current, 10Echo: Relative timestamps in notification panel are wrong - https://phabricator.wikimedia.org/T121813#1889105 (10Catrope) 3NEW [22:58:45] 3Collaboration-Team-Current, 10Echo: Add excerpt of edit summary to reverted notification - https://phabricator.wikimedia.org/T121808#1889114 (10Catrope) p:5Triage>3Normal [22:58:47] (03PS4) 10Alex Monk: build: Enable mediawiki-codesniffer and make pass [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/236581 (owner: 10Jforrester) [23:00:27] (03CR) 10jenkins-bot: [V: 04-1] build: Enable mediawiki-codesniffer and make pass [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/236581 (owner: 10Jforrester) [23:01:47] (03PS1) 10Catrope: Remove link from mention notification header [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259880 [23:05:11] (03CR) 10jenkins-bot: [V: 04-1] Remove link from mention notification header [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259880 (owner: 10Catrope) [23:05:17] (03CR) 10Alex Monk: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/236581 (owner: 10Jforrester) [23:11:12] (03CR) 10Mattflaschen: "Start from patch set 2 (rather than 3), then follow the inline comments." (038 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259406 (https://phabricator.wikimedia.org/T119253) (owner: 10Sn1per) [23:11:34] (03CR) 10Mattflaschen: [C: 04-1] "Start from patch set 2 and see my comments on that patch set." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259406 (https://phabricator.wikimedia.org/T119253) (owner: 10Sn1per) [23:11:48] (03CR) 10Alex Monk: [C: 032] "just rebased" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/236581 (owner: 10Jforrester) [23:15:21] (03Merged) 10jenkins-bot: build: Enable mediawiki-codesniffer and make pass [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/236581 (owner: 10Jforrester) [23:16:57] You do not have permission to nuke pages, for the following reason: NNPT [23:18:04] haha [23:27:59] 3Collaboration-Team-Current, 10Echo: Add snippet to mention notification - https://phabricator.wikimedia.org/T121817#1889208 (10Catrope) 3NEW [23:28:26] (03CR) 10Mattflaschen: [C: 032] "Looks good, tested locally." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [23:29:20] matt_flaschen: You wanted to SWAT that, right? [23:30:06] (03PS1) 10Mattflaschen: Include Flow topics in Nuke [extensions/Flow] (wmf/1.27.0-wmf.9) - 10https://gerrit.wikimedia.org/r/259892 (https://phabricator.wikimedia.org/T115695) [23:30:14] I'd normally be a bit apprehensive about that, but me being gone is irrelevant since I know nothing about Nuke :) [23:30:48] (03CR) 10jenkins-bot: [V: 04-1] Include Flow topics in Nuke [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [23:31:09] RoanKattouw, yeah. I tested it (Jenkins puts -1 before I send this message), but if you want me to hold off I will. [23:31:15] I think it's fine, though. [23:31:23] I'll check the -1. [23:32:01] "This change depends on a change that failed to merge." LIES [23:32:29] Yeah, I tend to disbelieve V-1s in wmf/* branches [23:32:30] (03CR) 10Mattflaschen: [C: 032] Include Flow topics in Nuke [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [23:33:08] RoanKattouw, it was actually on master, but the dependent change did merge, so... (maybe it got confused since I did the cherry-picks before it merged). [23:34:42] 6Collaboration-Team-Backlog, 10Echo: Echo: Namespace is not indicated for posts to talk pages other than article talk - https://phabricator.wikimedia.org/T57671#1889235 (10Catrope) [23:34:44] 3Collaboration-Team-Current, 10Echo, 7Voice & Tone, 7WorkType-NewFunctionality: Messages about talk pages are not completely adapted to non-talk namespaces - https://phabricator.wikimedia.org/T56433#1889236 (10Catrope) [23:40:51] Now it just stalled: https://gerrit.wikimedia.org/r/#/c/256448/ [23:41:01] It's not on Zuul status, but it's also not done. [23:41:09] I'll just C+2 V+2 submit it come 4pm [23:41:47] 3Collaboration-Team-Current, 10Echo, 7Voice & Tone, 7WorkType-NewFunctionality: Messages about talk pages are not completely adapted to non-talk namespaces - https://phabricator.wikimedia.org/T56433#1889274 (10Catrope) a:5Legoktm>3jmatazzoni We discussed this this week, and decided to go with the follo... [23:42:11] 3Collaboration-Team-Current, 10Echo, 7Voice & Tone, 7WorkType-NewFunctionality: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#1889280 (10Catrope) [23:42:14] RoanKattouw, it's the master one. I shouldn't cherry-pick before merge, that's probably why it's confused. [23:44:17] 6Collaboration-Team-Backlog, 10Echo: Echo: Namespace is not indicated for posts to talk pages other than article talk - https://phabricator.wikimedia.org/T57671#1889298 (10Catrope) [23:44:19] 6Collaboration-Team-Backlog, 10Echo: Notification for mentions on a user talk page should explain that they're on a user talk page, and have a special case for people writing to their own - https://phabricator.wikimedia.org/T65639#1889297 (10Catrope) [23:44:45] 6Collaboration-Team-Backlog, 10Echo: Echo: Namespace is not indicated for posts to talk pages other than article talk - https://phabricator.wikimedia.org/T57671#627312 (10Catrope) [23:44:47] 3Collaboration-Team-Current, 10Echo, 7Voice & Tone, 7WorkType-NewFunctionality: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#1889303 (10Catrope) [23:44:48] I'm going to force it. [23:44:49] 6Collaboration-Team-Backlog, 10Echo: Notification for mentions on a user talk page should explain that they're on a user talk page, and have a special case for people writing to their own - https://phabricator.wikimedia.org/T65639#705521 (10Catrope) [23:45:04] (03CR) 10Mattflaschen: [V: 032] Include Flow topics in Nuke [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [23:45:46] 6Collaboration-Team-Backlog, 10Echo: Notification for mentions on a user talk page should explain that they're on a user talk page, and have a special case for people writing to their own - https://phabricator.wikimedia.org/T65639#705521 (10Catrope) [23:45:48] 3Collaboration-Team-Current, 10Echo, 7Voice & Tone, 7WorkType-NewFunctionality: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#585144 (10Catrope) [23:45:57] (03CR) 10Mattflaschen: "After the bogus failure (the dependendent change did not fail to merge), it got lost (did not come back here, but was not on the dashboard" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [23:46:10] 3Collaboration-Team-Current, 10Echo, 7Voice & Tone, 7WorkType-NewFunctionality: Notification messages for mentions assume article namespace, do not reflect other namespaces - https://phabricator.wikimedia.org/T56433#585144 (10Catrope) Sorry for the noise, I decided to merge T65639 into this one. [23:49:16] RoanKattouw, okay, master are both merged (I had to force one, though). If you do SWAT, you might want to try not forcing them (should work normally now hopefully). [23:50:11] You had to force on in master? :O [23:50:37] Oh, I see [23:50:49] It's probably because there are two commits associated with that Change-Id, and the wmf9 one is not merged yet [23:51:27] 3Collaboration-Team-Current, 10Echo: Relative timestamps in notification panel are wrong - https://phabricator.wikimedia.org/T121813#1889334 (10Mooeypoo) I remember we were discussing the problem of timezones in relation to the "seenTime" issue, which is going to be even more complicated, especially when we ge... [23:52:32] Yeah. :( [23:52:47] I think I messed it up by cherry-picking before merge, and the Depends-On mechanism probably got confused. [23:54:59] 6Collaboration-Team-Backlog, 10Echo: Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#1889358 (10jmatazzoni) 3NEW a:3pau [23:56:26] 3Collaboration-Team-Current, 10Echo: Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#1889368 (10jmatazzoni) p:5Triage>3Normal [23:57:04] 3Collaboration-Team-Current, 10Echo: Truncate Page and Topic Names and Msg Excerpts in Notifications Fly-Outs and Page - https://phabricator.wikimedia.org/T121822#1889371 (10jmatazzoni) a:5pau>3Pginer-WMF