[00:44:18] 6Collaboration-Team-Backlog, 10Thanks, 7Easy: Thanks: Take advantage of new parameters passed to HistoryRevisionTools and DiffRevisionTools hooks - https://phabricator.wikimedia.org/T121369#1876839 (10Legoktm) 3NEW [01:56:19] (03PS1) 10Mooeypoo: Migrate MoodBar to the new way MW logs stuff [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258921 [01:59:20] (03PS2) 10Mooeypoo: Migrate MoodBar to the new way MW logs stuff [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258921 [02:08:41] (03PS2) 10Mooeypoo: Add GENDER support for log entries [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258698 (https://phabricator.wikimedia.org/T45481) (owner: 10MtDu) [02:15:18] (03CR) 10Mooeypoo: [C: 04-1] "Ok, MtDu, great job on this patch. In fact, you have successfully found a bit of a bug in MoodBar's logging system: it was using an outdat" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258698 (https://phabricator.wikimedia.org/T45481) (owner: 10MtDu) [02:20:12] (03CR) 10Mooeypoo: "Oops, correction for the previous comment: When I said "...and I will do the same for the en.json, unless you beat me to it." I clearly me" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258698 (https://phabricator.wikimedia.org/T45481) (owner: 10MtDu) [02:31:27] (03CR) 10jenkins-bot: [V: 04-1] Migrate MoodBar to the new way MW logs stuff [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258921 (owner: 10Mooeypoo) [02:31:50] (03CR) 10jenkins-bot: [V: 04-1] Add GENDER support for log entries [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258698 (https://phabricator.wikimedia.org/T45481) (owner: 10MtDu) [02:55:48] (03PS3) 10MtDu: Add GENDER support for log entries [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258698 (https://phabricator.wikimedia.org/T45481) [03:20:57] (03PS3) 10MtDu: Migrate MoodBar to the new way MW logs stuff [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258921 (owner: 10Mooeypoo) [03:21:22] (03CR) 10jenkins-bot: [V: 04-1] Migrate MoodBar to the new way MW logs stuff [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258921 (owner: 10Mooeypoo) [03:36:37] (03PS4) 10MtDu: Migrate MoodBar to the new way MW logs stuff [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258921 (owner: 10Mooeypoo) [03:40:07] (03CR) 10MtDu: "Ignore patch 3. Something weird happened. I fixed the typo in patch 4. I also added the documentation here and fixed the typo there as wel" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258921 (owner: 10Mooeypoo) [03:40:49] (03CR) 10MtDu: "I fixed the typo and added the needed updates to the documentation in qqq.json. I also fixed the typo here. https://gerrit.wikimedia.org/r" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/258698 (https://phabricator.wikimedia.org/T45481) (owner: 10MtDu) [10:02:51] (03PS1) 10Thiemo Mättig (WMDE): Fix visibility of setUp methods in tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258953 [10:03:22] (03PS1) 10Thiemo Mättig (WMDE): Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 [10:05:06] (03PS1) 10Thiemo Mättig (WMDE): setUp methods in tests must be protected, not public [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258955 [10:12:55] (03PS1) 10Thiemo Mättig (WMDE): Fix misspelled setUp() in RevisionStorageTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258957 [10:41:32] 6Collaboration-Team-Backlog, 10Echo, 7Epic, 7WorkType-NewFunctionality, 7user-notice: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#1877244 (10Pginer-WMF) >>! In T114350#1874980, @Catrope wrote: > @Pginer-wmf: What should we do when the labels of foreig... [13:32:35] (03PS10) 10Sbisson: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) [13:35:50] (03CR) 10jenkins-bot: [V: 04-1] Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) (owner: 10Sbisson) [13:36:24] (03PS11) 10Sbisson: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) [15:03:03] (03CR) 10Sbisson: [C: 032] Fix misspelled setUp() in RevisionStorageTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258957 (owner: 10Thiemo Mättig (WMDE)) [15:04:30] (03CR) 10Sbisson: [C: 032] setUp methods in tests must be protected, not public [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258955 (owner: 10Thiemo Mättig (WMDE)) [15:06:15] (03Merged) 10jenkins-bot: Fix misspelled setUp() in RevisionStorageTest [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258957 (owner: 10Thiemo Mättig (WMDE)) [15:08:38] (03Merged) 10jenkins-bot: setUp methods in tests must be protected, not public [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258955 (owner: 10Thiemo Mättig (WMDE)) [15:08:49] (03CR) 10Sbisson: [C: 032] Fix broken and incomplete PHPDoc tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:13:44] (03CR) 10jenkins-bot: [V: 04-1] Fix broken and incomplete PHPDoc tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:27:31] (03CR) 10Sbisson: [C: 032] Wrap topic lock/unlock standalone instance with flow-board div [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258073 (https://phabricator.wikimedia.org/T120725) (owner: 10Mooeypoo) [15:29:22] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:32:16] (03CR) 10Sbisson: Fix broken and incomplete PHPDoc tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:32:22] (03CR) 10Sbisson: [C: 032] Fix broken and incomplete PHPDoc tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:32:40] (03Merged) 10jenkins-bot: Wrap topic lock/unlock standalone instance with flow-board div [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258073 (https://phabricator.wikimedia.org/T120725) (owner: 10Mooeypoo) [15:35:32] (03Merged) 10jenkins-bot: Fix broken and incomplete PHPDoc tags [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258956 (owner: 10Thiemo Mättig (WMDE)) [15:35:47] (03CR) 10Sbisson: [C: 032] "I think it can be $topic->getContent( 'plaintext' ), topic-title is the only one that would use it but there's nothing specific to topic-t" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258098 (owner: 10Catrope) [15:38:47] (03Merged) 10jenkins-bot: Use plaintext topic title rather than wiktext for the [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258098 (owner: 10Catrope) [15:45:38] <grrrit-wm> (03CR) 10Sbisson: [C: 032] Fix visibility of setUp methods in tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258953 (owner: 10Thiemo Mättig (WMDE)) [15:46:30] <grrrit-wm> (03CR) 10Sbisson: [C: 032] Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 (owner: 10Thiemo Mättig (WMDE)) [15:47:14] <grrrit-wm> (03PS2) 10Sbisson: [wip] Add secondary links to notifications from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257519 (owner: 10Mooeypoo) [15:49:40] <grrrit-wm> (03Merged) 10jenkins-bot: Fix visibility of setUp methods in tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258953 (owner: 10Thiemo Mättig (WMDE)) [15:51:25] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 (owner: 10Thiemo Mättig (WMDE)) [15:53:09] <grrrit-wm> (03CR) 10Sbisson: "Do we want to do something special when the mention is done by an anonymous user? It shows the IP and a link to an IP user page." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257519 (owner: 10Mooeypoo) [15:54:10] <grrrit-wm> (03CR) 10Sbisson: Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 (owner: 10Thiemo Mättig (WMDE)) [15:54:16] <grrrit-wm> (03CR) 10Sbisson: [C: 032] Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 (owner: 10Thiemo Mättig (WMDE)) [15:58:00] <grrrit-wm> (03Merged) 10jenkins-bot: Fix broken and incomplete PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258954 (owner: 10Thiemo Mättig (WMDE)) [16:07:30] <wikibugs> 3Collaboration-Team-Current, 10Echo: Write script to backfill echo_unseen_wikis table - https://phabricator.wikimedia.org/T119523#1877855 (10matthiasmullie) a:3matthiasmullie [16:11:56] <wikibugs> 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Determine cause of historical UIDs colliding - https://phabricator.wikimedia.org/T117907#1877866 (10matthiasmullie) Ah, so it's likely not a case of double-insertion, but actual duplicate UUIDs. Judging from Matt's earlier script (which I also... [16:24:56] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9), 7WorkType-NewFunctionality: Email notification: The new renamed topic title is displayed in place for the previous title - https://phabricator.wikimedia.org/T109784#1877899 (10SBisson) a:3SBisson [16:36:20] <grrrit-wm> (03PS3) 10Matthias Mullie: Add filter to ApiEchoNotifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258162 (https://phabricator.wikimedia.org/T119890) [16:45:29] <grrrit-wm> (03CR) 10Matthias Mullie: Add filter to ApiEchoNotifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258162 (https://phabricator.wikimedia.org/T119890) (owner: 10Matthias Mullie) [16:47:59] <etonkovidova> matt_flaschen: are you back from vacation? :) [17:07:13] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Enable the Flow user talk opt-in Beta Feature on cawiki - https://phabricator.wikimedia.org/T120829#1878046 (10Etonkovidova) Checked in betalabs. There is the issue {T121275} that seems to be specific to cawiki. [17:09:10] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: [betalabs-cawiki] User intro for enabled "Flow on user talk" displays {{GENDER: $ 1 |}} in the popup - https://phabricator.wikimedia.org/T121275#1878057 (10Catrope) I can't reproduce. Were you using Google Chrome's translation for this? [17:13:13] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): [betalabs] Re-open a topic from History - JS error "Could not find .flow-board" - https://phabricator.wikimedia.org/T120725#1878058 (10Etonkovidova) Checked in betalabs - no JS errors upon reopening resolved to... [17:17:02] <grrrit-wm> (03PS1) 10Legoktm: [WIP] Add @integration tag to browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) [17:17:33] <grrrit-wm> (03CR) 10Legoktm: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [17:22:03] <grrrit-wm> (03PS2) 10Legoktm: [WIP] Add @integration tag to browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) [17:22:17] <grrrit-wm> (03CR) 10Legoktm: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [17:23:46] <wikibugs> 6Collaboration-Team-Backlog, 10Echo, 7I18n: Some Echo messages probably don't need {{GENDER:$2}} - https://phabricator.wikimedia.org/T121327#1878084 (10Catrope) Yeah, the documentation should be clearer. $2 refers to the gender of $1. Because of the way the infrastructure is set up, it's harder and more con... [17:25:04] <wikibugs> 3Collaboration-Team-Current, 10Echo: Write script to backfill echo_unread_wikis table - https://phabricator.wikimedia.org/T119523#1878096 (10Catrope) [17:25:41] <grrrit-wm> (03PS3) 10Legoktm: [WIP] Add @integration tag to browser tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) [17:25:53] <grrrit-wm> (03CR) 10Legoktm: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [17:33:30] <legoktm> 14:28:21 Sending email to: flaschen@wikimedia.org mmullie@wikimedia.org qa-alerts@lists.wikimedia.org msbisson@wikimedia.org [17:33:30] <legoktm> 14:28:21 Successfully sent to the following addresses: mmullie@wikimedia.org qa-alerts@lists.wikimedia.org [17:33:30] <legoktm> 14:28:21 Error sending to the following INVALID addresses: flaschen@wikimedia.org msbisson@wikimedia.org [17:34:39] <MatmaRex> that looks like it should be mflaschen and sbisson? the 'm' is misplaced? :P [17:34:44] <legoktm> yeah :P [17:35:14] <legoktm> In other news, our browser tests are broken [17:55:35] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: Reopen topic - Console error: Could not find .flow-board - https://phabricator.wikimedia.org/T118506#1878238 (10SBisson) [17:55:36] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): [betalabs] Re-open a topic from History - JS error "Could not find .flow-board" - https://phabricator.wikimedia.org/T120725#1878239 (10SBisson) [18:20:34] <etonkovidova> RoanKattouw: matt_flaschen: quiddity: pginer: sorry - I won't be in the standup due to an important iOS meeting for bug triage/analysis [18:21:08] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: [betalabs-cawiki] User intro for enabled "Flow on user talk" displays {{GENDER: $ 1 |}} in the popup - https://phabricator.wikimedia.org/T121275#1878378 (10Vriullop) I fixed the message in Translatewiki: https://translatewiki.net/w/i.php?title=MediaWiki:Flow-guidedtour-opti... [18:24:10] <grrrit-wm> (03CR) 10Legoktm: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259019 (https://phabricator.wikimedia.org/T109679) (owner: 10Legoktm) [18:24:17] <etonkovidova> matt_flaschen: can you look at my comment on https://phabricator.wikimedia.org/T108291? My understanding is that "Give the user the number of history items they asked for" should be working for such cases [18:24:56] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: Many unnecessary flow bots - https://phabricator.wikimedia.org/T121420#1878384 (10Stryn) 3NEW [18:25:22] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: [betalabs-cawiki] User intro for enabled "Flow on user talk" displays {{GENDER: $ 1 |}} in the popup - https://phabricator.wikimedia.org/T121275#1878392 (10Catrope) 5Open>3Resolved a:3Catrope Thanks @Vriullop! [18:27:18] <wikibugs> 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on some wikis - https://phabricator.wikimedia.org/T117990#1878408 (10Catrope) [18:27:19] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Enable the Flow user talk opt-in Beta Feature on cawiki - https://phabricator.wikimedia.org/T120829#1878407 (10Catrope) 5Open>3Resolved [18:42:16] <grrrit-wm> (03PS1) 10Legoktm: Add missing @throws tag and change Exception subclass being thrown [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259040 [19:25:32] <wikibugs> 6Collaboration-Team-Backlog, 10Echo, 10Flow, 7Easy, 3Google-Code-In-2015: Remove BatchRowUpdate from Flow and Echo and use the one in MediaWiki core instead - https://phabricator.wikimedia.org/T119253#1878717 (10Sn1per) a:3Sn1per [19:37:16] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: Enabling Flow after disabling it does nothing - https://phabricator.wikimedia.org/T119334#1878756 (10Stryn) >>! In T119334#1876251, @Stryn wrote: > *Flow enabled, but it does nothing: > https://www.wikidata.org/wiki/Topic:Suf3iqc70f51jkla This one was created, it was just... [19:46:09] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: [betalabs-cawiki] User intro for enabled "Flow on user talk" displays {{GENDER: $ 1 |}} in the popup - https://phabricator.wikimedia.org/T121275#1878816 (10Etonkovidova) Checked in betalabs - both Chrome and FF. Looks fine. [19:49:43] <wikibugs> 3Collaboration-Team-Current, 10Echo, 10Gather: Write presentation models for notifications in Gather - https://phabricator.wikimedia.org/T116848#1878850 (10Jdlrobson) [20:00:59] <grrrit-wm> (03PS1) 10Anomie: Prepare for move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259064 [20:01:02] <grrrit-wm> (03PS1) 10Anomie: Complete move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259065 [20:03:48] <grrrit-wm> (03PS6) 10Catrope: [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 [20:08:00] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Prepare for move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259064 (owner: 10Anomie) [20:10:13] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Complete move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259065 (owner: 10Anomie) [20:12:59] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (owner: 10Catrope) [20:27:46] <grrrit-wm> (03CR) 10Anomie: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259064 (owner: 10Anomie) [20:33:20] <grrrit-wm> (03CR) 10Anomie: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259065 (owner: 10Anomie) [21:12:39] <grrrit-wm> (03PS7) 10Catrope: [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 [21:12:42] <grrrit-wm> (03PS76) 10Catrope: Add OOUI widgets for cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) (owner: 10Mooeypoo) [21:15:59] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (owner: 10Catrope) [21:17:39] <grrrit-wm> (03CR) 10Mattflaschen: "Normally we link to their Special:Contributions page instead of user page for anons." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257519 (owner: 10Mooeypoo) [21:19:14] <wikibugs> 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Determine cause of historical UIDs colliding - https://phabricator.wikimedia.org/T117907#1879188 (10Mattflaschen) >>! In T117907#1877866, @matthiasmullie wrote: > Ah, so it's likely not a case of double-insertion, but actual duplicate UUIDs. >... [21:30:13] <wikibugs> 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Determine cause of historical UIDs colliding - https://phabricator.wikimedia.org/T117907#1879208 (10Catrope) I tried some simple tests on terbium, like running `echo \Flow\Model\UUID::create();` in a loop 2000 times, and I didn't get any duplic... [21:33:10] <grrrit-wm> (03PS3) 10Catrope: Add cross-wiki as a beta feature [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256138 (https://phabricator.wikimedia.org/T114237) (owner: 10Mooeypoo) [21:34:24] <grrrit-wm> (03PS8) 10Catrope: [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 [21:34:40] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Give the user the number of history items they asked for - https://phabricator.wikimedia.org/T108291#1879223 (10Mattflaschen) Yeah, for some reason this isn't working properly (anymore?) for this case. E.g. http... [21:38:22] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (owner: 10Catrope) [21:39:33] <wikibugs> 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Determine cause of historical UIDs colliding - https://phabricator.wikimedia.org/T117907#1879229 (10Mattflaschen) >>! In T117907#1879208, @Catrope wrote: > I tried some simple tests on terbium, like running `echo \Flow\Model\UUID::create();` in... [21:39:42] <grrrit-wm> (03CR) 10Catrope: "PS73-76:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) (owner: 10Mooeypoo) [21:44:17] <grrrit-wm> (03CR) 10Catrope: [C: 032] Add missing @throws tag and change Exception subclass being thrown [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259040 (owner: 10Legoktm) [21:45:57] <grrrit-wm> (03CR) 10Catrope: [C: 032] Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) (owner: 10Sbisson) [21:48:04] <grrrit-wm> (03Merged) 10jenkins-bot: Add missing @throws tag and change Exception subclass being thrown [extensions/Echo] - 10https://gerrit.wikimedia.org/r/259040 (owner: 10Legoktm) [21:49:20] <grrrit-wm> (03Merged) 10jenkins-bot: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) (owner: 10Sbisson) [21:54:23] <grrrit-wm> (03CR) 10Mooeypoo: Add OOUI widgets for cross-wiki bundled notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) (owner: 10Mooeypoo) [22:12:56] <grrrit-wm> (03PS10) 10Mattflaschen: Include Flow topics in Nuke [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [22:31:14] <wikibugs> 6Collaboration-Team-Backlog, 10Echo: Please add "unread watchlist items" to notifications - https://phabricator.wikimedia.org/T121453#1879367 (10Kipod) 3NEW [22:43:16] <grrrit-wm> (03CR) 10Mattflaschen: [C: 04-1] "Looks good, small stuff." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) (owner: 10Sbisson) [23:01:14] <wikibugs> 3Collaboration-Team-Current, 10Flow: Error with Flow beta feature at cawiki - InvalidInputException - https://phabricator.wikimedia.org/T121455#1879452 (10Quiddity) 3NEW [23:01:32] <quiddity> matt_flaschen, RoanKattouw_away ^ or https://phabricator.wikimedia.org/T121455 [23:02:40] <wikibugs> 3Collaboration-Team-Current, 10Flow: Error with Flow beta feature at cawiki - InvalidInputException - https://phabricator.wikimedia.org/T121455#1879460 (10Quiddity) [23:03:39] <quiddity> Possibly we need to do a repeat of https://phabricator.wikimedia.org/T120468 for all the wikis that have opted-in? [23:03:59] <quiddity> (tangentially to that bug) [23:11:35] <matt_flaschen> quiddity, Flow talk page manager already is a bot and a Flow bot on cawiki: https://ca.wikipedia.org/w/index.php?title=Especial%3AUsuaris&username=Flow+talk+page+manager&group=&limit=1 [23:11:54] <matt_flaschen> We don't log InvalidInputException. This is at least the second time this came up. [23:12:54] <quiddity> nod, but i mean for humans. Especially at cawiki where they have a namespace converted/enabled.. [23:14:08] <matt_flaschen> quiddity, sorry, I misread this. But it should already be possible to move Flow boards within that namespace, and to it. [23:14:29] <quiddity> nod, ok. Not urgent then. [23:23:18] <grrrit-wm> (03PS1) 10Mattflaschen: Make InvalidInputException loggable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 [23:25:54] <grrrit-wm> (03CR) 10Gergő Tisza: [C: 031] Prepare for move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259064 (owner: 10Anomie) [23:26:06] <grrrit-wm> (03CR) 10Mattflaschen: "This seems to actually be useful for debugging (e.g. T121455), so I think we should log it unless there's something I'm missing." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 (owner: 10Mattflaschen) [23:27:04] <grrrit-wm> (03CR) 10Gergő Tisza: [C: 031] Complete move of grant logic from OAuth to core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259065 (owner: 10Anomie) [23:31:50] <grrrit-wm> (03CR) 10Catrope: [C: 032] Make InvalidInputException loggable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 (owner: 10Mattflaschen) [23:31:53] <RoanKattouw> matt_flaschen: THANK YOU [23:32:03] <RoanKattouw> That has been bothering me for a long time and I keep forgetting to fix it [23:34:53] <matt_flaschen> RoanKattouw, hopefully there's not some horrible reason. But the commit (893521f8613cdf0e1bdc7d5b61211a844a73b48f) that added it just says, "Reuse code from MWException". [23:35:02] <matt_flaschen> I'm guessing it's just for log spam. [23:35:12] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Make InvalidInputException loggable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 (owner: 10Mattflaschen) [23:35:49] <matt_flaschen> Weird VE thing: https://integration.wikimedia.org/ci/job/mediawiki-extensions-hhvm/42933/console [23:35:53] <matt_flaschen> Some kind of git checkout problem [23:36:09] <grrrit-wm> (03CR) 10Mattflaschen: [C: 032] "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 (owner: 10Mattflaschen) [23:37:19] <RoanKattouw> I think it probably is log spam yes [23:37:37] <RoanKattouw> If it spams the crap out of the logs, we can always revert it, but that would also be a sign that we have to fix something [23:37:55] <RoanKattouw> Also, I think there are a few places in Flow that can throw exceptions in response to malformed user input which is Not Cool [23:38:05] <RoanKattouw> (maybe that was why this exception was made non-loggable) [23:39:29] <RoanKattouw> matt_flaschen: Whoa wtf yeah that's probably just the CI infrastructure being on crack [23:40:24] <grrrit-wm> (03Merged) 10jenkins-bot: Make InvalidInputException loggable [extensions/Flow] - 10https://gerrit.wikimedia.org/r/259182 (owner: 10Mattflaschen)