[00:04:12] (03CR) 10Catrope: [C: 032] ApiFlowThank: Update for topic title changes in Flow [extensions/Thanks] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258069 (https://phabricator.wikimedia.org/T120934) (owner: 10Catrope) [00:11:06] (03Merged) 10jenkins-bot: ApiFlowThank: Update for topic title changes in Flow [extensions/Thanks] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258069 (https://phabricator.wikimedia.org/T120934) (owner: 10Catrope) [00:29:02] 3Collaboration-Team-Current, 10Flow: [betalabs] Re-open a topic from History - JS error "Could not find .flow-board" - https://phabricator.wikimedia.org/T120725#1867963 (10Mooeypoo) a:3Mooeypoo [00:30:51] 6Collaboration-Team-Backlog, 10Flow: The page "Resolve topic" from history (standalone resolve topic page) does not have a summary textbox (in both js and no-js) - https://phabricator.wikimedia.org/T121043#1867966 (10Mooeypoo) 3NEW [00:31:21] (03PS1) 10Mooeypoo: Wrap topic lock/unlock standalone instance with flow-board div [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258073 (https://phabricator.wikimedia.org/T120725) [00:34:35] 6Collaboration-Team-Backlog, 10Echo, 10Flow, 10Thanks, and 2 others: "Thanks" alert in Echo: "Due to a technical error, this post could not be retrieved" instead of Flow discussion subject - https://phabricator.wikimedia.org/T120934#1867985 (10Catrope) The fix for this is deployed now. Unfortunately, the "... [00:35:01] 3Collaboration-Team-Current, 10Echo, 10Flow, 10Thanks, and 2 others: "Thanks" alert in Echo: "Due to a technical error, this post could not be retrieved" instead of Flow discussion subject - https://phabricator.wikimedia.org/T120934#1867988 (10Catrope) [00:35:28] 3Collaboration-Team-Current, 10Echo, 10Flow, 10Thanks, and 2 others: "Thanks" alert in Echo: "Due to a technical error, this post could not be retrieved" instead of Flow discussion subject - https://phabricator.wikimedia.org/T120934#1867991 (10Catrope) a:3Catrope [01:15:03] 6Collaboration-Team-Backlog, 10Flow: Enable the editing of topic titles on resolved topics - https://phabricator.wikimedia.org/T121051#1868150 (10Quiddity) 3NEW [02:01:37] (03CR) 10Catrope: [C: 032] Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [02:06:29] (03Merged) 10jenkins-bot: Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [02:25:31] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-OpenStackManager, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Write presentation models for notifications in OpenStackManager - https://phabricator.wikimedia.org/T116853#1868344 (10Catrope) 5Open>3Resolved [02:25:34] 3Collaboration-Team-Current, 10Echo, 7Tracking: Write presentation models for all notification types (tracking) - https://phabricator.wikimedia.org/T116834#1868345 (10Catrope) [02:25:36] 3Collaboration-Team-Current, 10Echo, 7Tracking: Write presentation models for all notification types (tracking) - https://phabricator.wikimedia.org/T116834#1759474 (10Catrope) [02:25:38] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-11-10_(1.27.0-wmf.6), and 2 others: Write presentation models for notifications in Echo - https://phabricator.wikimedia.org/T116843#1868346 (10Catrope) 5Open>3Resolved [02:25:41] 3Collaboration-Team-Current, 10Echo, 7Tracking: Write presentation models for all notification types (tracking) - https://phabricator.wikimedia.org/T116834#1759474 (10Catrope) [02:25:44] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-PageCuration, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Write presentation models for notifications in PageTriage - https://phabricator.wikimedia.org/T116849#1868348 (10Catrope) 5Open>3Resolved [02:26:14] 3Collaboration-Team-Current, 10Echo, 7Tracking: Write presentation models for all notification types (tracking) - https://phabricator.wikimedia.org/T116834#1759474 (10Catrope) [02:26:18] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation, 3LE-CX7-Sprint 4, and 4 others: Write presentation models for notifications in ContentTranslation - https://phabricator.wikimedia.org/T116852#1868350 (10Catrope) 5Open>3Resolved [02:31:10] 6Collaboration-Team-Backlog, 10Flow: History: quotes around titles with links should have additional space - https://phabricator.wikimedia.org/T121002#1868359 (10Catrope) Looks like a general bug in MediaWiki, because I can reproduce it by just writing stuff on a wiki page: https://www.mediawiki.org/wiki/User:... [02:34:02] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Brackets appear in history when topic title that contains link is changed - https://phabricator.wikimedia.org/T120329#1868363 (10Catrope) 5Open>3Resolved [02:42:10] (03PS1) 10Catrope: Use plaintext topic title rather than wiktext for the [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258098 [02:43:37] <grrrit-wm> (03CR) 10Catrope: "I feel like we should probably have some sort of utility for getting plain text topic titles (i.e. Utils::htmlToPlaintext( $topic->getCont" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258098 (owner: 10Catrope) [03:04:40] <grrrit-wm> (03CR) 10Catrope: Script to remove topics before a certain date (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [03:07:40] <grrrit-wm> (03CR) 10Catrope: [C: 04-1] "When I tried running this on my local wiki, I got an exception:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [03:09:00] <grrrit-wm> (03CR) 10Catrope: "Full log: https://phabricator.wikimedia.org/P2393" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [03:09:34] <grrrit-wm> (03CR) 10Catrope: Script to remove topics before a certain date (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [04:05:47] <grrrit-wm> (03PS2) 10Catrope: [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [04:08:44] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (https://phabricator.wikimedia.org/T121067) (owner: 10Legoktm) [04:13:56] <wikibugs> 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Incomplete GENDER support for notification-mention and related messages - https://phabricator.wikimedia.org/T119321#1868442 (10Catrope) >>! In T119321#1866566, @SBisson wrote: > # All 'mention' messages seem to s... [04:16:36] <wikibugs> 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Incomplete GENDER support for notification-mention and related messages - https://phabricator.wikimedia.org/T119321#1868446 (10Catrope) 5Open>3Resolved [04:17:46] <grrrit-wm> (03CR) 10Catrope: [C: 04-1] Share code between EchoNotificationMapper::fetchByUser & fetchUnreadByUser (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257961 (owner: 10Matthias Mullie) [04:31:50] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 5Patch-For-Review: Spread permission to move flow boards? - https://phabricator.wikimedia.org/T120468#1868468 (10Catrope) Scheduled for Friday Dec 11 00:00-01:00 UTC: https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=223863&oldid=223849 [04:32:06] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Spread permission to move flow boards? - https://phabricator.wikimedia.org/T120468#1868469 (10Catrope) [04:32:13] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Spread permission to move flow boards? - https://phabricator.wikimedia.org/T120468#1868471 (10Catrope) a:3Catrope [04:32:59] <wikibugs> 3Collaboration-Team-Current, 10Gather: Notifications are broken (not being sent) - https://phabricator.wikimedia.org/T120160#1868476 (10Catrope) 5Open>3Resolved [04:33:48] <wikibugs> 6Collaboration-Team-Backlog, 10Beta-Cluster-Infrastructure, 10DBA, 10Staging: Use External Store on Beta Cluster - https://phabricator.wikimedia.org/T95871#1868484 (10Catrope) [04:33:51] <wikibugs> 6Collaboration-Team-Backlog, 10Collaboration-Team-Sprint-D-2015-06-30, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, and 2 others: E10. Have Flow use ExternalStore on MediaWiki-Vagrant - https://phabricator.wikimedia.org/T95870#1868485 (10Catrope) [04:33:53] <wikibugs> 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 5Patch-For-Review, and 2 others: Migrate Flow content to new separate logical External Store - https://phabricator.wikimedia.org/T106363#1868480 (10Catrope) 5Open>3Resolved [04:47:17] <wikibugs> 3Collaboration-Team-Current, 10Echo: Remove unused text for primary link - https://phabricator.wikimedia.org/T116892#1868513 (10Catrope) 5Open>3Invalid a:3Catrope [04:49:13] <grrrit-wm> (03CR) 10Catrope: [C: 032] Bump Schema:Echo to oldid=7731316 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257825 (owner: 10Legoktm) [04:52:12] <grrrit-wm> (03Merged) 10jenkins-bot: Bump Schema:Echo to oldid=7731316 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257825 (owner: 10Legoktm) [10:46:19] <grrrit-wm> (03PS5) 10Matthias Mullie: Script to remove topics before a certain date [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) [10:48:01] <grrrit-wm> (03CR) 10Matthias Mullie: "As for the exception: I'll look into it. I've had a couple of similar exceptions where parents were deleted before children, causing error" (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [12:32:24] <wikibugs> 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#1869024 (10Pginer-WMF) > Discussion continues... (particularly related to the questions that Pau describes above, about whether the beta feature will... [12:41:05] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Enable the Flow user talk opt-in Beta Feature on cawiki - https://phabricator.wikimedia.org/T120829#1869038 (10Trizek-WMF) [[https://ca.wikipedia.org/w/index.php?title=Tema:St8tf44wbdcijhig&topic_showPostId=suaehrkiw2xo2517#flow-post-suaehrkiw2xo2517|An... [13:04:17] <wikibugs> 3Collaboration-Team-Current, 10Echo, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Incomplete GENDER support for notification-mention and related messages - https://phabricator.wikimedia.org/T119321#1869090 (10matej_suchanek) [14:06:44] <wikibugs> 6Collaboration-Team-Backlog, 10MoodBar, 3Google-Code-In-2015, 7I18n, 5Patch-For-Review: Add GENDER support to MediaWiki:Moodbar-log-hide and friends - https://phabricator.wikimedia.org/T45481#1869188 (10Aklapper) https://codein.withgoogle.com/dashboard/tasks/6483916638650368/ [14:07:31] <wikibugs> 6Collaboration-Team-Backlog, 10MoodBar, 3Google-Code-In-2015, 7I18n, 5Patch-For-Review: GENDER support for moodbar-feedback-response-summary - https://phabricator.wikimedia.org/T99066#1284585 (10Aklapper) https://codein.withgoogle.com/dashboard/tasks/4607096997806080/ [15:25:42] <grrrit-wm> (03PS2) 10Sbisson: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) [15:28:47] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) (owner: 10Sbisson) [15:49:40] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: Limit title input field to max length of topic title (1) - https://phabricator.wikimedia.org/T76818#1869498 (10Trizek-WMF) Someone confused title and text fields on a Flow board. A very long edit summary has been displayed on many watchlists ([[https://fr.wikipedia.org/w/in... [15:50:06] <grrrit-wm> (03PS3) 10Sbisson: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) [15:51:53] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: Flow should use one VisualEditor target per page - https://phabricator.wikimedia.org/T121110#1869523 (10Esanders) 3NEW [15:52:27] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) (owner: 10Sbisson) [15:56:27] <grrrit-wm> (03PS4) 10Sbisson: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) [15:59:46] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) (owner: 10Sbisson) [16:12:07] <grrrit-wm> (03PS5) 10Sbisson: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) [16:16:18] <grrrit-wm> (03PS6) 10Sbisson: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) [16:18:52] <grrrit-wm> (03PS1) 10Matthias Mullie: Add filter to ApiEchoNotifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258162 (https://phabricator.wikimedia.org/T119890) [16:20:01] <grrrit-wm> (03CR) 10Matthias Mullie: Share code between EchoNotificationMapper::fetchByUser & fetchUnreadByUser (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257961 (owner: 10Matthias Mullie) [16:20:29] <grrrit-wm> (03PS2) 10Matthias Mullie: Share code between EchoNotificationMapper::fetchByUser & fetchUnreadByUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257961 [16:21:18] <grrrit-wm> (03PS2) 10Matthias Mullie: Also support continuation requests for $unreadFirst [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257962 [16:22:42] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add filter to ApiEchoNotifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258162 (https://phabricator.wikimedia.org/T119890) (owner: 10Matthias Mullie) [16:25:29] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Also support continuation requests for $unreadFirst [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257962 (owner: 10Matthias Mullie) [16:25:58] <grrrit-wm> (03PS3) 10Matthias Mullie: Also support continuation requests for $unreadFirst [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257962 [16:29:02] <grrrit-wm> (03CR) 10Matthias Mullie: Also support continuation requests for $unreadFirst (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257962 (owner: 10Matthias Mullie) [16:29:07] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Also support continuation requests for $unreadFirst [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257962 (owner: 10Matthias Mullie) [16:33:41] <grrrit-wm> (03PS4) 10Matthias Mullie: Also support continuation requests for $unreadFirst [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257962 [16:48:35] <grrrit-wm> (03PS2) 10Matthias Mullie: Add filter to ApiEchoNotifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258162 (https://phabricator.wikimedia.org/T119890) [17:03:05] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: Flow should use one VisualEditor target per page - https://phabricator.wikimedia.org/T121110#1869794 (10Jdforrester-WMF) Blocked by {T97168}? [17:26:30] <James_F> Hey. [17:26:35] <James_F> We broke Flow. [17:26:36] <James_F> Sorry. [17:38:49] <grrrit-wm> (03PS1) 10Jforrester: Unbreak references to rename VisualEditor mw.ArticleTarget class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258174 [17:39:38] <grrrit-wm> (03CR) 10Jforrester: "Renamed in If72650bdf; mw.Target will get re-created soon with this code and more so Flow can sub-class it, but for now…" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258174 (owner: 10Jforrester) [17:50:22] <grrrit-wm> (03CR) 10Catrope: [C: 032] Unbreak references to rename VisualEditor mw.ArticleTarget class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258174 (owner: 10Jforrester) [17:50:26] <James_F> RoanKattouw: Thanks. [17:50:29] <RoanKattouw> James_F: Thanks for the fix [17:50:42] <RoanKattouw> It's not like I showed Ed this exact code when he was here 2 weeks ago... [17:50:44] <RoanKattouw> :P [17:51:32] * James_F grins. [17:54:42] <grrrit-wm> (03Merged) 10jenkins-bot: Unbreak references to rename VisualEditor mw.ArticleTarget class [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258174 (owner: 10Jforrester) [17:56:27] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 10Vector: Double quote (") immediately after an external link looks ugly: icon is too close to the double quote - https://phabricator.wikimedia.org/T121002#1869969 (10Jdlrobson) [17:58:03] <RoanKattouw> Actually he certainly remembers that because he filed a bug earlier today that he found while I showed him this code [17:59:53] * RoanKattouw heads into the office [18:02:28] <wikibugs> 3Collaboration-Team-Current, 10Echo: Fix EventLogging for cross-wiki notifications - https://phabricator.wikimedia.org/T120158#1869990 (10Legoktm) a:3Legoktm [18:07:28] <grrrit-wm> (03PS1) 10Legoktm: Add support for cross-wiki notifications to Schema:EchoInteraction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258178 (https://phabricator.wikimedia.org/T120158) [18:08:17] <etonkovidova> stephanebisson: there are some problems with sending/receiving Notifications again? In beta I can see only notifications about user talk pages... [18:09:46] <stephanebisson> etonkovidova: The Flow presentation models were merged recently, it could cause surprises in terms of how things look... [18:10:09] <stephanebisson> etonkovidova: which notifications were you expecting that didn't come? [18:14:54] <etonkovidova> stephanebisson: creating topic/new edits on watched pages -both Flow and non-Flow [18:15:51] <etonkovidova> stephanebisson: no notifications about 'your edits have been reviewed/reverted" [18:18:54] <stephanebisson> etonkovidova: I don't know why. I'll do some testing as well it might give us more information. [18:20:56] <etonkovidova> stephanebisson: ok - thanks! I will keep an eye on it - seems to me weird that only User talk page message come through [18:27:39] <stephanebisson> etonkovidova: I can trigger a bunch of notifications [18:28:22] <stephanebisson> any specific type you want me to try? [18:28:36] <etonkovidova> stephanebisson: it seems more interesting than I thought - I was logged simultaneously in cawiki and enwiki - notifications did not come through [18:29:12] <etonkovidova> stephanebisson: I logged out - so far seems normal flow notifications, but old notifications are not shown ... [18:29:43] <etonkovidova> stephanebisson: yes, I am interested in patrol notifications :) [18:29:48] <stephanebisson> are you trying to test cross-wiki notifications before it's there? [18:30:23] <etonkovidova> stephanebisson: it happened unintentionally [18:38:02] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Technical-Debt, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Remove old hardcoded tokens from patrol links in Flow - https://phabricator.wikimedia.org/T118225#1870219 (10Catrope) 5Open>3Resolved [18:52:14] <James_F> legoktm: I love you. [18:52:28] <legoktm> <3 [18:53:20] <James_F> legoktm: Also, more specifically, whatamidoing and elitre and others love you. [18:54:02] <legoktm> that's only half of it, I need to add it to mw.Feedback too [18:54:20] <James_F> legoktm: Take it easy. :-) [18:55:10] <legoktm> that part is easy :P [18:57:24] <James_F> legoktm: Being able to centralise the VE feedback page to just MW.org will be awesome. [18:59:15] <wikibugs> 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkType-Maintenance: Allow cross-wiki target for MediaWiki's feedback tool - https://phabricator.wikimedia.org/T111590#1870336 (10Legoktm) a:3Legoktm [19:02:21] <James_F> legoktm: Why is it now blocked? [19:07:15] <legoktm> James_F: I dragged it to the wrong column, blocked is right before "needs review" and then my internet died [19:07:25] <James_F> Aha. OK. [19:07:41] * James_F grumbles about trying to represent state with columns you can't set programmatically. [19:07:59] * RoanKattouw grumbles about not being able to re-column tasks from the task page [19:08:19] <James_F> Columns aren't 'first level' in Phab, so one is SOL. [19:08:36] <James_F> I wonder if Projects v3 will make columns just be sub-projects of the project. That'd be interesting. [19:08:42] <grrrit-wm> (03CR) 10Legoktm: [C: 032] Share code between EchoNotificationMapper::fetchByUser & fetchUnreadByUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257961 (owner: 10Matthias Mullie) [19:09:28] <grrrit-wm> (03CR) 10Catrope: [C: 032] Add support for cross-wiki notifications to Schema:EchoInteraction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258178 (https://phabricator.wikimedia.org/T120158) (owner: 10Legoktm) [19:09:37] <etonkovidova> stephanebisson_: pls let me know if you notice smth in terms of notification delivery discrepancies [19:10:04] <stephanebisson_> etonkovidova: everything I could test worked fine [19:10:23] <stephanebisson_> etonkovidova: I don't remember seeing "patrolled" notifications, does it exist? [19:10:53] <etonkovidova> stephanebisson_: it should be smth like 'your edits have been reviewed" [19:11:36] <James_F> legoktm: So… could you say (or just write) the change for VE to centralise our feedback if the given config is for MW.org? [19:11:46] <James_F> legoktm: Or would it Just Work™? [19:13:00] <legoktm> James_F: the only catch is that this will only work on wikis where Flow is installed [19:13:26] <James_F> legoktm: Installed for sending or for recieving? [19:13:52] <legoktm> The Flow extension has to be enabled on the local wiki, to be able to send to Flow on mw.o [19:14:06] <James_F> Isn't it installed on all WMF cluster wikis now? [19:14:55] <legoktm> 'betawikiversity' => false, # T107904 [19:14:55] <legoktm> 'dewikivoyage' => false, # T107846 [19:14:55] <legoktm> 'enwikiversity' => false, # T107846 [19:14:55] <legoktm> 'jawikiversity' => false, [19:14:55] <legoktm> 'private' => false, [19:14:56] <legoktm> 'loginwiki' => false, [19:14:58] <legoktm> 'votewiki' => false, [19:16:20] <grrrit-wm> (03Merged) 10jenkins-bot: Share code between EchoNotificationMapper::fetchByUser & fetchUnreadByUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257961 (owner: 10Matthias Mullie) [19:18:49] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Add support for cross-wiki notifications to Schema:EchoInteraction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258178 (https://phabricator.wikimedia.org/T120158) (owner: 10Legoktm) [19:20:38] <James_F> So everywhere except private wikis (which is fine), and three wikis I don't care about? [19:20:40] <James_F> WFM. [19:23:14] <grrrit-wm> (03PS1) 10Legoktm: Update messagePoster implementation for foreign wiki support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258194 (https://phabricator.wikimedia.org/T111590) [19:23:20] <legoktm> RoanKattouw: ^ last part [19:23:51] <grrrit-wm> (03CR) 10Legoktm: [C: 032] "?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258178 (https://phabricator.wikimedia.org/T120158) (owner: 10Legoktm) [19:24:34] <grrrit-wm> (03CR) 10Catrope: [C: 032] Update messagePoster implementation for foreign wiki support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258194 (https://phabricator.wikimedia.org/T111590) (owner: 10Legoktm) [19:25:44] <grrrit-wm> (03CR) 10jenkins-bot: [V: 04-1] Update messagePoster implementation for foreign wiki support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258194 (https://phabricator.wikimedia.org/T111590) (owner: 10Legoktm) [19:27:32] <grrrit-wm> (03Merged) 10jenkins-bot: Add support for cross-wiki notifications to Schema:EchoInteraction [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258178 (https://phabricator.wikimedia.org/T120158) (owner: 10Legoktm) [19:28:45] <grrrit-wm> (03PS2) 10Legoktm: Update messagePoster implementation for foreign wiki support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258194 (https://phabricator.wikimedia.org/T111590) [19:34:38] <legoktm> RoanKattouw: ^ ok, i fixed jsduck :) [19:35:05] <grrrit-wm> (03CR) 10Catrope: [C: 032] Update messagePoster implementation for foreign wiki support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258194 (https://phabricator.wikimedia.org/T111590) (owner: 10Legoktm) [19:36:09] <RoanKattouw> legoktm: BTW did you see my email from last night asking about when and where to enable the Echo tracking table? [19:36:46] <legoktm> no, /me reads [19:37:13] <legoktm> RoanKattouw: yeah, starting with test wikis now sounds like a good idea [19:37:19] <RoanKattouw> OK [19:37:35] <RoanKattouw> Yeah I figured we could start with only setting it on testwiki and test2wiki, then run the population script there once we have one [19:38:06] <RoanKattouw> Then when the new code rolls out, enable the beta feature on those two wikis so we have notifs going between them [19:38:15] <legoktm> yeah, sounds good to me [19:38:50] <RoanKattouw> Cool [19:38:52] * RoanKattouw writes config patch [19:39:31] <grrrit-wm> (03Merged) 10jenkins-bot: Update messagePoster implementation for foreign wiki support [extensions/Flow] - 10https://gerrit.wikimedia.org/r/258194 (https://phabricator.wikimedia.org/T111590) (owner: 10Legoktm) [19:40:20] <wikibugs> 3Collaboration-Team-Current, 5Patch-For-Review, 7WorkType-Maintenance: Allow cross-wiki target for MediaWiki's feedback tool - https://phabricator.wikimedia.org/T111590#1870459 (10Legoktm) 5Open>3Resolved [19:48:09] <grrrit-wm> (03CR) 10Catrope: [C: 04-1] Add filter to ApiEchoNotifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258162 (https://phabricator.wikimedia.org/T119890) (owner: 10Matthias Mullie) [19:51:01] <RoanKattouw> legoktm: If you like https://gerrit.wikimedia.org/r/258201 , I'll SWAT it this afternoon [19:51:26] <wikibugs> 3Collaboration-Team-Current, 10Flow: [betalabs] Blocked user creating a new topic gets malformed error message - https://phabricator.wikimedia.org/T121137#1870479 (10Etonkovidova) 3NEW [19:52:25] <wikibugs> 3Collaboration-Team-Current, 10Flow: [betalabs] Blocked user creating a new topic gets malformed error message - https://phabricator.wikimedia.org/T121137#1870486 (10Etonkovidova) [19:53:47] <legoktm> RoanKattouw: +1'd [19:57:35] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: Enable a way for us to choose whether to autowatchlist each new flow topic - https://phabricator.wikimedia.org/T121138#1870498 (10Quiddity) 3NEW [19:57:52] <wikibugs> 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Feed (watchlist/RC/contribs) - Flow issues (tracking) - https://phabricator.wikimedia.org/T85540#1870510 (10Quiddity) [19:57:53] <wikibugs> 6Collaboration-Team-Backlog, 10Flow: Enable a way for us to choose whether to autowatchlist each new flow topic - https://phabricator.wikimedia.org/T121138#1870511 (10Quiddity) [19:58:03] <wikibugs> 3Collaboration-Team-Current, 10Flow: [betalabs] Blocked user creating a new topic gets malformed error message - https://phabricator.wikimedia.org/T121137#1870519 (10Etonkovidova) After the fix, check the case when a user was blocked without enabling "Prevent this user from editing their own talk page while... [21:10:25] <etonkovidova> stephanebisson_: sigh... a question again: https://phabricator.wikimedia.org/T115515 "Make sure mw-vagrant Flow role creates users/groups required for Flow browser tests" [21:10:56] <stephanebisson_> yes [21:10:58] <etonkovidova> stephanebisson_: I do not see "Selenium Flow user" in root@localhost:[wiki]> select user_name from user where user_name like 'Selenium%'; [21:11:14] <etonkovidova> only Selenium Flow user 2 [21:11:35] <etonkovidova> stephanebisson_: and also - those user should be in betalabs too? [21:12:18] <stephanebisson_> etonkovidova: This is just for mw-vagrant. Did you pudate the repo and `vagrant provision` recently? [21:12:25] <stephanebisson_> *update [21:13:26] <etonkovidova> stephanebisson: hmm... I think I've updated it but will do again [21:14:29] <James_F> RoanKattouw: You looked at https://phabricator.wikimedia.org/T90523 recently? Is it sanely quickly doable? [21:14:31] <etonkovidova> Guest19644: but if you see both Selenium users in user table - all should be fine :) [21:14:48] <RoanKattouw> I've never seen that bug [21:15:15] <RoanKattouw> It's probably doable, not sure how easy, not sure about what practical pitfalls might exist [21:15:24] <RoanKattouw> I'd suggest asking Moriel, though she just went on vacation [21:15:28] <James_F> RoanKattouw: Sure. I think we can proceed without… [21:15:50] * James_F shrugs. [21:15:51] <RoanKattouw> You'd probably want to do something like detect how many strongly-rtl characters there are? [21:15:52] <stephanebisson_> etonkovidova: I see both [21:16:04] <etonkovidova> stephanebisson_: ok then [21:16:08] <RoanKattouw> Which means you need unicodejs-style data about stuff, but probably in PHP intead [21:16:16] <James_F> RoanKattouw: Why in PHP? [21:16:24] <RoanKattouw> and langdetect as Matt points out [21:16:52] <RoanKattouw> James_F: Posts don't change much, it would be nice to compute the lang/dir once server-side then just serve it to clients, rather than having every client recompute it every time and FODC [21:16:58] <RoanKattouw> *FOUDC [21:17:01] <James_F> Fair. [21:31:20] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Enable the Flow user talk opt-in Beta Feature on cawiki - https://phabricator.wikimedia.org/T120829#1870819 (10Catrope) Deployed (early because of deployment schedule weirdness), seems to be working. [21:31:45] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Spread permission to move flow boards? - https://phabricator.wikimedia.org/T120468#1870821 (10Catrope) Deployed (early due to deployment schedule weirdness) [21:35:18] <James_F> quiddity: ^^^ FYI re. cawiki. [21:39:07] <quiddity> thanks, I've updated their VPT topic [21:48:05] <wikibugs> 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Make sure mw-vagrant Flow role creates users/groups required for Flow browser tests - https://phabricator.wikimedia.org/T115515#1870863 (10Etonkovidova) ``` (21:44) root@localhost:[wiki]> select user_name from user where user_name like 'Selenium%'; +---... [21:51:59] <James_F> quiddity: Yay. [22:01:51] <quiddity> RoanKattouw, should regular users be able to move Flow boards yet? (i.e. https://phabricator.wikimedia.org/T120468#18708 ) I just tried with volunteer account, and cannot. [22:02:41] <quiddity> i.e. I still get http://i.imgur.com/RJ4SHQP.png [22:03:43] <RoanKattouw> quiddity: On mw.org anyone ought to be able to move Flow boards now [22:03:48] <quiddity> nope [22:03:52] <RoanKattouw> quiddity: Could you see if your volunteer account can use Special:EnableFlow? [22:04:31] <quiddity> RoanKattouw, yes, can use special:enableflow [22:04:55] <RoanKattouw> OK, weird [22:05:07] <RoanKattouw> I'll investigate in a minute [22:05:21] <quiddity> <3 [22:13:29] <wikibugs> 3Collaboration-Team-Current, 10Echo, 10Flow, 5Patch-For-Review: Write presentation models for notifications in Flow - https://phabricator.wikimedia.org/T116845#1870916 (10Etonkovidova) Checked in betalabs all types of messages mentioned in the ticket. [22:13:51] <quiddity> RoanKattouw, oh, possibly because there's a redirect at the target location... I'll delete that and try again... [22:15:50] <James_F> quiddity: Oh, if you're changing the content type that's a problem, yeah. [22:15:52] * James_F grumbles. [22:16:58] <quiddity> This is related to https://phabricator.wikimedia.org/T102300 [22:17:34] <James_F> No doubt. [22:17:43] <James_F> But also to "don't let users change the content model of a page". [22:20:06] <quiddity> I thought there was a patch for that? [22:20:15] <halfak> o/ jmatazzoni__ [22:46:15] <wikibugs> 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-CentralAuth, 7Wikimedia-log-errors: CentralAuthCreateLocalAccountJob failing on meta due to Echo deadlocks - https://phabricator.wikimedia.org/T121161#1871031 (10Legoktm) 3NEW [22:58:46] <grrrit-wm> (03CR) 10Catrope: [C: 04-1] "Looks great! Comments inline" (038 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) (owner: 10Sbisson) [23:00:09] <RoanKattouw> quiddity: BTW, interim solution for listing Flow pages on a wiki: https://quarry.wmflabs.org/query/6362 . You can edit/copy/clone the query to change the dbname and get lists for different wikis [23:00:52] <RoanKattouw> (Namespaces: 1 is talk, 3 is user talk, 4 is project (Wikipedia:), 5 is project talk, >100 are custom local namespaces) [23:07:55] <quiddity> awesome, thanks. And <3 quarry. I've used it a bit, mostly just adapting other people's SQL. [23:08:32] <RoanKattouw> I don't use it much because I have stat1003 :D [23:08:46] <RoanKattouw> But for slow things like this and being able to share the results, it's nice [23:08:52] <quiddity> :) [23:16:19] <grrrit-wm> (03CR) 10Catrope: [C: 04-1] Add OOUI widgets for cross-wiki bundled notifications (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) (owner: 10Mooeypoo) [23:19:37] <RoanKattouw> 421 Undefined index: html in /srv/mediawiki/php-1.27.0-wmf.8/extensions/Echo/includes/DataOutputFormatter.php on line 149 [23:20:01] <RoanKattouw> legoktm: ---^^ [23:20:08] <RoanKattouw> Apparently that's $legacyFormat = self::$legacyMapping[$format]; [23:20:32] <RoanKattouw> I guess we just need isset etc there [23:20:39] <RoanKattouw> Because we're probably breaking notformat=html now [23:21:13] <legoktm> uhh [23:21:57] <RoanKattouw> Yup we did: https://en.wikipedia.org/w/api.php?action=query&meta=notifications¬format=html [23:22:03] <RoanKattouw> Although probably very little uses that? [23:22:37] <RoanKattouw> More error log fun, in Flow this time: [23:22:39] <RoanKattouw> 3 Invalid operand type was used: array_slice expects an array or collection as argument 1 in /srv/mediawiki/php-1.27.0-wmf.8/extensions/Flow/includes/Formatter/His [23:22:40] <RoanKattouw> toryQuery.php on line 121 [23:22:42] <RoanKattouw> 3 Invalid operand type was used: array_merge expects array(s) in /srv/mediawiki/php-1.27.0-wmf.8/extensions/Flow/includes/Formatter/HistoryQuery.php on line 122 [23:22:44] <RoanKattouw> 3 data error in /srv/mediawiki/php-1.27.0-wmf.8/includes/Revision.php on line 1325 [23:22:45] <RoanKattouw> 3 array_filter() expects parameter 1 to be an array or collection in /srv/mediawiki/php-1.27.0-wmf.8/extensions/Flow/includes/Formatter/HistoryQuery.php on line 11 [23:22:47] <RoanKattouw> 5 [23:24:04] <grrrit-wm> (03PS1) 10Legoktm: Unbreak notformat=text|html in the API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258376 [23:24:09] <legoktm> RoanKattouw: how's that ^? [23:24:38] <grrrit-wm> (03CR) 10Catrope: [C: 032] Unbreak notformat=text|html in the API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258376 (owner: 10Legoktm) [23:24:40] <RoanKattouw> Thanks [23:27:23] <grrrit-wm> (03PS1) 10Legoktm: Unbreak notformat=text|html in the API [extensions/Echo] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258377 [23:27:40] <legoktm> RoanKattouw: so SWAT is full :/ [23:27:40] <grrrit-wm> (03CR) 10Catrope: [C: 032] Unbreak notformat=text|html in the API [extensions/Echo] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258377 (owner: 10Legoktm) [23:27:48] <legoktm> but you're going to deploy it, ok :P [23:28:16] <RoanKattouw> I'm just gonna do it now [23:28:19] <RoanKattouw> I mean, it's fataling [23:28:23] <RoanKattouw> As is the Math thing [23:29:52] <RoanKattouw> OK I guess this one isn't a fatal (the Math thing is), but it is broken [23:30:58] <grrrit-wm> (03Merged) 10jenkins-bot: Unbreak notformat=text|html in the API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/258376 (owner: 10Legoktm) [23:31:03] <grrrit-wm> (03PS73) 10Catrope: Add OOUI widgets for cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) (owner: 10Mooeypoo) [23:31:25] <wikibugs> 3Collaboration-Team-Current, 10Echo, 10Flow, 10Thanks, and 3 others: "Thanks" alert in Echo: "Due to a technical error, this post could not be retrieved" instead of Flow discussion subject - https://phabricator.wikimedia.org/T120934#1871590 (10Etonkovidova) Checked in betalabs - cases for - changing langu... [23:32:28] <wikibugs> 3Collaboration-Team-Current, 10Echo, 10Flow, 10Thanks, and 3 others: "Thanks" alert in Echo: "Due to a technical error, this post could not be retrieved" instead of Flow discussion subject - https://phabricator.wikimedia.org/T120934#1871593 (10Catrope) 5Open>3Resolved [23:35:20] <grrrit-wm> (03Merged) 10jenkins-bot: Unbreak notformat=text|html in the API [extensions/Echo] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258377 (owner: 10Legoktm)