[00:12:53] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Give the user the number of history items they asked for - https://phabricator.wikimedia.org/T108291#1864228 (10Etonkovidova) Checked in betalabs. I thought that the fix should apply to the case when a non-admi... [00:39:01] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Flow history page issues (tracking) - https://phabricator.wikimedia.org/T85563#1864294 (10Jdlrobson) [00:39:02] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Flow history page issues (tracking) - https://phabricator.wikimedia.org/T108363#1864292 (10Jdlrobson) [00:39:04] 6Collaboration-Team-Backlog, 10Flow, 10MobileFrontend, 7Easy, and 2 others: action=history should not redirect to Special:History for Flow boards - https://phabricator.wikimedia.org/T93491#1864291 (10Jdlrobson) 5Open>3Resolved [00:39:07] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Mobile web - Flow issues (tracking) - https://phabricator.wikimedia.org/T93430#1864293 (10Jdlrobson) [00:41:36] 6Collaboration-Team-Backlog, 10MobileFrontend: Very long talk pages unreadable - https://phabricator.wikimedia.org/T116686#1755662 (10Jdlrobson) [00:54:30] (03PS1) 10Legoktm: Use CentralIdLookup instead of hardcoding for CentralAuth [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257798 [01:06:47] (03CR) 10Catrope: [C: 032] Use CentralIdLookup instead of hardcoding for CentralAuth [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257798 (owner: 10Legoktm) [01:09:49] (03Merged) 10jenkins-bot: Use CentralIdLookup instead of hardcoding for CentralAuth [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257798 (owner: 10Legoktm) [02:29:50] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Incomplete GENDER support for notification-mention and related messages - https://phabricator.wikimedia.org/T119321#1864454 (10Etonkovidova) Checked in betalabs. Three questions: 1) Seems that notification-men... [03:13:15] (03PS3) 10Abdumuhaimin: Add GENDER to flow-notification-link-text-enabled-on-talkpage (fixed) Bug: T113784 Change-Id: I70b20e001614ed84244361d227aa41864d74d67e [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) [03:18:52] (03PS4) 10Catrope: Add GENDER to flow-notification-link-text-enabled-on-talkpage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [03:19:00] (03CR) 10Catrope: [C: 032] Add GENDER to flow-notification-link-text-enabled-on-talkpage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [03:19:29] (03Abandoned) 10Catrope: en.json: Add GENDER support to the file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257571 (owner: 10Abdumuhaimin) [03:22:43] (03Merged) 10jenkins-bot: Add GENDER to flow-notification-link-text-enabled-on-talkpage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [05:34:45] 6Collaboration-Team-Backlog, 10Flow, 10MobileFrontend, 7Easy, and 2 others: action=history should not redirect to Special:History for Flow boards - https://phabricator.wikimedia.org/T93491#1864597 (10Florian) [06:54:25] 3Collaboration-Team-Current, 10Flow, 10MobileFrontend, 7Easy, and 2 others: action=history should not redirect to Special:History for Flow boards - https://phabricator.wikimedia.org/T93491#1864610 (10Legoktm) [07:02:17] (03PS1) 10Legoktm: Bump Schema:Echo to oldid=7731316 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257825 [07:22:32] 3Collaboration-Team-Current, 10Echo, 7Easy, 3Google-Code-In-2015, and 2 others: Special:Notifications should use UserNotLoggedIn and auto-redirect to login page instead of custom error message - https://phabricator.wikimedia.org/T118873#1864651 (10Legoktm) [07:33:07] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 3Google-Code-In-2015: Use the double speech bubble icon in the Messages panel - https://phabricator.wikimedia.org/T119377#1864661 (10Legoktm) [07:54:33] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 3Google-Code-In-2015: Use the double speech bubble icon in the Messages panel - https://phabricator.wikimedia.org/T119377#1864692 (10Legoktm) https://codein.withgoogle.com/dashboard/tasks/5200329926770688/ [08:41:52] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: AbuseFilter test tools does not work for Flow edits - https://phabricator.wikimedia.org/T115128#1864753 (10Luke081515) p:5Triage>3High [08:43:53] 6Collaboration-Team-Backlog, 10Flow, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable Flow for testing on Hungarian Wikipedia - https://phabricator.wikimedia.org/T119365#1864756 (10Luke081515) p:5Triage>3Normal [08:44:03] 6Collaboration-Team-Backlog, 10Echo: User preferences for cross-wiki notifications - https://phabricator.wikimedia.org/T114917#1864761 (10Luke081515) p:5Triage>3Normal [08:47:26] 6Collaboration-Team-Backlog, 10Echo, 7Easy: Notification panel footer is too big compared to the header - https://phabricator.wikimedia.org/T119375#1864768 (10Luke081515) p:5Triage>3Low [08:47:29] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-skins-Metrolook, 5Patch-For-Review: Echo doesn't look good in metrolook - https://phabricator.wikimedia.org/T119134#1864769 (10Luke081515) p:5Triage>3Low [08:47:31] 6Collaboration-Team-Backlog, 10Echo: Make echo colourful - https://phabricator.wikimedia.org/T117923#1864771 (10Luke081515) p:5Triage>3Low [10:51:47] 3Collaboration-Team-Current, 10Echo: Add filtering for unread notifications only to meta=notifications API - https://phabricator.wikimedia.org/T119890#1864927 (10matthiasmullie) a:3matthiasmullie [12:23:15] 6Collaboration-Team-Backlog, 10Echo, 10Flow, 10Thanks: "Thanks" alert in Echo: "Due to a technical error, this post could not be retrieved" instead of Flow discussion subject - https://phabricator.wikimedia.org/T120934#1865057 (10Aklapper) 3NEW [15:54:32] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Email, 7Crosswiki, 7Epic: Please add cross-wiki talk page notification. - https://phabricator.wikimedia.org/T3066#1865594 (10matej_suchanek) [17:57:20] (03CR) 10Legoktm: [C: 032] Presentation model for page-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [17:57:27] (03CR) 10Legoktm: [C: 032] Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:02:18] (03Merged) 10jenkins-bot: Presentation model for page-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:02:22] (03CR) 10jenkins-bot: [V: 04-1] Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:03:51] (03PS1) 10Matěj Suchánek: Fix braces by {{GENDER:}} [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257951 [18:08:31] (03CR) 10Legoktm: [C: 032] "Oops." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257951 (owner: 10Matěj Suchánek) [18:09:37] (03PS21) 10Legoktm: Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:10:27] (03CR) 10Legoktm: "PS19: Stephane's rebase, PS20: My rebase, PS21: Revert to PS19." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:10:59] (03CR) 10Legoktm: Presentation model for edit-user-talk (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:13:26] (03Merged) 10jenkins-bot: Fix braces by {{GENDER:}} [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257951 (owner: 10Matěj Suchánek) [18:26:11] (03CR) 10Sbisson: Presentation model for edit-user-talk (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:28:01] stephanebisson: errr, the message key "notification-page-linked-bundle" is used by EditUserTalk ?? [18:29:08] legoktm: oups, no [18:30:04] it shouldn't be used at all, I don't know how it ended up in my merge [18:31:38] (03PS22) 10Sbisson: Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) [18:35:43] stephanebisson: looks like its in qqq too [18:35:43] (03CR) 10jenkins-bot: [V: 04-1] Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:35:44] (03PS23) 10Sbisson: Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) [18:40:11] (03CR) 10Legoktm: [C: 032] Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:40:42] (03PS22) 10Catrope: Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [18:42:02] (03CR) 10Catrope: "PS22: Add ViewingUserForGender in all places where it's needed" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [18:43:28] (03PS1) 10Matthias Mullie: Share code between EchoNotificationMapper::fetchByUser & fetchUnreadByUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257961 [18:43:31] (03PS1) 10Matthias Mullie: Also support continuation requests for [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257962 [18:43:34] (03Merged) 10jenkins-bot: Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:45:57] (03CR) 10jenkins-bot: [V: 04-1] Share code between EchoNotificationMapper::fetchByUser & fetchUnreadByUser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257961 (owner: 10Matthias Mullie) [18:46:52] (03CR) 10jenkins-bot: [V: 04-1] Also support continuation requests for [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257962 (owner: 10Matthias Mullie) [19:00:21] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-11-10_(1.27.0-wmf.6), 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Write presentation models for notifications in Echo - https://phabricator.wikimedia.org/T116843#1866395 (10SBisson) [19:35:24] (03CR) 10Catrope: [C: 04-1] Also support continuation requests for (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257962 (owner: 10Matthias Mullie) [19:37:39] stephanebisson: do you think that my comment #1 in T119321 "Incomplete GENDER support for notification-mention and related messages" justifies filing a separate bug? [19:38:07] stephanebisson: I cannot see the same issue in, say, French... [19:40:24] etonkovidova: Under normal circumstances I'd say yes, but once legoktm finishes the email formatter, most (if not all) of the email-specific messages are gonna go away [19:42:34] etonkovidova: all 'mention' messages seem to have gender support [19:45:20] etonkovidova: the 2nd case you mention in the bug is really weird [19:46:15] "Et12 thanked you [...] in "en raison d'une erreur technique [...]", with links in Russian [19:46:51] So, message in English, error message for post that can't be retrieved in French, and links in Russian [19:47:14] stephanebisson: thx! Can you add your comments to the ticket? Then I can move it to Product Review ? :) [19:50:25] o.O [19:50:32] You don't see trilingual messages very often [19:51:38] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Incomplete GENDER support for notification-mention and related messages - https://phabricator.wikimedia.org/T119321#1866566 (10SBisson) # All 'mention' messages seem to support gender. It is possible that the mes... [20:11:48] In other news, I have now created a crash loop in Google Docs spreadsheets [20:11:51] By including an SVG image [20:34:26] 6Collaboration-Team-Backlog, 10Flow: History: quotes around titles with links should have additional space - https://phabricator.wikimedia.org/T121002#1866758 (10Etonkovidova) 3NEW [20:35:31] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-12-15_(1.27.0-wmf.9): Brackets appear in history when topic title that contains link is changed - https://phabricator.wikimedia.org/T120329#1866770 (10Etonkovidova) Checked in betalabs. No brackets in title links {F3061997} The quot... [21:27:58] who uses `make qunit`? [21:28:34] 3Collaboration-Team-Current, 10Flow: Regression: notification message for changed topic's title is incorrect - https://phabricator.wikimedia.org/T121016#1866979 (10Etonkovidova) 3NEW [21:30:26] 3Collaboration-Team-Current, 10Flow: Regression: notification message for changed topic's title is incorrect - https://phabricator.wikimedia.org/T121016#1866989 (10SBisson) Is it the same as {T109784}? [21:43:49] 3Collaboration-Team-Current, 10Echo: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1867039 (10jmatazzoni) [21:45:11] 3Collaboration-Team-Current, 10Flow: Regression: notification message for changed topic's title is incorrect - https://phabricator.wikimedia.org/T121016#1867053 (10Catrope) >>! In T121016#1866989, @SBisson wrote: > Is it the same as {T109784}? Yes. [21:45:25] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Email notification: The new renamed topic title is displayed in place for the previous title - https://phabricator.wikimedia.org/T109784#1867055 (10Catrope) [21:45:26] 3Collaboration-Team-Current, 10Flow: Regression: notification message for changed topic's title is incorrect - https://phabricator.wikimedia.org/T121016#1867054 (10Catrope) [21:50:33] (03PS2) 10Paladox: Update grunt-jsonlint to 1.0.6 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251731 [21:57:07] (03PS3) 10Paladox: Update JS closure style [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253899 [21:59:18] (03PS4) 10Paladox: Update JS closure style [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253899 [22:03:28] (03CR) 10Paladox: Update grunt-jscs to 2.3.0 (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 (owner: 10Paladox) [22:08:49] (03PS19) 10Paladox: Update grunt-jscs to 2.5.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 [22:10:36] stephanebisson: can you take a quick look at T121016; mooeypoo suggested that you may see the cause for that bug :) [22:10:55] sure [22:11:30] etonkovidova: it's been closed as a duplicate by Roan [22:11:44] stephanebisson: sorry - missed that [22:12:02] etonkovidova: it is also fixed as part of the Flow presentation model T116845 [22:12:10] should be merged soon [22:12:38] etonkovidova: this is one of those "how did this ever worked?" [22:12:55] stephanebisson: hmm... my bug looks new [22:13:08] I am sure it'd be noticed before [22:13:36] anyway, if RoanKattouw says duplicate - it's a duplicate [22:14:23] Yeah I'm pretty sure this is a dupe, and it was kind of shocking [22:14:26] it was clearly a bug when you filed T109784 on August 20 [22:14:28] As stephanebisson said, how did it ever work [22:14:43] 3Collaboration-Team-Current, 10Flow: Regression: notification message for changed topic's title is incorrect - https://phabricator.wikimedia.org/T121016#1867212 (10Etonkovidova) [22:14:59] and it was still a bug when I started working on the Flow Presentation models a few weeks back [22:15:24] kk [22:15:26] it's scary how long things stay broken [22:17:29] 3Collaboration-Team-Current, 10Flow: Notification message for changed topic's title is incorrect - https://phabricator.wikimedia.org/T121016#1867225 (10Etonkovidova) [22:32:31] 3Collaboration-Team-Current, 10Echo: Notification panel: Clearer use of notification badges - https://phabricator.wikimedia.org/T115845#1867326 (10Mooeypoo) a:3Pginer-WMF [22:35:10] mooeypoo: https://phabricator.wikimedia.org/T120725 [23:16:09] hey ya'll, is this a known issue? (sorry, only have a couple minutes between meetings): http://i.imgur.com/icXjl8a.png [23:17:38] found it https://phabricator.wikimedia.org/T120934 [23:18:25] 6Collaboration-Team-Backlog, 10Echo, 10Flow, 10Thanks: "Thanks" alert in Echo: "Due to a technical error, this post could not be retrieved" instead of Flow discussion subject - https://phabricator.wikimedia.org/T120934#1867599 (10greg) Same on officewiki for me. {F3062376} [23:23:00] greg-g, yeah we got a few people complaining about that in the past few minutes. It's a parsoid/api problem, but the notification should *probably* adjust somehow once the problem is fixed (?) we're looking into that [23:23:04] thanks! [23:23:31] RoanKattouw, ^ [23:27:16] mooeypoo: thank you! [23:28:40] Hmm, I wonder if it ever *does* work [23:28:47] Is it intermittent, or is it consistently broken? [23:29:55] It could just as easily be a regression from the topic title patch [23:31:07] Yup it's structural [23:35:59] (03PS1) 10Catrope: ApiFlowThank: Update for topic title changes in Flow [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/258067 (https://phabricator.wikimedia.org/T120934) [23:36:16] legoktm: I can haz code review? ---^^ [23:36:24] * legoktm looks [23:36:56] greg-g: Also, assuming that gets merged, can I add that to the SWAT? :) [23:37:08] (03CR) 10Legoktm: [C: 032] ApiFlowThank: Update for topic title changes in Flow [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/258067 (https://phabricator.wikimedia.org/T120934) (owner: 10Catrope) [23:37:11] (I will also volunteer to do the SWAT; Krinkle has some interesting RL changes in there as well) [23:37:16] Oh there we go, thanks legoktm [23:43:39] (03Merged) 10jenkins-bot: ApiFlowThank: Update for topic title changes in Flow [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/258067 (https://phabricator.wikimedia.org/T120934) (owner: 10Catrope) [23:43:51] (03PS1) 10Catrope: ApiFlowThank: Update for topic title changes in Flow [extensions/Thanks] (wmf/1.27.0-wmf.8) - 10https://gerrit.wikimedia.org/r/258069 (https://phabricator.wikimedia.org/T120934) [23:45:50] RoanKattouw: yeppers