[00:08:31] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Community-consensus-needed, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1860849 (10Jdforrester-WMF) [00:08:33] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable the Flow personal talk opt-in Beta Feature on bswiki - https://phabricator.wikimedia.org/T117991#1860847 (10Jdforrester-WMF) 5Open>3Resolved This is now done: https://bs.wikipedia.org/wiki/Razgovor_sa_korisnikom:J... [00:08:48] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable the Flow personal talk opt-in Beta Feature on urwiki - https://phabricator.wikimedia.org/T117992#1860850 (10Jdforrester-WMF) 5Open>3Resolved a:3Jdforrester-WMF This is now done: https://ur.wikipedia.org/wiki/%D8... [00:08:50] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Community-consensus-needed, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1788617 (10Jdforrester-WMF) [00:10:33] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Community-consensus-needed, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1860869 (10Jdforrester-WMF) >>! In T117990#1841837, @doctaxon wrote: > No, you need community... [00:10:39] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1860870 (10Jdforrester-WMF) [00:19:09] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable the Flow personal talk opt-in Beta Feature on bswiki - https://phabricator.wikimedia.org/T117991#1860935 (10Catrope) p:5Low>3High [00:19:24] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable the Flow personal talk opt-in Beta Feature on urwiki - https://phabricator.wikimedia.org/T117992#1860948 (10Catrope) p:5Low>3High [00:20:24] wtf why did it change the prio, I just dragged those tasks [00:40:26] (03PS70) 10Mooeypoo: Add OOUI widgets for cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) [00:49:47] (03PS1) 10Catrope: Follow-up 65638384: update calls to normalizer functions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257507 [00:49:51] mooeypoo: --^^ [01:28:33] quiddity: I'm writing you what turned into a giant email about message key changes [01:28:39] hence the delay [01:39:01] (03PS71) 10Mooeypoo: Add OOUI widgets for cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) [01:39:46] (03CR) 10Mooeypoo: [C: 032] Follow-up 65638384: update calls to normalizer functions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257507 (owner: 10Catrope) [01:41:59] (03PS1) 10Mooeypoo: [wip] Add secondary links to notifications from Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257519 [01:43:04] (03Merged) 10jenkins-bot: Follow-up 65638384: update calls to normalizer functions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257507 (owner: 10Catrope) [01:43:23] that sha1 was purely numeric? :o [01:43:45] too short for gerrit to find it though :/ [01:44:27] Gerrit doesn't find purely numeric SHA-1s [01:44:31] Because it thinks their change numbers [01:44:35] *they're [03:21:16] (03PS1) 10Aaron Schulz: Replace DB begin()/commit() with startAtomic()/endAtomic() as needed [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/257542 (https://phabricator.wikimedia.org/T120791) [08:51:54] 6Collaboration-Team-Backlog, 10Thanks, 7Community-Wishlist-Survey: Opt out of Thanks feature - https://phabricator.wikimedia.org/T120753#1861562 (10Reedy) [09:36:22] (03CR) 10Addshore: [C: 032] Replace DB begin()/commit() with startAtomic()/endAtomic() as needed [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/257542 (https://phabricator.wikimedia.org/T120791) (owner: 10Aaron Schulz) [09:40:21] (03Merged) 10jenkins-bot: Replace DB begin()/commit() with startAtomic()/endAtomic() as needed [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/257542 (https://phabricator.wikimedia.org/T120791) (owner: 10Aaron Schulz) [09:51:59] (03PS1) 10Matthias Mullie: Bring in line with current getPrimaryLinks expected output [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/257561 [10:05:31] (03PS1) 10Abdumuhaimin: Edited the en.json file by adding the GENDER support for the message Flow-notification-link-text-enabled-on-talkpage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 [10:11:51] (03CR) 10Mooeypoo: "Great progress, Abdumuhaimin. There's a small comment that I wrote to you in the file itself. Fix it, and I'll approve the task for Google" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (owner: 10Abdumuhaimin) [10:30:29] (03PS1) 10Abdumuhaimin: Code's done :) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257571 [10:52:29] (03PS2) 10Abdumuhaimin: en.json file at i18n: code's done :D [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257571 [10:57:00] (03PS1) 10Matthias Mullie: Minor phpdoc/coding standards fixes or code optimizations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257573 [11:01:30] (03CR) 10Aklapper: "Hi Abdu! Thanks for your patch! Could you adjust the commit message a bit? See https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidel" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (owner: 10Abdumuhaimin) [13:14:16] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on some wikis - https://phabricator.wikimedia.org/T117990#1861997 (10MGChecker) [13:15:03] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests: Enable the Flow personal talk opt-in Beta Feature on cswiki - https://phabricator.wikimedia.org/T119351#1861999 (10MGChecker) [13:19:59] (03CR) 10Abdumuhaimin: "Aklapper: I had. See the edited code here: https://gerrit.wikimedia.org/r/#/c/257571/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (owner: 10Abdumuhaimin) [13:25:15] (03PS3) 10Abdumuhaimin: en.json: Add GENDER support to the file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257571 [13:25:55] (03PS4) 10Abdumuhaimin: en.json: Add GENDER support to the file [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257571 [13:34:13] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#1862032 (10Pginer-WMF) As I mentioned in the ticket description, we need to decide whether the scope includes only cross-wiki notifications or it is... [14:08:52] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257338 (owner: 10Sbisson) [14:12:06] (03CR) 10Sbisson: Minor phpdoc/coding standards fixes or code optimizations (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257573 (owner: 10Matthias Mullie) [14:14:53] (03CR) 10Sbisson: [C: 032] Unduplicate 'this page is an archive' message on converted pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256708 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [14:17:56] (03CR) 10jenkins-bot: [V: 04-1] Unduplicate 'this page is an archive' message on converted pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256708 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [14:19:00] (03CR) 10Sbisson: [C: 032] Fix some old code leftovers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243497 (owner: 10Matthias Mullie) [14:23:03] (03Merged) 10jenkins-bot: Fix some old code leftovers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243497 (owner: 10Matthias Mullie) [14:23:34] (03CR) 10Sbisson: [C: 031] Script to remove topics before a certain date [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [14:24:39] (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256708 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [14:28:00] (03CR) 10Krinkle: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256708 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [14:32:49] (03CR) 10Sbisson: Unduplicate 'this page is an archive' message on converted pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256708 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [14:32:56] (03CR) 10Sbisson: [C: 032] Unduplicate 'this page is an archive' message on converted pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256708 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [14:36:49] (03Merged) 10jenkins-bot: Unduplicate 'this page is an archive' message on converted pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256708 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [14:41:22] (03CR) 10Krinkle: "(failure due to T120824)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256708 (https://phabricator.wikimedia.org/T119509) (owner: 10Matthias Mullie) [14:48:47] * halfak looks around for Joe M. [14:48:51] Is he around on IRC? [14:49:00] Ahh. I see jmatazzoni__ [14:49:38] 6Collaboration-Team-Backlog, 10Flow: Enable the Flow user talk opt-in Beta Feature on cawiki - https://phabricator.wikimedia.org/T120829#1862175 (10Vriullop) 3NEW [15:14:39] (03PS1) 10Sbisson: Show topic title in plaintext in ToC [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) [15:44:05] 6Collaboration-Team-Backlog, 10Flow: Enable the Flow user talk opt-in Beta Feature on cawiki - https://phabricator.wikimedia.org/T120829#1862334 (10Jdforrester-WMF) [15:44:07] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on some wikis - https://phabricator.wikimedia.org/T117990#1862333 (10Jdforrester-WMF) [15:46:56] 3Collaboration-Team-Current, 10Flow, 7Regression: topic-title-wikitext conversion error when non-privileged user edits deleted topic - https://phabricator.wikimedia.org/T119157#1862343 (10SBisson) Do we want the links in topic titles to be actual links on the history page or do we just want the plaintext ver... [15:50:04] 3Collaboration-Team-Current, 10Flow: Brackets appear in history when topic title that contains link is changed - https://phabricator.wikimedia.org/T120329#1862355 (10SBisson) Do we want the links in topic titles to be actual links on the history page or do we just want the plaintext version? [16:16:52] (03CR) 10Aklapper: "@Abdu: Ah, thanks! Please try to avoid creating new patchsets. Instead amend your changes, because now your new patch technically requires" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (owner: 10Abdumuhaimin) [16:40:16] 6Collaboration-Team-Backlog, 10Flow, 10MobileFrontend, 7Easy, 7Mobile: action=history should not redirect to Special:History for Flow boards - https://phabricator.wikimedia.org/T93491#1862472 (10Florian) a:3Florian [17:00:00] (03PS1) 10Sbisson: Display topic title as plaintext on history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257640 (https://phabricator.wikimedia.org/T120329) [17:00:30] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Brackets appear in history when topic title that contains link is changed - https://phabricator.wikimedia.org/T120329#1862561 (10SBisson) a:3SBisson [17:24:02] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 3Google-Code-In-2015: Special:Notifications should use UserNotLoggedIn and auto-redirect to login page instead of custom error message - https://phabricator.wikimedia.org/T118873#1862596 (10Mhutti1) a:3Mhutti1 [17:50:01] (03PS2) 10Matthias Mullie: Minor phpdoc/coding standards fixes or code optimizations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257573 [17:50:06] (03CR) 10Matthias Mullie: Minor phpdoc/coding standards fixes or code optimizations (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257573 (owner: 10Matthias Mullie) [17:51:17] (03CR) 10Sbisson: [C: 032] Minor phpdoc/coding standards fixes or code optimizations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257573 (owner: 10Matthias Mullie) [17:55:44] (03Merged) 10jenkins-bot: Minor phpdoc/coding standards fixes or code optimizations [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257573 (owner: 10Matthias Mullie) [18:04:05] (03PS2) 10Nemo bis: Add GENDER to flow-notification-link-text-enabled-on-talkpage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [18:05:15] (03CR) 10Nemo bis: "See https://gerrit.wikimedia.org/r/#/c/257567/1..2//COMMIT_MSG,cm for how the commit message must look like." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [18:09:56] mooeypoo: just an observation... changing to Russian in betalabs - "thanked you for..." notification is still in English. *Any* other lang(hebrew, Chinese, Ukrainian, German) are ok [18:10:26] (03CR) 10Nemo bis: [C: 04-1] "This is an improvement over your previous patch, but there is no need to post is separately. Click "abandon" here." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257571 (owner: 10Abdumuhaimin) [18:10:36] mooeypoo: should we be concerned? :) [18:11:36] (03CR) 10Mooeypoo: [C: 04-1] "Hi Abdumuhaimin, please fix the underlying patchset, not this one. See Aklapper's comment in https://gerrit.wikimedia.org/r/#/c/257567/1 o" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257571 (owner: 10Abdumuhaimin) [18:11:39] (03PS1) 10Sbisson: Remove hardcoded token from patrol link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257655 (https://phabricator.wikimedia.org/T118225) [18:12:18] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Technical-Debt: Remove old hardcoded tokens from patrol links in Flow - https://phabricator.wikimedia.org/T118225#1862778 (10SBisson) p:5Triage>3Normal a:3SBisson [18:12:56] (03CR) 10Nemo bis: [C: 04-1] "includes/Notifications/Notifications.php is too obscure and undocumented for me; you need to check that 'primary-link' actually passes the" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [18:16:07] (03CR) 10Mooeypoo: "@Nemobis, actually, the string is about the current user, which could be referenced to with {{GENDER:|f|m}}, without the need of any param" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [18:16:16] (03CR) 10Mooeypoo: [C: 04-1] Add GENDER to flow-notification-link-text-enabled-on-talkpage [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [18:20:21] (03CR) 10Nemo bis: Add GENDER to flow-notification-link-text-enabled-on-talkpage (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [18:22:59] etonkovidova, hm that usually means that the russian isn't translated for that message [18:23:39] mooeypoo: if it's only in beta :) it's fine I was surprised that all other langs are fine [18:24:28] Hm, that's odd that it's only in beta [18:24:34] Maybe beta overrides that message? :\ [18:25:16] (03CR) 10Legoktm: [C: 04-1] Presentation model for edit-user-talk (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:28:19] (03PS18) 10Sbisson: Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) [18:28:37] (03CR) 10Legoktm: Presentation model for edit-user-talk (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:28:40] (03CR) 10Sbisson: Presentation model for edit-user-talk (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [18:51:00] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 10VisualEditor-ContentEditable: Firefox: ve-ce-chimera gets displayed sometimes in blank Flow boxes - https://phabricator.wikimedia.org/T98544#1862954 (10Jdforrester-WMF) [19:02:17] (03Merged) 10jenkins-bot: Remove hardcoded token from patrol link [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257655 (https://phabricator.wikimedia.org/T118225) (owner: 10Sbisson) [19:02:29] (03PS15) 10Sbisson: Presentation model for page-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) [19:04:45] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 3Google-Code-In-2015: Special:Notifications should use UserNotLoggedIn and auto-redirect to login page instead of custom error message - https://phabricator.wikimedia.org/T118873#1863032 (10Mhutti1) I have uploaded a patch https://gerrit.wikimedia.org/r/#/c/257661/ [19:07:38] 3Collaboration-Team-Current, 10Echo: Fix EventLogging for cross-wiki notifications - https://phabricator.wikimedia.org/T120158#1863035 (10Catrope) p:5Triage>3Normal [19:11:48] 3Collaboration-Team-Current, 10Echo, 10Gather, 5Patch-For-Review: Write presentation models for notifications in Gather - https://phabricator.wikimedia.org/T116848#1863046 (10Jdlrobson) Patch is -1ed. Since gather is only mobile beta this particular task is this really a high priority? [19:27:27] (03CR) 10Legoktm: [C: 04-1] "Good work! I left some inline comments. You also need to add message documentation to the "qqq.json" file, see (03CR) 10Sbisson: Presentation model for page-linked (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [19:35:02] (03CR) 10Catrope: [C: 04-1] Redirects annonomous user to login page from Special:Notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257661 (owner: 10Mhutti1) [19:36:19] 3Collaboration-Team-Current, 10Echo, 10Gather, 5Patch-For-Review: Write presentation models for notifications in Gather - https://phabricator.wikimedia.org/T116848#1863177 (10Legoktm) When Echo switches over to the new system and drops support for the old one, Gather's notifications won't be displayed in t... [19:37:59] 6Collaboration-Team-Backlog, 10Thanks, 7Community-Wishlist-Survey: Opt out of Thanks feature - https://phabricator.wikimedia.org/T120753#1863189 (10Legoktm) What does "opt-out" mean? You can turn off receiving thanks notifications in your preferences... [19:41:56] (03PS2) 10Mhutti1: Redirects annonomous user to login page from Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257661 (https://phabricator.wikimedia.org/T118873) [19:43:57] https://www.mediawiki.org/wiki/Echo_%28Notifications%29/Feature_requirements#Icons_and_types [19:44:00] mooeypoo, ^ [19:44:04] thanks! [19:46:58] (03PS3) 10Sbisson: [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (owner: 10Catrope) [19:47:18] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (owner: 10Catrope) [19:48:12] (03CR) 10Legoktm: [C: 04-1] "A few minor things left! :)" (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257661 (https://phabricator.wikimedia.org/T118873) (owner: 10Mhutti1) [19:49:55] mooeypoo: any movement on your Echo patches? [19:50:12] I'm hoping to clear out the MobileFrontend open patchsets over xmas to clean up before some big changes are made [19:50:43] I fear if your patch is not done before those changes it's gonna cause you more pain on the long term :) [19:52:57] (03PS3) 10Mhutti1: Redirects annonomous user to login page from Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257661 (https://phabricator.wikimedia.org/T118873) [19:53:49] 3Collaboration-Team-Current, 10Echo, 10Gather, 5Patch-For-Review: Write presentation models for notifications in Gather - https://phabricator.wikimedia.org/T116848#1863326 (10Catrope) >>! In T116848#1863046, @Jdlrobson wrote: > Patch is -1ed. Since gather is only mobile beta this particular task is this re... [19:55:47] (03CR) 10Catrope: "@Mooeypoo: You are missing that notifications can be formatter for different users than the current user (emails!), so in general, {{GENDE" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [19:56:07] (03PS4) 10Legoktm: Redirect anonymous user to login page from Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257661 (https://phabricator.wikimedia.org/T118873) (owner: 10Mhutti1) [19:56:45] (03CR) 10Legoktm: [C: 032] Redirect anonymous user to login page from Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257661 (https://phabricator.wikimedia.org/T118873) (owner: 10Mhutti1) [19:58:51] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 3Google-Code-In-2015, 5Patch-For-Review: Special:Notifications should use UserNotLoggedIn and auto-redirect to login page instead of custom error message - https://phabricator.wikimedia.org/T118873#1863347 (10Legoktm) 5Open>3Resolved Awesome work! [19:59:47] (03Merged) 10jenkins-bot: Redirect anonymous user to login page from Special:Notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/257661 (https://phabricator.wikimedia.org/T118873) (owner: 10Mhutti1) [20:01:03] ^ first GCI patch merged? :D [20:01:10] 6Collaboration-Team-Backlog, 10Flow, 7Easy: Flow: Provide more relevant error message if internet connection is lost - https://phabricator.wikimedia.org/T118680#1863360 (10Nemo_bis) [20:01:18] 6Collaboration-Team-Backlog, 10Flow, 7Easy, 7I18n: Flow: Provide more relevant error message if internet connection is lost - https://phabricator.wikimedia.org/T118680#1806450 (10Nemo_bis) [20:03:56] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 7I18n: Links on notification-page-linked, -bundle, -flyout etc. - https://phabricator.wikimedia.org/T69942#1863378 (10Nemo_bis) [20:05:30] jdlrobson, we just talked about this in our morning meeting; we've done massive reworking of our notifications system, the mobile work will be coming up after that so we don't have to test/break everything at once [20:23:59] (03CR) 10Abdumuhaimin: "@Mooeypoo: sorry, mentor. I'm totally confused and deadlocked with this. First of all, when I edited the en.json file, the git kept on say" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257571 (owner: 10Abdumuhaimin) [20:24:29] mooeypoo: okay. Just don't hate me if In early January it needs another rewrite due to us splitting apart MobileFrontend... :) [20:30:51] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#1863561 (10Quiddity) Note that during a meeting, we discussed the desire of having a clear, precise, and standard keyword, for referring to any featu... [20:33:08] jdlrobson, :p fair enough [20:52:10] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Email, 7Crosswiki, 7Epic: Please add cross-wiki talk page notification. - https://phabricator.wikimedia.org/T3066#1863703 (10Jdforrester-WMF) 5duplicate>3Open Re-opening as the overall delivery of Global notifications, instead of the technology side. [20:52:43] 6Collaboration-Team-Backlog, 10Echo, 7Epic, 7WorkType-NewFunctionality, 7user-notice: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#1863710 (10Jdforrester-WMF) [20:52:46] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Email, 7Crosswiki, 7Epic: Please add cross-wiki talk page notification. - https://phabricator.wikimedia.org/T3066#1863709 (10Jdforrester-WMF) [20:59:10] (03CR) 10Addshore: [C: 04-1] "needs manual rebase" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/188604 (owner: 10Matthias Mullie) [21:15:22] 3Collaboration-Team-Current, 10Echo: Write script to backfill echo_unseen_wikis table - https://phabricator.wikimedia.org/T119523#1863772 (10SBisson) I see that NotifUser::resetNotificationCount does that in different context. Any reasons why looping on the users and calling it would be a bad idea? [21:34:39] 3Collaboration-Team-Current, 10Echo: Write script to backfill echo_unseen_wikis table - https://phabricator.wikimedia.org/T119523#1863863 (10Legoktm) It has unintended side-effects that we probably don't want like setting it in memcached and invalidating the user cache. Also if possible we should aim to do bat... [21:46:22] (03CR) 10Mooeypoo: "Alright, let's take this step by step. You're doing great, this is only the final stretch for this task, and the good news is that once we" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257571 (owner: 10Abdumuhaimin) [21:52:44] (03CR) 10Mooeypoo: "@Catrope, okay, you're right, it's my fault for not thinking about this when putting this task up for GCI." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [21:53:52] 6Collaboration-Team-Backlog, 10Thanks, 7Community-Wishlist-Survey: Opt out of Thanks feature - https://phabricator.wikimedia.org/T120753#1863895 (10Quiddity) There's extensive (collapsed) discussion in the linked topic. Essentially, IIUC, the user(s) endorsing the proposal, want 1 of these 3 things to happen... [22:13:14] (03CR) 10Catrope: "@Mooeypoo You're looking at the wrong message, and in unmergd code." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257567 (https://phabricator.wikimedia.org/T113784) (owner: 10Abdumuhaimin) [23:19:06] (03PS72) 10Mooeypoo: Add OOUI widgets for cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) [23:19:25] (03CR) 10jenkins-bot: [V: 04-1] Add OOUI widgets for cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) (owner: 10Mooeypoo) [23:26:49] (03CR) 10Catrope: [C: 04-1] Show topic title in plaintext in ToC (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257605 (https://phabricator.wikimedia.org/T119537) (owner: 10Sbisson) [23:38:46] (03CR) 10Catrope: [C: 032] Display topic title as plaintext on history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257640 (https://phabricator.wikimedia.org/T120329) (owner: 10Sbisson) [23:42:28] (03Merged) 10jenkins-bot: Display topic title as plaintext on history page [extensions/Flow] - 10https://gerrit.wikimedia.org/r/257640 (https://phabricator.wikimedia.org/T120329) (owner: 10Sbisson) [23:44:31] taking a walk, and doing some errands, whilst the rain has abated. bbl. :)