[00:09:41] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-Newsletter, 5Patch-For-Review: Write presentation model for Newsletter - https://phabricator.wikimedia.org/T116856#1846518 (10Mooeypoo) a:3Mooeypoo [00:11:40] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#1846523 (10jmatazzoni) a:3Mooeypoo [00:12:21] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LiquidThreads, 7Wikimedia-log-errors: LQT: PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 - https://phabricator.wikimedia.org/T61791#1846528 (10Reedy) ``` $topmostTitle = $this->thread->to... [00:13:38] mooeypoo: https://phabricator.wikimedia.org/project/sprint/board/1384/query/open/ [00:22:15] RoanKattouw: "For example, many "thanks" for the same edit ("Cronopio and 10 more thanked you for your edit on Moai") may be bundled. Bundling together "thanks" notifications from the same user ("Cronopio thanked you for your edits on "Moai" and 5 pages more") does not work as well in this case. So we may want to define more clear guidelines if there are none already." [00:24:50] 6Collaboration-Team-Backlog, 10Echo, 10Thanks: Bundle "Thanks" notifications when multiple users thank you for the same edit - https://phabricator.wikimedia.org/T120152#1846553 (10Jdforrester-WMF) 3NEW [00:24:59] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#1692910 (10Jdforrester-WMF) >>! In T114356#1719436, @Pginer-WMF wrote: > For example, many "thanks" for the same edit ("Cronopio and 10 more thanked you for your edit on Mo... [00:26:57] James_F: https://phabricator.wikimedia.org/T114356 and https://phabricator.wikimedia.org/T61005 [00:27:52] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Provide the new bundling system replacing the existing hacky one - https://phabricator.wikimedia.org/T120153#1846581 (10Jdforrester-WMF) 3NEW [00:28:00] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Provide the new bundling system replacing the existing hacky one - https://phabricator.wikimedia.org/T120153#1846589 (10Jdforrester-WMF) [00:28:02] 6Collaboration-Team-Backlog, 10Echo: Echo: Allow un-bundling of Notifications - https://phabricator.wikimedia.org/T61005#1846590 (10Jdforrester-WMF) [00:28:41] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Provide the new bundling system replacing the existing hacky one - https://phabricator.wikimedia.org/T120153#1846581 (10Jdforrester-WMF) [00:28:42] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality: Implement expandable notification groups - https://phabricator.wikimedia.org/T115423#1846592 (10Jdforrester-WMF) [00:29:05] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Provide the new bundling system replacing the existing hacky one - https://phabricator.wikimedia.org/T120153#1846581 (10Jdforrester-WMF) [00:29:06] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Implement compressed rendering of notifications - https://phabricator.wikimedia.org/T115422#1846594 (10Jdforrester-WMF) [00:29:24] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Provide the new bundling system replacing the existing hacky one - https://phabricator.wikimedia.org/T120153#1846581 (10Jdforrester-WMF) [00:29:26] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7WorkType-NewFunctionality: Implement expandable notification groups - https://phabricator.wikimedia.org/T115423#1723912 (10Jdforrester-WMF) [00:29:27] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#1846595 (10Jdforrester-WMF) [00:29:29] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Implement compressed rendering of notifications - https://phabricator.wikimedia.org/T115422#1723904 (10Jdforrester-WMF) [00:29:51] 6Collaboration-Team-Backlog, 10Echo, 10Thanks: Bundle "Thanks" notifications when multiple users thank you for the same edit - https://phabricator.wikimedia.org/T120152#1846599 (10Jdforrester-WMF) [00:29:52] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Provide the new bundling system replacing the existing hacky one - https://phabricator.wikimedia.org/T120153#1846581 (10Jdforrester-WMF) [00:30:06] RoanKattouw: https://phabricator.wikimedia.org/T120152 [00:30:35] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Echo: Provide the new bundling system replacing the existing hacky one - https://phabricator.wikimedia.org/T120153#1846601 (10Legoktm) [01:31:06] 3Collaboration-Team-Current, 10Echo: Fix EventLogging for cross-wiki notifications - https://phabricator.wikimedia.org/T120158#1846796 (10Catrope) 3NEW [01:47:24] 3Collaboration-Team-Current, 10Flow, 10VisualEditor: [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1846833 (10Jdforrester-WMF) I get > load.php?debug=false&lang=en-gb&modules=ext.flow.visualEditor|ext.visualEditor.ba... [01:47:29] 3Collaboration-Team-Current, 10Flow, 10VisualEditor: [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1846834 (10Catrope) I can't reproduce that particular error, but now it's worse: ``` Uncaught TypeError: Cannot read... [02:43:05] bd808, do you think needs_update/update_all_databases shoudl also do composer update? [02:43:16] Right now, the update.php can fail due to that. [02:43:46] Downside is that maybe that's Too Much for just provision to do? But it would be nice for update.php to actually work, which that can require, so I think I end up in favor. [03:30:38] 3Collaboration-Team-Current, 10Gather: Notifications are broken - https://phabricator.wikimedia.org/T120160#1846911 (10Mattflaschen) [03:31:12] Getting dinner then heading home. Will be on a bit later. [04:01:34] matt_flaschen: `vagrant git-update` does the cool magic: git update, composer update, npm update, update.php [04:02:16] `vagrant provision` should (or at least can) do all that for a newly installed extension too [04:03:00] extensions need to be marked in puppet as needing composer to be run, it doesn't happen by default [04:57:15] bd808, the specific issue I'm getting at is that extension's can use puppet to mark needs-update => true, but that update.php run may fail if composer update is requires (since update.php checks for that). [04:57:32] And the composer update may be required for completely unrelated reasons (say, the weekly OOjs UI update). [04:58:35] but that would only be needed if you have updated core [04:59:03] if you update core using the git-update action it will take care of things [04:59:36] bd808, yeah, but git update takes forever, and sometimes you just update core in the course of doing other work. [04:59:42] I actually have a git hook that runs composer when I fetch and get composer.json changes [05:00:36] vagrant provision tries not to mess with existing git clones to be safer to run when you are working on things [05:03:21] here's the hook I use -- https://phabricator.wikimedia.org/P107 [05:03:41] maybe we could set that up automatically [06:28:23] (03CR) 10Mattflaschen: Presentation model for edit-user-talk (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [06:34:09] 3Collaboration-Team-Current, 10Echo, 7Tracking: Write presentation models for all notification types (tracking) - https://phabricator.wikimedia.org/T116834#1847156 (10Mattflaschen) [06:54:22] (03CR) 10Mattflaschen: "In addition to my last comment, it would be good to use the secondary link format." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [06:58:36] (03CR) 10Mattflaschen: [C: 04-1] "Should use new secondary link format ('url', 'label', 'description', 'icon', 'prioritized')." (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [06:58:56] (03CR) 10Mattflaschen: [C: 04-1] Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [09:33:29] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Transfer Flow documentation to Help namespace on MediaWiki - https://phabricator.wikimedia.org/T120189#1847452 (10Trizek-WMF) 3NEW a:3Trizek-WMF [09:35:43] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LiquidThreads, 7Wikimedia-log-errors: LQT: PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 - https://phabricator.wikimedia.org/T61791#1847467 (10Aklapper) >>! In T61791#1846066, @Paladox wrote... [10:33:29] (03PS3) 10Matthias Mullie: Script to remove topics before a certain date [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 [10:34:04] (03PS4) 10Matthias Mullie: Script to remove topics before a certain date [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 (https://phabricator.wikimedia.org/T119509) [11:15:01] 6Collaboration-Team-Backlog, 10Flow: As a user on [[mw:Flow]], I want to find out what's planned for Flow and who works on it - https://phabricator.wikimedia.org/T120195#1847651 (10Aklapper) 3NEW [13:50:56] (03PS1) 10Thiemo Mättig (WMDE): Remove unused imports [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256676 [15:09:46] (03CR) 10Sbisson: Presentation model for edit-user-talk (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [15:10:28] (03PS16) 10Sbisson: Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) [15:13:30] (03CR) 10Sbisson: Presentation model for page-linked (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [15:16:27] (03PS12) 10Sbisson: Presentation model for page-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) [15:22:22] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Transfer Flow documentation to Help namespace on MediaWiki - https://phabricator.wikimedia.org/T120189#1848242 (10Trizek-WMF) 5Open>3Resolved [15:53:50] (03PS1) 10Sbisson: Normalize links in Special:Notifications formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256699 [15:56:00] (03CR) 10jenkins-bot: [V: 04-1] Normalize links in Special:Notifications formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256699 (owner: 10Sbisson) [15:57:13] (03PS2) 10Sbisson: Normalize links in Special:Notifications formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256699 [16:03:20] mlitn: ^ [16:05:48] let’s see [16:07:05] (03PS13) 10Sbisson: Presentation model for page-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) [16:08:10] (03PS17) 10Sbisson: Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) [16:09:02] (03CR) 10Matthias Mullie: [C: 031] "Just one more nitpick, but feel free to merge if urgent!" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256699 (owner: 10Sbisson) [16:09:20] matt_flaschen: You on ops-l? Might be worth responding to Jaime. [16:11:24] (03PS3) 10Sbisson: Normalize links in Special:Notifications formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256699 [16:11:54] (03CR) 10Sbisson: Normalize links in Special:Notifications formatter (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256699 (owner: 10Sbisson) [16:13:30] (03CR) 10Matthias Mullie: [C: 032] Normalize links in Special:Notifications formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256699 (owner: 10Sbisson) [16:17:03] (03Merged) 10jenkins-bot: Normalize links in Special:Notifications formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256699 (owner: 10Sbisson) [16:35:49] (03PS1) 10Matthias Mullie: Unduplicate 'this page is an archive' message on converted pages [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256708 (https://phabricator.wikimedia.org/T119509) [17:09:26] (03PS20) 10Sbisson: Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [17:28:35] mlitn: i was just starting to look over the Flow search integration, i don't have time just this moment but we should set aside time at some point to make sure it properly works with the multi-cluster setup [17:29:06] (maybe when you are in town in january, i dunno) [17:37:23] (03PS5) 10Sbisson: [WIP] Include Flow topics in Nuke [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) [17:38:46] ebernhardson: sure, january sounds good! [17:38:52] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7WorkType-NewFunctionality: Email notification: The new renamed topic title is displayed in place for the previous title - https://phabricator.wikimedia.org/T109784#1848820 (10SBisson) [17:58:17] 3Collaboration-Team-Current, 10Gather, 5Patch-For-Review: Notifications are broken - https://phabricator.wikimedia.org/T120160#1849048 (10Jdlrobson) p:5Triage>3Normal [18:23:59] (03PS6) 10Sbisson: [WIP] Include Flow topics in Nuke [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) [19:08:55] Just wanted to note I'm planning to finish the Gather presentation model today. [19:30:26] matt_flaschen, you should work on the Vacation presentation model [23:46:09] 3Collaboration-Team-Current, 10Flow, 10VisualEditor, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1850929 (10Jdforrester-WMF) p:5High>3Unbreak! [23:46:40] 6Collaboration-Team-Backlog, 10Flow, 10MobileFrontend: The "All" and "Other" tabs on MobileFrontend watchlist show Flow gibberish topic ID links instead of topic titles - https://phabricator.wikimedia.org/T93565#1850933 (10Jdlrobson) p:5Normal>3Lowest No time to work on this right now but patches welcome... [23:52:26] 6Collaboration-Team-Backlog, 10Echo: Check Special:Notifications logging for MobileFrontend - https://phabricator.wikimedia.org/T112789#1850980 (10Jdlrobson) [23:52:46] 3Collaboration-Team-Current, 10Echo, 10Flow, 10Thanks, 6Security: HTML tags in flow titles are leaked on echo notifications - https://phabricator.wikimedia.org/T120291#1850985 (10Catrope) [23:54:35] (03PS1) 10Catrope: [SECURITY] Escape HTML characters in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256858 (https://phabricator.wikimedia.org/T120921) [23:58:24] 3Collaboration-Team-Current, 10Flow: XSS in Flow topic titles - https://phabricator.wikimedia.org/T120324#1850988 (10Catrope) 3NEW