[00:15:44] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1843337 (10Alsee) I'm with Quiddity. Full timestamp with temporary or permanent relative time. 99% of the time the timestamp disappears into backgrou... [02:39:43] (03PS3) 10Catrope: Allow grouping for getBundleCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256132 [02:39:46] (03PS13) 10Catrope: Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [02:39:58] (03PS9) 10Catrope: Presentation model for page-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [02:48:57] Gee thanks PHP: https://3v4l.org/AdkV8 [02:49:33] Passing an invalid callback to array_map() apparently doesn't throw an error, it just returns NULL [02:49:39] Which doesn't even match the docs! Because NULL is not an array [02:49:44] * James_F nods. [02:50:35] But of course array_unique( NULL ) also returns NULL (with another warning), and count( NULL ) is legal and returns 0 [02:50:51] So count( array_unique( array_map( ... ) ) ) will just return 0 if it doesn't like your callback [02:51:27] On the plus side, PHP throws an error if you try to pass this to a function that has callable as a type hint [02:51:36] It just doesn't do a very good job of telling you why [02:52:59] https://3v4l.org/egqd4 [02:54:11] ...although apparently this doesn't work in 5.3 at all, wtf [02:55:28] ...which I guess is why we don't use callable type hints at all [03:03:28] (03PS4) 10Catrope: Allow grouping for getBundleCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256132 [03:03:31] (03PS10) 10Catrope: Presentation model for page-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [06:56:26] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation, 3LE-CX7-Sprint 4, and 3 others: Write presentation models for notifications in ContentTranslation - https://phabricator.wikimedia.org/T116852#1843936 (10santhosh) [07:02:11] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation, 3LE-CX7-Sprint 4, and 3 others: Write presentation models for notifications in ContentTranslation - https://phabricator.wikimedia.org/T116852#1843943 (10santhosh) a:3Mooeypoo [07:05:47] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, and 3 others: Notify translators about new personalised suggestions being available based on their recently published translation - https://phabricator.wikimedia.org/T119939#1843945 (10Arrbee) p:5... [09:53:09] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1844145 (10Pginer-WMF) Thanks @Alsee for you feedback. > That shorten things, but I think it actually increases the cognitive load. That depends hea... [11:14:57] (03CR) 10Sbisson: Allow grouping for getBundleCount() (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256132 (owner: 10Catrope) [13:58:11] 6Collaboration-Team-Backlog, 10Echo, 6Design-Research: Evaluate designs for new notification panel actions - https://phabricator.wikimedia.org/T116741#1844598 (10Pginer-WMF) [13:59:59] 6Collaboration-Team-Backlog, 10Echo, 6Design-Research: Evaluate designs for new notification panel actions - https://phabricator.wikimedia.org/T116741#1756870 (10Pginer-WMF) [17:22:20] (03PS1) 10Sbisson: [WIP] Include Flow topics in Nuke [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) [17:25:13] (03PS1) 10Matthias Mullie: [WIP] Script to remove topics before a certain date [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 [17:35:46] (03PS2) 10Matthias Mullie: [WIP] Script to remove topics before a certain date [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256449 [17:36:01] (03PS14) 10Sbisson: Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) [18:25:24] RoanKattouw_away, I forgot. Christmas and New Year's day are non-floatable, so I'll take those off as well. [18:27:54] Yeah that's right [18:28:25] Sorry, when you said "I'm not taking any time off around the holidays" I interpreted that as "apart from 12/25 and 1/1", but I didn't notice that you hadn't put those in the spreadsheet [18:29:30] Hi echo is cusomised for the foreground skin. It is seperate from the personal bar it is next to the action button but echo seems to not work. Here is the css http://pastebin.com/WjJz2DZM i know the css is wrong since there was a big update in echo that changed alot of css. What should be changed. Repo is at https://github.com/thingles/foreground [18:48:52] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation, 3LE-CX7-Sprint 4, and 4 others: Write presentation models for notifications in ContentTranslation - https://phabricator.wikimedia.org/T116852#1845442 (10Mooeypoo) @santhosh, thanks for the quick merge! I actually made a littl... [18:54:27] (03PS2) 10Sbisson: [WIP] Include Flow topics in Nuke [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) [19:03:20] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Notify owners when an OAuthapp changes state - https://phabricator.wikimedia.org/T62528#1845532 (10Tgr) [19:03:21] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-OAuth: Add Echo notifications to OAuth - https://phabricator.wikimedia.org/T120100#1845531 (10Tgr) [19:52:31] RoanKattouw, we might want to make that video public as documentation if everyone is comfortable with that. [19:53:09] Don't think it has to be (I think Trizek is working on related text documentation), but might be helpful for people that like videos. [20:18:09] matt_flaschen: can I create a UUID instance that represents a specific timestamp in the past? [20:20:17] stephanebisson, yes. Use HistoricalUIDGenerator. [20:21:20] thanks! [20:21:39] No problem [20:22:12] stephanebisson, just curious, what is this for? [20:23:07] Nuke: to list topics that are in the range of RC, not too old [20:23:56] stephanebisson, oh, so just for range? I forgot, there is also getComparisonUUID if it's not actually getting stored (just for comparison purposes like it says). [20:24:20] I need it to build a DB query [20:24:40] getComparisonUUID is more idiomatic if you're just using it for a UUID DB query < >. [20:25:03] ok, I'll look at it [20:37:22] (03PS3) 10Sbisson: [WIP] Include Flow topics in Nuke [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) [20:38:44] (03PS4) 10Sbisson: [WIP] Include Flow topics in Nuke [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256448 (https://phabricator.wikimedia.org/T115695) [21:38:14] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LiquidThreads, 7Wikimedia-log-errors: LQT: PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 - https://phabricator.wikimedia.org/T61791#1845980 (10Paladox) I think this is fixed now. [21:48:35] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LiquidThreads, 7Wikimedia-log-errors: LQT: PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 - https://phabricator.wikimedia.org/T61791#1846034 (10hashar) [21:48:52] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LiquidThreads, 7Wikimedia-log-errors: LQT: PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 - https://phabricator.wikimedia.org/T61791#619826 (10hashar) It is not fixed. From T56670 can be repr... [21:50:47] matt_flaschen: Right now that video is WMF-only, and I'd be happy to make it public but only if everybody who's in the video agrees to that [21:51:23] RoanKattouw, right, I agree everyone should be specifically asked. [21:52:10] (03CR) 10Sbisson: [C: 032] Allow grouping for getBundleCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256132 (owner: 10Catrope) [21:52:45] Whee [21:52:48] Thanks stephanebisson [21:52:59] matt_flaschen: I agree [21:53:28] RoanKattouw: I can't +2 anything else related to those presentation models [21:53:58] I shouldn't either because I amended both of those as well [21:54:11] I'll go over them one more time and +1 them, then ask matt_flaschen to +2 [21:54:19] (Normally I would get legoktm to do that but he's not around) [21:54:37] RoanKattouw, sure. Post the links here and I'll review today. I'll also try to get the Gather one up. [21:56:13] (03Merged) 10jenkins-bot: Allow grouping for getBundleCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256132 (owner: 10Catrope) [21:56:25] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-LiquidThreads, 7Wikimedia-log-errors: LQT: PHP Fatal error: Call to a member function setFragment() on a non-object in ThreadPermalinkView.php on line 168 - https://phabricator.wikimedia.org/T61791#1846066 (10Paladox) Could this be raised to high or unbrea... [21:57:54] first working version of Flow support for Nuke is here (https://gerrit.wikimedia.org/r/#/c/256448/) all feedback is welcome, not sure it's production-grade [22:00:28] stephanebisson: Hmm so I don't remember if you responded to my earlier comment about this, but in https://gerrit.wikimedia.org/r/#/c/253599/14/i18n/en.json the bundled message has the gender of the viewing user while the non-bundled message doesn't [22:01:35] RoanKattouw: I forgot. It's kinda the same as https://phabricator.wikimedia.org/T119321 but I should address it right away in the patch [22:02:11] Yeah I guess it solves part of that bug [22:02:33] In this instance, the inconsistency wasn't there before and the patch introduces it [22:10:24] (03PS15) 10Sbisson: Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) [22:17:33] (03CR) 10Catrope: [C: 031] Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [22:17:43] (03PS11) 10Catrope: Presentation model for page-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [22:20:01] 3Collaboration-Team-Current, 10Echo, 7Tracking: Write presentation models for all notification types (tracking) - https://phabricator.wikimedia.org/T116834#1846130 (10Reedy) [22:20:02] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Notify owners when an OAuthapp changes state - https://phabricator.wikimedia.org/T62528#1846129 (10Reedy) [22:23:32] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-OAuth, 5Patch-For-Review: Add notification to inform oauthadmins that a new consumer request is waiting - https://phabricator.wikimedia.org/T61772#1846142 (10Tgr) [22:23:33] 3Collaboration-Team-Current, 10Echo, 7Tracking: Write presentation models for all notification types (tracking) - https://phabricator.wikimedia.org/T116834#1846143 (10Tgr) [22:25:25] (03CR) 10Catrope: [C: 031] Presentation model for page-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [22:25:50] matt_flaschen: https://gerrit.wikimedia.org/r/253599 and https://gerrit.wikimedia.org/r/253634 are the patches I was referring to earlier. They look good to me, but part of the code is mien [22:25:52] *mine [22:28:51] (03PS2) 10Mooeypoo: Add cross-wiki as a beta feature [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256138 (https://phabricator.wikimedia.org/T114237) [22:38:39] matt_flaschen, if I need to install an extension that doesn't have a role in vagrant, so I will just do the "normal" git clone + add it to the custom LocalSettings file -- is that okay or will that create issues for vagrant? [22:39:07] I want to get Newsletter extension but I don't see a role for it in vagrant [22:39:37] mooeypoo: write the role :) [22:39:59] but yes you can do it manually like that [22:40:00] stephanebisson: Also https://gerrit.wikimedia.org/r/#/c/251512/19 looks fine generally but needs to be ported to the new bundling code (and has minor unaddressed comments) [22:40:01] ooh, that's an idea. [22:40:18] mooeypoo, it's fine. If you prefer, you can put it in settings.d, or just make it like bd808 said (pretty easy). [22:40:20] Is there a threshhold or something for roles? Like... do I need to get anyone's approval to add that role? [22:40:35] Nope [22:41:17] someday we are going to need to revisit how we organize them, but that's a whole other topic [22:47:38] ok matt_flaschen bd808 where are roles defined in vagrant? I'm looking through the repo and my local folder and can't see it [22:47:46] Can't find a doc about this either [22:47:57] puppet/modules/role/manifests/... [22:48:50] oh I was close [22:49:01] I looked at modules but then looked elsewhere. [22:50:09] I don't think I've ever written a proper "adding a role" tutorial. the closest is probably buried in https://www.mediawiki.org/w/index.php?title=File:MediaWiki-Vagrant_Tech_Talk_2014Q4.pdf [22:50:24] I think I get the gist from the other roles in there [22:50:42] yeah, it's trivial most of the time [22:51:18] Looks like there is a bit of documentation at https://www.mediawiki.org/wiki/MediaWiki-Vagrant#Authoring_roles [22:51:36] hm in this case there's also an update script to run [22:52:13] that's "needs_update => true" in the mediawiki::extension define [22:52:34] but how does it know which file to run? [22:52:46] oh it's the general update script [22:52:51] forget my silly question [22:53:13] The documentation in newsletter said "manual update" I thought it required some standalone file to run there for a minute [22:53:37] no worries. adding that flag makes sure that maintenance/update.php gets run which is usually all you need [22:54:12] * mooeypoo nods [22:56:41] ok, created, testedd, and it works [22:57:10] https://gerrit.wikimedia.org/r/256596 [23:15:23] Breaking for... lunch? That doesn't sound right. [23:23:28] You wrote that at 6:15pm your local time so I think that's probably caller dinner [23:30:39] 6Collaboration-Team-Backlog, 10Echo, 3Google-Code-In-2015, 7Mobile: There is no way to distinguish old and new notifications in mobile - https://phabricator.wikimedia.org/T119597#1846392 (10Jdlrobson) [23:57:33] I'm going to collapse a bit early today (now). Might be back later this eve.