[00:06:07] Heya stephanebisson [00:06:21] RoanKattouw: hey [00:06:24] Could you take a look at https://gerrit.wikimedia.org/r/256132 ? [00:06:33] I think that could solve our bundle counting problems [00:47:49] (03PS11) 10Mooeypoo: [wip] Add a demo special page to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254612 (https://phabricator.wikimedia.org/T115551) [00:47:58] (03PS2) 10Mooeypoo: [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (owner: 10Catrope) [00:48:05] (03CR) 10jenkins-bot: [V: 04-1] [wip] Add a demo special page to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254612 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [00:48:15] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Cross-wiki notifications integration [extensions/Echo] - 10https://gerrit.wikimedia.org/r/255328 (owner: 10Catrope) [00:49:20] (03PS13) 10Mattflaschen: Fix history pagination and give user the number of entries they requested [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) [00:49:52] (03CR) 10Mattflaschen: "Reproduced, and 13 fixes it for me." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen) [00:49:59] (03CR) 10Sbisson: Allow grouping for getBundleCount() (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256132 (owner: 10Catrope) [00:50:29] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Add debug code to make details of UID collisions more obvious - https://phabricator.wikimedia.org/T117936#1840084 (10Mattflaschen) a:5Mattflaschen>3None [00:52:18] ^ RoanKattouw, history pagination should be done now. What do you think would be good for me to do next? [00:52:20] RoanKattouw, the two non-blocked assigned to me are https://phabricator.wikimedia.org/T117812 and https://phabricator.wikimedia.org/T116848, but I could take something else if you think it's higher priority. [00:52:47] Of those two, Gather presentation model first [00:52:54] Let me see if there's anything else [00:55:54] I don't see anything else urgent [00:56:03] Flow fires as they arise, but I don't think we have any right now [00:56:11] other than the UUID problems but Matthias is looking into those [00:56:25] There's cleaning up ptwikibooks but AIUI that's blocked on figuring out UUID stuff as well [00:57:32] That is what he's working on, right? [00:57:35] ptwikibooks, I mean. [00:57:41] Will do Gather next. [01:00:01] (03CR) 10Mattflaschen: [C: 032] "The normal recommendation is to commit it ( https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file )." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256141 (owner: 10Mooeypoo) [01:01:59] (03PS67) 10Mooeypoo: Add OOUI widgets for cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115419) [01:03:24] (03Merged) 10jenkins-bot: Stop tracking composer.lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256141 (owner: 10Mooeypoo) [01:21:02] Heading out. Will be on late tonight. [01:36:04] (03CR) 10Catrope: Allow grouping for getBundleCount() (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256132 (owner: 10Catrope) [02:24:06] (03PS2) 10Catrope: Allow grouping for getBundleCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256132 [02:24:09] (03PS12) 10Catrope: Presentation model for edit-user-talk [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [02:25:17] (03CR) 10Catrope: Allow grouping for getBundleCount() (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/256132 (owner: 10Catrope) [05:01:08] (03CR) 10Mattflaschen: [C: 04-1] "> @Mattflaschen I am not sure how to fix those issues." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 (owner: 10Paladox) [05:18:23] 3Collaboration-Team-Current, 10Flow: Problems encountered when enabling Flow on Chinese Wikipedia - https://phabricator.wikimedia.org/T118567#1840439 (10Mattflaschen) >>! In T118567#1823976, @Catrope wrote: > @mattflaschen, does that ring a bell? Changing rev_content is not allowed to avoid data corruption.... [05:18:56] See you tomorrow. [06:24:23] matt_flaschen, RoanKattouw_away, i'll vote for https://phabricator.wikimedia.org/T117812 as higher priority, (though i'm not familiar with what work the gather presentation model, might be blocking). It'd be good to have that back asap. [08:12:58] (03PS1) 10Matthias Mullie: Minor importer fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256172 [08:28:42] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, and 2 others: Notify translators about new personalised suggestions being available based on their recently published translation - https://phabricator.wikimedia.org/T119939#1840569 (10Pginer-WMF)... [09:03:33] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-ContentTranslation, 5ContentTranslation-Release7, and 2 others: Notify translators about new personalised suggestions being available based on their recently published translation - https://phabricator.wikimedia.org/T119939#1840602 (10Pginer-WMF) [09:18:59] (03Abandoned) 10Hashar: Refresh composer.lock [extensions/Flow] - 10https://gerrit.wikimedia.org/r/255561 (owner: 10Hashar) [09:19:32] (03CR) 10Hashar: "Change got abandoned, the /composer.lock file has been removed from the repository with https://gerrit.wikimedia.org/r/#/c/256141/ . Will " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [09:23:26] (03PS12) 10Hashar: Add composer test with just php-parallel-lint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [09:24:08] (03CR) 10Hashar: [C: 031] "Rebased to no more alter /composer.lock which has been removed from the repository." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [10:48:25] (03CR) 10Paladox: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [10:48:35] (03CR) 10Paladox: "Thanks." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [13:04:47] hey mlitn, how are you? [13:10:33] 6Collaboration-Team-Backlog, 10Echo, 7Design: Notification panel: Control notification volume - https://phabricator.wikimedia.org/T115264#1841269 (10Pginer-WMF) [14:13:16] 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend, 3Google-Code-In-2015, 7Mobile: There is no way to distinguish old and new notifications in mobile - https://phabricator.wikimedia.org/T119597#1830621 (10Aklapper) https://codein.withgoogle.com/dashboard/tasks/5370881970798592/ [14:16:01] (03CR) 10Sbisson: [C: 032] Fix history pagination and give user the number of entries they requested [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen) [14:18:38] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Parsoid 503 when trying to edit Flow board description - https://phabricator.wikimedia.org/T119967#1841401 (10TTO) 3NEW [14:19:39] (03Merged) 10jenkins-bot: Fix history pagination and give user the number of entries they requested [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen) [15:10:10] hey stephanebisson - good, and you? [15:10:17] good [15:11:17] mlitn: what do you think is the best way to list all non-moderated topics? [15:11:28] maybe not all, top 500 [15:11:39] regardless of boards [15:11:46] it's for Nuke [15:13:27] (03CR) 10Jforrester: [C: 031] "Good to go once the composer-test job is live." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [15:15:08] you mean code-wise? [15:15:15] mlitn: yes [15:15:59] I’d probably just $storage->find() and then RevisionActionPermissions->isAllowed() [15:16:15] I tried modifying Block\TopicList but got very deep without success, and i'm not sure it's the right level of abstraction [15:16:17] isAllowed is horrible performance-wise, but we’ll have to fix that at some point anyway :p [15:16:47] ah [15:16:55] maybe make it some formatter, then? [15:17:08] like contributions, history, rc, …? [15:17:46] which $storage? [15:22:15] mhh yeah right, can’t just query it [15:23:38] mlitn: Also, I merged Matt's history pagination patch this morning. I didn't see unrevolved comments in there but if you still had some reservations it's not too late to test it again. [15:24:57] ‘storage.post’->find( array( ‘tree_parent_id’ => null, ‘rev_mod_state’ => ‘’ ) [15:25:17] I assume that won’t work, given that it’s across 2 tables? [15:25:27] I have no idea if our storage layer can handle that :p [15:26:06] but since we probably want to get rid of that storage layer anyway, I think you can just query the db directly [15:26:41] (I didn’t have any reservations, but I haven’t looked at it in awhile, maybe I should test it again) [15:27:03] 6Collaboration-Team-Backlog, 10Thanks, 7Mobile, 5Patch-For-Review, 5WMF-deploy-2015-12-08_(1.27.0-wmf.8): Thanks button not hidden for bot edits on mobile - https://phabricator.wikimedia.org/T118686#1841520 (10Glaisher) 5Open>3Resolved a:3Glaisher [15:28:21] mlitn: so you use tree_parent_id to know it is a topic? and rev_mod_state from flow_revision to know it's not moderated? [15:28:30] how do youjoin the 2? [15:36:07] I thought ON rev_id = tree_rev_id, but doesn’t seem to work [15:38:23] lol [15:39:23] it does, I just forgot it’s “IS NULL”, not “= NULL” :) [15:39:25] SELECT * [15:39:26] FROM flow_revision [15:39:26] LEFT OUTER JOIN flow_tree_revision ON rev_id = tree_rev_id [15:39:27] WHERE tree_parent_id IS NULL AND rev_type = 'post'; [15:39:41] I guess some more things would have to be excluded still, though [15:39:58] and probably GROUP BY rev_type_id if you only want one per topic [15:40:05] it gives unmoderated revisions [15:41:01] that’s what you wanted, right? [15:41:12] I want unmoderated topics [15:41:29] never moderated, ideally [15:41:39] they should all be topic revisions (WHERE tree_parent_is IS NULL) [15:42:30] is it going to return older revisions, before it is moderated [15:42:30] ? [15:43:14] is there a way to get only current topic revisions, nothing older? [15:43:44] yeah [15:43:47] just a sec [15:50:43] this is one, but it’s quite horrible: [15:50:46] SELECT * FROM flow_revision [15:50:47] WHERE rev_mod_state = '' AND rev_id IN ( [15:50:49] SELECT MAX(r.rev_id) [15:50:50] FROM flow_revision AS r [15:50:52] INNER JOIN flow_tree_revision ON r.rev_type_id = tree_rev_descendant_id [15:50:53] WHERE tree_parent_id IS NULL AND r.rev_type = 'post' [15:50:54] GROUP BY r.rev_type_id [15:50:55] ); [15:53:25] but I guess we’re going to change permissions soon-ish anyway (https://phabricator.wikimedia.org/T118434) [15:54:26] and I assume that’s going to mean denormalizing moderation status in every revision (instead of having to fetch it from revision, root, board…) [15:54:33] so it will then probably become easier to query [15:54:43] for sure [15:54:57] right now, I can’t really think of 1 good performant way to query for what you want :p [15:55:22] having *current* revision denormalized would also make things simpler [15:56:16] that would help [15:56:53] ok, let me try to integrate that query in the hook... [15:57:34] stephanebisson: there’s a “Flow performance discussion” in an 1:30h, if you’re interested [15:57:40] may be relevant, or not, idk :p [16:00:42] I’ve added you, in case you’d like to come [16:00:52] ok [16:34:19] (03CR) 10Mattflaschen: [C: 032] Minor importer fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256172 (owner: 10Matthias Mullie) [16:37:13] (03Merged) 10jenkins-bot: Minor importer fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/256172 (owner: 10Matthias Mullie) [16:38:05] 6Collaboration-Team-Backlog, 10Flow, 10Parsoid: Parsoid 503 when trying to edit Flow board description - https://phabricator.wikimedia.org/T119967#1841687 (10Mattflaschen) Probably related to or same as {T119967}. [16:44:07] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Community-consensus-needed, and 2 others: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1841743 (10Jdforrester-WMF) I'm removing #Community-consensus-needed as it's not true that we... [16:44:16] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1841744 (10Jdforrester-WMF) [17:00:35] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1841837 (10doctaxon) No, you need community consensus of that wiki Flow should be enabled, also as Beta opt in. You cannot... [17:06:30] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Community-consensus-needed, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1841865 (10doctaxon) [17:06:50] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Community-consensus-needed, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1788617 (10doctaxon) I did it back to #Community-consensus-needed [17:35:45] RoanKattouw_away, are coming to the meeting? [17:48:48] matt_flaschen: can you paste me the etherpad link? [17:50:00] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Community-consensus-needed, 7Tracking: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1842029 (10doctaxon) Isn't it possible to enable Flow in a new namespace? So the user keeps hi... [18:04:20] 6Collaboration-Team-Backlog, 10Echo, 6Design-Research: Evaluate designs for new notification panel actions - https://phabricator.wikimedia.org/T116741#1842098 (10Capt_Swing) [18:26:03] I'll be a few mins late to standup [18:26:20] mlitn, https://etherpad.wikimedia.org/p/Flow-performance-2015-12-01 [18:26:21] mlitn: https://etherpad.wikimedia.org/p/Flow-performance-2015-12-01 [18:32:19] RoanKattouw_away, I can file those action items (unless someone volunteered, a little bit of the end was broken up). [18:35:17] mlitn: we're in the other hangout (collab-team) [18:35:22] coming! [18:50:41] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Vagrant: Setup cross-wiki notifications in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T119999#1842363 (10Mattflaschen) 3NEW [18:51:19] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Vagrant: Setup cross-wiki notifications in MediaWiki-Vagrant - https://phabricator.wikimedia.org/T119999#1842372 (10Mattflaschen) [18:51:23] 6Collaboration-Team-Backlog, 10Echo, 7Epic, 7WorkType-NewFunctionality, 7user-notice: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#1842371 (10Mattflaschen) [19:18:59] 6Collaboration-Team-Backlog, 10Flow: Unblock multi data center work - remove usage of cache CAS operations - https://phabricator.wikimedia.org/T92420#1842480 (10Mattflaschen) This is the same as {T94029}, right? [19:19:21] 6Collaboration-Team-Backlog, 10Flow: Unblock multi data center work - remove usage of cache CAS operations - https://phabricator.wikimedia.org/T92420#1842485 (10Mattflaschen) [19:19:22] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability, 5Patch-For-Review: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1153047 (10Mattflaschen) [19:21:55] 6Collaboration-Team-Backlog, 10Flow: Add debug/warn for cache reads from in-process cache - https://phabricator.wikimedia.org/T120007#1842499 (10Mattflaschen) 3NEW [19:22:07] 3Collaboration-Team-Current, 10Flow: Add debug/warn for cache reads from in-process cache - https://phabricator.wikimedia.org/T120007#1842508 (10Mattflaschen) [19:24:05] 6Collaboration-Team-Backlog, 10Flow: Remove in-process memcached wrapper or find an appropriate solution for cross-DC world - https://phabricator.wikimedia.org/T120008#1842512 (10Mattflaschen) 3NEW [19:24:13] 3Collaboration-Team-Current, 10Flow: Remove in-process memcached wrapper or find an appropriate solution for cross-DC world - https://phabricator.wikimedia.org/T120008#1842520 (10Mattflaschen) [19:24:20] 3Collaboration-Team-Current, 10Flow: Add debug/warn for cache reads from in-process cache - https://phabricator.wikimedia.org/T120007#1842523 (10Mattflaschen) [19:24:21] 3Collaboration-Team-Current, 10Flow: Remove in-process memcached wrapper or find an appropriate solution for cross-DC world - https://phabricator.wikimedia.org/T120008#1842512 (10Mattflaschen) [19:24:41] 3Collaboration-Team-Current, 10Flow: Add debug/warn for cache reads from in-process Memcached cache wrapper - https://phabricator.wikimedia.org/T120007#1842524 (10Mattflaschen) [19:24:54] 3Collaboration-Team-Current, 10Flow: Remove in-process Memcached wrapper or find an appropriate solution for cross-DC world - https://phabricator.wikimedia.org/T120008#1842525 (10Mattflaschen) [19:26:16] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability, 5Patch-For-Review: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1842533 (10Mattflaschen) In today's meeting, we decided to try the WANCache delete()/locally populate from slave approach. [19:27:47] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability, 5Patch-For-Review: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1842540 (10Mattflaschen) [19:31:38] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability, 5Patch-For-Review: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1842548 (10Mattflaschen) [19:31:41] 3Collaboration-Team-Current, 10Flow, 7Availability: Use WAN cache delete() and slave populations to avoid merge() - https://phabricator.wikimedia.org/T120009#1842549 (10Mattflaschen) 3NEW [19:36:26] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Document Flow backend data architecture - https://phabricator.wikimedia.org/T120011#1842589 (10Mattflaschen) 3NEW [19:56:05] (03CR) 10Hashar: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [19:59:08] (03CR) 10Hashar: [C: 032] "CI change deployed \O/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [20:02:45] (03Merged) 10jenkins-bot: Add composer test with just php-parallel-lint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [20:25:36] 3Collaboration-Team-Current, 10Flow, 10VisualEditor: [Regression pre-wmf.8] Insert a mention in any Flow editor (in VE mode) is broken (on master) - https://phabricator.wikimedia.org/T119773#1842818 (10Jdforrester-WMF) p:5Triage>3High [20:36:02] (03CR) 10Paladox: "Thanks." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [20:50:35] (03CR) 10Hashar: "Paladox you are welcome" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [21:05:02] RoanKattouw_away: ping for meeting [21:06:01] matt_flaschen: Sorry, I'm running late. I should be there in a few minutes, heading upstairs now [22:40:32] I'm not feeling great, so I'm going to take a half sick day for today. I'll try to be on later, though. [22:41:26] feel better, matt_flaschen ! [22:42:10] Thanks, mooeypoo. [23:01:08] * quiddity sends tea and blankets to matt_flaschen