[00:01:45] (03PS9) 10Legoktm: Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 [00:02:31] (03CR) 10Legoktm: Track what wikis a user has unread notifications on (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 (owner: 10Legoktm) [00:03:23] (03CR) 10Legoktm: Track what wikis a user has unread notifications on (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 (owner: 10Legoktm) [00:06:59] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-skins-Metrolook, 5Patch-For-Review: Echo Dosen't look good in metrolook - https://phabricator.wikimedia.org/T119134#1819444 (10Paladox) I mean there is already skin specific in echo could it be applied for all skins. [00:07:50] legoktm: So, AIUI that's not safe to merge before we create the table, right? [00:08:37] It is safe because $wgEchoSharedTrackingDB = false; [00:08:54] Oooh [00:08:56] but [00:08:58] I just noticed a bug [00:09:00] sigh. [00:09:06] In the update code path? [00:09:42] (cause that's the one I was worried about) [00:09:53] it requires $wgEchoCluster to be set, but that isn't set for mw.o/officewiki [00:10:03] Right [00:10:19] So we probably need a $wgEchoSharedTrackingCluster = 'extension1'; [00:10:39] And have a lowest-prio bug about moving mw.o/officewiki onto extension1 [00:11:13] Oh, so we won't be able to have mediawikiwiki and officewiki use this system? [00:11:21] I guess officewiki is private anyway so that's fine [00:11:33] (BTW we need $wgEchoSharedTrackingDB = false; for private wikis) [00:11:44] https://gerrit.wikimedia.org/r/#/c/248905/9/includes/EchoDbFactory.php,unified [00:12:02] it assumes $wgEchoSharedTrackingDB is on $wgEchoCluster [00:12:06] for mw.o that won't be true [00:12:08] Right [00:12:17] So we need a different global to control the cluster of the shared tracking db [00:12:55] metawiki too, sigh. [00:13:00] And breaking support for mw.org would be unfortunate [00:13:04] Ugh, meta too? [00:13:11] // The following wikis should be using extension1 db but started with [00:13:11] // the application main database, stick with the current setting [00:13:11] 'labswiki' => false, [00:13:11] 'mediawikiwiki' => false, [00:13:11] 'metawiki' => false, [00:13:12] 'officewiki' => false, [00:13:36] OK yeah then let's create more globals to be able to configure this correctly [00:13:36] I believe wikitech is just super special and can't talk to ex1 anyways. [00:13:55] Meh I'm OK excluding wikitech, at least at the outset [00:14:02] And with excluding private wikis too [00:14:04] (03CR) 10Legoktm: [C: 04-1] "Needs to be able to set cluster independently of $wgEchoCluster" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 (owner: 10Legoktm) [00:14:07] RoanKattouw, I thought we already said we would in the meeting re wikitech. [00:14:20] wikitech isn't part of SUL anyways [00:14:24] I have to go home from the co-working place. [00:14:29] But I'd really like not to be in the position where we can launch this as a beta feature but not on mw.org or meta [00:14:36] See you in a bit. [00:14:52] Those wikis are kind of important [00:16:18] fixing this should be trivial [00:16:32] OK [00:16:35] just another global™ [00:16:39] Yeah [00:17:12] I know that's not ideal, but it's better than trying to get ops to move two tables from s3 to x1 by the end of the year [00:19:52] 6Collaboration-Team-Backlog, 6operations, 7Database: Move echo tables from local wiki databases onto extension1 cluster for mediawikiwiki, metawiki, and officewiki - https://phabricator.wikimedia.org/T119154#1819482 (10Legoktm) 3NEW [00:20:55] fyi: Catchable fatal error: Argument 2 passed to EchoDiscussionParser::getTextSnippet() must be an instance of Language, StubUserLang given [00:21:07] Yeah we merged a fix for that, didn't we? [00:21:16] hmm, want me to swat it out? 34 in prod in last hour [00:21:34] The fix is in wmf7 [00:21:39] ehhh [00:21:42] hmm, everything should be running wmf7 :S [00:21:45] So unless something weird happened to the train today, it should be everywhere already [00:21:46] https://phabricator.wikimedia.org/T118542 [00:21:48] noc seems to agree [00:22:32] yea i see that patch in prod wmf.7...hmm [00:22:55] These are coming from maintenance scripts, right? [00:23:04] So maybe they're long-running and haven't been restarted yet [00:23:12] * RoanKattouw doesn't know how the job queue works these days [00:23:26] they shouldn't be *that* long-running.... [00:23:32] it's been 4+ hours [00:23:34] the way job queue's work today they run for 30s at a time [00:23:57] basically the daemon makes a web request to a local hhvm server, and that should run 30s worth of jobs in the specified queue [00:24:05] Actually 30s or "try for 30s but if a single job takes an hour, that's cool" [00:24:09] yea [00:24:32] it only quits after a job finishes, so a job could run for horus, yes [00:25:05] (03PS1) 10Legoktm: Remove problematic `Language` type-hint from getTextSnippet() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254339 (https://phabricator.wikimedia.org/T118542) [00:25:10] :) [00:25:14] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7), 7Wikimedia-log-errors: Catchable fatal error: Argument 2 passed to EchoDiscussionParser::getTextSnippet() must be an instance of Language, StubUserLang given - https://phabricator.wikimedia.org/T118542#1819500 (... [00:26:03] 6Collaboration-Team-Backlog, 6operations, 7Database: Move echo tables from local wiki databases onto extension1 cluster for mediawikiwiki, metawiki, and officewiki - https://phabricator.wikimedia.org/T119154#1819505 (10jcrespo) I was one of the people that wouldn't understand why this was like this in the fi... [00:26:38] ebernhardson: where in the logs are you seeing this? [00:28:57] legoktm: logstash fatalmonitor [00:29:15] legoktm: its 4th from the top in the 'Most Frequent' list [00:29:42] do I get any more context? [00:30:48] like, does it provide any more info like timestamp or whatever? [00:31:00] I remember issues with syslog buffering and want to make suer it's not that [00:31:14] legoktm: don't you have logstash access :P they all occured between 00:00:00 and 00:07:00 somehow [00:31:22] I do... [00:31:27] I'm looking at https://logstash.wikimedia.org/#/dashboard/elasticsearch/fatalmonitor right now [00:31:30] hrm. [00:31:40] legoktm: exception.log on fluorine also looks to have stack traces [00:32:12] aha, thanks [00:32:43] oh, I stupid [00:32:46] * legoktm slaps himself [00:34:20] (03PS2) 10Legoktm: Unstub $wgLang in BasicFormatter::getLanguage() too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254339 (https://phabricator.wikimedia.org/T118542) [00:34:22] there [00:38:18] (03CR) 10Catrope: [C: 032] Unstub $wgLang in BasicFormatter::getLanguage() too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254339 (https://phabricator.wikimedia.org/T118542) (owner: 10Legoktm) [00:39:47] (03PS45) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [00:41:50] (03Merged) 10jenkins-bot: Unstub $wgLang in BasicFormatter::getLanguage() too [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254339 (https://phabricator.wikimedia.org/T118542) (owner: 10Legoktm) [00:43:00] (03PS1) 10Catrope: Unstub $wgLang in BasicFormatter::getLanguage() too [extensions/Echo] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/254345 (https://phabricator.wikimedia.org/T118542) [00:44:18] 6Collaboration-Team-Backlog, 6operations, 7Database: Move echo tables from local wiki databases onto extension1 cluster for mediawikiwiki, metawiki, and officewiki - https://phabricator.wikimedia.org/T119154#1819541 (10Legoktm) >>! In T119154#1819505, @jcrespo wrote: > I was one of the people that wouldn't u... [00:47:00] (03CR) 10Catrope: [C: 032] Add a NetworkHandler as a central API authority to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 (owner: 10Mooeypoo) [00:47:54] (03CR) 10Catrope: [C: 032] Unstub $wgLang in BasicFormatter::getLanguage() too [extensions/Echo] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/254345 (https://phabricator.wikimedia.org/T118542) (owner: 10Catrope) [00:48:54] 6Collaboration-Team-Backlog, 6operations, 7Database: Move echo tables from local wiki databases onto extension1 cluster for mediawikiwiki, metawiki, and officewiki - https://phabricator.wikimedia.org/T119154#1819554 (10jcrespo) a:3jcrespo My mistake, I assumed labswiki was part of the migration just becaus... [00:48:58] 6Collaboration-Team-Backlog, 10Flow: Deleted topics/board while another user tries to edit - a user gets confusing error messages - https://phabricator.wikimedia.org/T119156#1819558 (10Etonkovidova) 3NEW [00:49:49] 6Collaboration-Team-Backlog, 10Flow: Delete topics/board while another user tries to edit - a user gets confusing error messages - https://phabricator.wikimedia.org/T119156#1819577 (10Etonkovidova) [00:49:51] RoanKattouw: thanks [00:52:15] (03PS11) 10Catrope: Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 (owner: 10Mooeypoo) [00:53:04] 3Collaboration-Team-Current, 10Flow, 6Security, 5Patch-For-Review: Ensure users can not access topics from deleted boards via Varnish caching - https://phabricator.wikimedia.org/T116095#1819595 (10Etonkovidova) 1) Admin user that bookmarked (or just saved a permalink url) of a deleted topic or of a topic... [00:54:07] (03CR) 10Catrope: [C: 032] Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 (owner: 10Mooeypoo) [00:55:03] (03Merged) 10jenkins-bot: Add a NetworkHandler as a central API authority to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 (owner: 10Mooeypoo) [00:55:06] (03Merged) 10jenkins-bot: Unstub $wgLang in BasicFormatter::getLanguage() too [extensions/Echo] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/254345 (https://phabricator.wikimedia.org/T118542) (owner: 10Catrope) [00:56:20] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7), 5WMF-deploy-2015-12-01_(1.27.0-wmf.8): SubmissionHandler should expose real error messages, rather than coercing everything to "user is blocked" - https://phabricator.wikimedia.org/T118890#1819613 (10Etonkovidov... [00:58:19] (03Merged) 10jenkins-bot: Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 (owner: 10Mooeypoo) [01:05:56] 6Collaboration-Team-Backlog, 10Flow, 7Regression: topic-title-wikitext conversion error when non-privileged user edits deleted topic - https://phabricator.wikimedia.org/T119157#1819626 (10Mattflaschen) 3NEW [01:06:39] 6Collaboration-Team-Backlog, 10Flow, 7Regression: topic-title-wikitext conversion error when non-privileged user edits deleted topic - https://phabricator.wikimedia.org/T119157#1819626 (10Mattflaschen) [01:06:46] 3Collaboration-Team-Current, 10Flow, 7Regression: topic-title-wikitext conversion error when non-privileged user edits deleted topic - https://phabricator.wikimedia.org/T119157#1819626 (10Mattflaschen) [01:07:39] 3Collaboration-Team-Current, 10Flow, 7Regression: [betalabs] Flow\Exception\WikitextException on clicking deleted topic link from View history - https://phabricator.wikimedia.org/T119133#1819638 (10Mattflaschen) [01:08:07] 3Collaboration-Team-Current, 10Flow, 7Regression: [betalabs] Flow\Exception\WikitextException on clicking deleted topic link from View history - https://phabricator.wikimedia.org/T119133#1819641 (10Mattflaschen) p:5Triage>3Unbreak! [01:50:34] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-skins-Metrolook, 5Patch-For-Review: Echo Dosen't look good in metrolook - https://phabricator.wikimedia.org/T119134#1819695 (10Mattflaschen) >>! In T119134#1819444, @Paladox wrote: > I mean there is already skin specific in echo could it be applied for all s... [01:57:52] 3Collaboration-Team-Current, 10Flow: When deleting Flow topic or post, contributions should appear in DeletedContributions - https://phabricator.wikimedia.org/T118024#1819708 (10Mattflaschen) p:5Triage>3High [02:43:36] Any thoughts on a good way to rebuild the MW database without a full destroy/up on MediaWiki-Vagrant? [03:24:00] matt_flaschen: if you drop or rename the db and then run `vagrant provision` again it will be recreated [03:30:42] bd808, oh, that's enough to properly re-trigger the installer? Thanks. [03:31:10] I *think* it will, yes [03:31:26] bd808, okay, well, we'll find out soon, because I'm testing full-wiki dumps. :) [03:31:39] I've been destroying, but that's obviously a pain. [03:31:49] there's an install.php maintenance script too [03:31:57] if not then deleting settings.d/wikis/wiki/LocalSettings.php should [03:54:22] All of a sudden (without changing the signature): [03:54:24] [d4d3cbf9] [no req] MWException from line 220 of /vagrant/mediawiki/includes/Hooks.php: Detected bug in an extension! Hook FlowHooks::onImportHandleToplevelXMLTag has invalid call signature; get_class() expects parameter 1 to be object, boolean given [03:57:54] ha [03:58:12] matt_flaschen: https://phabricator.wikimedia.org/T117553#1819736 [03:59:34] legoktm, ah, thanks. I was thinking it was really in an error in the hook, but hadn't got to the part about how it actually propogated to that. [04:01:42] bd808, with just dropping the DB, it started to work: [04:01:44] ==> default: Notice: /Stage[main]/Mediawiki/Mediawiki::Wiki[devwiki]/Exec[wiki_setup]/returns: executed successfully [04:01:46] ==> default: Notice: /Stage[main]/Mediawiki/Mediawiki::Wiki[devwiki]/Exec[wiki_include_extra_settings]/returns: executed successfully [04:01:57] But then it failed in BrowserTests and OAuth. [04:03:14] matt_flaschen: like an ordering problem in the puppet rules? [04:03:25] bd808, quite possibly. [04:03:58] I'm retrying after removing the db and removing that file. [04:04:44] Same issue. [04:05:57] If you can paste the output of `PUPPET_DEBUG=1 vagrant provision` I might be able to figure out what's wrong [04:09:14] bd808, it's getting late, so I'm probably just going to upload the Flow patch in a minute. I'll give you my roles if you want to take a look though. [04:09:55] https://phabricator.wikimedia.org/P2334 [04:10:43] cool. I'll try messing with it tomorrow [04:13:47] Thanks [04:26:07] (03PS17) 10Mattflaschen: Import Flow data dump [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie) [04:26:10] (03PS19) 10Mattflaschen: Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [04:34:38] (03CR) 10Mattflaschen: "I just thought of this, but we should include the username. This is easy and will be useful for consuming the dumps in ways other than re" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [04:39:48] (03CR) 10Mattflaschen: "I got errors on import about workflow not being set on metadata. I couldn't see why not. However, by digging through Listener I did find" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie) [05:00:09] (03CR) 10Mattflaschen: "I'm not sure if hidden users (as in hideuser from https://www.mediawiki.org/wiki/Help:Blocking_users#Blocking) are supposed to be hidden i" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [06:16:46] 6Collaboration-Team-Backlog, 10Flow, 6Community-Tech, 6Language-Engineering, and 4 others: Parsing team: Q3 2015-16 goals planning dependency tracker task - https://phabricator.wikimedia.org/T119088#1820046 (10santhosh) From #language-engineering we would like to see some priority for {T116350} [10:01:55] 3Collaboration-Team-Current, 10Flow: Problems encountered when enabling Flow on Chinese Wikipedia - https://phabricator.wikimedia.org/T118567#1820211 (10Antigng) [[https://zh.wikipedia.org/w/index.php?title=User_talk:Qsx753698&action=edit&redlink=1|User:Qsx753698]] [11:47:30] (03PS3) 10Hashar: [MoodBar] Update Jenkins tests [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/247064 (owner: 10Paladox) [11:53:39] (03PS4) 10Hashar: [MoodBar] Update Jenkins tests [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/247064 (owner: 10Paladox) [11:55:24] (03CR) 10Hashar: "rebased / tweaked a few ignores / excludes" [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/247064 (owner: 10Paladox) [11:56:06] (03PS5) 10Hashar: [MoodBar] Update Jenkins tests [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/247064 (owner: 10Paladox) [11:57:06] (03CR) 10Hashar: [C: 032] "I have added the banana checker which was commented out for some reason." [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/247064 (owner: 10Paladox) [12:02:49] (03Merged) 10jenkins-bot: [MoodBar] Update Jenkins tests [extensions/MoodBar] - 10https://gerrit.wikimedia.org/r/247064 (owner: 10Paladox) [12:07:36] (03PS1) 10Revi: Update translation for Korean [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254384 [13:15:31] (03PS2) 10Matthias Mullie: Add secondary link details: icon & description [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) [13:23:15] (03CR) 10Sbisson: [C: 04-1] Add secondary link details: icon & description (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) (owner: 10Matthias Mullie) [13:50:11] (03CR) 10Matthias Mullie: Expose more data through API (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie) [13:50:17] (03PS6) 10Matthias Mullie: Expose more data through API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) [13:52:49] (03CR) 10Matthias Mullie: Add secondary link details: icon & description (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) (owner: 10Matthias Mullie) [13:52:52] (03PS3) 10Matthias Mullie: Add secondary link details: icon & description [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) [13:55:53] (03CR) 10Sbisson: [C: 031] Add secondary link details: icon & description [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) (owner: 10Matthias Mullie) [16:17:43] 6Collaboration-Team-Backlog, 10Echo, 7I18n, 7user-notice: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1820715 (10matej_suchanek) So what is broken right now? [16:21:31] 3Collaboration-Team-Current, 10Flow: [beta] Special:Log errors out with a Flow exception - https://phabricator.wikimedia.org/T119204#1820734 (10SBisson) 3NEW [16:52:32] 6Collaboration-Team-Backlog, 10Echo, 7I18n, 7user-notice: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1820849 (10Nemo_bis) Any reason to think this is different from the long-standing brokenness of WMF's deployment system, reported at {T103879}? [17:18:22] 6Collaboration-Team-Backlog, 10Echo, 7I18n, 7user-notice: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1820913 (10SBisson) 5Open>3Resolved a:3SBisson This was about missing translations. They have been fixed. [17:49:54] mlitn, heyhey, I don't know if you saw, but I rebased your patch into my stack so I can test it... hope that's ok. I also reviewed, there is a missing icon url, I think we already have that information, at least from the old formatter [17:51:38] oh I just realized you commented. hee, sorry. [17:51:49] hey [17:51:52] yeah indeed D [17:52:02] of course I don’t mind the rebase ;) [17:52:29] mlitn, have you worked on the dumps since my uploads last night, or should I keep going? [17:52:38] Yeah I was trying to test both patches without rearranging them, but that turned out a bit of a challenge [17:53:04] hey matt_flaschen:no I haven’t [17:53:15] (03PS46) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [17:53:27] it looks like we’re waiting for someone else to chime in about usernames first? [17:54:03] or should we go ahead and start adding anyway? [17:54:39] (I ignored the listeners problem - I can’t reproduce it and couldn’t figure out exactly what was going wrong) [17:55:33] mooeypoo: you may also have to rebase https://gerrit.wikimedia.org/r/#/c/254147/ on top of the other one [17:55:35] matt_flaschen, I remember you had thoughts against serving the icons in Echo as symbolic names and then using front-end CSS classes (like OOUI does) but I don't remember exactly what were the reasons; we said, I think, that we'll talk about this more. Do you want to discuss this somewhere (in one of the tickets or add to the discussion agenda?) so we can all reach some resolution? or am I remembering wrong? [17:55:49] mlitn, oooh! awesomesauce [17:56:59] mooeypoo, IIRC I said it should serve the URL so third-party consumers like CrossWatch can render them without using the exact same rendering stack as Echo. [17:57:15] mlitn, I am also goign to review that one. I think we also wanted a flag for the secondary links "explicit" that states whether they are outside the [ ... ] menu or not, which might require some creative thinking on how the "client" of those formatters should flag those properly. I'll test the patch anyways. [17:58:03] matt_flaschen, good point. We seem to be theoretically expecting to move away from icon URLs, though, according to some of the discussions -- we should probably make sure we talk about this and make a decision. [17:58:20] I'll raise it in standup, we can decide if we want to solve it immediately or have it as an agenda item in the discussion [17:58:39] mooeypoo, sounds good. [17:58:51] I'm going to take a break from dumps to work on the topic title conversion regressions. [18:01:34] 3Collaboration-Team-Current, 10Flow, 6Stewards-and-global-tools: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1821073 (10Mattflaschen) p:5Unbreak!>3High We're still working on this (and fixes have already been merged), but I don't think it's UBN any more.... [18:03:12] We have 14 unbreak now, and that's after me downgrading one... Some are in product review, though. [18:03:49] yikes [18:04:23] 3Collaboration-Team-Current, 10Flow: [beta] Special:Log errors out with a Flow exception - https://phabricator.wikimedia.org/T119204#1821086 (10Mattflaschen) a:3Mattflaschen [18:04:53] 3Collaboration-Team-Current, 10Flow, 6Stewards-and-global-tools: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1821089 (10Mattflaschen) a:5Mattflaschen>3None [18:15:19] 3Collaboration-Team-Current, 10Flow: [beta] Special:Log errors out with a Flow exception - https://phabricator.wikimedia.org/T119204#1821117 (10Mattflaschen) [18:16:03] 3Collaboration-Team-Current, 10Flow, 7Regression: [betalabs] Flow\Exception\WikitextException on clicking deleted topic link from View history - https://phabricator.wikimedia.org/T119133#1821120 (10Mattflaschen) a:3Mattflaschen [18:16:36] 6Collaboration-Team-Backlog, 10Flow: [beta] Special:Log errors out with a Flow exception - https://phabricator.wikimedia.org/T119204#1821122 (10SBisson) [18:17:29] mooeypoo: that implicit/explicit thing (AIUI) will be part of changes in bundling [18:17:44] bundling first needs to be refactored [18:18:23] (right now, a bundle doesn’t output any children, it’s just like any other element) [18:19:20] mlitn, is it? I thought it was a general action/secondary link definition [18:20:02] matt_flaschen: responding an icon url makes so we can’t have generic (cachable) responses, since the url may change depending on user’s language/directionality) [18:20:32] aah [18:20:42] now I see what you mean [18:21:16] I’ll add that on Monday! [18:21:48] (though perhaps we need better terminology than explicit/implicit, since I assumed it was something else :p) [18:22:00] anyway, have a good weekend, all! [18:22:34] But how would it be cacheable anyway? Isn't the response completely dependent on what notifications the user currently has? [18:22:37] Sorry, yes, implicit vs explicit terminology isn't great [18:22:46] But it's the working term that Pau used and I didn't come up with a better one [19:08:01] (03CR) 10Catrope: [C: 031] "I think this would be a great API for the proposed bundling designs actually; though it would be nice to figure out a way not to have to d" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254166 (owner: 10Legoktm) [19:24:09] (03PS47) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [19:26:47] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [19:27:18] (03PS48) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [19:27:21] (03PS4) 10Mooeypoo: Add secondary link details: icon & description [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) (owner: 10Matthias Mullie) [19:27:36] (03PS7) 10Mooeypoo: Expose more data through API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie) [19:28:36] (03PS5) 10Mooeypoo: Add secondary link details: icon & description [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) (owner: 10Matthias Mullie) [19:28:44] (03PS49) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [19:30:18] That was the shortest DMV trip I've ever made \o/ [19:30:22] I wasn't even there for 10 minutes [19:30:39] Nice [19:31:31] mooeypoo made an appointment at the SF DMV yesterday and she had a choice of going in on Monday or in late December [19:32:44] Your story makes me hopeful for my DL renewal next year. But it is the SF DMV so who knows [19:33:33] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [19:34:57] (03CR) 10Mooeypoo: "I think the consensus was to call the new needed secondary links flag "prioritized" to note that they should be shown outside the menu whe" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) (owner: 10Matthias Mullie) [19:34:58] RoanKattouw: I had renewed my license over the phone and just needed to pick up the temporary license [19:35:05] Ooh OK [19:35:37] Yeah I renewed my license by mail last year (when it expired because the immigration status I had at the time had expired) [19:35:45] Also, there's absolutely no mention of the fact that you can renew your license over the phone on the DMV website...I guess no one does that :P [19:35:57] It was painless apart from having to wait 6 weeks and being without a license for a month [19:36:09] But I have an NL license valid till 2020 [19:36:28] legoktm: So, if you renew over the phone, do they just mail your new license to you? [19:36:32] Yep [19:36:34] Don't you have to take a paper test when renewing? [19:36:40] Or do you take that over the phone too? [19:36:42] No... [19:37:02] Hmm [19:37:07] I'll try that next year then [19:37:25] The thing I got in the mail said I could renew online/phone/mail and didn't need to take any tests [19:37:25] If there's a gap between my CA licenses I don't care, I have my NL license so I don't need to pick up a temp CA one [19:37:45] Probably because it only expired since I turned 21 and need to switch to the horizontal one [19:37:49] Riiight [19:38:00] Just realized that when dumps are merged, we can auto-create Flow boards on MediaWiki-Vagrant. Won't even need any non-trivial Varnish code, since we just reuse the existing importer. :) [19:38:04] Yeah mine was a special case too, it expired because my visa did [19:38:29] Err, non-trivlal Vagrant code. [19:38:33] I guess when it expires again next year, that'll be a real expiry and I'll have to go in and take the test [20:01:48] re: drivers license... re-testing?! I don't think Canadians have to take any re-tests until they reach age 80, or have an accident and similar circumstances. [20:03:46] 6Collaboration-Team-Backlog, 10Flow: Be consistent about whether topic titles of deleted topics are visible - https://phabricator.wikimedia.org/T119234#1821559 (10Mattflaschen) 3NEW [20:04:56] quiddity: Yeah same in NL [20:05:14] quiddity: Does your license also cover zambonis? [20:05:17] But CA (not sure about other states) makes you take 2/3 of the paper test every 5(?) years [20:05:30] Maybe every 10 [20:05:50] I think it might be "every time you reach an age that is 6 mod 10" (16, 26, etc) [20:07:01] legoktm, HA! (i wish) [20:07:44] and wow, that's a lot of testing. [20:08:56] RoanKattouw, https://phabricator.wikimedia.org/T119234 would be good to discuss at the team meeting if it's not resolved before then. [20:11:25] (03PS1) 10Mattflaschen: Fix regression in log formatting from "links in topic title" patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254466 (https://phabricator.wikimedia.org/T119133) [20:12:31] * RoanKattouw adds [20:12:54] Thanks. [20:13:06] Also, https://gerrit.wikimedia.org/r/254466 should be reviewed before branch cut. [20:14:07] On it [20:16:25] (03CR) 10Catrope: [C: 032] Fix regression in log formatting from "links in topic title" patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254466 (https://phabricator.wikimedia.org/T119133) (owner: 10Mattflaschen) [20:20:08] (03Merged) 10jenkins-bot: Fix regression in log formatting from "links in topic title" patch [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254466 (https://phabricator.wikimedia.org/T119133) (owner: 10Mattflaschen) [20:20:45] (03PS50) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [20:22:40] 6Collaboration-Team-Backlog, 10Flow: Be consistent about whether topic titles of deleted topics are visible - https://phabricator.wikimedia.org/T119234#1821638 (10Quiddity) That is all correct. Meta details of the entries in the standard deletion log are fully visible to everyone. That's also how LQT does it. [20:23:03] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [20:24:22] Thanks, RoanKattouw [20:26:38] 6Collaboration-Team-Backlog, 10Flow: Be consistent about whether topic titles of deleted topics are visible - https://phabricator.wikimedia.org/T119234#1821677 (10Mattflaschen) >>! In T119234#1821638, @Quiddity wrote: > That is all correct. Meta details of the entries in the standard deletion log are fully vis... [20:27:11] 6Collaboration-Team-Backlog, 10Flow: Be consistent about whether topic titles of deleted topics are visible - https://phabricator.wikimedia.org/T119234#1821678 (10Mattflaschen) [20:27:35] 6Collaboration-Team-Backlog, 10Echo, 7I18n, 7user-notice: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1821680 (10Nemo_bis) >>! In T117966#1820913, @SBisson wrote: > This was about missing translations. Not really. > They have been fixed. Definite... [20:27:48] 6Collaboration-Team-Backlog, 10Echo, 7I18n, 7user-notice: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1821681 (10Nemo_bis) [20:28:04] quiddity, I edited my last comment. Just to clarify, I'm asking about history. [20:40:28] 6Collaboration-Team-Backlog, 10Flow: Be consistent about whether topic titles of deleted topics are visible - https://phabricator.wikimedia.org/T119234#1821706 (10Quiddity) >>! In T119234#1821677, @Mattflaschen wrote: > Do you also agree we should change it to: Yes. Removing the visibility of the topic title,... [20:54:07] (03CR) 10Mattflaschen: Dump Flow data (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [20:54:25] (03CR) 10Mattflaschen: "Deleted boards currently look like:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [20:57:08] 6Collaboration-Team-Backlog, 10Flow: Change deleted topic titles to be consistently visible and reflect this in permissions system - https://phabricator.wikimedia.org/T119234#1821764 (10Mattflaschen) [21:17:05] (03PS9) 10Paladox: build: Add composer test, initially with just parallel-test [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 [21:17:28] (03CR) 10Paladox: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [22:00:43] 6Collaboration-Team-Backlog, 10Echo: Allow autoconfirmed users to report edits to oversighters - https://phabricator.wikimedia.org/T119241#1821897 (10Cenarium) 3NEW [22:35:39] James_F|Away: quiddity: This is exactly what I was thinking about during our meeting on Wednesday: https://phabricator.wikimedia.org/T119241 [22:57:03] Oh, really? Then I'll put it back in our backlog. [22:57:14] 6Collaboration-Team-Backlog, 10MediaWiki-Extension-Requests: Allow autoconfirmed users to report edits to oversighters - https://phabricator.wikimedia.org/T119241#1822034 (10Mattflaschen) [22:57:25] Don't think it belongs in Echo proper though. [22:57:31] It was already in collab-backlog because it was filed against Echo [22:57:46] We were talking about it as part of a future vision, not for this quarter or even necessarily next quarter [22:58:08] RoanKattouw, yeah, I removed it from both before since it didn't seem within Echo and I didn't know you had been talking about it. [22:58:22] Oh, I see [22:58:23] I can see the idea of an extension using thank-style links (and maybe Echo) for it, though. [22:58:48] No relation, BTW. Someone from the community just randomly filed a task about an idea I had two days ago, hence my mild surprise [23:04:12] 6Collaboration-Team-Backlog, 10MediaWiki-Extension-Requests: Allow autoconfirmed users to report edits to oversighters - https://phabricator.wikimedia.org/T119241#1822044 (10Luke081515) It would be great, if you can give a short reason for that request. The problem might be spamming with such requests, so I pr... [23:11:03] I'm going to sleep for a bit. I blame the flu shot for reducing my productivity today. Might be back later, or more likely Sunday. If I'm not back soon, then have a good weekend all. o/ [23:12:45] 6Collaboration-Team-Backlog, 10Flow: Allow importing to wiki where users don't exist - https://phabricator.wikimedia.org/T119249#1822074 (10Mattflaschen) 3NEW [23:13:05] 6Collaboration-Team-Backlog, 10Flow, 10Dumps-Generation: Allow importing from XML dumps to wiki where users don't exist - https://phabricator.wikimedia.org/T119249#1822082 (10Mattflaschen) [23:13:27] 6Collaboration-Team-Backlog, 10Flow: Add username to dumps just for non-import uses - https://phabricator.wikimedia.org/T119250#1822086 (10Mattflaschen) 3NEW [23:13:35] 6Collaboration-Team-Backlog, 10Flow, 10Dumps-Generation: Add username to dumps just for non-import uses - https://phabricator.wikimedia.org/T119250#1822096 (10Mattflaschen) [23:13:56] 6Collaboration-Team-Backlog, 10Flow, 10Dumps-Generation: Add username to dumps just for non-import uses - https://phabricator.wikimedia.org/T119250#1822086 (10Mattflaschen) [23:13:57] 6Collaboration-Team-Backlog, 10Flow, 10Dumps-Generation: Allow importing from XML dumps to wiki where users don't exist - https://phabricator.wikimedia.org/T119249#1822074 (10Mattflaschen) [23:15:26] (03CR) 10Mattflaschen: [C: 04-1] "Let's do the username part as a followup. (Related note: It copes oddly well with users that don't exist on the target wiki. It basically" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [23:17:13] (03PS51) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [23:18:06] (03CR) 10Mattflaschen: "> However, one of the metadata errors was from AbstractTopicInsertListener , which still happens on imports (as I think it should in this " [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie) [23:19:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [23:25:48] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 3 others: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1822120 (10Etonkovidova) Checked in betalabs according to specs. Please check below Talk:ET19 - the link in the title and in the Summary - [[Talk:ET... [23:26:44] (03PS52) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [23:27:21] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 3 others: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1822136 (10Etonkovidova) Not sure if it's big enough to be in a separate issue: - Have a title with a link in it - scroll up - the link exposes ht... [23:27:56] matt_flaschen: pls read my very last comment on https://phabricator.wikimedia.org/T59153 [23:28:08] matt_flaschen: everything else looks good [23:28:34] mooeypoo: When you have a minute, could you review https://gerrit.wikimedia.org/r/254097 and https://gerrit.wikimedia.org/r/254098 [23:29:16] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [23:32:02] (03CR) 10Mooeypoo: "lgtm" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254097 (owner: 10Catrope) [23:32:11] etonkovidova, got it, there's apparently a ToC issue. I think we can fix it as part of this task. I'll move it back to in dev. [23:32:14] (03CR) 10Mooeypoo: [C: 032] "lgtm" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254097 (owner: 10Catrope) [23:32:33] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 3Google-Code-In-2015: Remove BatchRowUpdate and use the core one instead - https://phabricator.wikimedia.org/T119253#1822145 (10Mattflaschen) [23:32:35] matt_flaschen: it's great - thank you. [23:33:22] (03CR) 10Mooeypoo: [C: 032] "lgtm" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254098 (owner: 10Catrope) [23:36:11] (03PS53) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [23:37:11] ebernhardson, how do I do a join with BatchRowIterator? [23:37:22] Basically, I only want to iterate workflows where the page ID is in the page table. [23:37:31] I see addJoinConditions, but not where the other table goes. [23:37:42] matt_flaschen: hmm, looking [23:38:03] I wonder if I just put both tables in the table parameter... [23:38:12] (03CR) 10Catrope: [C: 032] Expose more data through API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie) [23:39:02] (03Merged) 10jenkins-bot: Remove styling for nonexistent mw-echo-title-heading class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254097 (owner: 10Catrope) [23:39:17] matt_flaschen: they syntax should be same as DatabaseBase::select(), so array( 'page' => array( ' [23:39:19] 6Collaboration-Team-Backlog, 10Echo, 10Flow, 7Easy, 3Google-Code-In-2015: Remove BatchRowUpdate and use the core one instead - https://phabricator.wikimedia.org/T119253#1822198 (10Mattflaschen) [23:39:33] matt_flaschen: they syntax should be same as DatabaseBase::select(), so array( 'page' => array( 'JOIN', 'page_latest', workflow_page_id' ) ) or some such perhsp? [23:39:40] (03Merged) 10jenkins-bot: Prevent link color on hover for the body ("payload") as well as the header [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254098 (owner: 10Catrope) [23:40:19] matt_flaschen: i can't remember if i've ever used it for joins, it could also be mis-implemented and the table field should accept array [23:40:29] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to save or preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1822202 (10Catrope) Should be fixed in production now (but not in beta yet) [23:40:32] well, can probably pass array as $table [23:40:52] ebernhardson, yeah, I think that's it, and then specify the join condition. If that works, I'll update the docs. [23:41:58] (03Merged) 10jenkins-bot: Expose more data through API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie) [23:42:31] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to save or preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1822205 (10Etonkovidova) Checked in mw.org - the issue is fixed. Betalabs still has the issue. [23:43:36] matt_flaschen: if doing a maint script though, wont that have the issue that flow and mediawiki are on different servers/ [23:43:51] (03CR) 10Catrope: [C: 04-1] Add secondary link details: icon & description (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) (owner: 10Matthias Mullie) [23:44:22] ebernhardson, d'oh. [23:45:06] ebernhardson, I'll just use isDeleted [23:54:17] (03PS10) 10Legoktm: Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905