[00:00:48] (03PS1) 10Catrope: Surface permission errors [extensions/Flow] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/254074 (https://phabricator.wikimedia.org/T118890) [00:10:05] (03CR) 10Catrope: [C: 032] Surface permission errors [extensions/Flow] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/254074 (https://phabricator.wikimedia.org/T118890) (owner: 10Catrope) [00:13:17] (03Merged) 10jenkins-bot: Surface permission errors [extensions/Flow] (wmf/1.27.0-wmf.7) - 10https://gerrit.wikimedia.org/r/254074 (https://phabricator.wikimedia.org/T118890) (owner: 10Catrope) [00:31:10] 3Collaboration-Team-Current, 10Flow: Problems encountered when enabling Flow on Chinese Wikipedia - https://phabricator.wikimedia.org/T118567#1815791 (10Catrope) We backported a patch that fixes the error message problem (i.e. gives us real error messages rather than always saying "user is blocked"). It'll be... [00:32:00] (03CR) 10Catrope: [C: 032] Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) (owner: 10Mattflaschen) [00:35:00] (03Merged) 10jenkins-bot: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) (owner: 10Mattflaschen) [00:35:52] (03CR) 10Catrope: [C: 04-1] "You didn't address the comments on PS8 (they refer to needing to wait for T118058, but that's fixed now)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [00:51:57] (03CR) 10Catrope: [C: 032] Presentation model for reverted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253613 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [00:55:49] (03Merged) 10jenkins-bot: Presentation model for reverted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253613 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [01:04:26] (03CR) 10Catrope: [C: 04-1] Presentation model for edit-user-talk (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [01:21:38] (03CR) 10Catrope: [C: 04-1] "This doesn't handle bundled notifications correctly. I don't know if that's easy to fix or if it requires API changes (legoktm?)." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [01:27:38] (03CR) 10Catrope: "This also doesn't handle bundles correctly, similar to https://gerrit.wikimedia.org/r/#/c/253634/ : "RoanKattouw and 1 other left a messag" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253599 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson) [01:28:17] (03CR) 10Catrope: "Also check that bundling works correctly, see comments on https://gerrit.wikimedia.org/r/#/c/253634/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [01:28:27] legoktm: Sooo, Echo bundling [01:28:39] I -1ed https://gerrit.wikimedia.org/r/#/c/253634/ for not dealing with bundles correctly [01:28:48] But how *do* we deal with bundles in the new PresentationModel world? [01:29:51] I just -1ed 3/4 of Stephane's presentation model commits on that basis, without being able to offer him a solution :S [01:39:34] (03PS39) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [01:40:25] (03PS40) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [02:39:49] Thanks for reviewing the topic title patch, RoanKattouw. :) /cc quiddity [02:42:47] (03CR) 10Catrope: [C: 032] Notifications presentation models [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/252670 (https://phabricator.wikimedia.org/T116849) (owner: 10Matthias Mullie) [02:43:02] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, and 3 others: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#600971 (10Mattflaschen) [02:44:02] (03Merged) 10jenkins-bot: Notifications presentation models [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/252670 (https://phabricator.wikimedia.org/T116849) (owner: 10Matthias Mullie) [02:47:31] matt_flaschen: What's the status of https://phabricator.wikimedia.org/T113641 ? [02:47:41] * RoanKattouw is going over the board and trying to clean it up a bit [02:49:44] RoanKattouw, done but not reviewed recently. I need to bug people about it, which I'll do. [02:49:48] OK [02:49:51] RoanKattouw, thanks for the ping. [02:50:13] Also I moved https://phabricator.wikimedia.org/T109676 to blocked because it seems like all associated changes are merged (it was in CR Started) and we're waiting for DBA action [02:50:22] But correct me if I'm wrong [02:51:18] 3Collaboration-Team-Current, 10Flow, 7Database, 7Performance: Reduce Flow DB queries on Special:Contributions - https://phabricator.wikimedia.org/T118434#1816237 (10Catrope) [02:51:31] RoanKattouw, no, we need to run the script. [02:51:39] https://phabricator.wikimedia.org/T117786 [02:51:54] OK [02:52:02] How scary is that script? [02:52:18] Please answer in terms of how bad of an idea it is for me to run it at 6:52pm on a Wednesday night [02:52:21] :P [02:54:41] RoanKattouw, it should be fine. It will take a while, though, so I would use a screen session. It basically works by getting/reinserting all of the links, which adds the PK (which the app code really doesn't care at all about) as a side effect. [02:54:50] OK [02:54:53] I can start with a small wiki [02:57:17] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Run maintenance/FlowPopulateRefId.php on all production wikis - https://phabricator.wikimedia.org/T117786#1816245 (10Catrope) a:3Catrope [03:04:21] * RoanKattouw runs it on testwiki [03:04:33] Well that was fast [03:04:34] Catchable fatal error: Argument 8 passed to Flow\Model\WikiReference::__construct() must be an instance of Title, null given in /srv/mediawiki/php-1.27.0-wmf.7/extensions/Flow/includes/Model/WikiReference.php on line 37 [03:05:06] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Run maintenance/FlowPopulateRefId.php on all production wikis - https://phabricator.wikimedia.org/T117786#1816257 (10Catrope) ``` catrope@terbium:~$ mwscript extensions/Flow/maintenance/FlowPopulateRefId.php te... [03:07:00] (03PS1) 10Catrope: Make counts in FlowPopulateRevId.php output more useful [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254091 [03:07:23] (03PS2) 10Catrope: Make counts in FlowPopulateRevId.php output more useful [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254091 (https://phabricator.wikimedia.org/T117786) [03:10:47] RoanKattouw, ug, that error keeps cropping up. It is due to a title that fails to parse, probably because namespace configuration has changed. [03:11:19] RoanKattouw, also, I forgot jynus asked that we ping him to check lag, so we should probably do it when he's online for the larger wikis. [03:12:47] Yeah I'm live hacking something to tell me which title it is [03:12:48] (03CR) 10Mattflaschen: [C: 032] Make counts in FlowPopulateRevId.php output more useful [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254091 (https://phabricator.wikimedia.org/T117786) (owner: 10Catrope) [03:13:11] OK [03:13:18] Well right now the script doesn't even work yet :D [03:13:25] But yeah once I get it working I'll wait for him [03:15:31] RoanKattouw, there actually is debugging code for this: [03:15:39] wfDebugLog( 'Flow', __METHOD__ . ": Invalid title. Namespace: $namespace, Title text: $title" ); [03:15:40] ["ref_target_namespace"]=> [03:15:42] string(1) "0" [03:15:43] ["ref_target_title"]=> [03:15:45] string(21) "Topic:arg78o4a85gh750" [03:15:46] WTF [03:16:03] matt_flaschen: Where is that code located? [03:16:11] I don't see it in WikiReference::fromStorageRow() [03:16:19] (03Merged) 10jenkins-bot: Make counts in FlowPopulateRevId.php output more useful [extensions/Flow] - 10https://gerrit.wikimedia.org/r/254091 (https://phabricator.wikimedia.org/T117786) (owner: 10Catrope) [03:16:32] Oh, makeTitle [03:16:37] I think I might have put that there? [03:16:46] No, you did [03:17:51] Ooh I see [03:17:53] 2015-11-19 03:14:38 terbium testwiki Flow INFO: Flow\Model\WikiReference::makeTitle: Invalid title. Namespace: 104, Title text: Main_page [03:18:12] Also, WTF: [03:18:14] 2015-11-19 03:11:17 mw1025 enwiki Flow INFO: FlowHooks::onTitleSquidURLs: Invalid title Topic:Technical Theatre [03:19:37] RoanKattouw, so probably someone removed namespace 104. Need to look at the other one. [03:19:52] Yeah I guess so [03:20:12] It does mean that I need to go in and delete rows with ns=104 which jynus probably wants to be around for [03:20:25] Maybe we should write a cleanup script for these things [03:20:36] That removes all invalid rows [03:21:54] RoanKattouw, yeah. Same issue affects core (for both source and target of links) AFAICT, there we probably don't notice all the invalid data. [03:22:06] Well, two things [03:22:10] First, core has namespaceDupes.php [03:22:22] Second, core doesn't crash (not just with an exception but with a fatal) when there is even one invalid row in the DB [03:22:42] Right, but IIRC (from last time this cropped up) namespaceDupes does not handle this scenario. [03:22:49] Oh, a deleted namespace [03:22:50] Maybe not [03:22:57] But the (0, "Topic:blah") situation I saw, it does handle [03:22:58] I agree we need to handle it. [03:23:29] We can get rid of the fatal easily by not using type-hints, but that's just a band-aid. [03:23:42] Yeah [03:23:51] I mean that would probably work for the cleanup scripts [03:24:00] But it might have bad consequences for code that assumes the targetTitle is sane [03:24:43] Also, this is all routed through generic ObjectLocator code and there doesn't appear to be a way to tell it "the object you're looking for exists but is invalid" [03:25:07] RoanKattouw, it wouldn't work for this script anyway, since we both load and put it back in the DB, and ultimately we need the namespace of both source and target title to re-serialize. [03:25:19] Right, I just spotted that [03:25:39] And similarly I guess the serialization method probably doesn't have a way to say "I am not valid so I can't be serialized" [03:30:21] RoanKattouw, I'm thinking the right solution is to have removeNamespace.php [03:30:30] Yes, that too [03:30:38] removeNamespace.php --id 104 --canonicalnamespace "Foo" [03:30:49] Though ideally, our code wouldn't crash in the interim [03:31:00] Anyways namespace removals are rare [03:31:08] Not rare enough... [03:31:12] Yeah, I'll think about that next. [03:31:17] They mostly affect testwiki and mediawikiwiki [03:31:31] pl_from_namespace shouldn't be an issue unless someone removes a namespace where pages still are. [03:31:40] Yeah, AKA Don't Do That [03:31:48] Similar for the ref_src_namespace in Flow [03:31:57] pl_namespace pl_title should be handled as: [03:32:10] Wait, so you're working on dumps right now, right? Then history pagination, and artificial PK when it comes up? [03:32:48] Find row with pl_namespace 104, and change pl_title to "Foo:" + pl_title. [03:33:03] Basically, as if they linked to an page Foo:pl_title when there is no Foo namespace. [03:33:26] Yeah, I'm trying to get the dumps merged, but it just crashed again when I did an import. Not on duplicate ID, a different issue. [03:34:01] Yes, my next thing is history pagination. I'm not actually going to work on this, I just want to file a bug. [03:34:47] The dumps are a bit tedious to test, since to do a clean test I have to do a destroy/rebuild. [03:35:44] OK, cool [03:38:25] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Run maintenance/FlowPopulateRefId.php on all production wikis - https://phabricator.wikimedia.org/T117786#1816268 (10Catrope) Looks like the errors come from rows with namespace 104, which no longer exists on t... [03:38:41] RoanKattouw, hmm, I don't know if this is an issue with core, or if it's handled by link jobs. I will make this an "investigate" task. [03:38:55] Sure [03:39:33] Also, do you know what's up with the still-not-merged ES change? https://gerrit.wikimedia.org/r/#/c/226544/ [03:42:43] RoanKattouw, jynus said he would follow up with me, and probably got busy with other things. I will follow up with him tomorrow. [03:44:23] Never mind, there is no need to update the pagelinks table in response to page moves, since it doesn't track red link status, etc. It is definitely an issue and I still don't think namespaceDupes handles it. [03:44:37] Yeah namespace deletion is an issue [03:45:30] Yeah, the core link jobs don't help, since they don't actually need to do anything when a link destination moves. [03:48:12] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Maintenance-scripts: removeNamespace.php script for both core and Flow - https://phabricator.wikimedia.org/T119035#1816271 (10Mattflaschen) 3NEW [03:50:52] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Run maintenance/FlowPopulateRefId.php on all production wikis - https://phabricator.wikimedia.org/T117786#1816279 (10Mattflaschen) >>! In T117786#1816268, @Catrope wrote: > Long term, we could write a cleanup s... [03:55:13] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Log notification impressions and clicks again - https://phabricator.wikimedia.org/T114833#1816283 (10Catrope) 5Open>3Resolved ``` mysql:research@s3-analytics-slave [log]> SELECT event_action, count(*) FROM EchoInteraction_5782287 where timestamp be... [03:58:06] (03CR) 10Mattflaschen: [C: 04-1] "I think post has to go first, since a topic has to exist for you to summarize it. I'll test and if this resolves the root post error I sa" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [03:58:09] 3Collaboration-Team-Current, 10Echo: OOUI widgets for new notification design - https://phabricator.wikimedia.org/T115419#1816288 (10Catrope) a:3Mooeypoo [03:58:38] RoanKattouw, I think I figured out that error. If it works, I'll go ahead and upload it. [03:59:16] 3Collaboration-Team-Current, 10Echo, 7Voice & Tone, 7WorkType-NewFunctionality: Messages about talk pages are not completely adapted to non-talk namespaces - https://phabricator.wikimedia.org/T56433#1816292 (10Catrope) @legoktm Didn't I see code for this on your screen on Monday? Is there a patch in Gerrit? [04:11:50] (03PS1) 10Catrope: Remove styling for nonexistent mw-echo-title-heading class [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254097 [04:11:54] (03PS1) 10Catrope: Prevent link color on hover for the body ("payload") as well as the header [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254098 [04:16:33] (03PS8) 10Catrope: Add a NetworkHandler as a central API authority to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 (owner: 10Mooeypoo) [04:16:52] (03CR) 10Catrope: [C: 04-1] "This breaks the messages flyout, because it sends an API request for alerts." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 (owner: 10Mooeypoo) [04:27:19] See you all tomorrow [04:28:10] matt_flaschen: Bye! [10:33:28] 6Collaboration-Team-Backlog, 10Echo, 7Epic: Better organisation of the Notification Page - https://phabricator.wikimedia.org/T115316#1816677 (10Pginer-WMF) > Is it possible you have done some little mistakes at the pictures? Definitely. Thanks for catching them. At this point the main intention was to repr... [10:50:10] (03PS17) 10Matthias Mullie: Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) [10:50:27] (03CR) 10jenkins-bot: [V: 04-1] Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [10:53:36] (03PS18) 10Matthias Mullie: Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) [10:53:41] (03CR) 10Matthias Mullie: Dump Flow data (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [10:54:02] (03PS15) 10Matthias Mullie: Import Flow data dump [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) [12:24:46] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#1816821 (10Pginer-WMF) [12:26:40] 6Collaboration-Team-Backlog, 10Echo: Notifications panel: Easily explore bundled notifications - https://phabricator.wikimedia.org/T114356#1692910 (10Pginer-WMF) @MSchottlender-WMF I added details to the ticket about the questions you raised about "one-item bundles" and "unseen highlighting". Let me know if mo... [13:54:15] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-BounceHandler: Write presentation model for BounceHandler - https://phabricator.wikimedia.org/T116851#1816961 (10matthiasmullie) a:3matthiasmullie [14:00:29] 3Collaboration-Team-Current, 10Echo: API should expose enough structured data about notifications that frontend can render them - https://phabricator.wikimedia.org/T115418#1816982 (10matthiasmullie) I'll just keep the patch as-is (expose existing info to API). Adding in additional data that doesn't yet exist w... [14:00:36] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Echo: Allow secondary actions to have icons and subtitles/tooltips - https://phabricator.wikimedia.org/T115421#1816984 (10matthiasmullie) [14:12:42] (03PS2) 10Sbisson: Presentation model for page-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253634 (https://phabricator.wikimedia.org/T116843) [14:19:46] (03PS10) 10Sbisson: Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [14:21:53] (03PS11) 10Sbisson: Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [14:21:57] (03CR) 10jenkins-bot: [V: 04-1] Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [14:24:58] (03PS4) 10Matthias Mullie: Expose more data through API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) [14:28:30] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Echo: Allow secondary actions to have icons and subtitles/tooltips - https://phabricator.wikimedia.org/T115421#1817089 (10matthiasmullie) a:3matthiasmullie [14:29:50] (03PS12) 10Sbisson: Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [14:37:34] (03CR) 10Sbisson: Flow notification presentation models (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [14:39:42] (03PS13) 10Sbisson: Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [15:18:46] (03CR) 10Matthias Mullie: Expose more data through API (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie) [15:44:48] (03PS1) 10Matthias Mullie: Add secondary link details: icon & description [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) [16:11:30] (03CR) 10Sbisson: "The primary link text is/was used in emails." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) (owner: 10Matthias Mullie) [16:26:25] 6Collaboration-Team-Backlog, 10Flow, 6Community-Tech, 6Language-Engineering, and 4 others: Parsing team: Q3 2015-16 goals planning dependency tracker task - https://phabricator.wikimedia.org/T119088#1817460 (10Arrbee) [16:38:16] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Allow secondary actions to have icons and subtitles/tooltips - https://phabricator.wikimedia.org/T115421#1817494 (10matthiasmullie) The primary link currently also has an associated text, which is not displayed in the flyo... [16:39:27] (03CR) 10Matthias Mullie: "Aha, forgot about that, thanks for pointing that out :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) (owner: 10Matthias Mullie) [17:34:35] matt_flaschen: are you around? [17:34:51] stephanebisson, yeah. [17:35:27] matt_flaschen: the mw-vagrant patch to create the Selenium Flow users seems good [17:35:37] but it depends on another patch with a long history [17:36:09] are we waiting for some people to go back to it? [17:36:25] https://gerrit.wikimedia.org/r/#/c/222069 [17:36:53] stephanebisson, yeah, I pinged bd808 about it yesterday. [17:37:00] I'll ping a couple other people now. [17:37:41] ok [17:38:16] if I +2 the Flow users' patch, is it gonna wait and cascade once the dependency is +2? [17:38:19] matt_flaschen: I think I can take a look this afternoon. As I recall marxarelli had some request on part of it or a dependency the last time I looked (which was a while ago) [17:41:25] bd808, yep, he left four comments on PS3, which I addressed . [17:42:08] stephanebisson, yeah, if you +2 the 2nd one, it should auto-merge when the 1st is +2'ed. [17:42:21] Well, assuming it passes. [18:04:51] matt_flaschen: which priviledge do I need to see the "block" link next to usernames? [18:07:08] (03PS1) 10Legoktm: EventMapper: Always return an array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254165 [18:07:14] (03PS1) 10Legoktm: Add accessor for bundled events in EventPresentationModel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254166 [18:09:37] (03CR) 10jenkins-bot: [V: 04-1] EventMapper: Always return an array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254165 (owner: 10Legoktm) [18:10:41] (03CR) 10jenkins-bot: [V: 04-1] Add accessor for bundled events in EventPresentationModel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254166 (owner: 10Legoktm) [18:11:41] stephanebisson, should be 'block' right. E.g. sysop should have it. [18:13:02] matt_flaschen: as I said on the patch, 'Selenium Flow user' needs it for a test [18:13:46] (03PS2) 10Legoktm: EventMapper::fetchByUserBundleHash(): Always return an array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254165 [18:13:49] (03PS2) 10Legoktm: Add accessor for bundled events in EventPresentationModel [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254166 [18:14:48] stephanebisson, will update later. Normally suppressors would also be sysops. I just didn't think of it when writing the patch. [18:15:03] alright [18:24:13] Dump exported and imported cleanly this time with no exceptions. Everything looks fine except one minor thing. There are no posts... [18:24:32] mlitn, they're in the export but don't show up. Let me see if purge fixes it. [18:25:43] No, and they're not in history. [18:25:56] And some of the topic history throw exceptions. [18:27:58] I should have caught that in review... [18:29:28] I think it's a regression from the change to use onImportHandleToplevelXMLTag, since not all posts are top-level. [18:37:26] matt_flaschen: I see a PHP notice when importing some revision (Notice: Undefined index: -topic in extensions/Flow/FlowActions.php on line 599) [18:37:47] caused by permission gaps (where moderated revision is omitted) [18:38:20] the “restored” revision exists, though [18:39:03] but then permissions try to look at parent revision to see if it was hide/delete/…, but that revision is not what is used to be anymore... [18:39:58] should probably change the changeType for a “restore” permission in the dump? (to “edit-post” or “edit-title”?) [18:49:33] (03CR) 10Matthias Mullie: [C: 04-1] "Undo primary link changes here: we'll keep the label around for now." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254147 (https://phabricator.wikimedia.org/T115421) (owner: 10Matthias Mullie) [19:03:22] 6Collaboration-Team-Backlog, 10Flow, 6Community-Tech, 6Language-Engineering, and 4 others: Parsing team: Q3 2015-16 goals planning dependency tracker task - https://phabricator.wikimedia.org/T119088#1818145 (10GWicke) Some things that I'd love to see prioritized on your end are: - Improve how Parsoid mark... [19:06:24] mlitn, oh, I see. yeah, a null edit-post sounds reasonable. [19:06:45] As in same content/null edit. [19:06:56] I've got to break now. Meeting someone for lunch. [19:15:25] (03CR) 10Catrope: [C: 032] EventMapper::fetchByUserBundleHash(): Always return an array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254165 (owner: 10Legoktm) [19:18:43] (03Merged) 10jenkins-bot: EventMapper::fetchByUserBundleHash(): Always return an array [extensions/Echo] - 10https://gerrit.wikimedia.org/r/254165 (owner: 10Legoktm) [19:48:51] (03PS16) 10Matthias Mullie: Import Flow data dump [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) [19:49:01] matt_flaschen: I think I just fixed the import of posts ^^ [19:49:35] after encountering end nodes, it skipped to the next node... [20:17:08] 6Collaboration-Team-Backlog, 10Flow, 6Community-Tech, 6Language-Engineering, and 4 others: Parsing team: Q3 2015-16 goals planning dependency tracker task - https://phabricator.wikimedia.org/T119088#1818427 (10ssastry) >>! In T119088#1818145, @GWicke wrote: > - Multimedia support, even if it's "just" mlitn, shouldn't not appear on the top-level? [20:21:28] it’s not on the top level [20:22:18] I’m not sure exactly why that thing is called handletopleveltag, it read()s all tags :p [20:23:20] (the only reason ‘children’ is in that hook is so it doesn’t output “unhandled tag ‘children’”, by the way) [20:24:28] mlitn, okay, so basically ImportHandleToplevelXMLTag handles it if it's not handled by a lower level function (either a lower level function core like handlePage or a lower level one in Flow)? [20:25:18] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Log notification impressions and clicks again - https://phabricator.wikimedia.org/T114833#1818463 (10Etonkovidova) @Catrope > Looks good to me Agree. [20:26:12] yes; unless another function moves xmlreaders pointer inside one of those handlers, it will just move node by node [20:31:24] mlitn, oh, I see, and the unknown end tag was causing it to skip like you said? [20:31:43] yes, indeed [20:31:52] I see the warning for this only goes to $wgDebugLogFile which I disabled before since it kills my performance. :) [20:32:01] Obviously will re-enable temporarily. [20:32:06] (plus, handleRevisions also had to move ahead 1 more node) [20:32:22] I still have to fix the php notice though [20:32:36] although, since it’s a notice, it may not even affect anything [20:32:39] but I’ll take a look at that tomorrow [20:32:49] mlitn, I can go ahead and do it if you want. [20:32:56] feel free :) [20:33:06] Alright, will do. [21:49:17] (03PS41) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [22:04:00] (03PS9) 10Mooeypoo: Add a NetworkHandler as a central API authority to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 [22:16:33] 3Collaboration-Team-Current, 10Echo, 10UI-Standardization, 5Patch-For-Review, and 2 others: Echo notification icons should be properly themed in MonoBook - https://phabricator.wikimedia.org/T112290#1818829 (10Legoktm) 5Open>3Resolved [22:27:34] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to save or preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1818875 (10csteipp) [22:31:25] 3Collaboration-Team-Current, 10Flow: [betalabs] Flow\Exception\WikitextException on clicking deleted topic link from View history - https://phabricator.wikimedia.org/T119133#1818932 (10Etonkovidova) 3NEW [22:40:16] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-skins-Metrolook: Echo Dosen't look good in metrolook - https://phabricator.wikimedia.org/T119134#1818991 (10Paladox) [22:42:30] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-skins-Metrolook: Echo Dosen't look good in metrolook - https://phabricator.wikimedia.org/T119134#1819000 (10Paladox) Caused by https://gerrit.wikimedia.org/r/#/c/250969/ Ive tested and can see it is caused by https://gerrit.wikimedia.org/r/#/c/250969/2 [22:52:46] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-skins-Metrolook, 5Patch-For-Review: Echo Dosen't look good in metrolook - https://phabricator.wikimedia.org/T119134#1819080 (10Paladox) @Mattflaschen please allow other browsers to use the default grey as background. Or at least blacklist certain browsers fr... [23:11:10] (03PS9) 10Mooeypoo: Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 [23:23:31] (03PS42) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [23:25:09] (03PS10) 10Mooeypoo: Add a NetworkHandler as a central API authority to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 [23:25:21] (03PS10) 10Mooeypoo: Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 [23:25:27] (03PS43) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [23:26:12] (03CR) 10Mooeypoo: [C: 04-1] Expose more data through API (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie) [23:32:45] https://www.mediawiki.org/wiki/Special:DeletedContributions/Inzamam3004 [23:32:53] (newest | oldest) View (newer 50 | older 50) (20 | 50 | 100 | 250 | 500) [23:32:53] (newest | oldest) View (newer 50 | older 50) (20 | 50 | 100 | 250 | 500) [23:33:01] no "No changes were found matching these criteria." [23:33:12] wondering if it might be Flow-related [23:33:33] Oh, yes I think it might be related to a change I merged in Flow this week [23:34:15] Also, something weird going on here: https://www.mediawiki.org/wiki/Topic:Sszlgl8mj0enb8v3 [23:34:23] Topic was deleted, then I deleted a comment [23:34:31] 6Collaboration-Team-Backlog, 10Thanks, 5Patch-For-Review: Notifications: Getting multiple "Thank"s from one user for the same edit is possible (double/duplicate) - https://phabricator.wikimedia.org/T53303#1819255 (10Legoktm) a:5Legoktm>3None I'm not actively working on this at the moment. [23:34:36] History link on the comment... only shows topic deletion [23:35:20] (03PS44) 10Mooeypoo: [WIP] Add cross-wiki bundled notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [23:35:23] (03PS5) 10Mooeypoo: Expose more data through API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie) [23:40:53] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-skins-Metrolook, 5Patch-For-Review: Echo Dosen't look good in metrolook - https://phabricator.wikimedia.org/T119134#1819327 (10Mattflaschen) >>! In T119134#1819080, @Paladox wrote: > Or at least blacklist certain browsers from accessing certain pieces other... [23:41:48] Oh, no, I merged a patch for Special:Notifications that I was concerned might cause an empty view without a message, it wasn't related to contributions [23:56:57] RoanKattouw: why do we need to order by timestamp for https://gerrit.wikimedia.org/r/#/c/248905/8/db_patches/echo_unread_wikis.sql,cm ? [23:57:04] I was thinking we'd just select all the rows? [23:57:19] I guess we could [23:57:36] There could only be up to ~800 of them I suppose [23:57:52] what timestamp were you thinking of using? [23:58:05] The max of the timestamps of the notifs involved [23:58:14] That might be tricky to update as well [23:58:44] But if we want to order the cross-wiki item in the rest of the list correctly (which I suppose we might not do), then we need to know the timestamp of the latest foreign notif [23:59:12] Right, adding the timestamp to the table is trivial and already implemented. [23:59:17] We just don't have an index on it yet [23:59:20] OK, yeah, sure [23:59:29] Alright, yeah I agree we may not need it