[00:00:49] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 031] "Code looks good." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie)
[00:08:40] <matt_flaschen>	 Heading out, will be on later.
[01:11:02] <grrrit-wm>	 (03PS35) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) 
[01:11:45] <grrrit-wm>	 (03PS4) 10Mooeypoo: Add a NetworkHandler as a central API authority to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 
[01:12:02] <grrrit-wm>	 (03PS3) 10Mooeypoo: Change the naming of 'notifiction option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 
[01:13:06] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo)
[01:13:53] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Change the naming of 'notifiction option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 (owner: 10Mooeypoo)
[01:16:40] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Looks great, ready to merge except for some minor things." (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) (owner: 10Mattflaschen)
[01:20:55] <RoanKattouw>	 matt_flaschen: ---^ tiny tiny things and then it can be merged
[01:22:59] <grrrit-wm>	 (03CR) 10Catrope: Add a NetworkHandler as a central API authority to Echo (037 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 (owner: 10Mooeypoo)
[01:23:12] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Old comments (sorry for not submitting before) on PS3" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 (owner: 10Mooeypoo)
[01:59:26] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "You missed a comment in modules/nojs/mw.echo.notifications.less that mentions NotificationOptionWidget" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 (owner: 10Mooeypoo)
[05:51:00] <grrrit-wm>	 (03CR) 10Mattflaschen: Add support for edit summary formatting in topic titles (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) (owner: 10Mattflaschen)
[06:28:50] <grrrit-wm>	 (03PS10) 10Mattflaschen: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) 
[06:29:08] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) (owner: 10Mattflaschen)
[06:31:15] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 6Security: Ensure users can not access topics from deleted boards via Varnish caching - https://phabricator.wikimedia.org/T116095#1813097 (10demon)
[06:57:13] <matt_flaschen>	 Topic title finally merge-rotted again.  It had a good run.  We'er close now, though.  Will rebase.
[07:00:01] <matt_flaschen>	 Also, now we can't merge it due to code freeze (and this is *not* a change to make an exception on)
[07:05:00] <grrrit-wm>	 (03PS11) 10Mattflaschen: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) 
[07:10:03] <quiddity>	 matt_flaschen, aww, so close!  But agreed.
[07:10:17] <quiddity>	 Also, gotobed!
[07:12:46] * quiddity takes own advice
[08:08:27] <matt_flaschen>	 It's not code freeze.  I don't know why I was thinking the coming day was Tuesday.
[08:11:15] <grrrit-wm>	 (03PS16) 10Matthias Mullie: Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) 
[08:11:27] <grrrit-wm>	 (03CR) 10Matthias Mullie: Dump Flow data (034 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie)
[08:12:49] <grrrit-wm>	 (03PS14) 10Matthias Mullie: Import Flow data dump [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) 
[10:07:51] <grrrit-wm>	 (03PS1) 10Matthias Mullie: 'Load more' check should be based on retrieved data, not what could render [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253862 
[10:08:09] <wikibugs>	 10Pywikibot-Flow, 5Patch-For-Review: Moderate Flow topics and posts - https://phabricator.wikimedia.org/T109308#1813267 (10Liuxinyu970226)
[10:09:45] <grrrit-wm>	 (03CR) 10Matthias Mullie: [C: 04-1] "Apart from the minor comment, this patch looks good." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253643 (owner: 10Legoktm)
[11:28:02] <grrrit-wm>	 (03PS3) 10Matthias Mullie: Expose more data through API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) 
[11:28:19] <grrrit-wm>	 (03CR) 10Matthias Mullie: "I had no idea we still had non-HHVM machines. Let alone 5.3 :)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie)
[11:31:09] <grrrit-wm>	 (03CR) 10Hashar: "check zend" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie)
[11:43:18] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-EducationProgram: Write presentation models for notifications in EducationProgram - https://phabricator.wikimedia.org/T116850#1813426 (10matthiasmullie) a:3matthiasmullie
[12:57:47] <grrrit-wm>	 (03PS3) 10Sbisson: Surface permission errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/253752 (https://phabricator.wikimedia.org/T118890) 
[13:01:17] <grrrit-wm>	 (03CR) 10Sbisson: Surface permission errors (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/253752 (https://phabricator.wikimedia.org/T118890) (owner: 10Sbisson)
[13:39:16] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Problems encountered when enabling Flow on Chinese Wikipedia - https://phabricator.wikimedia.org/T118567#1813554 (10Lakokat) Quick update: [[https://zh.wikipedia.org/wiki/User:Zhanghandsome|User:Zhanghandsome]] had some luck today. Another failed, though.
[14:02:43] <grrrit-wm>	 (03PS1) 10Paladox: Update js [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253899 
[14:06:58] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 10VisualEditor, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1813574 (10Pginer-WMF) >>! In T116417#1803556,...
[15:18:47] <grrrit-wm>	 (03CR) 10Sbisson: [C: 031] Notifications presentation models [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/252670 (https://phabricator.wikimedia.org/T116849) (owner: 10Matthias Mullie)
[16:54:27] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] 'Load more' check should be based on retrieved data, not what could render [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253862 (owner: 10Matthias Mullie)
[16:57:48] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Surface permission errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/253752 (https://phabricator.wikimedia.org/T118890) (owner: 10Sbisson)
[16:58:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: 'Load more' check should be based on retrieved data, not what could render [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253862 (owner: 10Matthias Mullie)
[17:00:50] <grrrit-wm>	 (03Merged) 10jenkins-bot: Surface permission errors [extensions/Flow] - 10https://gerrit.wikimedia.org/r/253752 (https://phabricator.wikimedia.org/T118890) (owner: 10Sbisson)
[17:17:27] <stephanebisson>	 quiddity: Hi
[17:18:00] <quiddity>	 hey
[17:18:27] <stephanebisson>	 quiddity: I'm looking into "Flow support in Nuke"
[17:18:39] <stephanebisson>	 wondering how you see this working
[17:19:13] <stephanebisson>	 Nuke seems to be page-centric, not contribution-centric
[17:20:01] <stephanebisson>	 we could probably delete topics easily
[17:20:25] <quiddity>	 ideally it would , yeah, exactly that.  It would help to combat new-topic-spam
[17:20:43] <stephanebisson>	 it wouldn't help with posts and bad edits
[17:21:54] <quiddity>	 nod.  (although, aren't individual posts essentially separate pages?)
[17:22:19] <stephanebisson>	 topics are pages, not posts
[17:22:24] <quiddity>	 bad edits are definitely not included. they need to be handled by undo.
[17:22:26] <quiddity>	 ok
[17:23:11] <stephanebisson>	 ok, I'll start with topics
[17:23:13] <stephanebisson>	 thanks
[17:23:42] <quiddity>	 :)
[17:46:36] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "Minor doc issue, I'll amend and +2." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253647 (https://phabricator.wikimedia.org/T118059) (owner: 10Sbisson)
[17:46:55] <wikibugs>	 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 5Patch-For-Review: PageTriage Echo notifications for basic review/patrol actions are not useful - https://phabricator.wikimedia.org/T75925#1814201 (10Ragesoss) Okay, my patch is stale, but this issue is still relevant: PageCuration notificatio...
[17:47:37] <grrrit-wm>	 (03PS2) 10Legoktm: Extract `getMessageWithAgent` [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253647 (https://phabricator.wikimedia.org/T118059) (owner: 10Sbisson)
[17:48:04] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Extract `getMessageWithAgent` [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253647 (https://phabricator.wikimedia.org/T118059) (owner: 10Sbisson)
[17:53:06] <grrrit-wm>	 (03Merged) 10jenkins-bot: Extract `getMessageWithAgent` [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253647 (https://phabricator.wikimedia.org/T118059) (owner: 10Sbisson)
[17:53:37] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke: Add Flow support to Nuke - https://phabricator.wikimedia.org/T115695#1814227 (10SBisson) a:3SBisson
[17:54:47] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Support easy use of standard $1+$2 values (agent and agent for gender) in getBodyMessage - https://phabricator.wikimedia.org/T118059#1814233 (10Legoktm) 5Open>3Resolved
[17:54:48] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 10Flow, 5Patch-For-Review: Write presentation models for notifications in Flow - https://phabricator.wikimedia.org/T116845#1814234 (10Legoktm)
[18:11:54] <legoktm>	 does anyone understand https://gerrit.wikimedia.org/r/#/c/253899/ ?
[18:13:44] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] Expose more data through API (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie)
[18:14:51] <stephanebisson>	 legoktm: the "what", yes, the "why", no.
[18:21:19] <grrrit-wm>	 (03CR) 10Sbisson: "Could you elaborate on the reasons for proposing this change?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253899 (owner: 10Paladox)
[18:21:37] <grrrit-wm>	 (03PS2) 10Mattflaschen: Update JS closure style [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253899 (owner: 10Paladox)
[18:22:20] <grrrit-wm>	 (03PS9) 10Sbisson: Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) 
[18:23:08] <grrrit-wm>	 (03CR) 10Mattflaschen: "Presumably to be more rigid about JS conventions/style. This is the version used at the https://www.mediawiki.org/wiki/Manual:Coding_conv" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253899 (owner: 10Paladox)
[18:38:31] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Presentation model for email-user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253641 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson)
[18:40:52] <grrrit-wm>	 (03PS5) 10Mooeypoo: Add a NetworkHandler as a central API authority to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 
[18:41:13] <grrrit-wm>	 (03PS4) 10Mooeypoo: Change the naming of 'notifiction option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 
[18:41:37] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Change the naming of 'notifiction option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 (owner: 10Mooeypoo)
[18:42:03] <grrrit-wm>	 (03Merged) 10jenkins-bot: Presentation model for email-user [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253641 (https://phabricator.wikimedia.org/T116843) (owner: 10Sbisson)
[18:44:34] <grrrit-wm>	 (03PS5) 10Mooeypoo: Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 
[18:44:55] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 (owner: 10Mooeypoo)
[18:44:58] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Add a NetworkHandler as a central API authority to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 (owner: 10Mooeypoo)
[19:28:48] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Compare selected revisions for Flow history - https://phabricator.wikimedia.org/T108407#1814530 (10Elitre) This.
[19:33:22] <grrrit-wm>	 (03PS6) 10Mooeypoo: Add a NetworkHandler as a central API authority to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 
[19:37:48] <grrrit-wm>	 (03PS6) 10Mooeypoo: Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 
[19:38:04] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 (owner: 10Mooeypoo)
[19:40:03] <stephanebisson>	 quiddity: re: nuking topics, what kind of deletion do we want?
[19:40:31] <grrrit-wm>	 (03PS7) 10Mooeypoo: Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 
[19:40:48] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 (owner: 10Mooeypoo)
[19:40:58] <stephanebisson>	 quiddity: we have different moderation levels (hide, delete, suppress), we don't have revision deletion yet
[19:40:59] <mooeypoo>	 wtf.
[19:42:55] <legoktm>	 stephanebisson: delete I would assume
[19:42:56] <grrrit-wm>	 (03PS7) 10Mooeypoo: Add a NetworkHandler as a central API authority to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 
[19:44:02] <stephanebisson>	 legoktm: makes sense
[19:45:49] <quiddity>	 stephanebisson, yup, delete. That appears to be the only option in the current tool.
[19:46:19] <grrrit-wm>	 (03PS8) 10Mooeypoo: Change the naming of 'notification option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 
[19:48:42] <grrrit-wm>	 (03PS36) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) 
[19:50:45] <grrrit-wm>	 (03Abandoned) 10Mooeypoo: [DO NOT MERGE] Experimentally adding expandable items to notification widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252611 (owner: 10Mooeypoo)
[20:10:25] <grrrit-wm>	 (03CR) 10Paladox: "Also they are executed differently." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253899 (owner: 10Paladox)
[20:20:22] <grrrit-wm>	 (03CR) 10Mattflaschen: "What is the relevant difference in execution?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253899 (owner: 10Paladox)
[20:22:12] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Need a way to get from a topic page to the associated content page(s) and talkpage(s) - https://phabricator.wikimedia.org/T90280#1814774 (10QuimGil) ... I can only say that the lack of a link to the related Page is becoming annoying. As a user, I would expect the Page tab t...
[20:49:44] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Notification: Your file was used - https://phabricator.wikimedia.org/T77154#1814907 (10Quiddity)
[21:08:19] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 6Security, 5Patch-For-Review: Ensure users can not access topics from deleted boards via Varnish caching - https://phabricator.wikimedia.org/T116095#1815008 (10csteipp) 5Open>3Resolved Since the security issue is fixed, I'm going to close this now. Would be great to...
[21:17:32] <stephanebisson>	 matt_flaschen: when you have a moment
[21:18:30] <matt_flaschen>	 stephanebisson, yep.
[21:18:49] <stephanebisson>	 matt_flaschen: do you remember why we have rc_title => 'owner' for new-topic?
[21:20:45] <matt_flaschen>	 stephanebisson, I don't specifically remember that being put in, but new-topic is pretty consistently an action on the board page.
[21:21:16] <stephanebisson>	 matt_flaschen: yes, it's also the 'creation' of the topic page
[21:22:12] <matt_flaschen>	 stephanebisson, true, but e.g. IIRC topic creations don't show as an action if you have that topic watched.  Only the first post does.
[21:23:08] <matt_flaschen>	 stephanebisson, do you want to change it for Nuke support?
[21:23:26] <stephanebisson>	 matt_flaschen: yes, we collapse the topic creation and first post into 1 logical event, but we also mark it with 'N'
[21:23:48] <matt_flaschen>	 Also, the bold one for topic creations on Special:RecentChanges is the owner page, but that probably doesn't strictly require rc_title owner.
[21:23:56] <stephanebisson>	 matt_flaschen: yes, one way to make Nuke see our topics correctly is to use rc_title => 'article' and rc_new => 1
[21:24:58] <stephanebisson>	 in a way is seems consistent with everything else in recentchanges table but the way we consume it in our code is not simple, that's why I'm asking what you think
[21:24:58] <matt_flaschen>	 stephanebisson, I was thinking more along the lines of hooking into Nuke, since we don't delete topics by deleting the topic page.  We use Flow's own mechanism.
[21:24:59] <matt_flaschen>	 Or is it about Nuke 'seeing' the topics, not how it actually deletes them?
[21:26:42] <stephanebisson>	 matt_flaschen: deletion is currently prevented in onArticleDelete hook, I don't know if executing our own deletion (moderation) there makes sense
[21:28:09] <stephanebisson>	 matt_flaschen: were you thinking about adding hooks to Nuke specifically to extend retrieval and deletion of pages?
[21:28:56] <matt_flaschen>	 stephanebisson, it's probably doable.  I did that as a quick workaround, but I think triggering Flow's mechanism from onArticleDelete would work.  I would just make sure it's not suppressed. If not, trigger moderate-topic to change it to delete.
[21:29:28] <grrrit-wm>	 (03PS37) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) 
[21:29:50] <matt_flaschen>	 stephanebisson, I only thought about it briefly (I never actually worked on it), but my understanding was Nuke basically just deletes all pages created by a user.  So I was thinking, use/add a hook in Nuke that says "nuke of JohnSmith's edits requested", then have Flow delete all topics created by John Smith.
[21:31:08] <stephanebisson>	 matt_flaschen: it selects pages to delete based on a few criteria (user, NS, pattern, limit)
[21:31:51] <matt_flaschen>	 stephanebisson, yeah, looking at it now, I see why we have to either change how we do RC or hook into the retrieval phase.
[21:32:33] <stephanebisson>	 matt_flaschen: are you aware of any other deletion entry point that would be affected by me changing onArticleDelete?
[21:33:12] <matt_flaschen>	 stephanebisson, I think changing rc_title might cause some teething pains, but we already link to both board and topic for topic creations on S:RecentChanges. So the data's there. Also, RC expires, so we don't have to maintain back-compat for that long.
[21:33:59] <matt_flaschen>	 Lookign
[21:34:53] <stephanebisson>	 I agree, I'm willing to take the pain if we think it makes the data clearer
[21:35:18] <stephanebisson>	 matt_flaschen: there's ?action=delete
[21:35:50] <matt_flaschen>	 stephanebisson, right.  I am thinking that we would keep that tab hidden for topics (to avoid exposing it in the UI).  If they go to it anyway, question is what to do:
[21:35:55] <matt_flaschen>	 1. Currently, we block completely.
[21:37:02] <matt_flaschen>	 2. We could have onArticleDelete block the core-level deletion, but do the Flow topic deletion instead and show a message about that.  Not clean, but I don't think we want to delete the topic at the core level sometimes, but not other times.
[21:37:25] <matt_flaschen>	 With #1, we would have to add a hook to Nuke for the deletion phase (even if retrieval can be handled by changing RC).
[21:38:18] <matt_flaschen>	 3. We could always delete topic at both core and Flow level.  I think that is too big a change, and should wait until we redo moderation for the revdel, etc. work.
[21:38:22] <stephanebisson>	 when you say "at the core level", you mean the 'page' table?
[21:38:33] <matt_flaschen>	 Yeah, page/archive tables.
[21:38:43] <stephanebisson>	 yeah, not 3
[21:38:59] <matt_flaschen>	 And re #3 not sure we should even do that change then, but we could at least talk about it then.
[21:39:28] <matt_flaschen>	 That me look at the hooks a little closer.
[21:39:32] <matt_flaschen>	 Some are user-facing, some not.
[21:40:28] <stephanebisson>	 I don't know if #2 would work anyway. In the hook, we can moderate the topic but then we have to return false to prevent core deletion, and that mean a negative result in the UI
[21:43:22] <matt_flaschen>	 stephanebisson, yeah, that was the 'not clean' part.
[21:43:49] <matt_flaschen>	 stephanebisson, I'm looking at the exact deletion path in core to see where we could maybe intercept.
[21:44:41] <stephanebisson>	 can the content model help?
[21:49:23] <matt_flaschen>	 The deletion stuff is crazy:
[21:49:28] <matt_flaschen>	 DeleteAction => Article->delete => Article->doDelete => WikiPage->doDeleteArticleReal
[21:49:31] <matt_flaschen>	 SpecialNuke->doDelete => Article->doDeleteArticle => WikiPage->doDeleteArticle => WikiPage->doDeleteArticleReal
[21:49:41] <matt_flaschen>	 Half-expecting to see doDeleteArticleFakeActuallyLetsDoItAnyway
[21:50:31] <stephanebisson>	 it's only a matter of time
[21:50:55] <matt_flaschen>	 stephanebisson, thinking anything in particular re content model, or just something to think about?
[21:52:32] <stephanebisson>	 matt_flaschen: nothing specific
[21:52:38] <matt_flaschen>	 stephanebisson, well, they both ultimately trigger ArticleDelete, as expected.  And it seems to take pains to prevent you aborting the core deletion while marking it successful.
[21:52:44] <matt_flaschen>	 $status->fatal( 'delete-hook-aborted' );
[21:55:09] <matt_flaschen>	 stephanebisson, okay, if we don't want to do #3, what do we want to do?
[21:55:25] <matt_flaschen>	 Ideally we could just replace the implementation without it considering that an error...
[21:56:32] <stephanebisson>	 a deletion hook in Nuke
[21:57:09] <stephanebisson>	 unless you're confident we can modify core deletion without setting the world on fire
[21:57:33] <matt_flaschen>	 stephanebisson, yeah, deletion hook is the simple way.  The only other one I can think of is:
[21:57:56] <matt_flaschen>	 Make ArticleConfirmDelete abortable
[21:58:20] <matt_flaschen>	 So we still have the "aborted but it was really successful", but the user never sees that since they get an error as soon as they go to action=delete, and that actually prevents them from completing the form.
[21:58:38] <matt_flaschen>	 Right now, they see an error but it doesn't block the form, which I found very annoying at the time, but didn't fix.
[21:59:22] <matt_flaschen>	 So there's just a message at the topic of action=delete for topics currently, but the form is still there.
[21:59:34] <matt_flaschen>	 I would be willing to do that core change if you prefer that to hooking Nuke.
[22:00:25] <stephanebisson>	 that helps with ?action=delete but how does it help with Nuke?
[22:03:03] <matt_flaschen>	 stephanebisson, it means we could then change our ArticleDelete hook to actually do the Flow-style deletion then abort it.  But you're right, I just realized it still won't work because Nuke also checks if it was successful (it doesn't display the Flow-provided message, but it would just act like the topics weren't successfuly deleted).
[22:03:23] <matt_flaschen>	 stephanebisson, so yeah, I think we have to hook Nuke.
[22:03:28] <stephanebisson>	 right
[22:04:03] <matt_flaschen>	 The user would never see the Flow "it succeeded even though core thinks it fails" message on action=delete (since they wouldn't get that far), but Nuke and probably other stuff would still be a problem.
[22:06:00] <stephanebisson>	 I'll try something
[22:06:07] <stephanebisson>	 matt_flaschen: thanks!
[22:07:02] <matt_flaschen>	 stephanebisson, no problem.  It was good talking out the possibilities.
[22:17:03] <legoktm>	 https://github.com/facebook/hhvm/issues/6569
[22:20:33] <matt_flaschen>	 Heading out in 15 minutes.
[22:23:13] <stephanebisson>	 matt_flaschen: with your mw-vagrant patch that adds varnish as a dependency for flow
[22:23:32] <matt_flaschen>	 Yep
[22:23:35] <stephanebisson>	 if I just download the patch and provision varnish is not selected
[22:23:43] * RoanKattouw apologizes for delete / doDelete / doDeleteArticleReal
[22:23:50] <RoanKattouw>	 Probably not all my fault, but I think I created one of those
[22:24:04] <matt_flaschen>	 I know how it goes.  Accepted. :)
[22:24:11] <matt_flaschen>	 stephanebisson, you mean the * in list-roles?
[22:24:16] <stephanebisson>	 yes
[22:24:38] <matt_flaschen>	 stephanebisson, yeah, it never is for roles included by dependency.
[22:24:42] <matt_flaschen>	 "Note that roles enabled by dependency are not marked." at the bottom.
[22:24:47] <stephanebisson>	 and :6081 doesn't work
[22:24:56] <matt_flaschen>	 It is a dependency, but it does not properly do the port forwarding as mentioned in the commit message.  You have to enable-role it.
[22:25:25] <matt_flaschen>	 If you think it is pointless, I can just do the docfix, but I am hoping a. https://phabricator.wikimedia.org/T118605 will be fixed sometime. and b. It at least makes people aware and consider using Varnish with Flow.
[22:25:37] <stephanebisson>	 oh I see
[22:26:26] <stephanebisson>	 it's ok
[22:27:00] <stephanebisson>	 I'll try running the browser tests through varnish while I'm having dinner
[22:28:19] <matt_flaschen>	 Great, thanks.
[22:36:06] <matt_flaschen>	 Heading out, will be on later.
[23:42:31] <grrrit-wm>	 (03CR) 10Catrope: [WIP^n] Create a notifications widget demo (0365 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo)
[23:42:42] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] "Comments on PS35" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo)
[23:48:09] <grrrit-wm>	 (03PS38) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551)