[01:02:18] Hey all! The Russian WikiFur is looking for an editor discussion extension - LiquidThreads? Flow? Or something else? I see feature development has stopped on Flow - is it likely to restart at any point? Is it in a good position to use, or does it need more baking? (Probably we would wait until 1.27 anyway, since it has a 1.24 requirement and we're on LTS.) [01:04:48] Also the channel topic says you're working on Flow but it seems to be Workflows now based on https://www.mediawiki.org/wiki/Flow ... :-) [01:08:56] I think you're going to find that 1.23 Flow is pretty outdated and likely buggy, but the same can be said about 1.23 LQT... [01:09:17] Yeah, that's one thing I wanted to avoid. :-D [01:09:25] And Flow master requires basically MW master these days [01:10:27] What I currently plan to say to the community in question is "let's wait until 1.27 is out and see where Flow is", if that's a sensible thing to do. [01:10:46] Yeah, that sounds reasonable [01:11:21] It seems like it's been decided that it's not the most important thing in the world of wiki editing, which is fair enough since it's donor dollars working on it. But if it's a more solid foundation than LQT, that's something. [01:12:31] It has significantly more developer resources working on it than LQT :) [01:12:47] Yeah, I figured. ;-) [09:46:56] 6Collaboration-Team-Backlog, 10Flow, 7Technical-Debt: Add a surrogate primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T95203#1807252 (10jcrespo) [09:46:57] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, and 2 others: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1807253 (10jcrespo) [09:51:30] 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Make ref_id of flow_wiki_ref and flow_ext_ref not null and PK (DBA phase 2) - https://phabricator.wikimedia.org/T117787#1807262 (10jcrespo) I think this is blocked by another task, and not by the schema change, so it s... [09:59:06] 3Collaboration-Team-Current, 10Echo, 7Design, 5Patch-For-Review, 7WorkType-NewFunctionality: Allow marking Echo notifications as unread - https://phabricator.wikimedia.org/T73564#1807276 (10Pginer-WMF) As per the feedback when this ticket was discussed, it seems we want to keep the "mark as unread" just... [10:19:53] 3Collaboration-Team-Current, 10Echo, 7Design, 5Patch-For-Review, 7WorkType-NewFunctionality: Allow marking Echo notifications as unread - https://phabricator.wikimedia.org/T73564#1807303 (10Pginer-WMF) [10:20:02] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison: Try all possible admin actions concerning Flow - https://phabricator.wikimedia.org/T116785#1807304 (10Trizek-WMF) >>! In T116785#1789690, @Mattflaschen wrote: >> Board is deleted, Topics are still available (but it is normal). > > Please elaborate on... [10:46:58] 6Collaboration-Team-Backlog, 10Flow: Flow: Provide more relevant error message if internet connection is lost - https://phabricator.wikimedia.org/T118680#1807366 (10Aklapper) [11:04:59] 3Collaboration-Team-Current, 10Echo, 7Design, 5Patch-For-Review, 7WorkType-NewFunctionality: Allow marking Echo notifications as unread - https://phabricator.wikimedia.org/T73564#1807395 (10Pginer-WMF) [12:18:13] 6Collaboration-Team-Backlog, 10Echo, 7Design: Better control how notifications get marked as read when visiting a page - https://phabricator.wikimedia.org/T118722#1807481 (10Pginer-WMF) 3NEW [12:18:27] 6Collaboration-Team-Backlog, 10Echo, 7Design: Better control how notifications get marked as read when visiting a page - https://phabricator.wikimedia.org/T118722#1807500 (10Pginer-WMF) p:5Normal>3Triage [12:21:15] 3Collaboration-Team-Current, 10Echo, 7Design, 5Patch-For-Review, 7WorkType-NewFunctionality: Allow marking Echo notifications as unread - https://phabricator.wikimedia.org/T73564#1807510 (10Pginer-WMF) [14:15:07] (03CR) 10Sbisson: Notifications presentation models (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/252670 (https://phabricator.wikimedia.org/T116849) (owner: 10Matthias Mullie) [15:18:37] (03PS2) 10Matthias Mullie: Notifications presentation models [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/252670 (https://phabricator.wikimedia.org/T116849) [15:18:50] (03CR) 10Matthias Mullie: Notifications presentation models (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/252670 (https://phabricator.wikimedia.org/T116849) (owner: 10Matthias Mullie) [15:37:29] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Change-tagging, 7Easy: Notify user when a tag is added to/removed from their edit - https://phabricator.wikimedia.org/T112119#1807880 (10matej_suchanek) [15:38:37] 6Collaboration-Team-Backlog, 10Echo, 7Epic, 7WorkType-NewFunctionality, 7user-notice: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#1807889 (10matej_suchanek) [16:12:05] (03PS1) 10Matthias Mullie: Expose more data through API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) [16:12:09] 3Collaboration-Team-Current, 10Echo: API should expose enough structured data about notifications that frontend can render them - https://phabricator.wikimedia.org/T115418#1808073 (10matthiasmullie) a:3matthiasmullie [16:43:22] (03PS2) 10Matthias Mullie: Expose more data through API [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) [17:57:25] 3Collaboration-Team-Current, 10Flow: Problems encountered when enabling Flow on Chinese Wikipedia - https://phabricator.wikimedia.org/T118567#1808485 (10Trizek-WMF) p:5Triage>3High Flow is active as a beta Feature on zhwp. 261 users are trying this feature, and there is at least 12 accounts with issues. I... [18:08:43] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7), 7user-notice: Allow welcome notification to optionally have a link target - https://phabricator.wikimedia.org/T117509#1808542 (10Catrope) Once this is deployed, communities will be able to specify the link targ... [18:17:43] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7), 7user-notice: Allow welcome notification to optionally have a link target - https://phabricator.wikimedia.org/T117509#1808590 (10Etonkovidova) Checked in betalabs. [18:36:27] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Echo is passing wrong type for eventId - https://phabricator.wikimedia.org/T116205#1808651 (10Legoktm) 5Open>3Resolved Echo is no longer listed in https://logstash.wikimedia.org/#/dashboard/elasticsearch/eventlogging-errors [18:37:23] 3Collaboration-Team-Current, 10Echo: Implement new Echo notifications API - https://phabricator.wikimedia.org/T118503#1808656 (10Legoktm) [18:37:24] 3Collaboration-Team-Current, 10Echo: API should expose enough structured data about notifications that frontend can render them - https://phabricator.wikimedia.org/T115418#1808657 (10Legoktm) [18:44:00] (03PS1) 10Legoktm: Unstub $wgLang before passing it to DiscussionParser::getTextSnippet() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253362 (https://phabricator.wikimedia.org/T118542) [18:44:41] 3Collaboration-Team-Current, 10Flow: Problems encountered when enabling Flow on Chinese Wikipedia - https://phabricator.wikimedia.org/T118567#1808690 (10Catrope) a:3Catrope [18:48:49] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7Wikimedia-log-errors: Catchable fatal error: Argument 2 passed to EchoDiscussionParser::getTextSnippet() must be an instance of Language, StubUserLang given - https://phabricator.wikimedia.org/T118542#1808711 (10Legoktm) >>! In T118542#1803163, @Lego... [19:02:59] (03CR) 10Catrope: [C: 032] Unstub $wgLang before passing it to DiscussionParser::getTextSnippet() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253362 (https://phabricator.wikimedia.org/T118542) (owner: 10Legoktm) [19:05:23] (03CR) 10Catrope: Notifications presentation models (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/252670 (https://phabricator.wikimedia.org/T116849) (owner: 10Matthias Mullie) [19:07:44] (03CR) 10Catrope: [C: 031] "Looks good to me. I think the only information that's missing is the icon URL; unfortunately the code to get the icon URL from the icon ty" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie) [19:09:04] (03Merged) 10jenkins-bot: Unstub $wgLang before passing it to DiscussionParser::getTextSnippet() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253362 (https://phabricator.wikimedia.org/T118542) (owner: 10Legoktm) [19:09:44] (03CR) 10Legoktm: [C: 04-1] "We can't use JsonSerializable yet because we still have to support 5.3 :(" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie) [19:10:40] (03CR) 10Legoktm: "And getting the icon URL is EchoNotificationFormatter::getIconUrl( $iconType, $lang->getDir() );" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253341 (https://phabricator.wikimedia.org/T115418) (owner: 10Matthias Mullie) [19:12:18] (03CR) 10Catrope: [C: 04-1] Notifications presentation models (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/252670 (https://phabricator.wikimedia.org/T116849) (owner: 10Matthias Mullie) [19:13:47] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7), 7user-notice: Allow welcome notification to optionally have a link target - https://phabricator.wikimedia.org/T117509#1808780 (10Legoktm) 5Open>3Resolved https://lists.wikimedia.org/pipermail/wikitech-ambas... [19:15:10] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7Wikimedia-log-errors: Catchable fatal error: Argument 2 passed to EchoDiscussionParser::getTextSnippet() must be an instance of Language, StubUserLang given - https://phabricator.wikimedia.org/T118542#1808786 (10Legoktm) 5Open>3Resolved a:3Legok... [19:22:36] 3Collaboration-Team-Current, 10Flow: Flow not warning me when I leave an edit page with unsaved changes - https://phabricator.wikimedia.org/T96531#1808816 (10Quiddity) [19:44:25] OK I think that I've determined that opt-in-out-in is broken on zhwiki [19:44:31] But I'll use a different account to test that [19:55:41] (03PS17) 10Paladox: Update grunt-jscs to 2.3.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 [19:58:57] 6Collaboration-Team-Backlog, 10Flow, 10Security-Reviews, 6Security-Team: Security review for Flow new structured workflow feature - https://phabricator.wikimedia.org/T112793#1809012 (10dpatrick) Hey all, this phab ticket is on my work plan for this week. Is this feature/code ready for review? [19:58:57] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): Inconsistent state after AJAX board re-order - https://phabricator.wikimedia.org/T118108#1809016 (10Etonkovidova) There is an issue in betalabs with scrolling a board while the sorting is in progress. The only b... [19:58:57] 6Collaboration-Team-Backlog, 10Flow, 10Security-Reviews, 6Security-Team: Security review for Flow new structured workflow feature - https://phabricator.wikimedia.org/T112793#1809017 (10Catrope) 5Open>3Invalid a:3Catrope >>! In T112793#1809012, @dpatrick wrote: > Hey all, this phab ticket is on my wor... [19:59:50] matt_flaschen: I added comments to T118108 Inconsistent state after AJAX board re-order - when you have a min - pls take a look [20:00:12] etonkovidova, sure, will check now. [20:00:37] matt_flaschen: it could be something different - and having nothing to do with actual resorting stuff... [20:02:06] etonkovidova, yeah, it seems to be a different issue. I will see if I can reproduce, but it should be filed separately. [20:05:02] matt_flaschen: that what I thought ... I wonder how come I cannot see it on different boards - if only I figure out how to quickly get the # of topics on a board [20:10:53] 10Pywikibot-Flow, 7Tracking: Pywikibot and Flow (Phase 2: Moderation and Revision History) (tracking) - https://phabricator.wikimedia.org/T109228#1809029 (10happy5214) [20:10:55] 10Pywikibot-Flow, 5Patch-For-Review: Moderate Flow topics and posts - https://phabricator.wikimedia.org/T109308#1809028 (10happy5214) 5Open>3Resolved [20:25:45] etonkovidova, you can get it from the DB: [20:25:57] SELECT COUNT(*) FROM flow_workflow WHERE workflow_type = 'topic' AND workflow_page_id = ; [20:26:09] Replace with mw.config.get( 'wgArticleId' ) from the board page. [20:26:13] matt_flaschen: yeah... I am busy now with digging re-sorting [20:26:26] matt_flaschen: thx for the query! [20:26:29] There are other solutions in particular cases, but that's the only general solution (that counts topics currently out of view). [20:26:34] matt_flaschen: I meant ! [20:27:00] etonkovidova, anyway, can you file that separately? [20:27:28] matt_flaschen: will do [20:27:56] matt_flaschen: right now I see also an interesting issue with reverting "Thanked' to 'Thank' after resorting :(( [20:32:04] etonkovidova, known issue: https://phabricator.wikimedia.org/T101342 [20:32:29] matt_flaschen: and it's that old?! [21:05:23] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7), 7user-notice: Allow welcome notification to optionally have a link target - https://phabricator.wikimedia.org/T117509#1809117 (10Quiddity) [21:49:19] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 7Regression: Thanked-ness for Flow posts should be rendered server-side, not client-side - https://phabricator.wikimedia.org/T101342#1809176 (10Etonkovidova) Steps to reproduce the issue: 1. On any Flow board click to 'Thank' anyone. 2. 'Thank' changes to '... [21:56:35] 6Collaboration-Team-Backlog, 10Thanks, 7Mobile: "Thank"ing someone on mobile brings me to a dead end page - https://phabricator.wikimedia.org/T118779#1809181 (10greg) 3NEW [22:06:00] 6Collaboration-Team-Backlog, 10Flow: [betalabs] js errors when scrolling a page during re-sorting - https://phabricator.wikimedia.org/T118782#1809216 (10Etonkovidova) 3NEW [22:13:14] (03PS32) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [22:15:09] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [22:34:50] 6Collaboration-Team-Backlog, 10Echo, 7Design: Better control how notifications get marked as read when visiting a page - https://phabricator.wikimedia.org/T118722#1809265 (10MGChecker) I really like the first abd second idea, but I think the third idea would be too much. [22:52:35] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): Inconsistent state after AJAX board re-order - https://phabricator.wikimedia.org/T118108#1809314 (10Etonkovidova) There is also an old issue related to sorting {T101342}. [23:27:35] 3Collaboration-Team-Current, 10Flow: Problems encountered when enabling Flow on Chinese Wikipedia - https://phabricator.wikimedia.org/T118567#1809438 (10Catrope) I investigated the most recent case: https://zh.wikipedia.org/w/index.php?title=User_talk:Ww71338ww/%E5%AD%98%E6%A1%A3_1&action=history was archived... [23:34:16] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): Add accessor for current user to EchoEventPresentationModel - https://phabricator.wikimedia.org/T118058#1809463 (10Etonkovidova) Checked in betalabs with uselang ru, fr. [23:37:25] (03CR) 10Arlolra: "Removing my -2 now that T118462 was deployed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252749 (owner: 10Arlolra) [23:42:00] 3Collaboration-Team-Current, 10Echo: Support easy use of standard $1+$2 values (agent and agent for gender) in getBodyMessage - https://phabricator.wikimedia.org/T118059#1809483 (10Legoktm) a:5Legoktm>3SBisson [23:46:20] (03PS1) 10Legoktm: Remove old, now unused mention flyout messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253492 [23:46:31] 6Collaboration-Team-Backlog, 10Thanks, 7Mobile: "Thank"ing someone on mobile brings me to a dead end page - https://phabricator.wikimedia.org/T118779#1809498 (10greg) Maybe this is just Thanking someone for a Flow comment? On an edit history page on desktop it all happens in situ. But I just thanked a flow c... [23:46:50] 3Collaboration-Team-Current, 10Flow: Problems encountered when enabling Flow on Chinese Wikipedia - https://phabricator.wikimedia.org/T118567#1809500 (10Catrope) - Ww71338ww: bogus "user is blocked" error, probably related to DB connection errors (lost connection), see previous comment - Zhanghandsome: Same as... [23:47:08] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 7Mobile: "Thank"ing someone for a flow comment takes me to a dead end page - https://phabricator.wikimedia.org/T118779#1809501 (10greg) [23:47:36] (03PS33) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [23:47:54] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [23:48:30] (03PS1) 10Mattflaschen: Fix link to Flow posts [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/253493 [23:48:40] (03CR) 10jenkins-bot: [V: 04-1] Remove old, now unused mention flyout messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253492 (owner: 10Legoktm) [23:49:54] (03PS2) 10Legoktm: Remove old, now unused mention flyout messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253492 [23:51:35] (03CR) 10Catrope: [C: 032] "Sorry :S" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/253493 (owner: 10Mattflaschen) [23:51:41] 6Collaboration-Team-Backlog, 10Thanks, 10UI-Standardization, 7Easy: Convert Special:Thanks to use OOUI HTMLForm - https://phabricator.wikimedia.org/T118794#1809514 (10Legoktm) 3NEW [23:51:54] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 7Mobile: "Thank"ing someone for a flow comment on mobile takes me to a dead end page - https://phabricator.wikimedia.org/T118779#1809522 (10greg) [23:51:55] (03CR) 10Catrope: [C: 032] Remove old, now unused mention flyout messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253492 (owner: 10Legoktm) [23:52:38] 6Collaboration-Team-Backlog, 10Flow, 10Thanks, 7Mobile: "Thank"ing someone for a flow comment on mobile takes me to a dead end page - https://phabricator.wikimedia.org/T118779#1809181 (10greg) Ok, after trying to reproduce in front of Roan it worked on desktop (I probably had some weird JS loading error). [23:55:11] (03Merged) 10jenkins-bot: Fix link to Flow posts [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/253493 (owner: 10Mattflaschen) [23:56:11] (03Merged) 10jenkins-bot: Remove old, now unused mention flyout messages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/253492 (owner: 10Legoktm) [23:56:29] RoanKattouw: do you have a second? [23:56:37] Sure