[00:04:13] (03PS2) 10Legoktm: Set explicit output format for message in ThanksPresentationModel [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/252798 [00:04:16] (03PS1) 10Legoktm: Use new EventPresentationModel::getViewingUserForGender() helper [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/252876 [00:11:08] (03CR) 10Catrope: [C: 032] Fix JS error in topic page width toggle [extensions/Flow] (wmf/1.27.0-wmf.6) - 10https://gerrit.wikimedia.org/r/252763 (https://phabricator.wikimedia.org/T118481) (owner: 10Catrope) [00:20:55] (03Merged) 10jenkins-bot: Fix JS error in topic page width toggle [extensions/Flow] (wmf/1.27.0-wmf.6) - 10https://gerrit.wikimedia.org/r/252763 (https://phabricator.wikimedia.org/T118481) (owner: 10Catrope) [00:59:44] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): Add accessor for current user to EchoEventPresentationModel - https://phabricator.wikimedia.org/T118058#1802845 (10Legoktm) 5Open>3Resolved [02:26:47] 6Collaboration-Team-Backlog, 10Echo, 7Wikimedia-log-errors: Catchable fatal error: Argument 2 passed to EchoDiscussionParser::getTextSnippet() must be an instance of Language, StubUserLang given - https://phabricator.wikimedia.org/T118542#1802906 (10Legoktm) 3NEW [03:08:22] 3Collaboration-Team-Current, 10Echo, 10Flow, 6Editing-Analysis, 5Patch-For-Review: Measure the user responsiveness to notifications over time - https://phabricator.wikimedia.org/T108208#1802954 (10Milimetric) Yeah, one main problem is there's no index on timestamp there. It would help a lot, and a reque... [08:05:08] 6Collaboration-Team-Backlog, 10Echo: reverting a talk page shouldn't send Echo mentioning notification - https://phabricator.wikimedia.org/T118552#1803155 (10Amire80) 3NEW [08:07:22] 6Collaboration-Team-Backlog, 10Echo, 7Wikimedia-log-errors: Catchable fatal error: Argument 2 passed to EchoDiscussionParser::getTextSnippet() must be an instance of Language, StubUserLang given - https://phabricator.wikimedia.org/T118542#1803163 (10Legoktm) ``` km@km-tp ~/p/v/m/e/Echo> ack "Language \\\$" i... [13:24:51] (03CR) 10Matthias Mullie: Add support for edit summary formatting in topic titles (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) (owner: 10Mattflaschen) [13:51:05] (03PS14) 10Matthias Mullie: Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) [14:01:05] (03PS11) 10Matthias Mullie: Import Flow data dump [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) [14:08:51] (03PS12) 10Matthias Mullie: Import Flow data dump [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) [14:10:20] (03PS15) 10Matthias Mullie: Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) [14:13:08] (03CR) 10Matthias Mullie: [C: 032] Convert the post-summary query in ContributionsQuery to use JOINs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252769 (https://phabricator.wikimedia.org/T78671) (owner: 10Catrope) [14:19:44] (03Merged) 10jenkins-bot: Convert the post-summary query in ContributionsQuery to use JOINs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252769 (https://phabricator.wikimedia.org/T78671) (owner: 10Catrope) [14:21:21] 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 10VisualEditor, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1803556 (10Alsee) A submenu might be acceptable... [14:33:50] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests, 7Community-consensus-needed, 7user-notice: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1803593 (10Lydia_Pintscher) [14:33:51] 3Collaboration-Team-Current, 10Flow, 10Wikidata, 10Wikidata.org, and 2 others: Enable the Flow personal talk opt-in Beta Feature on Wikidata.org - https://phabricator.wikimedia.org/T116611#1803592 (10Lydia_Pintscher) 5Open>3Resolved [15:05:05] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-11-10_(1.27.0-wmf.6), 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): [production/betalabs] Regression: 'toggleClass' of undefined - 'Read at fixed width/Read at full width' on Topic page d... - https://phabricator.wikimedia.org/T118481#1803706 [15:26:21] 6Collaboration-Team-Backlog, 10Flow: Problems encountered when enabling Flow on Chinese Wikipedia - https://phabricator.wikimedia.org/T118567#1803753 (10Lakokat) 3NEW [16:49:59] 3Collaboration-Team-Current, 10Echo, 7Wikimedia-log-errors: Catchable fatal error: Argument 2 passed to EchoDiscussionParser::getTextSnippet() must be an instance of Language, StubUserLang given - https://phabricator.wikimedia.org/T118542#1803894 (10Mattflaschen) [16:58:14] RoanKattouw_away, is there a performance difference with the explicit INNER JOIN? Or is it just style (our docs say, "In the most common case, this is unnecessary, since the join condition can be in $conds. However, it is useful for doing a LEFT JOIN.")? [17:00:48] Never mind, i see you posted on the bug that it's the same. [17:09:39] 3Collaboration-Team-Current, 10Flow: Problems encountered when enabling Flow on Chinese Wikipedia - https://phabricator.wikimedia.org/T118567#1803946 (10Mattflaschen) [17:25:37] mlitn, it looks like the mapping code in Exporter can be simplified. I'm about to test. [17:36:57] Actually, never mind. [17:41:47] (03PS13) 10Mattflaschen: Import Flow data dump [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie) [17:42:06] :p [17:52:54] mlitn, re workflow_last_update_timestamp, originally you just used the topic ID. I was saying to instead store the update timestamp from the exporter. [17:52:57] If it's not stored in the DB (it should be, though), doesn't that mean we're going to have a problem when we stop using the index? [17:56:25] updateLastUpdated should work, though. [18:09:23] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1804185 (10Pginer-WMF) I think we are in the same page with respect to the issues of relative timestamps for old posts. The "3 months ago" illustrate... [18:19:08] matt_flaschen: Yeah an explicit INNER JOIN vs a straight join doesn't matter AFAIK. But Jaime complained about it, and he knows more about DBs than I do [18:21:20] Yeah, and much more than me. [18:37:07] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7), 7user-notice: Allow welcome notification to optionally have a link target - https://phabricator.wikimedia.org/T117509#1804329 (10Legoktm) [18:45:41] (03CR) 10Catrope: [C: 032] "This is slightly embarassing, since 1) I wrote this code and 2) I -1ed Stephane's code for the exact same thing" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/252798 (owner: 10Legoktm) [18:46:00] (03CR) 10Catrope: [C: 032] Use new EventPresentationModel::getViewingUserForGender() helper [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/252876 (owner: 10Legoktm) [18:51:10] (03Merged) 10jenkins-bot: Set explicit output format for message in ThanksPresentationModel [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/252798 (owner: 10Legoktm) [18:51:15] (03Merged) 10jenkins-bot: Use new EventPresentationModel::getViewingUserForGender() helper [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/252876 (owner: 10Legoktm) [19:27:38] 3Collaboration-Team-Current, 10Flow, 7Regression, 7WorkType-NewFunctionality: Clicking 'edit' should always refetch from the server - https://phabricator.wikimedia.org/T109660#1804426 (10Catrope) 5Open>3Resolved a:3Catrope [19:35:14] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): Requests to the API should return CAPTCHA in the UI language - https://phabricator.wikimedia.org/T117112#1804453 (10Catrope) 5Open>3Resolved [19:36:49] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Unable to solve captcha on RTL languages due to bad element position - https://phabricator.wikimedia.org/T116910#1804465 (10Catrope) 5Open>3Resolved [20:04:23] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Run maintenance/FlowPopulateRefId.php on all production wikis - https://phabricator.wikimedia.org/T117786#1804575 (10Catrope) @mattflaschen: Is this still blocked, or can it be done now? [20:05:51] 3Collaboration-Team-Current, 10Echo, 7Tracking: Write presentation models for all notification types (tracking) - https://phabricator.wikimedia.org/T116834#1804579 (10Catrope) [20:05:52] 3Collaboration-Team-Current, 10Echo, 10Thanks, 5Patch-For-Review: Write presentation models for notifications in Thanks - https://phabricator.wikimedia.org/T116847#1804578 (10Catrope) 5Open>3Resolved [20:19:54] 6Collaboration-Team-Backlog, 10Flow, 7Database, 7Performance: Reduce Flow DB queries on Special:Contributions - https://phabricator.wikimedia.org/T118434#1804588 (10Catrope) From my numbers it looks like we could fix almost half of this by caching the existence of page IDs (for the `Title::newFromId( $id... [20:21:15] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability, 5Patch-For-Review: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1804590 (10Catrope) I'd like to mitigate at least some of {T118434} before we do this. Right now, that bug's impact is... [20:23:05] 3Collaboration-Team-Current, 10Echo: Support easy use of standard $1+$2 values (agent and agent for gender) in getBodyMessage - https://phabricator.wikimedia.org/T118059#1804603 (10Catrope) >>! In T118059#1796492, @SBisson wrote: > Has anything been started here? If not, I can do it since I have a ticket block... [20:25:09] 3Collaboration-Team-Current, 10Echo: Support easy use of standard $1+$2 values (agent and agent for gender) in getBodyMessage - https://phabricator.wikimedia.org/T118059#1804605 (10Legoktm) No, I haven't done any work on this yet. [20:36:17] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1804619 (10Catrope) >>! In T111596#1804185, @Pginer-WMF wrote: > I think we are in the same page with respect to the issues of relative timestamps fo... [20:40:29] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-11-10_(1.27.0-wmf.6), 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): [production/betalabs] Regression: 'toggleClass' of undefined - 'Read at fixed width/Read at full width' on Topic page d... - https://phabricator.wikimedia.org/T118481#1804625 [20:40:54] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-11-10_(1.27.0-wmf.6), 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): [production/betalabs] Regression: 'toggleClass' of undefined - 'Read at fixed width/Read at full width' on Topic page d... - https://phabricator.wikimedia.org/T118481#1801428 [20:44:30] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-11-10_(1.27.0-wmf.6), 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): [production/betalabs] Regression: 'toggleClass' of undefined - 'Read at fixed width/Read at full width' on Topic page d... - https://phabricator.wikimedia.org/T118481#1804628 [20:51:59] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Run maintenance/FlowPopulateRefId.php on all production wikis - https://phabricator.wikimedia.org/T117786#1804646 (10Mattflaschen) {T117785} is done (it's in product review), so this isn't blocked. It might be... [20:53:08] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Run maintenance/FlowPopulateRefId.php on all production wikis - https://phabricator.wikimedia.org/T117786#1804648 (10Mattflaschen) Never mind, that actually has rolled out. [21:02:51] 6Collaboration-Team-Backlog, 10Flow, 7Database, 7Performance: Reduce Flow DB queries on Special:Contributions - https://phabricator.wikimedia.org/T118434#1804661 (10Mattflaschen) Agree with Matthias we should save bigger changes for when we go to implement the major permission changes. The caching idea ma... [22:32:13] 3Collaboration-Team-Current, 10Echo: Support easy use of standard $1+$2 values (agent and agent for gender) in getBodyMessage - https://phabricator.wikimedia.org/T118059#1804799 (10Legoktm) [22:32:14] 3Collaboration-Team-Current, 10Echo, 10Flow, 5Patch-For-Review: Write presentation models for notifications in Flow - https://phabricator.wikimedia.org/T116845#1804798 (10Legoktm) [23:18:21] Heading out, see you all later.