[00:02:34] (03PS22) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [00:10:14] WTF [00:10:21] matt_flaschen: Can you confirm I'm not crazy for a second? [00:10:26] I'm looking at ContributionsQuery.php [00:10:53] buildConditions() takes a $direction parameter which influences whether we use rev_id < 123 or rev_id > 123 for continuations [00:11:22] but nothing else uses $descending, and ORDER BY is always set to 'rev_id DESC' [00:13:42] RoanKattouw, looking [00:13:56] That can't possibly be correct, can it? [00:14:21] RoanKattouw, it doesn't seem obviously wrong. The page displays in descending order but it could page in either order. [00:14:27] Let me take a look at the web interface. [00:15:36] The query would also have to change its order for the paging order to change, wouldn't it? [00:16:15] RoanKattouw, there was a similar thing with RC, and I think I had to reverse it in PHP, and it turned out core does the same. One sec. [00:17:01] RoanKattouw, oh yeah, because if you say > then ORDER BY DESC, it gives you the very latest ones. [00:17:07] So you need to order by ASC, then reverse in PHP. [00:17:33] Actually, this was for history. [00:17:36] Suppose rev_id was an auto_increment field (the recent bugs make me wish we used those instead of UUIDs), then SELECT stuff FROM flow_revision ORDER BY rev_id DESC LIMIT 51; would give you ids 1000 through 950; then WHERE rev_id < 951 would give you 950 through 900, etc. But if you use > conditions then you can't do anything useful with DESC [00:17:45] Oh, right [00:17:49] yes, in history you need to reverse in PHP [00:18:03] Perhaps here too, but the query order needs to be ASC [00:18:10] Let me see if I can demonstrate that this is broken [00:18:29] I unfortunately need to restructure ContributionsQuery.php a bit just to add a FORCE INEDX [00:18:31] RoanKattouw, yeah, I agree with you (if I understand correctly) > and DESC is probably not useful for contribs either. [00:19:24] I even put a comment about this... https://gerrit.wikimedia.org/r/#/c/245621/11/includes/Formatter/BoardHistoryQuery.php [00:20:30] Right [00:20:39] But that's for history, and we do vary ASC vs DESC there, right? [00:21:11] I'm convinced we'll need to do the same for contribs, but I'm going to try to prove it first [00:22:10] RoanKattouw, yes, it's specifically coded as the opposite: https://gerrit.wikimedia.org/r/#/c/245621/11/includes/Data/ObjectLocator.php [00:22:41] ASC >, DESC <, plus reverse in PHP for 'rev'/ASC. [00:22:49] I see [00:22:51] OK yes that looks fine [00:23:13] The code is is a little more stilited than I would like due to the Memcached index. [00:25:03] Oh, wow, we are super wasteful for contributions views [00:25:23] I'll post a sanitized query log in a minute, but it looks like we issue several queries per line [00:25:40] Some duplicates as well [00:35:31] I setup ZNC as a bouncer today, and put up some instructions on officewiki. [00:39:05] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to save or preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1800148 (10Mattflaschen) [00:41:03] OK, so Special:Contributions/Catrope on my localhost issues 858 queries [00:41:16] To be fair some of that is objectcache [00:44:01] 472 of them contain the word 'flow' [00:44:04] * RoanKattouw starts crusade [00:46:01] OOOOOOOH [00:46:03] WOW [00:46:14] That isn't going to be a good WOW is it? [00:46:24] $conditions + array( 'workflow_id = tree_ancestor_id', 'tree_descendant_id = rev_type_id', 'rev_type' => 'post-summary' ), [00:46:28] Guess why that causes problems [00:46:31] matt_flaschen, It sounded like an excited one [00:46:41] I have no idea what it's about, but he exclaimed it very loudly [00:47:16] RoanKattouw, give me a sec to think. [00:47:29] RoanKattouw, because it's quadratic and not properly indexed? [00:47:42] I was *wondering* why Dan was quoting a query that was missing a condition, and then I reproduced it locally [00:47:43] Because every post/ancestor pair is stored, not just the root ancestor. [00:48:03] It doesn't actually specify rev_type_id?! [00:48:04] Maybe; I don't actually know enough about the DB schema to know if that's a problem [00:48:26] No, that's all fine, because it's a reverse query [00:48:36] No, $conditions could contain 0 => 'rev_id > blah' [00:48:41] if it's a continuation [00:48:55] And due to the magic of array plus in PHP, that will make the workflow_id=tree_ancestor_id condition drop out [00:49:42] You want array_merge( [00:49:44] Ugh. [00:49:50] That's why the query that Dan pulled from the slow query log on beta was missing that condition [00:49:58] Easy fix. [00:50:04] (A similar bug was dropping my FORCE INDEX) [00:50:08] I actually hit that issue too while working on that history patch. [00:50:30] or... wait, no, that can't be true, because those are all named [00:50:58] RoanKattouw, no they're not. [00:51:01] The first two are numeric. [00:51:02] The options are [00:51:05] I just forgot to add my variable there [00:51:16] The conds aren't all named though and there we do have a bg [00:51:17] Oh, you mean FORCE INDEX. [00:51:37] Yeah [00:51:49] (Well, it's called USE INDEX in our database API, but yeah) [00:53:24] Oh FFSF [00:53:26] *FFS [00:53:40] The newbies query computes MAX(user_id) and the set of users to exclude three times [00:54:18] I'm starting to be surprised that an optimizer bug in MySQL is what took down beta, because the querying behavior of the contributions code is pretty bad [00:55:44] RoanKattouw, so the summary bug causes it to query for all revisions, not just ones in the current wiki (due to the missing workflow join)? [00:56:11] hah, probably! [00:56:23] What are the three times for MAX? [00:56:24] Actually, no [00:56:28] There's also a cond on rev_user_wiki [00:56:31] (03PS23) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [00:56:34] But the namespace filter would break [00:57:12] matt_flaschen: So you know how, when preparing the newbie query, we do SELECT MAX(user_id) FROM user; and then use the result of that (plus the results of another more complicated query to do with groups) in our query? [00:57:21] Also, the MAX is supposed to be cached, don't know if that works. [00:57:28] Those preparatory queries are done 3 times, and in each case they're the exact same queries with the exact same results [00:57:36] Yeah MAX(user_id) is super fast [00:58:00] The groups query is probably still fairly fast [00:58:13] But I'm disappointed that the code isn't even trying to reduce the query volume [00:58:43] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [00:58:46] Then again, we issue >500 queries on a contribs page with 50 lines, so what's another 6 :| [00:59:45] RoanKattouw, I meant do you know why it's querying it three times. [01:00:00] I only see buildCond and getNewbie... called once from getResult. [01:00:17] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure: Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#1800165 (10Catrope) I analyzed all possible query types for ContributionsQuery over... [01:01:03] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure: Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#1800169 (10Catrope) >>! In T78671#1770170, @dduvall wrote: > Another instance of thi... [01:01:23] getnewbie is called from buildConditions [01:01:24] (03PS24) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [01:01:30] Oh and that's outside of the loop [01:01:32] wtf [01:01:46] No, you're right [01:01:49] * RoanKattouw checks his results [01:02:05] OK, sorry, no, I was wrong [01:02:12] *core* also queries MAX(user_id) [01:02:15] I spoke too soon [01:02:24] RoanKattouw, and *doesn't* cache it per our previous discussion. [01:02:28] core doesn't, that is. [01:02:35] Right [01:02:35] (03PS1) 10Mooeypoo: [DO NOT MERGE] Experimentally adding expandable items to notification widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252611 [01:03:02] (03CR) 10jenkins-bot: [V: 04-1] [DO NOT MERGE] Experimentally adding expandable items to notification widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252611 (owner: 10Mooeypoo) [01:03:28] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [01:05:04] OK, this bug was way easy to reproduce [01:05:12] http://localhost/w/index.php?limit=50&tagfilter=&title=Special%3AContributions&contribs=user&target=Catrope&namespace=3 only returns User talk results, as expected [01:05:34] However, if you use the namespace selector in the form, the URL it actually sends you to is http://localhost/w/index.php?limit=50&tagfilter=&title=Special%3AContributions&contribs=user&target=Catrope&namespace=3&tagfilter=&year=2015&month=-1 [01:05:44] which ends up triggering the offset case, and so I get results from the wrong namespace mixed in [01:09:59] (03PS1) 10Catrope: Don't use array plus to merge SQL condition arrays [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252612 [01:10:16] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure: Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#1800176 (10Catrope) >>! In T78671#1800169, @Catrope wrote: >>>! In T78671#1770170, @... [01:10:34] Good catch [01:13:28] (03PS25) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [01:14:02] (03PS2) 10Catrope: Don't use array plus to merge SQL condition arrays [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252612 (https://phabricator.wikimedia.org/T78671) [01:14:05] (03PS1) 10Catrope: Add FORCE INDEX to contributions queries to work around optimizer bug [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252614 (https://phabricator.wikimedia.org/T78671) [01:15:32] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [01:27:35] matt_flaschen: What's the status of the ptwikibooks UUID collision stuff? [01:27:35] (03CR) 10Mattflaschen: Dump Flow data (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [01:28:05] I'm writing a report about this month (Oct 15 - Nov 15) and I'm writing something about the ptwikibooks conversion [01:28:12] And I realized I don't 100% know how "finished" it is [01:28:37] My understanding is the UUID failures need to be sorted out before we can proceed to locking down LQT, running the content model population script and enabling namespace occupation [01:28:44] Yeah [01:29:03] RoanKattouw, what's your priority on that compared to code-reviewing Matthias's stuff and getting history pagination and topic title merged? [01:29:20] In the immediate term, the latter is more important [01:29:34] But I'd also like ptwikibooks to not linger too long [01:29:52] Yeah, we're on the same page. I'm not going to start anything new before that's done. [01:30:06] Sorry, that wasn't intended as a passive way of encouraging you to work on it, I just need to know what the status is for this report [01:30:24] I'm 1/5 of the way through a review of the topic title stuff [01:31:07] RoanKattouw, status is that I started working on https://phabricator.wikimedia.org/T117936 but it's not done. Basically, I'm going to log the row it was unable to import (with hex UUIDs), and maybe query to see what the one already there (that it's colliding with) is. [01:31:21] Oh, I forgot to move that. [01:32:06] OK, sounds good [01:32:42] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Add debug code to make details of UID collisions more obvious - https://phabricator.wikimedia.org/T117936#1787401 (10Mattflaschen) [01:32:47] So from that I infer "we don't know what's happening yet, but we suspect something is double-inserting things, so backtraces + dumps of the inserted data might give us clues" [01:33:55] RoanKattouw, yeah, I think it's possible, since my tests (https://phabricator.wikimedia.org/T117907#1787195) did not generate duplicate IDs. [02:13:08] (03CR) 10Mattflaschen: "Looks good. Will retest when the attribute mapping is in." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [02:14:35] Heading home, see you tomorrow. [02:14:57] Going to ping myself to test the bouncer works. [02:15:52] 3Collaboration-Team-Current, 10Echo, 10Flow, 6Editing-Analysis, 5Patch-For-Review: Measure the user responsiveness to notifications over time - https://phabricator.wikimedia.org/T108208#1800210 (10Etonkovidova) Checked https://gerrit.wikimedia.org/r/#/c/249394/5/ee/monthly_production_and_consumption_of_n... [02:17:42] Test ping matt_flaschen [02:39:31] Ughhhh [02:39:56] * RoanKattouw glares at RevisionStorage::findMultiInternal [02:40:27] if ( condition ) { inefficient_query(); } else { wfDebugLog( 'Unoptimizable query' ); inefficient_query(); } [04:44:40] 6Collaboration-Team-Backlog, 10Flow, 7Database, 7Performance: Reduce Flow DB queries on Special:Contributions - https://phabricator.wikimedia.org/T118434#1800286 (10Catrope) 3NEW [08:12:59] (03CR) 10Matthias Mullie: [C: 032] Don't use array plus to merge SQL condition arrays [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252612 (https://phabricator.wikimedia.org/T78671) (owner: 10Catrope) [08:16:22] (03Merged) 10jenkins-bot: Don't use array plus to merge SQL condition arrays [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252612 (https://phabricator.wikimedia.org/T78671) (owner: 10Catrope) [08:46:13] (03CR) 10Matthias Mullie: [C: 031] "Should we let a DBA verify this?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252614 (https://phabricator.wikimedia.org/T78671) (owner: 10Catrope) [09:24:50] (03Abandoned) 10Bartosz Dziewoński: Recognize ?action=edit§ion=new URLs and redirect to the new topic form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250959 (https://phabricator.wikimedia.org/T107637) (owner: 10Bartosz Dziewoński) [09:33:26] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure, and 2 others: Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#1800517 (10jcrespo) > This behavior is strange No it is not, you cann... [09:38:48] (03CR) 10Jcrespo: [C: 04-1] Add FORCE INDEX to contributions queries to work around optimizer bug [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252614 (https://phabricator.wikimedia.org/T78671) (owner: 10Catrope) [09:39:54] (03CR) 10Jcrespo: "Let's not rush with the FORCE. I think the main issue here was the full table scan of the other table. Let's try extending the index first" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252614 (https://phabricator.wikimedia.org/T78671) (owner: 10Catrope) [09:48:56] 6Collaboration-Team-Backlog, 10Flow, 7Database, 7Performance: Reduce Flow DB queries on Special:Contributions - https://phabricator.wikimedia.org/T118434#1800523 (10matthiasmullie) I think most of those queries are caused by Flow permission checks. RevisionActionPermissions::isAllowed used to only check t... [10:07:23] 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#1800539 (10Luke081515) [11:40:54] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-Newsletter: Write presentation model for Newsletter - https://phabricator.wikimedia.org/T116856#1800727 (10Tinaj1234) [11:59:26] (03PS1) 10Matthias Mullie: Notifications presentation models [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/252670 (https://phabricator.wikimedia.org/T116849) [12:12:11] 6Collaboration-Team-Backlog, 10Echo: Echo continues to not work when someone mentions another user - https://phabricator.wikimedia.org/T118458#1800779 (10He7d3r) 3NEW [14:31:18] 6Collaboration-Team-Backlog, 10Echo: Echo continues to not work when someone mentions another user - https://phabricator.wikimedia.org/T118458#1800920 (10Luke081515) p:5Triage>3High [15:14:17] 6Collaboration-Team-Backlog, 10Flow: 'Edit title' in a different browser tab results in Error - https://phabricator.wikimedia.org/T118425#1800956 (10SBisson) [16:26:18] matt_flaschen: any chance you could review https://gerrit.wikimedia.org/r/#/c/251165/ for me? ("mediawiki.jqueryMsg: Extend mw.Message with new #parseDom method") it's blocking some uploadwizard work from being merged. (not very high priority) [16:30:35] 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 10VisualEditor, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1801178 (10Jdforrester-WMF) p:5Triage>3Normal [16:55:47] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-PageCuration, 5Patch-For-Review: Write presentation models for notifications in PageTriage - https://phabricator.wikimedia.org/T116849#1801216 (10matthiasmullie) a:3matthiasmullie [17:08:46] (03PS1) 10Sbisson: Browser Tests: fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252711 [17:09:43] (03PS2) 10Sbisson: Browser Tests: fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252711 [17:12:46] (03CR) 10jenkins-bot: [V: 04-1] Browser Tests: fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252711 (owner: 10Sbisson) [17:55:01] (03CR) 10Legoktm: [WIP] Track what wikis a user has unread notifications on (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 (owner: 10Legoktm) [17:56:47] (03PS6) 10Legoktm: [WIP] Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 [18:00:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 (owner: 10Legoktm) [18:01:29] (03PS7) 10Legoktm: [WIP] Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 [18:24:26] (03PS8) 10Legoktm: Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 [18:26:09] 3Collaboration-Team-Current, 10Flow: [production/betalabs] Regression: 'toggleClass' of undefined - 'Read at fixed width/Read at full width' on Topic page does not work - https://phabricator.wikimedia.org/T118481#1801428 (10Etonkovidova) 3NEW [18:32:40] am I really the first person in standup today? o.O [18:33:24] legoktm: SFers went up some minutes ago. [18:33:31] legoktm: Might be fighting people currently in the meeting? [18:33:45] they're in now [18:33:53] also, https://ro.wikipedia.org/wiki/Utilizator:Anneto/Pagini.css wtf??? [18:34:16] I imagine that doesn't work. :-) [18:34:35] https://ta.wikipedia.org/wiki/%E0%AE%AA%E0%AE%AF%E0%AE%A9%E0%AE%B0%E0%AF%8D:L.Shriheeran/%E0%AE%95%E0%AE%B0%E0%AF%81%E0%AE%B5%E0%AE%BF%E0%AE%95%E0%AE%B3%E0%AF%8D.js ... [18:35:27] * legoktm pretends he didn't see those in mwgrep and continues [18:38:13] (03PS1) 10Legoktm: Don't export unused wgEchoOverlayConfiguration/wgEchoHelpPage JS variables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252741 [18:41:08] (03CR) 10jenkins-bot: [V: 04-1] Don't export unused wgEchoOverlayConfiguration/wgEchoHelpPage JS variables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252741 (owner: 10Legoktm) [18:43:04] (03PS2) 10Legoktm: Don't export unused wgEchoOverlayConfiguration/wgEchoHelpPage JS variables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252741 [18:53:20] (03PS1) 10Catrope: Fix JS error in topic page width toggle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252745 (https://phabricator.wikimedia.org/T118481) [18:56:12] mooeypoo: ---^^ [18:56:47] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: [production/betalabs] Regression: 'toggleClass' of undefined - 'Read at fixed width/Read at full width' on Topic page does not work - https://phabricator.wikimedia.org/T118481#1801575 (10Quiddity) [18:56:49] 3Collaboration-Team-Current, 10Flow, 7Regression: Broken width-expanding toggle on Topic pages - https://phabricator.wikimedia.org/T117823#1801573 (10Quiddity) [18:59:38] (03CR) 10Mooeypoo: [C: 032] Fix JS error in topic page width toggle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252745 (https://phabricator.wikimedia.org/T118481) (owner: 10Catrope) [19:03:35] (03Merged) 10jenkins-bot: Fix JS error in topic page width toggle [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252745 (https://phabricator.wikimedia.org/T118481) (owner: 10Catrope) [19:04:28] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-General-or-Unknown, 7JavaScript, 5Patch-For-Review: Support single API for pre-filling new topics for both old-style talk pages and Flow - https://phabricator.wikimedia.org/T107637#1801581 (10Mattflaschen) [19:04:42] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-General-or-Unknown, 7JavaScript, 5Patch-For-Review: Support single API for pre-filling new topics for both old-style talk pages and Flow - https://phabricator.wikimedia.org/T107637#1500033 (10Mattflaschen) Moved to current because there's a WIP. [19:07:42] 6Collaboration-Team-Backlog, 10Flow: Allow revision deletion for Flow edits - https://phabricator.wikimedia.org/T116301#1801587 (10Mattflaschen) [19:07:54] 6Collaboration-Team-Backlog, 10Flow: Allow revision deletion for Flow edits - https://phabricator.wikimedia.org/T116301#1745994 (10Mattflaschen) [19:10:01] 6Collaboration-Team-Backlog, 10Echo: Echo did not trigger mention notification when user was linked - https://phabricator.wikimedia.org/T118458#1801596 (10Mattflaschen) [19:11:45] 6Collaboration-Team-Backlog, 10Flow: Error when trying to edit topic title in new tab / noJS mode - https://phabricator.wikimedia.org/T100851#1801600 (10Mattflaschen) p:5Normal>3High [19:11:56] (03PS1) 10Arlolra: Revert "Revert "Adapt to Parsoid/RESTbase renaming scrubWikitext to scrub_wikitext"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252749 [19:12:48] MatmaRex, I added it to my list. May not be soon, though. [19:12:50] (03CR) 10Arlolra: [C: 04-2] "Do not submit until T118462 is resolved." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252749 (owner: 10Arlolra) [19:13:55] James_F, legoktm, it will probably work fine. CSS just discards invalid rules and keeps going. [19:14:00] So the HTML tags are just invalid CSS rules. [19:14:05] I know but... [19:14:09] they also pasted their edit tokens [19:14:28] (which have long been expired) [19:14:42] The JS... not so much. ;) [19:16:34] 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#1801612 (10Catrope) I agree it should be a proper JOI... [19:17:02] (03CR) 10Mattflaschen: [C: 032] Don't export unused wgEchoOverlayConfiguration/wgEchoHelpPage JS variables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252741 (owner: 10Legoktm) [19:18:06] 6Collaboration-Team-Backlog, 10Echo, 7Technical-Debt: Get rid of wgEchoConfig hack for qunit tests - https://phabricator.wikimedia.org/T118488#1801613 (10Legoktm) 3NEW [19:18:43] legoktm, I said it should work, not that it was a good decision. ;) [19:18:47] xP [19:19:46] (03CR) 10jenkins-bot: [V: 04-1] Don't export unused wgEchoOverlayConfiguration/wgEchoHelpPage JS variables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252741 (owner: 10Legoktm) [19:20:29] (03CR) 10Legoktm: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252741 (owner: 10Legoktm) [19:22:03] (03PS1) 10Legoktm: Remove unused NotifUser::getFormattedNotificationCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252754 [19:22:39] (03CR) 10Legoktm: [C: 032] "Try again..." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252741 (owner: 10Legoktm) [19:24:43] (03CR) 10Subramanya Sastry: [C: 031] Revert "Revert "Adapt to Parsoid/RESTbase renaming scrubWikitext to scrub_wikitext"" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252749 (owner: 10Arlolra) [19:26:55] (03Merged) 10jenkins-bot: Don't export unused wgEchoOverlayConfiguration/wgEchoHelpPage JS variables [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252741 (owner: 10Legoktm) [19:27:42] (03PS1) 10Legoktm: Remove unncessary code from NotifUserTest [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252756 [19:29:28] (03PS26) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [19:34:30] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [19:38:18] (03PS1) 10Catrope: Fix JS error in topic page width toggle [extensions/Flow] (wmf/1.27.0-wmf.6) - 10https://gerrit.wikimedia.org/r/252763 (https://phabricator.wikimedia.org/T118481) [19:38:55] (03PS1) 10Mooeypoo: Change the naming of 'notifiction option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 [19:57:17] mooeypoo: can you pastebin the draft new style API response you had somewhere? [19:57:49] * RoanKattouw recommends a Phabricator pastie [19:57:57] legoktm, yeah II have it in the gerrit patch for the demo [19:57:58] Cause then we can reference it from a task later [19:58:05] Oh right, it's there too [19:58:17] https://gerrit.wikimedia.org/r/#/c/247017/26/modules/demo/data/message_new.json [19:59:00] thanks [19:59:48] lol, if I go the next page of my contributions I get 1532 queries [19:59:54] *1534 [20:00:33] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1801734 (10Quiddity) @Pginer-WMF Re: Copying - This is only a minor use-case. (Fwiw, Timestamps are copied (in whole, or in part) for all sorts of r... [20:04:22] (03PS1) 10Catrope: Convert the post-summary query in ContributionsQuery to use JOINs [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252769 (https://phabricator.wikimedia.org/T78671) [20:28:33] 6Collaboration-Team-Backlog, 10Flow: Relative timestamp different between nojs and js mode ("1 day ago", "a day ago") - https://phabricator.wikimedia.org/T111596#1801850 (10Catrope) >>! In T111596#1801734, @Quiddity wrote: > The **first main reason** for changing this, is being able to distinguish between clos... [20:34:29] (03PS2) 10Catrope: Add FORCE INDEX to contributions queries to work around optimizer bug [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252614 (https://phabricator.wikimedia.org/T78671) [21:15:33] Going to take a break about 2:30 Pacific. I'm going to meet my father at the train station then head home and work from there. [21:35:11] 6Collaboration-Team-Backlog, 10Flow: Special:Log/ hist link for Protected Flow board produces 'Unable to find specified offset in query results" - https://phabricator.wikimedia.org/T118502#1802094 (10Etonkovidova) 3NEW [21:43:11] 3Collaboration-Team-Current, 10Echo: Implement new Echo notifications API - https://phabricator.wikimedia.org/T118503#1802103 (10Legoktm) 3NEW [21:47:16] RoanKattouw_away: do you remember which conversion https://phabricator.wikimedia.org/T118058 is blocking? [21:49:23] 6Collaboration-Team-Backlog, 10Flow: Reopen topic - Console error: Could not find .flow-board - https://phabricator.wikimedia.org/T118506#1802128 (10Etonkovidova) 3NEW [21:50:46] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-11-17_(1.27.0-wmf.7): Broken Special:Log output due to missing message logentry-lock-flow-lock-topic - https://phabricator.wikimedia.org/T118002#1802138 (10Etonkovidova) Checked in betalabs - Resolve/re-open topics on - Special:Log... [21:53:34] 6Collaboration-Team-Backlog, 10Flow: Special:Log/ hist link for Protected Flow board produces 'Unable to find specified offset in query results" - https://phabricator.wikimedia.org/T118502#1802152 (10Etonkovidova) The similar error is in {T115696} ``` /extensions/Flow/includes/Data/Index/FeatureIndex.php: U... [21:57:01] (03PS1) 10Legoktm: Set explicit output format for message in ThanksPresentationModel [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/252798 [22:02:15] (03CR) 10jenkins-bot: [V: 04-1] Set explicit output format for message in ThanksPresentationModel [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/252798 (owner: 10Legoktm) [22:04:21] (03CR) 10Legoktm: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/252798 (owner: 10Legoktm) [22:07:09] (03PS3) 10Mooeypoo: [wip] Add a NetworkHandler as a central API authority to Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252597 [22:07:50] (03PS2) 10Mooeypoo: Change the naming of 'notifiction option' to 'notification item' widgets [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252764 [22:08:50] (03PS27) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [22:10:59] (03PS1) 10Legoktm: Fix some phpdoc, add missing @throws [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252850 [22:11:44] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [22:18:06] (03PS1) 10MarkAHershberger: Add extension.json from conversion script. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252852 [22:20:21] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json from conversion script. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252852 (owner: 10MarkAHershberger) [22:26:39] (03PS2) 10MarkAHershberger: Add extension.json from conversion script. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252852 [22:28:14] (03CR) 10jenkins-bot: [V: 04-1] Add extension.json from conversion script. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/252852 (owner: 10MarkAHershberger) [22:30:59] (03PS1) 10Legoktm: Allow welcome notifications to have a primary link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252853 (https://phabricator.wikimedia.org/T117509) [22:32:12] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Allow welcome notification to optionally have a link target - https://phabricator.wikimedia.org/T117509#1802311 (10Legoktm) [22:33:13] legoktm: It doesn't /block/ any given conversion necessarily, it's just that genderization for French can't be done without it [22:33:17] But that was already broken [22:33:31] I think it was two of the Flow ones in Stephane's patch [22:34:10] Specific examples appear to be mention (in both Echo and Flow) [22:34:31] (03PS1) 10Legoktm: EventPresentationModel: Add accessor for current user's username [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252855 (https://phabricator.wikimedia.org/T118058) [22:34:38] and Thanks, but in that case we can derive the notified user from the event already [22:34:38] ok [22:35:23] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Allow welcome notification to optionally have a link target - https://phabricator.wikimedia.org/T117509#1802319 (10Legoktm) a:3Legoktm [22:35:31] Heading home. See you later. [22:35:40] Whoa 6 of the 7 most recently touched Echo patches are yours [22:36:01] legoktm: I'll go and take a pass at reviewing those; in the meantime, could you look at the email Karen sent you (CC me) about all-staff travel? [22:36:12] * legoktm opens email [22:36:29] (It's just confusion about a minor thing, nothing big) [22:37:00] some of the patches are pretty trivial [22:37:17] Yeah I saw one that was clearly just doc comments judging from the commit message [22:40:07] RoanKattouw: she responded saying "Kunal - I'll put you down for check-out on the 9th." do I still need to do anything? [22:40:17] Oh, sorry [22:40:27] She did indeed [22:40:47] No, you don't, unless you are already planning to leave on the 8th [22:41:24] in which case you should tell her that; but otherwise you should be set [22:41:44] And given that you originally requested the 9th, I'm guessing that's not the case [22:42:09] I was planning for 9th, but I can do 8th if necessary [22:42:50] As far as I'm concerned it's not necessary [22:44:25] Also I should send an email to see who's interested in doing a team trip to the Computer History Museum [22:44:31] If we do that, I suppose it would probably be on the 9th [22:50:54] Amazing [22:51:19] mooeypoo just discovered we have mw.echo.dm.NotificationItem = function MwFlowDmNotificationItem( .. ) { ... } in production [22:51:29] "Why am I getting Flow notifications?! Ooooh...." [22:51:34] * mooeypoo whistles [22:51:40] innocently, I'm sure [22:51:50] Overly innocently. [22:52:08] I blame... uh... uh... lego. I blame lego. For... something... [22:52:24] Something popuppy. There you go. [22:52:48] Behold how I expertly shift attention from myself with red popup herrings! [22:57:39] o.O [22:58:00] oops... [22:59:56] legoktm, you know what would've been worse? [23:00:14] I can think of a lot, but go ahead :P [23:00:42] if I found mw.echo.ui.NotificationBadgeWidget = function MwEchoFlyoutWidget( model, config ) { [23:00:50] THAT... would've been the end. [23:00:51] The reality is worse in some ways [23:01:02] well, the original is this [23:01:03] mw.echo.ui.NotificationBadgeWidget = function MwEchoUiNotificationBadgeButtonPopupWidget( model, config ) { [23:01:05] \o/ [23:01:10] But it is CONCISE [23:01:14] Try to say that without running out of breath [23:01:22] I bet the computer can [23:01:41] em double you echo you eye notification badge widget equals function em double you echo you eye notification badge button popup widget [23:02:10] is it causing any actual problems? or just that it shouldn't be named Flow? [23:02:13] Hey. At least it's POPUP. [23:02:26] No actual problems, it just causes double-takes when looking at the debugging console [23:02:28] It's just annoying to debug and figure out what is where [23:02:42] As in "Why am I getting Flow notifications?" [23:02:42] Those function names are unused except by the console [23:03:12] lolol [23:07:40] (03CR) 10Catrope: Track what wikis a user has unread notifications on (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 (owner: 10Legoktm) [23:07:46] (03CR) 10Catrope: [C: 04-1] Track what wikis a user has unread notifications on (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 (owner: 10Legoktm) [23:16:22] (03CR) 10Catrope: Browser Tests: fix (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252711 (owner: 10Sbisson) [23:17:15] (03PS3) 10Catrope: Browser Tests: fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252711 (owner: 10Sbisson) [23:34:10] (03CR) 10Catrope: [C: 032] Browser Tests: fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252711 (owner: 10Sbisson) [23:38:11] (03Merged) 10jenkins-bot: Browser Tests: fix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252711 (owner: 10Sbisson) [23:42:43] (03PS28) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [23:43:00] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [23:47:37] (03CR) 10Catrope: [C: 032] Remove unused NotifUser::getFormattedNotificationCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252754 (owner: 10Legoktm) [23:48:45] (03CR) 10Catrope: [C: 032] Fix some phpdoc, add missing @throws [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252850 (owner: 10Legoktm) [23:49:58] (03CR) 10Catrope: [C: 032] Allow welcome notifications to have a primary link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252853 (https://phabricator.wikimedia.org/T117509) (owner: 10Legoktm) [23:51:09] (03Merged) 10jenkins-bot: Remove unused NotifUser::getFormattedNotificationCount() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252754 (owner: 10Legoktm) [23:52:09] (03Merged) 10jenkins-bot: Fix some phpdoc, add missing @throws [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252850 (owner: 10Legoktm) [23:52:55] (03CR) 10Catrope: [C: 032] EventPresentationModel: Add accessor for current user's username [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252855 (https://phabricator.wikimedia.org/T118058) (owner: 10Legoktm) [23:53:11] (03Merged) 10jenkins-bot: Allow welcome notifications to have a primary link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252853 (https://phabricator.wikimedia.org/T117509) (owner: 10Legoktm) [23:53:56] (03CR) 10Catrope: [C: 032] Remove unncessary code from NotifUserTest [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252756 (owner: 10Legoktm) [23:58:12] (03Merged) 10jenkins-bot: EventPresentationModel: Add accessor for current user's username [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252855 (https://phabricator.wikimedia.org/T118058) (owner: 10Legoktm) [23:58:15] (03Merged) 10jenkins-bot: Remove unncessary code from NotifUserTest [extensions/Echo] - 10https://gerrit.wikimedia.org/r/252756 (owner: 10Legoktm)