[00:00:25] mooeypoo, maybe, it depends where the problem is. If it's reinserting the exact same object, that would cause the same symptoms and re-inserting the same object with a different ID would just cause a duplicate post. [00:01:45] Going to take a break and test the dump patch, then history pagination, then come back here. [00:01:48] Maybe I'll have an insight. [00:01:52] hm good point [00:01:55] matt_flaschen: I didn't see the same UUID twice though, in the logs [00:02:03] But I didn't compare -3 with -4 yet to be fair [00:02:04] Can we compare objects? [00:02:20] Do we have another way other than UUIDs to compare whether something is the same post, even just for this test? [00:02:32] RoanKattouw, but you only see the duplicate one. So if it inserts it normally, then something makes it re-insert, you'll only see the second. [00:02:33] can we check if the same UUID is found, whether the content is the same? [00:02:42] mooeypoo, I was thinking of adding some debugging code to facilitate that. [00:02:59] matt_flaschen: Sure, but you would expect that probably it'd be trying to double-insert the same objects if you reran it [00:03:08] Or that there would be some rhyme or reason to which objects get double-inserted [00:03:11] Yeah, we can see if that's the case, then, and if we cache structures we can maybe see if the object was slightly changed or something [00:03:12] But that doesn't happen [00:03:21] Hm... I guess since the conversion skips already-imported things, maybe not [00:03:33] RoanKattouw, it wouldn't be the same UID, though, since it's random. And I think the topic rolls back, so it would hit the same scenario again, but with a different ID. [00:04:21] Right [00:04:32] Same topic every time, but it leaves no trace of the old UUID [00:06:58] legoktm, help :\ echo_target_page ...? what's it do? when I insert a newly 'unread' message, what details do I need? I'm searching Echo for what adds to it and I'm going down a rabbit hole of sql statements [00:07:54] mooeypoo, the point is to automatically mark as read after you visit the page. [00:08:16] ahh [00:08:17] Oh right [00:08:19] hm. [00:08:26] So then when marking a notif as unread, you'd need to do some magic to reinsert those rows [00:08:30] Okay, so when I re-add to that table, I need.... things I don't have. Crap. [00:08:37] Perhaps through TargetPageMapper but I understand this very poorly [00:08:41] * RoanKattouw wishes legoktm was around to answer that [00:09:20] mooeypoo, probably better to not delete the rows until the 'prune script' runs. [00:09:36] What do you mean? [00:09:50] "Mark as read" deletes them [00:09:59] RoanKattouw, so because after you go read -> mark as read -> visit the page, it needs to get marked as read again. [00:10:01] "Mark as unread" needs to bring them back, whether it was an old notification or a new one [00:10:03] (03Abandoned) 10Alex Monk: Add artificial primary key to flow_wiki_ref and flow_ext_ref [extensions/Flow] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/251415 (https://phabricator.wikimedia.org/T109676) (owner: 10Mattflaschen) [00:10:03] When a notif is marked as read, those rows are deleted; but when we mark one as unread, they need to be reinserted. It sounds like a prune script wouldn't change that, because you could mark a notif as unead post-prone [00:10:06] mooeypoo, right, I'm saying to stop deleting them. [00:10:21] Unless the prune script only prunes those rows for notifs that themselves are pruned [00:10:28] But even if we do that, then at some point we'll prune, they'll be lost, and then we need to re-add them again anyways [00:10:36] But that would require keeping around a bunch more rows in that table; which might be OK I suppose [00:11:00] Right [00:11:13] I must have a way to get the page from the event information [00:11:13] (03CR) 10Alex Monk: [C: 032] Add artificial primary key to flow_wiki_ref and flow_ext_ref [extensions/Flow] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251416 (https://phabricator.wikimedia.org/T109676) (owner: 10Mattflaschen) [00:11:14] mooeypoo, no, because at some point we delete the whole event (and all associated data including target page) for real. [00:11:19] I have access to the event ID [00:11:25] mooeypoo, at that point, it would no longer exist at all, and thus not be mark-as-unread-able. [00:11:31] hmmm [00:11:44] Would that not spam the table though? leave a whole bunch of unnecessary rows? [00:11:50] also, we have a lot of "selects" from that table [00:12:00] we'll have to change all of them to check if thy're actually unread [00:13:47] You both have a point about table size. [00:14:06] I don't think the queries are as big an issue, properly indexed. [00:14:10] (03Merged) 10jenkins-bot: Add artificial primary key to flow_wiki_ref and flow_ext_ref [extensions/Flow] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251416 (https://phabricator.wikimedia.org/T109676) (owner: 10Mattflaschen) [00:14:16] It just means the table will be the same size as the notifications table [00:14:38] mooeypoo, not really, becase not all events have target pages. But some can have more than one. [00:14:39] we will have the same amount of rows in the echo_target_page table as we do in the notifications table [00:14:48] ah, hm, really? [00:15:43] matt_flaschen, okay, I'm doing everything *else* to make it work in the API [00:15:54] and I'll leave this one to legoktm and so e can consider what to do there [00:16:18] I am fairly sure we can re-add those rows too, we should have the information needed, and something does that when the notification is created, we should be able to "simply" call the same operation [00:16:25] that might save table space [00:16:51] mooeypoo, yes, see https://git.wikimedia.org/commit/mediawiki%2Fextensions%2FEcho.git/70639162f341ce19a6e8e15d728f2b89e04d16b3 . [00:19:25] sorry, I'm back [00:19:47] I'm not sure it makes sense to re-add echo_target_page rows [00:20:11] presumably if you explicitly mark a notification as unread, you don't want it automatically marked as read? [00:20:26] mooeypoo, you can't just re-call it with the current design, since it's passed in at event creation time. [00:21:41] 6Collaboration-Team-Backlog, 10Flow: Preferences-Notifications: disable Flow Web notifications - some of messages are still displayed - https://phabricator.wikimedia.org/T117934#1787295 (10Etonkovidova) 3NEW [00:27:18] 6Collaboration-Team-Backlog, 10Flow: When a page is manually converted to use Flow, the page-tabs turns blue immediately even if the page is empty - https://phabricator.wikimedia.org/T117828#1787312 (10Quiddity) >>! In T117828#1784710, @Spage wrote: >would deleting leave the "knowledge" somewhere that the page... [00:28:36] legoktm, good point [00:29:11] though I'm not sure that's what the user will expect entirely [00:29:38] But we can deal with taht later. I'm implementing without touching the echo_target_page when it's unmarked read [00:29:42] or.. marked... unread [00:30:28] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Deploy artificial primary key reference change to all production wikis simultaneously - https://phabricator.wikimedia.org/T117785#1787322 (10Mattflaschen) SWATed out. [00:30:56] ok, legoktm so, I did all the background stuff for mark unread, and now I'm thinking of how to add it to the API. There's an ApiEchoMarkRead that takes 'list' / 'all' / 'sections' params into it [00:31:09] I wsa thinking of creating the same thing for ApiEchoMarUnread but that will duplicate a lot of code [00:31:20] ibut then adding a parameter to echomarkread is weird [00:31:30] legoktm, what do you think? [00:32:00] I think we should add it as a new parameter to echomarkread for now [00:32:09] Also do we even want "mark *all* unread? [00:32:17] we should probably only have a mark read for a list [00:32:22] not sections and not all [00:32:25] Uh, no. [00:32:30] agreed [00:32:41] ok, so a sub-parameter to 'list' ? [00:32:55] or maybe an unreadlist=... param? [00:33:13] We're going to have to do a breaking change some point in the future w/r meta=notifications, we can probably do a few more at that time to give everything sensible names [00:33:25] yeah [00:33:33] we also need to fix/redo the seentime business [00:33:46] especially with the separation of alert/message *and* with cross-wiki stuff [00:33:52] but that can wait [00:35:47] (03CR) 10Catrope: [C: 04-1] "Looks good, one minor thing" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 (owner: 10Mooeypoo) [00:36:38] mooeypoo, legoktm, in my opinion, after marking a notification as unread, a user will expect it behave the same as if they just received it. [00:36:55] If we're making it behave different, we should think about how to clarify that (maybe 'pinned', rather than unread). [00:37:32] I see your argument, but I think in practice it'll be too annoying [00:37:47] RoanKattouw, for the user, or to implement? [00:37:58] We also don't make it explicit that visiting a page can mark a notif as read. Clicking it does, and that's fine, but it's implemented as a side effect of the former [00:38:10] For the user to keep a notif unread without accidentally making it be read again [00:38:19] that raises another issue though [00:38:30] if you marked a notification as unread and then you click it, it won't turn read [00:38:37] Right :S [00:38:47] I think maybe we should mark notifs as read on click, not when viewing a page [00:38:55] Although that could be difficult to support for nojs [00:38:58] We *could* do it for the user from the front end, but that's going too far to fix something we should probably fix in the back end [00:39:04] yeah exactly [00:39:15] though marking on click raises another issue [00:39:24] middle click :S [00:39:27] let's say I have notifications open for a while and my internet broke [00:39:36] now I click notification, the page doesn't load right [00:39:37] is it read? [00:39:42] no... but it might be marked as read [00:39:45] Oh right, the way we do it now you only mark read on a successful view [00:39:49] yeah [00:40:01] mooeypoo, how likely is it to die after the markasread request succeeds before the page loads? [00:40:04] in my example it actually won't be marked read because if the internet broke, the API will fail, but still [00:40:25] I don't know, but I am more worried about cross-wiki notifications [00:40:28] We should talk to Pau about this. [00:40:31] where you load the notification on another wiki [00:42:04] 6Collaboration-Team-Backlog, 10Echo, 7Design, 7WorkType-NewFunctionality: Allow marking Echo notifications as unread - https://phabricator.wikimedia.org/T73564#1787332 (10Mattflaschen) This raised a question about part of the current behavior. We currently automatically mark notifications as read when you... [00:42:34] mooeypoo, what's the difference, other than needing CORS for a markasread API request? [00:43:14] In terms of this issue. [00:43:22] 6Collaboration-Team-Backlog, 10Echo, 7Design, 7WorkType-NewFunctionality: Allow marking Echo notifications as unread - https://phabricator.wikimedia.org/T73564#1787334 (10Catrope) >>! In T73564#844657, @Quiddity wrote: > I do also like the sound of Matthias' description. That would solve the annoyance fact... [00:43:48] (and sending CORS requests is now super easy with mw.ForeignApi) [00:44:13] 6Collaboration-Team-Backlog, 10Echo, 7Design, 7WorkType-NewFunctionality: Allow marking Echo notifications as unread - https://phabricator.wikimedia.org/T73564#1787336 (10Catrope) >>! In T73564#844657, @Quiddity wrote: > In the meeting, we discussed the idea of being able to "pin" or "sticky" a notificatio... [00:44:56] (03CR) 10Catrope: [C: 032] Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 (owner: 10Mooeypoo) [00:46:54] 6Collaboration-Team-Backlog, 10Echo, 7Design, 7WorkType-NewFunctionality: Allow marking Echo notifications as unread - https://phabricator.wikimedia.org/T73564#1787338 (10Mattflaschen) >>! In T73564#1787336, @Catrope wrote: > Perhaps we could also reevaluate whether automatically marking alerts (but not me... [00:50:51] matt_flaschen, no, I mean we might run into cases where marking read in the api takes faster than going to the page, and we might run into cases where the page may not fully render properly [00:51:54] mooeypoo, yeah, actually that raises a good point. [00:52:18] mooeypoo, you either have to block navigation until the markasread is complete (kind of suck) or use sendBeacon (probably would work fine). [00:52:38] At this point, isn't it just better to set things up better in the back end? [00:53:06] mooeypoo, meaning what? [00:53:19] mooeypoo, also, we're talking about the possibility of a UX change. [00:53:43] I'm actually fine with the current UX (e.g. visiting a topic marks that topic notification as read regardless of how you get there), but we could consider changing it. [00:53:50] instead of finding how to updaete on click and then make sure we only update on click when the page renders, etc etc -- we just make sure that the current behavior (removing on page view) is kept, throughout [00:54:30] Yeah, I'm fine with removing on page view, I only mentioned this because RoanKattouw started talking about it. [00:56:14] 6Collaboration-Team-Backlog, 10Flow, 7Design: Make source/wikitext icon consistent - https://phabricator.wikimedia.org/T97451#1787355 (10DannyH) [00:56:37] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Flow's administration - https://phabricator.wikimedia.org/T113582#1787359 (10DannyH) [00:59:17] mooeypoo, turns out it's stored in the echo_event table, so you can pretty easily rebuild the relevant echo_target_page entries. [00:59:38] yeah I think there's also an object we can call [00:59:48] It's not queryable, since it's in JSON, but you're only dealing with the few they marked as read, which are probably already loaded. [01:00:06] ok I need to go in a minute, but I will have a basic wip soon that we can at least start building on depending on what we decide regarding the XU [01:00:07] UX [01:03:43] (03PS3) 10Mooeypoo: [wip] Allow notifications to be marked as unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 [01:03:57] ok this is the WIP. It's still having troubles marking unread in the API, I'm probably doing something wrong there [01:03:59] but I have to run [01:04:02] (03CR) 10jenkins-bot: [V: 04-1] [wip] Allow notifications to be marked as unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (owner: 10Mooeypoo) [01:04:13] i'll see you guys tomorrow [01:15:43] (03CR) 10Catrope: [C: 04-1] Implement SortedList in Echo notifications (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 (owner: 10Mooeypoo) [01:29:30] (03CR) 10Mattflaschen: "When I test the full wiki import, I get a duplicate key error:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie) [01:31:49] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Add debug code to make details of UID collisions more obvious - https://phabricator.wikimedia.org/T117936#1787401 (10Mattflaschen) 3NEW a:3Mattflaschen [01:33:27] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Determine cause of historical UIDs colliding - https://phabricator.wikimedia.org/T117907#1787409 (10Mattflaschen) I also got: ``` vagrant@mediawiki-vagrant:~$ mwscript extensions/Flow/maintenance/importDump.php --wiki=wiki /vagrant/full_Flow_w... [01:43:01] (03CR) 10Mattflaschen: "FlowFixWorkflowLastUpdateTimestamp.php works." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [01:45:36] (03CR) 10Catrope: [C: 04-1] Flow post-reply presentation model (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251412 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [01:49:21] (03CR) 10Catrope: Flow post-reply presentation model (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251412 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [01:50:53] (03CR) 10Catrope: [C: 04-1] Presentation model for new-topic notification (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251411 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [01:51:09] (03CR) 10Catrope: Presentation model for new-topic notification (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251411 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [02:01:23] 6Collaboration-Team-Backlog, 10Echo: Make echo colourful - https://phabricator.wikimedia.org/T117923#1787435 (10Aklapper) This is pretty subjective... Which problems do the changed colors create when it comes to your workflow? Problem descriptions and usecase are welcome - "Make Echo colourful" is just one pot... [02:10:00] I'm getting Parsoid failures trying to preview posts on mw.org in both Firefox and Chromium (curl error: 26) [02:19:15] 6Collaboration-Team-Backlog, 10Flow: Parsoid failures trying to preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1787444 (10Spage) 3NEW [02:20:42] ^ seems the @ mention messes up parsoid, remove it and flow-parsoid-utils responds OK. [02:35:53] spagewmf, you just wrote the wikitext: [02:36:05] @foo Thank you [02:36:07] ? [02:36:51] spagewmf, confirmed. [02:39:51] 6Collaboration-Team-Backlog, 10Flow: Parsoid failures trying to preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1787465 (10Mattflaschen) a:3Mattflaschen [02:40:05] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1787444 (10Mattflaschen) [02:40:14] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1787444 (10Mattflaschen) [02:45:33] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1787473 (10Mattflaschen) a:5Mattflaschen>3None [02:51:23] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1787479 (10Mattflaschen) Can be reproduced on Terbium easily: ``` mattflaschen@terbium:~$ mwscript eval.php --wiki=mediawikiwiki > var_export( F... [02:51:38] Have a good night, everyone. [03:17:50] 6Collaboration-Team-Backlog, 10Flow: a malformed URL can display any post in the titlebar area - https://phabricator.wikimedia.org/T117940#1787487 (10Spage) 3NEW [09:25:35] 6Collaboration-Team-Backlog, 10Echo: 127.0.0.1 instead of username in notifications about article linked - https://phabricator.wikimedia.org/T116470#1787767 (10Green_Zero) From 30 october notifications works correctly. Thanks! [09:31:11] 6Collaboration-Team-Backlog, 10Echo: 127.0.0.1 instead of username in notifications about article linked - https://phabricator.wikimedia.org/T116470#1787769 (10Green_Zero) 5Open>3Resolved [12:17:25] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251411 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [12:17:58] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251412 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [13:23:23] 6Collaboration-Team-Backlog, 10Echo: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1788146 (10Trizek-WMF) 3NEW [13:40:20] (03PS2) 10Sbisson: Flow post-reply presentation model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251412 (https://phabricator.wikimedia.org/T116845) [13:44:06] (03CR) 10Sbisson: Flow post-reply presentation model (035 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251412 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [13:57:56] 6Collaboration-Team-Backlog, 10Echo, 7I18n: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1788216 (10Aklapper) [14:03:06] (03CR) 10Sbisson: Presentation model for new-topic notification (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251411 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [14:14:31] 6Collaboration-Team-Backlog, 10Echo, 7I18n: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1788239 (10SBisson) These messages are new. See {T107823} and {T116847}. `notification-header-edit-thank` is part of the Thanks extension. See https://translatewi... [14:15:49] (03PS3) 10Sbisson: Presentation model for new-topic notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251411 (https://phabricator.wikimedia.org/T116845) [14:24:08] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison: Try all possible admin actions concerning Flow - https://phabricator.wikimedia.org/T116785#1788254 (10Trizek-WMF) **Move a page** Tests: * on MW with my WMF account (sysop and Flow manager) - works * on fr.wp with my WMF account (autopatrolled and Flow... [14:28:23] 6Collaboration-Team-Backlog, 10Echo, 7I18n: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1788280 (10Trizek-WMF) Thanks a lot for this clarification @SBisson. Just to know if something is missing, this has not been announced, correct? [14:30:11] 6Collaboration-Team-Backlog, 10Echo, 7I18n: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1788284 (10SBisson) >>! In T117966#1788280, @Trizek-WMF wrote: > Just to know if something is missing, this has not been announced, correct? I haven't seen anythin... [14:44:43] (03PS1) 10Sbisson: Presentation model for topic-renamed notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251502 (https://phabricator.wikimedia.org/T116845) [14:50:03] 3Collaboration-Team-Current, 10Echo, 10Flow, 5Patch-For-Review: Write presentation models for notifications in Flow - https://phabricator.wikimedia.org/T116845#1788315 (10SBisson) [14:59:16] 6Collaboration-Team-Backlog, 10Echo, 7I18n: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1788338 (10Trizek-WMF) >>! In T117966#1788284, @SBisson wrote: > How do we usually announce new messages that need translation? I've sometimes seen major translati... [15:24:21] 6Collaboration-Team-Backlog, 10Flow: Same topic displayed twice on a board - https://phabricator.wikimedia.org/T117973#1788357 (10Trizek-WMF) 3NEW [15:35:07] (03PS1) 10Sbisson: Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [15:35:21] (03PS2) 10Sbisson: [WIP] Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [15:36:10] (03Abandoned) 10Sbisson: Presentation model for new-topic notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251411 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [15:36:20] (03Abandoned) 10Sbisson: Flow post-reply presentation model [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251412 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [15:36:51] 3Collaboration-Team-Current, 10Echo, 10Flow, 5Patch-For-Review: Write presentation models for notifications in Flow - https://phabricator.wikimedia.org/T116845#1788396 (10SBisson) [15:38:01] (03Abandoned) 10Sbisson: Presentation model for topic-renamed notification [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251502 (https://phabricator.wikimedia.org/T116845) (owner: 10Sbisson) [15:41:50] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 10Browser-Tests-Infrastructure: Update PageTriage mediawiki_selenium Ruby gem to version 1.x - https://phabricator.wikimedia.org/T117979#1788436 (10zeljkofilipin) 3NEW a:3zeljkofilipin [15:42:33] (03PS3) 10Sbisson: [WIP] Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [16:14:28] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 10Browser-Tests-Infrastructure: Fix easy problems reported by RuboCop in PageTriage - https://phabricator.wikimedia.org/T117985#1788553 (10zeljkofilipin) 3NEW a:3zeljkofilipin [16:16:39] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 10Browser-Tests-Infrastructure: Fix easy problems reported by RuboCop in PageTriage - https://phabricator.wikimedia.org/T117985#1788600 (10zeljkofilipin) a:5zeljkofilipin>3None [16:24:54] Heya. [16:25:32] Is there a Phabricator ticket for enabling the Beta Feature to opt in to Flow on all wikis? [16:26:52] not that I know of [16:27:17] * James_F creates one. [16:27:42] 3Collaboration-Team-Current, 10Flow, 10Wikidata, 10Wikimedia-Site-Requests: Enable the Flow personal talk opt-in Beta Feature on Wikidata.org - https://phabricator.wikimedia.org/T116611#1788615 (10Jdforrester-WMF) [16:28:24] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1788617 (10Jdforrester-WMF) 3NEW [16:28:35] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1788625 (10Jdforrester-WMF) [16:28:36] 3Collaboration-Team-Current, 10Flow, 10Wikidata, 10Wikimedia-Site-Requests: Enable the Flow personal talk opt-in Beta Feature on Wikidata.org - https://phabricator.wikimedia.org/T116611#1753818 (10Jdforrester-WMF) [16:29:19] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests: Enable the Flow personal talk opt-in Beta Feature on bswiki - https://phabricator.wikimedia.org/T117991#1788627 (10Jdforrester-WMF) 3NEW a:3Jdforrester-WMF [16:30:18] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests: Enable the Flow personal talk opt-in Beta Feature on urwiki - https://phabricator.wikimedia.org/T117992#1788635 (10Jdforrester-WMF) 3NEW [16:30:31] (03PS4) 10Sbisson: [WIP] Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [16:33:45] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Site-Requests: Enable the Flow personal talk opt-in Beta Feature on all wikis - https://phabricator.wikimedia.org/T117990#1788653 (10Jdforrester-WMF) a:3Jdforrester-WMF [16:34:31] 3Collaboration-Team-Current, 10Flow, 10Wikidata, 10Wikimedia-Site-Requests, 5Patch-For-Review: Enable the Flow personal talk opt-in Beta Feature on Wikidata.org - https://phabricator.wikimedia.org/T116611#1788658 (10Jdforrester-WMF) a:3Jdforrester-WMF [16:35:40] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Deploy artificial primary key reference change to all production wikis simultaneously - https://phabricator.wikimedia.org/T117785#1788660 (10jcrespo) The non-existent array index complains with a notice here ht... [16:51:51] (03PS5) 10Sbisson: [WIP] Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [17:01:09] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 10Browser-Tests-Infrastructure: Update PageTriage mediawiki_selenium Ruby gem to version 1.x - https://phabricator.wikimedia.org/T117979#1788713 (10zeljkofilipin) a:5zeljkofilipin>3None [17:03:10] (03PS6) 10Sbisson: [WIP] Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [17:24:52] stephanebisson, matt_flaschen, re: whether or not to hide notifications for 'hidden' flow content, Benoit disagrees with me, and suggests we don't hide those by default. [17:30:52] 6Collaboration-Team-Backlog, 10Echo, 7Browser-Tests: 'I am logged in as a new user with no notifications' doesn't always work on browser tests - https://phabricator.wikimedia.org/T102177#1788823 (10zeljkofilipin) [17:40:00] 6Collaboration-Team-Backlog, 10Flow, 7Browser-Tests: Mobile browser tests for Flow - https://phabricator.wikimedia.org/T110562#1788853 (10zeljkofilipin) [17:40:45] 6Collaboration-Team-Backlog, 10Flow, 7Browser-Tests: More Flow no-JS browser tests - https://phabricator.wikimedia.org/T114729#1788869 (10zeljkofilipin) [17:41:18] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5), 5WMF-deploy-2015-11-10_(1.27.0-wmf.6): undo (coming from history) fails in Firefox - https://phabricator.wikimedia.org/T117835#1788875 (10Etonkovidova) Checked in betalabs and mediawiki. [17:45:58] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: MediaWiki.echo.overlay stats are wrong after lazy-load - https://phabricator.wikimedia.org/T113387#1788902 (10Etonkovidova) Checked stats count functionality in betalabs. For the case when Preferences-Notifications- Flow disabled (un-checked) see {{T11... [17:57:27] 6Collaboration-Team-Backlog, 10Echo, 7I18n: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1788939 (10Trizek-WMF) p:5Unbreak!>3High I'm sending an email to translators-l, and this will be announced on TechNews as well. [17:58:45] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7Browser-Tests, 7Ruby: Fix easy problems reported by RuboCop in PageTriage - https://phabricator.wikimedia.org/T117985#1788949 (10zeljkofilipin) [18:00:29] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 10Browser-Tests-Infrastructure, 7Ruby: Update PageTriage mediawiki_selenium Ruby gem to version 1.x - https://phabricator.wikimedia.org/T117979#1788965 (10zeljkofilipin) [18:13:08] 3Collaboration-Team-Current, 10Flow: Broken Special:Log output due to missing message logentry-lock-flow-lock-topic - https://phabricator.wikimedia.org/T118002#1789062 (10Catrope) 3NEW [18:13:16] ----^^ :( [18:13:21] (03CR) 10Legoktm: [C: 032] Make EchoEvent::create() a no-op if the DB is read-only [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250309 (owner: 10Aaron Schulz) [18:15:16] mooeypoo: https://gerrit.wikimedia.org/r/#/c/247028/ [18:21:34] (03PS4) 10Mooeypoo: Allow notifications to be marked as unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 [18:21:38] 3Collaboration-Team-Current, 10Flow: Editing post using nojs URL with JS enabled is broken - https://phabricator.wikimedia.org/T118006#1789136 (10Catrope) 3NEW [18:22:18] 3Collaboration-Team-Current, 10Echo, 7Design, 7WorkType-NewFunctionality: Allow marking Echo notifications as unread - https://phabricator.wikimedia.org/T73564#1789147 (10Catrope) a:3Mooeypoo [18:22:27] (03Merged) 10jenkins-bot: Make EchoEvent::create() a no-op if the DB is read-only [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250309 (owner: 10Aaron Schulz) [18:23:01] (03PS5) 10Mooeypoo: Allow notifications to be marked as unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 [18:23:04] (03PS12) 10Mooeypoo: Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 [18:23:07] (03PS9) 10Mooeypoo: Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 [18:23:10] (03PS8) 10Mooeypoo: Initialize notifications model outside of the widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 [18:23:13] (03CR) 10jenkins-bot: [V: 04-1] Allow notifications to be marked as unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (owner: 10Mooeypoo) [18:23:40] (03PS6) 10Mooeypoo: Allow notifications to be marked as unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) [18:23:47] mooeypoo: https://phabricator.wikimedia.org/T115551 [18:24:05] (03PS20) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [18:25:42] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) (owner: 10Mooeypoo) [18:27:05] (03CR) 10jenkins-bot: [V: 04-1] Allow notifications to be marked as unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) (owner: 10Mooeypoo) [18:27:37] 3Collaboration-Team-Current, 10Echo, 7Design, 5Patch-For-Review, 7WorkType-NewFunctionality: Allow marking Echo notifications as unread - https://phabricator.wikimedia.org/T73564#1789209 (10Mooeypoo) @PGiner-WMF I was guessing which icon to use as the 'mark unread' icon, and the 'circle' one seemed like... [18:30:20] 3Collaboration-Team-Current, 10Flow: Broken Special:Log output due to missing message logentry-lock-flow-lock-topic - https://phabricator.wikimedia.org/T118002#1789224 (10SBisson) These keys are generated by `ActionFormatter.php:98`. It may never have existed. [18:47:48] (03CR) 10Catrope: [C: 04-1] "qunit fails with TypeError: this.apiHandler.toggleItemReadStatus is not a function" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) (owner: 10Mooeypoo) [18:49:04] (03CR) 10Mooeypoo: Initialize notifications model outside of the widget (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 (owner: 10Mooeypoo) [18:49:19] (03PS9) 10Mooeypoo: Initialize notifications model outside of the widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 [18:50:11] (03PS10) 10Mooeypoo: Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 [18:50:20] 3Collaboration-Team-Current, 10Flow: Editing post using nojs URL with JS enabled is broken - https://phabricator.wikimedia.org/T118006#1789373 (10Catrope) a:3Catrope [18:57:16] (03PS13) 10Mooeypoo: Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 [18:58:48] mooeypoo, rebut my comments/research at https://phabricator.wikimedia.org/T110158#1573717 if you want to change it! ;p [18:58:49] (Note: my angle is purely "What do we call it in the user-facing docs"... if you want to name it something different in the code (and face ongoing confusion when users refer to it by the original name), that's up to you! [19:00:41] (03CR) 10Mooeypoo: Implement SortedList in Echo notifications (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 (owner: 10Mooeypoo) [19:01:19] (03PS14) 10Mooeypoo: Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 [19:01:33] (03PS7) 10Mooeypoo: Allow notifications to be marked as unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) [19:01:44] (03PS21) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (https://phabricator.wikimedia.org/T115551) [19:04:33] (03PS1) 10Catrope: Follow-up 715e950bd33: also activate EditPostWidget in nojs form code path [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251547 (https://phabricator.wikimedia.org/T118006) [19:05:20] (03CR) 10jenkins-bot: [V: 04-1] Allow notifications to be marked as unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) (owner: 10Mooeypoo) [19:09:03] Anyone having problems connecting to Gerrit via ssh? [19:09:07] git fetch hangs for me. [19:14:52] Aaron said he did in another channel [19:17:05] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-PageCuration, 5Patch-For-Review: PageTriage's "patrolled" notifications are jargony and scary - https://phabricator.wikimedia.org/T114415#1789524 (10Catrope) 5Open>3Resolved >>! In T114415#1770934, @Mattflaschen wrote: >>>! In T114415#1720432,... [19:20:04] mooeypoo: not sure if you saw my comment on https://gerrit.wikimedia.org/r/#/c/237509/ [19:35:22] jdlrobson, I was going to look now -- also, I need to re-add the logger [19:37:15] 3Collaboration-Team-Current, 10Flow: When deleting Flow topic or post, contributions should move from Contributions to DeletedContributions - https://phabricator.wikimedia.org/T118024#1789656 (10Quiddity) 3NEW [19:42:17] (03PS1) 10Mattflaschen: Add isset to handle when ref_id is not in row returned from MC index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251558 (https://phabricator.wikimedia.org/T109676) [19:44:28] (03PS2) 10Mattflaschen: Add isset to handle when ref_id is not in row returned from MC index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251558 (https://phabricator.wikimedia.org/T109676) [19:44:50] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Deploy artificial primary key reference change to all production wikis simultaneously - https://phabricator.wikimedia.org/T117785#1789686 (10Mattflaschen) >>! In T117785#1788660, @jcrespo wrote: > The non-exist... [19:45:19] (03PS8) 10Mooeypoo: Allow notifications to be marked as unread [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251309 (https://phabricator.wikimedia.org/T73564) [19:47:54] (03CR) 10Catrope: [C: 032] Add isset to handle when ref_id is not in row returned from MC index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251558 (https://phabricator.wikimedia.org/T109676) (owner: 10Mattflaschen) [19:49:22] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison: Try all possible admin actions concerning Flow - https://phabricator.wikimedia.org/T116785#1789690 (10Mattflaschen) > Board is deleted, Topics are still available (but it is normal). Please elaborate on exactly what you saw, at T116095. [19:51:51] (03Merged) 10jenkins-bot: Add isset to handle when ref_id is not in row returned from MC index [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251558 (https://phabricator.wikimedia.org/T109676) (owner: 10Mattflaschen) [19:51:59] Joel Spolsky is speaking in 10 minutes. Links in email. [19:52:23] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1789710 (10Catrope) From Googling around, curl error 26 appears to be "failed creating formpost data", and a mailing list post that I found (that... [19:53:37] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1789726 (10Mattflaschen) Oh yeah, in command-line cURL, @ means filename. I didn't realize that also affected the library. [19:54:06] Of Joel on Software and Stack Overflow. [20:02:22] (03CR) 10Sbisson: [C: 032] Follow-up 715e950bd33: also activate EditPostWidget in nojs form code path [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251547 (https://phabricator.wikimedia.org/T118006) (owner: 10Catrope) [20:03:04] Thanks [20:03:19] I'll cherry-pick that once it merges [20:03:34] matt_flaschen: Would you be able to babysit a morning SWAT for ---^^ on Monday? [20:04:04] RoanKattouw, sure. [20:04:21] OK, thanks. I'll put it in the calendar once the merge comes through and I've made the cherry-pick commit [20:05:57] (03Merged) 10jenkins-bot: Follow-up 715e950bd33: also activate EditPostWidget in nojs form code path [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251547 (https://phabricator.wikimedia.org/T118006) (owner: 10Catrope) [20:06:17] (03PS1) 10Catrope: Follow-up 715e950bd33: also activate EditPostWidget in nojs form code path [extensions/Flow] (wmf/1.27.0-wmf.5) - 10https://gerrit.wikimedia.org/r/251560 (https://phabricator.wikimedia.org/T118006) [20:08:19] 6Collaboration-Team-Backlog, 10Flow: Same topic displayed twice on a board - https://phabricator.wikimedia.org/T117973#1789759 (10Mattflaschen) p:5Triage>3Unbreak! We should try to investigate this before it gets purged or expires from cache. [20:08:47] 3Collaboration-Team-Current, 10Flow: Same topic displayed twice on a board - https://phabricator.wikimedia.org/T117973#1789764 (10Mattflaschen) [20:09:54] (03PS1) 10Mooeypoo: Add MobileNotificationsWrapperWidget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251561 [20:44:05] 6Collaboration-Team-Backlog, 10Echo, 7I18n, 7user-notice: Translations broken on Echo since last MediaWiki release - https://phabricator.wikimedia.org/T117966#1789799 (10matej_suchanek) [20:54:22] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1789834 (10Catrope) a:3Catrope [21:26:04] (03PS7) 10Sbisson: Flow notification presentation models [extensions/Flow] - 10https://gerrit.wikimedia.org/r/251512 (https://phabricator.wikimedia.org/T116845) [22:22:41] The translations for Urdu's timestamp messages, are correct *during* load, and then changes to English once JS is loaded. E.g. https://www.mediawiki.org/wiki/Talk:Sandbox?uselang=ur [22:22:45] It's probably related to https://phabricator.wikimedia.org/T111596 ("Relative timestamp different between nojs and js mode ("1 day ago", "a day ago")") and https://phabricator.wikimedia.org/T102728 ("Flow does not respect time format and time zone preferences in JS mode") but I'm not sure if a new task is needed, or if one of those existing tasks should just be repurposed/broadened...? [22:25:35] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1790065 (10Mattflaschen) What is this blocked on? [22:27:56] 3Collaboration-Team-Current, 10Flow: Parsoid failures trying to preview posts with @ mentions on mw.org (curl error: 26) - https://phabricator.wikimedia.org/T117938#1790076 (10Legoktm) >>! In T117938#1790065, @Mattflaschen wrote: > What is this blocked on? The blocking task, {T118032}. [22:31:27] RoanKattouw_away, good catch on the edit post widget on no-JS. Should have caught that in my patch. [22:46:04] 6Collaboration-Team-Backlog, 10Flow: Preferences-Notifications: disable Flow Web notifications - some of messages are still displayed - https://phabricator.wikimedia.org/T117934#1790124 (10Mattflaschen) 5Open>3Invalid a:3Mattflaschen This is not a Flow notification. It's a notification for a non-Flow us... [22:47:39] 6Collaboration-Team-Backlog, 10Flow: Preferences-Notifications: disable Flow Web notifications - some of messages are still displayed - https://phabricator.wikimedia.org/T117934#1790136 (10Mattflaschen) This would be controlled by the Web column of the "Talk page message" row, but we deliberately don't let peo... [22:51:14] 3Collaboration-Team-Current, 10Flow: When deleting Flow topic or post, contributions should appear in DeletedContributions - https://phabricator.wikimedia.org/T118024#1790150 (10Mattflaschen) [22:51:59] 3Collaboration-Team-Current, 10Flow: When deleting Flow topic or post, contributions should appear in DeletedContributions - https://phabricator.wikimedia.org/T118024#1789656 (10Mattflaschen) Maybe a regression from https://gerrit.wikimedia.org/r/#/c/248314/2 . [22:53:18] quiddity, make a bug specifically about Urdu being wrong for JS. Probably easier to fix. [22:53:27] k, ty [22:56:43] mooey|away: i fixed your patch [22:57:02] https://gerrit.wikimedia.org/r/#/c/237509/5..6/resources/mobile.notifications.overlay/NotificationsOverlay.js was the issue :) [22:58:15] jdlrobson: Ha. :-) [22:58:32] jdlrobson: All these directories getting in the way! [23:06:16] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Urdu translations of elapsed timestamps in Flow, change back to English once JS finishes loading - https://phabricator.wikimedia.org/T118044#1790183 (10Quiddity) 3NEW [23:38:55] quiddity: Pretty sure that's the same cause as the bug about the timestamp translation changing (not to English, but still to a different string) in ... Latvian I think? [23:39:58] Oh looks like I was thinking of https://phabricator.wikimedia.org/T110934, which I duped to https://phabricator.wikimedia.org/T111596 , which you found [23:45:39] I'm probably going to take a break in a half-hour or so, get an early dinner, then come back on late.