[00:05:25] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1780222 (10Mattflaschen) [00:05:33] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1780227 (10Mattflaschen) 5Open>3Resolved [00:05:34] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#1780228 (10Mattflaschen) [00:07:48] jdlrobson, guess what I just did.... [00:11:25] jdlrobson, https://gerrit.wikimedia.org/r/#/c/237509/ (beware, it depends on a commit stack in Echo before it can be merged, but that should revive this commit) [00:26:14] 6Collaboration-Team-Backlog, 10Echo: Echo: flyout jumps right when talk label changes after viewing user-edit-talk notification - https://phabricator.wikimedia.org/T117635#1780324 (10Legoktm) 3NEW [00:43:48] matt_flaschen: Special:WhatLinksHere gets the links to Talk pages from where? It certainly not from pagelinks table... [00:47:32] etonkovidova, it is from there (for simple links). Are you getting unexpected results looking at the table? [00:48:26] 6Collaboration-Team-Backlog, 10Echo: Echo: flyout jumps right when talk label changes after viewing user-edit-talk notification - https://phabricator.wikimedia.org/T117635#1780412 (10Mooeypoo) Popup. [00:48:36] haha [00:48:42] :) [00:50:52] 6Collaboration-Team-Backlog, 10Echo: Echo: flyout jumps right when talk label changes after viewing user-edit-talk notification - https://phabricator.wikimedia.org/T117635#1780414 (10Mooeypoo) More to the point, though, this is going to be a bit complicated to fix, because the popup is positioned relative to t... [00:51:17] matt_flaschen: I simply do not see it with select * from pagelinks where pl_title= 'Talk:ET24'; Empty set [00:53:21] etonkovidova, pl_title is only the part after the colon ('ET24'). [00:53:31] mooeypoo: yayyyy! [00:53:47] etonkovidova: You need pt_namespace=1 AND pt_title='ET24'; to get Talk:ET24 [00:54:02] RoanKattouw: thx [00:54:10] Because Talk: is Talk: in English but Diskussion: in German etc, so namespaces are represented with numbers [00:54:20] And like Roan said, pl_namespace is 1 (you can get namespace numbers from https://phabricator.wikimedia.org/diffusion/MW/browse/master/includes/Defines.php;f0ec6a11c90aec034c31a9f43ea7254e02801fb4$54 ). [00:54:37] pl_ not pt_ [00:54:53] You can also get namespace number from wgNamespaceNumber in JavaScript. [00:54:54] Ugh right,sorry [00:54:55] pl_ [00:58:17] (03PS4) 10Mattflaschen: Use flow- prefix for the CSS classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 [01:02:33] (03PS9) 10Mattflaschen: Fix history pagination and give user the number of entries they requested [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) [01:04:44] (03CR) 10Mattflaschen: "I can't reproduce that in either sort order with or without action=purge." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen) [01:06:25] ^ Can someone else test that? [01:06:30] https://gerrit.wikimedia.org/r/245621 [01:13:47] I will once I finish reviewing this other pathc [01:16:32] (03PS6) 10Mattflaschen: Import Flow data dump [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie) [01:17:22] Thanks [01:19:41] (03CR) 10Mattflaschen: "Also, I get:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [01:31:12] Breaking for dinner [01:34:09] (03CR) 10TTO: "Why create a separate import process for Flow, when you could just use the ImportHandleToplevelXMLTag hook to allow MW core to handle Flow" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie) [01:58:52] 6Collaboration-Team-Backlog, 10Echo: Echo: flyout jumps right when talk label changes after viewing user-edit-talk notification - https://phabricator.wikimedia.org/T117635#1780632 (10Legoktm) We could wait until it closes and then adjust the text? That might still causes issues with the user page link jumping.... [02:58:40] (03CR) 10Mattflaschen: "That's a good question, which we'll have to look at when Matthias gets back." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie) [03:36:56] Heading home. [05:17:53] https://www.getflow.com/ [05:18:23] (03CR) 10Mattflaschen: [C: 04-1] "Looks good overall." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie) [05:20:41] (03CR) 10Mattflaschen: "Note regarding escaping, and 'id' attribute." (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [06:20:15] (03CR) 10Grunny: [C: 031] "I'm not sure <%- mw.msg('foo') %> versus <%= mw.message( 'foo' ).escaped() %> matters too much as they are both being escaped at the poin" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250832 (owner: 10Catrope) [10:41:35] 6Collaboration-Team-Backlog, 10Echo, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#1781222 (10Pginer-WMF) 3NEW [10:43:26] 6Collaboration-Team-Backlog, 10Echo, 7Epic, 7WorkType-NewFunctionality: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#1781233 (10Pginer-WMF) [10:55:19] 6Collaboration-Team-Backlog, 10Echo, 7WorkType-NewFunctionality: Cross-notification settings - https://phabricator.wikimedia.org/T117670#1781238 (10Pginer-WMF) 3NEW [10:55:46] 6Collaboration-Team-Backlog, 10Echo, 7Design, 7WorkType-NewFunctionality: Define Cross-notification settings - https://phabricator.wikimedia.org/T117670#1781246 (10Pginer-WMF) [10:56:00] 6Collaboration-Team-Backlog, 10Echo, 7Design, 7WorkType-NewFunctionality: Define Cross-wiki Notifications settings - https://phabricator.wikimedia.org/T117670#1781238 (10Pginer-WMF) [10:58:11] 6Collaboration-Team-Backlog, 10Echo, 7Epic, 7WorkType-NewFunctionality: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#1781260 (10Pginer-WMF) [14:05:44] (03PS1) 10Bartosz Dziewoński: Recognize ?action=edit§ion=new URLs and redirect to the new topic form [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250959 (https://phabricator.wikimedia.org/T107637) [14:06:59] (03CR) 10Bartosz Dziewoński: "This is *ENTIRELY UNTESTED*, I don't have Flow set up locally. But somebody asked me to implement it, it's probably not a high priority fo" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250959 (https://phabricator.wikimedia.org/T107637) (owner: 10Bartosz Dziewoński) [14:11:47] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization: Echo notification icons should be properly themed in MonoBook - https://phabricator.wikimedia.org/T112290#1781705 (10Esanders) [14:29:59] 3Collaboration-Team-Current, 10Flow: Edit post and Summarize fail in firefox - https://phabricator.wikimedia.org/T117698#1781754 (10SBisson) 3NEW [14:48:20] (03PS1) 10Esanders: Separate skin specific styles and improve Monobook appearance [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250969 (https://phabricator.wikimedia.org/T112290) [14:50:40] 6Collaboration-Team-Backlog, 10Echo, 10UI-Standardization, 5Patch-For-Review: Echo notification icons should be properly themed in MonoBook - https://phabricator.wikimedia.org/T112290#1781832 (10Esanders) | Before | After | |{F2914227,size=full} |{F2914222,size=full} | [15:17:43] (03PS1) 10Sbisson: Browser tests fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250973 [16:04:25] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests-Infrastructure, 5Patch-For-Review: Fix or delete failing Flow browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94153#1782023 (10zeljkofilipin) 5Resolved>3Open Hm, as far as I can see, all Flow browser test jobs are still failing: https... [16:17:15] Yay, ptwikibooks finished [16:17:40] Oh, but crap, I forgot to reapply the live hack for /Arquivo LQT 1 so now the archive pages for the second run are all called /LQT Archive 1 :( [16:24:46] Posted at https://pt.wikibooks.org/w/index.php?title=Topic:Spfa84s3kbw3x1ei&topic_showPostId=ss2k563e3t50w7we#flow-post-ss2k563e3t50w7we [16:31:10] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#1782166 (10Catrope) >>! In T113682#1775974, @Catrope wrote: > Full run aborted because we want "/Arquivo LQT 1" instead of "/LQT Archive 1": P2270. Started a second... [16:34:42] matt_flaschen: Is UUID generation deterministic across import runs? [16:35:10] matt_flaschen: I ask because the ptwikibooks import has a number of duplicate UUID errors [16:36:05] 6Collaboration-Team-Backlog, 10Flow, 10OOjs-UI, 10VisualEditor, and 3 others: Duplicate icons: 'source' (in VE) and 'WikiText' - https://phabricator.wikimedia.org/T111038#1782178 (10Jdforrester-WMF) [16:36:54] It seems the answer might be no, because the different runs gave me different conflicting UUIDs [16:36:59] Anyway, this is very concerning [16:37:33] There were a total of 15 UUID conflicts across the 3 import runs [16:38:38] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#1782190 (10Catrope) Looking at the logs I noticed there were a few duplicate UUID failures, so I'm rerunning the conversion one more time to try and clean up those... [16:42:23] * RoanKattouw tries creating a 14MB Phabricator pastie [16:43:04] ...and it 503ed [16:59:42] RoanKattouw, yeah, I started using people.wikimedia.org when they got big. [17:01:05] RoanKattouw, no, it's not deterministic. It uses lots of random numbers: https://phabricator.wikimedia.org/diffusion/EFLW/browse/master/includes/Import/Importer.php;d07c26b597c71c82de61e845ce9fc753d020119e$143 [17:02:22] I just noticed "The import process needs to identify collision failures reported by the database and re-try importing that item with another generated uid." [17:03:14] Oh, good idea [17:03:17] OK, yeah I figured [17:03:22] I'm rerunning in the hopes that'll fix it [17:03:32] But this suggests we will get UUID conflicts from organic traffic as well [17:03:38] Unless there is workaround logic in those code paths [17:04:03] if my memory serves in the past 'identify and re-run' amounted to letting the transactions fail so nothing is moved, then re-running the script [17:04:12] so, yea :) [17:04:15] RoanKattouw, the historical implementation is pretty different. [17:04:16] 6Collaboration-Team-Backlog, 10Echo, 10MobileFrontend: Check Special:Notifications logging for MobileFrontend - https://phabricator.wikimedia.org/T112789#1782343 (10Jdlrobson) Is it working as intended? [17:05:46] For normal, we just rely on core's newTimestampedUID88, for historical we use custom time and custom rotations. [17:07:18] How is the difference between "normal" and "historical" defined? [17:08:59] RoanKattouw, historical link is above, normal link is at https://phabricator.wikimedia.org/diffusion/EFLW/browse/master/includes/Model/UUID.php;d07c26b597c71c82de61e845ce9fc753d020119e$149 [17:10:15] RoanKattouw, which logs did you see the UID failures in? The main ones, or elsewhere (fluorine?)? [17:11:32] (03CR) 10Mattflaschen: "There's also the idea of making it an Import backend (alongside LQT). I'm not sure we'd gain any benefit from that, though. This is prob" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie) [17:11:56] The main ones [17:12:08] How do I put things on people.wm.o again? [17:12:16] I haven't used my web homedir since the noc.wm.o / fenari days [17:13:31] (Since the logs I saw this in are 14MB and 8MB respectively, so I can't put them in Phabricator) [17:15:36] RoanKattouw, /home/catrope/public_html on terbium. [17:16:12] Thanks [17:16:27] Conveniently, my files are already on terbium [17:17:09] matt_flaschen: https://people.wikimedia.org/~catrope/ [17:17:22] (#4 is incomplete because it's still running) [17:17:34] Thanks. I can already grep through them on terbium though. :) [17:17:46] #2 and #3 contain errors, #3 more than #2 [17:17:47] I grepped on UID before and didn't see it, grepping on exception found it though. [17:17:48] Oh right lol [17:17:58] grep '1062 Duplicate' ~/2015-11-02-ptwikibooks-full* [17:18:01] is what I did [17:18:31] For MediaWiki.org conversion my policy was to grep on warning, exception, error, and fatal. [17:18:54] Right [17:19:00] I've only grepped for error so far [17:28:07] 6Collaboration-Team-Backlog, 10Thanks: Thanks given via mobile are not shown on desktop history page - https://phabricator.wikimedia.org/T61207#1782603 (10Jdlrobson) [17:28:14] 6Collaboration-Team-Backlog, 10Thanks: Thanks given via mobile are not shown on desktop history page - https://phabricator.wikimedia.org/T61207#597611 (10Jdlrobson) Code is in Thanks now [17:30:27] Going to go into the co-working place. [17:31:03] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Mobile web - Flow issues (tracking) - https://phabricator.wikimedia.org/T93430#1782644 (10Jdlrobson) [17:31:50] 6Collaboration-Team-Backlog, 10Flow: an inline external link in square brackets without a title doesn't appear in Flow pages on mobile web - https://phabricator.wikimedia.org/T93856#1782645 (10Jdlrobson) [17:53:42] 6Collaboration-Team-Backlog, 10Echo, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#1782781 (10Jdforrester-WMF) I like "Ask to enable from the panel" far more than the others, though we might want to tweak the language. [18:11:54] (03PS2) 10Legoktm: [WIP] Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 [18:12:08] (03PS3) 10Legoktm: [WIP] Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 [18:14:35] Destroyed my VM. It's now rebuilding. I want to test the dump patch with a full-wiki import. [18:14:43] Haven't done a full rebuild in a while... should be interesting. [18:15:20] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 (owner: 10Legoktm) [18:25:43] matt_flaschen, oy, that doesn't sound like fun [18:27:10] (03PS4) 10Legoktm: [WIP] Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 [18:29:53] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Revert notifications in Echo on Wikidata should display label as well as Q id - https://phabricator.wikimedia.org/T116762#1782983 (10Legoktm) Should Wikibase be using a Linker hook or something for this? So it works... [18:31:19] (03CR) 10Legoktm: [C: 032] Add a presentation model for Echo "Welcome" notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250596 (https://phabricator.wikimedia.org/T116843) (owner: 10Mooeypoo) [18:31:57] (03CR) 10Legoktm: "PS4: Now exposed via the API!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 (owner: 10Legoktm) [18:32:58] (03CR) 10jenkins-bot: [V: 04-1] [WIP] Track what wikis a user has unread notifications on [extensions/Echo] - 10https://gerrit.wikimedia.org/r/248905 (owner: 10Legoktm) [18:34:36] (03Merged) 10jenkins-bot: Add a presentation model for Echo "Welcome" notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250596 (https://phabricator.wikimedia.org/T116843) (owner: 10Mooeypoo) [18:38:31] 3Collaboration-Team-Current, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 7Blocked-on-Operations, and 2 others: Migrate Flow content to new separate logical External Store - https://phabricator.wikimedia.org/T106363#1783046 (10Mattflaschen) [18:43:44] (03CR) 10Catrope: [C: 032] Browser tests fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250973 (owner: 10Sbisson) [18:47:00] (03Merged) 10jenkins-bot: Browser tests fixes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250973 (owner: 10Sbisson) [19:27:50] 6Collaboration-Team-Backlog, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Add ref_id to flow_wiki_ref and flow_ext_ref (DBA phase 1) - https://phabricator.wikimedia.org/T117783#1783387 (10Mattflaschen) 3NEW a:3jcrespo [19:28:46] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Deploy artificial primary key reference change to all wikis simultaneously - https://phabricator.wikimedia.org/T117785#1783412 (10Mattflaschen) 3NEW [19:28:54] 6Collaboration-Team-Backlog, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Add ref_id to flow_wiki_ref and flow_ext_ref (DBA phase 1) - https://phabricator.wikimedia.org/T117783#1783387 (10Mattflaschen) [19:28:55] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Deploy artificial primary key reference change to all wikis simultaneously - https://phabricator.wikimedia.org/T117785#1783412 (10Mattflaschen) [19:29:42] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Run maintenance/FlowPopulateRefId.php on all production wikis - https://phabricator.wikimedia.org/T117786#1783423 (10Mattflaschen) 3NEW [19:29:47] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Run maintenance/FlowPopulateRefId.php on all production wikis - https://phabricator.wikimedia.org/T117786#1783423 (10Mattflaschen) [19:29:48] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Deploy artificial primary key reference change to all wikis simultaneously - https://phabricator.wikimedia.org/T117785#1783412 (10Mattflaschen) [19:30:00] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Deploy artificial primary key reference change to all production wikis simultaneously - https://phabricator.wikimedia.org/T117785#1783433 (10Mattflaschen) [19:31:48] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Make ref_id of flow_wiki_ref and flow_ext_ref not null and PK (DBA phase 2) - https://phabricator.wikimedia.org/T117787#1783435 (10Mattflaschen) 3NEW a:3matthiasmullie [19:32:35] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Make ref_id of flow_wiki_ref and flow_ext_ref not null and PK (DBA phase 2) - https://phabricator.wikimedia.org/T117787#1783435 (10Mattflaschen) a:5matthiasmullie>3jcrespo [19:32:47] 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Make ref_id of flow_wiki_ref and flow_ext_ref not null and PK (DBA phase 2) - https://phabricator.wikimedia.org/T117787#1783435 (10Mattflaschen) [19:33:13] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Deploy artificial primary key reference change to all production wikis simultaneously - https://phabricator.wikimedia.org/T117785#1783452 (10Mattflaschen) [19:33:28] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Run maintenance/FlowPopulateRefId.php on all production wikis - https://phabricator.wikimedia.org/T117786#1783423 (10Mattflaschen) [19:33:29] 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Make ref_id of flow_wiki_ref and flow_ext_ref not null and PK (DBA phase 2) - https://phabricator.wikimedia.org/T117787#1783435 (10Mattflaschen) [19:36:35] 6Collaboration-Team-Backlog, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Add ref_id to flow_wiki_ref and flow_ext_ref (DBA phase 1) - https://phabricator.wikimedia.org/T117783#1783479 (10Mattflaschen) [19:37:00] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1783484 (10Mattflaschen) >>! In T109676#1768400, @jcrespo wrote: > @Mattflaschen, let's try to do formall... [19:39:43] LOL, when I first opened http://127.0.0.1:8080/wiki/Talk:Sandbox after re-upping (no errors!) it was LQT. [19:39:46] Forgot about that setting. [19:42:34] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1783503 (10jcrespo) > Done, except DBA apparently doesn't exist yet, so I used Database. You did well. I... [19:44:06] 6Collaboration-Team-Backlog, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Add ref_id to flow_wiki_ref and flow_ext_ref (DBA phase 1) - https://phabricator.wikimedia.org/T117783#1783508 (10jcrespo) I will probably do this tomorrow (Thursday), unless something more urgent happens. [20:08:33] 3Collaboration-Team-Current, 10Flow, 7Blocked-by-schema-change, 7Database, and 2 others: Add ref_id to flow_wiki_ref and flow_ext_ref (DBA phase 1) - https://phabricator.wikimedia.org/T117783#1783616 (10Mattflaschen) [20:24:31] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1783679 (10Mattflaschen) p:5Unbreak!>3High [20:26:46] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Log notification impressions and clicks again - https://phabricator.wikimedia.org/T114833#1783684 (10Mattflaschen) What is this blocked on? [20:27:07] legoktm: when you have a moment [20:32:37] 3Collaboration-Team-Current, 10Flow: Edit post and Summarize fail in firefox - https://phabricator.wikimedia.org/T117698#1783699 (10Mattflaschen) a:3Mattflaschen [20:36:25] stephanebisson: what's up? [20:36:35] legoktm: On the new-topic notification, the first line has the text of the new topic, the second line has " created a new topic on ", and the 3rd line has a timestamp. Would you consider the second line the body text? [20:38:00] stephanebisson: yes [20:38:23] legoktm: I guess I should // @todo body text [20:39:03] unless you already have it in a patch [20:39:15] I don't :/ [20:39:53] I'll upload it for you to review [20:42:14] (03PS1) 10Sbisson: Output body text in flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251119 [20:46:25] legoktm: ^ [20:58:00] stephanebisson: I don't see any existing mw-echo-body class? https://phabricator.wikimedia.org/P2276 [20:58:11] (that's a random notification I have on mw.o) [21:01:10] legoktm: not used yet, I'll remove it and add it back when we want to address the styling [21:02:14] legoktm: also, what's the proper way to escape the body text in the formatter? And what's the proper way to return a $msg as string in getBodyText? [21:04:27] hm [21:04:43] so getBodyText() is documented as @return bool|Message [21:04:45] it should probably be named getBodyMessage() actually [21:05:03] so if getBody*() returns a Message object, the formatter should call ->escaped() / parse() on it [21:05:05] right [21:06:17] escaped() or parse()? [21:08:57] parse() probably since I see bold text... [21:10:58] (03PS2) 10Sbisson: Output body text in flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251119 [21:17:56] stephanebisson: do you want to rename it to getBodyMessage() in that patch? Nothing is implementing that yet [21:18:06] sure [21:20:13] (03PS3) 10Sbisson: Output body text in flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251119 [21:21:03] (03PS4) 10Sbisson: Output body text in flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251119 [21:21:47] (03PS5) 10Sbisson: Output body in flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251119 [21:22:37] (03CR) 10Legoktm: [C: 04-1] Output body in flyout (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251119 (owner: 10Sbisson) [21:24:58] (03PS6) 10Sbisson: Output body in flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251119 [21:27:27] (03CR) 10Legoktm: [C: 032] Output body in flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251119 (owner: 10Sbisson) [21:28:10] (03Abandoned) 10Legoktm: Add PHP CodeSniffer tests [extensions/Echo] - 10https://gerrit.wikimedia.org/r/242934 (owner: 10Siebrand) [21:31:14] (03Merged) 10jenkins-bot: Output body in flyout [extensions/Echo] - 10https://gerrit.wikimedia.org/r/251119 (owner: 10Sbisson) [21:41:29] * mooeypoo stares at legoktm [21:41:30] popup. [21:41:45] that class is named flyout! [21:42:00] Yes, and if we only knew the person who named it... [21:43:22] legoktm, You know those fluffy kids' toys you can press on their bellies and they sing? and then you end up having to throw the damn batteries away because you get tired of the same response over and over? I feel like I'm that fluffy toy, with a popup button. [21:43:24] 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, and 4 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#1783900 (10ssastry) subbu: Doing the same thing in every client sucks. subbu: Also, the name in... [21:57:02] legoktm: Looking forward to Yet Another Legoktm RfC? :-) [21:59:54] heh [21:59:57] this one isn't mine :P [22:00:17] legoktm: Composer and not you? [22:00:20] !? [22:00:43] thank goodness [22:23:43] 6Collaboration-Team-Backlog, 10Echo, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#1783997 (10Quiddity) If I understand correctly, Pau's examples are based on these steps: * As a user, I have enabled the BetaFeature on (fo... [22:24:59] 6Collaboration-Team-Backlog, 10Echo, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#1784002 (10Jdforrester-WMF) > If that is accurate, then we need to update the proposed blurb in {T114237} to include language such as: >>... [22:27:17] 6Collaboration-Team-Backlog, 10Echo: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#1784006 (10Quiddity) [22:34:15] 6Collaboration-Team-Backlog, 10Flow: Moving topics between boards - https://phabricator.wikimedia.org/T88140#1784017 (10Catrope) p:5Normal>3High [22:36:13] 6Collaboration-Team-Backlog, 10Echo: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#1784020 (10Quiddity) [22:38:26] 6Collaboration-Team-Backlog, 10Echo: Present cross-wiki notifications as a beta feature to users - https://phabricator.wikimedia.org/T114237#1784036 (10Quiddity) [22:41:46] legoktm: Is the body included in the flyout in the old system? I thought the body was special-page-only? [22:42:23] it is [22:42:35] matt_flaschen: So, I reran the ptwikibooks conversion again, and it failed again, with UUID errors for 9 topics [22:43:35] matt_flaschen: At this point I don't think rerun+pray is a good strategy, because it takes a long time and has failed twice now. Perhaps you can take a closer look? You should be able to grep the failures out of my -4 log (in my homedir and on people.wm.o) [22:43:52] RoanKattouw: e.g. https://i.imgur.com/ZhIELTn.png [22:44:06] Also we should make sure this doesn't affect prod later, but I suspect that perhaps this is due to certain timestamps being very popular through artificial phenomena specific to the import process [22:44:20] Oh, I see [22:44:56] RoanKattouw, okay, I'm working on fixing edit post, though, which is broken in production. [22:45:04] So I would like to finish that first. [22:45:13] Right, yeah, OK [22:45:20] I looked at that a bit and then I got meeting-ed [22:45:47] I got as far as "for some reason the click handlers don't take in beta (but wfm in master), and separately there's a JS error when loading the nojs URL" [22:45:55] But if it's broken in prod, yes, please focus on that [22:46:14] Will do. [22:47:38] RoanKattouw, did you use the same command as https://phabricator.wikimedia.org/P2270 for the later ones too (except for changing the output file)? [22:48:29] Yes [22:48:38] Exact same command line except for -2 vs -3 vs -4 [22:48:45] Okay, thanks. [22:48:55] But as I said, broken-in-prod comes first :) [22:52:15] 6Collaboration-Team-Backlog, 10Echo, 7WorkType-NewFunctionality: Invite users to enable Cross-wiki Notifications beta feature - https://phabricator.wikimedia.org/T117669#1784065 (10Catrope) >>! In T117669#1783997, @Quiddity wrote: > I.e. This invitation would //not// be shown to a user, unless/until they hav... [23:22:21] 3Collaboration-Team-Current, 10Flow: Fix en:Wikipedia_talk:Flow/Developer_test_page - https://phabricator.wikimedia.org/T117812#1784108 (10Mattflaschen) [23:23:47] 6Collaboration-Team-Backlog, 10Flow: Ensure Flow board can be restored even when it's not the most recent revision - https://phabricator.wikimedia.org/T117813#1784112 (10Mattflaschen) 3NEW [23:24:12] 3Collaboration-Team-Current, 10Flow: Fix en:Wikipedia_talk:Flow/Developer_test_page - https://phabricator.wikimedia.org/T117812#1784123 (10Krenair) ```2015-11-04 18:49:37 mw1113 enwiki exception ERROR: [67a438e3] /w/index.php?title=Special:Undelete&action=submit Flow\Exception\FlowException from line 76 of /... [23:36:57] mooeypoo, what's the difference between: [23:37:33] modules/flow/ui/widgets/editor/editors/mw.flow.ui.AbstractEditorWidget.js and flow/ui/widgets/editor/mw.flow.ui.EditorWidget.js [23:38:13] EditorWidget is the parent of the switcher and such? [23:38:18] And the other is an actual editor? [23:41:05] matt_flaschen, yes. Bad naming, I know :\ sorry [23:41:20] the EditorWidget is the general widget we embed everywhere.. it includes the switcher and controls widget, etc [23:41:51] the AbstractEditorWidget defines the structure of all editors we have (VisualEditorWidget / WikitextEditorWidget / whatever we may have) [23:43:35] This is the exact same naming the old editor system has. I even wrote a comment about it. [23:43:54] It raises the question whether this is a predisposition of all humans writing editor abstractions, or merely culture... [23:44:20] That was supposed to be "same naming problem"... [23:46:40] Indeed