[00:00:42] RoanKattouw, what do you think, should I do it now, or wait until it's done? It should be okay to do now as long as the source store is valid JSON (which it should always be anyway) and it's definitely done that page. [00:01:07] What are you going to do, copy the source store, modify it, and run something with the modified copy? [00:01:12] (03PS1) 10Mooeypoo: Add a presentation model for Echo "Welcome" notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250596 (https://phabricator.wikimedia.org/T116843) [00:01:20] RoanKattouw, yeah. [00:01:26] Sounds good to me [00:01:30] legoktm, probably the stubbiest presentation model EVER. [00:01:34] You know better than me how risky / safe it is [00:01:52] (03CR) 10Krinkle: [C: 032] Use startAtomic/endAtomic to avoid breaking transactions [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250310 (owner: 10Aaron Schulz) [00:02:10] I'll grep through the log and make sure it's done. [00:02:12] (03PS2) 10Mooeypoo: Add a presentation model for Echo "Welcome" notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250596 (https://phabricator.wikimedia.org/T116843) [00:02:55] RoanKattouw, you're currently running 2015-11-02-ptwikibooks-full-2.log ? [00:03:02] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review: Write presentation models for notifications in Echo - https://phabricator.wikimedia.org/T116843#1776143 (10Mooeypoo) [00:03:07] Yes [00:06:14] (FYI, I think it's because that's the last/only page in full.log and it was interrupted before doing useliquidthreads:0). [00:06:39] The log confirms it's done. [00:11:26] in the end, how was the namespace redirect implemented? [00:11:52] Thread still redirects to Tópico [00:11:54] Flow uses Topic. [00:12:42] I'm going to wait. [00:12:56] (03Merged) 10jenkins-bot: Use startAtomic/endAtomic to avoid breaking transactions [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250310 (owner: 10Aaron Schulz) [00:13:50] got it [00:14:04] have to go now.. [00:16:18] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5): Cannot post a topic after Flow board was re-sorted - https://phabricator.wikimedia.org/T117238#1776181 (10Etonkovidova) Checked in betalabs. [00:19:51] RoanKattouw, but I'm going to rotate them since I plan to delete one, and I don't want people posting to it in the meantime: [00:20:12] https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas -> https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas/Temporary [00:20:22] https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas/Arquivo_LQT_1 -> https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas [00:23:10] RoanKattouw, do you have sysop rights there? [00:23:45] Probably [00:24:00] Yeah I can move things [00:24:18] Do you need me to execute the moves you just outlined? [00:33:41] 6Collaboration-Team-Backlog, 10Flow: Flow: Topic bar CSS defeats its active button behavior - https://phabricator.wikimedia.org/T60800#1776235 (10Spage) 5Open>3Invalid a:3Spage These days the `.flow-topic-titlebar` is no longer a `mw-ui-button` and doesn't always collapse/expand the topic's posts, so I'm... [00:33:56] matt_flaschen: You want me to perform those moves for you? [00:34:59] 6Collaboration-Team-Backlog, 10Flow, 7Easy: Better communicate that resolved topics can be expanded - https://phabricator.wikimedia.org/T103866#1401106 (10Spage) This happened to me, I often click on the wrong thing. I can only expand if I click after the text in the h2, but not too close to the watch star.... [00:35:03] RoanKattouw, yeah, but there's going to be one more I think. One sec. [00:37:45] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1776259 (10Mattflaschen) 3NEW a:3Mattflaschen [00:38:50] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1776259 (10Mattflaschen) [00:39:05] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1776259 (10Mattflaschen) [00:39:42] RoanKattouw, yeah, can you do 1, 2, 3 of https://phabricator.wikimedia.org/T117514 being sure not to leave a redirect? [00:41:24] matt_flaschen: I probably shouldn't move the talk pages, right? [00:43:39] RoanKattouw, yeah, there's only one, and we'll just leave it there. [00:44:41] matt_flaschen: OK, 1-3 done [00:44:52] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1776304 (10Catrope) 1-3 done [00:46:19] RoanKattouw, thanks, looks good. [00:46:38] That way if someone posts overnight, it should be fine. [00:46:57] Unless they post on /Temporary but there's no reason they would do that for real. [00:47:32] Oh we need to leave it like this until the conversion finishes? [00:48:28] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Extension-setup, 5Patch-For-Review: Enable Flow on pt.wikibooks - https://phabricator.wikimedia.org/T114540#1776316 (10Etonkovidova) https://pt.wikibooks.org/w/api.php?action=query&meta=siteinfo&siprop=namespaces&formatversion=2 returns False for ``` "90":... [00:50:28] RoanKattouw, I was thinking we could. My only concerns if I do it now are if somehow the script circles back and tries to do this itself (I don't think it would but I would need to verify how Namespaceiterator works) and that I'm not sure whether I should start this at 8 PM. [00:51:05] Right [00:51:13] Yeah it's fine, I was just clarifying [00:51:29] Okay [01:31:54] (03CR) 10Mattflaschen: Dump Flow data (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [02:43:02] (03PS10) 10Mattflaschen: Dump Flow data [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [02:49:25] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1776549 (10Mattflaschen) Or we could just re-import the whole page, then delete the duplicate topics. Not as elegant, but les... [03:06:57] (03CR) 10Mattflaschen: "Looks really good." (0314 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [03:07:12] (03CR) 10Mattflaschen: [C: 04-1] "See patch set 9." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie) [06:02:49] (03PS1) 10Krinkle: LocalCache: Fix bad type hint of getTargets() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250631 [06:15:46] (03PS1) 10Krinkle: Migrate LocalCache from MapCacheLRU to HashBagOStuff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 [06:19:28] (03CR) 10jenkins-bot: [V: 04-1] Migrate LocalCache from MapCacheLRU to HashBagOStuff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 (owner: 10Krinkle) [06:23:52] (03PS2) 10Krinkle: Migrate LocalCache from MapCacheLRU to HashBagOStuff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 [06:24:19] (03PS3) 10Krinkle: Migrate LocalCache from MapCacheLRU to HashBagOStuff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 [06:50:33] (03PS4) 10Krinkle: Migrate LocalCache from MapCacheLRU to HashBagOStuff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 [06:53:06] (03CR) 10jenkins-bot: [V: 04-1] Migrate LocalCache from MapCacheLRU to HashBagOStuff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 (owner: 10Krinkle) [07:29:19] 6Collaboration-Team-Backlog, 10Flow, 7Easy: Better communicate that resolved topics can be expanded - https://phabricator.wikimedia.org/T103866#1776640 (10Pginer-WMF) >>! In T103866#1570594, @Pginer-WMF wrote: > From the comments I read about the issue, the problem does not seem to be about identifying the t... [08:48:17] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Exclude deleted topics/posts from flow-reportcard stats - https://phabricator.wikimedia.org/T116797#1776688 (10matthiasmullie) Sorry for the confusion. The timestamp format should also include hours, minutes, seconds, like: 20151018000000. [09:16:46] (03CR) 10Aaron Schulz: [C: 032] LocalCache: Fix bad type hint of getTargets() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250631 (owner: 10Krinkle) [09:18:14] 6Collaboration-Team-Backlog, 10Flow: Special:Watchlist contains &curid=0&diff=0&oldid=0 "diffs" - https://phabricator.wikimedia.org/T117528#1776721 (10Nemo_bis) [09:22:36] (03Merged) 10jenkins-bot: LocalCache: Fix bad type hint of getTargets() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250631 (owner: 10Krinkle) [09:54:08] (03CR) 10Aaron Schulz: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 (owner: 10Krinkle) [09:57:25] (03CR) 10Aaron Schulz: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 (owner: 10Krinkle) [10:16:31] (03CR) 10Aaron Schulz: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 (owner: 10Krinkle) [10:21:07] (03CR) 10Aaron Schulz: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 (owner: 10Krinkle) [10:29:17] (03CR) 10Gilles: [C: 031] Make EchoEvent::create() a no-op if the DB is read-only [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250309 (owner: 10Aaron Schulz) [10:45:48] 6Collaboration-Team-Backlog, 10Flow: Prefill loads all template contents, including elements - https://phabricator.wikimedia.org/T116002#1776853 (10Trizek-WMF) [10:45:51] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, 7WorkType-NewFunctionality: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1776854 (10Trizek-WMF) [11:09:04] 6Collaboration-Team-Backlog, 10Echo, 7Performance: Echo DB writes on page views - https://phabricator.wikimedia.org/T117531#1776881 (10aaron) 3NEW [11:27:46] (03CR) 10Gilles: [C: 032] Migrate LocalCache from MapCacheLRU to HashBagOStuff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 (owner: 10Krinkle) [11:30:37] (03Merged) 10jenkins-bot: Migrate LocalCache from MapCacheLRU to HashBagOStuff [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250636 (owner: 10Krinkle) [15:36:37] 3Collaboration-Team-Current, 10Flow: Main topic list pagination can only paginate at most 500 topics - https://phabricator.wikimedia.org/T114456#1777438 (10SBisson) [15:36:38] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Give the user the number of history items they asked for - https://phabricator.wikimedia.org/T108291#1777439 (10SBisson) [15:37:11] 3Collaboration-Team-Current, 10Flow: Main topic list pagination can only paginate at most 500 topics - https://phabricator.wikimedia.org/T114456#1695958 (10SBisson) Will resume work on this once {T108291} (https://gerrit.wikimedia.org/r/#/c/245621) is merged [15:41:22] (03CR) 10Sbisson: "I get a DB error when I try to view a Flow board with this patch." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen) [16:05:55] 3Collaboration-Team-Current, 10Echo, 10Flow: Write presentation models for notifications in Flow - https://phabricator.wikimedia.org/T116845#1777581 (10SBisson) a:3SBisson [16:58:51] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation, 7Technical-Debt, 7WorkType-Maintenance: Write presentation models for notifications in ContentTranslation - https://phabricator.wikimedia.org/T116852#1777809 (10Amire80) [17:03:14] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: Invalid language code "nl_nl" - https://phabricator.wikimedia.org/T116890#1777837 (10Legoktm) >>! In T116890#1770353, @Krinkle wrote: > Part of this would be addressed by 3b829b4385e... [17:04:12] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: Invalid language code "nl_nl" - https://phabricator.wikimedia.org/T116890#1777845 (10Legoktm) a:3Krinkle [17:11:38] stephanebisson: hey Stephane, would you mind helping to review some old browser-test tasks related to Flow and Echo? [17:12:13] i'm pretty sure they aren't relevant anymore but i wanted to double check [17:24:24] marxarelli: sure, which ones? [17:24:38] stephanebisson: https://phabricator.wikimedia.org/maniphest/query/rOVtNs5ascwA/#R [17:24:52] and https://phabricator.wikimedia.org/maniphest/query/Q1UX7AwND3VH/#R [17:26:50] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Flow: topic created by logged in user was stored as created by anon user. - https://phabricator.wikimedia.org/T75926#1777947 (10SBisson) 5Open>3Invalid a:3SBisson Has not been seen in a long time. Please reopen if it happens again. [17:27:12] \o/ thanks, stephanebisson [17:29:16] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Flow: logic of edit_existing browser test is broken - https://phabricator.wikimedia.org/T66082#1777966 (10SBisson) 5Open>3Invalid a:3SBisson Not relevant anymore with the current state of those tests. [17:34:24] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Flow firefox-monobook-sauce browser test has failed since Dec 5 in Reply moderation.Hiding a comment - https://phabricator.wikimedia.org/T85497#1778001 (10SBisson) 5Open>3Invalid a:3SBisson I don't know what it was but reply_moderation.feature:10 (h... [17:35:24] 6Collaboration-Team-Backlog, 10Flow, 7Performance: Saving a new topic can take >5s on beta labs - https://phabricator.wikimedia.org/T73476#1778010 (10SBisson) [17:36:18] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Flow QA: Lock post action is offscreen and browser test fails - https://phabricator.wikimedia.org/T72878#1778012 (10SBisson) 5Open>3Invalid a:3SBisson Not relevant anymore with the current state of those tests. [17:41:47] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests, 5Patch-For-Review: Fix or delete failing Flow browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94153#1778042 (10SBisson) 5Open>3Resolved Flow browser tests are being monitored on a daily basis for regression and instability. Quick chan... [17:45:35] 6Collaboration-Team-Backlog, 10Echo, 10Flow, 10Browser-Tests: mediawiki_api client.create_page fails on Flow board - https://phabricator.wikimedia.org/T71321#1778069 (10SBisson) 5Open>3Invalid a:3SBisson Not relevant anymore with the current state of those tests. The echo tests are being completely r... [17:46:05] marxarelli: I don't know what to do with the last 3 [17:47:52] 3Collaboration-Team-Current, 10Flow, 10Browser-Tests, 7WorkType-NewFunctionality: Make Flow browser tests stable - https://phabricator.wikimedia.org/T109785#1778081 (10SBisson) 5Open>3declined a:3SBisson This is being worked on on a daily basis. [17:48:02] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests, 7WorkType-NewFunctionality: Make Flow browser tests stable - https://phabricator.wikimedia.org/T109785#1778084 (10SBisson) [17:48:46] stephanebisson: no worries, we can review the rest [17:49:05] that was tremendously helpful [17:49:44] stephanebisson: re https://phabricator.wikimedia.org/T66103 are irc notification even desirable? [17:49:54] or have email notifications been sufficient? [17:50:28] marxarelli: not useful for me, I'm not even looking at the emails since I actively monitor the jobs [17:50:39] marxarelli: but I can't speak for whoever filed the task [17:53:07] i'd say it's up to whoever is currently responsible for the tests, really [17:53:35] and spagewmf isn't in this channel :) [17:54:00] I would keep it as it is for now [17:54:10] i'll comment on the task(s) [17:54:17] thanks for the review! [17:54:49] no worries, it feels good to declutter [17:58:28] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests, 7Easy: send Echo and Flow (and any Collaboration team extensions with browser tests) browser test job notices to #wikimedia-collaboration channel - https://phabricator.wikimedia.org/T66103#1778114 (10dduvall) Is this still desired by Collaboration? IRC... [18:05:45] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Sauce Labs screencast for "No JavaScript" Flow tests shows empty browser window. - https://phabricator.wikimedia.org/T86707#1778133 (10dduvall) 5Open>3Resolved a:3dduvall The description and test history suggests an intermittent issue with SauceLabs... [18:28:15] 6Collaboration-Team-Backlog, 10Flow: An image used on a Flow message is not listed on Global usage section on the Commons file page - https://phabricator.wikimedia.org/T117576#1778211 (10Trizek-WMF) 3NEW [18:33:30] 6Collaboration-Team-Backlog, 10Echo, 7Performance: Echo DB writes on page views - https://phabricator.wikimedia.org/T117531#1778249 (10Mattflaschen) I think these are inherently from read actions (e.g. visiting a topic marks that topic notification read), so probably need to use some workaround, e.g. [Enqueu... [18:39:50] 6Collaboration-Team-Backlog, 10Echo, 7Performance: Echo DB writes on page views - https://phabricator.wikimedia.org/T117531#1778313 (10aaron) Any reason not to just use DeferredUpdates::addCallableUpdate()? I see there is a comment saying it should be deferred and was wondering if there was some problem with... [18:43:13] RoanKattouw, are you alright with my latter suggestion at https://phabricator.wikimedia.org/T117514#1776549 ? [18:45:52] matt_flaschen: Sounds good to me, but I don't know how to do that either so you'd have to do it [18:46:02] Let me check if the original run is done yet [18:46:58] I know how to do it. Just force-resume that specific page with a fresh source store, then delete the duplicates. [18:47:06] I still need to revert the redirects, which I would have to do either way. [18:48:10] It's still going... [18:54:03] 6Collaboration-Team-Backlog, 10Flow, 10MobileFrontend, 7I18n: wgRevisionId is 0 for Flow pages - https://phabricator.wikimedia.org/T92296#1778410 (10Jdlrobson) p:5High>3Low [19:08:05] 6Collaboration-Team-Backlog, 10Flow, 7Documentation, 7Easy, and 2 others: documentation inconsistent with behavior - https://phabricator.wikimedia.org/T96511#1778448 (10Aklapper) What exactly is left to do in this task to change its status to resolved? Catrope's pa... [19:09:55] 6Collaboration-Team-Backlog, 10MoodBar, 7I18n, 5Patch-For-Review: GENDER support for moodbar-feedback-response-summary - https://phabricator.wikimedia.org/T99066#1778459 (10Aklapper) @Haritha28: Any plans to rework your patch? Please see T45481#1665205 [19:18:34] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Flow's administration - https://phabricator.wikimedia.org/T113582#1778491 (10Trizek-WMF) [19:18:35] 6Collaboration-Team-Backlog, 10Flow: Flow: add "change visibility" button on Special:Contributions for users that can revdel edits - https://phabricator.wikimedia.org/T65024#1778492 (10Trizek-WMF) [19:24:05] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison: Try all possible admin actions concerning Flow - https://phabricator.wikimedia.org/T116785#1778527 (10Trizek-WMF) p:5Normal>3High [19:25:33] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: Invalid language code "nl_nl" - https://phabricator.wikimedia.org/T116890#1778531 (10Krinkle) p:5Triage>3Normal [19:26:07] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: Invalid language code "nl_nl" - https://phabricator.wikimedia.org/T116890#1760970 (10Krinkle) [19:27:08] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: wgUserLanguage in JS should be valid for API (Exception: Invalid language code "nl_nl") - https://phabricator.wikimedia.org/T116890#1778534 (10Krinkle) 5Open>3Resolved [19:30:17] 6Collaboration-Team-Backlog, 10Flow, 7Documentation, 7Easy, and 2 others: documentation inconsistent with behavior - https://phabricator.wikimedia.org/T96511#1778544 (10Catrope) 5Open>3Resolved [20:20:11] 6Collaboration-Team-Backlog, 10Echo, 7Performance: Echo DB writes on page views - https://phabricator.wikimedia.org/T117531#1778940 (10Catrope) >>! In T117531#1778313, @aaron wrote: > Any reason not to just use DeferredUpdates::addCallableUpdate()? I see there is a comment saying it should be deferred and wa... [20:31:35] 6Collaboration-Team-Backlog, 10Echo, 7Performance: Echo DB writes on page views - https://phabricator.wikimedia.org/T117531#1778990 (10aaron) I assume the change would affect the code below: ``` $notifUser = MWEchoNotifUser::newFromUser( $user ); $msgCount = $notifUser->getMessageCount(); $alertCount = $not... [20:31:38] (03PS1) 10Aaron Schulz: Defer onPersonalUrls() DB writes to post-send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250761 (https://phabricator.wikimedia.org/T117531) [20:33:09] (03PS2) 10Aaron Schulz: Defer onPersonalUrls() DB writes to post-send [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250761 (https://phabricator.wikimedia.org/T117531) [20:50:00] RoanKattouw: when you have a moment - pls take a look at comments in https://phabricator.wikimedia.org/T116797 [20:54:27] 6Collaboration-Team-Backlog, 10Flow, 10VisualEditor, 7Epic: Associate non-body content such as annotations and talk to a location in the article - https://phabricator.wikimedia.org/T89575#1779066 (10GWicke) [20:56:45] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1779073 (10Mattflaschen) [20:58:45] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1779076 (10Mattflaschen) We decided to do the latter plan, so updated. This page was only converted because of `{{useliquidth... [21:05:34] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Exclude deleted topics/posts from flow-reportcard stats - https://phabricator.wikimedia.org/T116797#1779095 (10Etonkovidova) My bad (in copying/pasting it mindlessly). It actually works without following a full format for the timestamp (thx @catrope)... [21:17:39] 3Collaboration-Team-Current, 10MediaWiki-extensions-PageCuration, 6Security, 7Vuln-XSS: XSS possible in PageTriage toolbar - https://phabricator.wikimedia.org/T111029#1779182 (10csteipp) This was assigned CVE-2015-8006 [21:23:42] (03PS1) 10Gerrit Patch Uploader: Add Estonian translation for flow topic namespace [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250829 [21:23:45] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250829 (owner: 10Gerrit Patch Uploader) [21:25:14] (03PS1) 10CSteipp: Add extra escaping in template [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250830 (https://phabricator.wikimedia.org/T111029) [21:26:22] 3Collaboration-Team-Current, 10Echo, 6Security, 7Vuln-Infoleak, and 2 others: Echo ignores hideuser for non-revision based notifications (e.g. thanks) - https://phabricator.wikimedia.org/T110553#1779339 (10csteipp) Assigned CVE-2015-8007 [21:34:34] (03CR) 10Catrope: [C: 032] Add extra escaping in template [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250830 (https://phabricator.wikimedia.org/T111029) (owner: 10CSteipp) [21:41:06] (03Merged) 10jenkins-bot: Add extra escaping in template [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250830 (https://phabricator.wikimedia.org/T111029) (owner: 10CSteipp) [21:43:52] (03PS1) 10Catrope: Escape message values where possible [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250832 [21:44:21] (03CR) 10jenkins-bot: [V: 04-1] Escape message values where possible [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250832 (owner: 10Catrope) [21:44:55] Anyone know how to revert an edit to a LQT post? /cc quiddity [21:45:24] the history? [21:45:30] (03PS2) 10Catrope: Escape message values where possible [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250832 [21:46:04] (03CR) 10Catrope: "Not sure whether we should prefer <%- mw.msg('foo') %> or <%= mw.message( 'foo' ).escaped() %>" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/250832 (owner: 10Catrope) [21:48:03] legoktm, oldid link doesn't work for some reason: https://pt.wikibooks.org/w/index.php?title=Tópico:Wikilivros:Plantão_de_dúvidas/Coleção_de_HTML&oldid=259783&action=edit . I figured out a workaround, though. [21:48:04] matt_flaschen, yeah, history page. See example here, if you need the URL string: https://test.wikipedia.org/w/index.php?title=Thread:User:Quiddity_%28WMF%29/sandbox3/test&action=history [21:48:05] Undo works. [21:49:16] If you just take the oldid link from history and add edit, it goes to the newest version. [22:16:51] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1779639 (10Mattflaschen) [22:19:43] (03CR) 10Paladox: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [22:19:59] (03CR) 10Paladox: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246424 (owner: 10Paladox) [22:20:20] quiddity, do you have rights to mark https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas/Arquivo_LQT_1?action=history pending-changes-reviewed? [22:21:37] matt_flaschen, nope [22:22:32] quiddity, okay, I don't think it matters, I was just trying to be extra-cautious. [22:36:41] matt_flaschen: Did we ever fix the memory leak in the LQT import? [22:37:20] I see 10-20 second waits between "Finished importing topic" and "Importing new topic", wondering if that's known/related [22:39:21] RoanKattouw: https://ganglia.wikimedia.org/latest/graph_all_periods.php?h=terbium.eqiad.wmnet&m=cpu_report&r=hour&s=by%20name&hc=4&mc=2&st=1446590307&g=mem_report&z=large&c=Miscellaneous%20eqiad [22:39:36] No, we didn't. [22:39:57] OK so I'm definitely using an increasing amount of memory [22:40:53] matt_flaschen: Would it be advisable for me to interrupt and restart the script? [22:41:12] Yes, there's a leak, but the graphs don't show it being out of control yet. [22:41:22] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-General-or-Unknown, 7JavaScript: Support single API for pre-filling new topics for both old-style talk pages and Flow - https://phabricator.wikimedia.org/T107637#1779696 (10matmarex) > Have Flow polyfill (could just be a redirect) index.php?action=edit§i... [22:41:30] Yeah that's what I was thinking, I don't see terbium going into swapdeath or even getting close to historical levels [22:41:48] RoanKattouw, wait until I'm done the re-conversion otherwise it *will* step on my toes. I'm almost to the coup de main. [22:42:02] OK [22:42:10] I only wanna do this if it helps us [22:42:36] RoanKattouw, it should be fine, I just have to be done the page. [22:42:39] and yes, we definitely need to not screw up your fixing the misconverted topic thing [22:44:10] RoanKattouw, I'm pretty sure the only reason it didn't successfully resume is that the most recent move was not by the conversion script/Flow user (it was Helder's move). [22:44:19] That won't be an issue for whatever page is interrupted this time. [22:44:21] Right, that's what I thought too [22:44:26] I just wanted to check that ... exactly [22:44:33] There is a specific check that most recent move is by us. [22:48:11] I'm running the actual re-conversion for that page (https://phabricator.wikimedia.org/T117514) now. [22:50:31] RoanKattouw, is there a bug and/or fix up for the i18n issue? [22:50:40] (03PS6) 10Mooeypoo: Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 [22:51:23] No :( [22:51:34] It's just a live hack on terbium right now, and we would have to verify it's still present [22:51:57] I'll put a real commit for that in Gerrit [22:52:08] (03PS1) 10Mooeypoo: Prep for mobile rewrite in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250849 [22:53:37] Okay, no problem. It won't be a big deal to fix, we just should get it in before next one. [22:54:02] RoanKattouw, I'll file a bug. [22:54:22] RoanKattouw, it worked, except https://pt.wikibooks.org/wiki/Topic:R1rhcfgazv10jnj3 (that's the old one on /Temporary). I was a little worried about that one since it's a weird LQT move thing. [22:54:31] I can re-create it. Not the end of the world IMHO. [22:55:26] 6Collaboration-Team-Backlog, 10Flow: Allow config of archive title formats for LQT conversion using MediaWiki namespace config page - https://phabricator.wikimedia.org/T117616#1779790 (10Mattflaschen) 3NEW [22:55:32] 6Collaboration-Team-Backlog, 10Flow: Allow config of archive title formats for LQT conversion using MediaWiki namespace config page - https://phabricator.wikimedia.org/T117616#1779807 (10Mattflaschen) a:3Catrope [22:55:44] 6Collaboration-Team-Backlog, 10Collaboration-Team-Sprint-E-Everywhere-2015-07-14, 10Flow, 7I18n, 5Patch-For-Review: E3. Allow config of archive title formats using MediaWiki namespace config page - https://phabricator.wikimedia.org/T93395#1136177 (10Mattflaschen) [22:55:46] 6Collaboration-Team-Backlog, 10Flow, 7Documentation, 7Easy, and 2 others: documentation inconsistent with behavior - https://phabricator.wikimedia.org/T96511#1779811 (10Aklapper) a:5Haritha28>3Catrope [22:56:17] 6Collaboration-Team-Backlog, 10Flow: Allow config of archive page title formats for LQT conversion using MediaWiki namespace config page - https://phabricator.wikimedia.org/T117616#1779812 (10Mattflaschen) [22:56:32] 6Collaboration-Team-Backlog, 10Flow: Allow config of archive page title formats for LQT conversion using MediaWiki namespace config page - https://phabricator.wikimedia.org/T117616#1779790 (10Mattflaschen) [22:57:47] matt_flaschen, how do I access the mysql db in vagrant? [22:58:25] mooeypoo: vagrant ssh, then when inside: mysql [22:58:41] Should automatically let you in, but root password is vagrant I believe. [23:00:32] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1779838 (10Mattflaschen) [23:00:54] RoanKattouw, you should be good to kill and resume. I will let you know when the topics are deleted. [23:01:37] RoanKattouw, oh, I forgot, I can't do that, so someone else has to. [23:01:50] I can [23:01:56] Hold on, lemme get it to an abortable place [23:02:40] Done [23:02:48] matt_flaschen: OK what do I need to delete? [23:02:53] Every place should be abortable (it is committed at a topic level so if you abort in between it should just rollback the topic), but yeah, it doesn't hurt to let it pause. [23:03:31] RoanKattouw, basically, the topics where all the posts are blank at https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas . [23:03:42] RoanKattouw, they are actually redirects, but they just look blank. [23:03:58] If you're not sure, just let me know and I'll take a look. [23:05:18] OK so I have to go through and find the blank ones [23:05:57] Yeah, basically there will be a pair for every topic, with one topic blank, except the oldest ones will not have a blank one. [23:06:21] So https://pt.wikibooks.org/wiki/Topic:S37odm2m6j4k0wzl is a blank topic for example [23:06:23] RoanKattouw, you only need to do it at a topic level. There won't be any where some of the posts are blank and some are real. [23:06:33] Yeah, that's one of them. [23:07:44] How exactly am I supposed to delete it? [23:07:59] lol lemme log in first [23:08:08] Do I click "Delete topic"? [23:08:15] I ask because some of the Flow actions map to strange things [23:09:12] RoanKattouw, yeah, just 'Delete topic'. [23:11:48] matt_flaschen: You said something about how there should be copies of each topic? [23:11:51] pairs? [23:12:11] RoanKattouw, except for the oldest ones. [23:12:14] (03PS7) 10Mooeypoo: Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 [23:12:16] Oh I see [23:12:19] They're just far apart [23:12:20] (03PS18) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [23:12:28] RoanKattouw, oh, sort it in newest order. [23:12:34] Oh right [23:12:52] Also sigh I might OOUIify the deletion thing over the weekend [23:12:57] No progress indication whatsoever [23:12:59] Then they'll always be siblings, but the order of real/fake varies. [23:12:59] RoanKattouw: Woo. [23:13:12] s/the weekend/a weekend/ [23:13:39] RoanKattouw: Tsk. [23:13:48] (03CR) 10Catrope: [C: 032] Prep for mobile rewrite in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250849 (owner: 10Mooeypoo) [23:14:56] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1779887 (10Mattflaschen) It worked except for https://pt.wikibooks.org/wiki/Topic:R1rhcfgazv10jnj3 which didn't re-import to t... [23:16:57] (03Merged) 10jenkins-bot: Prep for mobile rewrite in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250849 (owner: 10Mooeypoo) [23:17:09] (03PS11) 10Mooeypoo: Add an APIHandler to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 [23:17:15] (03PS6) 10Mooeypoo: Initialize notifications model outside of the widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 [23:17:19] (03PS7) 10Mooeypoo: Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 [23:17:25] (03PS8) 10Mooeypoo: Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 [23:17:31] (03PS19) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [23:19:07] matt_flaschen: OK I think I got them all [23:21:12] RoanKattouw, yeah, looks good. [23:21:19] RoanKattouw, I appreciate it. [23:23:20] RoanKattouw, last thing is to delete https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas/Temporary . I cross-checked to make sure everything is imported. [23:23:41] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1779947 (10Mattflaschen) [23:23:54] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1776259 (10Mattflaschen) [23:24:52] matt_flaschen: Delete that whole page you mean? [23:26:23] RoanKattouw, yeah, the /Temporary board. [23:26:53] All 6 are on the real board now. [23:27:11] Just the standard MW page deletion. [23:28:06] Done [23:29:03] Thanks [23:29:23] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1779978 (10Mattflaschen) [23:29:55] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Fix https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas - https://phabricator.wikimedia.org/T117514#1776259 (10Mattflaschen) @Catrope did the final deletions, so this should be fixed. [23:30:31] matt_flaschen: Can I resume the conversion now? [23:30:47] RoanKattouw, yep. [23:34:05] OK resuming [23:35:11] (03PS1) 10Mooeypoo: Don't mark read notifications as unseen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250858 [23:36:59] dannyh: why are projects getting removed from closed Community-Tech tasks in Phab so they cannot be found anymore when searching for what CommTech has worked on? [23:38:04] andre__ to get them out of our Done column? I want to be able to focus on what we've done within this sprint, and there isn't a way to get old tickets our of our collective face without putting them on a board [23:38:27] You can't remove them from all projects. [23:38:46] * andre__ realizes that #commtech exists, sorry for bringing that up here [23:39:05] dannyh: uhm, so they cannot stay in the general #Community-Tech project which is not related to any sprint? [23:39:35] to me removing all projects feels like destroying info that's why I'm asking what's the intention and to find out if there's a better way [23:40:08] andre__ yeah, absolutely -- the comm-tech board is our active backlog board [23:40:31] andre__ I could create an archive column or an archive board or somethign [23:40:33] Even if there is no better way, this is going to be reverted. [23:40:47] Krenair I'll fix it, don't worry [23:40:50] dannyh: I'd highly highly appreciate that. Thanks! [23:41:05] andre__ no problem, thanks for bringing it up [23:41:15] thank you for explaining :) [23:43:15] Doing this floods my inbox, by the way. [23:47:26] (03CR) 10Catrope: [C: 032] Don't mark read notifications as unseen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250858 (owner: 10Mooeypoo) [23:50:38] (03Merged) 10jenkins-bot: Don't mark read notifications as unseen [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250858 (owner: 10Mooeypoo)