[07:00:53] 6Collaboration-Team-Backlog, 10Flow: Edits at ee-flow and flow-tests.wmflabs.org are not in user's contributions - https://phabricator.wikimedia.org/T90772#1772672 (10Liuxinyu970226) [08:08:53] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Exclude deleted topics/posts from flow-reportcard stats - https://phabricator.wikimedia.org/T116797#1772718 (10matthiasmullie) New data is up. While the numbers are definitely very different now that moderated topics are excluded, the chart is still tr... [15:07:31] 6Collaboration-Team-Backlog, 10Flow: Remove usernames blocked at will from the mention search on Flow. - https://phabricator.wikimedia.org/T114467#1773715 (10Trizek-WMF) Okay. But this requires an action to oversight a username, right? As @elfix explains here T114467#1711869, there is no consensus to hide use... [15:54:46] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Flow browser test: hover failure in IE in flow_logged_in test - https://phabricator.wikimedia.org/T69723#1773920 (10zeljkofilipin) Is this still a problem, or can this task be resolved? [16:09:14] 6Collaboration-Team-Backlog, 10Flow: Quick opt-in opt-out fails - https://phabricator.wikimedia.org/T117432#1773969 (10SBisson) 3NEW [16:11:40] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests: Flow browser test: hover failure in IE in flow_logged_in test - https://phabricator.wikimedia.org/T69723#1773982 (10SBisson) It can be closed as invalid since Flow browser tests in IE are not executed or supported for the time being. [16:18:27] stephanebisson: Are we just giving up on browser tests in IE? Isn't that the main point of them? [16:19:08] James_F: mw-selenium doesn't support IE in the newer versions (there is no IE browser factory) [16:19:23] Yet another reason to drop Selenium. :-) [16:19:37] James_F: it's not selenium, it's mediawiki-selenium [16:19:51] Oh. What? [16:21:52] mw-selenium is our own helper library, it makes running in our environment easier [16:22:30] selenium-webdriver and watir-webdriver both support IE, the problem is... IE [16:23:11] (03CR) 10Alex Monk: [C: 032] Fix non-deterministic behavior in FeatureIndex [extensions/Flow] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249940 (https://phabricator.wikimedia.org/T117138) (owner: 10Catrope) [16:23:16] the tests needed to be stabilize with a friendly browser before we try to make them IE compatible, and we're almost done with that [16:24:01] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests, 7Performance: QA: implement "login to " to speed up browser tests - https://phabricator.wikimedia.org/T73635#1774026 (10zeljkofilipin) 5Open>3Resolved a:3zeljkofilipin Browser tests can now log in via the API, making it really fast. Please r... [16:30:48] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests, 7Browser-Support-Google-Chrome: upstream: Chrome sending bogus newline etc. values inside sendkeys strings - https://phabricator.wikimedia.org/T64536#1774058 (10zeljkofilipin) 5Open>3Invalid a:3zeljkofilipin No reply in a long time, resolving as i... [16:44:00] 6Collaboration-Team-Backlog, 10Thanks, 7Browser-Support-Apple-Safari, 7Browser-Support-Internet-Explorer, 7JavaScript: On Safari and IE9 the thanks confirmation is not hide correctly - https://phabricator.wikimedia.org/T117309#1774151 (10Mattflaschen) Tested English Wikipedia on OS X Mavericks with Safar... [16:44:54] MatmaRex, if you want, you should be able to request access to Sauce Labs from your manager to test browser issues like https://phabricator.wikimedia.org/T117309#1771054 . It basically is a cloud interface to test with VMs. [16:45:53] matt_flaschen: yeah, i know, i've used that or something similar before [16:46:04] but it's a bit of a pain [16:47:23] 6Collaboration-Team-Backlog, 10Thanks, 7Browser-Support-Apple-Safari, 7Browser-Support-Internet-Explorer, 7JavaScript: On Safari and IE9 the thanks confirmation is not hidden correctly - https://phabricator.wikimedia.org/T117309#1774156 (10Mattflaschen) [16:49:02] 6Collaboration-Team-Backlog, 10Echo, 7Design, 7WorkType-NewFunctionality: Allow marking Echo notifications as unread - https://phabricator.wikimedia.org/T73564#1774176 (10Mattflaschen) [16:56:59] 6Collaboration-Team-Backlog, 10Flow: Prefill loads all template contents, including elements - https://phabricator.wikimedia.org/T116002#1774217 (10Trizek-WMF) [17:03:49] (03CR) 10Mattflaschen: "Not all issues from patch set 8 addressed." (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 (owner: 10Paladox) [17:06:10] (03PS11) 10Paladox: Update grunt-jscs to 2.2.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/243503 [17:06:20] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 7Regression, 7WorkType-NewFunctionality: Allow links in Flow topic titles - https://phabricator.wikimedia.org/T59153#1774275 (10Trizek-WMF) [17:38:29] 6Collaboration-Team-Backlog, 10Flow: Flow UI encourages reply-to-topic and discourages reply-to-comment - https://phabricator.wikimedia.org/T116999#1774424 (10ksmith) 5Invalid>3Open Reopening, pending clarifications of my last comment (question). I'm also going to retitle it to reflect my improved understa... [17:39:04] 6Collaboration-Team-Backlog, 10Flow: Flow UI does not allow replying to the last comment (it only allows reply-to-topic in that case) - https://phabricator.wikimedia.org/T116999#1774426 (10ksmith) [17:43:44] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): Requests to the API should return CAPTCHA in the UI language - https://phabricator.wikimedia.org/T117112#1774453 (10Etonkovidova) Checked in betalabs and production. {F2908009} [17:54:12] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4), 5WMF-deploy-2015-11-03_(1.27.0-wmf.5): Unable to solve captcha on RTL languages due to bad element position - https://phabricator.wikimedia.org/T116910#1774507 (10Etonkovidova) Checked in betalabs - translation... [18:01:44] matt_flaschen, stephanebisson I think I talked to you about not having to put in my password every time I do "vagrant up" for NFS daemon? I found the solution if you want [18:01:58] mooeypoo, oh, cool. [18:02:08] mooeypoo: what did you do? [18:02:43] edit /etc/sudoers to include the relevant lines from "ROOT PRIVILEGE REQUIREMENT" https://docs.vagrantup.com/v2/synced-folders/nfs.html [18:02:55] they do warn that it might change when upgrading vagrant, though [18:03:29] matt_flaschen, stephanebisson the full answer is the second answer here: http://askubuntu.com/questions/412525/vagrant-up-and-annoying-nfs-password-asking [18:03:47] Though it's probably better to take the lines from the original vagrant docs instead [18:05:04] Thanks, will try it later. [18:07:12] I just tested it on my machine, works like a charm for me [18:07:19] woohoo [18:17:26] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests, 15User-greg: Flow browser test: hover failure in IE in flow_logged_in test - https://phabricator.wikimedia.org/T69723#1774652 (10greg) 5Open>3Invalid a:3greg >>! In T69723#1773982, @SBisson wrote: > It can be closed as invalid since Flow browser t... [18:31:46] legoktm, ping [18:31:56] err, standup, thatis [18:32:05] oops, joining [18:39:13] (03CR) 10Legoktm: [C: 032] Convert Echo notifications to the new system [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 (https://phabricator.wikimedia.org/T116847) (owner: 10Catrope) [18:40:18] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure: Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#1774775 (10Catrope) a:3Catrope [18:40:25] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure: Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#850716 (10Catrope) p:5Normal>3High [18:42:55] 3Collaboration-Team-Current, 10Echo, 7Tracking: Write presentation models for all notification types (tracking) - https://phabricator.wikimedia.org/T116834#1774786 (10santhosh) @Catrope, Any preferred deadline to complete this? So that we can plan it properly in our sprints with correct priority. [18:45:44] (03Merged) 10jenkins-bot: Convert Echo notifications to the new system [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 (https://phabricator.wikimedia.org/T116847) (owner: 10Catrope) [18:52:09] (03CR) 10Sbisson: [C: 032] Fix how events are handled to make them work on board re-sort. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250167 (https://phabricator.wikimedia.org/T117238) (owner: 10Mattflaschen) [18:57:01] (03Merged) 10jenkins-bot: Fix how events are handled to make them work on board re-sort. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250167 (https://phabricator.wikimedia.org/T117238) (owner: 10Mattflaschen) [19:01:26] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4), 5WMF-deploy-2015-11-03_(1.27.0-wmf.5): sort() call in FeatureIndex caused non-deterministic behavior - https://phabricator.wikimedia.org/T117138#1767451 (10Mattflaschen) Was SWATted out today, and I ran FlowFix... [19:11:53] (03CR) 10Mattflaschen: "Can you mention the new reason for returning false in the docblock?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250309 (owner: 10Aaron Schulz) [19:13:17] 3Collaboration-Team-Current, 10Echo, 7Tracking: Write presentation models for all notification types (tracking) - https://phabricator.wikimedia.org/T116834#1774901 (10Catrope) >>! In T116834#1774786, @santhosh wrote: > @Catrope, Any preferred deadline to complete this? So that we can plan it properly in our... [19:13:39] (03CR) 10Sbisson: [C: 032] Simplify RevisionActionPermissions::isAllowedAny() a little [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250216 (owner: 10Legoktm) [19:14:34] 6Collaboration-Team-Backlog, 10Flow: Remove usernames blocked at will from the mention search on Flow. - https://phabricator.wikimedia.org/T114467#1774904 (10Mattflaschen) >>! In T114467#1773715, @Trizek-WMF wrote: > Okay. But this requires an action to oversight a username, right? Yes. > As @elfix explains... [19:15:57] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation: Write presentation models for notifications in ContentTranslation - https://phabricator.wikimedia.org/T116852#1774908 (10Catrope) >>! In T116852#1765409, @Amire80 wrote: > Hmm, I'm not familiar with presentation models. > Sorry... [19:16:24] 6Collaboration-Team-Backlog, 10Flow: Remove usernames blocked at will from the mention search on Flow. - https://phabricator.wikimedia.org/T114467#1774909 (10Trizek-WMF) >>! In T114467#1774904, @Mattflaschen wrote: > That's fine. But I don't think Flow should handle this differently than the many other place... [19:16:55] (03Merged) 10jenkins-bot: Simplify RevisionActionPermissions::isAllowedAny() a little [extensions/Flow] - 10https://gerrit.wikimedia.org/r/250216 (owner: 10Legoktm) [19:17:14] (03PS2) 10Aaron Schulz: Make EchoEvent::create() a no-op if the DB is read-only [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250309 [19:18:28] 6Collaboration-Team-Backlog, 10Flow: Flow UI does not allow replying to the last comment (it only allows reply-to-topic in that case) - https://phabricator.wikimedia.org/T116999#1774920 (10Mattflaschen) [19:18:30] 6Collaboration-Team-Backlog, 10Flow: New Flow indentation model shows comments in the wrong order and level of indentation - https://phabricator.wikimedia.org/T93883#1774921 (10Mattflaschen) [19:21:34] matt_flaschen: So what I've been looking at is the queries in ContributionsQuery [19:21:47] It can produce 9 [19:21:53] (3x3) different types of queries [19:22:41] The one I'm the most worried about is the newbie query, can you tell me something about what that is and why it is the way it is? [19:23:03] The form of the query appears to be something like WHERE rev_user_id > N AND rev_user_id NOT IN(X, Y, Z, ...) [19:23:53] If we have to support that, I can probably figure out a least-sucky way to support it, but if there's some reason why we randomly don't need that query at all (or could do it significantly differently), that would be better [19:24:16] 6Collaboration-Team-Backlog, 10Flow: Flow UI does not allow replying to the last comment (it only allows reply-to-topic in that case) - https://phabricator.wikimedia.org/T116999#1774951 (10Mattflaschen) This has been discussed a lot, so I merged this into an older bug. This was a deliberate product change (le... [19:25:15] RoanKattouw, looking. [19:28:05] RoanKattouw, what is the 3x3 you're referring to? I see the fork on revision type, plus some conditions. Want to make sure we're on the same page. [19:28:59] It's listing every single bot in the condition?! [19:29:02] Yeah there's a 3-way fork on revision type, and buildConditions() has a 3-way fork based on whether we're in newbie mode and whether the user is anon or not [19:29:17] haha yeah can you see why I'm concerned about this query? :) [19:29:33] (The NOT IN part is just the icing on the cake really, the rev_user_id > N part is already a problem) [19:29:59] brb [19:34:52] Back [19:38:18] RoanKattouw, looks like it's just copied from core, except we have the courtesy to cache it. :) [19:39:39] The bot part is done differently, though. [19:40:32] RoanKattouw, https://phabricator.wikimedia.org/diffusion/MW/browse/master/includes/specials/SpecialContributions.php;98f3cfe5c1a41b0dec80be61ad388910313941e5$838 [19:43:31] This doesn't actually use the index code, so if the LEFT JOIN to deal with bots works better, that can be swapped in pretty easily. [19:43:40] Going to pick up some lunch quick before Moriel's talk. [19:46:43] Oh crap [19:46:46] Yeah I should do that too [19:48:26] Thanks for finding that code Matt, I'll look at it in more detail later [20:56:09] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-11-03_(1.27.0-wmf.5): Stop falling back to PHP parser if a specific Parsoid call fails - https://phabricator.wikimedia.org/T116699#1775343 (10Etonkovidova) For future (testing) references: On https://zh.wikipedia.org/w/index.php?title... [21:03:34] (03CR) 10Mattflaschen: [C: 031] "Merge after branch cut." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250309 (owner: 10Aaron Schulz) [21:06:07] mooeypoo, great job. Looking forward to trying out ltr.wtf and rtl.wtf [21:18:28] 6Collaboration-Team-Backlog, 10Echo: 127.0.0.1 instead of username in notifications about article linked - https://phabricator.wikimedia.org/T116470#1775461 (10Base) [21:48:58] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-EducationProgram: Echo notification for Education program should be grouped - https://phabricator.wikimedia.org/T117489#1775623 (10Teles) 3NEW [21:52:59] Ah, the Vagrant sudo code says it requires 1.7.3+, and I have 1.6.5. [21:53:36] I'll upgrade sometime, but not today. [21:55:14] matt_flaschen, thanks! I put up a placeholder in rtl.wtf while I work on the fuller system... :p [21:57:14] mooeypoo, nice! The hover effect works with NoScript still on. :) [21:57:44] yep, it's css only :D [21:57:48] LRO [21:57:52] actually RLO [22:00:04] mooeypoo, oh, do you know why cursor movement is different from selection movement? Is there a good reason or just, "That's how it turned out". [22:01:14] matt_flaschen, no the cursor was always defined as logical vs. visual, but then the browsers implemented it differently, and now there's a bit more of a somewhat-of-an-agreement [22:02:42] mooeypoo, you mean before browsers, it was consistently logical, now it's sort-of consistently visual? [22:03:58] no no in browsers. I don't remember which browser did what in terms of selection and movement, but they were NOT in agreement [22:04:11] I think firefox also has it as a configuration option... :\ [22:04:27] matt_flaschen, it creates an absolute *mess* for selection and movement support in VisualEditor [22:04:37] I remember David was wrestling with it for a while [22:05:01] especially if you have something like this: "sentence in English משהו בעברית and then english" [22:05:18] and worse, "sentence in English משהו בעברית [img] and then english" [22:06:03] if you move your cursor, it needs to go to the right, then to the left on the hebrew, then select the image, then go to the logical-end -- but where is that? Is it going left (backwards into the hebrew?) or right into the english? [22:06:30] So it used to "walk" the sentence visually until in encountered a selectable node and then it got "stuck" on it, the cursor just going back and forth before it and after it [22:06:48] Basically, you cannot predict which direction the cursor will move when you press leftarrow/rightarrow [22:06:59] At least at an LTR/RTL boundary it's hard to tell [22:07:14] It shouldn't be when it's visual, but most times you *want* your cursor to go logical [22:07:25] in VE the movement is logical now IIRC [22:07:26] And if you mix native and overridden behavior, it's easy to create loops [22:07:38] mooeypoo: No, it's native, so visual [22:07:49] it didn't use to be [22:07:50] VE lets the native action happen and fixes up the result if necessary [22:08:01] oh, that's right, we "fixed" it [22:08:31] Well, we made it behave the same as the native environment, which I think is good in general [22:13:28] (03CR) 10Mattflaschen: "This should be reviewed now (well, after I rebase it)." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen) [22:15:08] RoanKattouw, that assumes the native environment is good [22:24:22] 3Collaboration-Team-Current, 10Flow, 10Wikimedia-Extension-setup: Enable Flow on pt.wikibooks - https://phabricator.wikimedia.org/T114540#1775773 (10Catrope) a:3Catrope [22:24:58] 6Collaboration-Team-Backlog, 10Flow, 3Google-Code-In-2015: GENDER support for Flow-notification-link-text-enabled-on-talkpage - https://phabricator.wikimedia.org/T113784#1775775 (10Mooeypoo) [22:25:04] 6Collaboration-Team-Backlog, 10Flow, 3Google-Code-In-2015: GENDER support for Flow-notification-link-text-enabled-on-talkpage - https://phabricator.wikimedia.org/T113784#1675740 (10Mooeypoo) I will mentor this in #GCI2015 [22:27:41] matt_flaschen, legoktm I'm tagging easy gender i18n tasks with Google Code In 2015 project... if you see any or think of any good small tasks, feel free [22:28:28] mooeypoo, sounds good, I will be on the lookout as well. [22:30:36] awesome, I tagged a bunch last night :) [22:30:39] matt_flaschen: Can you take a quick look at https://gerrit.wikimedia.org/r/250576 ? [22:30:43] legoktm: Or you [22:30:51] Sure [22:31:05] If it's not crazy, I'll deploy it in a few minutes [22:31:54] afk for a bit with advil and tea. hopefully back in an hour or two. [22:33:44] matt_flaschen: Good catch [22:34:03] quiddity, hope you feel better. [22:34:11] Amended [22:36:51] Is the plan to use "Topic" long term? [22:38:25] Their expressed desire is to switch to Tópico eventually [22:39:01] And Helder says he is okay with breaking the LQT Topico links (https://phabricator.wikimedia.org/T113682#1745155). We didn't discuss that idea much, though. [22:40:06] Yeah I think we'll wait a while, then make Tópico point to Topic instead of Thread [22:40:24] i.e. apply the hack that I just applied but to the LQT namespace instead of the Flow one [22:40:41] That'll break old LQT Tópico links, and old-ish Flow Topic: links will automatically redirect to Tópico [22:41:14] uh [22:41:30] :/ [22:41:36] breaking links = :( [22:41:38] I know :S [22:41:42] 6Collaboration-Team-Backlog, 10Flow: "Edit summary" separate page is broken for JS users and uses old editor - https://phabricator.wikimedia.org/T117500#1775856 (10Mattflaschen) 3NEW [22:41:56] We've tried to get them to translate "Thread" and "Topic" to different words [22:42:01] But apparently there aren't enough synonyms [22:42:13] 6Collaboration-Team-Backlog, 10Flow: "Edit summary" separate page is broken for JS users and uses old editor - https://phabricator.wikimedia.org/T117500#1775856 (10Mattflaschen) [22:42:32] oh yeah I got that [22:42:45] I'm just thinking about how difficult it would be to run a bot or something [22:42:45] oi? [22:43:21] legoktm, yeah, that would only work for internal links, but would probably reduce the damage a lot. [22:43:28] Hey Helder [22:43:36] or, [22:43:46] some hack that says if not a valid UUID, assume it was LQT [22:44:24] :( to that as well. [22:45:00] Yeah I suppose you could try to redirect invalid Topic: links to Thread: if the Thread page exists [22:46:27] Behold, my hack works: https://pt.wikibooks.org/wiki/Topic:Sryoz68b63nlaiol [22:47:00] (And https://pt.wikibooks.org/wiki/Thread:Sryoz68b63nlaiol redirects to https://pt.wikibooks.org/wiki/Tópico:Sryoz68b63nlaiol which doesn't exist) [22:48:52] And: [22:49:03] https://pt.wikibooks.org/wiki/Thread:Wikilivros_Discuss%C3%A3o:Portal_comunit%C3%A1rio/Proposta_para_converter_as_p%C3%A1ginas_de_LiquidThreads_para_Flow/resposta_%286%29 [22:49:04] and: [22:49:12] https://pt.wikibooks.org/wiki/T%C3%B3pico:Wikilivros_Discuss%C3%A3o:Portal_comunit%C3%A1rio/Proposta_para_converter_as_p%C3%A1ginas_de_LiquidThreads_para_Flow/resposta_%286%29 [22:49:14] both work. [22:49:37] With the former redirecting to the latter [22:49:41] I've also just created the templates [22:50:03] Which unfortunately weren't translated :( [22:50:44] Helder: If you like, you could help us translate the templates for the LQT->Flow conversion [22:51:01] https://pt.wikibooks.org/wiki/Especial:Contribui%C3%A7%C3%B5es/Flow_talk_page_manager [22:51:26] 6Collaboration-Team-Backlog, 10Flow: Flow UI does not allow replying to the last comment (it only allows reply-to-topic in that case) - https://phabricator.wikimedia.org/T116999#1775908 (10ksmith) Thanks @Mattflaschen. The ticket you merged this with explains the situation much better than the other ticket(s).... [22:51:45] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run FlowCreateTemplates.php on pt.wikibooks - https://phabricator.wikimedia.org/T114541#1775910 (10Catrope) a:3Catrope [22:53:54] RoanKattouw, do I have to keep the parameter names in English? E.g.: {{{archive}}} instead of {{{arquivo}}}? [22:54:14] I think so [22:54:16] Let me check [22:54:31] Helder, RoanKattouw, yes. [22:54:42] ok [22:55:14] Yup [22:55:15] Sorry :S [22:55:30] Perhaps numbered params would have been better, although those have their own problems [22:57:01] (03PS8) 10Mattflaschen: Fix history pagination and give user the number of entries they requested [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) [22:57:28] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7Browser-Support-Internet-Explorer: Minimized PageCuration Toolbar rotates text 180 degrees instead of 90 degrees under IE11 - https://phabricator.wikimedia.org/T105846#1775918 (10GOIII) [23:01:45] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 7Browser-Support-Internet-Explorer: Minimized PageCuration Toolbar rotates text 180 degrees instead of 90 degrees under IE11 - https://phabricator.wikimedia.org/T105846#1775923 (10GOIII) As of 11/02/2015 an working example of //Page Curation//... [23:02:20] translation is {{done}} [23:02:29] Thanks Helder! You're awesome [23:02:58] As a guinea pig page (first conversion, to see if it works) I propose https://pt.wikibooks.org/wiki/Wikilivros_Discuss%C3%A3o:P%C3%A1gina_principal because it's nice and small [23:03:05] Is that a crazy idea or can I go ahead and do that? [23:03:32] go ahead :) [23:04:28] [2015-11-02 23:04:19] Imported 9 items, failed 0 [23:04:55] The result looks good to me [23:05:15] (03CR) 10Mattflaschen: "Rebased. The conflicts were mainly in the test files, but I did a quick re-test." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen) [23:05:28] And I didn't realize that LQT imports could produce deeply nested reply structures such as https://pt.wikibooks.org/wiki/Topic:Q3q7vulwhl5ejv9p , you wouldn't be able to create that exact structure in Flow [23:06:43] Yeah, unfortunately the request for that feature in Flow was not implemented [23:07:12] There was discussion about that today actually: https://phabricator.wikimedia.org/T116999 (which I haven't read yet) [23:07:50] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#1775929 (10Catrope) a:3Catrope [23:08:31] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#1673081 (10Catrope) First run went well: P2269 Now going to convert all pages. [23:08:37] OK so that went well, I'll start converting all pages next [23:08:42] Helder, RoanKattouw, actually, a lesser known part of the New Model for Indentation is that max depth is now 8. [23:09:03] However, you can only get that by replying to an intermediary post (since replying to the last post of a tangent is always vertical). [23:09:08] It used to be 3, though. [23:11:18] (03CR) 10Mattflaschen: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen) [23:11:45] OK, here goes [23:11:47] RoanKattouw, where can I define the name for pages like https://pt.wikibooks.org/wiki/Wikilivros_Discuss%C3%A3o:P%C3%A1gina_principal/LQT_Archive_1 ? [23:11:55] "LQT Archive 1" [23:12:11] In a message I think [23:12:13] Let me see [23:12:23] I've killed the conversion I just started so we can fix that [23:13:51] ARGH [23:13:53] FFS [23:13:55] It's not translatable [23:14:50] Helder: Can you tell me the translated version? Then I'll just live-hack it into the file [23:15:32] It could be this: "Arquivo LQT 99999" [23:16:21] Can I just move https://pt.wikibooks.org/wiki/Wikilivros_Discuss%C3%A3o:P%C3%A1gina_principal/LQT_Archive_1 as any other pages? [23:16:27] (rename it) [23:16:35] (03CR) 10Mooeypoo: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 (owner: 10Mooeypoo) [23:17:27] RoanKattouw, ^ [23:17:41] Yeah go ahead and move the ones that already exist [23:17:44] I can't fix those automatically [23:17:50] But the new ones should be correct [23:18:35] ok [23:21:09] Ug, we put in the infrastructure for this but forgot to do it for the LQT case. [23:21:28] It works for enable Flow and opt-in. [23:21:37] Yeah it works for everything else, just not this [23:21:55] OK, starting take 2, hopefully with correct archive patterns this time [23:22:42] Helder: Seems to work: https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas/Arquivo_LQT_1 [23:23:54] (03PS9) 10Mattflaschen: Add support for edit summary formatting in topic titles [extensions/Flow] - 10https://gerrit.wikimedia.org/r/243066 (https://phabricator.wikimedia.org/T59153) [23:24:32] RoanKattouw, I think that one was me [23:24:40] wait, that is a Flow page? [23:24:56] https://pt.wikibooks.org/w/index.php?diff=prev&oldid=292176 [23:25:29] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Convert LQT -> Flow on pt.wikibooks - https://phabricator.wikimedia.org/T113682#1775974 (10Catrope) Full run aborted because we want "/Arquivo LQT 1" instead of "/LQT Archive 1": P2270. Started a second full run with that fixed (or rather, monk... [23:25:35] Oh, right [23:26:05] https://pt.wikibooks.org/wiki/Utilizador_Discuss%C3%A3o:Celso_Candido/Arquivo_LQT_1 is a real example of it working :) [23:26:30] both "Wikilivros:Plantão de dúvidas" and "Wikilivros:Plantão de dúvidas/Arquivo LQT 1" are Flow pages now, is that right? [23:26:42] (I assume both were in LQT format then?) [23:26:48] RoanKattouw, we need to do the rev model thing, right? [23:27:05] and then "Wikilivros:Plantão de dúvidas/Arquivo LQT 1/Arquivo LQT 1" is the wikitext archive [23:27:33] Ahg, what happened to https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas/Arquivo_LQT_1 ? [23:28:46] Oh, you know what [23:28:50] Maybe it got converted twice [23:28:57] Because Helder moved it between the two conversion runs [23:29:11] RoanKattouw, it shouldn't matter, since it should be marked useliquidthreads:0. [23:29:20] RoanKattouw, what script did you run? [23:29:28] And as he pointed out, https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas/Arquivo_LQT_1/Arquivo_LQT_1 is the LQT archive page [23:30:20] yeah, probably just a bad timing [23:31:11] Maybe if it was literally while the script was running. [23:31:32] Is it a known issue that a page like "Wikilivros:Plantão de dúvidas/Arquivo LQT 1" does not show the link to the page above it? [23:32:04] (E.g. https://pt.wikibooks.org/wiki/Wikilivros:Biblioteca/Ordem_alfab%C3%A9tica has a line "< Wikilivros:Biblioteca" below the title) [23:32:33] It looks like it's doing the right thing for an opt-out wiki in general: https://pt.wikibooks.org/w/index.php?title=Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas/Arquivo_LQT_1/Arquivo_LQT_1&diff=292317&oldid=292178 [23:34:18] Helder, yeah, sorry: https://phabricator.wikimedia.org/T99033 [23:37:08] so, it seems that of the topics which should be at "Wikilivros:Plantão de dúvidas", the oldest ones are there, but the newest ones are at "Wikilivros:Plantão de dúvidas/Arquivo LQT 1" [23:37:24] is there any chance of merging them at "Wikilivros:Plantão de dúvidas"? [23:37:39] Urgh did it split the board into two? [23:37:49] maybe... [23:37:55] Great :S [23:38:08] I'm not sure if there were somehow two LQT pages [23:38:21] but it might be just because I was moving the page while the script was running [23:38:22] =/ [23:38:24] (sorry) [23:40:58] RoanKattouw, I think I kow how to fix it. [23:41:40] Awesome [23:41:42] Go for it [23:42:26] Alright, let me think for a second. This is a new issue. [23:42:54] legoktm, I'm impklementing the new event presentation model for "welcome" in Echo, but it has no primary link [23:43:00] #whatdoIdo [23:43:09] o.O [23:43:15] we allow notifications to have no primary link? [23:43:19] It makes sense... where would it link? [23:43:30] "Welcome to Wikipedia" inside wikipedia. Should it link to itself and implode the internet? [23:43:40] Project:Welcome :P [23:43:47] Everywhere has that? [23:44:00] In general, though, we should be able to have notifications without links if we need them.... [23:44:05] nope [23:44:06] yes [23:44:18] is that a heisenberg answer? [23:44:31] er, [23:44:42] no, not all projects have Project:Welcome. Yes we need to support not having a primary link [23:44:56] wait wait wait [23:45:03] We could probably introduce an i18n message for Project:Welcome [23:45:34] so I got into this all "yay I'm going to implement the new presentation model, hoorah!" ... I ended up with a class that has "getIconType" and "canRender always true" [23:45:37] AND I FOUND A BUG!? [23:46:17] lol [23:47:36] "
Welcome to Wikipedia, 01foobar! We're glad you're here.
" [23:48:25] patch coming in a few minutes [23:48:39] legoktm, okay, I'm testing with: public function getPrimaryLink() { return array( "#", "#" ); } [23:51:04] I thought I could just use an old trick to force-resume it (there is checking that makes resuming complicated if the page moves are non-standard), but there's also the issue of it all being done (with the topic redirects like https://pt.wikibooks.org/wiki/T%C3%B3pico:Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas/Atribui%C3%A7%C3%A3o_de_cap%C3%ADtulos/resposta?redirect=no). [23:51:17] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Exclude deleted topics/posts from flow-reportcard stats - https://phabricator.wikimedia.org/T116797#1776074 (10Etonkovidova) Checked in production - with old queries I got the # in the first column: ``` mysql:research@s3-analytics-slave [flowdb]> SELEC... [23:51:53] RoanKattouw, do you have the source store? [23:53:01] When I started the second run I passed it the same sourceStore [23:53:22] Basically I reran https://phabricator.wikimedia.org/P2270 exactly just with a different filename passed to tee [23:53:32] That's okay. I'm thinking what i can do is take the source store, remove the handful at https://pt.wikibooks.org/wiki/Wikilivros:Plant%C3%A3o_de_d%C3%BAvidas , then force-resume it. [23:53:40] It should only add back that handful, this time in the right place. [23:53:45] Ahm [23:53:54] Do you need the conversion process to not be running while you do that? [23:54:31] Because it's currently running and using that sourceStore [23:55:16] RoanKattouw, maybe not strictly, but I'd rather wait until it's done if that's alright. [23:55:25] (03PS1) 10Legoktm: Allow notifications to not have a primary link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250592 [23:55:44] OK [23:56:05] legoktm, do we not use composer's autoload.php for classes ? [23:56:05] Do you know how many pages there are? [23:56:08] (03CR) 10Catrope: [C: 032] Allow notifications to not have a primary link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250592 (owner: 10Legoktm) [23:56:21] Not exactly. IIRC it's about 8000 [23:56:26] mooeypoo: no, we use scripts/gen-autoload.php [23:56:32] but... [23:56:36] we use composer .... [23:56:40] .... why wouldn't we use that? [23:56:44] how long does the LQT-FLow conversion takes, usually? [23:56:51] RoanKattouw, matt_flaschen ? [23:56:55] It depends on how much there is to convert [23:56:57] composer is used for development dependencies like phpcs, not the actual extension [23:57:09] mediawiki.org's Support desk page took days because it was so huge [23:57:11] ah [23:57:30] I don't really know how long ptwikibooks is gonna take, but I would guess multiple hours [23:57:37] ok [23:58:31] 6Collaboration-Team-Backlog, 10Echo: Allow welcome notification to optionally have a link target - https://phabricator.wikimedia.org/T117509#1776117 (10Legoktm) 3NEW [23:59:23] (03Merged) 10jenkins-bot: Allow notifications to not have a primary link [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250592 (owner: 10Legoktm)