[00:00:47] 3Collaboration-Team-Current, 10Echo, 7Voice & Tone, 7WorkType-NewFunctionality: Messages about talk pages are not completely adapted to non-talk namespaces - https://phabricator.wikimedia.org/T56433#1767407 (10jrbs) [00:02:50] (03Merged) 10jenkins-bot: Follow-up 65cc2f6c1d: [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249924 (owner: 10Catrope) [00:02:53] (03Merged) 10jenkins-bot: Get captcha text in user language [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249926 (https://phabricator.wikimedia.org/T116910) (owner: 10Mooeypoo) [00:03:17] (03PS1) 10Catrope: Follow-up 65cc2f6c1d: [extensions/Flow] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249933 [00:03:25] (03CR) 10Catrope: [C: 032] Follow-up 65cc2f6c1d: [extensions/Flow] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249933 (owner: 10Catrope) [00:03:58] 3Collaboration-Team-Current, 10Flow: sort() call in FeatureIndex caused non-deterministic behavior - https://phabricator.wikimedia.org/T117138#1767451 (10Mattflaschen) 3NEW [00:04:37] (03PS1) 10Mattflaschen: Fix non-deterministic behavior in FeatureIndex [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249934 (https://phabricator.wikimedia.org/T117138) [00:06:35] (03Merged) 10jenkins-bot: Follow-up 65cc2f6c1d: [extensions/Flow] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249933 (owner: 10Catrope) [00:09:25] (03PS2) 10Mattflaschen: Fix non-deterministic behavior in FeatureIndex [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249934 (https://phabricator.wikimedia.org/T117138) [00:10:39] RoanKattouw, do you think we should try to deploy https://phabricator.wikimedia.org/T117138 tonight? [00:10:45] I'll do it now [00:10:56] I just had to deploy a follow-up to my SWAT patch anyway [00:10:56] RoanKattouw, okay, it also needs the accompanying mediawiki-config. [00:11:39] Lovely [00:11:54] the mw-config change is idempotent with the current state of things, so that can go out separately first [00:12:00] s/idempotent/a no-op/ [00:12:18] RoanKattouw, yeah [00:12:23] What is the actual impact of this bug? [00:12:29] The phab task doesn't describe that [00:13:15] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: sort() call in FeatureIndex caused non-deterministic behavior - https://phabricator.wikimedia.org/T117138#1767562 (10Mattflaschen) [00:14:15] RoanKattouw, when testing Matthias's patch (but I think it also affects master, it's just sensitive to what titles you use), I could add consecutive references ([[Link 1]], [[Link 2]], ...) to the description, and only the first would show up in WhatLinksHere [00:14:43] Eventually, I traced it back to the insert and access paths using different keys (access path is used to update core tables). [00:15:08] OK [00:15:21] I suppose this is a recent regression from Ori's changes in the caching area [00:15:40] RoanKattouw, actually, I don't think so. It would still be distinct keys even before the md5. [00:15:46] Oh, right [00:16:17] OK so this breaks Whatlinkshere, and we'd presumably have to regenerate that using some sort of maintenance script once this is deployed [00:16:33] But other than that, what does it break that's deploy-on-a-Thursday-an-hour-after-SWAT worthy? [00:16:50] RoanKattouw, we don't have to do it today. There haven't been complaints, that's why I didn't mark it UBN. [00:16:56] OK [00:17:03] RoanKattouw, we luckily already have that script (FlowFixLinks). [00:17:07] Let's just let it ride the train then [00:17:19] And schedule your config patch (since it's currently a no-op) for Monday [00:17:35] then FlowFixLinks for Thursday (one week from today) after the train [00:17:50] I'll put those things in the deployment schedule [00:18:11] RoanKattouw, I would prefer to have all deployed code using the same cache version. [00:18:19] Oh, ugh [00:18:20] OK [00:18:22] SWAT on Monday then? [00:18:41] Yeah, that's better. [00:18:47] And I'll file a task about FlowFixLinks. [00:19:16] I was gonna put in a deploy cal entry for that actually [00:19:25] (03CR) 10Catrope: [C: 032] Fix non-deterministic behavior in FeatureIndex [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249934 (https://phabricator.wikimedia.org/T117138) (owner: 10Mattflaschen) [00:20:31] Okay, I'll just put a note. [00:20:44] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: sort() call in FeatureIndex caused non-deterministic behavior - https://phabricator.wikimedia.org/T117138#1767585 (10Mattflaschen) a:3Mattflaschen [00:21:05] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: sort() call in FeatureIndex caused non-deterministic behavior - https://phabricator.wikimedia.org/T117138#1767451 (10Mattflaschen) [00:23:27] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: sort() call in FeatureIndex caused non-deterministic behavior - https://phabricator.wikimedia.org/T117138#1767605 (10Mattflaschen) [00:24:12] https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=198362&oldid=198347 [00:30:36] (03Merged) 10jenkins-bot: Fix non-deterministic behavior in FeatureIndex [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249934 (https://phabricator.wikimedia.org/T117138) (owner: 10Mattflaschen) [00:38:12] (03CR) 10Mattflaschen: "This was hopefully just caused by T117138 which I found and fixed in the course of testing this. Will retest now." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [00:40:18] (03PS1) 10Catrope: Fix non-deterministic behavior in FeatureIndex [extensions/Flow] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249940 (https://phabricator.wikimedia.org/T117138) [00:44:59] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Topics: Edit a topic/a message, Summarize a topic, Resolve a topic - https://phabricator.wikimedia.org/T113578#1767657 (10Mattflaschen) Do we want to make these a little more explicit about how to use the UI (with or without scree... [00:47:46] (03PS7) 10Mattflaschen: Add artificial primary key to flow_wiki_ref and flow_ext_ref [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [01:27:07] (03CR) 10Mattflaschen: [C: 031] "Looks good after fix of T117138. I did the whole elaborate retest and it's no longer reproducible (and I don't think it was caused or exa" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [01:28:21] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1767728 (10Mattflaschen) >>! In T109676#1764634, @Mattflaschen wrote: >>>! In T109676#1763501, @Mattflasc... [01:56:56] (03PS5) 10Mattflaschen: Move Flow ExternalStore entries to separate cluster [extensions/Flow] - 10https://gerrit.wikimedia.org/r/226544 (https://phabricator.wikimedia.org/T106363) (owner: 10Matthias Mullie) [02:13:33] 6Collaboration-Team-Backlog, 10Echo: [[User:USERNAME]] does not notify user - https://phabricator.wikimedia.org/T117155#1767822 (10XXN) 3NEW [02:13:55] 6Collaboration-Team-Backlog, 10Echo: [[User:USERNAME]] does not notify user - https://phabricator.wikimedia.org/T117155#1767831 (10Mattflaschen) Please provide the diff. [02:18:59] 6Collaboration-Team-Backlog, 10Echo: [[User:USERNAME]] does not notify user - https://phabricator.wikimedia.org/T117155#1767834 (10XXN) I was mentioned in this long message https://ro.wikipedia.org/w/index.php?title=Discu%C8%9Bie_Utilizator:Ionutzmovie&diff=prev&oldid=10114112 and did not received notification... [02:22:31] Is the JS topic summary interface broken for anyone else locally? /cc RoanKattouw mooey|away [02:22:56] it takes me to the no-JS view. [02:23:00] 6Collaboration-Team-Backlog, 10Echo: [[User:USERNAME]] does not notify user - https://phabricator.wikimedia.org/T117155#1767840 (10Catrope) >>! In T117155#1767834, @XXN wrote: > I was mentioned in this long message https://ro.wikipedia.org/w/index.php?title=Discu%C8%9Bie_Utilizator:Ionutzmovie&diff=prev&oldid=... [02:23:04] Ahm, hah [02:23:07] Let me check [02:23:36] You mean Summarize / Edit summary ? [02:24:36] Cause those wfm [02:28:02] (03PS1) 10Catrope: Revert "Follow-up 65cc2f6c1d:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249951 [02:29:09] (03PS1) 10Catrope: Revert "Clean up captcha form and remove to stylesheet" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249952 [02:29:12] (03CR) 10jenkins-bot: [V: 04-1] Revert "Clean up captcha form and remove to stylesheet" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249952 (owner: 10Catrope) [02:29:55] (03PS2) 10Catrope: Revert "Clean up captcha form and remove to stylesheet" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249952 [02:36:14] 3Collaboration-Team-Current, 10Flow: data-parsoid missing again locally - https://phabricator.wikimedia.org/T117156#1767847 (10Mattflaschen) 3NEW [09:55:56] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo) [09:58:54] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 (https://phabricator.wikimedia.org/T116847) (owner: 10Catrope) [10:00:35] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a page about (more) advanced Flow features - https://phabricator.wikimedia.org/T111529#1768342 (10Trizek-WMF) [10:00:36] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about permalinks - https://phabricator.wikimedia.org/T113580#1768340 (10Trizek-WMF) 5Open>3Resolved https://www.mediawiki.org/wiki/Flow/Permalinks [10:07:04] (03CR) 10Siebrand: "i18n/L10n reviewed. Please add message documentation when adding messages. See https://www.mediawiki.org/wiki/I18n#Message_documentation f" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (owner: 10Legoktm) [10:07:11] (03CR) 10Siebrand: [C: 04-1] [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (owner: 10Legoktm) [10:42:57] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1768400 (10jcrespo) @Mattflaschen, let's try to do formally once [[ https://wikitech.wikimedia.org/wiki/S... [10:51:09] (03Abandoned) 10Hashar: Trivial jscs fix [extensions/Flow] (wmf/1.27.0-wmf.2) - 10https://gerrit.wikimedia.org/r/247326 (owner: 10Hashar) [11:00:06] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison, 7Documentation: Create a page describing Flow interface - https://phabricator.wikimedia.org/T117192#1768420 (10Trizek-WMF) 3NEW a:3Trizek-WMF [11:00:35] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Topics: Edit a topic/a message, Summarize a topic, Resolve a topic - https://phabricator.wikimedia.org/T113578#1670000 (10Trizek-WMF) The more I write this documentation, the more I think I'll have to create something about the in... [11:03:19] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a page describing Flow interface - https://phabricator.wikimedia.org/T117192#1768433 (10Trizek-WMF) [13:01:31] 6Collaboration-Team-Backlog, 10Echo, 7I18n, 7Voice & Tone: Some Echo issues of GENDER and untranslatability - https://phabricator.wikimedia.org/T63904#1768599 (10Nemo_bis) Not quite a tone issue. [13:01:49] 6Collaboration-Team-Backlog, 10Echo, 7I18n: Links on notification-page-linked, -bundle, -flyout etc. - https://phabricator.wikimedia.org/T69942#1768600 (10Nemo_bis) [14:08:25] 6Collaboration-Team-Backlog, 10Flow: A substed templates is not parsed until you post the message - https://phabricator.wikimedia.org/T117211#1768785 (10Trizek-WMF) 3NEW [14:08:48] 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 10VisualEditor, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1749049 (10Trizek-WMF) >>! In T116417#1761384,... [14:37:55] 6Collaboration-Team-Backlog, 10Echo: [[User:USERNAME]] does not notify user when edit did not add signature - https://phabricator.wikimedia.org/T117155#1768848 (10Aklapper) [15:19:22] 3Collaboration-Team-Current, 10Echo, 10Flow, 6Analytics-Kanban, and 2 others: Analytics support for this task {frog} - https://phabricator.wikimedia.org/T117220#1768995 (10Milimetric) 3NEW a:3matthiasmullie [15:20:20] 3Collaboration-Team-Current, 10Echo, 10Flow, 6Editing-Analysis, 5Patch-For-Review: Measure the user responsiveness to notifications over time - https://phabricator.wikimedia.org/T108208#1769007 (10Milimetric) [15:32:27] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability, 5Patch-For-Review: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1769027 (10Etonkovidova) Current summary (https://tendril.wikimedia.org/host/view/db1029.eqiad.wmnet/3306) db1029 : re... [15:36:11] 6Collaboration-Team-Backlog, 10Flow: Create a system to see last active conversations on a wiki - https://phabricator.wikimedia.org/T117222#1769048 (10Trizek-WMF) 3NEW [16:28:40] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure: Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#1769274 (10matthiasmullie) [16:31:35] (03CR) 10Mattflaschen: [C: 032] Revert "Clean up captcha form and remove to stylesheet" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249952 (owner: 10Catrope) [16:32:17] (03CR) 10Mattflaschen: [C: 032] Revert "Follow-up 65cc2f6c1d:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249951 (owner: 10Catrope) [16:32:40] RoanKattouw_away, yeah, Summarize at least. [16:35:33] (03Merged) 10jenkins-bot: Revert "Follow-up 65cc2f6c1d:" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249951 (owner: 10Catrope) [16:38:25] (03Merged) 10jenkins-bot: Revert "Clean up captcha form and remove to stylesheet" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249952 (owner: 10Catrope) [16:39:54] Could someone review https://gerrit.wikimedia.org/r/#/c/249049/1 ? [16:45:17] 3Collaboration-Team-Current, 10Flow: Cannot post a topic after Flow board was re-sorted - https://phabricator.wikimedia.org/T117238#1769329 (10Etonkovidova) 3NEW [16:47:06] (03CR) 10Legoktm: [C: 032] Do not attempt to fall back to PHP parser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249049 (https://phabricator.wikimedia.org/T116699) (owner: 10Mattflaschen) [16:49:47] (03Merged) 10jenkins-bot: Do not attempt to fall back to PHP parser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249049 (https://phabricator.wikimedia.org/T116699) (owner: 10Mattflaschen) [16:57:59] (03CR) 10Mattflaschen: [C: 031] "I think this is ready to merge, but I want to give Jaime a final chance to review." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/226544 (https://phabricator.wikimedia.org/T106363) (owner: 10Matthias Mullie) [17:01:47] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability, and 2 others: DB master connections requested by Flow on GET/HEAD requests - https://phabricator.wikimedia.org/T94028#1769398 (10Etonkovidova) - General regression testing is done - updated stats from https://tendril.wikimedi... [17:02:40] 3Collaboration-Team-Current, 10Flow: Cannot post a topic after Flow board was re-sorted - https://phabricator.wikimedia.org/T117238#1769401 (10Mattflaschen) a:3Mattflaschen [17:04:51] 3Collaboration-Team-Current, 10Flow: Cannot post a topic after Flow board was re-sorted - https://phabricator.wikimedia.org/T117238#1769408 (10Mattflaschen) p:5Triage>3Unbreak! [17:07:02] 3Collaboration-Team-Current, 10Flow: Cannot post a topic after Flow board was re-sorted - https://phabricator.wikimedia.org/T117238#1769413 (10Mattflaschen) a:5Mattflaschen>3None [17:07:40] 3Collaboration-Team-Current, 10Flow: data-parsoid missing again locally - https://phabricator.wikimedia.org/T117156#1769419 (10Mattflaschen) a:3Mattflaschen [17:23:54] (03CR) 10Mattflaschen: "scrub_wikitext spelling is not supported yet by Parsoid, though they are discussing how to do it at that bug." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245612 (https://phabricator.wikimedia.org/T114620) (owner: 10Catrope) [17:25:23] 6Collaboration-Team-Backlog, 10Echo, 6Design-Research: Evaluate designs for new notification panel actions - https://phabricator.wikimedia.org/T116741#1769539 (10Capt_Swing) a:3Capt_Swing [17:34:22] 3Collaboration-Team-Current, 10Flow: Cannot post a topic after Flow board was re-sorted - https://phabricator.wikimedia.org/T117238#1769591 (10Mattflaschen) [17:40:08] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Have a cheat sheet about Flow shortcuts - https://phabricator.wikimedia.org/T117251#1769618 (10Trizek-WMF) 3NEW a:3Trizek-WMF [17:50:45] (03PS1) 10Legoktm: IDatabase::delete() does not take a fourth parameter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/250048 [17:51:16] 6Collaboration-Team-Backlog, 10Flow: Use alt+maj+s to post a message - https://phabricator.wikimedia.org/T117257#1769713 (10Trizek-WMF) 3NEW [17:51:43] 6Collaboration-Team-Backlog, 10Flow: Use alt+maj+s to post a message - https://phabricator.wikimedia.org/T117257#1769731 (10Trizek-WMF) [17:51:44] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Have a cheat sheet about Flow shortcuts - https://phabricator.wikimedia.org/T117251#1769730 (10Trizek-WMF) [17:52:40] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Have a cheat sheet about Flow shortcuts - https://phabricator.wikimedia.org/T117251#1769618 (10Trizek-WMF) [17:54:04] https://phabricator.wikimedia.org/maniphest/query/lqkv1QDGuiNU/#R [17:54:07] mooeypoo, ^ [17:54:34] awesomesauce, thanks! [17:59:09] hey ya'll, beta cluster is down again due to a bad query, looks like flow agian [17:59:14] RoanKattouw_away: matt_flaschen ^ [17:59:19] debug going on in -releng [17:59:24] 6Collaboration-Team-Backlog, 10Flow: Use alt+maj+s to post a message - https://phabricator.wikimedia.org/T117257#1769780 (10Mattflaschen) [17:59:26] 6Collaboration-Team-Backlog, 10Flow: Flow lacking accesskeys for preview/submit - https://phabricator.wikimedia.org/T63517#1769781 (10Mattflaschen) [17:59:51] 6Collaboration-Team-Backlog, 10Flow: Use alt+maj+s to post a message - https://phabricator.wikimedia.org/T117257#1769713 (10Mattflaschen) [17:59:52] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Have a cheat sheet about Flow shortcuts - https://phabricator.wikimedia.org/T117251#1769791 (10Mattflaschen) [18:00:05] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Have a cheat sheet about Flow shortcuts - https://phabricator.wikimedia.org/T117251#1769618 (10Mattflaschen) [18:00:07] 6Collaboration-Team-Backlog, 10Flow: Flow lacking accesskeys for preview/submit - https://phabricator.wikimedia.org/T63517#672482 (10Mattflaschen) [18:00:41] greg-g, might be the same query. I don't think it's been fixed yet, but RoanKattouw_away said he would work on it shortly. [18:01:45] 3Collaboration-Team-Current, 10Flow: Can't connect to Parsoid locally - https://phabricator.wikimedia.org/T117156#1769817 (10Mattflaschen) [18:01:55] matt_flaschen: might want to help ori who's currently trying to get you all better debug info [18:03:52] I think he's getting something [18:03:57] I don't want to interrupt him ;) [18:06:06] So, embarassingly, I found https://phabricator.wikimedia.org/T78671#850799 [18:06:27] In which Antoine pinpoints the exact query I was suspicious of as taking 60s in the slow query log .... 10 months ago [18:07:24] hilarious [18:07:32] but yes, I feel your pain, RoanKattouw [18:07:34] :) [18:08:15] I guess I get to hide behind Dec 2014 predating my involvement with this team [18:08:41] RoanKattouw, do you want me to look at it as well? [18:09:00] I'm looking now [18:09:08] I've just rerun the EXPLAIN on stat1003 [18:09:15] (because beta is down and Antoine's explain is a year old) [18:09:44] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure: Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#1769830 (10Catrope) Updated explain result of that query: ``` +------+-------------+... [18:09:54] hah, I wonder what index_merge is [18:10:44] RoanKattouw, https://dev.mysql.com/doc/refman/5.0/en/index-merge-optimization.html [18:11:00] Thanks Matt [18:11:10] I'd gotten distracted so I hadn't looked it up yet [18:11:43] Happened to have that in history from a previous battle with explain. [18:13:50] Hmm wait these are NOT the same query [18:13:58] In this case the range scan is on rev_id and that's already going wrong [18:14:28] In the other case I saw the range scan was on rev_user_id which is much scarier [18:17:47] OK I understand what's up now [18:18:38] It's doing WHERE rev_user_id=820 AND rev_id < 'something' by doing an index merge on the user index and the primary key [18:18:40] Which is clever [18:18:48] But then that causes ORDER BY rev_id to filesort [18:18:57] This table badly needs indexes that match the actual calling pattern [18:21:43] (03PS10) 10Mooeypoo: Add an APIHandler to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 [18:22:04] (03PS5) 10Mooeypoo: Initialize notifications model outside of the widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 [18:22:10] (03PS5) 10Mooeypoo: Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 [18:22:16] (03PS6) 10Mooeypoo: Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 [18:22:24] (03PS17) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [18:24:20] (03CR) 10jenkins-bot: [V: 04-1] Initialize notifications model outside of the widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 (owner: 10Mooeypoo) [18:25:00] 6Collaboration-Team-Backlog, 10Flow, 7Design: Make source/wikitext icon consistent - https://phabricator.wikimedia.org/T97451#1769921 (10Mattflaschen) >>! In T97451#1714903, @Pginer-WMF wrote: >>>! In T97451#1714847, @Trizek-WMF wrote: >> The recent change concerning the source icon, from to [[]] raises... [18:25:06] I'll work on that after lunch [18:26:51] Am I right that flow_revision_user won't work for your example query because rev_user_ip is omitted? [18:27:15] So maybe we need to split it? ^ RoanKattouw_away [18:33:04] 6Collaboration-Team-Backlog, 10Flow, 7Design: Make source/wikitext icon consistent - https://phabricator.wikimedia.org/T97451#1769967 (10Mattflaschen) >>! In T97451#1715060, @Trizek-WMF wrote: > Thanks @Pginer-WMF! > Emphasize by changing the typo is a good idea, which could solve {T95831} :) That is actual... [18:41:07] 6Collaboration-Team-Backlog, 10Flow: U+FFFC displayed on a Flow topic title - https://phabricator.wikimedia.org/T115012#1769992 (10Mattflaschen) Chrome is making them invisible. They're still there, though. You can tell by opening edit title, selecting the field, hitting Home (go to beginning of field), then... [18:44:31] 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 10VisualEditor, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1770006 (10Volker_E) @Pginer-WMF I disagree wit... [19:13:31] hi everybody -- is the Flow dashboard on Limn broken? I wanted to see the latest stats... http://flow-reportcard.wmflabs.org/# [19:14:32] dannyh: it is not broken, matthias removed all the data because he wanted to recompute it [19:14:46] so that's going to run Sunday ('cause it's a weekly thing) [19:15:07] he backed it up though, in case you want to look at numbers, ask him where he put the files [19:19:16] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 10Beta-Cluster-Infrastructure: Beta Cluster Special:Contributions lags by a long time and notes slow Flow queries - https://phabricator.wikimedia.org/T78671#1770170 (10dduvall) Another instance of this query took down Beta Cluster again toda... [19:27:10] milimetric oh, good :) -- I don't need to see it right now specifically, I just check in sometimes. [19:38:26] 3Collaboration-Team-Current, 10Flow: Can't connect to Parsoid locally - https://phabricator.wikimedia.org/T117156#1770237 (10Mattflaschen) 5Open>3Invalid a:5Mattflaschen>3None [19:38:44] 3Collaboration-Team-Current, 10Flow: Can't connect to Parsoid locally - https://phabricator.wikimedia.org/T117156#1767847 (10Mattflaschen) Just needed to update Parsoid repo. [19:38:55] 3Collaboration-Team-Current, 10Flow: Cannot post a topic after Flow board was re-sorted - https://phabricator.wikimedia.org/T117238#1770241 (10Mattflaschen) a:3Mattflaschen [19:48:33] mooeypoo, I'm going to review your initializer refactor, since I have to debug the bug etonkovidova filed, and I'd rather do that debugging on the code we'll be using going forward. [19:48:45] mooeypoo, are you okay with me merging today, or do you want to leave more time before the cut? [19:54:47] matt_flaschen, hm. I think we'll probably be okay ? [19:55:10] matt_flaschen, I ran browser tests against it, and it passes, I just wanted some time to make sure the patch didn't forget anything major [19:55:21] but I think if browser tests are passing, it's more encouraging [19:55:24] mooeypoo, okay, we'll see. I am going to have some review comments. I'll try to keep it quick. [19:55:34] * mooeypoo nods [20:23:54] * quiddity lunches [20:47:11] (03CR) 10Mattflaschen: [C: 04-1] "Looks good, some small stuff inline." (0311 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 (owner: 10Mooeypoo) [20:53:25] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: Invalid language code "nl_nl" - https://phabricator.wikimedia.org/T116890#1770353 (10Krinkle) Part of this would be addressed by 3b829b4385eda5b986 / https://gerrit.wikimedia.org/r/2... [21:15:56] matt_flaschen, question regarding one of your comments [21:16:32] mooeypoo, yep. [21:16:54] You were commenting on line #184 in https://gerrit.wikimedia.org/r/#/c/248082/10/modules/mw.flow.Initializer.js about the default sort -- but that sort is set from flow-initialize when we instantiate dm.System() and it is set by $board.data( 'flow-sortby' ) [21:17:01] So I am a little cofnused about what I need to fix with that comment? [21:17:41] oh the comment above that code says "newest" I completely missed that... sorry, I thought you were refering to the actual this.flowBoard.topicIdSort = ... code bit [21:18:06] mooeypoo, yeah, you should probably just remove the 'newest' part (don't specify what the default is). [21:18:09] It's just asking to go out of date. [21:18:14] * mooeypoo nods [21:18:40] Yeah I thought you were saying we should change the sort in the code, that's why I was confused. [21:18:45] fixing now [21:32:43] 6Collaboration-Team-Backlog, 10Echo: [[User:USERNAME]] does not notify user when edit did not add signature - https://phabricator.wikimedia.org/T117155#1770418 (10matmarex) {T66778}? [21:40:39] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: Mentions are not recognized when more than one section is involved - https://phabricator.wikimedia.org/T101385#1770458 (10Mattflaschen) [21:41:52] 6Collaboration-Team-Backlog, 10Echo: [[User:USERNAME]] does not notify user when edit affected multiple sections - https://phabricator.wikimedia.org/T117155#1770467 (10Mattflaschen) [21:41:56] 6Collaboration-Team-Backlog, 10Echo: [[User:USERNAME]] does not notify user when edit affected multiple sections - https://phabricator.wikimedia.org/T117155#1767822 (10Mattflaschen) [21:41:58] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: Mentions are not recognized when more than one section is involved - https://phabricator.wikimedia.org/T101385#1337166 (10Mattflaschen) [21:42:18] mooeypoo, is there a task for removing the old editor system? [21:52:04] 3Collaboration-Team-Current, 10Flow: Cannot post a topic after Flow board was re-sorted - https://phabricator.wikimedia.org/T117238#1770517 (10Mattflaschen) [21:53:56] matt_flaschen, I think so? It was in QA forever iirc [21:57:05] mooeypoo, it's not done. The old editor system is still in the code. [21:58:32] There is https://phabricator.wikimedia.org/T114448 , which covers the preparatory steps to removing it, AFAICT. [21:59:45] 6Collaboration-Team-Backlog, 10Flow: Remove old editor system - https://phabricator.wikimedia.org/T117291#1770524 (10Mattflaschen) 3NEW [21:59:56] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3): Investigate the uses of the old editor system in Flow, and clean up the uses in handlebars - https://phabricator.wikimedia.org/T114448#1770533 (10Mattflaschen) [21:59:57] 6Collaboration-Team-Backlog, 10Flow: Remove old editor system - https://phabricator.wikimedia.org/T117291#1770532 (10Mattflaschen) [22:04:54] matt_flaschen, yeh it's not done at all, I think the undo actions were one of the last things we were missing [22:05:17] the ticket kept going back and forth between QA and in Development for the list of things to do in there, iirc [22:06:17] (03PS11) 10Mooeypoo: Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 [22:07:52] (03CR) 10Mooeypoo: Organize flow-initialize and add an Initializer object (0311 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 (owner: 10Mooeypoo) [22:08:06] mooeypoo, it actually seems pretty done. https://phabricator.wikimedia.org/T116085 might be the only one left. [22:08:23] 6Collaboration-Team-Backlog, 10Flow: History: 'undo' for topic summary still has the old-style icon - https://phabricator.wikimedia.org/T116085#1770567 (10Mattflaschen) [22:08:24] 6Collaboration-Team-Backlog, 10Flow: Remove old editor system - https://phabricator.wikimedia.org/T117291#1770566 (10Mattflaschen) [22:08:36] 6Collaboration-Team-Backlog, 10Flow: History: 'undo' for topic summary still uses the old editor system (has the old-style icon) - https://phabricator.wikimedia.org/T116085#1770568 (10Mattflaschen) [22:10:51] crap, another undo!? aaaaa [22:11:10] but yeah i think the undo and standalone edits were the last ones to hold off on using the editor [22:11:29] i believe I removed the loader actions from handlebars for most things, too [22:12:37] mooeypoo, not so much another one, I think that might be the only one. [22:12:58] When you say "standalone edits", do you mean JS in no-JS edit page? [22:21:53] (03PS12) 10Mattflaschen: Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 (owner: 10Mooeypoo) [22:22:17] ^ mooeypoo, rebased your init patch in Gerrit. [22:28:11] matt_flaschen: No, it's not about splitting indexes but rather about merging them I think [22:31:07] RoanKattouw, my understanding was that multi-column indices like flow_revision_user can not be used if an intermediate column is not included in the query (e.g. rev_user_ip). Is that right? [22:32:05] I.E. if the query is on rev_user_id and rev_user_wiki, but not IP, is it usable? [22:36:28] (03CR) 10Mattflaschen: [C: 032] Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 (owner: 10Mooeypoo) [22:37:21] Got a quick question for you guys. I'm considering use mediawiki for writing a book (due to its markup capabilities and cross references, etc.) I'm wondering if flow will provide better support for commenting on parts of a page (in Google Docs you can just select the text and click add comment.) Also, any other suggestions? [22:37:53] That's right [22:38:00] But AFAIK there's always a condition on every field [22:38:05] I'll have to take a detailed look though [22:40:06] hunterb, we don't have any support for that currently. [22:41:28] hunterb, there is https://www.mediawiki.org/wiki/Extension:Annotator . It hasn't been worked on recently, though, and there are known limitations, the biggest of which is that all of the annotations are per-revision, so if you make a change, annotations to unrelated parts of the page will no longer show up (unless you go to the older revision). [22:42:10] There might also be other issues that make it not suitable for a public wiki (though it sounds like yours is private?) [22:42:25] (03Merged) 10jenkins-bot: Organize flow-initialize and add an Initializer object [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248082 (owner: 10Mooeypoo) [22:44:33] mooeypoo, is there a reason that the href links have to be blanked? I was thinking that if we didn't do that, we might be able to do it using event delegation (rather than re-running the transform, which is broken and I'm fixing): [22:44:35] https://phabricator.wikimedia.org/diffusion/EFLW/browse/master/modules/mw.flow.Initializer.js;d3c622439cad191c05e7bdc108cceeed36128d1f$520 [22:45:22] I realize if we don't blank it, they could open it in a new tab, and then that page has to behave sensibly with JS enabled. [22:48:05] matt_flaschen: yeah, it would be private. [22:59:51] hmmm [23:00:52] matt_flaschen, actually, I was thinking the same thing when I migrated this. The following lines have .click( ... ) in there that returns false and prevents propogation, so the link squashing should be unnecessary [23:01:01] I didn't fix it because I didn't want to accidentally introduce a separate bug [23:01:08] bug that's a good point, we might not need to do this now [23:02:40] mooeypoo, okay, I'll go ahead and do it that way, since avoids the problem of "have to catch every scenario where new reply links are provided". [23:02:56] Unfortunately, we can't solve it like this everywhere, because sometimes the actual widget is displayed by default. [23:02:58] (before click) [23:04:03] yeah [23:07:15] Re: watchlist loading performance. Did anything change with it in the last few weeks? aaron and nemo have some interesting notes at https://phabricator.wikimedia.org/T116971 [23:08:06] 6Collaboration-Team-Backlog, 10Echo: Echo message popout height keep growing till it reach the end of page while scrolling - https://phabricator.wikimedia.org/T117297#1770706 (10santhosh) 3NEW [23:11:25] quiddity, the one I can think of is https://gerrit.wikimedia.org/r/#/c/248314/ . Watchlist and RC share a lot of their implementation internally. [23:13:35] nod, i'll note that, and CC you [23:13:48] quiddity, I'll add it. [23:13:56] ok, ty :) [23:15:39] quiddity, I don't really think that's it, though, because it doesn't add any isRootAllowed calls, or load anything new. It *should* just change what isRootAllowed returns for existing data. [23:16:32] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Watchlist, 7Performance: Special:Watchlist takes 23 seconds to start loading on mediawiki.org - https://phabricator.wikimedia.org/T116971#1770719 (10Mattflaschen) {529d6bd36cfbad0a71c321e8e217432935d7b3b0} seems relevant at first glance. RC and watchlist sh... [23:23:07] matt_flaschen, i'm getting ready to go upstairs for the halloween party... you need anything before I go ? [23:23:16] thanks for merging, btw [23:24:18] mooeypoo, nope, I think I know what to do. Have fun, probably going to go to the party my coworking space is throwing tomorrow, we'll see though. [23:30:12] Awesomesauce, thanks, and have fun! [23:36:30] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Watchlist, 7Performance: Special:Watchlist takes 23 seconds to start loading on mediawiki.org - https://phabricator.wikimedia.org/T116971#1770773 (10Quiddity) Confirmation note: On mediawiki.org, with my preferences set to "0 days, 1000 changes", and for 2...