[00:00:00] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "Maybe make $objectId a UUID. But either way, please add types to the docblock." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249116 (https://phabricator.wikimedia.org/T116582) (owner: 10Sbisson)
[00:06:07] <matt_flaschen>	 Heading home
[00:12:10] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: Invalid language code "nl_nl" - https://phabricator.wikimedia.org/T116890#1764412 (10Catrope) Do things like `?uselang=isownwork` fail similarly? Commons uses those kinds of "languag...
[00:13:31] <legoktm>	 Um
[00:13:38] <legoktm>	 I just lost power
[00:13:47] <RoanKattouw>	 What you too
[00:13:58] <RoanKattouw>	 Stephane was saying he'd lost power this morning, and that the park near his house had turned into a lake
[00:14:08] <RoanKattouw>	 But he's a couple thousand miles away :)
[00:14:21] <legoktm>	 lol
[00:14:35] <legoktm>	 They're doing construction near my house
[00:14:59] <RoanKattouw>	 I'm gonna guess it's not related to flooding :P
[00:15:05] <RoanKattouw>	 Although it did rain a bit in the city todafy
[00:16:11] <grrrit-wm>	 (03PS3) 10Mooeypoo: Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 
[00:16:37] <grrrit-wm>	 (03PS15) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 
[00:16:46] <legoktm>	 Not here
[00:17:59] <legoktm>	 Aaand I barely have a good cell signal. I'm gonna go read a book or something.
[00:21:55] <grrrit-wm>	 (03CR) 10Catrope: [C: 04-1] Allow presentation models to indicate a notification can't be formatted (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249444 (https://phabricator.wikimedia.org/T116888) (owner: 10Legoktm)
[00:24:15] <grrrit-wm>	 (03PS3) 10Catrope: Convert Echo notifications to the new system [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 (https://phabricator.wikimedia.org/T116847) 
[00:24:45] <grrrit-wm>	 (03CR) 10Catrope: Convert Echo notifications to the new system [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 (https://phabricator.wikimedia.org/T116847) (owner: 10Catrope)
[00:30:04] <grrrit-wm>	 (03PS4) 10Catrope: Convert Echo notifications to the new system [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 (https://phabricator.wikimedia.org/T116847) 
[00:31:08] <grrrit-wm>	 (03CR) 10Catrope: Convert Echo notifications to the new system (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 (https://phabricator.wikimedia.org/T116847) (owner: 10Catrope)
[00:54:53] <legoktm>	 power's back
[00:55:06] <legoktm>	 PG&E says 2000 houses were affected
[00:55:59] <RoanKattouw>	 Ouch
[00:56:09] <RoanKattouw>	 That reminds me of that big storm + rain we had in December
[00:56:18] <RoanKattouw>	 With the pictures of the flooded Safeway parking lot and stuff
[00:57:25] <RoanKattouw>	 The night before I told Trevor there was no way he wasn't gonna have a power outage, with his rickety old above-ground power lines that hum and crackle at night when it's foggy, and his house being a couple hundred feetfrom the ocean
[00:57:55] <RoanKattouw>	 The next morning, I'm randomly up early at 7am (while it's still dark out) and doing my dishes, and all of a sudden the power goes out and I have to finish the dishes in the dark
[00:58:09] <RoanKattouw>	 Turns out lightning had struck a substation near downtown SF and >100k people were affected
[00:59:31] <RoanKattouw>	 Luckily the office had regained power by the time I got there, but my neighborhood didn't have power for most of the day
[00:59:38] <RoanKattouw>	 So I guess weird stuff can happen
[01:00:47] <RoanKattouw>	 (needless to say Trevor had no power problems; although the freeway near his house did flood)
[01:03:28] <legoktm>	 I'm looking up UPSs on amazon right now, any recommendations?
[01:04:03] <legoktm>	 mainly for our wifi router
[01:04:19] <RoanKattouw>	 No, I don't have any UPS gear at my house
[01:04:23] <RoanKattouw>	 Cause I don't own a desktop computer
[01:05:12] <legoktm>	 my laptops are set up as desktops :P
[01:05:19] <legoktm>	 but they become useless if the router loses power
[01:06:02] <RoanKattouw>	 The only things I use power for are lights, charging devices, and my wifi router, but apparently it takes more than a 100k+ outage to knock out LTE in my area
[01:06:25] <legoktm>	 hehe
[01:07:16] <RoanKattouw>	 It was kind of weird to walk around in total darkness, no street lights or traffic lights, but still receive emails straight to my watch
[01:23:38] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Notifications on added links should exclude links made by the user herself - https://phabricator.wikimedia.org/T117010#1764547 (10jeblad)
[01:25:17] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Notifications on added links should exclude links made by the user herself - https://phabricator.wikimedia.org/T117010#1764551 (10Legoktm) This was fixed, just hasn't been deployed to Wikipedia's yet (tomorrow).
[01:25:22] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo: Notifications on added links should exclude links made by the user herself - https://phabricator.wikimedia.org/T117010#1764552 (10Legoktm)
[01:25:24] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 10Wikidata, 5MW-1.27-release-notes, and 4 others: Echo should not notify the user about his own linking activity - https://phabricator.wikimedia.org/T116485#1764553 (10Legoktm)
[01:28:33] <grrrit-wm>	 (03CR) 10Legoktm: Allow presentation models to indicate a notification can't be formatted (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249444 (https://phabricator.wikimedia.org/T116888) (owner: 10Legoktm)
[01:28:39] <grrrit-wm>	 (03PS2) 10Legoktm: API: Remove no-op wfProfile(In|Out) calls [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249601 
[01:28:42] <grrrit-wm>	 (03PS3) 10Legoktm: Allow presentation models to indicate a notification can't be formatted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249444 (https://phabricator.wikimedia.org/T116888) 
[01:29:51] <grrrit-wm>	 (03CR) 10Aaron Schulz: [C: 032] API: Remove no-op wfProfile(In|Out) calls [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249601 (owner: 10Legoktm)
[01:46:20] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Allow presentation models to indicate a notification can't be formatted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249444 (https://phabricator.wikimedia.org/T116888) (owner: 10Legoktm)
[01:48:57] <grrrit-wm>	 (03Merged) 10jenkins-bot: Allow presentation models to indicate a notification can't be formatted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249444 (https://phabricator.wikimedia.org/T116888) (owner: 10Legoktm)
[01:49:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: API: Remove no-op wfProfile(In|Out) calls [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249601 (owner: 10Legoktm)
[01:51:51] <legoktm>	 reviewing your thanks one now
[01:52:06] <RoanKattouw>	 Thanks :D
[01:54:21] <RoanKattouw>	 legoktm: BTW did you see the email I sent you about linux.conf.au today?
[01:54:28] <legoktm>	 yes,
[01:54:31] <RoanKattouw>	 OK
[01:54:32] <legoktm>	 I'll do that next
[01:54:37] <RoanKattouw>	 Cause the early birds are at 98% now :O
[01:54:39] <RoanKattouw>	 OK thanks
[01:54:53] <legoktm>	 oh crap
[01:54:55] <legoktm>	 should I do it now?
[01:55:04] <RoanKattouw>	 If you could
[01:55:41] <RoanKattouw>	 The difference isn't enormous, it's $200, but it does help a bit and it's easily saved money
[01:56:03] <RoanKattouw>	 It was only like 80%ish last I checked
[01:56:15] <RoanKattouw>	 1-2 days ago
[01:57:19] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Use flow- prefix for the CSS classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 (owner: 10Mattflaschen)
[01:57:29] <legoktm>	 RoanKattouw: are their shirt sizes the same as the US?
[01:57:35] <RoanKattouw>	 I think so
[01:57:53] <RoanKattouw>	 I've gotten the same size from them as I get here (M) and I've been happy
[01:58:03] <RoanKattouw>	 I didn't check to see if they have a sizing chart somewhere
[01:58:27] <legoktm>	 "Penguin Dinner Ticket"
[01:58:45] <legoktm>	 I assume Penguin is Tux related and not what's for dinner?
[01:58:55] <RoanKattouw>	 Yes :)
[01:59:00] <RoanKattouw>	 Yes, get a Penguin Dinner ticket
[01:59:08] <RoanKattouw>	 It'll tell you that it costs extra, but it'll knock that back off at the end
[01:59:15] <RoanKattouw>	 because it's included with a Professional ticket
[01:59:17] <RoanKattouw>	 (same for the t-shirt)
[01:59:28] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Use flow- prefix for the CSS classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 (owner: 10Mattflaschen)
[02:00:31] <legoktm>	 ouch
[02:00:38] <legoktm>	 my favorite shell isn't listed :(
[02:00:44] <RoanKattouw>	 What?!
[02:00:46] <RoanKattouw>	 What is it?
[02:00:54] <RoanKattouw>	 (My favorite editor isn't either but I could understand that)
[02:02:05] <legoktm>	 fish!
[02:03:22] <legoktm>	 http://fishshell.com/
[02:06:17] <legoktm>	 ok, ticket bought
[02:06:31] <RoanKattouw>	 Thanks man
[02:06:38] <legoktm>	 I'll email my relatives again tonight
[02:06:46] <RoanKattouw>	 It gave you the early bird rate ($799 AUD) and says you've paid and everything?
[02:06:58] <RoanKattouw>	 (I ask because early bird-ness is only truly locked in when you pay)
[02:10:27] <legoktm>	 yes
[02:10:30] <legoktm>	 I have a pdf receipt
[02:10:35] <RoanKattouw>	 Awesome
[02:10:37] <RoanKattouw>	 Thanks man
[02:12:00] <RoanKattouw>	 Also, if you plan on staying in the campus-style accommodation arranged by the conference (Moriel and I will be staying there), then please book that soonish too
[02:12:50] <RoanKattouw>	 That's not an "OMG it's at 98%" situation, but if it does fill up somehow, we'll be out an annoying amount of money because of how affordable it is compared to alternatives
[02:13:05] <RoanKattouw>	 (The fact that there's a cycling race or whatever it is the weekend before the conference doesn't help there)
[02:42:06] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1764634 (10Mattflaschen) >>! In T109676#1763501, @Mattflaschen wrote: >>>! In T109676#1745382, @jcrespo w...
[02:49:02] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 04-1] "Re-testing, I was able to make the core links table still remember links I had already removed." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie)
[04:32:20] <grrrit-wm>	 (03CR) 10Catrope: Add an APIHandler to Echo notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 (owner: 10Mooeypoo)
[06:06:47] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4), 5WMF-deploy-2015-11-03_(1.27.0-wmf.5): MentionPresentationModel fatals for notifications with no title - https://phabricator.wikimedia.org/T116888#1764739 (10Legoktm) 5Open>3Resolved
[06:32:18] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: Invalid language code "nl_nl" - https://phabricator.wikimedia.org/T116890#1764756 (10Legoktm) >>! In T116890#1764412, @Catrope wrote: > Do things like `?uselang=isownwork` fail simil...
[07:34:27] <grrrit-wm>	 (03PS1) 10Legoktm: Fix @return doc on EchoEventPresentationModel::getPrimaryLink() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249691 
[07:35:57] <grrrit-wm>	 (03PS1) 10Legoktm: Document that text from getSecondaryLinks() isn't escaped [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249692 
[07:39:15] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10Continuous-Integration-Config: Generate doxygen for Echo on doc.wm.o - https://phabricator.wikimedia.org/T117025#1764815 (10Legoktm) 3NEW
[07:39:24] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 10Continuous-Integration-Config: Generate doxygen for Echo on doc.wm.o - https://phabricator.wikimedia.org/T117025#1764823 (10Legoktm) p:5Triage>3Low
[07:46:51] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 7Documentation: Document new Echo formatting system - https://phabricator.wikimedia.org/T116612#1764826 (10Legoktm) Started at https://www.mediawiki.org/wiki/Echo_%28Notifications%29/New_formatter_system. It needs more links and examples right now.  Also submitted https:/...
[10:53:31] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MassMessage, 10MediaWiki-extensions-AbuseFilter, and 2 others: Wrong AF variables computed for MassMessage account for edits on Flow topics - https://phabricator.wikimedia.org/T115887#1764950 (10Glaisher) 5Resolved>3Open Looks like this is still not fixed...
[10:56:42] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MassMessage, 10MediaWiki-extensions-AbuseFilter, and 2 others: Wrong AF variables computed for MassMessage account for edits on Flow topics - https://phabricator.wikimedia.org/T115887#1764955 (10Glaisher) 5Open>3Resolved It's actually fixed. https://www.mediawiki....
[11:15:03] <grrrit-wm>	 (03PS4) 10Jforrester: Run phpcs through "composer test", disabling failing rules [extensions/Echo] - 10https://gerrit.wikimedia.org/r/215269 (https://phabricator.wikimedia.org/T101074) (owner: 10Legoktm)
[11:27:50] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-Newsletter: Write presentation model for Newsletter - https://phabricator.wikimedia.org/T116856#1764981 (10Glaisher) Just found this. https://www.mediawiki.org/wiki/Echo_%28Notifications%29/New_formatter_system
[11:54:11] <grrrit-wm>	 (03PS5) 10Jforrester: Run phpcs through "composer test", disabling failing rules [extensions/Echo] - 10https://gerrit.wikimedia.org/r/215269 (https://phabricator.wikimedia.org/T101074) (owner: 10Legoktm)
[12:19:09] <grrrit-wm>	 (03PS2) 10Sbisson: Centralize tree cache keys creation in TreeCacheKey::build [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249116 (https://phabricator.wikimedia.org/T116582) 
[12:25:31] <grrrit-wm>	 (03PS3) 10Sbisson: Centralize tree cache keys creation in TreeCacheKey::build [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249116 (https://phabricator.wikimedia.org/T116582) 
[12:26:23] <grrrit-wm>	 (03CR) 10Sbisson: Centralize tree cache keys creation in TreeCacheKey::build (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249116 (https://phabricator.wikimedia.org/T116582) (owner: 10Sbisson)
[12:36:46] <grrrit-wm>	 (03PS3) 10Sbisson: Pull out isModeratedChange to check if something is a moderation action [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248473 (owner: 10Mattflaschen)
[12:45:29] <grrrit-wm>	 (03CR) 10Sbisson: [C: 032] Pull out isModeratedChange to check if something is a moderation action [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248473 (owner: 10Mattflaschen)
[12:48:08] <grrrit-wm>	 (03Merged) 10jenkins-bot: Pull out isModeratedChange to check if something is a moderation action [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248473 (owner: 10Mattflaschen)
[13:08:53] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 7WorkType-NewFunctionality: Run FlowUpdateBetaFeaturePreference.php in production - https://phabricator.wikimedia.org/T111253#1765134 (10SBisson)
[15:16:43] <grrrit-wm>	 (03CR) 10Sbisson: [C: 031] "Looks good. I'll test after you've rebased." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245621 (https://phabricator.wikimedia.org/T112230) (owner: 10Mattflaschen)
[15:20:05] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation: Write presentation models for notifications in ContentTranslation - https://phabricator.wikimedia.org/T116852#1765409 (10Amire80) Hmm, I'm not familiar with presentation models.  Is this supposed to be done in CX code or in Echo...
[16:31:34] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] Run phpcs through "composer test", disabling failing rules [extensions/Echo] - 10https://gerrit.wikimedia.org/r/215269 (https://phabricator.wikimedia.org/T101074) (owner: 10Legoktm)
[16:32:09] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Exclude deleted topics/posts from flow-reportcard stats - https://phabricator.wikimedia.org/T116797#1758758 (10matthiasmullie) Code has been merged, but new data won't regenerate before Sunday.
[16:35:11] <grrrit-wm>	 (03Merged) 10jenkins-bot: Run phpcs through "composer test", disabling failing rules [extensions/Echo] - 10https://gerrit.wikimedia.org/r/215269 (https://phabricator.wikimedia.org/T101074) (owner: 10Legoktm)
[17:04:52] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'Squiz.WhiteSpace.LanguageConstructSpacing.Incorrect' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249770 
[17:04:55] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249771 
[17:04:58] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'Generic.PHP.ForbiddenFunctions.FoundWithAlternative' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249772 
[17:05:01] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'MediaWiki.Usage.DirUsage.FunctionFound' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249773 
[17:05:04] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249774 
[17:05:07] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'PSR2.Methods.MethodDeclaration.AbstractAfterVisibility' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249775 
[17:05:10] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'PSR2.Methods.MethodDeclaration.StaticBeforeVisibility' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249776 
[17:05:13] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'PSR2.Classes.PropertyDeclaration.ScopeMissing' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249777 
[17:05:16] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'PSR2.Classes.PropertyDeclaration.VarUsed' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249778 
[17:05:19] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249779 
[17:05:22] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'Squiz.Classes.ValidClassName.NotCamelCaps' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249780 
[17:05:25] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249781 
[17:05:28] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'MediaWiki.VariableAnalysis.UnusedGlobalVariables' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249782 
[17:05:31] <grrrit-wm>	 (03PS1) 10Jforrester: build: Enable phpcs rule 'Generic.Files.LineLength' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249783 
[17:16:01] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] build: Enable phpcs rule 'Generic.Files.LineLength' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249783 (owner: 10Jforrester)
[17:18:33] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'Squiz.WhiteSpace.LanguageConstructSpacing.Incorrect' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249770 (owner: 10Jforrester)
[17:18:56] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249771 (owner: 10Jforrester)
[17:19:09] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'Generic.PHP.ForbiddenFunctions.FoundWithAlternative' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249772 (owner: 10Jforrester)
[17:19:24] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'MediaWiki.Usage.DirUsage.FunctionFound' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249773 (owner: 10Jforrester)
[17:19:32] <James_F>	 legoktm: I got carried away…
[17:20:04] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249774 (owner: 10Jforrester)
[17:20:15] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Paste in flow inserts awkward soft-newline characters that must be manually deleted - https://phabricator.wikimedia.org/T117063#1765811 (10ksmith) 3NEW
[17:20:23] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'PSR2.Methods.MethodDeclaration.AbstractAfterVisibility' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249775 (owner: 10Jforrester)
[17:21:02] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'PSR2.Methods.MethodDeclaration.StaticBeforeVisibility' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249776 (owner: 10Jforrester)
[17:21:05] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'Squiz.WhiteSpace.LanguageConstructSpacing.Incorrect' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249770 (owner: 10Jforrester)
[17:21:07] <legoktm>	 James_F: :D
[17:21:22] <James_F>	 Also apparently I screwed up the line length one.
[17:21:42] <James_F>	 (And boy does the code need a good clean up.)
[17:22:00] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'PSR2.Classes.PropertyDeclaration.ScopeMissing' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249777 (owner: 10Jforrester)
[17:22:35] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] "Uh, I think the change for this ended up in the previous patch." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249778 (owner: 10Jforrester)
[17:22:54] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249771 (owner: 10Jforrester)
[17:22:57] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249779 (owner: 10Jforrester)
[17:23:17] <James_F>	 legoktm: I imagine this makes every single outstanding patch need manual rebasing. ;-)
[17:23:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'Generic.PHP.ForbiddenFunctions.FoundWithAlternative' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249772 (owner: 10Jforrester)
[17:23:43] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "The $maintClass = '...' lines at the bottom of the files need to be updated to reflect the new class name." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249780 (owner: 10Jforrester)
[17:24:24] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'MediaWiki.Usage.DirUsage.FunctionFound' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249773 (owner: 10Jforrester)
[17:24:27] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249774 (owner: 10Jforrester)
[17:24:54] <grrrit-wm>	 (03PS2) 10Jforrester: build: Enable phpcs rule 'Squiz.Classes.ValidClassName.NotCamelCaps' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249780 
[17:25:00] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'PSR2.Methods.MethodDeclaration.AbstractAfterVisibility' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249775 (owner: 10Jforrester)
[17:25:48] <grrrit-wm>	 (03PS2) 10Jforrester: build: Enable phpcs rule 'MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249781 
[17:25:53] <grrrit-wm>	 (03PS2) 10Jforrester: build: Enable phpcs rule 'MediaWiki.VariableAnalysis.UnusedGlobalVariables' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249782 
[17:25:59] <grrrit-wm>	 (03PS2) 10Jforrester: build: Enable phpcs rule 'Generic.Files.LineLength' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249783 
[17:26:28] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'PSR2.Methods.MethodDeclaration.StaticBeforeVisibility' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249776 (owner: 10Jforrester)
[17:26:31] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'PSR2.Classes.PropertyDeclaration.ScopeMissing' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249777 (owner: 10Jforrester)
[17:26:48] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Fix @return doc on EchoEventPresentationModel::getPrimaryLink() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249691 (owner: 10Legoktm)
[17:26:52] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'PSR2.Classes.PropertyDeclaration.VarUsed' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249778 (owner: 10Jforrester)
[17:26:55] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'MediaWiki.NamingConventions.PrefixedGlobalFunctions.wfPrefix' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249779 (owner: 10Jforrester)
[17:27:38] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Document that text from getSecondaryLinks() isn't escaped [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249692 (owner: 10Legoktm)
[17:29:17] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] build: Enable phpcs rule 'Generic.Files.LineLength' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249783 (owner: 10Jforrester)
[17:32:29] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-Newsletter: Write presentation model for Newsletter - https://phabricator.wikimedia.org/T116856#1765852 (10Catrope) Yes, @Glaisher has it right. We (collaboration team) are going through all extensions and porting them to the new system (since we ar...
[17:33:21] <grrrit-wm>	 (03Merged) 10jenkins-bot: Fix @return doc on EchoEventPresentationModel::getPrimaryLink() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249691 (owner: 10Legoktm)
[17:33:23] <grrrit-wm>	 (03Merged) 10jenkins-bot: Document that text from getSecondaryLinks() isn't escaped [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249692 (owner: 10Legoktm)
[17:35:19] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'Squiz.Classes.ValidClassName.NotCamelCaps' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249780 (owner: 10Jforrester)
[17:35:34] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249781 (owner: 10Jforrester)
[17:36:12] <grrrit-wm>	 (03CR) 10Legoktm: [C: 032] build: Enable phpcs rule 'MediaWiki.VariableAnalysis.UnusedGlobalVariables' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249782 (owner: 10Jforrester)
[17:37:13] <grrrit-wm>	 (03CR) 10Legoktm: [C: 04-1] "There's a syntax error and tests are failing." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249783 (owner: 10Jforrester)
[17:39:48] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'Squiz.Classes.ValidClassName.NotCamelCaps' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249780 (owner: 10Jforrester)
[17:39:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'MediaWiki.WhiteSpace.SpaceAfterControlStructure.Incorrect' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249781 (owner: 10Jforrester)
[17:40:51] <grrrit-wm>	 (03Merged) 10jenkins-bot: build: Enable phpcs rule 'MediaWiki.VariableAnalysis.UnusedGlobalVariables' and make pass [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249782 (owner: 10Jforrester)
[17:41:49] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Flow UI encourages reply-to-topic and discourages reply-to-comment - https://phabricator.wikimedia.org/T116999#1765872 (10ksmith) @Mattflaschen: It seems that T92400 was implemented, despite being counter-intuitive. To make sure we're saying the same thing, if there is:  To...
[17:41:51] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Unable to solve captcha on RTL languages due to bad element position - https://phabricator.wikimedia.org/T116910#1765873 (10Catrope) a:3Mooeypoo
[17:43:01] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 10Gather: Write presentation models for notifications in Gather - https://phabricator.wikimedia.org/T116848#1765879 (10Mattflaschen) a:3Mattflaschen
[17:43:30] <wikibugs>	 3Collaboration-Team-Current, 10Echo: Write presentation models for all notification types - https://phabricator.wikimedia.org/T116834#1765880 (10Catrope) Documentation: https://www.mediawiki.org/wiki/Echo_%28Notifications%29/New_formatter_system
[17:43:55] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 7Tracking: Write presentation models for all notification types (tracking) - https://phabricator.wikimedia.org/T116834#1765882 (10Legoktm)
[17:45:08] <grrrit-wm>	 (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245501 (https://phabricator.wikimedia.org/T114703) (owner: 10Matthias Mullie)
[17:45:15] <grrrit-wm>	 (03CR) 10Sbisson: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/242569 (https://phabricator.wikimedia.org/T89398) (owner: 10Matthias Mullie)
[17:52:20] <grrrit-wm>	 (03PS1) 10Legoktm: Re-enable presentation model for mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249791 
[17:53:01] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Re-enable presentation model for mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249791 (owner: 10Legoktm)
[17:55:41] <grrrit-wm>	 (03Merged) 10jenkins-bot: Re-enable presentation model for mentions [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249791 (owner: 10Legoktm)
[18:21:14] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Deleted topic: 'changed the topic title' action should be filtered out from History/Recent changes etc - https://phabricator.wikimedia.org/T117069#1765993 (10Etonkovidova) 3NEW
[18:22:12] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, and 4 others: Provide an API flag to suppress auto-generated <references /> - https://phabricator.wikimedia.org/T113331#1766011 (10ssastry) Here is a summary of a lengthy IRC discussion on #mediawiki-parsoid.  @GWicke raises the concern...
[18:23:51] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Deleted topics deleted edits shouldn't appear in recent changes - https://phabricator.wikimedia.org/T116058#1766014 (10Etonkovidova) >'changed the topic title' action is still there   filed as {T117069}
[18:41:26] <grrrit-wm>	 (03PS4) 10Mooeypoo: Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 
[18:43:20] <mooeypoo>	 omg wow I created a loop that continued to fail and I stared at it and stared at it and... yeah. "for ( i = 0; test.markRead.length; i++ ) {" ...
[18:43:44] <mooeypoo>	 The importance of 2 characters
[18:43:56] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 (owner: 10Mooeypoo)
[18:44:04] <mooeypoo>	 ... don't fail me now, jenkins
[18:44:50] <mooeypoo>	 eh. grunt well, grunt often
[18:45:01] <grrrit-wm>	 (03PS5) 10Mooeypoo: Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 
[18:45:12] <grrrit-wm>	 (03PS16) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 
[18:51:15] <mooeypoo>	 anyone knows what I need to do to have captcha in my local install?
[18:51:23] <mooeypoo>	 is captcha an extension? I can't find it
[18:51:32] <matt_flaschen>	 mooeypoo, confirmedit.
[18:52:04] <stephanebisson>	 there's a mw-vagrant role
[18:52:30] <mooeypoo>	 yeah just saw it for confirmedit -- thanks!
[18:52:35] <mooeypoo>	 i'm reprovisioning now
[18:52:39] <mooeypoo>	 let's see what RTL did now
[18:52:54] <matt_flaschen>	 Yeah.  Do you think Flow should depend on ConfirmEdit?
[18:53:14] <matt_flaschen>	 I already have a patch that makes it depend on two other extensions, but that's mainly for PHPUnit: https://gerrit.wikimedia.org/r/#/c/247479/1
[18:53:23] <mooeypoo>	 Not necessarily? If 3rd party users don't want to have it, why would we force them?
[18:53:29] <mooeypoo>	 it works without it
[18:53:35] <matt_flaschen>	 Sorry, I meant in MediaWiki-Vagrant, to in Flow itself.
[18:53:42] <matt_flaschen>	 not in Flow itself
[18:53:52] <mooeypoo>	 oh, sure, yeah, it's a dev environment,so that'll help
[18:54:13] <mooeypoo>	 I told you guys about my newest acquisition, didn't I?
[18:54:21] * mooeypoo pwned the internet
[18:54:21] <stephanebisson>	 no sure
[18:54:28] <matt_flaschen>	 Don't think so, what is it? :)
[18:54:40] <mooeypoo>	 I am the recently proud owner of both http://rtl.wtf and http://ltr.wtf
[18:54:47] <mooeypoo>	 \o/
[18:55:09] <grrrit-wm>	 (03PS3) 10Mattflaschen: Use flow- prefix for the CSS classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 
[18:55:11] <mooeypoo>	 Totally going to create a playable demo in this so I can share that in LCA 
[18:55:16] <matt_flaschen>	 Nice!
[18:55:23] <stephanebisson>	 matt_flaschen: confirmedit used to interfere with some browser tests where we are creating users, I like to be able to not have it
[18:55:45] <mooeypoo>	 stephanebisson, oh, crap, so does that mean my browser tests will fail *again* now that I have it?
[18:55:50] <mooeypoo>	 I can't get a break!
[18:56:12] <matt_flaschen>	 stephanebisson, okay.  It doesn't have the same issues where it causes Flow PHPUnit to be skipped, so I'll leave it off.
[18:56:16] <stephanebisson>	 just to keep you on the edge
[18:56:50] <matt_flaschen>	 mooeypoo, didn't know .wtf was a new TLD.  Not surprised, but still :)
[18:57:14] <mooeypoo>	 matt_flaschen, I didn't either, but when I saw it, I squeed
[18:57:21] <mooeypoo>	 at least ONE thing came out of the new TLDs
[18:57:53] <mooeypoo>	 okay, how do I invoke the captcha to appear? I added the confirmedit role, I'm trying to add a topic and reply to flow as anonymous user, and I don't see the captcha
[18:58:17] <mooeypoo>	 matt_flaschen, there are seriously weird tlds now... let me find the list, it was whack
[18:58:30] <mooeypoo>	 there. enjoy: https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains
[18:58:59] <mooeypoo>	 More specifically, https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains#ICANN-era_generic_top-level_domains
[18:59:05] <matt_flaschen>	 Also, relatedly, patch to create Flow groups is https://gerrit.wikimedia.org/r/#/c/249312/ .
[18:59:06] <stephanebisson>	 mooeypoo: type in 'rtl.wtf' in your topic
[18:59:12] <matt_flaschen>	 mooeypoo, yeah, they've added a *lot*.
[18:59:19] <mooeypoo>	 stephanebisson, *while* in RTL... I think my internet will implode
[18:59:44] <stephanebisson>	 mooeypoo: you're at the boundaries of the known world...
[18:59:58] <mooeypoo>	 upside down and backwards
[19:00:15] <mooeypoo>	 okay, I can't manage to evoke captcha :\ what do I do? I enabled the role... what am I missing here?
[19:00:42] <stephanebisson>	 type [[http://google.com]]
[19:01:16] <mooeypoo>	 oh, I think I need to add a setting for which captcha to use
[19:02:21] <mooeypoo>	 ok, progress. Now I have an error message "hphp_invoke"
[19:04:06] <mooeypoo>	 crap, to set up recaptcha i need keys
[19:05:43] <matt_flaschen>	 mooeypoo, no, just leave it on FancyCaptcha.
[19:05:54] <matt_flaschen>	 It will trigger the CAPTCHA if you add an external link as a non-autoconfirmed user.
[19:06:12] <matt_flaschen>	 You shouldn't need any custom settings.
[19:07:23] <mooeypoo>	 oh, ok
[19:13:22] * RoanKattouw watches mooeypoo go down the rabbit hole
[19:14:06] <RoanKattouw>	 Turns out CAPTCHAs are always in the content language (i.e. don't respect user language), and also mess up the page layout when loaded
[19:14:08] <RoanKattouw>	 Because there are <link>, <meta> and <script> tags in the ConfirmEdit API output, of course ^_^
[19:16:31] <matt_flaschen>	 RoanKattouw, why do any of those affect layout?  They don't directly render, right?
[19:16:53] <matt_flaschen>	 I'm not surprised they're always in the content language, since they're pre-generated.  But aren't they also always in English, or was that fixed?
[19:19:38] <RoanKattouw>	 They do get injected into the DOM
[19:20:16] <matt_flaschen>	 Yeah, I realize that.  This is probably just my ignorance of RTL layout rules talking.
[19:20:16] <RoanKattouw>	 Not sure if that's why things break or not
[19:20:35] <RoanKattouw>	 We don't yet understand why things break, just that there's some very weird things in there
[19:21:43] <RoanKattouw>	 Anyway, lunch
[19:24:10] <grrrit-wm>	 (03CR) 10Mattflaschen: [C: 032] Centralize tree cache keys creation in TreeCacheKey::build [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249116 (https://phabricator.wikimedia.org/T116582) (owner: 10Sbisson)
[19:26:59] <grrrit-wm>	 (03Merged) 10jenkins-bot: Centralize tree cache keys creation in TreeCacheKey::build [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249116 (https://phabricator.wikimedia.org/T116582) (owner: 10Sbisson)
[19:31:10] <matt_flaschen>	 mooeypoo, do you have the dates for the offsite after All Hands?
[19:37:53] <matt_flaschen>	 Found it.  If anyone needs it, PM me.
[19:38:56] <etonkovidova>	 matt_flaschen: mooeypoo: it's not exactly offsite, is it?
[19:42:13] <matt_flaschen>	 et|lunch, yeah, I just created an event for it (hopefully with the right people): "Collaboration team onsite offsite"
[19:55:39] <RoanKattouw_away>	 Thanks Matt
[19:55:40] <RoanKattouw_away>	 And sorry for the auto-decline :)
[19:55:43] <RoanKattouw_away>	 Also, what do people think about doing a field trip to the Computer History Museum in Mountain View, perhaps during the weekend (9-10)
[19:58:55] <matt_flaschen>	 Big +1 to the museum.  Heard so much about it.
[20:23:21] <etonkovidova>	 matt_flaschen: onsite offsite sounds  totally right :)
[20:23:55] <matt_flaschen>	 :)
[20:32:10] <wikibugs>	 3Collaboration-Team-Current, 10Echo: Remove unused text for primary link - https://phabricator.wikimedia.org/T116892#1766491 (10Legoktm) a:5Legoktm>3None It *is* used by emails, (both plain text and html), so we need to support it in the model, but we should stop shipping it to the frontend in the Flyout f...
[21:06:10] <mooeypoo>	 matt_flaschen, meh. You're not going to like this fix/hack for captcha
[21:06:53] <matt_flaschen>	 mooeypoo, what is it?
[21:07:25] <mooeypoo>	 i'm going to push in a second, hang on
[21:10:04] <grrrit-wm>	 (03PS1) 10Mooeypoo: Clean up captcha form and remove <link> to stylesheet [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249882 (https://phabricator.wikimedia.org/T116910) 
[21:10:21] * mooeypoo gives matt_flaschen a throw up bucket and sneaks out for a break
[21:10:23] <mooeypoo>	 brb
[21:11:10] <mooeypoo>	 matt_flaschen, specifically, look here: https://gerrit.wikimedia.org/r/#/c/249882/1/modules/flow/dm/api/mw.flow.dm.APIHandler.js
[21:11:12] <mooeypoo>	 brb
[21:14:07] <matt_flaschen>	 mooeypoo, yeah, I would like to see if we can update ConfirmEdit.  If not, this should go on top of my CAPTCHA refactoring (still mergable!) (https://gerrit.wikimedia.org/r/#/c/234423/) (probably in CAPTCHAWidget).
[21:14:36] <matt_flaschen>	 I kind of assumed that refactoring was already merged.  That was excessively optimistic.
[21:14:49] <grrrit-wm>	 (03PS1) 10Legoktm: Move some boilerplate code into EchoEventFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249884 
[21:14:52] <grrrit-wm>	 (03PS1) 10Legoktm: [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 
[21:16:35] <matt_flaschen>	 Meanwhile, I found out the link table issue does not happen on master, but I'm still isolating it.
[21:20:00] <grrrit-wm>	 (03CR) 10jenkins-bot: [V: 04-1] [WIP] Add plain text email formatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249885 (owner: 10Legoktm)
[21:22:56] <grrrit-wm>	 (03PS2) 10Legoktm: Move some boilerplate code into EchoEventFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249884 
[21:29:54] <grrrit-wm>	 (03PS2) 10Mooeypoo: Clean up captcha form and remove <link> to stylesheet [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249882 (https://phabricator.wikimedia.org/T116910) 
[21:30:14] <mooeypoo>	 matt_flaschen, yeah we should fix confirmEdit, but this is a good defense. I updated with RoanKattouw_away's advice to remove all "offending" tags
[21:31:05] <RoanKattouw>	 Yeah, my idea was 1) get a quick & dirty fix done, cherry-picked and SWATed, 2) fix it in the backend, 3) integrate whatever needs to be integrated with your refactor
[21:35:02] <matt_flaschen>	 RoanKattouw, alright, no objection.  Let me know if you want me to review.  Otherwise I will keep working on the link bug.
[21:36:05] <RoanKattouw>	 I'll review it
[21:36:11] <RoanKattouw>	 and handle the SWAT etc
[21:36:29] <RoanKattouw>	 What is the link bug?
[21:39:33] <matt_flaschen>	 RoanKattouw, see my comment at https://gerrit.wikimedia.org/r/#/c/238393/ .  I think I found another related issue as well now.  Seems to only be with that change, so not in Phabricator.
[21:39:56] <RoanKattouw>	 Oh, that
[21:44:05] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: References in isolated posts, create duplicate "[1]" (#cite_note-1) links - https://phabricator.wikimedia.org/T108398#1766818 (10ssastry) >>! In T108398#1533403, @Catrope wrote: > This seems to partly be an issue in Cite (or Parsoid's implementation of Cite?) where using it...
[21:54:02] <wikibugs>	 3Collaboration-Team-Current, 10Flow: Requests to the API should return CAPTCHA in the UI language - https://phabricator.wikimedia.org/T117112#1766879 (10Mooeypoo) 3NEW a:3Mooeypoo
[21:56:41] <matt_flaschen>	 mooeypoo, do you mean the actual CAPTCHA image, or just the surrounding UI text?
[21:56:49] <RoanKattouw>	 The text
[21:56:54] <mooeypoo>	 the offender is the CSS actually
[21:57:00] <RoanKattouw>	 Oh right that too
[21:57:01] <mooeypoo>	 but yeah, the text
[21:57:11] <mooey|mtg>	 bbiab
[21:58:06] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): Requests to the API should return CAPTCHA in the UI language - https://phabricator.wikimedia.org/T117112#1766898 (10Mattflaschen)
[22:09:33] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): Requests to the API should return CAPTCHA in the UI language - https://phabricator.wikimedia.org/T117112#1766945 (10Florian) Sorry, I don't get it, do you have an example (query)? Is this really Api-related?
[22:10:14] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-ConfirmEdit-(CAPTCHA-extension): Requests to the API should return CAPTCHA in the UI language - https://phabricator.wikimedia.org/T117112#1766952 (10Catrope) Most likely Flow just needs to pass `uselang` as a query parameter to the API request.
[22:16:54] <matt_flaschen>	 I think the colon thing bit us again.
[22:17:14] <matt_flaschen>	 Actually, not sure.
[22:26:59] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] "This may break styles or scripts that CAPTCHAs try to add, but that's still better than having them not work at all in RTL languages." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249882 (https://phabricator.wikimedia.org/T116910) (owner: 10Mooeypoo)
[22:29:46] <grrrit-wm>	 (03Merged) 10jenkins-bot: Clean up captcha form and remove <link> to stylesheet [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249882 (https://phabricator.wikimedia.org/T116910) (owner: 10Mooeypoo)
[22:31:17] <grrrit-wm>	 (03PS1) 10Catrope: Clean up captcha form and remove <link> to stylesheet [extensions/Flow] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249910 (https://phabricator.wikimedia.org/T116910) 
[22:34:06] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Move some boilerplate code into EchoEventFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249884 (owner: 10Legoktm)
[22:36:42] <grrrit-wm>	 (03Merged) 10jenkins-bot: Move some boilerplate code into EchoEventFormatter [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249884 (owner: 10Legoktm)
[22:37:57] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Switch User_talk:Amire80 in en.wikipedia, mediawiki.org and meta.wikimedia.org to Flow - https://phabricator.wikimedia.org/T107148#1767051 (10DannyH) 5Open>3Resolved resolved to the extent that it can be right now.
[22:38:47] <wikibugs>	 6Collaboration-Team-Backlog, 10Flow: Editing description on a brand new board doesn't show the new description - https://phabricator.wikimedia.org/T106459#1767055 (10DannyH) a:5DannyH>3None
[22:39:33] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 7Design: Special:Notifications does not mirror the read/unread statuses from the echo flyout - https://phabricator.wikimedia.org/T78363#1767059 (10DannyH) a:5DannyH>3None
[22:46:42] <etonkovidova>	 matt_flaschen: RoanKattouw: do you know that Flow boards cannot be searched for topic titles or content? I am surprised...
[22:47:19] <RoanKattouw>	 Yeah :S before the reprioritization, we were going to work on a search feature this quarter
[22:48:43] <etonkovidova>	 RoanKattouw: I thought that it's a "global" feature -all pages in all namespaces are indexed 
[22:49:06] <RoanKattouw>	 Are you saying the normal search doesn't work either?
[22:49:11] <RoanKattouw>	 I wasn't quite sure whether that worked or not
[22:49:37] <etonkovidova>	 RoanKattouw: yup  -the normal search does not work
[22:49:46] <etonkovidova>	 RoanKattouw: even google :)
[22:54:51] <wikibugs>	 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Unable to solve captcha on RTL languages due to bad element position - https://phabricator.wikimedia.org/T116910#1767150 (10Catrope) >>! In T116910#1766752, @gerritbot wrote: > Change 249882 had a related patch set uploaded (by Mooeypoo): > Clean up cap...
[22:55:05] <matt_flaschen>	 Google works.
[22:55:06] <matt_flaschen>	 https://www.google.com/?gws_rd=ssl#q=mediawiki.org+Talk:Sandbox
[22:55:11] <matt_flaschen>	 etonkovidova, but yeah, it sucks. :(
[22:59:52] <etonkovidova>	 matt_flaschen:yeah- sigh  -  google does not find MavetunaET24 which is used in a topic title and in content
[23:01:51] <matt_flaschen>	 etonkovidova, when did you add it?  They sometimes take a little while to update their index.
[23:02:28] <etonkovidova>	 matt_flaschen: about 10 min...
[23:03:57] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Clean up captcha form and remove <link> to stylesheet [extensions/Flow] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249910 (https://phabricator.wikimedia.org/T116910) (owner: 10Catrope)
[23:04:17] <etonkovidova>	 matt_flaschen:  I am not concerned about google:) When I add smth to a normal wiki page - it's searchable immediately in wiki search
[23:05:13] <matt_flaschen>	 etonkovidova, yeah, I agree, it sucks that it's not searchable.  If I were prioritizing, order would have been rather different.
[23:05:41] <matt_flaschen>	 Speaking of sucking...
[23:05:47] <matt_flaschen>	 Who thinks these have the same output?
[23:05:48] <matt_flaschen>	 $input = array( 'ref_src_wiki' => 'wiki', 'ref_src_namespace' => 191, 'ref_src_title' => '2015-10-29_missing_link_retest' ); sort( $input ); echo wfForeignMemcKey( 'wiki', '', 'flow_ref:wiki:by-source:v3', md5( implode( ':', $input ) ), '4.7' )
[23:06:00] <matt_flaschen>	 $input = array( 'ref_src_namespace' => 191, 'ref_src_title' => '2015-10-29_missing_link_retest', 'ref_src_wiki' => 'wiki' ); sort( $input ); echo wfForeignMemcKey( 'wiki', '', 'flow_ref:wiki:by-source:v3', md5( implode( ':', $input ) ), '4.7' )
[23:06:33] <etonkovidova>	 matt_flaschen: right! :))
[23:07:34] <matt_flaschen>	 At the very bottom of sort function documentation:
[23:07:39] <matt_flaschen>	 "Be careful when sorting arrays with mixed types values because sort() can produce unpredictable results."
[23:08:04] <matt_flaschen>	 By which we mean, "haha never do this.  We only put in this feature for that guy who makes conference presentations about wtf."
[23:09:13] <RoanKattouw>	 WTF seriously?
[23:09:36] <RoanKattouw>	 I guess you could call that a Gary Bernhardt feature
[23:09:41] <RoanKattouw>	 And I suppose what we want there is ksort()?
[23:10:30] <grrrit-wm>	 (03Merged) 10jenkins-bot: Clean up captcha form and remove <link> to stylesheet [extensions/Flow] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249910 (https://phabricator.wikimedia.org/T116910) (owner: 10Catrope)
[23:13:01] <matt_flaschen>	 RoanKattouw, yeah, I was thinking of using SORT_STRING, but your suggestion is better as long as there are always keys, which there should be. 
[23:23:29] <wikibugs>	 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 7Regression: Add 'target-page' for edit-user-talk - https://phabricator.wikimedia.org/T112477#1767265 (10Huji) 5Open>3Resolved Closing it as it now appears to have been actually resolved.
[23:25:26] <quiddity>	 I'm going afk early today. Might be back later.
[23:31:17] <grrrit-wm>	 (03PS1) 10Catrope: Follow-up 65cc2f6c1d: [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249924 
[23:32:00] <grrrit-wm>	 (03CR) 10Mooeypoo: [C: 032] Follow-up 65cc2f6c1d: [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249924 (owner: 10Catrope)
[23:34:27] <grrrit-wm>	 (03PS2) 10Bartosz Dziewoński: Follow-up 65cc2f6c1d: [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249924 (owner: 10Catrope)
[23:34:38] <grrrit-wm>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Couldn't resist!" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249924 (owner: 10Catrope)
[23:39:42] <grrrit-wm>	 (03PS1) 10Mooeypoo: Get captcha text in user language [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249926 (https://phabricator.wikimedia.org/T116910) 
[23:42:03] <grrrit-wm>	 (03CR) 10Catrope: [C: 032] Get captcha text in user language [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249926 (https://phabricator.wikimedia.org/T116910) (owner: 10Mooeypoo)
[23:50:54] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 7I18n, 7Voice & Tone: Links on notification-page-linked, -bundle, -flyout etc. - https://phabricator.wikimedia.org/T69942#1767373 (10jrbs)
[23:56:10] <wikibugs>	 6Collaboration-Team-Backlog, 10Echo, 7I18n, 7Voice & Tone: Some Echo issues of GENDER and untranslatability - https://phabricator.wikimedia.org/T63904#1767386 (10jrbs)