[00:02:30] quiddity: Did you get any more feedback re namespace name for ptwikibooks? [00:02:51] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-Newsletter: Write presentation model for Newsletter - https://phabricator.wikimedia.org/T116856#1760262 (10Catrope) p:5Triage>3High [00:02:57] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-OpenStackManager: Write presentation models for notifications in OpenStackManager - https://phabricator.wikimedia.org/T116853#1760264 (10Catrope) p:5Triage>3High [00:03:01] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation: Write presentation models for notifications in ContentTranslation - https://phabricator.wikimedia.org/T116852#1760266 (10Catrope) p:5Triage>3High [00:03:04] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-BounceHandler: Write presentation model for BounceHandler - https://phabricator.wikimedia.org/T116851#1760268 (10Catrope) p:5Triage>3High [00:03:06] RoanKattouw, not onwiki. Just the one comment on phab. [00:03:09] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-EducationProgram: Write presentation models for notifications in EducationProgram - https://phabricator.wikimedia.org/T116850#1760270 (10Catrope) p:5Triage>3High [00:03:19] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-PageCuration: Write presentation models for notifications in PageTriage - https://phabricator.wikimedia.org/T116849#1760271 (10Catrope) p:5Triage>3High [00:03:26] 3Collaboration-Team-Current, 10Echo, 10Gather: Write presentation models for notifications in Gather - https://phabricator.wikimedia.org/T116848#1760272 (10Catrope) p:5Triage>3High [00:03:31] 3Collaboration-Team-Current, 10Echo, 10Thanks: Write presentation models for notifications in Thanks - https://phabricator.wikimedia.org/T116847#1760273 (10Catrope) p:5Triage>3High [00:03:39] 3Collaboration-Team-Current, 10Echo: Write presentation models for notifications in Echo - https://phabricator.wikimedia.org/T116843#1760274 (10Catrope) p:5Triage>3High [00:04:01] also, I'll do that phab batch edit, later tonight [00:07:12] 3Collaboration-Team-Current, 10Echo: Write presentation models for all notification types - https://phabricator.wikimedia.org/T116834#1760289 (10Catrope) p:5Triage>3High [00:11:03] Thanks, quiddity [00:15:24] (03CR) 10Mattflaschen: Add artificial primary key to flow_wiki_ref and flow_ext_ref (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [00:16:00] quiddity: Also, what are your thoughts on https://phabricator.wikimedia.org/T116611 ? [00:18:07] (03PS8) 10Catrope: Add an APIHandler to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 (owner: 10Mooeypoo) [00:19:47] (03PS5) 10Mattflaschen: Add artificial primary key to flow_wiki_ref and flow_ext_ref [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [00:20:01] RoanKattouw, My thoughts are complicated. Trizek and I advocate hesitation, but I believe James has decided per the conversation he mentions, placing the burden on those 2. (ie. goforit) [00:20:28] You mean do it and blame James and Lydia if it goes wrong? [00:20:55] yup [00:21:06] k [00:22:52] You can add me to the hesitant list. [00:23:10] What's the reason to try to speed it on this particular wiki? [00:24:12] Was there a community discussion about it? [00:24:16] I've got to go in ~10 minutes. [00:25:10] (03PS6) 10Mattflaschen: Add artificial primary key to flow_wiki_ref and flow_ext_ref [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [00:28:10] (03CR) 10Mattflaschen: "We should remove the special code that creates a UUID when reading the DB, maybe after a major version" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [00:29:50] matt_flaschen: Wikidatan's love Flow apparently. [00:35:23] See you tomorrow. [01:18:34] (03CR) 10Catrope: [C: 04-1] Add an APIHandler to Echo notifications (0314 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 (owner: 10Mooeypoo) [01:21:54] (03CR) 10Catrope: [C: 04-1] "Looks good, one minor thing inline" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 (owner: 10Mooeypoo) [01:29:55] (03CR) 10Catrope: [C: 04-1] Allow notification model and widget to show combined notifications (036 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 (owner: 10Mooeypoo) [01:31:45] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration: Speedy deletion tags logged twice - https://phabricator.wikimedia.org/T86631#1760370 (10Quiddity) [01:31:46] 6Collaboration-Team-Backlog, 10Flow: Flow should know how to attach to wikis or groups of people - https://phabricator.wikimedia.org/T68947#1760371 (10Quiddity) [01:31:48] 6Collaboration-Team-Backlog, 10Thanks: Add a way to thank users for new articles - https://phabricator.wikimedia.org/T58155#1760374 (10Quiddity) [01:31:50] 6Collaboration-Team-Backlog, 10Echo: Username mention email notification should be suppressed by enotifwatchlist when both are applicable - https://phabricator.wikimedia.org/T55878#1760375 (10Quiddity) [01:31:52] 6Collaboration-Team-Backlog, 10Echo, 7Easy: "Show changes" link for page link notifications - https://phabricator.wikimedia.org/T52629#1760377 (10Quiddity) [01:31:54] 6Collaboration-Team-Backlog, 10Echo, 7Easy: Echo: User rights change : Link to specific row of table that is applicable - https://phabricator.wikimedia.org/T55860#1760378 (10Quiddity) [01:31:58] 6Collaboration-Team-Backlog, 10Thanks, 7Design: Echo's "thanked you for your edit" should also link to thanker user page in email notification - https://phabricator.wikimedia.org/T49511#1760381 (10Quiddity) [01:32:00] 6Collaboration-Team-Backlog, 10Echo: Can't hide items on Special:Notifications - https://phabricator.wikimedia.org/T48692#1760383 (10Quiddity) [01:32:25] 3Collaboration-Team-Current, 10Echo, 10Thanks: Write presentation models for notifications in Thanks - https://phabricator.wikimedia.org/T116847#1760386 (10Catrope) See also {T49511} [01:32:57] 3Collaboration-Team-Current, 10Echo: Write presentation models for notifications in Echo - https://phabricator.wikimedia.org/T116843#1760389 (10Catrope) See also {T52629} [01:35:22] (03CR) 10Aaron Schulz: [C: 032] Fix page-linked notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249318 (https://phabricator.wikimedia.org/T116485) (owner: 10Legoktm) [01:37:01] RoanKattouw, I just batch edited 8. If there are no objections to the result, I'll do the remaining 186 now. [01:37:08] LGTM [01:37:56] (03Merged) 10jenkins-bot: Fix page-linked notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249318 (https://phabricator.wikimedia.org/T116485) (owner: 10Legoktm) [01:38:04] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Ignore accents for purposes of mention matching? - https://phabricator.wikimedia.org/T94274#1760395 (10Quiddity) [01:38:05] 6Collaboration-Team-Backlog, 10Flow: Menu items have no highlight - https://phabricator.wikimedia.org/T93649#1760396 (10Quiddity) [01:38:06] 6Collaboration-Team-Backlog, 10Flow: Evaluate what tags (Special:Tags) to add - https://phabricator.wikimedia.org/T93313#1760399 (10Quiddity) [01:38:08] 6Collaboration-Team-Backlog, 10Flow, 7I18n: The message flow-preview-warning is used for comments and for new topics - https://phabricator.wikimedia.org/T93348#1760397 (10Quiddity) [01:38:10] 6Collaboration-Team-Backlog, 10Flow: Flow sandbox on every wiki - https://phabricator.wikimedia.org/T91723#1760402 (10Quiddity) [01:38:12] 6Collaboration-Team-Backlog, 10Flow, 7JavaScript: When a user is replying to a specific comment, flow should highlight it - https://phabricator.wikimedia.org/T91807#1760400 (10Quiddity) [01:38:14] 6Collaboration-Team-Backlog, 10Flow: Batch requests for titles used in Redlinker - https://phabricator.wikimedia.org/T91719#1760403 (10Quiddity) [01:38:16] 6Collaboration-Team-Backlog, 10Flow: Flow: Disable VE editor if not installed - https://phabricator.wikimedia.org/T91136#1760405 (10Quiddity) [01:38:25] poor wikibugs. ;_; [01:39:27] 6Collaboration-Team-Backlog, 10Flow: Add a README - https://phabricator.wikimedia.org/T65125#1760557 (10Quiddity) [01:39:27] 6Collaboration-Team-Backlog, 10Flow: Flow: a topic with a suppressed comment displays to non-oversighters as having "1 comment", despite no comments being visible - https://phabricator.wikimedia.org/T65657#1760556 (10Quiddity) [01:39:28] 6Collaboration-Team-Backlog, 10Flow: Flow: Pages designated for Flow that have no content and have never had content should not have a history tab - https://phabricator.wikimedia.org/T64903#1760559 (10Quiddity) [01:40:10] all done. [01:40:40] 6Collaboration-Team-Backlog, 10Thanks: Add thanks links on Special:Watchlist and Special:Contributions - https://phabricator.wikimedia.org/T51541#1760704 (10Quiddity) [01:40:40] 6Collaboration-Team-Backlog, 10Echo, 5Patch-For-Review: Notifications page HTML markup - https://phabricator.wikimedia.org/T51269#1760706 (10Quiddity) [01:40:41] 6Collaboration-Team-Backlog, 10Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake - https://phabricator.wikimedia.org/T51087#1760707 (10Quiddity) [01:42:25] ok, dinnertime. [01:43:24] I agree [01:53:48] 6Collaboration-Team-Backlog, 10MediaWiki-extensions-PageCuration, 10MediaWiki-Database, 10MediaWiki-Page-protection: Move writes on read requests to the job queue - https://phabricator.wikimedia.org/T88143#1760790 (10aaron) [05:21:44] 3Collaboration-Team-Current, 10Echo, 10Thanks: Write presentation models for notifications in Thanks - https://phabricator.wikimedia.org/T116847#1760919 (10Catrope) a:3Catrope [05:22:17] 3Collaboration-Team-Current, 10Echo: Write presentation models for all notification types - https://phabricator.wikimedia.org/T116834#1760922 (10Catrope) [05:24:18] (03PS1) 10Legoktm: Fix page-linked notifications [extensions/Echo] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249351 (https://phabricator.wikimedia.org/T116485) [05:35:23] 3Collaboration-Team-Current, 10Echo, 10Wikidata, 5MW-1.27-release-notes, and 3 others: Echo should not notify the user about his own linking activity - https://phabricator.wikimedia.org/T116485#1760933 (10Legoktm) I've scheduled backports to wmf4 during tomorrow morning's SWAT. It depends on some code that... [05:59:10] 6Collaboration-Team-Backlog, 10Echo: Allow secondary actions to have icons and subtitles/tooltips - https://phabricator.wikimedia.org/T115421#1760935 (10Catrope) Right now `EchoEventPresentationModel::getSecondaryLinks()` returns `array( url => text )`. @legoktm, how do you think this could best be extended to... [06:03:16] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Vagrant, 5Patch-For-Review: Have 'flow-suppress' work on MediaWiki-Vagrant out of the box - https://phabricator.wikimedia.org/T113641#1760939 (10Ajraddatz) So I'm still not sure why we need two groups. Two very obvious options: 1. Add flow-suppress to the ov... [06:06:45] 6Collaboration-Team-Backlog, 10Echo: Allow secondary actions to have icons and subtitles/tooltips - https://phabricator.wikimedia.org/T115421#1760941 (10Legoktm) Is the subtitle different from the currently unused text? Something like: ``` lang=php return array( 'url' => array( 'text' => '...', '... [06:36:43] 3Collaboration-Team-Current, 10Echo: MentionPresentationModel fatals for notifications with no title - https://phabricator.wikimedia.org/T116888#1760949 (10Catrope) 3NEW a:3Legoktm [06:36:51] I er. [06:38:31] also, wtf [06:38:32] MWException from line 4420 of /srv/mediawiki/php-1.27.0-wmf.3/languages/Language.php: Invalid language code "nl_nl" [06:39:01] 3Collaboration-Team-Current, 10Echo: MentionPresentationModel fatals for notifications with no title - https://phabricator.wikimedia.org/T116888#1760967 (10Catrope) The error is ` PHP Fatal error: Call to a member function getText() on a non-object in /home/catrope/git/mediawiki/extensions/Echo/includes/forma... [06:39:39] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: Invalid language code "nl_nl" - https://phabricator.wikimedia.org/T116890#1760970 (10Legoktm) 3NEW [06:39:55] (03PS1) 10Catrope: Comment out presentation model for mentions since it fatals on deleted pages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249354 (https://phabricator.wikimedia.org/T116888) [06:41:59] legoktm: WTF, nl_nl? [06:42:00] legoktm: BTW, let's merge + morning-SWAT https://gerrit.wikimedia.org/r/249354 unless there's an obvious fix I don't see [06:42:23] yes [06:42:46] RoanKattouw: can you add the bug number next to the commented out line? [06:44:19] 6Collaboration-Team-Backlog, 10Echo: Allow secondary actions to have icons and subtitles/tooltips - https://phabricator.wikimedia.org/T115421#1760991 (10Catrope) >>! In T115421#1760941, @Legoktm wrote: > Is the subtitle different from the currently unused text? > Yes. The currently unused text is for the prim... [06:44:28] legoktm: Yes, sorry, I thought I had [06:44:43] lol there's even a trailing space because I was preparing to paste it in [06:45:05] (03PS2) 10Catrope: Comment out presentation model for mentions since it fatals on deleted pages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249354 (https://phabricator.wikimedia.org/T116888) [06:45:07] there [06:46:03] (03CR) 10Legoktm: [C: 032] Comment out presentation model for mentions since it fatals on deleted pages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249354 (https://phabricator.wikimedia.org/T116888) (owner: 10Catrope) [06:46:27] the good news is that I forgot to remove the then-unused i18n messages: https://gerrit.wikimedia.org/r/#/c/232632/10/i18n/en.json,cm [06:46:57] 3Collaboration-Team-Current, 10Echo: Remove unused text for primary link - https://phabricator.wikimedia.org/T116892#1760992 (10Catrope) 3NEW a:3Legoktm [06:47:11] ha [06:47:34] Oh, I see [06:47:38] Which you didn't to for userrights [06:48:56] BTW I noticed this bug because I was working on converting the Thanks notifications, and stumbled upon setTitleLink [06:49:11] while figuring out how the Flow notification formatter built its links [06:49:19] [no page] strikes back :S [06:49:38] The good news is, I'm halfway done with those [06:51:05] sigh. [06:51:07] I remember this [06:51:29] there's no way to differentiate between a deleted page (ok to show) and a suppressed page (not ok) [06:51:55] (03Merged) 10jenkins-bot: Comment out presentation model for mentions since it fatals on deleted pages [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249354 (https://phabricator.wikimedia.org/T116888) (owner: 10Catrope) [06:52:21] Right [06:52:39] And the title is null even after the page is restored [06:52:50] I mean I would be OK with not showing deleted pages [06:52:54] the EchoTitleLocalCache usage in EchoEvent::getTitle() looks fishy, but that's another issue [06:53:33] But, 1) it would be nice if we could re-show their titles after undeletion (otherwise it's trivial to sabotage people's notifications through deletion vandalism; although I guess delete rights are privileged so that's not that big of a deal) [06:53:59] page_id isn't a stable identifier [06:54:08] and 2) if the page is deleted or suppressed, I would prefer omitting the notification entirely rather than barfing [no page] into it, which in the current system breaks wikitext as well [06:54:33] omitting the notification is actually really easy [06:55:12] I think we should either have a nice styled (page deleted) like we have for (username removed) or hide it entirely [06:55:19] right [06:55:37] The former would be easier actually, now that we don't have links in the notif text any more [06:55:54] Secondary links that would point to the page would just be omitted [06:56:16] We would have to allow for the primary link to be empty string or something, if it would otherwise be a link to the deleted page [06:56:39] if a notification doesn't have a primary link, it's useless [06:56:51] I guess that's true [06:57:25] Why is it that we can't differentiate between deleted and suppressed titles? [06:58:35] deletion = log entry with delete/delete, rows move to archive table. suppress = log entry with suppress/delete, rows move to archive table with extra bit flag [06:59:03] there might be a hook we can listen to [06:59:23] Right, given that we don't appear to check at render time but use a hook already [06:59:36] er, we don't use a hook? [06:59:48] Then how come a notification stays broken when the page is undeleted? [06:59:49] it is checked at render time [06:59:53] I assumed we used a hook for that reason [06:59:54] because the page_id is different [06:59:58] D'OH [07:00:01] Right [07:00:14] also this is in a serialized blob so we can't easily do updates on it [07:00:42] Well, using the page id instead of the page title allows us to deal with moves transparently [07:00:49] And moves are presumably more common than delete+restore [07:01:26] right [07:01:47] Random other question: why is EchoEventPresentationModel::$user private? It says that it's only for permissions checking, but how can I {{GENDER}} things for the correct user? [07:02:03] (Right now {{GENDER:|you}} would work because $wgUser is correct, but that falls apart for emails) [07:02:46] hmm [07:03:19] RoanKattouw: you need to use gender outside of the header message? [07:03:35] No this is in the header message [07:03:47] the header already has gender in $2 [07:03:51] The gender of the agent [07:03:53] Not of the viewing user [07:04:09] wait, [07:04:22] I have to do something like $1 {{GENDER:$2|thanked}} {{GENDER:$4|you}} for $3 [07:04:25] ohh [07:05:32] Which Thanks currently supports for flow-thank but not edit-thank <_< [07:06:35] I can't immediately think of an example where you'd need it in a language I speak, except maybe if you used the passive voice in French [07:06:43] .....and now that I look at fr.json, that's actually exactly what it does [07:06:59] "notification-flow-thanks": "[[User:$1|$1]] vous a {{GENDER:$5|remercié|remerciée}} pour $2 dans « $3 » sur [[:$4]].", [07:07:05] "notification-flow-thanks-flyout": "[[User:$1|$1]] {{GENDER:$4|vous}} a remercié pour votre commentaire dans « $2 » sur $3.", [07:07:14] you could use User::newFromId( $event->getExtraParam( 'thanked-user-id' ) )->getName(); [07:07:27] The latter has the masculine form hardcoded due to lack of gender support it seems, or maybe they were just lazy [07:07:32] oooooh right [07:07:35] Good catch [07:07:44] I did have a reason for making it private, and I'm trying to think of why now [07:09:02] so, going back to mention [07:09:14] I think if we can't give a primary link, we should just not display it [07:09:59] Makes sense [07:10:08] We can't link to the mention anyway [07:19:58] mlitn: The root of a post is always the topic, right? [07:20:11] yes [07:20:32] Specifically, I'm looking at why the links in Flow thank notifications are of the form /wiki/Talk:Main_Page?workflow=abc123 which then redirects to /wiki/Topic:Abc123 [07:20:47] AFAICT it's always like that, so we should be able to bypass the redirect [07:22:55] probably no reason [07:23:04] we didn’t originally have Topic namespace [07:23:50] Ooh, right [07:23:53] So maybe it's just very old [07:23:57] I guess noone ever got around to changing the link in Thanks [07:24:10] probably [07:27:22] (03PS1) 10Catrope: Convert Echo notifications to the new system [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 [07:27:35] (03CR) 10Catrope: [C: 04-2] "Fatals on deleted pages" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 (owner: 10Catrope) [07:28:19] (03PS2) 10Catrope: Convert Echo notifications to the new system [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 (https://phabricator.wikimedia.org/T116847) [07:45:34] (03PS1) 10Catrope: FlowThanksPresentationModel: Use NS_TOPIC directly instead of obsolete &workflow= parameter [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249359 [07:47:24] (03CR) 10Catrope: "What worries me a bit about this is that this makes rendering of flow-thank notifications require Flow (because of NS_TOPIC), whereas righ" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249359 (owner: 10Catrope) [07:47:55] mlitn: So https://gerrit.wikimedia.org/r/#/c/249359/1/FlowThanksPresentationModel.php is what I ended up with but I'm not sure the additional complications are worth it [07:48:04] (See also my comment about depending on Flow for rendering Flow notifs) [07:49:09] legoktm: I guess maybe we need a canRender() function or something? For flow-thank notifs it could check if Flow is still installed, and for e.g. mention notifs it could check that the title isn't null [07:50:22] RoanKattouw: yeah, something like that [07:53:16] RoanKattouw, legoktm: BTW, I had exciting chats with Daniel about primary vs. derived 'slots' for revisions, and having multi-content-type revisions. But both of you should be asleep. :-P [07:54:19] RoanKattouw: (Did you see https://phabricator.wikimedia.org/P2245 and if so are the Collaboration ones fixed?) [07:54:50] Ooh thanks [07:54:57] MentionTargetInputWidget is fixed [07:55:14] mw.flow.dm.List.js is documentation-only and being upstreamed anyway [07:55:31] Kk. [07:55:34] mw.echo.dm.List.js ditto [07:55:38] No other collab ones AFAICT [07:55:42] * James_F nods. [07:55:51] Feel free to fix the others. ;-) [07:55:59] But seriously, not at 01:00. :-P [07:56:59] James_F: it's not 1am yet :P [07:59:41] (03PS1) 10Catrope: EventPresentationModel: Add getDiffURL() helper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249360 [08:00:26] (03PS1) 10Catrope: Use getDiffURL() from Echo [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249361 [08:00:48] that ---^ is just a trial balloon from me, feel free to shoot it down if you think random-ass helpers like that don't belong in the base class [08:06:07] * legoktm will look in the other morning [08:09:27] (03CR) 10Matthias Mullie: "Mmh. We could check if the constant is defined before using it, but ideally we'd not render the notification at all if Flow no longer exis" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249359 (owner: 10Catrope) [08:13:04] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo) [09:54:27] 6Collaboration-Team-Backlog, 10Echo: Allow secondary actions to have icons and subtitles/tooltips - https://phabricator.wikimedia.org/T115421#1761196 (10Pginer-WMF) > secondary items need to specify an icon, text for their subtitle/tooltip (depending on rendering mode), and whether they are rendered outside th... [10:09:43] 6Collaboration-Team-Backlog, 10Echo, 7Epic, 7WorkType-NewFunctionality: Notifications Panel: Support cross-wiki notifications - https://phabricator.wikimedia.org/T114350#1761242 (10Pginer-WMF) [10:09:45] 3Collaboration-Team-Current, 10Echo, 6Design-Research, 5Design Research and product team collaboration, and 2 others: Validate initial design ideas for the cross-wiki notification panel - https://phabricator.wikimedia.org/T114086#1761240 (10Pginer-WMF) 5Open>3Resolved I think we can declare this ticket... [10:25:31] 6Collaboration-Team-Backlog, 10Flow: If page content is a group of templates, talk page conversion to Flow does not archive the old content - https://phabricator.wikimedia.org/T116787#1761274 (10Trizek-WMF) I don't manage anymore to see the diff between the old page and the new one. The old page has all these... [10:28:54] 6Collaboration-Team-Backlog, 10Flow: If page content is a group of templates, talk page conversion to Flow does not archive the old content - https://phabricator.wikimedia.org/T116787#1761278 (10Trizek-WMF) Ok, I've found the archive : https://fr.wikipedia.org/wiki/Discussion_utilisateur:%D4%B1%D5%B7%D5%B8%D5%... [11:04:19] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Revert notifications in Echo on Wikidata should display label as well as Q id - https://phabricator.wikimedia.org/T116762#1761351 (10matej_suchanek) A possible temporary hack: changing the local page ``` Your {{PLU... [11:09:20] 6Collaboration-Team-Backlog, 10Flow: Better warn of detected wikitext on Flow VE mode - https://phabricator.wikimedia.org/T116900#1761369 (10Pginer-WMF) [11:10:51] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1761380 (10SBisson) >>! In T94029#1758417, @matthiasmullie wrote: > Blocked on https://gerrit.wikimedia.org/r/#/c/247575/. Only after that h... [11:12:15] 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 10VisualEditor, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1761384 (10Pginer-WMF) > I may have other examp... [11:13:22] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Redirects, 6operations, and 2 others: Flow notification links on mobile point to desktop - https://phabricator.wikimedia.org/T107108#1761393 (10SBisson) What is blocking this ticket? [11:42:03] (03CR) 10Siebrand: [C: 031] "i18n/L10n reviewed." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 (https://phabricator.wikimedia.org/T116847) (owner: 10Catrope) [12:12:51] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-Newsletter: Write presentation model for Newsletter - https://phabricator.wikimedia.org/T116856#1761516 (10Qgil) /me is intrigued, trying to understand the description and the parent task. In any case, thank you for helping improving the Newsletter... [12:16:49] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-Newsletter: Write presentation model for Newsletter - https://phabricator.wikimedia.org/T116856#1761519 (10Glaisher) Looks like Echo's formatting system was rewritten and Newsletter extension's formatter also needs to be updated to use the new syste... [12:20:58] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison: Try all possible admin actions concerning Flow - https://phabricator.wikimedia.org/T116785#1761530 (10Qgil) Just curious, what is the objective of this task? [12:47:54] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison: Try all possible admin actions concerning Flow - https://phabricator.wikimedia.org/T116785#1761590 (10Trizek-WMF) As explained on T113582#1758468, upgrade documentation. [12:57:30] (03CR) 10Sbisson: "Matt, any reason not to merge this? I would like to enhance the delete tests in a different patch if you don't mind." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 (owner: 10Sbisson) [13:06:24] 6Collaboration-Team-Backlog, 10Flow: Unable to solve captcha on RTL languages due to bad element position - https://phabricator.wikimedia.org/T116910#1761622 (10Trizek-WMF) 3NEW [14:10:46] 3Collaboration-Team-Current, 10Echo, 10Flow, 6Editing-Analysis, 5Patch-For-Review: Measure the user responsiveness to notifications over time - https://phabricator.wikimedia.org/T108208#1761798 (10matthiasmullie) Thanks for the help, @Milimetric! I've submitted https://gerrit.wikimedia.org/r/#/c/249394/... [14:20:46] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability, 5Patch-For-Review: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1153047 (10matthiasmullie) Moved back to blocked. First patch to lower cache TTL is on Gerrit, but I'd like to first se... [14:21:38] 3Collaboration-Team-Current, 10Flow: Exclude deleted topics/posts from flow-reportcard stats - https://phabricator.wikimedia.org/T116797#1761836 (10matthiasmullie) a:3matthiasmullie [15:39:06] (03PS1) 10Legoktm: Comment out presentation model for mentions since it fatals on deleted pages [extensions/Echo] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249411 (https://phabricator.wikimedia.org/T116888) [15:39:11] (03CR) 10Legoktm: [C: 032] Fix page-linked notifications [extensions/Echo] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249351 (https://phabricator.wikimedia.org/T116485) (owner: 10Legoktm) [15:39:11] (03CR) 10Legoktm: [C: 032] Comment out presentation model for mentions since it fatals on deleted pages [extensions/Echo] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249411 (https://phabricator.wikimedia.org/T116888) (owner: 10Legoktm) [15:39:13] (03Merged) 10jenkins-bot: Fix page-linked notifications [extensions/Echo] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249351 (https://phabricator.wikimedia.org/T116485) (owner: 10Legoktm) [15:39:13] (03Merged) 10jenkins-bot: Comment out presentation model for mentions since it fatals on deleted pages [extensions/Echo] (wmf/1.27.0-wmf.4) - 10https://gerrit.wikimedia.org/r/249411 (https://phabricator.wikimedia.org/T116888) (owner: 10Legoktm) [15:43:33] 3Collaboration-Team-Current, 10Echo, 10Wikidata, 5MW-1.27-release-notes, and 3 others: Echo should not notify the user about his own linking activity - https://phabricator.wikimedia.org/T116485#1762102 (10Legoktm) 5Open>3Resolved [16:06:18] 3Collaboration-Team-Current, 10Echo, 10Flow, 6Analytics-Kanban, and 2 others: Measure the user responsiveness to notifications over time - https://phabricator.wikimedia.org/T108208#1762179 (10Milimetric) [16:13:27] 6Collaboration-Team-Backlog, 10Flow: Flow\Exception\InvalidInputException displayed after enable/disable Flow some times on beta features - https://phabricator.wikimedia.org/T116926#1762205 (10Trizek-WMF) 3NEW [16:35:04] (03CR) 10Mattflaschen: "> Matt, any reason not to merge this? I would like to enhance the delete tests in a different patch if you don't mind." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 (owner: 10Sbisson) [16:35:54] (03CR) 10Sbisson: "Sounds good." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 (owner: 10Sbisson) [16:37:41] possibly one for you, mooey|away https://phabricator.wikimedia.org/T116910 [16:39:46] 6Collaboration-Team-Backlog, 10Flow: Flow\Exception\InvalidInputException displayed after enable/disable Flow some times on beta features - https://phabricator.wikimedia.org/T116926#1762328 (10Quiddity) [16:41:23] 6Collaboration-Team-Backlog, 10Thanks: Add a way to thank users for new articles - https://phabricator.wikimedia.org/T58155#1762333 (10Mattflaschen) [16:43:47] 6Collaboration-Team-Backlog, 10Flow, 7I18n: Ignore accents for purposes of mention matching? - https://phabricator.wikimedia.org/T94274#1762348 (10Mattflaschen) This could get spammy (accidentally or otherwise). Also, we no longer treat topic authors specially here. [16:46:27] 6Collaboration-Team-Backlog, 10Flow: Flow: Pages designated for Flow that have no content and have never had content should not have a history tab - https://phabricator.wikimedia.org/T64903#1762359 (10Mattflaschen) Fixed: https://ca.wikipedia.org/wiki/Viquip%C3%A8dia_Discussi%C3%B3:Not_a_real_page [16:46:35] 6Collaboration-Team-Backlog, 10Flow, 7Tracking: Flow history page issues (tracking) - https://phabricator.wikimedia.org/T85563#1762363 (10Mattflaschen) [16:46:36] 6Collaboration-Team-Backlog, 10Flow: Flow: Pages designated for Flow that have no content and have never had content should not have a history tab - https://phabricator.wikimedia.org/T64903#1762361 (10Mattflaschen) 5Open>3Resolved [16:50:35] 6Collaboration-Team-Backlog, 10Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake - https://phabricator.wikimedia.org/T51087#1762380 (10Mattflaschen) This was a deliberate design decision that has by now had a lot of discussion. No reason to leave open at t... [16:50:38] 6Collaboration-Team-Backlog, 10Thanks: Duplicate thank you allowed - https://phabricator.wikimedia.org/T63883#1762384 (10Mattflaschen) [16:51:11] 6Collaboration-Team-Backlog, 10Thanks: Specify which edit was thanked in Special:Log/thanks, both for private and public records' sake - https://phabricator.wikimedia.org/T51087#539465 (10Mattflaschen) [16:51:12] 6Collaboration-Team-Backlog, 10Thanks: Duplicate thank you allowed - https://phabricator.wikimedia.org/T63883#1762388 (10Mattflaschen) [16:52:03] 6Collaboration-Team-Backlog, 10Thanks: Duplicate thank you allowed - https://phabricator.wikimedia.org/T63883#652086 (10Mattflaschen) This is not blocked by T51087. We now track it privately (https://gerrit.wikimedia.org/r/#/c/218568/). [17:00:14] 6Collaboration-Team-Backlog, 10Echo: Allow secondary actions to have icons and subtitles/tooltips - https://phabricator.wikimedia.org/T115421#1762445 (10Catrope) >>! In T115421#1761196, @Pginer-WMF wrote: >> secondary items need to specify an icon, text for their subtitle/tooltip (depending on rendering mode),... [17:03:58] 6Collaboration-Team-Backlog, 10Flow, 6Language-Engineering, 10Parsoid, and 3 others: Provide an API flag to suppress auto-generated - https://phabricator.wikimedia.org/T113331#1762448 (10ssastry) [17:04:32] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Redirects, 6operations, and 2 others: Flow notification links on mobile point to desktop - https://phabricator.wikimedia.org/T107108#1762460 (10Mooeypoo) I couldn't reproduce the specific problems in this bug, but it also shows several issues with Echo and m... [17:05:36] 6Collaboration-Team-Backlog, 10Flow: Unable to solve captcha on RTL languages due to bad element position - https://phabricator.wikimedia.org/T116910#1762466 (10Mattflaschen) p:5Triage>3Unbreak! [17:05:42] 3Collaboration-Team-Current, 10Flow: Unable to solve captcha on RTL languages due to bad element position - https://phabricator.wikimedia.org/T116910#1761622 (10Mattflaschen) [17:07:18] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Redirects, 6operations, and 2 others: Flow notification links on mobile point to desktop - https://phabricator.wikimedia.org/T107108#1762473 (10Mooeypoo) More to the point, I don't think this should be "blocked". Some aspects of this ticket are under develop... [17:09:16] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Redirects, 6operations, and 2 others: Flow notification links on mobile point to desktop - https://phabricator.wikimedia.org/T107108#1762476 (10Mattflaschen) Yes, my understanding is we took it because although we thought the fix would touch mobile code (and... [17:11:16] 3Collaboration-Team-Current, 10Flow, 10BetaFeatures: Activate Flow as a beta feature on zh.wp - https://phabricator.wikimedia.org/T115100#1762497 (10Mattflaschen) [17:11:17] 3Collaboration-Team-Current, 10Flow, 7WorkType-NewFunctionality: Run FlowUpdateBetaFeaturePreference.php in production - https://phabricator.wikimedia.org/T111253#1762494 (10Mattflaschen) 5Open>3Invalid a:3Mattflaschen This is not a workable bug, since it needs to be done after enabling. We can create... [17:12:36] 3Collaboration-Team-Current, 10Flow, 10Wikidata, 10Wikimedia-Site-Requests: Enable the Wikidata personal talk opt-in Beta Feature on Wikidata.org - https://phabricator.wikimedia.org/T116611#1762505 (10Mattflaschen) [17:13:15] 3Collaboration-Team-Current, 10Flow, 10BetaFeatures: Activate Flow as a beta feature on zh.wp - https://phabricator.wikimedia.org/T115100#1714792 (10Mattflaschen) [17:15:37] (03PS1) 10Legoktm: Allow presentation models to indicate a notification can't be formatted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249444 (https://phabricator.wikimedia.org/T116888) [17:15:40] (03CR) 10jenkins-bot: [V: 04-1] Allow presentation models to indicate a notification can't be formatted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249444 (https://phabricator.wikimedia.org/T116888) (owner: 10Legoktm) [17:19:04] (03PS2) 10Legoktm: Allow presentation models to indicate a notification can't be formatted [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249444 (https://phabricator.wikimedia.org/T116888) [17:19:37] 3Collaboration-Team-Current, 10Echo, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4), 5WMF-deploy-2015-11-03_(1.27.0-wmf.5): MentionPresentationModel fatals for notifications with no title - https://phabricator.wikimedia.org/T116888#1762528 (10Legoktm) p:5Unbreak!>3High Lowering priority sin... [17:27:00] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-Vagrant, 5Patch-For-Review: Have 'flow-suppress' work on MediaWiki-Vagrant out of the box - https://phabricator.wikimedia.org/T113641#1762557 (10Mattflaschen) I can think of a couple possible ways to address the temporary duplicate group issue: 1. Try to au... [17:27:38] (03CR) 10Legoktm: [C: 04-1] "Idb975feaec893ef86c41cc487102e3539c07e328 adds a canRender() function to avoid the fatals." (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249358 (https://phabricator.wikimedia.org/T116847) (owner: 10Catrope) [18:05:40] BRB. Going to buy tissues. [18:24:05] (03CR) 10Mattflaschen: "For posterity: We decided at standup it's okay." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 (owner: 10Sbisson) [18:32:50] (03PS1) 10Mattflaschen: Include namespace in exception message when Title can't be created [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249469 [18:36:42] (03PS9) 10Mooeypoo: Add an APIHandler to Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 [18:37:04] (03PS2) 10Mooeypoo: Initialize notifications model outside of the widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 [18:37:22] (03CR) 10Mooeypoo: Initialize notifications model outside of the widget (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 (owner: 10Mooeypoo) [18:37:27] (03CR) 10Catrope: [C: 032] Include namespace in exception message when Title can't be created [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249469 (owner: 10Mattflaschen) [18:38:25] (03CR) 10Mattflaschen: [C: 032] Browser tests: Actions on suppressed topics not in board history anymore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 (owner: 10Sbisson) [18:40:04] (03Merged) 10jenkins-bot: Include namespace in exception message when Title can't be created [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249469 (owner: 10Mattflaschen) [18:42:12] (03Merged) 10jenkins-bot: Browser tests: Actions on suppressed topics not in board history anymore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 (owner: 10Sbisson) [18:42:19] (03PS3) 10Mooeypoo: Initialize notifications model outside of the widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 [18:44:14] (03PS2) 10Mooeypoo: Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 [18:44:20] (03CR) 10jenkins-bot: [V: 04-1] Initialize notifications model outside of the widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 (owner: 10Mooeypoo) [18:46:43] (03CR) 10jenkins-bot: [V: 04-1] Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 (owner: 10Mooeypoo) [18:49:22] (03CR) 10Mooeypoo: Allow notification model and widget to show combined notifications (037 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 (owner: 10Mooeypoo) [18:50:33] (03PS3) 10Mooeypoo: Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 [18:52:41] (03CR) 10jenkins-bot: [V: 04-1] Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 (owner: 10Mooeypoo) [18:57:45] stephanebisson: RoanKattouw: just a reminder - pls "review" my comment on https://phabricator.wikimedia.org/T116058 - to make sure that we are OK with the fix [19:00:22] (03PS4) 10Mooeypoo: Initialize notifications model outside of the widget [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249008 [19:00:25] etonkovidova: I would ask quiddity as I'm not sure what it's supposed to do.... [19:02:53] etonkovidova: so you saying all topic actions should be filtered out of RC after the topic is deleted but you're still seeing change title, delete, restore, and hide, right? [19:04:03] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Deleted topics deleted edits shouldn't appear in recent changes - https://phabricator.wikimedia.org/T116058#1762865 (10Catrope) @Etonkovidova: did you get those results while you were logged in as a user who has... [19:05:11] stephanebisson, etonkovidova, quiddity, my understanding is it's intentional to show the topic-level moderation action itself. [19:05:22] I commented on the Gerrit about edit title, but didn't think it was worth blocking the change. [19:06:59] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Deleted topics deleted edits shouldn't appear in recent changes - https://phabricator.wikimedia.org/T116058#1762899 (10Mattflaschen) I believe " previous delete/restore/hide actions on the topic also not filtered... [19:10:56] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Deleted topics deleted edits shouldn't appear in recent changes - https://phabricator.wikimedia.org/T116058#1762932 (10Quiddity) I believe what is wanted (please confirm, @Glaisher et al?) is for deleted topics t... [19:11:38] etonkovidova, stephanebisson, matt_flaschen: hopefully that clarifies ^ [19:17:20] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Deleted topics deleted edits shouldn't appear in recent changes - https://phabricator.wikimedia.org/T116058#1762960 (10Mattflaschen) Other than the edit-title issue, we only show it once (no longer showing the co... [19:17:23] RoanKattouw_away, re: presentation models - I /think/ there might be a notification integration in GettingStarted, too. Per https://git.wikimedia.org/blob/mediawiki%2Fextensions%2FGettingStarted/53a5bed16813b675d0b0c42761081ebb568265af/i18n%2Fen.json#L50 and the 2 yellow icons at https://www.mediawiki.org/wiki/Echo_%28Notifications%29/Feature_requirements#Icons_and_types - However, I don't know if it's in use? [19:17:49] * quiddity goes for lunch, and a short walk. [19:20:37] quiddity, GettingStarted does not use Echo since 7e9cfe9f57de8a0a9d736e0395a45a3f7da40ddf. gettingstarted-lightbulb-notification-body is for a different type of notification. [19:59:58] I hit a weird thing testing the artificial PK patch, but I can't reproduce. [20:12:19] (03PS4) 10Mooeypoo: Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 [20:19:00] (03PS11) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [20:20:19] (03PS12) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [20:32:32] (03PS13) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [20:39:44] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Deleted topics deleted edits shouldn't appear in recent changes - https://phabricator.wikimedia.org/T116058#1763331 (10Etonkovidova) @Catrope As user that has no right to delete ( the same View history is for... [20:50:29] (03PS1) 10Mooeypoo: Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 [20:51:24] 6Collaboration-Team-Backlog, 10Flow: Hide all actions connected to deleted boards from RC and watchlist - https://phabricator.wikimedia.org/T116326#1763374 (10Etonkovidova) For testing after the fix: Action to be checked - not to be displayed after deletion edit topic edit summary mark as resolved after ma... [20:51:57] (03PS14) 10Mooeypoo: [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 [20:52:31] (03CR) 10jenkins-bot: [V: 04-1] Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 (owner: 10Mooeypoo) [20:54:36] (03CR) 10jenkins-bot: [V: 04-1] [WIP^n] Create a notifications widget demo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247017 (owner: 10Mooeypoo) [20:56:32] could someone review a trival fix for a UBN in wmf.4 in RecentChanges? https://gerrit.wikimedia.org/r/#/c/249502/ [20:57:15] Looking [20:57:42] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Beta: Cannot reply to any topic - https://phabricator.wikimedia.org/T116582#1763418 (10Etonkovidova) Checked in betalabs. [20:58:14] legoktm: +2ed [20:58:34] thanks [21:00:26] 3Collaboration-Team-Current, 10Flow: Error converting a page to Flow - CirrusSearch\Hooks::onTitleMoveComplete - https://phabricator.wikimedia.org/T116970#1763429 (10Quiddity) 3NEW [21:00:45] unbreak now, I think. ^ [21:00:45] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Watchlist, 7Performance: Special:Watchlist takes 23 seconds to start loading on mediawiki.org - https://phabricator.wikimedia.org/T116971#1763436 (10Nemo_bis) 3NEW [21:02:58] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Watchlist, 7Performance: Special:Watchlist takes 23 seconds to start loading on mediawiki.org - https://phabricator.wikimedia.org/T116971#1763452 (10aaron) Maybe you can see the slowest methods via https://wikitech.wikimedia.org/wiki/Debugging_in_production#... [21:10:06] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Flow's action menu can be hidden behind page footer - https://phabricator.wikimedia.org/T116077#1763467 (10Etonkovidova) Checked in betalabs - all menu options are visible. Resolv... [21:18:40] (03CR) 10Mattflaschen: [C: 031] "Tested. I think we're good to go." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [21:19:42] 3Collaboration-Team-Current, 10Flow, 7Database, 5Patch-For-Review, 7WorkType-NewFunctionality: Add artificial primary key to flow_wiki_ref and flow_ext_ref - https://phabricator.wikimedia.org/T109676#1763501 (10Mattflaschen) >>! In T109676#1745382, @jcrespo wrote: > Now that T111084 has been applied, ple... [21:20:18] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Opt-out: Add template with a link to Flow Archive page - https://phabricator.wikimedia.org/T112957#1763502 (10Etonkovidova) Checked in betalabs After opt-out 1) wikitext User talk page displays a link to archi... [21:22:22] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Watchlist, 7Performance: Special:Watchlist takes 23 seconds to start loading on mediawiki.org - https://phabricator.wikimedia.org/T116971#1763525 (10Nemo_bis) [[https://wikitech.wikimedia.org/w/index.php?title=Debugging_in_production&type=revision&diff=19807... [21:33:27] 3Collaboration-Team-Current, 10Flow: Error converting a page to Flow - CirrusSearch\Hooks::onTitleMoveComplete - https://phabricator.wikimedia.org/T116970#1763587 (10Quiddity) Confirmed/reproduced at https://www.mediawiki.org/wiki/User_talk:Quiddity_(WMF)/sandbox7 Nothing obvious in webconsole. {F2887705} [21:33:33] RoanKattouw, matt_flaschen, ping for visibility. probable UBN: https://phabricator.wikimedia.org/T116970 [21:34:08] Ouch. In a meeting, will look later [21:34:11] nod [21:38:16] quiddity, nothing to do with us. CirrusSearch broke all moves. [21:38:33] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Watchlist, 7Performance: Special:Watchlist takes 23 seconds to start loading on mediawiki.org - https://phabricator.wikimedia.org/T116971#1763613 (10aaron) Just viewing a the watchlist with ?foceprofile and the extension enabled (clicking the globe) is enoug... [21:38:45] aha, kk. ty. [21:38:52] quiddity, I'll see if it's a quick fix. [22:11:03] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Watchlist, 7Performance: Special:Watchlist takes 23 seconds to start loading on mediawiki.org - https://phabricator.wikimedia.org/T116971#1763841 (10Nemo_bis) >>! In T116971#1763613, @aaron wrote: > Just viewing a the watchlist with ?foceprofile and the exte... [22:14:46] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-Watchlist, 7Performance: Special:Watchlist takes 23 seconds to start loading on mediawiki.org - https://phabricator.wikimedia.org/T116971#1763864 (10aaron) You can probably slip out the stuff < 3% to keep the comment smaller. [22:15:04] 3Collaboration-Team-Current, 10Echo, 10Wikidata, 5MW-1.27-release-notes, and 4 others: Echo should not notify the user about his own linking activity - https://phabricator.wikimedia.org/T116485#1763866 (10Etonkovidova) Checked in betalabs. [23:04:39] (03PS1) 10Legoktm: API: Remove no-op wfProfile(In|Out) calls [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249601 [23:05:24] (03CR) 10jenkins-bot: [V: 04-1] API: Remove no-op wfProfile(In|Out) calls [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249601 (owner: 10Legoktm) [23:11:47] 6Collaboration-Team-Backlog, 10Flow: Flow UI encourages reply-to-topic and discourages reply-to-comment - https://phabricator.wikimedia.org/T116999#1764232 (10ksmith) 3NEW [23:16:59] (03PS2) 10Mooeypoo: Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 [23:18:56] (03CR) 10jenkins-bot: [V: 04-1] Implement SortedList in Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249503 (owner: 10Mooeypoo) [23:21:01] 6Collaboration-Team-Backlog, 10Flow: Flow UI encourages reply-to-topic and discourages reply-to-comment - https://phabricator.wikimedia.org/T116999#1764269 (10Mattflaschen) The input box that is show by default and the bottom-most reply link have the exact same effect. If you click the bottom-most reply link,... [23:24:54] (03CR) 10Legoktm: [C: 04-1] Add an APIHandler to Echo notifications (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/247021 (owner: 10Mooeypoo) [23:29:36] 6Collaboration-Team-Backlog, 10Flow: Flow UI encourages reply-to-topic and discourages reply-to-comment - https://phabricator.wikimedia.org/T116999#1764303 (10ksmith) @Mattflaschen: Oh. Thanks for pointing that out. Then I guess my real complaint is that there is literally no way to reply to the last comment o... [23:31:00] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: Invalid language code "nl_nl" - https://phabricator.wikimedia.org/T116890#1764307 (10Legoktm) {F2888026} [23:49:07] 6Collaboration-Team-Backlog, 10Flow: Flow UI encourages reply-to-topic and discourages reply-to-comment - https://phabricator.wikimedia.org/T116999#1764344 (10Mattflaschen) 5Open>3Invalid a:3Mattflaschen >>! In T116999#1764303, @ksmith wrote: > @Mattflaschen: Oh. Thanks for pointing that out. Then I gues... [23:51:13] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: Invalid language code "nl_nl" - https://phabricator.wikimedia.org/T116890#1764352 (10Legoktm) 1) User passes ?uselang=nl_nl to a normal pageview, it's not a known language code so core uses the content language 2) $wgL... [23:51:26] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-Internationalization, 10MediaWiki-extensions-CLDR, 7Wikimedia-log-errors: Invalid language code "nl_nl" - https://phabricator.wikimedia.org/T116890#1764357 (10Legoktm) [23:55:41] (03CR) 10Legoktm: "The code is fine, but I'd rather not add utility functions to the presentation model itself, which I see more as an interface with sane de" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249360 (owner: 10Catrope)