[00:06:27] (03PS1) 10Mooeypoo: Allow notification model and widget to show combined notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249031 [00:17:27] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1755983 (10Mattflaschen) We tried to workaround this by cherry-picking out {e359e9c166dfee047e6365850fd37... [00:18:55] RoanKattouw, well, it fails more slowly now.] [00:21:24] (03CR) 10Mattflaschen: [C: 032] "Merge after branch cut." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245612 (https://phabricator.wikimedia.org/T114620) (owner: 10Catrope) [00:22:53] RoanKattouw, I copied it wrong when I said Parsoid decodes it. It 503's. [00:23:28] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1755990 (10Mattflaschen) Never mind, I did copy it wrong. I accidentally lost the meta line, which is ac... [00:23:51] (03Merged) 10jenkins-bot: Adapt to Parsoid/RESTbase renaming scrubWikitext to scrub_wikitext [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245612 (https://phabricator.wikimedia.org/T114620) (owner: 10Catrope) [00:34:07] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1756020 (10Mattflaschen) p:5Unbreak!>3High [00:37:26] Doh, I meant to +1 the scrub_wikitext. Oh well, I'm 99% sure it's fine, just didn't want more Parsoid stuff to deal with in the very unlikely event it's wrong. [00:40:38] I'm not sure direct Parsoid actually supports it... [00:43:11] RoanKattouw, do you know who from Parsoid might be online now? [00:44:29] Okay, I'm just going to revert it, since it's after freeze and I'm not confident in it. [00:44:36] OK [00:44:42] (03PS1) 10Mattflaschen: Revert "Adapt to Parsoid/RESTbase renaming scrubWikitext to scrub_wikitext" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249039 [00:44:52] (03CR) 10Catrope: [C: 032] Revert "Adapt to Parsoid/RESTbase renaming scrubWikitext to scrub_wikitext" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249039 (owner: 10Mattflaschen) [00:45:30] was that change causing issues for you guys? [00:46:34] (03CR) 10Mattflaschen: [C: 032] "Sorry. There may be nothing wrong with it, but I didn't mean to merge it after freeze." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249039 (owner: 10Mattflaschen) [00:47:25] Krenair: No, it's just that Matt accidentally +2ed instead of +1ing and merging after the cut [00:47:29] (03Merged) 10jenkins-bot: Revert "Adapt to Parsoid/RESTbase renaming scrubWikitext to scrub_wikitext" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249039 (owner: 10Mattflaschen) [00:47:35] k [00:49:42] Yeah, this is actually a different thing that I'm a little unsure about. [00:50:58] (03CR) 10Mattflaschen: "Let's check the answer to https://phabricator.wikimedia.org/T114620#1756025 before doing this." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/245612 (https://phabricator.wikimedia.org/T114620) (owner: 10Catrope) [00:51:26] Ooh good question [00:51:33] I did not realize that interaction might be a problem [00:51:45] Probably because the scrub_wikitext patch is older than the avoid-RB one [00:52:03] I'm not 100% sure, but not seeing scrub_wikitext in Parsoid repo worries me enough to ask. [00:52:19] We definitely need the APIs consistent, and I think there have been coordination issues on the API in the past [00:55:03] (03PS2) 10Mattflaschen: Use flow- prefix for the CSS classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 [00:56:10] (03CR) 10Mattflaschen: "We should probably wait until after the cut, since this is non-urgent." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 (owner: 10Mattflaschen) [00:56:19] (03CR) 10Mattflaschen: Use flow- prefix for the CSS classes (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248988 (owner: 10Mattflaschen) [01:29:15] (03PS1) 10Mattflaschen: Implement AbstractCollection::newFromRevisionId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249044 [01:29:58] Breaking for dinner. [01:31:16] (03CR) 10jenkins-bot: [V: 04-1] Implement AbstractCollection::newFromRevisionId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249044 (owner: 10Mattflaschen) [01:57:27] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-ResourceLoader, 6Performance-Team, and 3 others: wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1756128 (10Catrope) This appears to happen because we use non-multibyte-aware truncation for summaries (I think th... [01:57:29] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1756127 (10Mattflaschen) p:5High>3Unbreak! [01:57:34] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-ResourceLoader, 6Performance-Team, and 3 others: wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1756129 (10Catrope) a:3Catrope [01:57:55] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1755762 (10Catrope) [02:38:25] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1756157 (10Catrope) ...but somehow the API does manage to output JSON which... [02:42:47] That PHPUnit failure is weird. Locally, hhvm is fine, Zend gives a strict standards warning. On Jenkins, it says PostCollection is missing (?!) [02:47:12] (03CR) 10Mattflaschen: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249044 (owner: 10Mattflaschen) [02:48:08] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1756159 (10Catrope) ...which happens because ApiResult runs everything throu... [02:53:19] RoanKattouw, I don't think you have to change the database. Looks like the truncation happens at view-time. [02:53:56] Yeah I see that now [02:54:00] I'm now even more confused than before [02:54:06] Because we use the built-in truncation utility [02:54:14] Is there a bug in Language::truncate()? [02:55:32] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1756166 (10Catrope) It looks like the "summary" isn't in the DB at all, but... [02:56:18] RoanKattouw, yeah, the only other possibility I can think of is that trim, html_entity_decode, or strip_tags messes it up in a way that truncate does not repair. [02:56:23] Or it's already messed up beforehand. [02:56:58] (03PS2) 10Mattflaschen: Implement AbstractCollection::newFromRevisionId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249044 [02:58:01] (03PS3) 10Mattflaschen: Implement AbstractCollection::newFromRevisionId [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249044 [03:01:28] 3Collaboration-Team-Current, 10Flow: Stop falling back to PHP parser if a specific Parsoid call fails - https://phabricator.wikimedia.org/T116699#1756173 (10Mattflaschen) [03:14:53] (03PS1) 10Mattflaschen: Do not attempt to fall back to PHP parser [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249049 (https://phabricator.wikimedia.org/T116699) [03:17:54] (03CR) 10Mattflaschen: "Should we be even more explicit and have something like $wgFlowUseParsoid? We could use that to determine whether to use Parsoid, then ha" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249049 (https://phabricator.wikimedia.org/T116699) (owner: 10Mattflaschen) [03:30:11] matt_flaschen: Going home now, but just to let you know: I found it, it was a bug in Language::truncate() when the input contained newlines before the truncation point. One-byte fix (added a modifier to the regex). https://gerrit.wikimedia.org/r/#/c/249050 [03:31:20] RoanKattouw_away, cool. [03:42:46] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-13_(1.27.0-wmf.3), 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): wgRelevantPageName is missing on Chinese Wikipedia - https://phabricator.wikimedia.org/T116693#1756201 (10Krinkle) 5Open>3Resolved [04:29:04] Good news: Today I learned a whole new kind of bash string escaping. [04:29:08] Bad news: Today I learned a whole new kind of bash string escaping. [04:29:15] Worse news: It still doesn't work. [04:41:37] 6Collaboration-Team-Backlog, 10Echo, 7Easy, 7Performance: Static data should go in data module, not MakeGlobalVariablesScript - https://phabricator.wikimedia.org/T73539#1756246 (10Krinkle) a:5Krinkle>3None If the data is the same for all users/pages, and large "enough"; using a data module makes sense... [08:06:46] 3Collaboration-Team-Current, 10Echo, 6Design-Research, 5Design Research and product team collaboration, and 2 others: Validate initial design ideas for the cross-wiki notification panel - https://phabricator.wikimedia.org/T114086#1756436 (10Pginer-WMF) [09:55:42] 6Collaboration-Team-Backlog, 10Flow: Allow preloading summary with explicit text - https://phabricator.wikimedia.org/T94283#1756608 (10Trizek-WMF) >>! In T94283#1752977, @Mattflaschen wrote: >>>! In T94283#1682017, @Trizek-WMF wrote: >> Other cases: >> * [[ https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Forum_de... [10:19:29] 6Collaboration-Team-Backlog, 10Flow, 10UI-Standardization, 10VisualEditor, 7Design: Come up with a better re-usable UI concept for a button to switch editor-mode; the current one is confusing, and hard to discover - https://phabricator.wikimedia.org/T116417#1756670 (10Trizek-WMF) >>! In T116417#1752597,... [10:51:36] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke: Add Flow support to Nuke - https://phabricator.wikimedia.org/T115695#1730512 (10Steinsplitter) just for the record: https://www.mediawiki.org/wiki/Topic:Srjlukq433v34hyb [11:19:12] (03PS1) 10Sbisson: Add jquery.findWithParent to Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249095 (https://phabricator.wikimedia.org/T116146) [11:30:05] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Flow Browser tests fail with "Error modules: ext.thanks.flowthank." on beta - https://phabricator.wikimedia.org/T116146#1756853 (10SBisson) > Thank can ship its own variant of the utility method. It's simple enough. Sharing this costs more than it gains... [11:31:27] (03Abandoned) 10Sbisson: Depend on jquery.findWithParent from Core [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248070 (https://phabricator.wikimedia.org/T116146) (owner: 10Sbisson) [11:31:37] (03Abandoned) 10Sbisson: Depend on jquery.findWithParent from Core [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/248072 (https://phabricator.wikimedia.org/T116146) (owner: 10Sbisson) [11:41:37] 6Collaboration-Team-Backlog, 10Echo: Evaluate designs for new notification panel actions - https://phabricator.wikimedia.org/T116741#1756870 (10Pginer-WMF) 3NEW [11:43:30] 6Collaboration-Team-Backlog, 10Echo, 6Design-Research: Evaluate designs for new notification panel actions - https://phabricator.wikimedia.org/T116741#1756870 (10Pginer-WMF) [11:52:18] 3Collaboration-Team-Current, 10Echo, 6Design-Research, 5Design Research and product team collaboration, and 2 others: Validate initial design ideas for the cross-wiki notification panel - https://phabricator.wikimedia.org/T114086#1756891 (10Pginer-WMF) > Also, the slides refer to "prototype updates". Are t... [11:58:03] (03CR) 10Matthias Mullie: "That method never made it in because it was a bit of a hack:" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249044 (owner: 10Mattflaschen) [11:59:57] (03PS1) 10Sbisson: Browser tests: Actions on suppressed topics not in board history anymore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 [12:02:47] (03PS2) 10Sbisson: Browser tests: Actions on suppressed topics not in board history anymore [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 [12:26:52] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: Add a post title variable to AbuseFilter - https://phabricator.wikimedia.org/T116744#1756972 (10Glaisher) 3NEW [12:27:33] 3Collaboration-Team-Current, 10Flow: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1756984 (10Glaisher) [13:38:16] (03PS1) 10Sbisson: Centralize tree cache keys creation in TreeCacheKey::build [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249116 (https://phabricator.wikimedia.org/T116582) [14:10:20] (03PS1) 10Sbisson: Increase the spacer to show the full menu [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249125 (https://phabricator.wikimedia.org/T116077) [14:33:44] 6Collaboration-Team-Backlog, 10Flow, 10Browser-Tests, 5Patch-For-Review: Fix or delete failing Flow browsertests Jenkins jobs - https://phabricator.wikimedia.org/T94153#1757325 (10hashar) [14:55:37] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke: Add Flow support to Nuke - https://phabricator.wikimedia.org/T115695#1757419 (10Trizek-WMF) Per [[https://www.mediawiki.org/w/index.php?title=Topic:Srjlukq433v34hyb&topic_showPostId=srkg23ltfk01l4ti#flow-post-srkg23ltfk01l4ti | Shanmugamp7 fee... [15:06:10] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Revert notifications in Echo on Wikidata should display label as well as Q id - https://phabricator.wikimedia.org/T116762#1757478 (10Addshore) 3NEW [15:07:14] 6Collaboration-Team-Backlog, 10Echo, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Revert notifications in Echo on Wikidata should display label as well as Q id - https://phabricator.wikimedia.org/T116762#1757495 (10Addshore) p:5Triage>3Low [15:11:08] 3Collaboration-Team-Current, 10Flow: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1757536 (10Glaisher) [15:18:48] 3Collaboration-Team-Current, 10Flow, 10MediaWiki-extensions-Nuke: Add Flow support to Nuke - https://phabricator.wikimedia.org/T115695#1757566 (10Mattflaschen) [15:32:26] (03CR) 10Mattflaschen: "May have caused https://gerrit.wikimedia.org/r/#/c/249103/ , pending discussion." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/248314 (https://phabricator.wikimedia.org/T116058) (owner: 10Matthias Mullie) [15:33:37] (03CR) 10Mattflaschen: "This is probably from https://gerrit.wikimedia.org/r/#/c/248314/ ." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 (owner: 10Sbisson) [15:34:50] quiddity, did you see https://gerrit.wikimedia.org/r/#/c/249103/ ? [15:34:57] (03PS3) 10Hashar: Add composer.json [extensions/Echo] (REL1_26) - 10https://gerrit.wikimedia.org/r/246991 (https://phabricator.wikimedia.org/T115392) (owner: 10Paladox) [15:34:59] stephanebisson noticed a behavior change through the browser tests. I think I know where it's from, but I'm trying to figure out if this is okay, or needs to be updated. [15:36:15] Basically, if you have suppress rights you still see the suppress action itself, but not the comment actions. [15:37:20] I haven't checked, but I think this is from https://gerrit.wikimedia.org/r/#/c/248314/ . [15:38:17] (03PS4) 10Hashar: Add composer.json [extensions/Echo] (REL1_26) - 10https://gerrit.wikimedia.org/r/246991 (owner: 10Paladox) [15:38:29] (03CR) 10Hashar: [C: 032] "Dropped reference to Bug: T115392 unrelated." [extensions/Echo] (REL1_26) - 10https://gerrit.wikimedia.org/r/246991 (owner: 10Paladox) [15:40:10] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: Add a post title variable to AbuseFilter - https://phabricator.wikimedia.org/T116744#1757654 (10Mattflaschen) How did you navigate to that page? {T115128} says this doesn't work, and it indeed isn't listed at https://www.mediawiki.org/... [15:40:24] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: AbuseFilter examine/test tools does not work for Flow edits - https://phabricator.wikimedia.org/T115128#1715614 (10Mattflaschen) Parts of it seem to work. See https://www.mediawiki.org/wiki/Special:AbuseFilter/examine?wpSearchUser=Vish... [15:43:12] (03Merged) 10jenkins-bot: Add composer.json [extensions/Echo] (REL1_26) - 10https://gerrit.wikimedia.org/r/246991 (owner: 10Paladox) [15:47:22] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: Add a post title variable to AbuseFilter - https://phabricator.wikimedia.org/T116744#1757682 (10Glaisher) This task is about adding a new AbuseFilter variable to Flow which would let us check the contents of post titles. (Looking at ano... [15:47:25] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: Add a post title variable to AbuseFilter - https://phabricator.wikimedia.org/T116744#1757683 (10Mattflaschen) I believe right now it's a separate action, so it's still filterable, though I can see how it might be useful to filter it tog... [15:47:34] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: AbuseFilter test tools does not work for Flow edits - https://phabricator.wikimedia.org/T115128#1757685 (10Glaisher) [15:48:27] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: AbuseFilter test tools does not work for Flow edits - https://phabricator.wikimedia.org/T115128#1715614 (10Glaisher) Sorry, actually `examine` does work, it's `test` interface which is not working properly. See T116744#1757682. [15:50:13] 6Collaboration-Team-Backlog, 10Echo: regression: "Page link" notification appears for link added by the article creator - https://phabricator.wikimedia.org/T116769#1757721 (10Kipod) 3NEW [15:51:35] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: AbuseFilter test tools does not work for Flow edits - https://phabricator.wikimedia.org/T115128#1757736 (10Mattflaschen) Could you explain how you got to https://www.mediawiki.org/wiki/Special:AbuseFilter/examine/log/82309, just for my... [15:53:29] 6Collaboration-Team-Backlog, 10Echo: regression: "Page link" notification appears for link added by the article creator - https://phabricator.wikimedia.org/T116769#1757743 (10Kipod) [15:53:57] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: AbuseFilter test tools does not work for Flow edits - https://phabricator.wikimedia.org/T115128#1757747 (10Glaisher) >>! In T115128#1757736, @Mattflaschen wrote: > Could you explain how you got to https://www.mediawiki.org/wiki/Special:... [15:55:25] 6Collaboration-Team-Backlog, 10Echo: regression: "Page link" notification appears for link added by the article creator - https://phabricator.wikimedia.org/T116769#1757762 (10Mattflaschen) [15:55:27] 3Collaboration-Team-Current, 10Echo, 10Wikidata, 7Regression: Echo should not notify the user about his own linking activity - https://phabricator.wikimedia.org/T116485#1757763 (10Mattflaschen) [15:57:47] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-extensions-AbuseFilter: Add a post title variable to AbuseFilter - https://phabricator.wikimedia.org/T116744#1757778 (10Glaisher) Yes, this would be similar to `article_text` and `article_prefixedtext` variables. See https://www.mediawiki.org/wiki/Extension:Ab... [15:57:59] Thanks, Glaisher. [15:58:41] yw.. and also thanks for working on this [16:57:39] 3Collaboration-Team-Current, 10Flow, 6Stewards-and-global-tools: Improve/investigate solutions for the Flow botspam - https://phabricator.wikimedia.org/T116211#1758031 (10Legoktm) [17:02:56] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): [betalabs] First invocation of a Link inspector displayed cut off on a Flow board - https://phabricator.wikimedia.org/T116643#1758163 (10Etonkovidova) Checked in betalabs - Chrome 46, FF 41, Safari 9.0.1. Also ch... [17:11:03] (03CR) 10Quiddity: "I *think* that is good. IIUC, it matches up with my testing at http://en.wikipedia.beta.wmflabs.org/w/index.php?title=User:Quiddity/sandbo" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 (owner: 10Sbisson) [17:11:15] (03CR) 10Catrope: [C: 032] Increase the spacer to show the full menu [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249125 (https://phabricator.wikimedia.org/T116077) (owner: 10Sbisson) [17:12:10] (03CR) 10Legoktm: "Should the module name be prefixed like it is in flow?" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249095 (https://phabricator.wikimedia.org/T116146) (owner: 10Sbisson) [17:13:15] (03CR) 10Sbisson: "yes, good catch." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249095 (https://phabricator.wikimedia.org/T116146) (owner: 10Sbisson) [17:14:29] (03Merged) 10jenkins-bot: Increase the spacer to show the full menu [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249125 (https://phabricator.wikimedia.org/T116077) (owner: 10Sbisson) [17:18:05] (03PS2) 10Sbisson: Add jquery.findWithParent to Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249095 (https://phabricator.wikimedia.org/T116146) [17:25:37] Is there an api module to get all the flow edits by a particular user? [17:28:49] list=usercontribs doesn't seem to be working [17:28:56] i'll be 2 min late [17:33:09] (03CR) 10Legoktm: [C: 032] Add jquery.findWithParent to Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249095 (https://phabricator.wikimedia.org/T116146) (owner: 10Sbisson) [17:36:35] (03Merged) 10jenkins-bot: Add jquery.findWithParent to Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/249095 (https://phabricator.wikimedia.org/T116146) (owner: 10Sbisson) [17:38:15] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-API: Allow to get Flow user contribs through API - https://phabricator.wikimedia.org/T116783#1758360 (10Glaisher) 3NEW [17:42:36] (03PS6) 10Catrope: Add templates to talkpage and Flow board during opt-out [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246858 (https://phabricator.wikimedia.org/T112957) (owner: 10Sbisson) [17:42:51] 3Collaboration-Team-Current, 10Echo, 6Design-Research, 5Design Research and product team collaboration, and 2 others: Validate initial design ideas for the cross-wiki notification panel - https://phabricator.wikimedia.org/T114086#1758395 (10Capt_Swing) @Catrope thanks for the heads-up. I've just shared the... [17:43:39] (03CR) 10Catrope: [C: 032] Add templates to talkpage and Flow board during opt-out [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246858 (https://phabricator.wikimedia.org/T112957) (owner: 10Sbisson) [17:46:44] (03Merged) 10jenkins-bot: Add templates to talkpage and Flow board during opt-out [extensions/Flow] - 10https://gerrit.wikimedia.org/r/246858 (https://phabricator.wikimedia.org/T112957) (owner: 10Sbisson) [17:47:54] 6Collaboration-Team-Backlog, 3Collaboration-Team-Current, 10Flow, 7Availability: Spike: Avoid use of merge() in Flow caches - https://phabricator.wikimedia.org/T94029#1758417 (10matthiasmullie) Blocked on https://gerrit.wikimedia.org/r/#/c/247575/. Only after that has merged, we can start lowering cache TT... [17:50:49] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison: Try all possible admin actions concerning Flow - https://phabricator.wikimedia.org/T116785#1758443 (10Trizek-WMF) 3NEW a:3Trizek-WMF [17:51:06] mlitn: thanks for the explanation on the blocked task [17:52:39] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create a page about (more) advanced Flow features - https://phabricator.wikimedia.org/T111529#1758472 (10Trizek-WMF) [17:52:40] 6Collaboration-Team-Backlog, 10Flow, 7Documentation: Create an help page about Flow's administration - https://phabricator.wikimedia.org/T113582#1758468 (10Trizek-WMF) 5Resolved>3Open Re-opening: based on feedback, tests to improve help page should be conducted. {T116785} [17:52:45] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison: Try all possible admin actions concerning Flow - https://phabricator.wikimedia.org/T116785#1758443 (10Trizek-WMF) [17:53:11] 6Collaboration-Team-Backlog, 10Flow: If page content is a group of templates, talk page conversion to Flow does not archive the old content - https://phabricator.wikimedia.org/T116787#1758476 (10Trizek-WMF) 3NEW [17:53:39] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison: Try all possible admin actions concerning Flow - https://phabricator.wikimedia.org/T116785#1758443 (10Trizek-WMF) [17:53:53] 6Collaboration-Team-Backlog, 10Flow, 6Community-Liaison: Try all possible admin actions concerning Flow - https://phabricator.wikimedia.org/T116785#1758490 (10Trizek-WMF) p:5Triage>3Normal [18:07:04] (03CR) 10Mattflaschen: "This probably affects deletion too." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 (owner: 10Sbisson) [18:31:28] 3Collaboration-Team-Current, 10Flow: Exclude deleted topics/posts from flow-reportcard stats - https://phabricator.wikimedia.org/T116797#1758758 (10Catrope) 3NEW [18:58:45] (03CR) 10Sbisson: "Probably but the delete tests are not detailed enough to be affected." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 (owner: 10Sbisson) [19:22:45] anybody knows about: "Error: Module sentry.raven has failed dependencies"? [19:23:10] Ouch, nope [19:23:18] WTF is that module, I don't even know what that is [19:23:22] What wiki are you seeing that on? [19:24:06] beta, switching between wikitext and ve on new post editor [19:24:16] Did someone enable Sentry? [19:24:27] What's Sentry? [19:24:42] It's a JS client-error tracking system tgr built. [19:24:48] Oh also, Parsoid was broken on beta last I checked [19:24:56] lol, so there's an error loading the error-reporting system? [19:25:07] It was going to be used to find out what errors occurred in the real-world in UploadWizard. [19:25:10] Apparently? [19:25:13] I see Error: Module ext.flow.visualEditor has failed dependencies [19:25:22] It was never deployed, I think. [19:25:57] From OO.mixinClass(mw.flow.ve.ui.MentionTargetInputWidget, OO.ui.LookupElement); [19:26:35] Oh. [19:26:36] Yes. [19:26:40] Breaking change in OOUI. [19:26:45] Aha [19:26:46] [BREAKING CHANGE] Remove aliases for OO.ui.mixins, deprecated in 0.11.4 (C. Scott Ananian) [19:26:47] Trevor's going to send the e-mail soon. [19:26:58] You've only had four months to fix. ;-) [19:27:14] True :) [19:28:29] Oh there's only one in Flow that wasn't updated [19:28:32] The others already were [19:29:18] (03PS1) 10Catrope: Update for breaking change for mixins in OOUI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249221 [19:29:24] stephanebisson: ---^^ [19:29:46] looking... [19:31:54] It looks like that's what causes it. I also see an error about sentry.raven, but I think that's wrong, because getState('sentry.raven') returns 'ready' [19:32:39] (03CR) 10Sbisson: "What about lines 9, 26 and 141? Should these be changed as well?" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249221 (owner: 10Catrope) [19:33:06] ....yes they should [19:33:43] And that's why we have code review [19:33:45] Thanks stephanebisson [19:34:04] (03PS2) 10Catrope: Update for breaking change for mixins in OOUI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249221 [19:43:00] Glaisher, yeah, sorry, the API doesn't support it yet. Special page works. [19:44:28] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-API: Allow to get Flow user contribs through API - https://phabricator.wikimedia.org/T116783#1759096 (10Mattflaschen) [19:44:29] 6Collaboration-Team-Backlog, 10Flow: Support Flow changes in Usercontribs API - https://phabricator.wikimedia.org/T88753#1759097 (10Mattflaschen) [19:45:27] 6Collaboration-Team-Backlog, 10Flow, 10MediaWiki-API: Include Flow revisions in RecentChanges API - https://phabricator.wikimedia.org/T104083#1759100 (10Mattflaschen) [19:45:48] (03CR) 10Bartosz Dziewoński: [C: 032] Update for breaking change for mixins in OOUI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249221 (owner: 10Catrope) [19:57:14] (03Merged) 10jenkins-bot: Update for breaking change for mixins in OOUI [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249221 (owner: 10Catrope) [19:59:36] 6Collaboration-Team-Backlog, 10Flow: If page content is a group of templates, talk page conversion to Flow does not archive the old content - https://phabricator.wikimedia.org/T116787#1759153 (10Mattflaschen) I see the archive link. There is the expected template (```{{Page de discussion wikitexte convertie e... [20:11:40] (03CR) 10Mattflaschen: "Yeah, I'm raising it because suppress and deletion are expected to work differently (beyond the direct part that the "allowed to see it" l" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/249103 (owner: 10Sbisson) [20:12:13] 3Collaboration-Team-Current, 10Echo, 10Flow, 6Editing-Analysis: Measure the user responsiveness to notifications over time - https://phabricator.wikimedia.org/T108208#1759209 (10Milimetric) Responding here to an email from @matthiasmullie: > We have an existing limn dashboard that’s a couple of years old[... [20:16:59] Quis log sextarium errores erroribus? [20:19:20] James_F|Away, did he work on Sentry itself? I thought it was a third-party library and he worked on the integration. [20:23:50] legoktm: If a notification type does not specify 'formatter-class' (i.e. use EchoBasicNotificationFormatter), do they still need a 'presentation-model'? [20:24:03] yes [20:24:05] legoktm: I guess the source of my confusion is that I don't really understand what those two things are or how they interact [20:24:06] OK [20:24:10] So that makes my list bigger [20:24:34] I'm working on docs :P [20:25:07] Yeah, I know, so don't bother explaining too much to me on IRC right now [20:34:21] RoanKattouw, re: the fix for Language::truncate(): <- Should I send a special thanks to the editor who raised this bug, for (helping to fix a longstanding bug in core - or something like that) ? [20:34:45] Yes [20:35:02] You can tell them they discovered a years-old bug in something everyone assumed was infallible [20:35:14] perfect, ty [20:36:39] It's one of those undermines-your-faith-in-the-system occurrences even for people like us who find and fix bugs on a daily basis [20:39:04] hmm, re: the beta cluster caching bug, where new replies don't show up. It's now happening on mediawiki.org [20:39:13] It's kind of like your state/province's dept of transportation running out of construction cones or something, people just assume that will never happen [20:39:15] I saved a reply here 2 mins ago, but it's not visible. https://www.mediawiki.org/wiki/Topic:Srahmurfaimvrnnm [20:39:24] Grr [20:39:29] Did Stephane's change not make it in? [20:39:38] quiddity: Can you link me to the phab task for that? [20:39:43] Then I can find the change from there [20:40:49] idk, looking... [20:41:14] nm found it [20:42:04] No, his patch made it in [20:42:13] it was merged last night [20:42:38] Yeah [20:42:44] Hmm but mw.org says it's on wmf3, wtf [20:43:14] Oh only testwiki is on 4, MW is still on 3 [20:43:22] I hope the memc changes didn't get backported to 3? [20:43:23] * RoanKattouw checks [20:45:32] according to https://www.mediawiki.org/wiki/Special:Version it's running a version of Flow from Oct 13th, certainly doesn't have my fix [20:46:26] Yeah but it should also be running an old version of MW core [20:46:32] so that your fix isn't neede [20:48:00] indeed [20:48:24] how can you tell if I83ea7e7336a1c9e64aa42284c2517089a736efe5 was backported or not? [20:51:28] stephanebisson: to see if it made it into the branch, click "Included in" for a list. to see if it was backported, paste the change-id into gerrit's search, it should give you all manual bakcports [20:53:44] It doesn't show as having been backported [20:53:44] thanks MatmaRex. If I did this right, I83ea7e7336a1c9e64aa42284c2517089a736efe5 made it into wmf/1.27.0-wmf.4 but was not backported manually. [20:58:44] You can also just click the Change-Id link. [20:59:54] 3Collaboration-Team-Current, 10Flow: An error has occurred while processing HTML/wikitext conversion - Fatal exception of type "Flow\Exception\WikitextException" - https://phabricator.wikimedia.org/T116685#1759391 (10Mattflaschen) We've done some steps on our side (including [no longer using RESTBase](https://... [21:02:14] 3Collaboration-Team-Current, 10Echo, 10Wikidata, 7Regression: Echo should not notify the user about his own linking activity - https://phabricator.wikimedia.org/T116485#1759401 (10Legoktm) The `LinksUpdateAfterInsert` hook that echo depended upon is now being deferred so `$wgUser` is wrong. [21:04:25] 3Collaboration-Team-Current, 10Echo, 10Wikidata, 7Regression: Echo should not notify the user about his own linking activity - https://phabricator.wikimedia.org/T116485#1759402 (10Legoktm) I'm guessing {1846e2dc15e957c557efad75f4e99f5a73c38aaa} caused this. [21:04:33] So annoying that DB name and wiki name are different in MediaWiki-vagrant. [21:09:54] matt_flaschen: help! my talk page doesn't take my responses [21:10:07] flow ate them ? [21:10:30] i post answers to people, but there are not save/not shown [21:11:34] matanya: They are saved but the page is displaying older versions from the cache. We are looking into this. Sorry about that. [21:12:06] thanks stephanebisson. So this is known ? [21:12:14] any phab # ? [21:13:46] matanya: It was known and fixed yesterday on beta (https://phabricator.wikimedia.org/T116582). I suspect it's happening for a different reason now. [21:14:23] oh well [21:15:08] matanya: I'm actually not sure it's the same thing but I'm looking at it. [21:15:15] thanks [21:20:00] 3Collaboration-Team-Current, 10Echo: Write presentation models for all notification types - https://phabricator.wikimedia.org/T116834#1759474 (10Catrope) 3NEW [21:20:01] 3Collaboration-Team-Current, 10Flow: Cannot reply to posts on mediawiki.org - https://phabricator.wikimedia.org/T116835#1759481 (10SBisson) 3NEW [21:20:57] AHA [21:21:15] stephanebisson: https://gerrit.wikimedia.org/r/#/c/248590/ [21:21:41] right... [21:21:48] Merged by Gilles around 2am Pacific this morning (about 12h ago) [21:21:51] dammit [21:21:55] OK then we do need to cherry-pick your change [21:22:38] RoanKattouw: can you swat it out? [21:22:49] I will [21:23:21] thanks! [21:24:07] We should have commented on the Gerrit that this affected us (unless they knew some other way). [21:24:47] Also, cherry-picking like that obviously means it's not traceable in the Gerrit interface. [21:24:49] Don't know if I should tell/remind ori of that. [21:25:10] 3Collaboration-Team-Current, 10Flow: Cannot reply to posts on mediawiki.org - https://phabricator.wikimedia.org/T116835#1759505 (10Catrope) This happened because https://gerrit.wikimedia.org/r/#/c/248590/ cherry-picked https://gerrit.wikimedia.org/r/#/c/248539/ stealthily (i.e. without Gerrit's normal lookups... [21:25:28] Yes [21:25:39] I'm gonna have a chat with him about out-of-schedule deployments in general [21:25:46] Because this is not the first time that team has broken our things [21:26:16] But yes we should have commented on Gerrit that it caused a regression in our code [21:26:31] shouldnt mw.o be on wmf.4 by now, anyway? [21:26:33] Although the cherry-pick sat around for a while, so I don't think that would have helped in this particular case [21:26:49] In theory yes, but for some reason wmf4 is only on testwiki now [21:26:54] when can i get my replies back then ? [21:26:55] kk [21:26:56] Maybe they just forgot part 2 of the train deploy [21:27:03] matanya: In a few minutes, I know what to do now [21:27:11] oh, great, thanks [21:27:21] so i am the first one to complain ? [21:27:38] matanya, it was a known issue, but we tried to prevent it from hitting MW.org, didn't work obviously. [21:27:58] happened on he.wiki [21:28:07] matanya: the other complaints were hidden because of the cache ;) [21:28:09] that is past wm.org [21:28:35] so it got to group 2 somehow [21:28:45] heh stephanebisson :) [21:28:53] matanya, yeah, you're right, if the train had rolled on schedule it actually wouldn't have affected mw.org, but because it was cherry-picked it affects Wikipedia (all wikis currently I think). [21:29:04] We didn't know about the core cherry-pick. [21:29:11] got it [21:29:42] 3rd breakge for me this week of part of a wiki [21:29:43] Yeah it was cherry-picked stealhily [21:29:46] *stealthily [21:30:01] Sorry. :( [21:30:04] (03PS1) 10Catrope: Fix cache key construction [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249299 (https://phabricator.wikimedia.org/T116582) [21:30:04] * matanya points at greg-g [21:30:16] (03CR) 10Catrope: [C: 032] Fix cache key construction [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249299 (https://phabricator.wikimedia.org/T116582) (owner: 10Catrope) [21:31:29] I think I hit my first Ruby WTF. [21:31:52] capitalize capitalizes the first letter, but *lower-cases* the other letters even if they were already capital. [21:32:26] Puppet stdlib inherits this "feature" [21:33:05] yeah, there's Capitalize, UPCASE and downcase [21:33:45] stephanebisson, I want 'selenium Flow user' => 'Selenium Flow user' (in reality, I'll just put it in correctly here, but it also needs to do admin => Admin, etc.) [21:34:23] these are cse-sensitive, right? [21:34:39] stephanebisson, except the first letter. [21:34:50] But I need to canonicalize the first letter to caps since it's like that in DB. [21:35:11] can you write them with the right case and not transform? [21:35:29] I don't really want to, since people will get it wrong. It's already 'admin' in the YAML (before my change). [21:35:51] I found http://stackoverflow.com/a/2647031/47773 . I'll use that if there's not a better way. [21:35:56] Checking if Puppet has a method for it. [21:36:07] So you want an equivalent of ucfirst in PHP? [21:36:11] Yes [21:38:39] Also, Ruby has a method to remove the last character, but not one for the first. [21:39:19] legoktm: I think https://phabricator.wikimedia.org/T116834?workflow=create is the full list. Do you think I should split that up in 32 subtasks (one per notif type), or 9 (one per extension), or not split it up at all? [21:40:55] RoanKattouw: lets do one per extension [21:41:26] mw.org seems to be fixed! [21:43:14] matt_flaschen: String#[] accepts a Range, so you can do `"foo"[1..-1]` [21:44:03] if you really want to mutate the string in place, you can do `str[0] = ''` [21:46:12] marxarelli, thanks. Puppet doesn't support reassigning variables anyway. I'll use that (plus capitalize on the individual character) and I'm sure someone will tell me if Puppet has a better way. [21:47:12] I don't see anything better in the Puppet docs so far. It can also be done in Ruby with slice!, but puppet doesn't export that. [21:47:22] OK [21:47:39] (03Merged) 10jenkins-bot: Fix cache key construction [extensions/Flow] (wmf/1.27.0-wmf.3) - 10https://gerrit.wikimedia.org/r/249299 (https://phabricator.wikimedia.org/T116582) (owner: 10Catrope) [21:48:41] mw.org seems to be fixed! <--- mw.o is on .wmf4 now. [21:48:45] matt_flaschen: are you trying to mutate the variable? [21:49:17] marxarelli, no, I can't in Puppet, and don't need to. [21:50:05] you can't in the Puppet lang, no. i thought you were trying to sidestep the protection in an erb template :) [21:50:16] I've also just cherry-picked Stephane's fix to wmf3 [21:50:22] <3 [21:50:30] So the disappearing post issue should be fixed on all wikis now [21:50:31] marxarelli, no, I feel a little weird about shelling into Ruby just for [1..-1], but still can't find anything in pure Puppet. [21:51:56] 3Collaboration-Team-Current, 10Flow: Cannot reply to posts on mediawiki.org - https://phabricator.wikimedia.org/T116835#1759698 (10Catrope) https://gerrit.wikimedia.org/r/#/c/249299/ is now deployed [21:52:02] 3Collaboration-Team-Current, 10Flow: Cannot reply to posts on mediawiki.org - https://phabricator.wikimedia.org/T116835#1759699 (10Catrope) a:3Catrope [21:52:52] RoanKattouw, confirmed. I can see recent posts on wikidata and hewiki, now. [21:52:55] what'd I do? [21:53:10] Nothing, you should just be aware because it's a deployment thing [21:53:12] nothing, this time! ;-) [21:53:13] <3 [21:53:14] matt_flaschen: did you try `$new_str = $str[1, -1]`? [21:53:24] There was a memcached-related change in master last week that broke something in a subtle way in Flow [21:53:30] matt_flaschen: https://docs.puppetlabs.com/puppet/latest/reference/lang_data_string.html#accessing-substrings [21:53:42] So we merged a fix into master for that as well, planning for it to ride the wmf4 train along with the thing that broke it [21:54:09] oh right, that [21:54:19] But then ~12h ago the breaking change was cherry-picked into wmf3 and deployed, outside of SWAT and in a way that made Gerrit's automatic cherry-pick knowledge not be aware of it [21:54:48] ahhhhhhhh [21:55:54] Thanks, marxarelli. I was thinking maybe it has slice syntax, but the slice function didn't mention it. Should have read that page, but time to ask and answer a Stack Overflow question. [21:56:05] Fourth result for https://www.google.com/search?q=%22puppet%22+string+remove+first+character is "Worlds of Shadow: Teaching with Shadow Puppetry" [21:56:23] None of the earlier results answer it, and the capitlalize docs don't mention Ruby's "feature". [21:56:36] matt_flaschen: no problem. that's from the 4.0 docs but hopefully it works in 3.x, too [21:56:51] marxarelli, ooh, better check. [22:01:13] greg-g: Per #wikimedia-perf , it turned out to be a communications failure (one person puts a cherry-pick into wmf3 just to see why it fails tests there, forgets to -2 it, other person sees it and deploys) [22:01:23] :( [22:01:25] suck [22:01:32] Anyways, that's all cleared up now [22:04:47] 3Collaboration-Team-Current, 10Echo: Write presentation models for notifications in Echo - https://phabricator.wikimedia.org/T116843#1759752 (10Catrope) 3NEW [22:07:12] 3Collaboration-Team-Current, 10Echo, 10Flow: Write presentation models for notification types in Flow - https://phabricator.wikimedia.org/T116845#1759772 (10Catrope) 3NEW [22:09:52] 3Collaboration-Team-Current, 10Echo, 10Thanks: Write presentation models for notification types in Thanks - https://phabricator.wikimedia.org/T116847#1759790 (10Catrope) 3NEW [22:10:49] 3Collaboration-Team-Current, 10Echo, 10Gather: Write presentation models for notification types in Gather - https://phabricator.wikimedia.org/T116848#1759798 (10Catrope) 3NEW [22:11:31] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-PageCuration: Write presentation models for notification types in PageTriage - https://phabricator.wikimedia.org/T116849#1759804 (10Catrope) 3NEW [22:12:22] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-EducationProgram: Write presentation models for notification types in EducationProgram - https://phabricator.wikimedia.org/T116850#1759815 (10Catrope) 3NEW [22:13:32] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-BounceHandler: Write presentation model for BounceHandler - https://phabricator.wikimedia.org/T116851#1759824 (10Catrope) 3NEW [22:16:31] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-ContentTranslation: Write presentation models for notifications in ContentTranslation - https://phabricator.wikimedia.org/T116852#1759842 (10Catrope) 3NEW [22:16:58] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-OpenStackManager: Write presentation models for notifications in OpenStackManager - https://phabricator.wikimedia.org/T116853#1759848 (10Catrope) 3NEW [22:17:45] 3Collaboration-Team-Current, 10Echo, 10Thanks: Write presentation models for notifications in Thanks - https://phabricator.wikimedia.org/T116847#1759861 (10Catrope) [22:17:51] 3Collaboration-Team-Current, 10Echo, 10Gather: Write presentation models for notifications in Gather - https://phabricator.wikimedia.org/T116848#1759863 (10Catrope) [22:17:56] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-PageCuration: Write presentation models for notifications in PageTriage - https://phabricator.wikimedia.org/T116849#1759865 (10Catrope) [22:18:04] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-EducationProgram: Write presentation models for notifications in EducationProgram - https://phabricator.wikimedia.org/T116850#1759867 (10Catrope) [22:18:49] marxarelli, doesn't work, just for your future reference. We're running Puppet 3.4.3 in MWV: [22:18:57] Filing these tasks has made me wonder how the hell one would test a change to notifications in OpenStackManager [22:18:59] $canonical_username = capitalize($username[0]) + $username[1,-1] [22:19:25] RoanKattouw, spin up an instance to put in Jenkins job pool... Sh** [22:19:37] Inception! :) [22:20:01] matt_flaschen: oh, drats [22:20:28] marxarelli, no worries, I'll do it the Ruby way. [22:20:30] Error: Syntax error at ','; expected ']' at /vagrant/puppet/modules/mediawiki/manifests/user.pp:53 on node mediawiki-vagrant.dev [22:24:24] 3Collaboration-Team-Current, 10Echo, 10MediaWiki-extensions-OpenStackManager: Write presentation models for notifications in OpenStackManager - https://phabricator.wikimedia.org/T116853#1759881 (10Krenair) Honestly I don't think build and reboot notifications work at all any more. Used to be triggered by a m... [22:43:18] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review, 5WMF-deploy-2015-10-27_(1.27.0-wmf.4): Deleted topics deleted edits shouldn't appear in recent changes - https://phabricator.wikimedia.org/T116058#1759989 (10Etonkovidova) Checked in betalabs - topic 'Sep25-02' was deleted from 'Talk:ET46' 1) History... [22:59:06] 3Collaboration-Team-Current, 10Flow: Make sure mw-vagrant Flow role creates users/groups required for Flow browser tests - https://phabricator.wikimedia.org/T115515#1760062 (10Mattflaschen) a:3Mattflaschen [23:05:09] 3Collaboration-Team-Current, 10Flow, 5Patch-For-Review: Stop falling back to PHP parser if a specific Parsoid call fails - https://phabricator.wikimedia.org/T116699#1760108 (10Mattflaschen) I didn't mean to move this to Blocked. [23:11:09] mooeypoo: What's next for https://phabricator.wikimedia.org/T113881 [23:11:11] ? [23:11:54] matt_flaschen: Can we tell Jaime we're ready for https://phabricator.wikimedia.org/T109676 , or is there something we need to wait for there? [23:14:13] RoanKattouw, no, I'll go ahead and tell him. [23:15:33] RoanKattouw, I also need to rebase. [23:16:42] RoanKattouw, the message panel can now be closed with the badge, but not when you click outside of it -- for that, we need to sort out what event to have the popup widget listen to. "click" or "touchstart" or whatever [23:16:54] RoanKattouw, https://gerrit.wikimedia.org/r/#/c/244592/ [23:17:39] (03PS1) 10Legoktm: Fix page-linked notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249318 (https://phabricator.wikimedia.org/T116485) [23:17:56] RoanKattouw, did you test it earlier? If not, I should do that as well. [23:19:16] Eh, I'll retest anyway. [23:19:46] (03PS4) 10Mattflaschen: Add artificial primary key to flow_wiki_ref and flow_ext_ref [extensions/Flow] - 10https://gerrit.wikimedia.org/r/238393 (https://phabricator.wikimedia.org/T109676) (owner: 10Matthias Mullie) [23:42:08] matt_flaschen: No, I don't think I've ever tested it [23:42:58] (03CR) 10Catrope: [C: 032] Stop reading from DB_MASTER [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247575 (https://phabricator.wikimedia.org/T94028) (owner: 10Matthias Mullie) [23:45:40] (03Merged) 10jenkins-bot: Stop reading from DB_MASTER [extensions/Flow] - 10https://gerrit.wikimedia.org/r/247575 (https://phabricator.wikimedia.org/T94028) (owner: 10Matthias Mullie) [23:46:01] (03CR) 10Catrope: [C: 032] Fix page-linked notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249318 (https://phabricator.wikimedia.org/T116485) (owner: 10Legoktm) [23:46:51] err wait [23:47:09] RoanKattouw: core patch hasn't been merged yet [23:47:15] I canceled your +2 [23:47:21] I know, but it won't break without that, will it? [23:47:22] It has b/c code [23:47:57] yeah, but I'd like to make sure the core patch goes through with that function using that name, etc. [23:48:05] OK, yeah that makes sense [23:48:21] (03CR) 10Catrope: [C: 031] "OK to merge this when the core patch is merged" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/249318 (https://phabricator.wikimedia.org/T116485) (owner: 10Legoktm) [23:48:32] Did you see Aaron's comment? [23:48:34] yes [23:48:39] I'm just finishing testing it locally